rcserver: avoid generating default credentials with htpasswd - fixes #4839

This commit is contained in:
Kamui 2022-11-14 09:26:44 -06:00 committed by GitHub
parent 0ac5795f8c
commit efd3c6449b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -97,11 +97,11 @@ func newServer(ctx context.Context, opt *rc.Options, mux *http.ServeMux) *Server
if opt.NoAuth {
fs.Logf(nil, "It is recommended to use web gui with auth.")
} else {
if opt.HTTPOptions.BasicUser == "" {
if opt.HTTPOptions.BasicUser == "" && opt.HTTPOptions.HtPasswd == "" {
opt.HTTPOptions.BasicUser = "gui"
fs.Infof(nil, "No username specified. Using default username: %s \n", rcflags.Opt.HTTPOptions.BasicUser)
}
if opt.HTTPOptions.BasicPass == "" {
if opt.HTTPOptions.BasicPass == "" && opt.HTTPOptions.HtPasswd == "" {
randomPass, err := random.Password(128)
if err != nil {
log.Fatalf("Failed to make password: %v", err)