From feaa20d885ffa337cf7240a662ce3e5b05429a85 Mon Sep 17 00:00:00 2001 From: Nick Craig-Wood Date: Tue, 29 Aug 2023 12:58:05 +0100 Subject: [PATCH] build: re-enable revive linters In this commit: 75dfdbf211593cea ci: revert revive settings back to fix lint We accidentally disabled all the revive linters. Unfortunately setting the rules clears the default set of rules so it is necessary to mention all rules that we need. --- .golangci.yml | 52 +++++++++++++++++++++++++++++++++++++++++++++++---- 1 file changed, 48 insertions(+), 4 deletions(-) diff --git a/.golangci.yml b/.golangci.yml index c241475ce..0d61df700 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -33,23 +33,67 @@ issues: - staticcheck text: 'SA1019: "github.com/rclone/rclone/cmd/serve/httplib" is deprecated' + # don't disable the revive messages about comments on exported functions + include: + - EXC0012 + - EXC0013 + - EXC0014 + - EXC0015 + run: # timeout for analysis, e.g. 30s, 5m, default is 1m timeout: 10m linters-settings: revive: + # setting rules seems to disable all the rules, so re-enable them here rules: - - name: unreachable-code - disabled: true - - name: unused-parameter - disabled: true + - name: blank-imports + disabled: false + - name: context-as-argument + disabled: false + - name: context-keys-type + disabled: false + - name: dot-imports + disabled: false - name: empty-block disabled: true + - name: error-naming + disabled: false + - name: error-return + disabled: false + - name: error-strings + disabled: false + - name: errorf + disabled: false + - name: exported + disabled: false + - name: increment-decrement + disabled: true + - name: indent-error-flow + disabled: false + - name: package-comments + disabled: false + - name: range + disabled: false + - name: receiver-naming + disabled: false - name: redefines-builtin-id disabled: true - name: superfluous-else disabled: true + - name: time-naming + disabled: false + - name: unexported-return + disabled: false + - name: unreachable-code + disabled: true + - name: unused-parameter + disabled: true + - name: var-declaration + disabled: false + - name: var-naming + disabled: false stylecheck: # Only enable the checks performed by the staticcheck stand-alone tool, # as documented here: https://staticcheck.io/docs/configuration/options/#checks