8 Commits

Author	SHA1	Message	Date
nielash	e053c8a1c0	copy: fix nil pointer dereference when corrupted on transfer with nil dst	2024-04-02 15:34:58 +01:00
Nick Craig-Wood	7c828ffe09	operations: fix very long file names when using copy with --partial ... Before this change we were using the wrong variable to read the filename length from. This meant that very long filenames were not being truncated as intended. This problem was spotted by Wang Zhiwei on the forum in a code review. See: https://forum.rclone.org/t/why-use-c-remoteforcopy-instead-of-c-remote-to-check-length-in-copy-operation/45099	2024-03-30 09:06:58 +00:00
Lewis Hook	bf494d48d6	Improve error messages when objects have been corrupted on transfer - fixes #5268	2024-03-23 12:35:35 +00:00
Nick Craig-Wood	91b54aafcc	rc: add srcFs and dstFs to core/stats and core/transferred stats ... Before this change it wasn't possible to see where transfers were going from and to in core/stats and core/transferred. When use in rclone mount in particular this made interpreting the stats very hard.	2024-02-02 11:43:10 +00:00
Nick Craig-Wood	23ab6fa3a0	operations: fix server side copies on partial upload backends after refactor ... After the copy refactor: 179f978f75 operations: refactor Copy into methods on an temporary object There was some confusion in the code about server side copies - should they or shouldn't they use partials? This manifested in unit test failures for remotes which supported server side Copy and PartialUploads. This combination is rare and only exists in the sftp backend with the --sftp-copy-is-hardlink flag. This fix makes the choice that backends which set PartialUploads always use partials even for server side copies.	2023-10-30 16:50:19 +00:00
Nick Craig-Wood	e64be7652a	operations: fix invalid UTF-8 when truncating file names when not using --inplace ... Before this change, when not using --inplace, rclone could generate invalid file names when truncating file names to fit within the character size limits. This fixes it by taking care to truncate on UTF-8 character boundaries. See: https://forum.rclone.org/t/ssh-fx-failure-when-copying-file-with-nonstandard-characters-to-sftp-remote-with-ntfs-drive/42560/	2023-10-29 14:04:37 +00:00
Nick Craig-Wood	179f978f75	operations: refactor Copy into methods on an temporary object ... operations.Copy had become very unwieldy. This refactors it into methods on a copy object which is created for the duration of the copy. This makes it much easier to read and reason about.	2023-10-29 14:04:37 +00:00
Nick Craig-Wood	17b7ee1f3a	operations: factor Copy into its own file	2023-10-29 14:04:37 +00:00