Daniel Shahaf
693de99a90
comments: Fix issue #163 and #167 : Highlight comments.
2015-10-30 08:38:44 +02:00
Daniel Shahaf
e76f208cf8
comments: Add a PASSing test for the NO_INTERACTIVE_COMMENTS case.
2015-10-30 08:38:39 +02:00
Daniel Shahaf
e9ceb2017e
comments: Add XFail tests from issues #163 and #167 .
...
These tests are based on the patches contributed in those issues:
commit 9d9df4fe80
(upstream/pr/167)
Author: Miciah Masters <miciah.masters@gmail.com>
AuthorDate: Thu Apr 23 20:28:24 2015 -0400
Commit: Miciah Dashiel Butler Masters <mmasters@redhat.com>
CommitDate: Thu Apr 23 20:28:24 2015 -0400
Highlight comments
M highlighters/main/main-highlighter.zsh
A highlighters/main/test-data/comments.zsh
commit d94f1a037f
(upstream/pr/163)
Author: sonnym <michaud.sonny@gmail.com>
AuthorDate: Fri Mar 6 18:27:57 2015 -0500
Commit: sonnym <michaud.sonny@gmail.com>
CommitDate: Fri Mar 6 21:16:27 2015 -0500
highlight comments when interactive_comments is on
M highlighters/main/main-highlighter.zsh
A highlighters/main/test-data/comment-embedded.zsh
A highlighters/main/test-data/comment-leading.zsh
Patch-by: sonnym <michaud.sonny@gmail.com>
Patch-by: Miciah Masters <miciah.masters@gmail.com>
(corrected and refreshed for harness changes by me)
2015-10-29 18:08:30 +02:00
Daniel Shahaf
2f05620b19
sudo: Flag an error when a required argument is missing.
2015-10-29 12:01:13 +00:00
Daniel Shahaf
9cb87473cc
sudo: Tweak state computations.
...
This causes the ':start:' state to be set in $next_word in iteration N-1,
rather than to only be added to $this_word in iteration N.
2015-10-29 12:01:13 +00:00
Daniel Shahaf
f49f3bf0c0
sudo: Extend tests.
2015-10-29 12:01:13 +00:00
Daniel Shahaf
a3047a9121
sudo: Highlight an empty sudo;
as an error.
...
The word following 'sudo' was considered :regular:, although it isn't.
2015-10-29 12:01:13 +00:00
Daniel Shahaf
86e9249709
sudo/redirections: Fix remaining part of issue #221 , "sudo and redirection don't mix".
2015-10-29 12:01:13 +00:00
Daniel Shahaf
0d1bfbcbfa
Highlight subshells and anonymous functions correctly.
...
Fixes zsh-users/zsh-syntax-highlighting#166.
Fixes zsh-users/zsh-syntax-highlighting#194.
Builds upon the issue #207 work.
2015-10-29 12:01:13 +00:00
Daniel Shahaf
c216242b46
command word: Highlight more reserved words. Part of issue #207 .
2015-10-29 12:01:13 +00:00
Daniel Shahaf
2218e26bf8
command word: Highlight 'else' correctly. Part of issue #207 .
2015-10-29 12:01:13 +00:00
Daniel Shahaf
b397b12ac1
command word: Start fixing issue #207 , "Word following certain reserved words should be a command word".
2015-10-29 12:01:13 +00:00
Daniel Shahaf
87deac3062
command word: Add an XFail test for issue #207 .
2015-10-29 12:01:13 +00:00
Daniel Shahaf
01d7eeb3c7
Fix issue #205 , "';' after assignment is highlighted as unknown-token".
2015-10-29 12:01:13 +00:00
Daniel Shahaf
6d6fb8b03e
redirections: Document handling of redirections and possibly fix a latent bug.
...
The change of behaviour is triggered by test-data/sudo-redirection.zsh: the iteration
on "otheruser" sets $next_word to ":regular::sudo_opt::start::sudo_opt::start:" before
this patch, but to ":regular::sudo_opt::start:" after it (note the deduplication).
2015-10-29 12:01:13 +00:00
Daniel Shahaf
be006aded5
sudo/redirections: Fix part of issue #221 , "sudo and redirection don't mix".
2015-10-29 12:01:11 +00:00
Daniel Shahaf
c6355a31b7
Followup to last: re-fix issue #9 and add test for it.
...
The fix for issue #9 was accidentally broken by the penultimate commit.
Note that we don't care about aliases to ZSH_HIGHLIGHT_TOKENS_COMMANDSEPARATOR
entries, since the code deals with aliases at command position.
2015-10-29 12:01:11 +00:00
Daniel Shahaf
018bc45f21
Followup to last: tighten the fix and ask a question.
2015-10-29 12:01:11 +00:00
Daniel Shahaf
2c9f8c8c95
Fix issue #209 , "precommand modifiers at non-command-word position".
2015-10-29 12:01:11 +00:00
Daniel Shahaf
88cf98d9c4
states work: Documents the various states.
2015-10-29 12:01:11 +00:00
Daniel Shahaf
0aa6a5db78
states work: Convert $new_expression parsing.
2015-10-29 12:01:11 +00:00
Daniel Shahaf
10b1da64e6
states work: Convert sudo parsing.
2015-10-29 12:01:11 +00:00
Daniel Shahaf
80d692c400
command word: Add an XFail test for issue #194 , "Highlight anonymous functions".
2015-10-29 12:01:11 +00:00
Daniel Shahaf
e49251b6fa
sudo/redirections: Add two XFail tests for issue #221 , "sudo and redirection don't mix".
2015-10-29 12:01:09 +00:00
Daniel Shahaf
2080a441ac
minor: Remove redundant setting of $highlight_glob.
2015-10-28 09:58:13 +02:00
Daniel Shahaf
59fbdda64c
main: Refresh highlighting upon accept-* widgets (accept-line et al).
...
Use this to remove [path_prefix] highlighting during accept-* widgets.
This causes ": file.tx<CR>" to remove the underline from "file.tx", like
": file.tx<SPACE>" already does. (Assume 'file.txt' exists.)
2015-10-28 09:24:08 +02:00
Daniel Shahaf
7723edf4f5
Add an XFail test for accept-line semantics.
2015-10-28 08:30:05 +02:00
Daniel Shahaf
feec9f58c9
Followup to last: Fix issue number in comment.
2015-10-27 13:38:40 +02:00
Daniel Shahaf
ed6d229b1c
Add XFail test for issue #208 , 'precommand modifiers at non-command-word position'.
2015-10-27 12:33:11 +02:00
Daniel Shahaf
fb5ce43799
noop: Rename a local variable for clarity.
2015-10-27 11:59:25 +02:00
Daniel Shahaf
9816fcf055
redirections: Test an infix redirection.
2015-10-27 05:20:24 +00:00
Daniel Shahaf
871af68082
sudo: Extend test to cover all codepaths.
2015-10-27 05:09:13 +00:00
Daniel Shahaf
98aee7f8b9
Remove path_approx.
...
Fixes zsh-users/zsh-syntax-highlighting#187 .
Adds a test for zsh-users/zsh-syntax-highlighting#204 .
2015-10-27 04:29:05 +00:00
Daniel Shahaf
20d106bd4d
noop: Associate an XFAIL test with its issue.
2015-10-23 04:57:05 +00:00
Daniel Shahaf
d66113c1ed
Add XFAIL test for issue #205 , "';' highlighted as unknown-token".
2015-10-23 04:56:02 +00:00
Daniel Shahaf
728ed66ff9
Fix copyright year.
...
Followup to b2ac98b981
.
2015-10-23 04:53:06 +00:00
Daniel Shahaf
11c060ab76
test harness: Fix a bug whereby 'todo' state would propagate to all subsequent test points.
...
Update expectations on the subshell test (which triggered this bug, since it has
a passing test point following a 'todo' test point).
2015-10-23 04:26:51 +00:00
Daniel Shahaf
b2ac98b981
Fix issue #216 : test failure with HOME=/nonexistent.
...
Make the test pass by setting explicitly the global state (existing $HOME) it
depends on. Test another value of the global state (a non-existing $HOME).
2015-10-23 03:51:06 +00:00
Antony Lee
22c8736e2b
Add XFAIL test for issue #160 , "subshells highlighted incorrectly".
2015-10-23 03:31:00 +00:00
Daniel Shahaf
c687bddea3
Drop unnecessary shebang lines, part 2.
...
Follow-up to the last commit.
E: zsh-syntax-highlighting: missing-dep-for-interpreter zsh => zsh | zsh-beta (usr/share/zsh-syntax-highlighting/highlighters/main/main-highlighter.zsh)
W: zsh-syntax-highlighting: executable-not-elf-or-script usr/share/zsh-syntax-highlighting/highlighters/main/main-highlighter.zsh
2015-10-20 12:06:07 +00:00
Daniel Shahaf
c30301d474
Drop unnecessary shebang lines.
...
All these files should be sourced, not executed; and Debian's lintian complains:
W: zsh-syntax-highlighting: script-not-executable usr/share/zsh-syntax-highlighting/zsh-syntax-highlighting.zsh
2015-10-20 11:49:51 +00:00
Daniel Shahaf
e138cfd765
command word: Protect against the case that the command word starts with a minus.
2015-10-02 13:27:21 +00:00
Daniel Shahaf
07fd773d7e
noop: Add comments.
2015-09-30 01:26:27 +00:00
Daniel Shahaf
5cd1fb26c0
Resolve tilde expansions in command word.
...
This causes '~/bin/foo' to highlight as a command, rather than as a file.
Part of issue #201 .
2015-09-30 00:49:34 +00:00
Daniel Shahaf
faed2fa49e
internal: Fix docstrings.
2015-09-29 23:45:44 +00:00
Daniel Shahaf
69203b1a1d
Don't highlight escaped globbing.
...
Fixes zsh-users/zsh-syntax-highlighting#193 .
2015-09-29 23:44:57 +00:00
Daniel Shahaf
800158745a
Highlight quoted command words correctly.
...
Fixes zsh-users/zsh-syntax-highlighting#147 .
2015-09-28 19:49:39 +00:00
Daniel Shahaf
7b4598a764
Highlight arithmetic expansions.
...
Fixes zsh-users/zsh-syntax-highlighting#188 in the case that both the
opening '((' and closing '))' have been typed, The case that only the
opening '((' have been typed is also fixed, but requires a zsh development
build (zsh-5.1.1-52-g4bed2cf or newer); see comments within.
2015-09-28 13:55:38 +00:00
Daniel Shahaf
52a2ef644b
Don't highlight escaped globbing.
...
Fixes zsh-users/zsh-syntax-highlighting#193 .
2015-09-27 16:28:32 +00:00
Daniel Shahaf
6488284814
back-dollar-quoted-argument: Highlight incomplete escape sequences as unknown-token
...
Followup to 219184f046
, which fixed issue #196 .
2015-09-27 15:59:04 +00:00
Daniel Shahaf
f657406159
minor: Fix comment in last ocmmit.
2015-09-26 18:59:16 +00:00
Daniel Shahaf
8b728522de
Add test for empty commands.
...
Related to issue #205 .
2015-09-26 18:28:56 +00:00
Daniel Shahaf
79e8c2dd48
Don't highlight syntax elements as paths.
...
Without this, redirections, history expansions, and command separators would
be matched by path_approx.
A test case is simply LBUFFER="<" RBUFFER="" (highlighted as redirection with this
fix and as path_approx without it).
Fixes zsh-users/zsh-syntax-highlighting#204 .
2015-09-26 18:28:48 +00:00
Daniel Shahaf
4ec821b2b1
Highlight redirections.
...
Fixes zsh-users/zsh-syntax-highlighting#23 .
* danielsh/i23-highlight-redirections:
Highlight redirections.
2015-09-26 17:58:07 +00:00
Daniel Shahaf
6732783d46
back-dollar-quoted-argument: Correct an off-by-one.
...
Highlight the last character of a «\xHH» escape when it is the last thing in
LBUFFER. This is similar to what b0cc02ed86
did
for issue #186 .
2015-09-26 01:09:37 +00:00
Daniel Shahaf
0788514cbd
back-dollar-quoted-argument: Correct octal escape syntax.
...
A leading zero, as in '\0NNN', is permitted by 'echo' but not by 'print',
and «$''» follows 'print'.
2015-09-25 21:54:37 +00:00
Daniel Shahaf
8a43bd2cd9
back-dollar-quoted-argument: Highlight \uHHHH and \UHHHHHHHH escapes.
2015-09-25 21:45:38 +00:00
Daniel Shahaf
98366ade11
back-dollar-quoted-argument: Don't consider \0xHH a hex escape sequence.
...
A leading zero is not permitted in the '\xHH' syntax.
2015-09-25 21:45:38 +00:00
Daniel Shahaf
78ad649d47
back-dollar-quoted-argument: Don't consider comma a hex character.
...
Character class syntax does not ignore commas between ranges.
2015-09-25 21:45:38 +00:00
Daniel Shahaf
69fcb40275
Highlight backslash escapes within $'' strings.
...
Correct highlighting of backslash escapes within "" strings: highlight only
the four specific escape sequences defined there.
Fixes zsh-users/zsh-syntax-highlighting#196 .
2015-09-25 21:45:38 +00:00
Daniel Shahaf
f4164ac86c
internal: Document a function-local variable.
2015-09-25 21:22:09 +00:00
Daniel Shahaf
9c7a1109c8
WARN_CREATE_GLOBAL: don't leak the arithmetic for loop's index variable.
...
Found by code inspection; WARN_CREATE_GLOBAL missed this.
2015-09-25 20:57:51 +00:00
Daniel Shahaf
040df93c01
Highlight redirections.
...
Fixes zsh-users/zsh-syntax-highlighting#23 .
2015-09-25 12:42:34 +00:00
Daniel Shahaf
66eb801358
dollar-double-quoted-argument: Handle «"foo$"» correctly.
2015-09-24 19:03:17 +00:00
Daniel Shahaf
b0cc02ed86
dollar-double-quoted-argument: Highlight "$foo" better.
...
Now, «"$42foo"» doesn't highlight the «foo», and «"$bar» highlights the «r».
2015-09-24 19:03:00 +00:00
Daniel Shahaf
908c4fe150
Stop leaking variables into global namespace.
...
Set WARN_CREATE_GLOBAL to prevent recurrence.
Fixes zsh-users/zsh-syntax-highlighting#192 .
2015-09-24 18:01:06 +00:00
Daniel Shahaf
9e80fe8f02
Bump copyright years.
2015-09-24 16:46:28 +00:00
Daniel Shahaf
001e6cb404
tests: Cover 'back-quoted-argument'.
...
This is part of issue zsh-users/zsh-syntax-highlighting#198 .
2015-09-23 15:41:17 +00:00
Daniel Shahaf
22fa215e05
Fixup last commit.
...
* highlighters/main/test-data/hashed-command.zsh:
Set the right region key. This makes the test more specific.
(Issue #184 would have caught this bug.)
2015-09-23 15:39:53 +00:00
Daniel Shahaf
845361ef3d
tests: Cover 'hashed-command'.
...
This is part of issue zsh-users/zsh-syntax-highlighting#198 .
2015-09-23 15:35:56 +00:00
Daniel Shahaf
4594d8b7ec
Merge remote-tracking branch 'danielsh/i199-semicolon-v1'
...
* danielsh/i199-semicolon-v1:
Fix regression: Highlight ';' as commandseparator.
Follow-up to 547b8be30461: Fix $observed_result calculation.
Fixes zsh-syntax-highlghting/zsh-users#199 .
2015-09-23 15:23:25 +00:00
Daniel Shahaf
5fb4cb2f72
Fix regression: Highlight ';' as commandseparator.
...
This was broken by c2b9327b07
and tracked as zsh-users/zsh-syntax-highlighting#199 .
This fixes the vanilla-newline.zsh test, which was was (consciously) broken
by the previous commit.
2015-09-23 14:50:22 +00:00
Daniel Shahaf
f7cb4741d6
Followup to previous: Extend the 'alias' test.
2015-09-18 22:04:07 +00:00
Daniel Shahaf
81c8d78d12
tests: Cover 'alias' and 'suffix-alias'.
...
This is part of issue zsh-users/zsh-syntax-highlighting#198 .
2015-09-18 21:42:22 +00:00
Daniel Shahaf
8767e0ef66
tests: Cover 'reserved-word'.
...
This is part of issue zsh-users/zsh-syntax-highlighting#198 .
2015-09-18 20:38:32 +00:00
Daniel Shahaf
b056f592f2
tests: Cover 'path_prefix'.
...
This is part of issue zsh-users/zsh-syntax-highlighting#198 .
2015-09-18 20:21:19 +00:00
Daniel Shahaf
e0a7ddb6ec
tests: Cover 'history-expansion'.
...
This is part of issue zsh-users/zsh-syntax-highlighting#198 .
2015-09-18 20:01:10 +00:00
Daniel Shahaf
416934202e
tests: Cover 'single-quoted-argument', 'double-hyphen-option', and 'function'.
...
This is part of issue zsh-users/zsh-syntax-highlighting#198 .
2015-09-18 19:21:21 +00:00
Daniel Shahaf
627eb71940
tests: Use $unused_highlight in more places.
...
Notably, the 'single-hyphen-option' and 'assign' contexts both default to the
'none' style, so before this patch, the tests would not have detected a failure
to apply those two contexts.
For other contexts, using $unused_highlight only helps detect the case where
the right highlight style (e.g., 'fg=yellow') is used as a result of applying
the wrong context — which should be a theoretical failure mode.
This is part of zsh-users/zsh-syntax-highlighting#198 .
2015-09-18 18:44:45 +00:00
Daniel Shahaf
404d498e1d
tests: vanilla-newline.zsh: Fix expectations
2015-09-17 23:33:56 +00:00
Daniel Shahaf
0d3a5dadea
tests: Add test for escape sequences in double-quoted strings
2015-09-17 20:01:46 +00:00
Daniel Shahaf
186536705b
tests: path-tilde-named.zsh: Fix expectations
...
The path string ends at offset 26, not 23.
2015-09-17 19:09:33 +00:00
Daniel Shahaf
547b8be304
test harness: Fix off-by-one discrepancy between observed and expected.
...
Fixes zsh-users/zsh-syntax-highlighting#195 .
The one revision made on master between this branch's creation and merge
already uses correct offsets.
* danielsh/i195-tests-offbyone-v1:
New test for dollar-double-quoted-argument.
test harness: Fix off-by-one discrepancy between observed and expected.
2015-09-17 19:08:29 +00:00
Daniel Shahaf
80587e5419
New test for dollar-double-quoted-argument.
...
This exercises the previous patch.
2015-09-12 20:48:25 +00:00
Daniel Shahaf
c46b8d169e
test harness: Fix off-by-one discrepancy between observed and expected.
...
Fixes issue #195 .
2015-09-12 20:48:25 +00:00
Daniel Shahaf
a8afbdf2f5
Support $''-quoted strings.
...
This does not yet highlight backslash escapes within them.
2015-09-10 20:02:39 +00:00
Daniel Shahaf
6d93ea07fd
main highlighter docs: README: Tweak.
2015-09-10 19:46:01 +00:00
Daniel Shahaf
4f5a0fe60b
main highlighter docs: Give examples of styles.
2015-09-10 19:44:19 +00:00
Daniel Shahaf
555e142e66
suffix aliases: Highlight differently.
...
Add an underline, since they are at command word position but will be executed
by something else.
Suggested-by: Daniel Hahler
2015-09-08 10:13:16 +00:00
Daniel Shahaf
e13c5a1611
Highlight 'noglob' correctly in more cases.
...
Fixes zsh-users/zsh-syntax-highlighting#189 .
2015-09-07 18:07:59 +00:00
Daniel Shahaf
8515b7e0c5
Highlight ? as globbing.
...
Fixes zsh-users/zsh-syntax-highlighting#94 .
2015-09-07 18:05:56 +00:00
Daniel Shahaf
dc701501e5
Highlight ? as globbing.
...
Fixes zsh-users/zsh-syntax-highlighting#94 .
2015-09-07 18:03:14 +00:00
Daniel Shahaf
9310d8ae71
Support suffix aliases
...
Fixes zsh-users/zsh-syntax-highlighting#126 .
2015-09-07 17:59:52 +00:00
Daniel Shahaf
b3ceea8511
Highlight 'noglob' correctly in more cases.
...
Fixes zsh-users/zsh-syntax-highlighting#189 .
2015-09-07 09:09:17 +00:00
Daniel Shahaf
a0b5bc6c71
Fix bug in previous commit ( d330b49b33
)
...
'local' is a reserved word in zsh 5.1 but not in earlier versions [1].
Therefore, under zsh older than 5.1, quoting is required.
This manifested as random «builtin=''» in emitted to the terminal, and
commands (such as 'echo') highlighted as errors (in red).
[1] https://github.com/zsh-users/zsh/blob/master/README#L46
(the section "Incompatibilites between 5.0.8 and 5.1")
2015-09-07 01:26:11 +00:00
Daniel Shahaf
d330b49b33
Fix variable leakage into global namespace.
...
Similar to zsh-users/zsh-syntax-highlighting#97 .
2015-09-06 19:20:49 +00:00
Daniel Shahaf
546a5288e2
multiline strings: Add a second test for commit ff4d402e9a
2015-09-05 15:08:08 +00:00
Daniel Shahaf
7f41967a17
Highlight array appends: foo+=(bar baz).
...
Fixes zsh-users/zsh-syntax-highlighting#181 .
2015-09-05 09:38:02 +00:00
Daniel Shahaf
51aed8a765
Merge remote-tracking branch 'upstream/pr/179'
...
* upstream/pr/179:
Don't parse first word of array assignment as command
2015-09-04 17:57:08 +00:00
Daniel Shahaf
42495cc5d6
Merge remote-tracking branch 'upstream/pr/161'
...
* upstream/pr/161:
Don't highlight prefix redirections as error
2015-09-04 17:27:25 +00:00