Tweak some comments

This commit is contained in:
Matthew Holt 2022-09-21 12:59:40 -06:00
parent 1426c97da5
commit 9206e8a738
2 changed files with 3 additions and 2 deletions

View File

@ -170,9 +170,10 @@ func (rr *responseRecorder) WriteHeader(statusCode int) {
return
}
// save statusCode in case http middleware upgrading websocket
// save statusCode always, in case HTTP middleware upgrades websocket
// connections by manually setting headers and writing status 101
rr.statusCode = statusCode
// 1xx responses aren't final; just informational
if statusCode < 100 || statusCode > 199 {
rr.wroteHeader = true

View File

@ -239,7 +239,7 @@ func (s *Server) ServeHTTP(w http.ResponseWriter, r *http.Request) {
return
}
repl.Set("http.response.status", wrec.Status())
repl.Set("http.response.status", wrec.Status()) // will be 0 if no response is written by us (Go will write 200 to client)
repl.Set("http.response.size", wrec.Size())
repl.Set("http.response.duration", duration)
repl.Set("http.response.duration_ms", duration.Seconds()*1e3) // multiply seconds to preserve decimal (see #4666)