github-mirror/discourse
github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-23 03:39:39 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

UX: Fix deselect text location in edit sidebar category/tag modal (#23966)

Browse Source 
Why this change?

In 38d32080274a864580c86827e98ab1de914269a5, the position of the
`headerBelowTitle` outlet was changed causing the deselect text in the
edit sidebar catgegory/tag modals to appear inline with the title which
we do not want.

What does this change do?

This change introduces the `belowModalTitle` outlet in `DModal` which is
where the `headerBelowTitle` outlet was located before it was changed.
This commit is contained in:
Alan Guo Xiang Tan 2023-10-18 11:33:35 +08:00 committed by GitHub
parent 8c355d9e99
commit 3c26df78ea
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/assets/javascripts/discourse/app/components/d-modal.hbs
View File

@ -56,6 +56,8 @@
{{/if}}
</div>
{{/if}}
{{yield to="belowModalTitle"}}
</div>
{{yield to="headerBelowTitle"}}

4
app/assets/javascripts/discourse/app/components/sidebar/edit-navigation-menu/modal.hbs
View File

@ -3,7 +3,7 @@
@title={{i18n @title}}
@closeModal={{@closeModal}}
>
<:headerBelowTitle>
<:belowModalTitle>
<p class="sidebar__edit-navigation-menu__deselect-wrapper">
<DButton
@label="sidebar.edit_navigation_modal_form.deselect_button_text"
@ -14,7 +14,7 @@
{{@deselectAllText}}
</p>
</:headerBelowTitle>
</:belowModalTitle>
<:belowHeader>
<div class="sidebar__edit-navigation-menu__filter">