Revert "DEV: Output failing MF keys when compilation fails" (#29199)

This reverts commit aedfb12eda.
This commit is contained in:
Jeff Wong 2024-10-15 09:37:44 +09:00 committed by GitHub
parent 28141388fb
commit 745bc9ffa3
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 1 additions and 20 deletions

View File

@ -163,17 +163,7 @@ module JsLocaleHelper
require("discourse-mf");
JS
rescue => e
message_formats[locale.to_s]
.filter_map do |key, value|
next if MessageFormat.compile(locale, value, strict: false)
rescue StandardError
key
end
.then do |strings|
Rails.logger.error(
"Failed to compile message formats for #{locale}.\n\nBroken strings are: #{strings.join(", ")}\n\nError: #{e}",
)
end
Rails.logger.error("Failed to compile message formats for #{locale} '#{e}'")
<<~JS
console.error("Failed to compile message formats for #{locale}. Some translation strings will be missing.");
JS

View File

@ -169,10 +169,8 @@ RSpec.describe JsLocaleHelper do
let(:translated_message) do
v8_ctx.eval("I18n._mfMessages.get('posts_likes_MF', {count: 3, ratio: 'med'})")
end
let(:fake_logger) { FakeLogger.new }
before do
Rails.logger.broadcast_to(fake_logger)
overriden_translation_ja.update_columns(
value: "{ count, plural, one {返信 # 件、} other {返信 # 件、} }",
)
@ -180,8 +178,6 @@ RSpec.describe JsLocaleHelper do
v8_ctx.eval(output)
end
after { Rails.logger.stop_broadcasting_to(fake_logger) }
context "when locale is 'en'" do
let(:locale) { "en" }
@ -262,11 +258,6 @@ RSpec.describe JsLocaleHelper do
it "raises an error" do
expect(output).to match(/Failed to compile message formats/)
end
it "logs which keys are problematic" do
output
expect(fake_logger.errors).to include(/posts_likes_MF/)
end
end
end