github-mirror/discourse
github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-03-28 21:49:25 +08:00
Code Issues Actions1 Packages Projects Releases Wiki Activity

DEV: skips two flakey specs ()

Browse Source
This commit is contained in:
Joffrey JAFFEUX 2023-10-22 18:50:04 +02:00 committed by GitHub
parent 53c23cf929
commit 7c057878e2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 8 deletions

9
plugins/chat/spec/system/channel_members_page_spec.rb

@ -35,13 +35,12 @@ RSpec.describe "Channel - Info - Members page", type: :system do
channel_1.add(current_user) channel_1.add(current_user)
channel_1.add(Fabricate(:user, username: "cat")) channel_1.add(Fabricate(:user, username: "cat"))
98.times { channel_1.add(Fabricate(:user)) } 98.times { channel_1.add(Fabricate(:user)) }
end
it "shows all members" do
Jobs.run_immediately! Jobs.run_immediately!
channel_1.update!(user_count_stale: true) channel_1.update!(user_count_stale: true)
Jobs::Chat::UpdateChannelUserCount.new.execute(chat_channel_id: channel_1.id) Jobs::Chat::UpdateChannelUserCount.new.execute(chat_channel_id: channel_1.id)
end
xit "shows all members" do
chat_page.visit_channel_members(channel_1) chat_page.visit_channel_members(channel_1)
expect(page).to have_selector(".chat-channel-members__list-item", count: 60) expect(page).to have_selector(".chat-channel-members__list-item", count: 60)
@ -57,10 +56,6 @@ RSpec.describe "Channel - Info - Members page", type: :system do
context "with filter" do context "with filter" do
it "filters members" do it "filters members" do
Jobs.run_immediately!
channel_1.update!(user_count_stale: true)
Jobs::Chat::UpdateChannelUserCount.new.execute(chat_channel_id: channel_1.id)
chat_page.visit_channel_members(channel_1) chat_page.visit_channel_members(channel_1)
find(".chat-channel-members__filter").fill_in(with: "cat") find(".chat-channel-members__filter").fill_in(with: "cat")

2
plugins/chat/spec/system/navigation_spec.rb

@ -131,7 +131,7 @@ RSpec.describe "Navigation", type: :system do
end end
context "when opening a thread from the thread list" do context "when opening a thread from the thread list" do
it "goes back to the thread list when clicking the back button" do xit "goes back to the thread list when clicking the back button" do
skip("Flaky on CI") if ENV["CI"] skip("Flaky on CI") if ENV["CI"]
visit("/chat") visit("/chat")