DEV: Revert upload-artifacts to v3 for flaky test related actions (#24960)

Why this change?

`upload-artifacts` v4 introduces a breaking change where uploading
multiple uploads to the same name artifact is no longer supported.
However, we have external services reading these artifacts and the
change in the artifact name is breaking those services.
This commit is contained in:
Alan Guo Xiang Tan 2023-12-19 14:20:21 +08:00 committed by GitHub
parent 38abc0d922
commit b364de7387
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -289,10 +289,10 @@ jobs:
shell: bash
- name: Upload failed system test screenshots
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v3 # TODO (tgxworld): V4 doesn't allow us to upload multiple uploads to the same artifact name so keep at V3 for now.
if: always() && steps.check-failed-system-test-screenshots.outputs.exists == 'true'
with:
name: failed-system-test-screenshots-${{ hashFiles('tmp/capybara/*.png') }}
name: failed-system-test-screenshots
path: tmp/capybara/*.png
- name: Check for flaky tests report
@ -318,10 +318,10 @@ jobs:
run: cp tmp/turbo_rspec_flaky_tests.json tmp/turbo_rspec_flaky_tests-${{ matrix.build_type }}-${{ matrix.target }}-${{ steps.fetch-job-id.outputs.job_id }}.json
- name: Upload flaky tests report
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v3 # TODO (tgxworld): V4 doesn't allow us to upload multiple uploads to the same artifact name so keep at V3 for now
if: always() && steps.check-flaky-spec-report.outputs.exists == 'true'
with:
name: flaky-test-reports-${{ hashFiles('tmp/turbo_rspec_flaky_tests-*') }}
name: flaky-test-reports
path: tmp/turbo_rspec_flaky_tests-${{ matrix.build_type }}-${{ matrix.target }}-${{ steps.fetch-job-id.outputs.job_id }}.json
- name: Check Annotations