github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-12-02 16:04:55 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: Remove obsolete references to lounge category (#21608)

Browse Source 
### What is this change?

The lounge category was replaced with the general category in https://github.com/discourse/discourse/pull/18097.

However, there are still a few references to the lounge category in code. In particular, `Category#seeded?` is erroring out in production looking for `SiteSetting.lounge_category_id`.
This commit is contained in:
Ted Johansson 2023-05-17 16:48:31 +08:00 committed by GitHub
parent 292ca384b9
commit c9ee11c675
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/models/category.rb
View File

@ -806,7 +806,7 @@ class Category < ActiveRecord::Base
def seeded? def seeded?
[ [
SiteSetting.lounge_category_id, SiteSetting.general_category_id,
SiteSetting.meta_category_id, SiteSetting.meta_category_id,
SiteSetting.staff_category_id, SiteSetting.staff_category_id,
SiteSetting.uncategorized_category_id, SiteSetting.uncategorized_category_id,

4
spec/lib/seed_data/categories_spec.rb
View File

@ -135,7 +135,7 @@ RSpec.describe SeedData::Categories do
end end
it "does not override permissions of existing category when not forced" do it "does not override permissions of existing category when not forced" do
create_category("lounge_category_id") create_category("general_category_id")
category = Category.last category = Category.last
category.set_permissions(trust_level_2: :full) category.set_permissions(trust_level_2: :full)
@ -143,7 +143,7 @@ RSpec.describe SeedData::Categories do
expect(category.category_groups.first).to have_attributes(permissions(:trust_level_2, :full)) expect(category.category_groups.first).to have_attributes(permissions(:trust_level_2, :full))
expect { create_category("lounge_category_id") }.not_to change { CategoryGroup.count } expect { create_category("general_category_id") }.not_to change { CategoryGroup.count }
category.reload category.reload
expect(category.category_groups.first).to have_attributes(permissions(:trust_level_2, :full)) expect(category.category_groups.first).to have_attributes(permissions(:trust_level_2, :full))