github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-22 11:44:49 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: Descriptions not showing for some site setting types (#26399)

Browse Source 
Descriptions for the `category-list`, `file-size-restriction` and `file-types-list` site/theme settings aren't rendered due to a bug that was introduced when those components were migrated to Glimmer components. This commit fixes the bug which is that arguments passed to .gjs components should be accessed as `@argument` and not `this.arugment` inside the `<template>` tag.
This commit is contained in:
Osama Sayegh 2024-03-27 15:48:48 +03:00 committed by GitHub
parent 2146ab492b
commit f79f9e236a
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/assets/javascripts/admin/addon/components/site-settings/category-list.gjs
View File

@ -51,8 +51,8 @@ export default class CategoryList extends Component {
@onChange={{this.onChangeSelectedCategories}}
/>
<SiteSettingsDescription @description={{this.setting.description}} />
<SettingValidationMessage @message={{this.validationMessage}} />
<SiteSettingsDescription @description={{@setting.description}} />
<SettingValidationMessage @message={{@validationMessage}} />
</div>
</template>
}

2
app/assets/javascripts/admin/addon/components/site-settings/file-size-restriction.gjs
View File

@ -29,6 +29,6 @@ export default class FileSizeRestriction extends Component {
/>
<SettingValidationMessage @message={{this.validationMessage}} />
<SiteSettingsDescription @description={{this.setting.description}} />
<SiteSettingsDescription @description={{@setting.description}} />
</template>
}

4
app/assets/javascripts/admin/addon/components/site-settings/file-types-list.gjs
View File

@ -146,7 +146,7 @@ export default class FileTypesList extends Component {
class="btn file-types-list__button document"
/>
<SettingValidationMessage @message={{this.validationMessage}} />
<SiteSettingsDescription @description={{this.setting.description}} />
<SettingValidationMessage @message={{@validationMessage}} />
<SiteSettingsDescription @description={{@setting.description}} />
</template>
}