discourse

mirror of https://github.com/discourse/discourse.git synced 2024-12-15 18:34:24 +08:00

Author	SHA1	Message	Date
Joffrey JAFFEUX	761003c8bd	FIX: makes sure an hex is always at 6 chars (#6608 ) eg: #aaa should be converted to #aaaaaa	2018-11-15 00:52:47 +01:00
Maja Komel	c701036034	FIX: reset bump date resets bumped_at to the last regular post in topic (#6605 )	2018-11-14 18:56:22 +01:00
Régis Hanol	c78dcde973	FIX: only send originalText when we need to	2018-11-14 17:47:59 +01:00
Bianca Nenciu	fce0a0ccc8	FEATURE: Compute distance between logins to generate login alerts. (#6562 )	2018-11-14 13:26:47 +01:00
Guo Xiang Tan	2220345a8b	Fix the build.	2018-11-14 17:32:32 +08:00
Guo Xiang Tan	72370b9c36	Add deprecation warnings for url based site settings.	2018-11-14 16:09:26 +08:00
Guo Xiang Tan	44391ee8ab	FEATURE: Upload Site Settings. (#6573 )	2018-11-14 15:03:02 +08:00
David Taylor	17bc82765b	FEATURE: Log password changes in UserHistory (#6600 )	2018-11-14 08:32:42 +08:00
Kyle Zhao	38a9bc740d	FIX: change title when primary group changes (#6602 )	2018-11-14 08:28:41 +08:00
Sam	80ceb57c76	DEV: add API endpoint to destroy_timings only of last post Previously API only allowed you to nuke all timings from a topic, new API is less punishing and allows you just to remove 1 post.	2018-11-13 16:07:48 +11:00
Robin Ward	0cb33d2b52	UX: Rename Most Disagreed Flaggers report to "User Flagging Ratio"	2018-11-12 16:23:37 -05:00
David Taylor	d89ffbeffd	FEATURE: Add button to delete unused tags (#6587 ) This is particularly useful if you have uploaded a CSV file, and wish to bulk-delete all of the tags that you uploaded.	2018-11-12 16:24:34 +00:00
Bianca Nenciu	5af9a69a3b	FIX: Do not check for suspicious login when impersonating. (#6534 ) * FIX: Do not check for suspicious login when impersonating. * DEV: Add 'impersonate' parameter to log_on_user.	2018-11-12 15:34:12 +01:00
Maja Komel	012da86a07	FIX user directory time period count (#6586 )	2018-11-12 15:30:05 +01:00
Sam	d1684a1652	PERF: avoid left joins and distinct on posts_for query Previously this was extremely expensive due to the `distict` and `left join` clauses, this eliminates it and makes query much faster	2018-11-12 13:26:41 +11:00
David Taylor	c3c9299c44	FIX: Improve performance for `Group.posts_for` (#6588 )	2018-11-12 08:44:20 +08:00
Joffrey JAFFEUX	f8838ac9cd	FIX: fix/removes broken elements of old dashboard	2018-11-09 17:18:19 +01:00
Gerhard Schlager	24e5be3f0c	FIX: Relative links in translations should work with subfolder	2018-11-08 23:31:05 +00:00
Sam	42572ff138	Revert font awesome 5 changes We are still pushing ahead on this 100% just need a bit longer to prepare all plugins	2018-11-08 16:12:18 +11:00
Penar Musaraj	005e1ecb9b	FEATURE: Update Font Awesome to v5.4.1 and SVGs (#6557 ) * First take on subsetting svg icons * FontAwesome 5 svg subset WIP * Include icons from plugins/badges into svg sprite subset * add svg icon support to themes * Add spec for SvgSprite * Misc. SVG icon fixes * Use FA5 svgs in local-dates plugin * CSS adjustments, fix SVG icons in group flair * Use SVG icons in poll plugin * Add SVG icons to /wizard	2018-11-07 13:05:43 -05:00
Sam	0a442e319c	FIX: correct svg handling for images We regressed and optimized images no longer worked with svg The following adds the correct logic to simply copy file for svgs and bypasses resizing for svg avatars	2018-11-07 15:29:26 +11:00
Guo Xiang Tan	7534042427	DEV: Update annotations.	2018-11-07 11:11:19 +08:00
Bianca Nenciu	2070edf889	FIX: Clarify User.group_locked_trust_level. * Rename User.group_locked_trust_level to User.group_granted_trust_level. * Remove the column from users table.	2018-11-07 10:27:44 +08:00
Joffrey JAFFEUX	8067f8a32c	FIX: disables dates filtering on most_disagreed_flags report (#6556 )	2018-11-02 14:42:52 +01:00
Joffrey JAFFEUX	4e0f033fae	FEATURE: adds ignored flags to most_disagreed_flags report (#6554 )	2018-11-02 11:08:00 +01:00
Kyle Zhao	f9b36820ef	FIX: only extract script tags with certain types (#6553 ) `script` tags with custom types (e.g. `text/template`) are not executed by the browser, and should not be extracted into an external theme JavaScript	2018-11-01 16:01:46 -04:00
Robin Ward	ec91450aae	FEATURE: Track how many user flags are agreed/disagreed/ignored Display the percentage when reviewing flags.	2018-11-01 09:59:50 -04:00
Sam	23423ba112	correct spec and error reporting previous commit misused warn_exception which caused a spec to fail	2018-10-31 13:38:05 +11:00
Bianca Nenciu	e0ccd36dbe	FEATURE: Suspicious logins report. (#6544 )	2018-10-30 22:51:58 +00:00
Joffrey JAFFEUX	b2585524a9	FEATURE: adds a most disagreed flaggers report	2018-10-26 15:59:04 +02:00
Penar Musaraj	ed9c21e42c	FEATURE: hide muted categories from /categories list (#6531 )	2018-10-26 11:34:39 +11:00
Régis Hanol	d17c8df926	Only check for suspicious login for staff members	2018-10-26 00:29:28 +02:00
Bianca Nenciu	6a3767cde7	FEATURE: Warn users via email about suspicious logins. (#6520 ) * FEATURE: Warn users via email about suspicious logins. * DEV: Move suspicious login check to a job.	2018-10-25 09:45:31 +00:00
Jeff Wong	0ead513fb0	PERF: remove total unread notifications from message bus (#6529 )	2018-10-25 12:14:34 +11:00
Sam	5fd94d3211	PERF: limit unread count to 99 in blue circle This revises: `e605542c4e` Previous commit was faulty	2018-10-24 12:10:27 +11:00
Sam	e605542c4e	PERF: limit unread count to 99 in the blue circle This safeguard is in place to avoid very expensive queries on the server side	2018-10-24 11:53:28 +11:00
Sam	b74dd7d379	FIX: stop logging every 404 error when searching for gravatars	2018-10-23 11:43:14 +11:00
Bianca Nenciu	b69652278f	FEATURE: Add Wiki Editor badge. (#6511 )	2018-10-19 15:30:27 +02:00
Joffrey JAFFEUX	5f86564da1	FEATURE: adds latest to user-api-key session scope	2018-10-19 09:54:06 +02:00
Sam	9bfc939692	cleanup so gravatar download failures are consistent previously we would ignore socket error, but this would mean that there could be conditions where we would keep trying to download gravatars forever (in an hourly job)	2018-10-19 12:51:55 +11:00
Robin Ward	f0af61da41	FIX: User `AvatarLookup` for looking up avatar details (#6508 ) This allows plugins with their own avatar logic to work in the user summary sections.	2018-10-18 15:49:34 -04:00
Régis Hanol	3973823a33	FIX: always update 'last_gravatar_download_attempt' when updating gravatar	2018-10-18 11:02:54 +02:00
Kyle Zhao	0f1afad6da	FIX: extracted theme JavaScripts for multisite (#6502 ) * FIX: extracted theme javascripts for multisite * onceoff to rebake all theme fields	2018-10-18 17:05:34 +11:00
Guo Xiang Tan	22408f93c9	FIX: Wrap custom fields database statements in a transaction. Kind of strange that we don't do it because a database statement may fail and leave us in a weird state.	2018-10-18 12:23:04 +08:00
Guo Xiang Tan	44eba0bb60	FIX: Don't rescue `PG::UniqueViolation` within a transaction. Also acquire a transaction per link instead of failing when any of the links can't be processed. This prevents ActiveRecord from rolling back the transaction and the next SQL statement sent to PG will fail. This is however hard to test as it only happens when there are two competing process trying to process this method at the same time.	2018-10-18 10:54:30 +08:00
David Taylor	c6f364224e	FEATURE: Allow plugins to whitelist user custom fields for public display (#6499 ) This works exactly the same as `whitelist_staff_user_custom_fields`, but is not limited to staff	2018-10-17 10:33:27 +01:00
Sam	19d7543004	FIX: clear color scheme cache when clearing theme cache	2018-10-16 12:00:46 +11:00
Kyle Zhao	99d1ded3b3	rename route `/javascripts` to `/theme-javascripts` (#6495 )	2018-10-15 11:32:52 -04:00
Joffrey JAFFEUX	f6eff38c0e	FEATURE: adds list#(unread\|new) to user api key routes (#6494 )	2018-10-15 15:48:35 +02:00
Kyle Zhao	6acdea37c4	DEV: extract inline js when baking theme fields (#6447 ) * extract inline js when baking theme fields * destroy javascript cache when destroying theme fields This work is needed to support CSP work	2018-10-15 15:55:23 +11:00
Guo Xiang Tan	84d4c81a26	FEATURE: Support backup uploads/downloads directly to/from S3. This reverts commit `3c59106bac`.	2018-10-15 09:43:31 +08:00
Neil Lalonde	12f132736b	FIX: error looking at users in admin when tl3_promotion_min_duration is set to a very high value	2018-10-11 15:11:48 -04:00
Vinoth Kannan	6a444eee56	Merge pull request #6476 from vinothkannans/tl4-flag FEATURE: automatically hide non-TL4 posts when flagged by a TL4 user	2018-10-11 17:13:26 +05:30
Vinoth Kannan	227a49bb32	FEATURE: automatically hide non-TL4 posts when flagged by a TL4 user	2018-10-11 17:11:46 +05:30
Jeff Wong	b5b382dcd6	Feature: add boxes with subcategories option for desktop categories page (#6471 ) * Feature: add boxes with subcategories option for desktop categories page * only add subclass div when subclasses exist	2018-10-11 15:59:37 +08:00
Guo Xiang Tan	3c59106bac	Revert "FEATURE: Support backup uploads/downloads directly to/from S3." This reverts commit `c29a4dddc1`. We're doing a beta bump soon so un-revert this after that is done.	2018-10-11 11:08:23 +08:00
Gerhard Schlager	c29a4dddc1	FEATURE: Support backup uploads/downloads directly to/from S3.	2018-10-11 10:38:43 +08:00
Guo Xiang Tan	ae6a5419e0	DEV: Report the backtrace as well.	2018-10-10 17:43:42 +08:00
Erin Kosewic	51aba32651	FEATURE: add branch option to remote theme import * FEATURE: add branch option to remote theme import * FIX: Add missing variable in params * FIX: Add missing param for import_theme method * SPEC: Add test methods for branch support in git import * FIX: Add missing space to scss style * Do not assume default branch as master * Change branch field placeholder * FIX: add missing div start tag	2018-10-09 17:01:08 +11:00
Jeff Wong	e55f220b33	add category style boxes with featured topics option	2018-10-08 16:19:54 -07:00
Gerhard Schlager	eb3ed7f6fd	Add missing annotations	2018-10-08 18:01:21 +02:00
David Taylor	9bf522f227	FEATURE: Mixed case tagging (#6454 ) - By default, behaviour is not changed: tags are made lowercase upon creation and edit. - If force_lowercase_tags is disabled, then mixed case tags are allowed. - Tags must remain case-insensitively unique. This is enforced by ActiveRecord and Postgres. - A migration is added to provide a `UNIQUE` index on `lower(name)`. Migration includes a safety to correct any current tags that do not meet the criteria. - A `where_name` scope is added to `models/tag.rb`, to allow easy case-insensitive lookups. This is used instead of `Tag.where(name: "blah")`. - URLs remain lowercase. Mixed case URLs are functional, but have the lowercase equivalent as the canonical.	2018-10-05 10:23:52 +01:00
Vinoth Kannan	8430ea927e	FIX: Generate webhook payloads before destroy events (#6325 )	2018-10-05 16:53:59 +08:00
Penar Musaraj	34516c72bd	FIX: Recover public actions (likes) when recovering a post (#6412 )	2018-10-02 11:25:08 -04:00
Joffrey JAFFEUX	a515ba8612	FIX: corrects typo and adds a spec for likes report (#6439 ) * FIX: corrects typo and adds a spec for likes report * save!	2018-10-02 02:27:43 -07:00
Maja Komel	1add11d8c9	FIX: don't send multiple requests when changing category notification (#6435 )	2018-10-01 23:41:23 +08:00
David Taylor	19c9a6699a	FIX: Validate auto_close_hours category setting This prevents server errors when the value is set too high	2018-09-26 16:04:49 +01:00
David Taylor	84f5448a92	FEATURE: Display trust level descriptions in site settings (#6421 )	2018-09-21 15:10:38 +01:00
Kyle Zhao	e402394375	FEATURE: auto grant an available title when removing old title * FEATURE: auto grant an available title when removing old title	2018-09-21 12:06:08 +10:00
Arpit Jalan	3e17ef0507	Merge pull request #6414 from techAPJ/user-field-unique-key FEATURE: add external details to user fields	2018-09-20 22:29:39 +05:30
Sam	df45e82377	SECURITY: only allow picking of avatars created by self (#6417 ) * SECURITY: only allow picking of avatars created by self Also adds origin tracking to all uploads including de-duplicated uploads	2018-09-19 22:33:10 -07:00
Guo Xiang Tan	195bd02fce	FIX: Avoid race condition when enqueuing job.	2018-09-20 11:24:01 +08:00
Arpit Jalan	72be638728	FEATURE: add external details to user fields	2018-09-20 08:10:51 +05:30
Sam	e0e6dae6a7	minor cleanup to previous commit from code review	2018-09-19 16:07:29 +10:00
Sam	5302709343	FIX: in redis readonly raise an exception from DistributedMutex If we detect redis is in readonly we can not correctly get a mutex raise an exception to notify caller When getting optimized images avoid the distributed mutex unless for some reason it is the first call and we need to generate a thumb In redis readonly no thumbnails will be generated	2018-09-19 15:50:58 +10:00
Guo Xiang Tan	4a92c5b2d6	`UploadRecovery` should recover attachments too.	2018-09-19 10:44:36 +08:00
Vinoth Kannan	9281b72308	FEATURE: Log entity export in staff logs	2018-09-19 03:16:45 +05:30
Sam	7d6b348d0b	SECURITY: correct XSS on long topic titles	2018-09-18 08:54:44 +10:00
Kyle Zhao	6659417807	FEATURE: match user title when primary group changes When primary group changes and the user's title is the previous primary group's title, change the title to the new primary group's title	2018-09-17 15:08:39 +10:00
Sam	33541c4096	FEATURE: unconditionally omit no-follow for staff Previously TL2 and below staff would have links no-followed which was never intended	2018-09-17 12:02:20 +10:00
Joffrey JAFFEUX	e51c676135	refactors trending search report to use SearchLog	2018-09-17 10:19:40 +10:00
OsamaSayegh	5625461c05	clear error if you can contact theme repo again	2018-09-17 09:49:53 +10:00
OsamaSayegh	c7d81e2682	FIX/FEATURE: don't blow up when can't reach theme's repo, show problem themes on dashboard	2018-09-17 09:49:53 +10:00
Sam	419b14e58b	FIX: correctly keep stylesheet cache entries The intent from day one was to keep MAX_TO_KEEP stylesheets per target however the DELETE statement did not perform target filtering This meant we often deleted the wrong stylesheets from the cache	2018-09-14 12:54:11 +10:00
Joffrey JAFFEUX	a6502ce879	FIX: ensures errors in report initialization fail nicely (#6392 )	2018-09-13 17:36:55 +02:00
Joffrey JAFFEUX	18fcd483f2	FIX: ensures we have a color for reports (#6396 )	2018-09-13 17:36:39 +02:00
Joffrey JAFFEUX	7bf8b0d305	FIX: treats users_(by_type\|tl) as other reports (#6391 )	2018-09-13 17:35:54 +02:00
Arpit Jalan	d288462abf	Merge pull request #6393 from techAPJ/bad-json FIX: ignore and log bad json values for custom fields	2018-09-13 15:54:01 +05:30
Arpit Jalan	e364547ff7	FIX: ignore and log bad json values for custom fields	2018-09-13 14:26:30 +05:30
Guo Xiang Tan	529e4018f0	DEV: Avoid using `send` and make the method public instead.	2018-09-13 16:34:32 +08:00
Guo Xiang Tan	3884e99e88	Add extra protection in `Upload#get_from_url`. In case the extension goes missing from the URL.	2018-09-12 00:12:14 -07:00
Guo Xiang Tan	b3469bea2d	FIX: Uploads not being linked correctly to posts. Regression due to `1f636c445b`.	2018-09-11 23:50:23 -07:00
Sam	d1984a0b4d	FIX: display a correct error when attempting to agree on a deferred flag Previously we would raise a 500 error if a moderator tried to agree on a flag another moderator deferred. This can happen cause the UX for flags does not live refresh as flags are handled	2018-09-12 13:16:59 +10:00
Guo Xiang Tan	71185c13b5	Merge pull request #6377 from tgxworld/remove_tif_tiff Drop `tif`, `tiff`, `webp` and `bmp` from supported images.	2018-09-12 09:32:32 +08:00
Guo Xiang Tan	e1b16e445e	Rename `FileHelper.is_image?` -> `FileHelper.is_supported_image?`.	2018-09-12 09:22:28 +08:00
Osama Sayegh	16bd3f2cf2	FIX: use current user color scheme when filling `theme-color` attribute (#6384 ) * FIX: use current user color scheme when filling `meta` attribute `theme-color` * update manifest.webmanifest colors	2018-09-12 11:04:58 +10:00
Sam	e64402cb3b	SECURITY: correct edge case when SSO provides unvalidated emails	2018-09-11 08:24:02 +10:00
Guo Xiang Tan	04d26c65e2	Refactor `Upload.get_from_url` to check length of sha1.	2018-09-10 10:10:39 +08:00
Gerhard Schlager	797cbf8653	FIX: Remove user fields when anonymizing user	2018-09-07 00:02:56 +02:00
Guo Xiang Tan	1f636c445b	PERF: Add fast path to find uploads before resorting to `LIKE` query. For a normal upload url Before ``` Warming up -------------------------------------- 264.000 i/100ms Calculating ------------------------------------- 2.754k (± 8.4%) i/s - 13.728k in 5.022066s ``` After ``` Warming up -------------------------------------- 341.000 i/100ms Calculating ------------------------------------- 3.435k (±11.6%) i/s - 17.050k in 5.045676s ```	2018-09-06 14:44:24 +08:00
Guo Xiang Tan	d4b05d7bc5	Always link post to uploads in post process. The operation is cheap anyway so no point skipping.	2018-09-06 14:08:03 +08:00
Guo Xiang Tan	434035f167	FIX: Link post to uploads in `PostCreator`. * This ensures that uploads are linked to their post on creation instead of a background job which may be delayed if Sidekiq is facing difficulties.	2018-09-06 11:18:11 +08:00
Joffrey JAFFEUX	e59622f2ba	FIX: deactivate chart trends for now (#6364 )	2018-09-05 23:33:29 +02:00
David Taylor	4382fb5fac	DEV: Allow plugins to whitelist specific user custom_fields for editing (#6358 )	2018-09-04 20:45:36 +10:00
Sam	ad70502ab8	FIX: ignore invalid usernames in incoming link tracker If an incoming link username has NULL in it simply ignore it	2018-09-04 12:28:32 +10:00
Guo Xiang Tan	8dc1463ab3	Enable `Lint/ShadowingOuterLocalVariable` for Rubocop.	2018-09-04 10:16:42 +08:00
Bianca Nenciu	931cffcebe	FEATURE: Let users see their user auth tokens. (#6313 )	2018-08-31 10:18:06 +02:00
Sam	e1975e293f	FIX: when uploads are destroyed clear up avatar refs in user table This also auto corrects twice daily when we ensure consistency	2018-08-31 14:46:42 +10:00
Joffrey JAFFEUX	bb93179609	FEATURE: charts will now use tertiary color (#6342 )	2018-08-30 14:56:11 +02:00
David Taylor	f0abb4d09a	FIX: Allow user actions to be saved even if the post has nil user This issue made it impossible to delete users if they had flagged a post with nil user	2018-08-30 01:03:32 +01:00
Sam	e6970151a6	FEATURE: allow specifying locale via SSO Use: locale locale_force_update To force user locale on users where SiteSetting.allow_user_locale is enabled Note: If an invalid locale is specified no action will occur	2018-08-30 09:58:03 +10:00
Kyle Zhao	e25a6e085e	FIX: drop title updates through RSS feeds can create an update loop	2018-08-28 16:25:04 +10:00
Sam	9ab1fb7dfc	FEATURE: correctly store width and height on uploads Previously we used width and height for thumbnails, new code ensures 1. We auto correct width and height 2. We added extra columns for thumbnail_width and height, this is determined by actual upload and no longer passed in as a side effect 3. Optimized Image now stores filesize which can be used for analysis, decisions Also - fixes Android image manifest as a side effect - fixes issue where a thumbnail generated that is smaller than the upload is no longer used	2018-08-28 12:59:22 +10:00
Joffrey JAFFEUX	c8ffe0fda3	FIX: term should be handled as text (#6321 )	2018-08-27 11:58:46 +02:00
Raul Tambre	2271918be2	FEATURE: Use S3 dualstack endpoints Allows S3 without a CDN to serve images from dualstack domains that also support ipv6	2018-08-27 11:22:46 +10:00
Kris	faf09bb8c8	Replacing default brown category color	2018-08-24 14:18:14 -04:00
Guo Xiang Tan	932195d828	DEV: Update test case for `TopicEmbed`.	2018-08-24 09:42:12 +08:00
Guo Xiang Tan	1ba24496ab	Merge pull request #6261 from xrav3nz/fix/topic-embed-import-updates FIX: update TopicEmbed's title and user correctly	2018-08-24 09:32:03 +08:00
Osama Sayegh	e0cc29d658	FEATURE: themes and components split * FEATURE: themes and components split * two seperate methods to switch theme type * use strict equality operator	2018-08-24 11:30:00 +10:00
Gerhard Schlager	409ee66839	Add optional "ignore_case" parameter to posts:remap rake task	2018-08-23 14:49:17 +02:00
Gerhard Schlager	3d176d9984	Add missing copy	2018-08-23 09:44:15 +02:00
Guo Xiang Tan	72ed6ae951	Raise an error if update fails.	2018-08-23 15:40:21 +08:00
Osama Sayegh	2711f173dc	FIX: don't allow inviting more than `max_allowed_message_recipients` * FIX: don't allow inviting more than `max_allowed_message_recipients` setting allows * add specs for guardian * user preferences for auto track shouldn't be applicable to PMs (it auto watches on visit) Execlude PMs from "Automatically track topics I enter..." and "When I post in a topic, set that topic to..." user preferences * groups take only 1 slot in PM * just return if topic is a PM	2018-08-23 14:36:49 +10:00
Joffrey JAFFEUX	c08dea386b	FIX: better handling of no prev30Days (#6301 )	2018-08-22 18:00:11 +02:00
Régis Hanol	f01169d6ff	FIX: don't send email when the post was deleted	2018-08-22 13:13:58 +02:00
Kyle Zhao	baf413d527	FIX: update TopicEmbed's title and user correctly	2018-08-21 18:31:01 +08:00
Guo Xiang Tan	7c69fa8cfd	PERF: Memoize `SkippedEmailLog.reason_types`.	2018-08-21 10:25:06 +08:00
Bianca Nenciu	860c1c3dcd	FEATURE: Automatically expire keys if not used for a configurable amount of time. (#6264 )	2018-08-20 17:36:14 +02:00
Gerhard Schlager	14af90df5b	UX: Stop putting usernames in edit reason when changing post owner	2018-08-20 12:28:04 +02:00
Sam	8b5e42ea16	FIX: always test and coerce to image on upload In the past the filename of the origin was used as the source for the extension of the file when optimizing on upload. We now use the actual calculated extension based on upload data.	2018-08-20 12:18:59 +10:00
Joffrey JAFFEUX	37d4f27c44	FIX: quality/bugfix dashboard/reports pass (#6283 )	2018-08-17 16:19:25 +02:00
Sam	9628c3cf97	FEATURE: automatically correct extension for bad uploads This fixes with post thumbnails on the fly	2018-08-17 14:00:27 +10:00
Régis Hanol	93201d8dbe	FIX: don't trigger 'flag_reviewed' when no flags were reviewed	2018-08-16 18:11:29 +02:00
Joffrey JAFFEUX	3fbf7b164d	FEATURE: emoji 11.0 "recently added" update (#6275 ) Adds support for emojis in the http://www.unicode.org/emoji/charts-11.0/emoji-released.html list	2018-08-16 11:59:45 +02:00
Sam	f62073a22a	correct regression uploading images	2018-08-16 18:49:08 +10:00
Sam	796164b58c	FIX: automatically correct bad avatars on access Also start relying on upload extension for optimized images	2018-08-16 16:32:56 +10:00
Sam	243fc9d0f9	FIX: refreshing auto groups when min_username_length is long	2018-08-15 16:59:56 +10:00
Sam	33b5cc6bbd	FIX: Add gif to list of allowed decoders	2018-08-15 13:56:57 +10:00
Sam	cf788582cc	DEV: split optimize image failure warnings in logs	2018-08-15 13:27:24 +10:00
Gerhard Schlager	c358421ca5	FIX: Bulk updating category failed when topic title was too short	2018-08-14 16:37:52 +02:00
Régis Hanol	de92913bf4	FIX: store the topic links using the cooked upload url	2018-08-14 12:23:32 +02:00
Sam	83fd308963	FEATURE: group error message regarding image optimization failures	2018-08-13 14:48:25 +10:00
Gerhard Schlager	6d813c2b52	FIX: Importers failed to import avatars	2018-08-12 22:02:17 +02:00
Simon Cossar	093c3510e6	Rework moderators activity query (#6230 ) * Order rows in query * Don't increment revisions when moderator revises their own post	2018-08-10 10:51:31 +10:00
Gerhard Schlager	b9072e8292	FEATURE: Add "Reset Bump Date" action to topic admin wrench (#6246 )	2018-08-10 10:51:03 +10:00
Misaka 0x4e21	6db623ef6b	UX: Improve category filtering and include subcategories * category_filtering 1. report_top_referred_topics 2. report_top_traffic_sources 3. report_post_edit * category_filtering with subcategory topics 1. report_top_referred_topics 2. report_top_traffic_sources 3. report_post_edit 4. report_posts 5. report_topics 6. report_topics_with_no_response * category_filtering tests (without subcategory topics) 1. report_posts 2. report_topics_with_no_response * subcategory topics tests `in_category_and_subcategories` in `topic_spec.rb` 1. `in_category_and_subcategories` in `topic_spec.rb` 2. topics, posts, flags and topics_with_no_response in `report_spec.rb`	2018-08-10 10:50:05 +10:00
Kris	b53d3457c8	updating color scheme attribution	2018-08-08 16:01:21 -04:00
Osama Sayegh	0b7ed8ffaf	FEATURE: backend support for user-selectable components * FEATURE: backend support for user-selectable components * fix problems with previewing default theme * rename preview_key => preview_theme_id * omit default theme from child themes dropdown and try a different fix * cache & freeze stylesheets arrays	2018-08-08 14:46:34 +10:00
David Taylor	aa9a9a5a72	FIX: Include auth_providers for anonymous users when login_required	2018-08-07 09:24:16 +01:00
Joffrey JAFFEUX	7f2f3b8b22	FIX: improves reports resilience (#6239 ) This commit makes most of the reports now lazy loaded, and making them benefits from graceful failures.	2018-08-06 16:57:40 -04:00
David Taylor	812add18bd	REFACTOR: Serve auth provider information in the site serializer. At the moment core providers are hard-coded in Javascript, and plugin providers get added to the JS payload at compile time. This refactor means that we only ship enabled providers to the client.	2018-08-06 09:25:48 +01:00
Guo Xiang Tan	4e11811321	FIX: `UserAvatar#update_gravatar!` does not update `User#uploaded_avatar`. https://meta.discourse.org/t/missing-user-profile-pictures/93844/4	2018-08-06 13:29:44 +08:00
Osama Sayegh	18b396ad56	FEATURE: add link to see new commits when updates are available for themes (#6233 ) * FEATURE: add link to see new commits when updates are available for themes * shorten regexp	2018-08-06 15:29:15 +10:00
Régis Hanol	0cd9e2acb9	fix build	2018-08-04 01:56:26 +02:00
Régis Hanol	bf4d98e89d	FIX: always store topic links using the upload url	2018-08-04 01:29:32 +02:00
Osama Sayegh	880462a41c	FEATURE: display out of date themes on admin dashboard * FEATURE: disaply out of date themes on admin dashboard * Update copy	2018-08-03 09:53:48 +10:00
Joffrey JAFFEUX	9073e11943	FIX: improves number/percent support in reports	2018-08-01 18:40:59 -04:00
Penar Musaraj	4a872823e7	Improvements to user drafts (#6226 ) * drafts in user profile: only show to user herself (not to admins), use avatar replying to (instead of topic OP), add keyboard shortcut for drafts, simplify display labels * use JSON when testing Draft.stream	2018-08-02 07:41:27 +10:00
Dan Ungureanu	1a0ffc5ace	FEATURE: Added method to get multiple values at once from PluginStore. (#6225 )	2018-08-01 18:42:40 +02:00
Gerhard Schlager	f4ca105498	FIX: Moving posts to existing topic didn't update topic metadata	2018-08-01 18:05:43 +02:00
Joffrey JAFFEUX	0b9437cee7	FIX: more resilient/consistent dashboard caching (#6223 )	2018-08-01 09:45:50 -04:00
Joffrey JAFFEUX	7c7dfa4e5e	FIX: wraps any query with the slow query guard (#6222 )	2018-08-01 07:39:57 -04:00
Penar Musaraj	1f45215537	FEATURE: Drafts view in user profile * add drafts.json endpoint, user profile tab with drafts stream * improve drafts stream display in user profile * truncate excerpts in drafts list, better handling for resume draft action * improve draft stream SQL query, add rspec tests * if composer is open, quietly close it when user opens another draft from drafts stream; load PM draft only when user is in /u/username/messages (instead of /u/username) * cleanup * linting fixes * apply prettier styling to modified files * add client tests for drafts, includes a fixture for drafts.json * improvements to code following review * refresh drafts route when user deletes a draft open in the composer while being in the drafts route; minor prettier scss fix * added more spec tests, deleted an acceptance test for removing drafts that was too finicky, formatting and code style fixes, added appEvent for draft:destroyed * prettier, eslint fixes * use "username_lower" from users table, added error handling for rejected promises * adds guardian spec for can_see_drafts, adds improvements following code review * move DraftsController spec to its own file * fix failing drafts qunit test, use getOwner instead of deprecated this.container * limit test fixture for draft.json testing to new_topic request only	2018-08-01 16:34:54 +10:00
Joffrey JAFFEUX	5febe71baa	FIX: prevents crash if flagger doesn’t exist (#6219 )	2018-07-31 23:48:54 -04:00
Joffrey JAFFEUX	849f0d00f6	FEATURE: adds revision_count to moderators_activity (#6218 ) Co-Authored-By: Simon Cossar <scossar@users.noreply.github.com>	2018-07-31 23:40:45 -04:00
Guo Xiang Tan	919e8db686	FIX: Check for group name availability should skip reserved usernames.	2018-08-01 11:09:33 +08:00
Joffrey JAFFEUX	2b2a506a7b	FIX: makes dashboard more resilient to errors (#6217 ) This commit is an attempt to limit cases where the dashboard will generate a full exception page and also make it easier to track the error.	2018-07-31 21:23:28 -04:00
Joffrey JAFFEUX	37252c1a5e	UI: improves dashboard table reports - support for avatars - support for topic/post/user type in reports - improved totals row UI - minor css tweaks	2018-07-31 17:35:13 -04:00
Neil Lalonde	fd29ecb91a	UX: include a flag reason in the post-deleted-by-staff-because-of-flags message	2018-07-30 16:45:46 -04:00
Guo Xiang Tan	87537b679c	Drop `reply_key`, `skipped` and `skipped_reason` from `email_logs`.	2018-07-30 11:39:28 +08:00
Guo Xiang Tan	b94633e844	FIX: `FileHelper` should prioritize response content-type. Request to a URL with `.png` extension may return a jpg instead causing us to attach the wrong extension to an upload.	2018-07-30 10:54:36 +08:00
Guo Xiang Tan	6f9a91cbd5	Merge pull request #6175 from vinothkannans/post_approval_webhook FEATURE: Webhook for post approval events	2018-07-27 10:50:49 +08:00
Vinoth Kannan	af5b88f8e2	Rename approval web hook event type to queued post	2018-07-26 10:29:38 +05:30
Guo Xiang Tan	f8b367cc9c	Fix the build.	2018-07-26 10:17:51 +08:00
Guo Xiang Tan	30242972d3	Add spec for `4bf3bf6786`.	2018-07-26 09:16:14 +08:00
Régis Hanol	f94aeaf6cf	SECURITY: force IM decoder based on file extension - part 3	2018-07-25 23:55:06 +02:00
Régis Hanol	800c57c6ab	SECURITY: force IM decoder based on file extension - part 2	2018-07-25 23:08:02 +02:00
Régis Hanol	4bf3bf6786	SECURITY: force IM decoder based on file extension	2018-07-25 22:00:04 +02:00
Kris	3fd2571abc	Fix typo in color scheme	2018-07-25 15:12:01 -04:00
Vinoth Kannan	5059dad8f0	FEATURE: Webhook for post approval events	2018-07-25 23:43:19 +05:30
David Taylor	0d0d78841b	FIX: Remove `plugin.enabled?` checks at initialization time (#6166 ) Checking `plugin.enabled?` while initializing plugins causes issues in two ways: - An application restart is required for changes to take effect. A load-balanced multi-server environment could behave very weirdly if containers restart at different times. - In a multisite environment, it takes the `enabled?` setting from the default site. Changes on that site affect all other sites in the cluster. Instead, `plugin.enabled?` should be checked at runtime, in the context of a request. This commit removes `plugin.enabled?` from many `instance.rb` methods. I have added a working `plugin.enabled?` implementation for methods that actually affect security/functionality: - `post_custom_fields_whitelist` - `whitelist_staff_user_custom_field` - `add_permitted_post_create_param`	2018-07-25 16:44:09 +01:00
Joffrey JAFFEUX	578c8e861b	FIX: refreshes disk_space on backup create/destroy (#6169 )	2018-07-25 08:26:30 -04:00
Joffrey JAFFEUX	7a3c541077	UX: Preview multiple color schemes in wizard (#6151 ) It was a dropdown to provide choices of color schemes, and only one scheme could be shown. With this commit, multiple color scheme previews can be displayed on one page at the same time, making admins choose color schemes more easily. Theme preview windows are shrinked. Imported default color schemes. Co-Authored-By: Misaka 0x4e21 <misaka4e21@gmail.com>	2018-07-24 09:00:20 -04:00
Guo Xiang Tan	fa19d3a53c	Merge pull request #6108 from discourse/transaction-sidekiq-fix Fix notifications for topics moved between categories	2018-07-24 17:44:03 +08:00
David Taylor	20a21b1240	Move into MiniSQLMultisiteConnection, and add test for rollback	2018-07-24 09:41:55 +01:00
Guo Xiang Tan	98f84d1a4e	Update annotations.	2018-07-24 15:49:55 +08:00
Guo Xiang Tan	7a2bf8e368	Fix invalid query syntax when `CategoryCustomField#value` is blank.	2018-07-24 14:48:27 +08:00
Guo Xiang Tan	fad9c2b971	PERF: Move `EmailLog#reply_key` into new `post_reply_keys` table.	2018-07-24 13:51:53 +08:00
Guo Xiang Tan	ae8b0a517f	PERF: Split skipped email logs into a seperate table.	2018-07-24 13:14:37 +08:00
Guo Xiang Tan	9b84e78fdf	Update annotations.	2018-07-24 11:14:19 +08:00
David Taylor	eda1462b3b	FEATURE: List, revoke and reconnect associated accounts. Phase 1 (#6099 ) Listing connections is supported for all built-in auth providers. Revoke and reconnect is currently only implemented for Facebook.	2018-07-23 16:51:57 +01:00
Joffrey JAFFEUX	32062864d3	FIX: removes system from user to user report (#6144 )	2018-07-23 10:33:12 -04:00
Vinoth Kannan	84ab825e41	FEATURE: Webhook for user destroyed event (#6124 )	2018-07-23 13:19:49 +05:30
Guo Xiang Tan	5c1bd38d84	Merge pull request #6131 from jjaffeux/lazy-load-reports FIX: lazy load more reports in dashboard	2018-07-21 17:24:17 +08:00
Simon Cossar	d705f859db	Exclude System user from post_edits report (#6130 )	2018-07-21 11:17:25 +02:00
Joffrey JAFFEUX	1d5096eb46	FIX: lazy load more reports in dashboard	2018-07-20 23:35:53 -04:00
Guo Xiang Tan	7cf6c2825e	Merge pull request #6106 from OsamaSayegh/watch-when-splitting FIX: topic owner should watch the new topic when moving posts to a new topic	2018-07-20 15:18:59 +08:00
OsamaSayegh	69450750d1	shorter method name and better specs	2018-07-20 10:13:27 +03:00
Joffrey JAFFEUX	64f0cf425b	FIX: removes uncessary reports loading (#6119 )	2018-07-19 19:30:13 -04:00
Joffrey JAFFEUX	a0793387cf	FEATURE: differentiates pms in moderators activity report (#6117 ) Co-Authored-By: Simon Cossar <scossar@users.noreply.github.com>	2018-07-19 19:29:42 -04:00
Joffrey JAFFEUX	1a78e12f4e	FEATURE: part 2 of dashboard improvements - moderation tab - sorting/pagination - improved third party reports support - trending charts - better perf - many fixes - refactoring - new reports Co-Authored-By: Simon Cossar <scossar@users.noreply.github.com>	2018-07-19 14:33:11 -04:00
Guo Xiang Tan	4765507585	Remove code that is no longer required.	2018-07-19 16:56:53 +08:00
Sam	a755ff7b35	FIX: not checking for 0 correctly 0.blank? == false	2018-07-19 07:45:26 +10:00
Maja Komel	a9ebad3f6c	FIX: do not add a moderator post when post is flagged via direct message (#6100 )	2018-07-18 23:18:14 +02:00
David Taylor	32db976156	FIX: Stop race condition when topic notification jobs are scheduled during a database transaction This was not picked up by tests because scheduled jobs are run immediately and in the current thread (and therefore the current database transaction). This particular case sometimes occurs inside multiple nested transactions, so simply moving the offending line outside of the transaction is not enough. Implemented TransactionHelper, which allows us to use `TransactionHelper.after_commit` to define code to be run after the current transaction has been committed.	2018-07-18 22:04:43 +01:00
Neil Lalonde	afc94ac9e4	FEATURE: add a Top Categories section to the user summary page, showing the categories in which a user has the most activity	2018-07-18 16:39:16 -04:00
OsamaSayegh	547b571d84	FIX: topic owner should watch the new topic when moving posts to a new topic	2018-07-18 15:23:32 +03:00
Régis Hanol	6d6e026e3c	FEATURE: selectable avatars	2018-07-18 12:57:43 +02:00
Guo Xiang Tan	487ef9773f	Better logging when optimizing image fails.	2018-07-18 14:11:23 +08:00
Guo Xiang Tan	b068a8a771	Fix the build.	2018-07-18 14:03:27 +08:00
Guo Xiang Tan	be71f9ff82	REFACTOR: Don't load entire AR object just to get a column.	2018-07-18 13:53:57 +08:00
Arpit Jalan	7da22e395b	FIX: do not show links with 0 click on topic map	2018-07-18 10:50:01 +05:30
OsamaSayegh	281538ae61	FIX: theme JS should only run when needed global objects exist (#6098 )	2018-07-18 15:13:47 +10:00
Guo Xiang Tan	3874d40910	Prepare to drop `EmailLog#topic_id`.	2018-07-18 10:22:24 +08:00
Sam	5adf5b527d	FEATURE: support filter_auto_bump_topics event Use this event to filter the list of auto bumped topics. EG: on(:filter_auto_bump_topics) do \|_category, filters\| filters.push(->(r) { r.where(<<~SQL) NOT EXISTS( SELECT 1 FROM topic_custom_fields WHERE topic_id = topics.id AND name = 'accepted_answer_post_id' ) SQL }) end	2018-07-18 10:56:09 +10:00
Sam	02628883d2	FEATURE: adjust autobump system - We spread out bumping through the day, if you are bumping 4 topics then a topic will be bumped every 6 hours - We add a small, bumping action at the bottom of the post to denote a topic got bumped	2018-07-18 10:17:33 +10:00
Guo Xiang Tan	3553375dd2	PERF: Store `EmailLog#reply_key` as `uuid` data type.	2018-07-17 17:05:42 +08:00
Guo Xiang Tan	1d74ccaaf8	Add compatibility for ImageMagick7.	2018-07-17 15:50:58 +08:00
Guo Xiang Tan	fe230f29cd	Update annotations.	2018-07-17 13:11:45 +08:00
Sam	91266cdabb	correct auto bump topic logic	2018-07-17 09:33:33 +10:00
Guo Xiang Tan	c0c263405a	PERF: Store `EmailLog#bounce_key` as `uuid` data type. (#6093 ) PERF: Store `EmailLog#bounce_key` as `uuid` data type.	2018-07-16 20:05:54 +08:00
Sam	ac0053f491	FEATURE: navigate to first post and auto bump category settings ### navigate_to_first_post_after_read setting for categories When enabled on categories logged on users will return to OP after reading the entire category. (useful for documentation categories) ### num_auto_bump_daily Set a number of topics that will automatically bump daily on a category. - Every 15 minutes we will check if any category has this setting - Categories with the setting are shuffled - We exclude pinned, closed, category description and archived topics - Maximum of 1 topic for the list of categories is bumped till limit reached per category - We always try to bump oldest first - Limit is elastic using a RateLimiter that ensures that we only bump N per day Also some minor organisation on category settings Froze strings on category.rb	2018-07-16 18:10:35 +10:00
Guo Xiang Tan	6761f8ecbf	PERF: Add missing index on `user_id` for `user_second_factors` table.	2018-07-16 14:21:07 +08:00
Guo Xiang Tan	214dac05de	Update annotations.	2018-07-16 14:19:07 +08:00
Rishabh	a6c589d882	FEATURE: Add custom S3 Endpoint and DigitalOcean Spaces/Minio support for Backups (#6045 ) - Add custom S3 Endpoints and DigitalOcean Spaces support - Add Minio support using 'force_path_style' option and fix uploads to custom endpoint	2018-07-16 14:44:55 +10:00
Leo McArdle	21ebb1cd54	FEATURE: Secondary emails support.	2018-07-16 11:09:49 +08:00
Guo Xiang Tan	50e59fb9bd	Fix the build.	2018-07-16 10:12:19 +08:00
Jay Pfaffman	0ed2834c2d	FEATURE: Add users:disable_2factor rake task https://meta.discourse.org/t/admin-locked-out-of-2fa/92156/2?u=pfaffman	2018-07-16 09:56:55 +08:00
Kyle Zhao	2901691e87	FEATURE: per-category approval settings (#5778 ) - disallow moving topics to a category that requires topic approval	2018-07-13 12:51:08 +10:00
Arpit Jalan	db67c87916	fix purge unactivated users subquery	2018-07-13 07:58:58 +05:30
OsamaSayegh	decf1f27cf	FEATURE: Groundwork for user-selectable theme components * Phase 0 for user-selectable theme components - Drops `key` column from the `themes` table - Drops `theme_key` column from the `user_options` table - Adds `theme_ids` (array of ints default []) column to the `user_options` table and migrates data from `theme_key` to the new column. - Removes the `default_theme_key` site setting and adds `default_theme_id` instead. - Replaces `theme_key` cookie with a new one called `theme_ids` - no longer need Theme.settings_for_client	2018-07-12 14:18:21 +10:00
Sam	574d447254	FIX: don't attempt to bump draft sequence if no editor Rare case on old installs	2018-07-11 17:06:49 +10:00
Guo Xiang Tan	a17f5052a3	FIX: `ignored_columns` was called twice.	2018-07-11 09:52:37 +08:00
OsamaSayegh	f2cc05c6c6	FIX: ignore self-quotes from the same post when saving (#6082 )	2018-07-10 16:17:28 +08:00
Guo Xiang Tan	5374a0e720	Fix the build.	2018-07-10 09:48:57 +08:00
Jordan Seanor	10bc69a62f	FEATURE: Event on topic merge (#6057 )	2018-07-10 09:28:57 +08:00
Guo Xiang Tan	96aca6d7e6	Remove legacy vote post action code. (#6009 )	2018-07-09 16:54:18 +08:00
Sam	330e848d4a	FIX: if s3 set via global setting bypass config check in UI	2018-07-09 15:38:06 +10:00
michael@discoursehosting.com	81188060d6	Add S3 region eu-west-3 (Paris)	2018-07-09 14:18:35 +10:00
Andrew Schleifer	dba22bbde2	rollback changes This reverts: * 1baba84c438e "fix s3 subfolders harder" * ea5e57938edf "fix test for absolute_base_url change"	2018-07-06 17:16:40 -05:00
Andrew Schleifer	52e9f49ec1	fix s3 subfolders harder specifically, include the folder in absolute_base_url	2018-07-06 16:28:40 -05:00
Maja Komel	18f5f646b1	FEATURE: allow selecting a tag when moving posts to a new topic (#6072 )	2018-07-06 18:21:32 +02:00
Guo Xiang Tan	875008522d	FIX: `Discourse.S3BaseUrl` did not account for subfolder bucket names.	2018-07-06 15:53:57 +08:00
Guo Xiang Tan	7163bf9323	FIX: `Upload.get_from_url` not respective subfolder in s3 bucket names.	2018-07-06 11:37:11 +08:00
Neil Lalonde	eabc8f7fbd	Merge pull request #6023 from misaka4e21/only-staff-can-create-tag FEATURE: Support disabling tag creation for non-staff users.	2018-07-05 11:12:44 -04:00
Patrick Gansterer	28dd7fb562	FEATURE: Create hidden posts for received spam emails (#6010 ) * Add possibility to add hidden posts with PostCreator * FEATURE: Create hidden posts for received spam emails Spamchecker usually have 3 results: HAM, SPAM and PROBABLY_SPAM SPAM gets usually directly rejected and needs no further handling. HAM is good message and usually gets passed unmodified. PROBABLY_SPAM gets an additional header to allow further processing. This change addes processing capabilities for such headers and marks new posts created as hidden when received via email.	2018-07-05 11:07:46 +02:00
Sam	7b26f5086b	PERF: we have no use for topic percent rank Prepare to remove this column	2018-07-05 15:10:19 +10:00
Maja Komel	cb89797e9a	FEATURE: shows remaining backup codes in user preferences	2018-07-04 10:45:42 +02:00
Leo McArdle	c3129444ea	FIX: allow multiple secondary emails	2018-07-03 18:21:35 +08:00
Arpit Jalan	7550e9ff95	FIX: purge unactivated users with a message from non-human users	2018-06-29 13:03:04 +05:30
hellekin	25cfc98b67	Fix 'asscoiated' typo I know that Naming is CRITICAL and that Refactoring only NOT welcome. But since I spotted this (consistent) typo and the change does not affect any functionality -- I checked the presence of "asscoiated" in the code base, I guess the first rule trumps the second one. It also gave me a false pretext to bypass my reluctance to use Google forms and sign de CLA. Typos hurt the eye.	2018-06-29 11:10:05 +10:00
Sam	e0bc6590fd	minor cleanup	2018-06-29 10:30:22 +10:00
Robin Ward	5d1d7e0e7d	PERF: Scanning the `id` for this is signficantly slower in production	2018-06-28 11:04:40 -04:00
Sam	db14e10943	SECURITY: category badges should HTML escape names	2018-06-28 18:15:07 +10:00
Maja Komel	ec3e6a81a4	FEATURE: Second factor backup	2018-06-28 10:12:32 +02:00
misaka4e21	47cb46671a	FEATURE: Support disabling tag creation for non-staff users.	2018-06-27 07:15:02 +08:00
David Lee	4644d777bd	FEATURE: add website field to SSO	2018-06-25 16:09:39 +10:00
Jeff Wong	41f76a74f8	FEATURE: send message when a user reaches tl1	2018-06-22 13:20:00 -07:00
Jeff Wong	bc52bdfa12	Feature: unconditionally consider TL0 users as "first day" users	2018-06-21 10:53:08 -07:00
Guo Xiang Tan	f7d22bad90	FEATURE: Forced summary mode for megalodon topics. This is mainly done for performance reasons and megalodon topics are usually a byproduct of imports where site setting limits are not respected.	2018-06-21 14:00:20 +08:00
Guo Xiang Tan	ac80360bea	PERF: Help postgres make use of index in `Post.summary`.	2018-06-21 13:29:16 +08:00
Guo Xiang Tan	6ddd214476	FIX: `Post#summary` returning posts from other topics.	2018-06-21 12:00:54 +08:00
Joffrey JAFFEUX	50d11fd582	FIX: improves durability display check	2018-06-20 23:15:11 +02:00
Guo Xiang Tan	0365806b93	FIX: Properly display error when post action fails to create.	2018-06-20 21:20:23 +08:00
Joffrey JAFFEUX	fa43969fe2	FIX: crashes with date conversion in reports	2018-06-20 14:42:15 +02:00
Sam	35e0ccfc84	make linter happy	2018-06-20 18:03:27 +10:00
Sam	cb824a6b33	DEV: remove all calls to SqlBuilder use DB.build instead This is part of the migration to mini_sql, SqlBuilder.new is being deprecated and replaced with DB.build	2018-06-20 17:53:49 +10:00
riking	7f37ee9152	SearchLog: fix specs	2018-06-20 10:44:11 +10:00
riking	38a8e52ca4	FIX: Add time retention limit to search logs 3 years is a very conservative limit that allows for a very wide buffer for year-over-year analysis. The max is set to 5 years because that is the policy listed for logging in hosted Discourse.	2018-06-20 10:44:11 +10:00
riking	1de0ef137e	FIX: SearchLog: Do not store IP of logged in users	2018-06-20 10:44:11 +10:00
Jeff Wong	2ff226e509	FIX: consider staged users mature (no spam checks) after 1 day	2018-06-19 09:41:10 -07:00
Sam	5f64fd0a21	DEV: remove exec_sql and replace with mini_sql Introduce new patterns for direct sql that are safe and fast. MiniSql is not prone to memory bloat that can happen with direct PG usage. It also has an extremely fast materializer and very a convenient API - DB.exec(sql, params) => runs sql returns row count - DB.query(sql, params) => runs sql returns usable objects (not a hash) - DB.query_hash(sql, params) => runs sql returns an array of hashes - DB.query_single(sql, params) => runs sql and returns a flat one dimensional array - DB.build(sql) => returns a sql builder See more at: https://github.com/discourse/mini_sql	2018-06-19 16:13:36 +10:00
Jeff Wong	68e4e6a575	FIX: staged users are still tl0 but do not trigger spam if 1 week old.	2018-06-18 17:20:04 -07:00
Jeff Wong	9e55767f6a	FIX: don't punish a user for being previously staged for spam flags.	2018-06-15 12:25:25 -07:00
Régis Hanol	ff06ce4cce	fix the build	2018-06-13 23:05:23 +02:00
Régis Hanol	051d1a3c36	PERF: faster Screened IP Address roll up	2018-06-13 22:47:23 +02:00
Robin Ward	fd54c92a52	FEATURE: New site setting, whitelisted_link_domains If provided, users who normally couldn't post links (say, due to a low trust level), can post links to those specific hosts.	2018-06-13 16:11:22 -04:00
Maja Komel	6c9190357c	fix get from url for external uploads without CDN	2018-06-13 16:21:28 +10:00
riking	94f70c7b5c	FIX: TopicViewItem: do not store IP of logged in users	2018-06-12 12:43:56 +10:00
riking	4b2e2ea8ef	Change TopicViewItem to allow null IP address	2018-06-12 12:43:56 +10:00
Gerhard Schlager	150ae21489	FEATURE: Log user merge in staff logs	2018-06-11 18:43:56 +02:00
Vinoth Kannan	a6303073a0	Strip images from cooked for topic excerpt	2018-06-11 14:43:53 +05:30
Guo Xiang Tan	ad5082d969	Make rubocop happy again.	2018-06-07 13:28:18 +08:00
Sam	89ad2b5900	DEV: Rails 5.2 upgrade and global gem upgrade This updates tests to use latest rails 5 practice and updates ALL dependencies that could be updated Performance testing shows that performance has not regressed if anything it is marginally faster now.	2018-06-07 14:21:33 +10:00
Guo Xiang Tan	d600e71b3d	FIX: Clean up stale `UserExport` records daily. * Add tests for `UserExport.remove_old_exports`	2018-06-05 09:43:40 +08:00
Robin Ward	fab59c66f0	FIX: Protection against dangling category group records	2018-06-04 15:43:26 -04:00
Arpit Jalan	89eca87f16	FEATURE: add staff action log for post rejections	2018-06-01 21:48:27 +05:30
Guo Xiang Tan	9ef61e0af5	PERF: Prefer `exists?` instead of loading AR object.	2018-06-01 09:44:14 +08:00
Neil Lalonde	e26a14dc29	FIX: error when flagging to notify moderators because message title is too long	2018-05-29 12:21:47 -04:00
Sam	df815d6c0e	DEV: prefer using ordering in relation over default scope	2018-05-29 09:34:12 +10:00
Arpit Jalan	8d9c77e113	optimize group invitation code	2018-05-28 17:59:14 +05:30
Arpit Jalan	c8bc942333	FIX: do not add invited user to automatic groups	2018-05-28 17:17:48 +05:30
Gerhard Schlager	ed2ae3cb0a	FIX: Load post revisions in correct order	2018-05-28 11:25:24 +02:00
Guo Xiang Tan	754458e6a2	PERF: Minor but we can just pass a hash to `where`. ``` Warming up -------------------------------------- 4 x .where 1.040k i/100ms 1 x .where 1.677k i/100ms Calculating ------------------------------------- 4 x .where 10.321k (± 5.2%) i/s - 52.000k in 5.053803s 1 x .where 17.117k (± 3.8%) i/s - 85.527k in 5.004107s Comparison: 1 x .where: 17117.1 i/s 4 x .where: 10321.3 i/s - 1.66x slower ```	2018-05-28 16:41:38 +08:00
Sam	5a32a70d6c	FIX: ColorScheme color missing was returning "nil"	2018-05-28 11:46:00 +10:00
Régis Hanol	5b2e7c8d10	fix the build	2018-05-26 03:11:10 +02:00
Régis Hanol	338d39265a	FIX: don't publish notifications_state when user has been deleted	2018-05-26 02:27:54 +02:00
Régis Hanol	d23229df85	Let's use the same method	2018-05-26 02:16:53 +02:00
Régis Hanol	f988fa31aa	FIX: ensure 'notifications_state' is up to date after creating a notification	2018-05-26 02:09:48 +02:00
Robin Ward	4195c7c9ea	FEATURE: Ability to clear a user's penalty history You can do this manually if you want to allow them to reach TL3 without their penalty history counting against them.	2018-05-25 12:54:22 -04:00
Joffrey JAFFEUX	a8901efafe	FIX: flags report is now a lower is better kind of report	2018-05-25 12:59:39 +02:00
Gerhard Schlager	20b94bc714	FIX: Extraction of quoted posts failed in some cases * It stored only oneboxed "quotes" when [quote] and links to topics or posts were mixed. * Revising a post didn't add or remove records from the quoted_posts table.	2018-05-25 12:00:17 +02:00
riking	501bc0e9af	FIX: UserProfileView: Do not log IP of logged-in users	2018-05-25 15:54:14 +10:00
Régis Hanol	71f66cd679	FIX: ensure PostAlerter is always run in sidekiq	2018-05-24 17:27:43 +02:00
Guo Xiang Tan	3bfd9698c7	PERF: Avoid running the same query twice in `TopicViewSerializer#details`.	2018-05-24 16:46:13 +08:00
Guo Xiang Tan	b3860c82da	FIX: Don't enqueue web hooks inside a deferred queue. * The deferred queue is meant for short lived jobs and does not guarantee execution. We need to ensure that web hooks are always run.	2018-05-24 15:03:17 +08:00
Guo Xiang Tan	8a1aab4e8a	PERF: Select distinct active web hooks at the db level.	2018-05-24 14:56:40 +08:00
Gerhard Schlager	beed676b04	FIX: Check group names when checking username availability	2018-05-22 21:55:54 +02:00
Joffrey JAFFEUX	508b65b76a	UX: refactoring/refining tables of new dashboard	2018-05-22 16:47:23 +02:00
Guo Xiang Tan	f6becd6a4e	Merge pull request #5838 from discourse/fix-for-s3-subfolders FIX for bucket name in GlobalSetting with folder	2018-05-22 18:10:44 +08:00
Sam	1ac1ee4287	FEATURE: allow registration of an array custom field	2018-05-22 16:48:39 +10:00
riking	9b0efe9c84	FIX: TopicLinkClick: do not log IP of logged in users	2018-05-22 16:05:38 +10:00
Guo Xiang Tan	ae3a7ca08d	Fix unexpected return error.	2018-05-21 22:28:44 +08:00
Guo Xiang Tan	467d91347a	Missing specs for `Group`, `Tag`, `Category` and `Flag` web hooks.	2018-05-21 17:29:58 +08:00
Guo Xiang Tan	bf84037f79	FIX: Payload for webhooks should be current as of the time the event was triggered. https://meta.discourse.org/t/group-category-tag-user-deleted-webhooks-not-firing/87752	2018-05-21 17:29:58 +08:00
Arpit Jalan	290ee312e6	FIX: handle invalid mailto links	2018-05-18 18:02:52 +05:30
David Taylor	c168639be2	Add plugin outlet in admin theme list (#5837 ) This will be used by discourse-theme-creator to add avatars next to each theme.	2018-05-18 10:09:21 +02:00
Guo Xiang Tan	416d19af27	FIX: Wrong target user displayed for user actions in activity stream. https://meta.discourse.org/t/wrong-assigned-username-in-activity-list/73816	2018-05-18 11:28:13 +08:00
Joffrey JAFFEUX	af548c23c4	new dashboard quality pass (code, tests and UI)	2018-05-17 22:44:33 +02:00
Andrew Schleifer	bc89674b58	FIX for bucket name in GlobalSetting with folder When `s3_bucket="bucket/folder` in discourse.conf, absolute_base_url was bucket/folder.s3-region.amazonaws.com These names are bad, but this mirrors the s3_bucket/s3_bucket_name in S3Store N.B. that nearby s3_upload_bucket _should_ include the folder	2018-05-17 12:59:34 -05:00
Régis Hanol	53f8f6095d	FEATURE: staff action logs when creating/updating/deleting badges	2018-05-17 18:09:27 +02:00
Guo Xiang Tan	b3981ddc43	Shorten `User.suggest_name` further.	2018-05-17 16:35:03 +08:00
Guo Xiang Tan	147ea37115	FIX: Missing notification for watching first post users when topic is recategorized. https://meta.discourse.org/t/not-receiving-notifications-for-announcements/87275/2?u=tgxworld	2018-05-17 16:15:29 +08:00
Arpit Jalan	33899664ce	FIX: handle bad user profile website	2018-05-17 13:21:24 +05:30
Arpit Jalan	539cf32f87	FIX: handle encoded mailto links when looking for upload record	2018-05-17 12:44:53 +05:30
Guo Xiang Tan	117763493b	Refactor `User#suggest_name`. * Rename `email` to `string` as variable can be an email, username or any valid string.	2018-05-17 14:54:14 +08:00
Arpit Jalan	aee4045dd0	FIX: suggest name when username/name is provided	2018-05-17 10:36:36 +05:30
Sam	c381d60471	Replace the "posts" line with message count	2018-05-17 10:26:30 +10:00
Régis Hanol	39aceed63d	FIX: don't purge unactivated users with a message	2018-05-16 18:24:11 +02:00
Gerhard Schlager	ae6236d090	FIX: Changing owner of deleted reply didn't work	2018-05-16 17:03:09 +02:00
Régis Hanol	4103783821	FIX: don't use PMs in Incoming Links reports	2018-05-16 16:55:54 +02:00
Régis Hanol	5e97a9bfb7	FIX: tags in a 'visible by everyone but usable only by staff' group weren't visible by everyone	2018-05-16 09:48:19 +02:00
Sam	21e0b7c818	avoid async report pattern and replace with simpler hijack	2018-05-16 16:05:03 +10:00
Sam	3864091f2d	correct links to admins and moderators	2018-05-16 15:24:52 +10:00
Jeff Wong	74aecdfd9d	Feature: add a 30 seconds grace window for 2-factor token checks	2018-05-15 16:13:21 -07:00
Joffrey JAFFEUX	9947c38e1c	UX: support for multiple datasets in one chart	2018-05-15 20:12:03 +02:00
Régis Hanol	a512b181d9	FIX: automatically in/decrement topic_tags.pm_topic_count	2018-05-15 16:05:48 +02:00
Sam	fe89f441ae	correct reports	2018-05-15 15:12:27 +10:00
Sam	193b6d5651	UX: improve new dashboard - top referred topics - limit search logs to 8 results	2018-05-15 15:08:36 +10:00
Sam	eb33f6e9b9	correct daily engaged users to look at average	2018-05-15 10:17:17 +10:00
Régis Hanol	a28c58feb1	FIX: automatic group membership when using SSO	2018-05-15 01:48:30 +02:00
riking	cdcb0a396f	FIX: IncomingLink: do not log IP of logged-in users	2018-05-15 09:32:29 +10:00
Joffrey JAFFEUX	e474351ae4	inactive users report is not used anymore	2018-05-14 21:31:14 +02:00
Régis Hanol	e9abdaebbe	UX: show an enveloppe icon when a badge is used in messages - the badge count now includes messages - only show the message badges to admins	2018-05-14 19:02:00 +02:00
Joffrey JAFFEUX	34dbb32df4	FIX: makes report description optional	2018-05-14 16:34:56 +02:00
Joffrey JAFFEUX	83255d94d9	DateGroupable is not used anymore	2018-05-14 16:26:14 +02:00
Joffrey JAFFEUX	ba0cec2091	UX: minor fixes to new dashboard UI - adds a link to search log - display a text if log search queries is disabled - adds link to trust level and user types - adds a description for eeach report when browsing a report directly	2018-05-14 14:23:51 +02:00
Régis Hanol	3e06598e96	FIX: only unstage staged users	2018-05-14 12:03:15 +02:00
Sam	6332d5040d	UX: switch dashboard to be the new dashboard Also: - add pageviews - add problems and version sections	2018-05-14 13:07:59 +10:00
Sam	d6316ac4b9	add some more protection	2018-05-14 12:01:57 +10:00
Sam	9d97e1244e	correct it so when we have no dates we still return graphs	2018-05-14 11:12:52 +10:00
Régis Hanol	2cf6fb7359	FIX: always unstage users when they log in	2018-05-13 17:00:02 +02:00
Sam	4f508b2358	correct sorting in dashboard	2018-05-11 16:32:12 +10:00
Sam	67054d524d	correct missing day from async reports	2018-05-11 15:06:23 +10:00
Sam	8a783412b7	UX: improvements to new dashboard - remove inactive user report and replace with posts - clean up internals so grouping by week happens on client - when switching periods old report was not destroyed leading to bugs - calculate trend based on previous interval ... not previous 30 days - show percentages for mau/dau - be more careful about utc date usage - show uniqu and click through rate on search panel - publish key of report with report so we only load the correct one - subscribe earlier in channel in case of concurrency issues	2018-05-11 13:30:32 +10:00
Guo Xiang Tan	630a8ba3d8	Update annotations.	2018-05-09 07:52:45 +08:00
Arpit Jalan	d2f99419b7	Merge pull request #5809 from techAPJ/invite-redeem-fixes FIX: better handling of invite links after they are redeemed	2018-05-08 22:06:11 +05:30
Gerhard Schlager	badad80cdf	FIX: Use default locale for flag reason	2018-05-08 17:31:00 +02:00
Arpit Jalan	83245aa508	FIX: better handling of invite links after they are redeemed FIX: deprecate invite_passthrough_hours setting	2018-05-08 20:17:57 +05:30
Robin Ward	8262fc5d15	Merge pull request #5807 from discourse/min-flags-by-topic FEATURE: New site setting `min_flags_staff_visibility`	2018-05-08 09:17:29 -04:00
Robin Ward	ac60a84329	FEATURE: New site setting `min_flags_staff_visibility` When set higher than 1, flags won't show up for staff in the admin section unless the minimum threshold of flags on a post is reached.	2018-05-07 16:05:13 -04:00
Guo Xiang Tan	ee1eb1a5bd	FIX: Retrigger notification when a topic is recategorized. https://meta.discourse.org/t/notifications-when-a-topic-is-recategorized/63079	2018-05-07 21:29:06 +08:00
Misaka 0x4e21	ff6be3c2e3	FEATURE: add profile_background fields into SSO (#5701 ) Add profile_background and card_background fields into Discourse SSO.	2018-05-07 10:03:26 +02:00
Guo Xiang Tan	ad833c4485	FIX: Don't downcase group name.	2018-05-07 14:02:11 +08:00
Jeff Wong	91b31860a1	Feature: Push notifications for Android (#5792 ) * Feature: Push notifications for Android Notification config for desktop and mobile are merged. Desktop notifications stay as they are for desktop views. If mobile mode, push notifications are enabled. Added push notification subscriptions in their own table, rather than through custom fields. Notification banner prompts appear for both mobile and desktop when enabled.	2018-05-04 15:31:48 -07:00
Gerhard Schlager	ee426623e4	Dashboard next: correctly group inactive member count	2018-05-04 07:48:55 +02:00
Gerhard Schlager	41cd8c169c	Add specs for inactive users report	2018-05-04 07:48:55 +02:00
Sam	3a06cb461e	FEATURE: remove support for legacy auth tokens	2018-05-04 10:12:10 +10:00
Joffrey JAFFEUX	581d362627	fix spec	2018-05-03 17:39:37 +02:00
Joffrey JAFFEUX	980972182f	dashboard next: caching, mobile support and new charts	2018-05-03 15:41:41 +02:00
osamasayegh	4ebf46dc08	FEATURE: theme settings in RAW hbs templates	2018-05-03 10:43:07 +10:00
Kyle Zhao	0cc4b42180	FIX: TopicEmbed.import should update title and author	2018-05-02 17:12:31 +10:00
Joffrey JAFFEUX	691174fa8f	FEATURE: adds emoji search aliases	2018-05-01 15:43:49 +02:00
Gerhard Schlager	14e700fa50	Adds query for daily engaged users	2018-04-28 01:20:13 +02:00
Arpit Jalan	67357b84b9	FIX: only allow one user to be created per invite	2018-04-27 19:21:10 +05:30
Neil Lalonde	bd77795d7a	REFACTOR: move support for user card badge images to a plugin discourse-user-card-badges	2018-04-26 13:25:24 -04:00
Joffrey JAFFEUX	73a1be0d57	Fix spec	2018-04-26 17:19:44 +02:00
Joffrey JAFFEUX	b9c7e09a4e	linting	2018-04-26 15:21:02 +02:00
Joffrey JAFFEUX	9fabf2543b	dashboard next: activity metrics and new contributors This commit also introduces a better grouping of data points.	2018-04-26 14:49:41 +02:00
Gerhard Schlager	3f6d1a583e	Add helper for grouping by periods The methods are still experimental and might change without notice! You need to add `include DateGroupable` to your model before you can use it like this: `User.smart_group_by_date("users.created_at", start_date, end_date)`.count	2018-04-24 23:31:26 +02:00
Robin Ward	456e40a709	FIX: Don't allow a user to become TL3 if they've ever been penalized Previously the code would only check if they were currently suspended or silenced.	2018-04-24 15:15:32 -04:00
Gerhard Schlager	ed4c0c4a63	FEATURE: Add option to delete all replies of flagged post	2018-04-24 11:08:05 -04:00
Arpit Jalan	0a442977b3	FEATURE: add staff action log for post approvals	2018-04-23 11:28:44 +05:30
Guo Xiang Tan	9eabf7c02c	Fix randomly failing specs due to SearchLog cache.	2018-04-23 10:10:10 +08:00
Neil Lalonde	70f2c5d3fd	FEATURE: move staff tags setting to tag group settings	2018-04-20 15:34:23 -04:00
Arpit Jalan	91bf10bd12	FIX: create upload record for exported csv files	2018-04-20 00:27:49 +05:30
Joffrey JAFFEUX	58a53017c9	simplify code	2018-04-19 18:26:30 +02:00
Joffrey JAFFEUX	0e414d0890	dashboard next: trending search report This commit also improves how data is loaded sync and async	2018-04-19 18:19:21 +02:00
Régis Hanol	45850a0cd6	FIX: don't break when posting invalid URIs	2018-04-19 12:29:35 +02:00
Joffrey JAFFEUX	01c061d20d	dashboard next: perf and UI tweaks * cache CORE reports * adds backups/uploads section * few css tweaks	2018-04-18 21:30:41 +02:00
Neil Lalonde	8fc1289172	move topic excerpt code to one method to DRY it up and for extensibility	2018-04-17 15:08:21 -04:00
Joffrey JAFFEUX	2b8307c6c3	dashboard next: minor improvements * rename route to dashboard-next * better scaling of charts for large data sets * adjust trend position to avoid overlap * makes sure silenced/suspended is made on real users * correctly format data when only one data point * minor refactoring	2018-04-17 11:01:06 +02:00
Joffrey JAFFEUX	06b6c805d5	dashboard next: adds report for user types	2018-04-16 13:03:43 +02:00
Arpit Jalan	9353ae4b5d	Remove obsolete per topic unsubscribe page.	2018-04-16 16:11:20 +05:30
Neil Lalonde	3e9230714f	UX: moved posts message links to the first post at the destination topic	2018-04-13 12:47:36 -04:00
Arpit Jalan	00f59f648d	Merge pull request #5755 from techAPJ/flag-webhook FEATURE: webhook for flag events	2018-04-13 07:50:21 +05:30
Arpit Jalan	a16b616861	FEATURE: webhook for flag events	2018-04-13 07:47:58 +05:30
Guo Xiang Tan	6e46f81123	Add a distributed mutex around user creation via SSO. * When two SSO requests containing the same email in the payload are sent at the same time, it would sometimes result in two users being created but one without an email record. Investigations points to ActiveRecord not generating the right statements but we have no figured out the reproduction steps yet. We should review this after upgrading to Rails 5.2.	2018-04-12 16:18:49 +08:00
Vinoth Kannan	19e8f9af13	Remove support for theme settings in raw handlebar templates	2018-04-11 18:21:04 +05:30
Arpit Jalan	9ca6ebe8fe	FEATURE: enforce tagging on categories	2018-04-11 07:15:24 +05:30
Guo Xiang Tan	874003b7b1	FIX: Group can't be deleted if certain users are demoted.	2018-04-10 14:19:35 +08:00
Sam	fe37ce165d	correct issue where groups was never being blanked	2018-04-10 15:30:18 +10:00
Sam	afaeb20f27	FEATURE: Add option to have sso synchronize group membership In some cases add_groups and remove_groups is too much work, some sites may wish to simply synchronize group membership based on a list. When sso_overrides_groups is on all not automatic group membership is sourced from SSO. Note if you omit to specify groups, they will be cleared out.	2018-04-10 13:17:23 +10:00
Guo Xiang Tan	c82b2dcc24	Remove admin group management pages.	2018-04-09 15:14:50 +08:00
osamasayegh	ce1a6f2fd8	FEATURE: Theme settings in handlerbars templates	2018-04-09 16:47:28 +10:00
Neil Lalonde	e33aef729f	FIX: unable to save groups with mixed case names	2018-04-06 16:12:35 -04:00
Gerhard Schlager	cd6a99a027	FEATURE: Send a different PM when a post has been hidden more than once	2018-04-05 14:03:21 +02:00
Gerhard Schlager	f2d00e5eff	FEATURE: Use Message-ID for detecting email replies to group Ignores the site setting "find_related_post_with_key" and always tries to honor the `In-Reply-To` and `References` header for emails sent to a group. The senders email address must be included in the `To` or `CC` header of a previous email sent to the group and the `Message-ID` of that email must be included in the current email's `In-Reply-To` or `References` header.	2018-04-05 11:00:38 +02:00
Sam	f8637ed616	FIX: if a message is partially archived consider it not archived	2018-04-05 17:17:47 +10:00
Vinoth Kannan	434cbc649f	FEATURE: Webhook for tag events	2018-04-04 17:49:20 +05:30
Arpit Jalan	c36e201eb3	FIX: update categories topic_count when converting topic to a PM and vice versa	2018-04-04 12:01:56 +05:30
Guo Xiang Tan	00d879ec63	Fix the build.	2018-04-03 00:44:12 +08:00
Guo Xiang Tan	2498403bc3	Revert "FIX: Username uniqueness check should not happen to current user_id" This reverts commit `f71a18facd`.	2018-04-03 00:44:04 +08:00
Vinoth Kannan	f71a18facd	FIX: Username uniqueness check should not happen to current user_id	2018-04-02 21:59:11 +05:30
Guo Xiang Tan	221503cd10	FIX: Add server side uniqueness validations for `Group#name` and `User#username`. https://meta.discourse.org/t/groups-can-be-given-same-name-as-existing-username/74010	2018-04-02 18:19:18 +08:00
Guo Xiang Tan	d2a8f40fb0	Merge pull request #5711 from Supermathie/learn_cdn_url_hostname FIX: CDN_URL hostname should be in GlobalSetting.hostnames	2018-04-02 16:39:24 +08:00
Guo Xiang Tan	142571bba0	Remove use of `rescue nil`. * `rescue nil` is a really bad pattern to use in our code base. We should rescue errors that we expect the code to throw and not rescue everything because we're unsure of what errors the code would throw. This would reduce the amount of pain we face when debugging why something isn't working as expexted. I've been bitten countless of times by errors being swallowed as a result during debugging sessions.	2018-04-02 13:52:51 +08:00
Vinoth Kannan	efb19dbdaf	Merge pull request #5705 from discourse/new_webhooks FEATURE: Webhook for group and category events	2018-04-02 10:53:21 +05:30
Robin Ward	eab64710ff	FIX: Shared draft performance fix + missing avatars	2018-03-28 16:11:43 -04:00
Robin Ward	4b5977aa6a	Revert "PERF: Don't join on shared drafts unless you have to" This reverts commit `efedd9745f`.	2018-03-28 15:35:13 -04:00
Robin Ward	efedd9745f	PERF: Don't join on shared drafts unless you have to	2018-03-28 13:57:39 -04:00
Robin Ward	31d0998506	FIX: Don't allow links with no href	2018-03-28 12:32:16 -04:00
Michael Brown	976d6b290c	FIX: CDN_URL hostname should be in GlobalSetting.hostnames	2018-03-27 15:20:22 -04:00
Neil Lalonde	eb714d8ae3	FIX: application request count keys not expiring in redis	2018-03-27 15:12:39 -04:00
Neil Lalonde	2bd44bbf13	WebCrawlerRequest.clear_cache needs to clear user agent list too	2018-03-27 15:11:48 -04:00
Neil Lalonde	7311023a52	Merge pull request #5700 from discourse/crawl-block FEATURE: control web crawlers access with white/blacklist	2018-03-27 15:06:03 -04:00
Neil Lalonde	4d12ff2e8a	when writing cache, remove elements from the user agents list. also return a message and content type when blocking a crawler.	2018-03-27 13:44:14 -04:00
Arpit Jalan	518f7ba91b	FIX: show private message topic count on admin dashboard reports	2018-03-27 17:10:33 +05:30
Vinoth Kannan	e7407d0adc	FEATURE: Webhook for group and category events	2018-03-27 11:53:35 +05:30
Neil Lalonde	f2c060bdf2	FEATURE: option for tags in a tag group to be visible only to staff	2018-03-26 17:05:09 -04:00
Guo Xiang Tan	35745166b5	UX: New group membership management workflow. https://meta.discourse.org/t/adding-owners-members-ux-is-inconsistent-and-misleading/58084	2018-03-26 16:15:02 +08:00
Guo Xiang Tan	3d18cd1d9d	Raise error when timestamp is invalid when creating topic timers. https://meta.discourse.org/t/topic-timer-doesnt-work-for-fa-ir-locale/83702	2018-03-26 11:33:52 +08:00
Neil Lalonde	ced7e9a691	FEATURE: control which web crawlers can access using a whitelist or blacklist	2018-03-22 15:41:02 -04:00
Guo Xiang Tan	fa95699fde	Fix the build.	2018-03-22 14:20:27 +08:00
Guo Xiang Tan	f3b402ffd5	UX: Allow users to filter members on group page. * Only admins are allowed to filter users by email.	2018-03-22 14:02:41 +08:00
Guo Xiang Tan	bfe38b2118	FIX: `limit` wasn't correctly applied to `Upload.migrate_to_new_scheme`.	2018-03-22 10:56:06 +08:00
Arpit Jalan	d96c1058a2	FEATURE: add staff action log for 'restore topic'	2018-03-21 18:04:13 +05:30
Robin Ward	b9abd7dc9e	FEATURE: Shared Drafts This feature can be enabled by choosing a destination for the `shared drafts category` site setting. * Staff members can create shared drafts, choosing a destination category for the topic when it is published. * Shared Drafts can be viewed in their category, or above the topic list for the destination category where it will end up. * When the shared draft is ready, it can be published to the appropriate category by clicking a button on the topic view. * When published, Drafts change their timestamps to the current time, and any edits to the original post are removed.	2018-03-20 17:15:26 -04:00
Robin Ward	b39fbf7187	A staff member can hide another staff's member's post by flagging	2018-03-20 09:38:23 -04:00
Guo Xiang Tan	d0e7898fa0	Build `primary_email` association directly in `DiscourseSingleSignOn`.	2018-03-20 19:36:35 +08:00
Guo Xiang Tan	15bcfcd182	UX: Allow users to filter by different group types on groups page.	2018-03-20 17:38:11 +08:00
Guo Xiang Tan	69a53210d3	Improve `UserEmail#email` validation to use the index.	2018-03-20 10:22:06 +08:00
Neil Lalonde	4d44024c82	FIX: error when trying to block an IP address. Return a message when IP address matches an existing screened IP address, including ranges.	2018-03-19 14:34:43 -04:00
Guo Xiang Tan	0522aabaab	UX: Allow user_count on groups page to be sortable.	2018-03-19 16:15:13 +08:00
Guo Xiang Tan	9e8d10f711	Fix the build.	2018-03-19 12:34:21 +08:00
Guo Xiang Tan	52b9af10a1	PERF: PG queries for the `UserEmail#email` column was not using the index.	2018-03-19 11:31:14 +08:00
Arpit Jalan	f053e4cf37	Merge pull request #5682 from techAPJ/allowed-tags-page FIX: show only allowed tags on PM tags page and display correct count	2018-03-17 08:29:00 +05:30
Gerhard Schlager	864bdbd9b6	Fix the build	2018-03-16 22:55:42 +01:00
Gerhard Schlager	6c736a1fa4	FIX: Translation overrides for flag types didn't expire cache	2018-03-16 22:10:19 +01:00
Arpit Jalan	e9bc763440	FIX: show only allowed tags on PM tags page and display correct count FIX: tags page should link to user profile we are browsing	2018-03-17 00:17:48 +05:30
Guo Xiang Tan	c85e1fdb50	Revert "PERF: Query for email was not using index." This reverts commit `65eb046e69`.	2018-03-16 15:31:39 +08:00
Guo Xiang Tan	65eb046e69	PERF: Query for email was not using index.	2018-03-16 15:19:35 +08:00
Guo Xiang Tan	fe96ef6ed2	UX: Use topic list for displaying group messages on group page. https://meta.discourse.org/t/group-inbox-on-a-groups-page-mockup/71319	2018-03-16 11:56:40 +08:00
Guo Xiang Tan	937372df02	Merge pull request #5677 from jjaffeux/fix-ruby-warning-keyword FIX: prevents ruby warning with circular reference	2018-03-16 09:31:54 +08:00
Sam	5474635361	add more safety	2018-03-16 11:19:06 +11:00
Joffrey JAFFEUX	c0a986c181	FIX: prevents ruby warning with circular reference	2018-03-15 15:48:40 +01:00
Sam	c589564f6a	FIX: color schemes not updating when remote saves	2018-03-15 18:26:54 +11:00
Neil Lalonde	5ce8177662	FIX: unable to delete user belonging to a group that grants a trust level	2018-03-14 15:12:11 -04:00
Michael Brown	1b5549df58	FIX: my sso_overrides_username assumed username was passed	2018-03-13 18:29:11 -04:00
Arpit Jalan	7d375690c1	Merge pull request #5667 from techAPJ/pm-tags-page FEATURE: replace PM tags dropdown with a dedicated tags page	2018-03-13 13:08:21 +05:30
Arpit Jalan	24338fbbe8	FEATURE: replace PM tags dropdown with a dedicated tags page	2018-03-13 13:06:58 +05:30
Guo Xiang Tan	d5c828213f	FIX: Circular references warning in `TopicTrackingState`.	2018-03-13 08:35:15 +08:00
Robin Ward	65ac80b014	FEATURE: Log Staff edits in Staff Action Logs Why? Some edits by staff are not tracked. For example, during the grace period, or via the flags/silence dialog. If a staff member is editing someone else's post, it now goes into the Staff Action Logs so it can be audited by other staff members.	2018-03-12 13:51:40 -04:00
Arpit Jalan	82143a421c	FIX: `max topic invitations per day` should apply on PM invites as well FIX: do not apply `max topic invitations per day` on email invites	2018-03-12 23:17:58 +05:30
Sam	758b9a7dda	FEATURE: prototype of local theme directory watcher (note this will be documented a bit late)	2018-03-12 18:36:06 +11:00
Arpit Jalan	12706c4b29	FEATURE: support markdown rendering for embedded posts	2018-03-11 08:00:48 +05:30
Michael Brown	3c3d205180	FIX: sso_overrides_username may inappropriately change the username if the case changed	2018-03-09 16:06:55 -05:00
Guo Xiang Tan	0e1b896821	Explicitly assign primary_email record when creating a user * This looks like we're doing the same thing but we're debugging a race condition where a user can be created without an email record. Therefore, we prefer the more obvious method of assigning an association.	2018-03-09 15:59:46 +08:00
Sam	39e679d3cb	FEATURE: allow themes to live in private git repos This feature allows themes sourced from git to live on private servers, it automatically generates key pairs.	2018-03-09 16:14:38 +11:00
Guo Xiang Tan	a89f3160a5	Add new config to ensure backup/restore connects to PG directly. * In `pg_dump` 10.3+ and 9.5.12+, in it does a `SELECT pg_catalog.set_config('search_path', '', false)` which changes the state of the current connection. This is known to be problematic with Pgbouncer which reuses connections. As such, we'll always try to connect directly to PG directly during the backup/restore process.	2018-03-09 10:28:03 +08:00
Arpit Jalan	4b23634092	FIX: converting topic to message for a second time was broken	2018-03-08 17:59:04 +05:30
Arpit Jalan	0c2be8b775	Merge pull request #5655 from techAPJ/pm-tags-dropdown FEATURE: filter personal messages by tags	2018-03-08 16:30:38 +05:30
Arpit Jalan	a8149f8969	FIX: user should not be able to invite to PM if trust level requirment not met FIX: when personal messages are disabled let user invite to a public topic	2018-03-08 14:59:04 +05:30
Arpit Jalan	c29660c8f1	FEATURE: filter personal messages by tags	2018-03-08 14:42:07 +05:30
Neil Lalonde	1093dacc03	FIX: bulk importers need to create category description topics	2018-03-07 12:10:22 -05:00
Guo Xiang Tan	3045c589f6	FIX: Publish live messages to both team inbox and archive on update.	2018-03-07 14:01:20 +08:00
Guo Xiang Tan	5169be6080	FIX: User archiving message should also publish to sent section.	2018-03-07 11:39:23 +08:00
Guo Xiang Tan	bef35f7be5	FIX: User archive messages should only publish to the user.	2018-03-07 11:28:29 +08:00
Robin Ward	c74d10cf34	FIX: Consider live links in `<code>` as links when counting	2018-03-06 11:46:12 -05:00
Guo Xiang Tan	1365bab0d7	FEATURE: Live updates for user's messages page. https://meta.discourse.org/t/group-inbox-messages-not-updated-for-new-posts/38189	2018-03-06 18:15:21 +08:00
Guo Xiang Tan	13764b31ec	Remove unnecessary attribute in topic tracking payload.	2018-03-06 17:37:53 +08:00
Guo Xiang Tan	d576056cff	REFACTOR: Add basic tests for `TopicTrackingState#publish_`. Ensure we don't publish events for PMs.	2018-03-06 17:37:53 +08:00
Gerhard Schlager	8e48b339fa	Drop unused tables (#5630 )	2018-03-05 17:27:30 -05:00
Guo Xiang Tan	2f65393706	REFACTOR: Use `Topic#private_message?` to reduce duplication.	2018-03-05 15:39:22 +08:00
Guo Xiang Tan	07f1d90b88	FIX: Inviting a group that I am part of creates a notification. https://meta.discourse.org/t/inviting-a-group-to-a-message-does-not-trigger-a-notification-mail/50509/10?u=tgxworld	2018-03-05 13:51:32 +08:00
Guo Xiang Tan	42e0aaed61	FIX: Set first visit PM notification level to group default notification level. https://meta.discourse.org/t/notifications-not-received-for-private-messages-im-invited-to/71577/21?u=tgxworld	2018-03-05 13:39:00 +08:00
Sam	9331b4849d	FEATURE: we need access to settings in theme js	2018-03-05 15:35:41 +11:00
Sam	2c25b9ae12	annotate	2018-03-05 11:06:45 +11:00
OsamaSayegh	282f53f0cd	FEATURE: Theme settings (2) (#5611 ) Allows theme authors to specify custom theme settings for the theme. Centralizes the theme/site settings into a single construct	2018-03-04 19:04:23 -05:00
Robin Ward	31e3bf6d8d	FEATURE: New "Categories and Top" homepage style Select this option if you want to show top topics on the homepage instead of latest topics.	2018-03-03 14:26:57 -05:00
Robin Ward	730201d423	New interface to upsert custom fields	2018-03-02 12:45:52 -05:00
Arpit Jalan	334ed74346	Merge pull request #5635 from techAPJ/invite-muted FIX: do not allow invite notifications from muted user/topic	2018-03-02 18:10:17 +04:00
Guo Xiang Tan	6b59a2827d	Add more information to SSO user creation logging.	2018-03-02 18:27:15 +08:00
Guo Xiang Tan	642c60c310	Rename variable so that it is clearer which variable is being referred.	2018-03-02 16:41:02 +08:00
Arpit Jalan	2e202495a3	FIX: do not allow invite notifications from muted user/topic	2018-03-02 12:24:51 +05:30
Guo Xiang Tan	939180efa8	FIX: Missing 2FA guards when sso is enabled or when local login is disabled.	2018-03-02 10:39:10 +08:00
Gerhard Schlager	fffd1a6602	FIX: Associated Instagram account was missing at some places	2018-03-01 12:26:40 +01:00
Guo Xiang Tan	947b6fdf46	FIX: Incorrect rate limit applied to topics invitation flow.	2018-03-01 12:50:00 +08:00
Robin Ward	b283bb2ba7	FIX: Don't include unlisted topic in groups/posts	2018-02-28 14:40:18 -05:00
Guo Xiang Tan	e7a7356986	Remove ancient votes code that is no longer used.	2018-02-28 14:37:22 +08:00
Guo Xiang Tan	902c5d11cf	FIX: Don't allow other flag actions after `notify_moderator` has happened. https://meta.discourse.org/t/receiving-sorry-an-error-has-occurred-during-flagging-step-of-discobot-tutorial/77233/5	2018-02-28 11:27:56 +08:00
Gerhard Schlager	c22e56499a	FIX: Allow changing post owner even when validations fail	2018-02-27 15:46:20 +01:00
Guo Xiang Tan	66d620f7b1	FEATURE: Trigger topic webhook when topic status is updated.	2018-02-27 11:07:37 +08:00
Robin Ward	c7a37f391a	New event when a flag is handled	2018-02-26 18:51:51 -05:00
Gerhard Schlager	5ca5817902	FIX: Only likes should change the given daily likes	2018-02-26 22:27:18 +01:00
Guo Xiang Tan	c1f53e1ece	UX: Invited users should watch PM topic once topic has been visited. https://meta.discourse.org/t/notifications-not-received-for-private-messages-im-invited-to/71577/11	2018-02-26 17:58:58 +08:00
Guo Xiang Tan	982e5bae3a	Update annotations.	2018-02-26 15:32:04 +08:00
Guo Xiang Tan	6a88f7db61	Notification created for wrong user after invite. Introduced in `c64f09b6b7`	2018-02-26 13:21:19 +08:00
Guo Xiang Tan	31242335a6	Revert "Fix the build." This reverts commit `07f928e05e`.	2018-02-26 13:08:10 +08:00
Guo Xiang Tan	07f928e05e	Fix the build.	2018-02-26 12:42:55 +08:00
Guo Xiang Tan	c64f09b6b7	REFACTOR: Simplify and DRY `Group#invite`.	2018-02-26 11:59:07 +08:00
Arpit Jalan	709f201bd4	FIX: update group user count when bulk adding users	2018-02-23 14:29:56 +05:30
Sam	6f076963f2	FIX: incorrect caching of theme keys	2018-02-23 17:58:13 +11:00
Guo Xiang Tan	dd26bbe868	Merge pull request #5610 from discourse/pm-tags FEATURE: Allow staffs to tag PMs	2018-02-23 07:07:41 +08:00
Vinoth Kannan	7cbda949f1	REFACTOR: New spec tests and code improvement	2018-02-22 20:27:02 +05:30
Guo Xiang Tan	bbb30bedf3	Improve output of SSO verbose logging.	2018-02-22 11:26:13 +08:00
Sam	720e1965e3	FEATURE: add category suppress from latest In the past we used suppress_from_homepage, it had mixed semantics it would remove from category list if category list was on home and unconditionally remove from latest. New setting explicitly only removes from latest list but leaves the category list alond	2018-02-22 09:56:35 +11:00
Vinoth Kannan	2b509eaa91	Merge branch 'master' into pm-tags	2018-02-21 23:55:59 +05:30
Neil Lalonde	81e873138f	FIX: error when deleting a tag associated with a deleted topic	2018-02-21 12:35:53 -05:00
Vinoth Kannan	84ce1acfef	FEATURE: Allow staffs to tag PMs	2018-02-21 20:11:46 +05:30
Guo Xiang Tan	8964e75ad6	Merge pull request #5612 from discourse/featheredtoast-two-factor-login Featheredtoast two factor login	2018-02-21 15:00:10 +08:00
Guo Xiang Tan	14f3594f9f	Review Changes for `f4f8a293e7`.	2018-02-21 14:55:49 +08:00
Robin Ward	5c40ae9e63	FIX: Links in quotes should be counted for rate limits	2018-02-20 20:42:01 -05:00
Jeff Wong	f4f8a293e7	FEATURE: Implement 2factor login TOTP implemented review items. Blocking previous codes - valid 2-factor auth tokens can only be authenticated once/30 seconds. I played with updating the “last used” any time the token was attempted but that seemed to be overkill, and frustrating as to why a token would fail. Translatable texts. Move second factor logic to a helper class. Move second factor specific controller endpoints to its own controller. Move serialization logic for 2-factor details in admin user views. Add a login ember component for de-duplication Fix up code formatting Change verbiage of google authenticator add controller tests: second factor controller tests change email tests change password tests admin login tests add qunit tests - password reset, preferences fix: check for 2factor on change email controller fix: email controller - only show second factor errors on attempt fix: check against 'true' to enable second factor. Add modal for explaining what 2fa with links to Google Authenticator/FreeOTP add two factor to email signin link rate limit if second factor token present add rate limiter test for second factor attempts	2018-02-21 09:04:07 +08:00
Guo Xiang Tan	226ace1643	Update annotations.	2018-02-20 14:28:58 +08:00
Sam	86d12bd44b	FEATURE: search within title using in:title Also - Significantly improved search ranking, title is treated most strongly - Adds tag names to the index - Run search re-indexer more aggressively - Re-index topic and all posts on category change	2018-02-20 14:41:21 +11:00
Arpit Jalan	c419c26f56	FEATURE: new site setting 'max_emojis_in_title'	2018-02-19 18:15:26 +05:30
Neil Lalonde	991dfadad7	FIX: CategoryTagStat queries need to exclude PMs with tags	2018-02-15 12:13:42 -05:00
Arpit Jalan	f07b1a5c05	FIX: activate user even if email token is already confirmed	2018-02-14 20:44:48 +05:30
Sam	f028ffaf29	SECURITY: correct local onebox category checks Also removes ugly "source_topic_id" from cooked posts Patch was authored by @zogstrip Signed-off-by: Sam <sam.saffron@gmail.com>	2018-02-14 10:40:46 +11:00
Gerhard Schlager	5a56746610	FIX: Embedded topic was not found when URL contained query string	2018-02-14 00:28:30 +01:00
Robin Ward	4c9959f795	FIX: Don't allow silenced users to reach TL3	2018-02-12 17:20:11 -05:00
Neil Lalonde	76c309fe6b	PERF: a faster way to count tags used per category	2018-02-12 15:16:47 -05:00
Robin Ward	cee3337357	Don't allow users to auto-hide staff posts	2018-02-09 19:53:58 -05:00
Robin Ward	5466389f4e	FIX: Consider oneboxes links wrt to `min_trust_level_to_post_links`	2018-02-08 18:27:40 -05:00
Gerhard Schlager	0ecdf90023	FIX: Validations could prevent moving posts	2018-02-08 13:36:13 +01:00
Gerhard Schlager	8ab6689f43	FIX: Preserve original date when moving first post	2018-02-08 12:55:32 +01:00
Gerhard Schlager	890ffb1eb5	FIX: overriding _MF translations worked only for English	2018-02-07 12:47:15 +01:00
Sam Saffron	884b9d4b78	PERF: optimize performance of new topics query (home page) This ensures the bypass is always applied to query plan also, add frozen strings	2018-02-06 12:37:23 -05:00
Vinoth Kannan	e8559f222c	FIX: After moving the posts topic timestamp should be updated with newest post	2018-02-02 19:30:52 +05:30
Neil Lalonde	ef2a7ac0f7	FIX: admin reports would sometimes return fewer than 30 days of data, causing current 30 day period counts to be too small and prev30day counts to count the wrong days	2018-02-01 15:50:51 -05:00
Joshua Rosenfeld	f85055d653	FIX: Remove activation link from account approved email (#5548 )	2018-02-01 14:59:37 +01:00
Arpit Jalan	f88b8a8945	rename 'default_email_private_messages' to 'default_email_personal_messages'	2018-02-01 13:25:29 +05:30
Arpit Jalan	6be536ca50	rename 'max_private_messages_per_day' to 'max_personal_messages_per_day'	2018-02-01 13:25:29 +05:30
Arpit Jalan	25ec077eca	rename 'min_private_message_{post/title}_length' to 'min_personal_message_{post/title}_length'	2018-02-01 13:25:29 +05:30
Régis Hanol	4bcf9c5bf3	FIX: only count 'human' users in group.user_count	2018-01-31 21:55:01 +01:00
Arpit Jalan	1f6adbea5c	FEATURE: log private message views	2018-01-29 08:08:08 +05:30
Robin Ward	6b04967e2f	FEATURE: Staff members can lock posts Locking a post prevents it from being edited. This is useful if the user has posted something which has been edited out, and the staff members don't want them to be able to edit it back in again.	2018-01-26 14:01:30 -05:00
Gerhard Schlager	b784c1eda4	FIX: Remove all notifications of staged user during sign-up	2018-01-25 14:58:43 +01:00
Gerhard Schlager	d9515c37b3	FIX: Show message from discobot when staged user signs up	2018-01-25 14:58:43 +01:00
Gerhard Schlager	eb52c5469e	FEATURE: Allow plugins to register a new locale	2018-01-25 14:57:41 +01:00
Sam	c42bb94362	PERF: slow down optimizing images per host	2018-01-24 08:53:17 +11:00
Sam	bfd052a317	PERF: guard so we only create one optimized image per process This protectd sidekiq and other cases where optimized images are created on demand so they do not dominate the machine.	2018-01-24 08:22:28 +11:00
Gerhard Schlager	dde0fcc658	FEATURE: Allow sending invites to staged users	2018-01-22 15:37:18 +01:00
Kyle Zhao	83c549bd31	FEATURE: grant badges in post admin wrench (#5498 ) * FEATURE: grant badges in post admin wrench * only grant manually grantable badges * extract GrantBadgeController mixin	2018-01-22 14:10:53 +11:00
Rafael dos Santos Silva	70c5f6ae17	Merge pull request #5489 from discourse/fix-shared-s3-cdn FIX: Allow shared CDN for s3 and assets	2018-01-17 16:32:11 -02:00
Sam	b7023da894	PERF: reduce queries required for post timings - also freezes a bunch of strings - bypass active record for an exists query	2018-01-17 15:50:41 +11:00
Sam	2d2602edf0	no need to log anything if term is blank	2018-01-17 11:02:53 +11:00
Neil Lalonde	ce79ec0127	FIX: subfolder: top referred topics report was missing subfolder in links	2018-01-15 17:28:35 -05:00
Arpit Jalan	785d063a6b	Merge pull request #5496 from techAPJ/admin-graphs FIX: graphs should go to zero for missing dates	2018-01-15 11:10:29 +05:30
Arpit Jalan	b7ba490df7	FIX: graphs should go to zero for missing dates	2018-01-15 10:16:34 +05:30
Sam	bf68d394f4	PERF: handle debounce in redis cause SQL can be slow	2018-01-15 14:48:28 +11:00
Neil Lalonde	298ee26908	FIX: when deleting a tag, the warning modal has the wrong topic count	2018-01-12 16:35:27 -05:00
Neil Lalonde	ad58a1743b	rename topic_list.tags to topic_list.top_tags	2018-01-12 16:35:27 -05:00
Neil Lalonde	6d68275ef9	don't show tag groups if they're restricted to categories you can't access	2018-01-12 14:25:42 -05:00
Neil Lalonde	2493648f9c	PERF: calculate topic_counts for tags in an async job so tag queries that include counts are much faster	2018-01-12 11:03:03 -05:00
Rafael dos Santos Silva	b9a343afe7	FIX: Allow shared CDN for s3 and assets	2018-01-12 01:08:15 -02:00
Vinoth Kannan	b96ae14261	FEATURE: Display force_https warning in admin problems dashboard	2018-01-11 12:16:10 +05:30
Neil Lalonde	8f21c96ea5	FIX: don't downcase watched words on input since it can break the watched_words_regular_expressions setting	2018-01-09 16:51:59 -05:00
Guo Xiang Tan	e90187cbf7	Merge pull request #5469 from tgxworld/add_guard_to_prevent_primary_email_from_being_reassigned FIX: Add guard to prevent a primary `UserEmail` from being reassigned.	2018-01-09 13:35:08 +08:00
Vinoth Kannan	e5affdf230	FIX: URI must be ascii only for URI.parse command	2018-01-07 02:31:35 +05:30
Sam	0081de30a5	PERF: conserve memory while rebaking posts	2018-01-05 09:54:42 +11:00
Arpit Jalan	9030d3ef63	FIX: do not create duplicate topics https://meta.discourse.org/t/duplicate-http-https-topics-are-randomly-created/77190	2018-01-04 23:53:52 +05:30
Guo Xiang Tan	8a3bbcb19a	FIX: Add guard to prevent a primary `UserEmail` from being reassigned.	2018-01-04 19:40:50 +08:00
Guo Xiang Tan	ad02437358	FIX: Missing post/topic created web hooks due to race condition.	2018-01-03 17:24:01 +08:00
Guo Xiang Tan	9644569a28	FIX: Wildcard webhooks could send duplicated events.	2018-01-03 17:00:44 +08:00
Gerhard Schlager	38269c416d	FIX: return regular notification level for categories when not set by user	2017-12-30 20:36:58 +01:00
Arpit Jalan	6a38e4336b	FIX: use different variable name for referer record	2017-12-29 23:31:53 +05:30
Sam	c30ccceade	correct params	2017-12-27 13:51:16 +11:00
Sam	0c834515a9	FIX: only attempt old rebakes a maximum of 3 times	2017-12-27 12:44:41 +11:00
Gerhard Schlager	727a45185d	FIX: regex should behave the same in Ruby and Postgres	2017-12-21 11:26:56 +01:00
Guo Xiang Tan	6ecf37c482	Improve URL validation to check for a valid host. Parsing a URL with `URI` is not sufficient as the following cases are considered valid: URI.parse("http://https://google.com") => #<URI::HTTP http://https//google.com>	2017-12-21 13:50:15 +08:00
Régis Hanol	7f69362d9d	FIX: external links in whisper ended up in a white page FIX: clicking a link in a onebox wasn't properly extracting the post_id	2017-12-20 17:55:15 +01:00
Gerhard Schlager	86c86a1ddb	FIX: prevent loading of invalid locales from plugins	2017-12-20 12:14:39 +01:00
Philipp Daniels	6a2bce1931	FIX: Data loss on update of single user_field. https://meta.discourse.org/t/api-data-loss-caused-by-changed-behaviour-of-custom-user-field-update/74990	2017-12-20 16:33:23 +08:00
Sam	7aa56fc9d9	refinement and test for batch mode on feature_topics	2017-12-20 13:58:05 +11:00
Neil Lalonde	f5a3be750c	PERF: add option to limit how many categories are processed in one call to CategoryFeaturedTopic.feature_topics (#5446 )	2017-12-20 13:42:29 +11:00
Arpit Jalan	eab66065d1	FEATURE: search log term details page (#5445 )	2017-12-20 13:41:31 +11:00
Régis Hanol	24e89b6b38	FIX: validates 'ThemeField' name when used in a SCSS variable	2017-12-19 16:10:44 +01:00
Guo Xiang Tan	30ddc1f222	Don't swallow errors when failing to create message for post action.	2017-12-19 10:58:26 +08:00
Guo Xiang Tan	b39d3a863d	FIX: `moderators` group wasn't being updated to be messagable by everyone. https://meta.discourse.org/t/custom-flag-not-showing-text/76244	2017-12-19 10:14:56 +08:00
Sam	1abc276451	FIX: properly omit inactive and silenced users from directory	2017-12-19 12:53:59 +11:00
Régis Hanol	b91f83eb7d	Ignore auto-quote/reply when counting replies	2017-12-15 00:38:14 +01:00
Sam	f18dda2adc	FEATURE: full rebake of all old posts This limits to 100 post per 15 minutes, so it will take a while. This will pick up CommonMark and a large amount of onebox fixes.	2017-12-15 10:28:25 +11:00
Régis Hanol	092c976d7c	FIX: prevent 💥 when selecting replies to posts quoting themselves	2017-12-15 00:23:51 +01:00
Robin Ward	4fcf9ece3a	Allow plugins to customize the columns returned by user_actions This is useful if they have a different mechanism for rendering an avatar and want to include custom columns via the `custom_avatar_column` plugin function.	2017-12-14 16:52:54 -05:00
Guo Xiang Tan	f2565f6c7e	SECURITY: Any group can be invited into a PM.	2017-12-14 14:57:48 +08:00
Régis Hanol	5db3d39b05	FIX: Post.reply_ids should also handle quotes	2017-12-14 00:43:48 +01:00
Maja Komel	0f4ed2e070	display language name in user locale selector - make it consistent with admin (#5424 )	2017-12-14 08:17:36 +11:00
Régis Hanol	1b4483c942	FEATURE: Added 'select +below' and 'select +all replies' options to selecting posts	2017-12-13 22:12:06 +01:00
Neil Lalonde	712c9fca1b	sorry rubocop	2017-12-13 15:47:42 -05:00
Neil Lalonde	3f1d6a302e	FIX: links with query params to external sites fail to load if ga universal auto link domains is used	2017-12-13 13:58:44 -05:00
Guo Xiang Tan	d5293aeae2	Clean `Topic#slug` when `SiteSetting.slug_generation_method` changes. https://meta.discourse.org/t/removing-the-concept-of-slugs-for-some-languages/26643/24?u=tgxworld	2017-12-13 16:11:07 +08:00
Gerhard Schlager	a7c1b0c81f	FIX: path whitelist for embedded comments didn't work with non-ASCII chars	2017-12-12 20:17:46 +01:00
Gerhard Schlager	e30851e45a	Move escape_uri method to a more suitable place	2017-12-12 20:17:46 +01:00
Régis Hanol	af3c153687	make robocop 🤖 happy	2017-12-12 11:33:35 +01:00
Régis Hanol	62a5b174e1	FIX: wasn't able to use the same username when taking over a staged account	2017-12-12 11:26:00 +01:00
Guo Xiang Tan	4bd5acec47	FIX: `Topic#featured_link` may contain more than a URL.	2017-12-11 16:36:19 +08:00
Arpit Jalan	3c56c9b637	FIX: strip webhook payload_url	2017-12-11 13:48:11 +05:30
Robin Ward	74b9828731	FIX: Remove mentions filters from user and groups Additionally return no data if disabled	2017-12-07 16:29:02 -05:00
Robin Ward	4ae1bbaeba	FIX: Only show the full suspension reason on the admin side	2017-12-07 13:27:02 -05:00
Joffrey JAFFEUX	f0ef307d2d	FIX: topic timer offset applied two times timezone offset was calculated and sent from browser to server, it would be applied on utc time generated from '2013-11-22 5:00' format for example and then sent back to browser which would display it thinking it's UTC time using `moment(utc time)` when it's in fact an UTC time we have offseted with the initial user timezone. This is impossible to automatically test in the current app state. Easiest reproduction is in live browser after setting your timezone to `America/New_York`, when setting a topic timer to later_today, after save, the time under the topic should be off to something roughly equal +1/-1 hour to your timezone offset.	2017-12-07 14:42:58 +01:00
Arpit Jalan	daeb7694bc	update annotations	2017-12-05 21:03:20 +05:30
Guo Xiang Tan	e73fbfe265	FIX: `Topic#featured_link_root_domain` extracts URL before parsing.	2017-12-04 10:00:07 +08:00
Arpit Jalan	496cd3b4df	Merge pull request #5385 from techAPJ/search-logs-improvements FEATURE: support search click through tracking for user, category and tags	2017-12-01 12:08:38 +05:30
Arpit Jalan	e3925278e2	FEATURE: support search click through tracking for user, category and tags https://meta.discourse.org/t/search-logs-page/73281/11?u=techapj This commit adds following features: - support for tracking click through to user, tag and category - new filter for search type (header, full page) This commit also removes "most viewed topic" field from search logs page because we are now tracking multiple click through entities, so topic is not a special entity anymore. This also improves query perf. The query now takes `20.5ms` to runs, as opposed to `655.9ms` previously.	2017-12-01 12:04:55 +05:30
Vinoth Kannan	7f2eeaf767	FIX: Password required flag should be cleared whenever clearing the raw password (#5384 )	2017-12-01 15:19:24 +11:00
Vinoth Kannan	1ee48966ca	REVERT: FIX: Password required flag should be cleared whenever clearing the raw password	2017-11-30 16:17:14 +05:30
Vinoth Kannan	1776649b4d	FIX: Password required flag should be cleared whenever clearing the raw password	2017-11-30 13:40:18 +05:30
Guo Xiang Tan	853b51b519	Add uniqueness validation for `SingleSignOnRecord#external_id`.	2017-11-30 15:15:52 +08:00
Guo Xiang Tan	1c2d1682ae	Merge pull request #5328 from tgxworld/reenable_interpolation_keys_check FIX: Re-enable invalid interpolation keys check and allow default key…	2017-11-30 13:04:54 +08:00
Guo Xiang Tan	9fbe1436b6	UX: Replace heuristic solution root domain extraction for topic featured link.	2017-11-29 21:52:41 +08:00
Guo Xiang Tan	bb0b7b61d7	FIX: Don't fail silently when updating a record.	2017-11-29 08:01:13 +08:00
Robin Ward	23ee3047bf	FIX: Future date input selector was not respecting timezone	2017-11-28 13:44:24 -05:00
Robin Ward	77f90876d3	REFACTOR: Track manual locked user levels separately from groups	2017-11-27 11:23:44 -05:00
Guo Xiang Tan	5805979e88	FIX: Re-enable invalid interpolation keys check and allow default keys to be left out of translation overrides. https://meta.discourse.org/t/bulk-invite-from-file-resets-the-invite-forum-mailer-customized-text/67606/16	2017-11-27 11:00:08 +08:00
Gerhard Schlager	b3094e9954	FIX: incoming and outgoing emails got lost when post was moved	2017-11-24 11:45:36 +01:00
Arpit Jalan	406ad1a1f2	Merge pull request #5357 from techAPJ/invite-trust-level FIX: invited users were not granted trust level based on their group	2017-11-23 23:42:20 +05:30
Robin Ward	ad07e6e172	FEATURE: `group_removes_trust_level` setting By default in Discourse, if a group grants a user a particular trust level that is locked even if they are removed from the group. With this new setting, when a user is removed from a group their trust level is set to either the next highest trust level based on group membership, or they are unlocked and promoted based on the default mechanisms.	2017-11-23 13:03:24 -05:00
Arpit Jalan	3508046e33	FIX: invited users were not granted trust level based on their group https://meta.discourse.org/t/bulk-invites-and-trust-level/73535 If the user enters password when accepting invite they were not granted trust level based on their group privileges. It was because `password_required` was set to true when creating user record and when the user was updated again when granting trust level the password validation was raising error saying that the password is empty. This commit fetches fresh user record after the user is created so that the user record can be updated successfully.	2017-11-23 22:19:28 +05:30
Gerhard Schlager	39810e4425	FIX: do not move small post actions	2017-11-23 17:25:53 +01:00
Neil Lalonde	6c86e0c94a	FEATURE: remove the featured link by editing the topic	2017-11-22 14:53:35 -05:00
Guo Xiang Tan	f7642e076d	REFACTOR: Avoid duplicated logic on server and client.	2017-11-21 17:10:04 +08:00
Régis Hanol	2d48caffdf	FIX: be more lenient when deleting a custom emoji	2017-11-20 23:50:23 +01:00
Sam	7e841a0495	FIX: stop counting PMs, deleted topics and whispers in directory and user stats	2017-11-20 16:44:09 +11:00
Gerhard Schlager	92a831bae6	FEATURE: user directory returns staged users during search	2017-11-19 01:17:31 +01:00
Neil Lalonde	6dda87c49b	FEATURE: show topics viewed on user summary	2017-11-17 17:53:30 -05:00
Neil Lalonde	87ec11e298	FIX: more accurate counting of posts read. Skipping to the end of a topic does not count all posts as read in user stats.	2017-11-17 16:08:46 -05:00
Gerhard Schlager	8f6d35aa59	FEATURE: category setting for mailinglist mirror	2017-11-17 15:29:14 +01:00
Neil Lalonde	b37e40eea9	FEATURE: show read time in last 60 days	2017-11-16 15:46:51 -05:00
Régis Hanol	678e28794a	FIX: properly handle too large & broken images in posts	2017-11-16 15:45:07 +01:00
Sam	174ab2d93a	minor, ensure ordering of custom fields is consistent	2017-11-16 15:14:10 +11:00
Sam	20fbf81505	FEATURE: Allow plugins to easily add defaults to GlobalSetting usage: GlobalSetting.add_default("plugin_setting_name", "value")	2017-11-16 08:39:29 +11:00
Gerhard Schlager	9207dee69a	FEATURE: escape HTML when cooking plaintext emails	2017-11-15 20:22:11 +01:00
Robin Ward	9e03b5c69a	FIX: Don't load other locales in test mode	2017-11-15 12:50:20 -05:00
Robin Ward	fc73de9578	Support for finding new locales in plugins	2017-11-15 11:20:04 -05:00
Vinoth Kannan	cbc0afb399	REFACTOR: Instance methods added to 'PluginStore' model for easy access (#5315 )	2017-11-15 10:10:20 -05:00
Arpit Jalan	2e7c61681e	PERF: n+1 query when fetching search_logs	2017-11-15 16:23:57 +05:30
Vinoth Kanan	9ed16343fc	Remove email column from schema information	2017-11-15 15:45:19 +05:30
Arpit Jalan	ee1f68438e	UX: sort search logs results by unique searches	2017-11-15 12:58:40 +05:30
Arpit Jalan	3831663fea	FEATURE: search logs page (#5313 )	2017-11-15 11:13:50 +11:00
Robin Ward	971e302ff2	FEATURE: Support an end date for user silencing	2017-11-14 13:20:19 -05:00
Gerhard Schlager	4be8f17e66	FIX: counting invites didn't work PostgreSQL reported the following error: "for SELECT DISTINCT, ORDER BY expressions must appear in select list"	2017-11-14 11:40:07 +01:00
Sam	075a458489	FIX: child theme component vars not resolved in parent	2017-11-14 15:22:59 +11:00
Gerhard Schlager	d3baae5365	removes whitespaces and uses scope	2017-11-13 15:23:24 +01:00
Robin Ward	1f14350220	Rename "Blocked" to "Silenced"	2017-11-10 14:10:27 -05:00
Neil Lalonde	ec3d800492	add option to force DirectoryItem.refresh_period! to run even if user directory is disabled	2017-11-10 12:30:22 -05:00
Neil Lalonde	16ff2a4715	FIX: topic counts after converting topic to/from public and private	2017-11-09 15:33:44 -05:00
Michael Howell	38b8d68c68	FEATURE: Allow the user to select a custom home page (#5268 ) * Add user_home configuration option * Use the new user_home preference to actually show the right home page * Fix trailing whitespace * Update user_option_serializer.rb * Fix JavaScript default homepage tests * Use an object instead of a giant switch * Remove trailing whitespace * Make the default `user_home` set to `null` instead of `0` * Rename user_home to homepage_id	2017-11-10 06:45:19 +11:00
Arpit Jalan	b21d5d3633	FIX: SSO email match should be case insensitive	2017-11-08 20:37:41 +05:30
Guo Xiang Tan	6090994cdf	FEATURE: Retain the latest 30 days of WebHookEvent records by default.	2017-11-08 14:11:01 +08:00
Guo Xiang Tan	9abeaa4719	Revert "Validates presence of `UserEmail#user_id` in AR." This reverts commit `0dec3269d8`.	2017-11-08 11:54:18 +08:00
Guo Xiang Tan	0dec3269d8	Validates presence of `UserEmail#user_id` in AR.	2017-11-08 11:43:41 +08:00
Guo Xiang Tan	4bb454d889	FIX: JSON custom fields incorrectly being converted to an array. https://meta.discourse.org/t/custom-fields-simultaneous-save-with-json-becomes-an-array/73647	2017-11-08 11:17:37 +08:00
Guo Xiang Tan	9355f92f78	Add more verbose SSO logging.	2017-11-07 19:38:36 +08:00
Guo Xiang Tan	95c891cf11	Raise error if sso record fails to create.	2017-11-07 18:38:38 +08:00
Guo Xiang Tan	b3237d37f0	Drop unused email column from users table.	2017-11-07 10:12:33 +08:00
Guo Xiang Tan	d320f4840d	FIX: Unable to invite groups that are not public visible into pms. https://meta.discourse.org/t/inviting-groups-broken-in-head/73346/6	2017-11-03 21:40:33 +08:00
Neil Lalonde	c7d7cb940c	FIX: dashboard posts report was including posts in daily data, but not in totals	2017-11-02 18:46:28 -04:00
Neil Lalonde	24af9b7d97	FIX: when a topic is deleted, update the post count stats of all user who replied	2017-11-02 18:05:23 -04:00
Guo Xiang Tan	edf4af608e	FIX: Better match when searching for groups.	2017-11-02 10:20:14 +08:00
Robin Ward	076df104dc	FEATURE: Support filtering of groups page by category if in url	2017-10-31 17:50:06 -04:00
Neil Lalonde	d753adab84	FIX: badge description links broken on subfolder	2017-10-31 15:18:52 -04:00
Robin Ward	e02ad4249e	FIX: In case that `category` is `nil` it should not throw an error	2017-10-30 11:59:13 -04:00
Robin Ward	00bc79439a	FIX: Couldn't disagree with "notify moderator" flags	2017-10-30 10:52:00 -04:00
Sam	fab3e25101	FIX: badge selector showing up for anon	2017-10-30 16:21:31 +11:00
Robin Ward	530624d438	FIX: Couldn't agree with a custom flag type	2017-10-26 14:41:11 -04:00
Guo Xiang Tan	f1615c2148	Merge pull request #5263 from tgxworld/improve_pattern REFACTOR: Always validate email by default.	2017-10-26 14:34:09 +08:00
Guo Xiang Tan	defea6245c	REFACTOR: Always validate email by default.	2017-10-25 13:48:34 +08:00
Sam	0d816302e2	Explicitly avoid all readonly protection and scoping	2017-10-25 13:31:44 +11:00
Sam	877b7be579	FIX: in readonly mode don't double count pages	2017-10-25 13:19:43 +11:00
Guo Xiang Tan	19f3b81161	Revert "FIX: always trigger the ':user_updated' event" This reverts commit `519b70ea46`. https://meta.discourse.org/t/creating-a-topic-or-a-post-sends-the-user-updated-webhook/71643	2017-10-23 11:44:22 +08:00
Robin Ward	e00d330579	FIX: Defer wasn't working on all flag types	2017-10-20 10:04:55 -04:00
Gerhard Schlager	4205c1ad2b	FIX: postprocessing ignored cook method	2017-10-20 10:26:45 +02:00
Robin Ward	aad5118aa9	FIX: Post Action Type 6 is not a notify type	2017-10-19 17:13:55 -04:00
Robin Ward	7cfb8ed5c1	FIX: You can't notify a user on a flag topic	2017-10-19 14:11:31 -04:00
Robin Ward	838568cbc3	Refactor flag types for more customization	2017-10-19 13:55:23 -04:00
Gerhard Schlager	1cae875146	FIX: topic link extraction shouldn't fail when the parsed URL has no path	2017-10-19 15:26:37 +02:00
Gerhard Schlager	3cd73cdf18	FIX: fancy topic title must fit into column	2017-10-19 14:34:30 +02:00
Guo Xiang Tan	22ba70fb01	Merge pull request #5226 from tgxworld/allow_user_to_disable_private_messages FEATURE: Allow users to disable new PMs.	2017-10-19 16:46:18 +08:00
Guo Xiang Tan	5b9ddaf972	FIX: `Topic#fancy_title` should not write in readonly mode.	2017-10-19 16:07:03 +08:00
Guo Xiang Tan	25c25ae423	FEATURE: Allow user to leave a PM.	2017-10-19 12:32:55 +08:00
Guo Xiang Tan	79de10b212	FEATURE: Allow users to disable new PMs. https://meta.discourse.org/t/is-it-possible-to-disable-private-messaging-for-a-specific-user/46391	2017-10-19 12:32:55 +08:00
Guo Xiang Tan	b54eb8f53c	FIX: Set PG `connect_timeout` to 5 seconds. * 30 seconds is alittle too long.	2017-10-17 12:32:41 +08:00
Robin Ward	f73a3cc0d4	Don't include suspended_at or suspended_till unless suspended	2017-10-13 12:17:54 -04:00
Guo Xiang Tan	4e89d3f778	Only refresh site settings once on initialization.	2017-10-12 14:12:18 +08:00
Arpit Jalan	a2183c3f1d	SECURITY: verify that inviter can invite new user to a topic	2017-10-09 15:59:41 +05:30
Sam	4ea87b5ab8	Merge branch 's3_refactor'	2017-10-09 10:27:52 +11:00
Régis Hanol	8d14d55fc5	make rubocop happy	2017-10-06 16:48:11 +02:00
Régis Hanol	3bdd8f57c1	FIX: invited staged users would sometimes not get notified of replies	2017-10-06 16:37:28 +02:00
Sam	70bb2aa426	FEATURE: allow specifying s3 config via globals This refactors handling of s3 so it can be specified via GlobalSetting This means that in a multisite environment you can configure s3 uploads without actual sites knowing credentials in s3 It is a critical setting for situations where assets are mirrored to s3.	2017-10-06 16:20:01 +11:00
Guo Xiang Tan	d67f0b39ae	Update annotations.	2017-10-06 11:13:01 +08:00
Guo Xiang Tan	5dc4b469be	Remove unused code for Redis Sentinel.	2017-10-05 14:53:03 +08:00
Guo Xiang Tan	b0557c6692	UX: Allow users to remove a remind me topic timer.	2017-10-05 11:50:08 +08:00
Neil Lalonde	f5a2ed99b0	FIX: deleting category background images sometimes has no effect	2017-10-04 17:04:37 -04:00
Régis Hanol	e212435545	FIX: redirect to top wasn't working	2017-10-04 22:08:41 +02:00
Guo Xiang Tan	1310181664	FIX: Adding a public topic timer deletes a private topic timer.	2017-10-04 16:31:40 +08:00
Kyle Zhao	0342324b47	FEATURE: support regex in rake post:remap (#5201 )	2017-10-04 11:47:53 +11:00
Robin Ward	4fbe4218c4	FIX: Header primary color was too dark in dark mode	2017-10-03 13:01:05 -04:00
Robin Ward	00b190af75	Revert "A safe way to create class variables in a multisite environment." The approach taken by this interface was flawed. We need a better solution.	2017-09-29 11:06:12 -04:00
Arpit Jalan	d64853dfa0	FIX: update group.has_messages field weekly	2017-09-29 08:23:07 +05:30
Guo Xiang Tan	30fa5379ce	Merge pull request #5195 from henrik/patch-1 100.years.ago -> Time.at(0)	2017-09-28 15:47:06 +08:00
Sam	8ecf313a81	FIX: correctly raise errors when downloads fail This corrects an issue where we are hitting Gravatar for 404 over and over Also ensures file download properly reports errors	2017-09-28 16:35:43 +10:00
Sam	b80320da5e	no verbose logging for failed downloads of gravatars	2017-09-28 11:32:26 +10:00
Robin Ward	3e13becf33	A safe way to create class variables in a multisite environment. This should allow plugins to set class variables that will not stomp on other plugins.	2017-09-27 13:00:47 -04:00
Guo Xiang Tan	367fb1c524	FIX: Onebox fails on encoded URL. https://meta.discourse.org/t/onebox-breaks-if-theres-chinese-text-in-url/67364	2017-09-26 18:34:54 +08:00
Guo Xiang Tan	69e170efe8	Require right dependency.	2017-09-26 17:28:53 +08:00
Guo Xiang Tan	c37598ddbc	Merge pull request #5200 from gschlager/embed FIX: do not escape already escaped chars in URL	2017-09-26 09:07:57 +08:00
Robin Ward	09ed2ed749	Add Suspend User to flags page	2017-09-25 12:28:00 -04:00
Robin Ward	d7c37d9369	Add front end service for staff controls	2017-09-25 12:25:14 -04:00
Robin Ward	40eba8cd93	FEATURE: View flags grouped by topic	2017-09-25 12:25:14 -04:00
Guo Xiang Tan	88555f32cf	Improve specs.	2017-09-25 13:49:00 +08:00
Guo Xiang Tan	e542884b00	FIX: Incorrect notification state being published.	2017-09-25 13:48:59 +08:00
Guo Xiang Tan	23b787e0a6	Require dependency otherwise it causes Sidekiq to lock up in development.	2017-09-25 13:48:59 +08:00
Guo Xiang Tan	77d4c4d8dc	Fix all the errors to get our tests green on Rails 5.1.	2017-09-25 13:48:58 +08:00
Gerhard Schlager	6f6b47f096	FIX: do not escape already escaped chars in URL	2017-09-22 17:36:44 +02:00
Gerhard Schlager	1a435414d5	FIX: handle URL encoded email addresses	2017-09-22 14:26:06 +02:00
Henrik Nyh	77cc33b231	100.years.ago -> Time.at(0) A bit more robust ;)	2017-09-19 08:48:50 +01:00
Régis Hanol	8ed318c4fe	display 'similar to' earlier when composing a post	2017-09-16 01:03:29 +02:00
Régis Hanol	797936d2c5	FIX: don't leak whisper count in user card	2017-09-14 20:08:16 +02:00
Gerhard Schlager	f3d3129113	FIX: Use default locale for edit reason when owner of post gets changed	2017-09-14 17:17:37 +02:00
Gerhard Schlager	efef422416	FIX: Use default locale for moderator post when posts are moved	2017-09-14 17:17:37 +02:00
Guo Xiang Tan	26c6447161	Fix bugs in profiling scripts leading to incorrect results.	2017-09-13 15:33:59 +08:00
Neil Lalonde	6831efe2e9	FIX: no notification was being sent when a post is hidden by community flags	2017-09-12 15:43:44 -04:00
Leo McArdle	104d97695d	FIX: don't activate un-confirmed email on omniauth authentication (#5176 )	2017-09-12 17:36:17 +02:00
Guo Xiang Tan	d3a409456f	PERF: Bypass AR and execute SQL directly.	2017-09-12 17:52:13 +08:00
Darren Lee	90dd1609eb	FIX: memoization in PostAnalyzer.raw_mentions (#5172 ) Due to a missing 's' when assigning the computed value to @raw_mentions, the raw_mentions function in PostAnalyzer would never retrieve a memoized value.	2017-09-11 20:01:24 +02:00
Neil Lalonde	d7d9923b8e	FIX: display email validation error messages	2017-09-11 13:22:14 -04:00
David Taylor	1def49cf6c	SECURITY: Only publish PM reply messagebus notifications to allowed users	2017-09-08 14:12:15 -07:00
Guo Xiang Tan	5d4221fbe1	PERF: Avoid calling expensive `PostGuardian#can_see_post?` multiple times. Before ``` Your Results: (note for timings- percentile is first, duration is second in millisecs) --- topic_admin: 50: 19 75: 19 90: 21 99: 27 topic: 50: 56 75: 62 90: 64 99: 99 timings: load_rails: 1262 ruby-version: 2.4.1-p111 rss_kb: 198432 pss_kb: 136612 virtual: physical architecture: amd64 operatingsystem: Ubuntu memorysize: 15.59 GB kernelversion: 4.10.0 physicalprocessorcount: 1 processor0: Intel(R) Core(TM) i7-6700K CPU @ 4.00GHz rss_kb_9877: 327892 pss_kb_9877: 263671 rss_kb_9946: 325468 pss_kb_9946: 261671 rss_kb_10153: 326456 pss_kb_10153: 262657 ``` After ``` Your Results: (note for timings- percentile is first, duration is second in millisecs) --- topic_admin: 50: 18 75: 18 90: 20 99: 28 topic: 50: 41 75: 42 90: 46 99: 49 timings: load_rails: 1201 ruby-version: 2.4.1-p111 rss_kb: 187936 pss_kb: 123596 virtual: physical architecture: amd64 operatingsystem: Ubuntu memorysize: 15.59 GB kernelversion: 4.10.0 physicalprocessorcount: 1 processor0: Intel(R) Core(TM) i7-6700K CPU @ 4.00GHz rss_kb_26478: 342360 pss_kb_26478: 276696 rss_kb_26547: 340368 pss_kb_26547: 275930 rss_kb_26747: 338964 pss_kb_26747: 274466 ```	2017-09-08 14:07:24 +08:00
David Taylor	7d350d0d75	Revert plugin js changes (#5139 ) * Revert "Add disabled_plugins to preloadstore for login_required anonymous users (#5134)" This reverts commit `b840170f8d`. * Revert "Do not load javascripts for disabled plugins (#5103)" This reverts commit `a14ab48829`.	2017-09-07 15:15:29 +02:00
Régis Hanol	8a935a4b5f	FEATURE: new badges when visiting the forum for 10, 100 and 365 consecutive days	2017-09-06 22:35:08 +02:00
David Taylor	b840170f8d	Add disabled_plugins to preloadstore for login_required anonymous users (#5134 )	2017-09-06 12:18:58 +02:00
Guo Xiang Tan	672b7cb9a5	Require missing dependency.	2017-09-05 09:39:56 +08:00
Guo Xiang Tan	7786c6c6f2	Remove duplicated scope.	2017-09-05 09:15:06 +08:00
Joffrey JAFFEUX	afe6f46b03	merges after_save	2017-09-04 13:40:11 +02:00
Joffrey JAFFEUX	caedefd675	FIX: correctly resets user_themes template This commit adds tests for this behaviour and also adds support for reseting cache when updating a theme name and destroying a theme.	2017-09-04 13:27:58 +02:00
Arpit Jalan	66f2925348	SECURITY: do not include links from whispers in topic summary map https://meta.discourse.org/t/staff-whispers-links-in-whispers-showing-up-publicly-in-topics-summary/69134?u=techapj	2017-08-31 23:44:54 +05:30
Sam	c705159d22	Remove email column from user table	2017-08-29 11:50:56 -04:00
Sam	b3fd091379	annotate stuff	2017-08-29 10:48:22 -04:00
Bianca Nenciu	6bc74ceb50	Split alias levels in mentionable and messageable levels. (#5065 ) * Split alias levels in mentionable and messageable levels. * Fixed some tests. * Set messageable level to everyone by default. * By defaults, groups are not mentionable or messageable. * Made staff groups messageable by the system.	2017-08-28 12:32:08 -04:00
Neil Lalonde	398604ac71	FEATURE: set purge_unactivated_users_grace_period_days to 0 to disable purging unactivated users	2017-08-25 15:20:06 -04:00
Neil Lalonde	2c56f8df7c	FEATURE: show tags in search results	2017-08-25 11:52:59 -04:00
Guo Xiang Tan	0531ef2e20	Fix calling `exists?` on Arrays.	2017-08-24 09:56:07 +09:00
Guo Xiang Tan	91d3929f52	Merge pull request #5078 from lelelelemon/master change count>0 to exists	2017-08-24 09:24:42 +09:00
junwen yang	8124f26a6e	change count>0 to exists	2017-08-23 22:54:51 +00:00
Sam	f766ea4257	Correct short url decoding for sha1s leading with zero This was picked up cause we had a flaky test!	2017-08-23 11:08:18 -04:00
Neil Lalonde	224796a7d4	FIX: wrongs counts on tags with deleted topics	2017-08-22 16:55:05 -04:00
Sam	bcf7dc38c2	FEATURE: server side support for upload:// markdown This allows uploads to be specified using short sha1 hash instead of full URL Client side change is pending	2017-08-22 11:46:23 -04:00
Arpit Jalan	b00747fd49	FIX: do not create topic link reflection for unlisted topics	2017-08-22 14:28:01 +05:30
Guo Xiang Tan	29a9e0c4d2	Fix the build.	2017-08-22 15:52:24 +09:00
Guo Xiang Tan	bc3e43b496	FIX: Topic timers being incorrectly `trashed!`. https://meta.discourse.org/t/temporary-timed-closure-of-topic-not-re-opening-topic/67877	2017-08-22 15:23:09 +09:00
Guo Xiang Tan	87994a86ce	FIX: Don't set topic timer for close topics when changing category. https://meta.discourse.org/t/moving-a-topic-after-closure-reopens-topic/67659/4	2017-08-22 12:54:34 +09:00
Sam	c2a6616035	Correct erratic spec failure	2017-08-17 15:26:31 -04:00
Jen	d29fc781fb	trigger for other backup choices	2017-08-17 10:34:24 -04:00
Jen	b5823a3b03	add event for other backup choices	2017-08-17 10:34:24 -04:00
Régis Hanol	629810bd07	FIX: when registering custom_field types, ensure we're casting them before checking for equality	2017-08-16 23:04:40 +02:00
Robin Ward	b78958fbfc	Silence CSS logging in development - it's way too noisy	2017-08-16 10:59:56 -04:00
Sam	c68999e128	annotate models WARNING annotators out there, be to run bin/annotate on RAILS_ENV=test on a clean db	2017-08-16 10:38:11 -04:00
Guo Xiang Tan	ed851dbfff	FIX: Avoid publishing a gigantic payload. * Certain sites have way too many categories.	2017-08-16 11:38:30 +09:00
Erick Guan	1146772deb	Fix: unlinked topic search model (#5044 )	2017-08-15 11:46:57 -04:00
Neil Lalonde	94d8f6d734	FIX: digest emails should not include posts that are still in the edit grace period	2017-08-14 12:47:33 -04:00
Régis Hanol	c2061aae3d	Add new 'post_moved' event	2017-08-12 04:12:09 +02:00
Régis Hanol	4f09a5a7a5	Add 'Post.permitted_create_params' to allow plugins to add new params when creating a post	2017-08-12 04:10:45 +02:00
Neil Lalonde	9813f9f0f8	FIX: more cases of case sensitive group membership in sso	2017-08-11 18:09:29 -04:00
Neil Lalonde	15a74d6d3e	FIX: don't enforce newuser_spam_host_threshold on private messages	2017-08-10 17:19:08 -04:00
Guo Xiang Tan	b84e87dedd	FIX: Don't raise an error if URL timesout.	2017-08-10 12:58:56 +09:00
Guo Xiang Tan	b404a4b97c	Merge pull request #5034 from tgxworld/fix_staged_primary_email FIX: Staged users are still missing primary email.	2017-08-10 10:30:51 +09:00
Neil Lalonde	ca1609c821	FIX: user directory didn't update stats of users with no recent activity	2017-08-09 15:57:42 -04:00
Guo Xiang Tan	90d7dd1f05	FIX: Ensure that post action moderation post uses the site's default locale. https://meta.discourse.org/t/a-post-in-looking-for-someone-to-customize-discourse-to-create-a-forum-site-requires-staff-attention/67468/5?u=tgxworld	2017-08-09 18:20:20 +09:00
Guo Xiang Tan	0bc690ed11	FIX: Staged users are still missing primary email.	2017-08-09 12:03:49 +09:00
Régis Hanol	d182f0f2d1	Add support for preloaded custom_fields on Group	2017-08-08 15:45:27 +02:00
Guo Xiang Tan	f496302c2c	`order` scope is ignored when using `find_each`.	2017-08-07 11:46:18 +09:00
Guo Xiang Tan	3f24ed2b3e	Can't revert due to incompatibility of new site setting types. Revert "Revert "FEATURE: Site settings defaults per locale"" This reverts commit `439fe8ba24`.	2017-08-07 10:43:09 +09:00
Guo Xiang Tan	439fe8ba24	Revert "FEATURE: Site settings defaults per locale" This reverts commit `468a8fcd20`.	2017-08-07 10:31:50 +09:00
Régis Hanol	519b70ea46	FIX: always trigger the ':user_updated' event We don't always use the UserUpdated class to update a user's record	2017-08-04 18:12:10 +02:00
Régis Hanol	c26ba890bd	prevent N+1 when loading custom emojis	2017-08-04 17:04:59 +02:00
Leo McArdle	99527af38a	FIX: show rejected emails with unrecognized errors (#5026 ) Although `407a23663d` will send rejection messages for unrecognized errors, sometimes processing the email will raise an error which has a blank message. This commit: 1. Shows rejected emails which have already been processed and contain a blank error in /admin/email/rejected 2. Replaces new blank error messages with the error type	2017-08-04 16:20:44 +02:00
Guo Xiang Tan	40fc6c429a	Merge pull request #5018 from discourse/wekbit-embedded-referer FIX: First load of embed comments would always fail on WebKit	2017-08-04 14:12:26 +09:00
Guo Xiang Tan	a47e297508	Merge pull request #5019 from tgxworld/more_resiliency_to_readonly_redis Fix Redis command errors when trying to start app with a readonly Redis.	2017-08-03 06:34:36 +09:00
Rafael dos Santos Silva	57a214e920	FIX: First load of embed comments would always fail on WebKit	2017-08-02 17:43:31 -03:00
Erick Guan	468a8fcd20	FEATURE: Site settings defaults per locale This change-set allows setting different defaults for different locales. It also: - Adds extensive testing around site setting validation - raises deprecation error if site setting has the default property based on env - relocated site settings for dev and tests in the initializer - deprecated client_setting in the site setting's loading process - ensure it raises when a enum site setting being set - default_locale is promoted to `required` category. - fixes incorrect default setting and validation - fixes ensure type check for site settings - creates a benchmark for site setting - sets reasonable defaults for Chinese	2017-08-02 12:24:19 -04:00
Neil Lalonde	3de45ce0cd	FIX: use case insensitive group name search when applying group rules from SSO	2017-08-02 11:30:37 -04:00
Guo Xiang Tan	9bc3038728	Fix Redis command errors when trying to start app with a readonly Redis.	2017-08-02 21:33:56 +09:00
Régis Hanol	e43799134c	fix the regexp used to valide user's website	2017-08-02 10:19:24 +02:00
Benjamin Elijah Griffin	d471ad08c6	Website RE validator without a 10 char limit on TLD.	2017-08-01 23:37:28 -07:00
Guo Xiang Tan	bd0efb8525	Fix the build.	2017-08-01 17:57:26 +09:00
Guo Xiang Tan	1197750e7d	PERF: Allow plugins to preload custom fields for topics in `CategoryList`.	2017-08-01 17:27:28 +09:00
Neil Lalonde	5d528f0d15	Merge pull request #4958 from dmacjam/search_posts_by_filetype FEATURE: Search posts by filetype	2017-07-31 11:55:34 -04:00
Guo Xiang Tan	24e0e000b9	FIX: Always validate presence of user's primary_email.	2017-07-31 11:47:29 +09:00

... 14 15 16 17 18 ...

4525 Commits