Guo Xiang Tan
1bc96177dd
DEV: Improve specs for validating a unique post.
...
Follow up to d2a7f29595
which caused post
edits to fail.
2019-03-14 10:39:51 +08:00
Guo Xiang Tan
d2a7f29595
Revert "REFACTOR: remove unnecessary parentheses attempt 2 (follow-up on 154f503d
)"
...
This reverts commit 7db2dc717e
.
Commit breaks post edits for regular users.
2019-03-14 08:15:40 +08:00
Guo Xiang Tan
1c6a2262b3
FIX: StaticController#favicon
reads from disk when using local store. ( #7160 )
...
Since uploads site settings are now backed by an actual upload, we don't
have to reach over the network just to fetch the favicon. Instead, we
can just read the upload directly from disk.
2019-03-14 04:17:36 +08:00
Roman Rizzi
4f74210949
Version bump to v2.3.0.beta5
2019-03-13 16:47:23 -03:00
Neil Lalonde
7db2dc717e
REFACTOR: remove unnecessary parentheses attempt 2 (follow-up on 154f503d
)
2019-03-13 15:33:46 -04:00
Dan Ungureanu
81bf4df1a5
DEV: Fix lint.
2019-03-13 21:32:28 +02:00
Roman Rizzi
bd8e46a9c1
SECURITY: Upgrading Rails version to 5.2.2.1
2019-03-13 16:24:54 -03:00
Dan Ungureanu
18ff790e79
FIX: Use prioritize_username_in_ux in post notices.
2019-03-13 21:17:41 +02:00
Roman Rizzi
77931b70c3
Revert "DEV: Upgrade to Ember 3.7.0 ( #6977 )" ( #7165 )
...
This reverts commit 3eebf8be73
.
2019-03-13 15:49:47 -03:00
Kris
4178578e09
UX: Adhere to Facebook & Twitter brand guidelines for share icon colors
2019-03-13 13:42:11 -04:00
Maja Komel
65f3ed0689
UX: make name optional for confirmation user field ( #7149 )
2019-03-13 18:40:43 +01:00
Maja Komel
12c37ada2e
UX: focus on search box when emoji picker is opened ( #7098 )
2019-03-13 17:48:40 +01:00
David Taylor
420c6f8102
FEATURE: Skip sending emails to domains on the .invalid
TLD ( #7162 )
...
This is a reserved TLD which we use when importing users without an email address. https://tools.ietf.org/html/rfc2606
2019-03-13 16:17:59 +00:00
Joffrey JAFFEUX
9a5f08ee61
DEV: skip discourse-chat-integration tests ( #7164 )
...
Suspected of causing timeout issues in our test suite with Ember 3.7
2019-03-13 16:50:56 +01:00
Dan Ungureanu
91bd0becaa
DEV: Allow topics to register default topic order criteria. ( #7158 )
2019-03-13 16:44:08 +01:00
Vinoth Kannan
c773f82ba1
DEV: Added qunit test functions and did minor refactoring
...
135191d1d1
2019-03-13 18:38:27 +05:30
Joffrey JAFFEUX
d32557ea32
Revert "FIX: Better emoji escaping for topic title"
...
This reverts commit 35426b5ad6
.
2019-03-13 13:02:56 +01:00
Maja Komel
3eebf8be73
DEV: Upgrade to Ember 3.7.0 ( #6977 )
...
* Upgrade to Ember 3.7.0
* use ember source 3.7.0.2
* fix mobile header
* fix navigation
2019-03-13 12:16:06 +01:00
Vinoth Kannan
d4d67386c9
FIX: change to correct bundled version
2019-03-13 16:43:45 +05:30
Vinoth Kannan
1b454c73ae
FIX: 'topic' can have null value
2019-03-13 16:34:47 +05:30
Bianca Nenciu
76a14c47ac
FEATURE: Add site contact group. ( #7152 )
2019-03-13 11:34:47 +01:00
Tim Lange
35426b5ad6
FIX: Better emoji escaping for topic title
...
This commit also puts emojiVersion in its own erb file.
2019-03-13 11:17:59 +01:00
Vinoth Kannan
135191d1d1
DEV: Option to add extra topic status icons in its widget and component
...
and did some refactoring
2019-03-13 15:17:26 +05:30
Guo Xiang Tan
243fb8d9ad
Fix the build.
2019-03-13 17:39:07 +08:00
Guo Xiang Tan
b0c8fdd7da
FIX: Properly support defaults for upload site settings.
2019-03-13 16:36:57 +08:00
Guo Xiang Tan
684eef71c7
REFACTOR: Better variable name.
2019-03-13 15:23:01 +08:00
Erick Guan
bd2edbb243
FIX: a temporary fix when CJK user tries to add a long title ( #7045 )
...
Discourse doesn't analyze the sentence components. So it counts the whole sentence as a word for CJK.
https://meta.discoursecn.org/t/topic/3033
2019-03-13 17:22:46 +11:00
Tim Lange
d1c4981f65
UX: Added tooltips to topic admin menu ( #7146 )
...
* UX: Added tooltips to topic admin menu
* FIX: Prettyfied code
* FIX: Fixed typo
* Update config/locales/client.en.yml
Co-Authored-By: venarius <tim.lange@online.de>
2019-03-13 17:11:36 +11:00
Joffrey JAFFEUX
edc6d87862
FIX: invite-panels regressions on private topics ( #7157 )
2019-03-13 16:34:23 +11:00
Blake Erickson
7ac394f51f
FIX: prevent mixed api auth headers & query params
...
When using the api and you provide an http header based api key any other
auth based information (username, external_id, or user_id) passed in as
query params will not be used and vice versa.
Followup to f03b293e6a
2019-03-12 17:33:21 -06:00
Dan Ungureanu
476d0050ab
FIX: Disable notices for posts by anonymous.
2019-03-13 00:20:19 +02:00
Dan Ungureanu
7310ee3ef1
FEATURE: Add more control over post notices. ( #7148 )
2019-03-13 08:06:28 +11:00
Neil Lalonde
e9ba4c74f7
Revert "REFACTOR: remove unnecessary parentheses"
...
Specs fail
2019-03-12 15:00:58 -04:00
Bianca Nenciu
c6ed86220e
FIX: Notify on tag change. ( #7119 )
2019-03-12 18:09:34 +01:00
Simon Cossar
e5e2fa4064
FEATURE: unhide the embed_whitelist_selector setting ( #7137 )
...
* Unhide embed_whitelist_selector Site Setting and move it to Posting section
* Add i18n key for the embed_whitelist_selector setting
2019-03-12 18:08:56 +01:00
Saurabh Patel
a901527057
DEV: remove user_profile events added for akismet ( #7044 )
2019-03-12 17:51:09 +01:00
Régis Hanol
154f503d2e
REFACTOR: remove unnecessary parentheses
2019-03-12 17:13:21 +01:00
Tarek Khalil
28384ba62c
FEATURE: Add Top Ignored Users
report ( #7153 )
...
* FEATURE: Add `Top Ignored Users` report
## Why?
This is part of the [Ability to ignore a user feature](https://meta.discourse.org/t/ability-to-ignore-a-user/110254/8 ), and also part of [this PR](https://github.com/discourse/discourse/pull/7144 ).
We want to send a System Message daily when a specific count threshold for an ignored is reached. To make this system message informative, we want to link to a report for the Top Ignored Users too.
2019-03-12 16:01:58 +00:00
Tarek Khalil
4a00772c19
FIX: invite approval StaffActionLogger
bug ( #7151 )
...
* FIX: invite approval `StaffActionLogger` bug
2019-03-12 13:32:25 +00:00
Guo Xiang Tan
6d0528687d
DEV: Remove redundant assertion.
...
If the post is not present, the test will fail with an error.
2019-03-12 20:56:18 +08:00
Tarek Khalil
db08b59eb2
UX: Change ignore
button color ( #7150 )
2019-03-12 11:10:18 +00:00
Joffrey JAFFEUX
90965e1c18
FIX: error with two inputs having the same id ( #7147 )
2019-03-12 09:46:58 +01:00
Bianca Nenciu
e6c2faf186
FIX: Disable 'Create Topic' button if tag is staff-only. ( #6984 )
...
* FIX: Disable 'Create Topic' button if tag is staff-only.
* FIX: Staff-only tags should always return 404.
2019-03-12 19:23:36 +11:00
Bianca Nenciu
191e31dccf
FEATURE: Log user approvals. ( #7121 )
2019-03-12 19:16:56 +11:00
Guo Xiang Tan
da941840d4
FIX: Advanced search category term should be case insensitive.
2019-03-12 14:11:21 +08:00
Penar Musaraj
95532814df
DEV: Make Rubocop happy
2019-03-11 22:33:24 -04:00
Penar Musaraj
49cdb072d7
DEV: Use --profile
and --fail-fast
in CI only
2019-03-11 22:04:47 -04:00
Guo Xiang Tan
34b29f62db
DEV: Remove the use of stubs and mocks in Jobs::UserEmail
tests.
...
We can only be sure that an email is sent when we get a mailer in
`ActionMailer::Deliveries`. A couple of tests were actually incorrect
because it didn't flow through our email sender where there are more
conditions in determining whether an email is sent or not.
2019-03-12 09:39:16 +08:00
Dan Ungureanu
32bae48fd3
DEV: Use User#human? User#bot? ( #7140 )
2019-03-12 07:58:14 +08:00
Robin Ward
d1d9a4f128
Add new run_jobs_synchronously!
helper for tests
...
Previously if you wanted to have jobs execute in test mode, you'd have
to do `SiteSetting.queue_jobs = false`, because the opposite of queue
is to execute.
I found this very confusing, so I created a test helper called
`run_jobs_synchronously!` which is much more clear about what it does.
2019-03-11 16:58:35 -04:00