Meghna
2cd2d7d4d6
FIX: add mobile specific stylesheet for onebox ( #23329 )
2023-08-31 10:35:28 +10:00
Martin Brennan
97a812f022
FIX: Hide core plugins from the admin Plugins list ( #23328 )
...
Most of the core plugins were already hidden, this hides
chat, styleguide, and checklist to avoid potential confusion
for end users.
Also removes respond_to? :hide_plugin, since that API has been
in place for a while now.
2023-08-31 10:01:01 +10:00
Martin Brennan
c5d6e8cd23
Revert "FIX: Remove chat "enable chat plugin text" ( #23327 )" ( #23344 )
...
This reverts commit 7f5c3d4e9a
2023-08-31 09:59:51 +10:00
Kris
556e59580e
DEV: add plugin outlet to mobile login ( #23341 )
2023-08-30 17:36:47 -04:00
Kris
6b375440f5
DEV: add plugin outlets to create/login ( #23340 )
2023-08-30 15:58:22 -04:00
David Taylor
2c58d456dd
DEV: Improve strategy for identifying ember-cli JS chunks ( #23336 )
...
Our Ember build compiles assets into multiple chunks. In the past, we used the output from `ember-auto-import-chunks-json-generator` to give Rails a map of those chunks. However, that addon is specific to ember-auto-import, and is not compatible with Embroider.
Instead, we can switch to parsing the html files which are output by ember-cli. These are guaranteed to have the correct JS files in the correct place. A `<discourse-chunked-script>` will allow us to easily identify which chunks belong to which entrypoint.
In future, as we update more entrypoints to be compiled by Embroider/Webpack, we can easily introduce new wrappers.
2023-08-30 18:47:06 +01:00
chapoi
a97dcd8564
UX: composer fixes ( #23334 )
...
* UX: fix disappearing separator
* UX: slightly smaller composer btns on non-mobile
2023-08-30 15:10:21 +02:00
Jarek Radosz
7b78895930
DEV: Group babel updates together ( #23322 )
...
Grouped Dependabot updates are now available (https://github.blog/changelog/2023-08-24-grouped-version-updates-for-dependabot-are-generally-available/ ) so we can finally make it create a single PR for both `@babel/core` and `@babel/standalone` 😌
2023-08-30 10:38:26 +02:00
Jarek Radosz
f6cd8e5968
DEV: Remove redundant braces ( #23321 )
2023-08-30 10:37:03 +02:00
Martin Brennan
2965519c76
DEV: Add auto _map extensions for list site settings with no type ( #23331 )
...
Followup to eea74e0e32
2023-08-30 16:14:06 +10:00
Ted Johansson
d3a5156e66
DEV: Move 'ignore and delete' action under 'ignore' menu for chat flags ( #23304 )
...
This moves the "delete message" action (if it is available) of a flagged chat message under the "ignore" menu. This puts it on par with the menu for flagged posts.
2023-08-30 10:51:32 +08:00
dependabot[bot]
4f830d7561
Build(deps): Bump @uppy/utils in /app/assets/javascripts ( #22767 )
...
Bumps [@uppy/utils](https://github.com/transloadit/uppy ) from 5.4.0 to 5.4.3.
- [Release notes](https://github.com/transloadit/uppy/releases )
- [Changelog](https://github.com/transloadit/uppy/blob/main/CHANGELOG.md )
- [Commits](https://github.com/transloadit/uppy/compare/@uppy/utils@5.4.0...@uppy/utils@5.4.3 )
---
updated-dependencies:
- dependency-name: "@uppy/utils"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-08-30 12:50:46 +10:00
Martin Brennan
7f5c3d4e9a
FIX: Remove chat "enable chat plugin text" ( #23327 )
...
This text is repetitive and also a little confusing
to end users, since it doesn't really matter that
chat is a plugin, since it is in core.
2023-08-30 12:17:01 +10:00
Martin Brennan
bbd908ae09
FIX: Add hashtag placeholder when chat message sent ( #23287 )
...
This commit fixes an issue from 2ecc8291e8
2023-08-30 11:31:34 +10:00
dependabot[bot]
875a817410
Build(deps): Bump css_parser from 1.14.0 to 1.15.0 ( #23323 )
...
Bumps [css_parser](https://github.com/premailer/css_parser ) from 1.14.0 to 1.15.0.
- [Changelog](https://github.com/premailer/css_parser/blob/master/CHANGELOG.md )
- [Commits](https://github.com/premailer/css_parser/compare/v1.14.0...v1.15.0 )
---
updated-dependencies:
- dependency-name: css_parser
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-08-30 01:56:34 +02:00
Blake Erickson
da389d7844
DEV: Remove unused site settings ( #23326 )
...
According to the output of this rake task:
`LOAD_PLUGINS=0 bin/rails "site_settings:find_dead"`
which searches for unused site settings, these settings:
```
rate_limit_new_user_create_topic
enable_system_avatars
check_for_new_features
allow_user_api_keys
```
are unused.
2023-08-29 17:42:32 -06:00
dependabot[bot]
ab3e622a45
Build(deps-dev): Bump rubocop from 1.56.1 to 1.56.2 ( #23325 )
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.56.1 to 1.56.2.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.56.1...v1.56.2 )
---
updated-dependencies:
- dependency-name: rubocop
dependency-type: indirect
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-08-30 01:36:13 +02:00
dependabot[bot]
79b2eb238f
Build(deps-dev): Bump webmock from 3.19.0 to 3.19.1 ( #23324 )
...
Bumps [webmock](https://github.com/bblimke/webmock ) from 3.19.0 to 3.19.1.
- [Changelog](https://github.com/bblimke/webmock/blob/master/CHANGELOG.md )
- [Commits](https://github.com/bblimke/webmock/compare/v3.19.0...v3.19.1 )
---
updated-dependencies:
- dependency-name: webmock
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-08-30 01:34:49 +02:00
dependabot[bot]
f97aef4b27
Build(deps-dev): Bump terser in /app/assets/javascripts ( #23319 )
...
Bumps [terser](https://github.com/terser/terser ) from 5.19.2 to 5.19.3.
- [Changelog](https://github.com/terser/terser/blob/v5.19.3/CHANGELOG.md )
- [Commits](https://github.com/terser/terser/compare/v5.19.2...v5.19.3 )
---
updated-dependencies:
- dependency-name: terser
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-08-30 00:35:57 +02:00
Renato Atilio
58b49bce41
FEATURE: support to initial values for form templates through /new-topic ( #23313 )
...
* FEATURE: adds support for initial values through /new-topic to form templates
2023-08-29 18:41:33 -03:00
Kris
8dddc9eb39
DEV: remove broken margin removal ( #23318 )
2023-08-29 17:11:38 -04:00
Renato Atilio
f49389309a
FIX: no form template logic when editing posts ( #23317 )
2023-08-29 16:07:33 -03:00
Isaac Janzen
6650aa18f5
DEV: Convert move-to-topic modal to component-based API ( #23293 )
...
<img width="654" alt="Screenshot 2023-08-28 at 2 49 04 PM" src="https://github.com/discourse/discourse/assets/50783505/5fc4dfb5-a7da-4a2b-a524-e81b5039efe6 ">
<img width="745" alt="Screenshot 2023-08-28 at 2 48 47 PM" src="https://github.com/discourse/discourse/assets/50783505/4432338e-ba05-4206-8553-eb69f8b31b4f ">
<img width="448" alt="Screenshot 2023-08-28 at 2 48 44 PM" src="https://github.com/discourse/discourse/assets/50783505/6d6c305d-396b-488a-9ee9-bc41773dd98b ">
<img width="747" alt="Screenshot 2023-08-28 at 2 48 42 PM" src="https://github.com/discourse/discourse/assets/50783505/9279f591-ca4a-4152-81c5-71d79dbcbc10 ">
<img width="671" alt="Screenshot 2023-08-28 at 2 40 42 PM" src="https://github.com/discourse/discourse/assets/50783505/dea02b8b-cf87-45bb-8466-449367b5609a ">
<img width="643" alt="Screenshot 2023-08-28 at 2 40 37 PM" src="https://github.com/discourse/discourse/assets/50783505/e422b9b0-89b5-4681-91db-89b8eee05872 ">
2023-08-29 13:50:13 -05:00
Jordan Vidrine
480419565f
FIX: Remove border radius on more topics container buttons: ( #23314 )
2023-08-29 12:02:38 -05:00
Keegan George
f753918cf5
DEV: Add after-composer-title-input outlet ( #23303 )
2023-08-29 09:14:05 -07:00
Isaac Janzen
2671de3f86
DEV: Convert post-enqueued modal to component-based API ( #23295 )
2023-08-29 11:09:57 -05:00
Blake Erickson
5d438f805c
DEV: Add rake command to help detect dead settings ( #23300 )
...
* DEV: Add rake command to help detect dead settings
Some Site Settings may still exist but are no longer being used in the
core discourse code or in related plugins. This rake task will help
identify any unused (aka: dead) settings by using the `rg` command to
search for them.
You can execute the rake task by using this command:
`LOAD_PLUGINS=1 bin/rails "site_settings:find_dead"`
* Add env variable, apply feedback
2023-08-29 09:42:52 -06:00
Discourse Translator Bot
9db047a76c
Update translations ( #23309 )
2023-08-29 15:50:52 +02:00
Penar Musaraj
76f4142d3f
Revert "A11Y: Improve setting focus to post" ( #23311 )
...
This reverts commit 9b3fc8081a
2023-08-29 09:24:16 -04:00
Meghna
d47a3e053a
UX: settings are misaligned when translations are too long ( #23308 )
2023-08-29 18:17:12 +05:30
BettyJJ
b644eaf0dd
FIX: correct link to meta.discourse.org
2023-08-29 13:17:05 +02:00
Meghna
60a34b0908
UX: Fix github onebox on mobile ( #23306 )
...
* UX: Fix github onebox on mobile
* UX: Fix github onebox on mobile
2023-08-29 16:36:20 +05:30
Ted Johansson
7a4119846c
FIX: Include 'notify staff' separator in chat message flag modal ( #23301 )
...
When flagging a chat message, and options included both notifying user and notifying staff, the modal was missing the separating text. This was happening because the #staffFlagsAvailable method was based on post flags, and the model for chat flags is slightly different. This fixes that by delegating to the relevant flag target object.
2023-08-29 15:26:14 +08:00
Martin Brennan
e562bb1f43
DEV: Remove reviewable action custom_modal and use new action-based modal API ( #23258 )
...
This removes the custom_modal implementation for the
reviewable items and uses the new modal patterns defined at
https://meta.discourse.org/t/converting-modals-from-legacy-controllers-to-new-dmodal-component-api/268057
Only one plugin (discourse category experts) was using this API,
that has been fixed up here https://github.com/discourse/discourse-category-experts/pull/117
Also adds `registerReviewableActionModal` to allow for plugins and
core to map a reviewable action ID to an actual
JS class for the modal and improves docs for plugin API functions
used by reviewable-item.
2023-08-29 14:36:20 +10:00
dependabot[bot]
27ebbd2f8d
Build(deps-dev): Bump @babel/standalone from 7.22.12 to 7.22.13 in /app/assets/javascripts ( #23299 )
...
Bumps [@babel/standalone](https://github.com/babel/babel/tree/HEAD/packages/babel-standalone ) from 7.22.12 to 7.22.13.
- [Release notes](https://github.com/babel/babel/releases )
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md )
- [Commits](https://github.com/babel/babel/commits/v7.22.13/packages/babel-standalone )
---
updated-dependencies:
- dependency-name: "@babel/standalone"
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-08-29 08:21:48 +08:00
Isaac Janzen
026cd3e532
DEV: Convert flag modal to component-based API ( #23279 )
...
# Topic Flag
<img width="587" alt="Screenshot 2023-08-28 at 10 53 12 AM" src="https://github.com/discourse/discourse/assets/50783505/6ffe4e47-05a6-406c-9d1b-899ff4d5c2c9 ">
# Post Flag
<img width="620" alt="Screenshot 2023-08-28 at 10 52 44 AM" src="https://github.com/discourse/discourse/assets/50783505/1f893916-b62f-4825-a337-4c0e0e4ce3af ">
# Chat Flag
<img width="648" alt="Screenshot 2023-08-28 at 10 52 31 AM" src="https://github.com/discourse/discourse/assets/50783505/e79444e8-a8b1-4f05-9b47-03d425bc9085 ">
2023-08-28 16:51:58 -05:00
Roman Rizzi
cf71f8358e
FIX: Typo in summary URL ( #23298 )
2023-08-28 18:06:36 -03:00
Roman Rizzi
e20de81de3
FIX: Display summaries for anonymous users. ( #23294 )
...
Streaming doesn't work for anonymous users because we scope updates to the current user. Since they can only see cached summaries, we can skip the streaming parameter and update it directly with the ajax response.
2023-08-28 17:29:48 -03:00
Jordan Vidrine
d8b62c2275
FIX: Update search-menu.scss ( #23292 )
...
Remove overflow hidden, which is causing issues on windows
2023-08-28 11:04:41 -05:00
Isaac Janzen
6870f38e87
DEV: Convert feature-topic modal to component-based API ( #23277 )
...
Updated styles with some sign off from @jordanvidrine
<img width="655" alt="Screenshot 2023-08-28 at 9 07 47 AM" src="https://github.com/discourse/discourse/assets/50783505/31b453ef-a787-436f-9fd9-48c9cd3a2e81 ">
2023-08-28 09:41:14 -05:00
David Taylor
81d8c6ba6c
UX: Prevent initial jump when dragging topic timeline scroller ( #23291 )
...
Previously, when dragging the timeline scroller, we would position it purely based on the current cursor position. That means that if you started dragging it from anywhere other than the centre, the scroller will 'jump' suddenly to centre itself on the cursor.
This commit measures the offset of your cursor when the drag starts, and maintains it throughout the drag. So for example, if you start dragging at the bottom of the scroller and drag one pixel up, the scroller will only move by 1px.
This should make the UX much smoother, especially on large topics.
2023-08-28 15:00:32 +01:00
Jarek Radosz
6f1d666323
DEV: Make index.html a valid html ( #23289 )
...
Co-authored-by: Godfrey Chan <godfreykfc@gmail.com>
2023-08-28 14:44:38 +02:00
David Taylor
33d5845991
FIX: Avoid scroll jumping for topics on slow connections ( #23290 )
...
When the 'loading slider' navigation indicator is enabled, and a connection is very slow, we `display: none` most of the page and display a spinner. The `still-loading` body class for this was being added in the `afterRender` step in the Ember runloop. This meant that, depending on the order they were scheduled, other `afterRender` jobs may run before it. This caused an issue with topic scroll locations because we would attempt to scroll to an element which was `display: none` at the point its position was calculated.
This commit moves the `still-loading` class manipulations to the `render` step of the runloop, which is technically more correct, and means that anything scheduled in the `afterRender` step is guaranteed to run without the `display: none` CSS.
https://meta.discourse.org/t/276305/29
2023-08-28 12:23:02 +01:00
Sam
997c839626
FEATURE: display count of topics being dismissed in dialog ( #23288 )
...
Previous to this change it was unclear if all new would be dismissed or just
some of them
Co-authored-by: Joffrey JAFFEUX <j.jaffeux@gmail.com>
2023-08-28 11:46:38 +02:00
Sion Kang
c9ebc75a1d
DOCS: Update wrong link address ( #23285 )
2023-08-28 13:00:17 +08:00
Martin Brennan
64a4390e17
DEV: Fix flaky network-based upload spec ( #23286 )
...
Tries to fix the composer upload spec by making the upload
slow enough to allow clicking the Cancel button, and improves
generally the API for CDP network changes.
2023-08-28 12:59:22 +08:00
Jarek Radosz
09446baf10
DEV: Fix redis.sadd warnings ( #23244 )
...
```
Redis#sadd will always return an Integer in Redis 5.0.0. Use Redis#sadd? instead
```
2023-08-28 12:58:47 +08:00
dependabot[bot]
09acba17de
Build(deps-dev): Bump eslint from 8.47.0 to 8.48.0 in /app/assets/javascripts ( #23281 )
...
Bumps [eslint](https://github.com/eslint/eslint ) from 8.47.0 to 8.48.0.
- [Release notes](https://github.com/eslint/eslint/releases )
- [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md )
- [Commits](https://github.com/eslint/eslint/compare/v8.47.0...v8.48.0 )
---
updated-dependencies:
- dependency-name: eslint
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-08-28 12:58:31 +08:00
dependabot[bot]
5d2d1ed9a2
Build(deps-dev): Bump webmock from 3.18.1 to 3.19.0 ( #23282 )
...
Bumps [webmock](https://github.com/bblimke/webmock ) from 3.18.1 to 3.19.0.
- [Changelog](https://github.com/bblimke/webmock/blob/master/CHANGELOG.md )
- [Commits](https://github.com/bblimke/webmock/compare/v3.18.1...v3.19.0 )
---
updated-dependencies:
- dependency-name: webmock
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-08-28 12:58:17 +08:00
dependabot[bot]
d2d74c9c3c
Build(deps): Bump google-protobuf from 3.24.1 to 3.24.2 ( #23283 )
...
Bumps [google-protobuf](https://github.com/protocolbuffers/protobuf ) from 3.24.1 to 3.24.2.
- [Release notes](https://github.com/protocolbuffers/protobuf/releases )
- [Changelog](https://github.com/protocolbuffers/protobuf/blob/main/protobuf_release.bzl )
- [Commits](https://github.com/protocolbuffers/protobuf/compare/v3.24.1...v3.24.2 )
---
updated-dependencies:
- dependency-name: google-protobuf
dependency-type: indirect
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-08-28 12:57:53 +08:00
