Arpit Jalan
3094459cd9
FEATURE: multiple use invite links ( #9813 )
2020-06-09 20:49:32 +05:30
Gerhard Schlager
6b7a2d6d4d
DEV: Remove non-existent option from setup-ruby Github action
2020-06-09 15:50:09 +02:00
David Taylor
f1fc6cd40d
DEV: Add user-card-additional-buttons plugin outlet
...
The user-card-additional-controls outlet is outside the `<li>` element, which makes styling difficult. Placing an outlet inside the button list means that themes/plugins can easily reuse core styling.
2020-06-09 14:33:24 +01:00
Guo Xiang Tan
edc940ce3e
DEV: Fix incorrect messagebus redis config for rails_failover.
2020-06-09 17:05:14 +08:00
Guo Xiang Tan
c35649ccf1
DEV: Remove Redis noop logging.
...
When Redis drops into readonly mode, it floods the log. The log isn't
actionable and we have other means of knowing that an app is in readonly
mode.
2020-06-09 16:45:34 +08:00
Guo Xiang Tan
a1c13eb3c6
DEV: Redis failover should only clear redis recently readonly.
2020-06-09 16:36:31 +08:00
Sam Saffron
716629dc0a
DEV: correct flaky test relying on possibly valid user id
...
This test lasted about 7 years prior to it becoming flaky.
Today ... for whatever reason the test suite created 100 users
prior to running this spec. So the new user becomes user id 101
And... lo and behold:
```
1) PostSerializer a hidden post with add_raw enabled a hidden post shows the raw post only if authorized to see it
Failure/Error: expect(serialized_post_for_user(Fabricate(:user))[:raw]).to eq(nil)
expected: nil
got: "Raw contents of the post."
(compared using ==)
# ./spec/serializers/post_serializer_spec.rb:127:in `block (4 levels) in <main>'
```
2020-06-09 17:40:41 +10:00
Sam Saffron
08044b4f94
FIX: emoji autocomplete triggering incorrectly
...
Previous to this fix the we were checking for non letters.
This was mismatching what pretty-text/addon/emoji.js was doing.
`ù:su`
and
`1:su`
Would lead to an emoji autocomplete popup in the composer.
2020-06-09 17:22:51 +10:00
Guo Xiang Tan
8b434531e4
Bump message_bus to 3.3.1.
2020-06-09 14:12:14 +08:00
Martin Brennan
3e210b76d9
FIX: Change bookmark name "name" attr to disable autocomplete
2020-06-09 14:47:30 +10:00
Kris
d09bf892c7
UX: Improve layout of topic pin admin modal
2020-06-08 23:58:53 -04:00
Kane York
9b050f2822
FIX: Enforce maximum of 100 years on all site settings counted in days ( #9991 )
2020-06-09 12:48:51 +10:00
Guo Xiang Tan
4065cd198a
DEV: Print backtrace of error when plugin fails to initialize.
2020-06-09 10:25:43 +08:00
Penar Musaraj
c5b1f028ed
FIX: update minimum required tag when switching categories in composer
2020-06-08 17:10:26 -04:00
Kris
fbeaba4acf
FIX: don't override category text color in dropdown
2020-06-08 16:45:30 -04:00
Penar Musaraj
bdba17cdf7
FIX: Restore stream position in safari ( #9993 )
...
Safari uses an aggressive back/forward cache, which means the app loads
very quickly when hitting Back. But, in topics with > 30 posts, hitting
Back runs post stream calculations too early, which means that users
get taken back to an earlier point in the stream, consistently.
Using `onpageshow`, we can restore the correct location before the post
stream calculations take place.
2020-06-08 10:13:46 -04:00
Bianca Nenciu
052c91770f
FIX: Reply notifications should not appear as edited ( #9965 )
2020-06-08 15:23:33 +02:00
Joffrey JAFFEUX
cb13152a43
FIX: ensures edit-category-setting is correctly casting boolean ( #9999 )
2020-06-08 15:16:42 +02:00
David Taylor
472862e87d
DEV: Do not attempt to change schema of posts table
...
Changing this requires rebuilding the badge_posts view, so will need to be done separately
Followup to f7d676dc
2020-06-08 13:52:31 +01:00
David Taylor
556380f970
DEV: Do not attempt to change schema badge_posts view
...
Followup to f7d676dc
2020-06-08 13:08:28 +01:00
David Taylor
f7d676dce1
DEV: Correct historical schema discrepancies ( #9955 )
...
Rails schema defaults have changed over the years. This migration will correct discrepancies, and make all databases match the modern schema.
2020-06-08 12:20:27 +01:00
David Taylor
833b5d89e0
PERF: Cache PrettyText instance for rendering composer preview ( #9987 )
...
Previously we were building pretty-text from scratch on every keypress
2020-06-08 10:42:59 +01:00
Guo Xiang Tan
4ce618e55b
Bump rails_failover.
2020-06-08 17:04:58 +08:00
Gerhard Schlager
0bf753a739
DEV: Remove unused routes
2020-06-08 10:26:29 +02:00
Gerhard Schlager
8c6a42c589
FIX: Redirects containing Unicode usernames didn't work
2020-06-08 10:26:29 +02:00
Guo Xiang Tan
f6628e4f43
DEV: Disable messageBus keepalive when Redis fails over.
2020-06-08 12:33:08 +08:00
Guo Xiang Tan
2ffda2b320
Bump rails_failover.
2020-06-08 12:19:33 +08:00
Guo Xiang Tan
dc8b773765
Update rails_failover.
2020-06-08 11:03:25 +08:00
dependabot-preview[bot]
cb015efb74
Bump rubocop from 0.85.0 to 0.85.1
...
Bumps [rubocop](https://github.com/rubocop-hq/rubocop ) from 0.85.0 to 0.85.1.
- [Release notes](https://github.com/rubocop-hq/rubocop/releases )
- [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop-hq/rubocop/compare/v0.85.0...v0.85.1 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-06-08 09:11:58 +08:00
Jeff Atwood
dc49581344
clarify on supported Linux distros
2020-06-07 17:50:45 -07:00
David Taylor
293467a37a
REFACTOR: Remove jquery usage from resolveAllShortUrls, and fix debounce
...
- This function now requires an explicit scope. It will never run on the entire document.
- Previously debounce was being used with an anonymous function, which means it was having no effect.
2020-06-05 17:15:14 +01:00
Joffrey JAFFEUX
d4caf69ed7
DEV: makes SKIP_INSTALL_PLUGINS called last and global ( #9990 )
2020-06-05 17:59:23 +02:00
David Taylor
0f09fd22f3
DEV: Remove attachment css handling from resolveAllShortUrls
...
This was moved inside the markdown processor in 65481858
2020-06-05 15:12:30 +01:00
dependabot-preview[bot]
dc633f299f
Bump email_reply_trimmer from 0.1.12 to 0.1.13 ( #9980 )
...
Bumps [email_reply_trimmer](https://github.com/discourse/email_reply_trimmer ) from 0.1.12 to 0.1.13.
- [Release notes](https://github.com/discourse/email_reply_trimmer/releases )
- [Commits](https://github.com/discourse/email_reply_trimmer/commits/v0.1.13 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-06-05 10:00:59 -04:00
Robin Ward
a9def011d0
FIX: (getURL "") was not working with the i18n helper
2020-06-05 09:53:43 -04:00
David Taylor
be5974734d
PERF: Pass element to resolveAllShortUrl function, not text selector ( #9988 )
...
We already have a reference to the preview element, so there is no need to look it up again. This saves about 1ms per keypress in my testing.
2020-06-05 13:37:07 +01:00
David Taylor
731263b81c
PERF: Correctly memoize baseUri value in javascript app ( #9986 )
...
An empty string is a falsey value in javascript, so we were looking for the meta tag every time getURL was called, which took approximately 1.5ms every time.
2020-06-05 13:36:48 +01:00
David Taylor
6c7e9d3255
DEV: Remove htmlparser dependency ( #9981 )
...
We stopped using htmlparser in b5008586
2020-06-05 13:29:50 +01:00
Sam Saffron
1c48853ede
DEV: allow skipping of a single plugin when installing
...
SKIP_INSTALL_PLUGINS can be used to tell plugin:install_all_official
to skip a plugin.
Comma seperated list
2020-06-05 18:26:25 +10:00
OsamaSayegh
ded5ebb5ae
DEV: Make git ignore cosmetic commit
2020-06-05 05:51:07 +03:00
OsamaSayegh
985900818f
DEV: Fix indentation for routes.rb
2020-06-05 05:49:31 +03:00
Martin Brennan
e84ffb4861
DEV: Add pry-byebug and optionally require pry behind a ENV var for better spec debugging ( #9984 )
...
We removed pry-nav a while back because it is not up to date with pry but it is super useful. Luckily pry-byebug is here to save us all from Satan's power.
To get this to work you need to add the following to your $HOME/.pryrc file.
```
if defined?(PryByebug)
Pry.commands.alias_command 'c', 'continue'
Pry.commands.alias_command 's', 'step'
Pry.commands.alias_command 'n', 'next'
Pry.commands.alias_command 'f', 'finish'
end
Pry::Commands.command /^$/, "repeat last command" do
pry_instance.run_command Pry.history.to_a.last
end
```
The require-ing of pry, pry-rails, and pry-byebug in specs is controlled by the IMPROVED_SPEC_DEBUGGING flag (disabled by default).
2020-06-05 12:30:34 +10:00
Vinoth Kannan
0f20a6f0aa
FIX: use short_path of flair upload to get signed url for secure media.
...
If we use `upload.url` for secure urls then the images won't render.
2020-06-05 07:43:15 +05:30
Penar Musaraj
2de2537595
UX: add bottom padding to user lists on mobile
...
In some cases, when lists had a handful of items, the last item would be covered by the footer-nav eoverlay on PWAs and DiscourseHub.
2020-06-04 21:42:01 -04:00
Penar Musaraj
f6c3962e3c
UX: Change collapsed draft z-index on mobile
2020-06-04 21:24:14 -04:00
Guo Xiang Tan
320b1e95bf
DEV: Silence all freedom patches trace in verbose query logs.
2020-06-05 09:09:54 +08:00
Guo Xiang Tan
e82d4d8a75
DEV: Update rails_failover to avoid monkey patching Rails config.
2020-06-05 09:05:19 +08:00
Martin Brennan
36841210fb
Move UploadSecurity public types into PUBLIC_TYPES constant
...
* this is so plugins can extend the public types if required
2020-06-05 10:56:57 +10:00
Kris
5cea4a6cc2
icon color fix, follow-up to 5cc0369
2020-06-04 17:29:28 -04:00
Kris
5cc0369898
Minor dropdown icon width fix
2020-06-04 17:26:57 -04:00
