Commit Graph

21915 Commits

Author SHA1 Message Date
Marica Odagaki
3bb1b98b0e FIX: admin dashboard shouldn't complain when using iam profile for s3 access
Previous code wasn't working as intended because it was parsed as

    (bad_keys = (access_key or secret_key)) and !use_iam_profile

because of Ruby's operator precedence: `=` binds more eagerly than `and`.

http://ruby-doc.org/core-2.3.1/doc/syntax/precedence_rdoc.html

See also: https://github.com/bbatsov/ruby-style-guide#no-and-or-or
2017-02-15 00:22:14 -08:00
Marica Odagaki
af9c97ec43 Add failing tests 2017-02-15 00:05:58 -08:00
Marica Odagaki
2c1279b740 Fix typo to be more consistent with other test descriptions 2017-02-15 00:04:10 -08:00
Neil Lalonde
c085e8f85f Version bump to v1.8.0.beta6 2017-02-14 17:40:44 -05:00
Sam
8409f42352 Add outlet for injecting custom tags 2017-02-14 17:40:13 -05:00
Sam
f2099c3811 adjust API 2017-02-14 16:32:33 -05:00
Sam
89d5e8ab4b FEATURE: allow plugins to preload data in topic list 2017-02-14 16:29:06 -05:00
Sam
21e21b9882 Merge pull request #4708 from discourse/phantonjs-timeout
Increase Qunit tests timeout on Docker tests
2017-02-14 14:48:22 -05:00
Rafael dos Santos Silva
6a271a7695 Increase Qunit tests timeout on Docker tests 2017-02-14 16:09:14 -02:00
Sam
dacfdd4dc8 use chars as opposed to split 2017-02-14 09:40:15 -05:00
Sam
5346cd3514 correct the test 2017-02-14 09:34:39 -05:00
Sam
c52784f9d2 FIX: race condition when marking tokens as seen
- in rare conditions can lead to users being logged off
2017-02-14 09:34:09 -05:00
Sam
8feb94e13f FIX: password validator was being too strict 2017-02-14 09:18:04 -05:00
Régis Hanol
dba16b57cb Merge pull request #4707 from discourse/revert-4699-rfc-signature
Revert "use RFC-complient signature separator dash-dash-space"
2017-02-14 14:58:30 +01:00
Régis Hanol
d88562e72b Revert "use RFC-complient signature separator dash-dash-space" 2017-02-14 14:58:08 +01:00
Neil Lalonde
53d8d126a4 Version bump to v1.8.0.beta5 2017-02-13 16:46:08 -05:00
Neil Lalonde
56233e9ec6 Update translations 2017-02-13 16:42:15 -05:00
Sam
783bac9ff7 less stubbing for better clarity and robustness 2017-02-13 14:34:15 -05:00
Sam
7652901b75 reduce mocking and stubbing in controller spec 2017-02-13 14:31:15 -05:00
Sam
0ab96a7691 FEATURE: add hidden setting for verbose auth token logging
This is only needed to debug auth token issues, will result in lots
of logging
2017-02-13 14:01:09 -05:00
Robin Ward
0e58e393a1 FIX: === and a better constant, thanks @ZogStriP 2017-02-13 13:14:19 -05:00
Robin Ward
9d4405d602 Don't add an empty class to the list elements in the hamburger 2017-02-13 11:28:10 -05:00
Sam
07b9c351a4 Merge pull request #4705 from vinothkannans/dev
new: server plugin outlet for indexable robots.txt
2017-02-13 11:18:51 -05:00
Robin Ward
c40d8d37dd Put an error in the console if the discourseEmbedUrl is relative 2017-02-13 11:18:24 -05:00
Robin Ward
e1d358ffbf FIX: Don't clear the login hint when the system user is saved 2017-02-13 10:54:20 -05:00
Rafael dos Santos Silva
87a2aa18ee Merge pull request #4703 from ndossougbete/ndossougbete-patch-1
Use `natural` orientation for web app manifest.
2017-02-13 13:28:38 -02:00
Vinoth Kannan
08c14dd689 new: server plugin outlet for indexable robots.txt 2017-02-13 17:31:10 +05:30
Jeff Atwood
13c7887210 Merge pull request #4704 from rimian/patch-2
remove personal email from fixtures
2017-02-12 19:50:45 -08:00
Rimian Perkins
432b08f296 remove personal email from fixtures
I'm writing acceptance tests against the user fixture in my plugin. It would be a good idea to use a generic email address as I'd like to respect eviltrout's privacy :)
2017-02-13 11:29:03 +11:00
Nicolas
1deec95ccb Use natural orientation for web app manifest.
The `any` orientation forces the rotation even when the device's screen
 rotation is disabled. Using `natural` respects that and restores the
 expected behaviour.
2017-02-12 18:04:06 +00:00
Jeff Atwood
22c83b0a20 Merge pull request #4700 from gsambrotta/replay-btn-position
fix replay btn position on mobile and desktop
2017-02-11 22:21:11 -08:00
Jeff Atwood
3ee7a9266c Merge pull request #4686 from tgxworld/group_is_visible_if_user_is_group_owner
FIX: Show groups that user is owner of on groups page.
2017-02-11 22:18:44 -08:00
Jeff Atwood
243d8e170d Merge pull request #4702 from vinothkannans/pr-welcome/57037
'Article' to 'DiscussionForumPosting' schema type
2017-02-11 22:17:34 -08:00
Vinoth Kannan
1b43c209eb 'Article' to 'DiscussionForumPosting' schema type
topic => https://meta.discourse.org/t/invalid-article-schema/57037
Replacing '[Article](https://schema.org/Article)' schema type with '[DiscussionForumPosting](https://schema.org/DiscussionForumPosting)'
2017-02-11 18:44:40 +05:30
Sam
675cb1c715 FEATURE: allow registrations of custom small action icons via plugins 2017-02-10 12:55:21 -05:00
giorgia
8c6d0ecd64 fix replay btn position on mobile and desktop 2017-02-10 17:11:10 +01:00
Neil Lalonde
94e1105af7 fix unique char counting in password validator 2017-02-10 10:38:17 -05:00
Régis Hanol
137e941814 Merge pull request #4699 from rriemann/rfc-signature
use RFC-complient signature separator dash-dash-space
2017-02-10 12:50:26 +01:00
Robert Riemann
bcd4513963 use RFC-complient signature separator dash-dash-space
currently, Discourse uses '---' in its notifications to
separate the signature with unsubscribe links etc. from
the body of the message.

The RFC standard defines '-- '.
https://www.ietf.org/rfc/rfc3676.txt (4.3)

The problem has been discussed in:

https://meta.discourse.org/t/previous-replies-separator-is-not-rfc-compliant/39410

And an incomplete fix has been added a year ago:
86819f08c3

The separator is important, because some mail clients strip off the
signature automatically in replies if the signature is recognised as such.
2017-02-10 11:46:02 +01:00
Sam Saffron
4332f0dde1 FEATURE: allow user search API to restrict to group 2017-02-09 18:45:39 -05:00
Neil Lalonde
1bcb835446 FEATURE: passwords must have a minimum number of unique characters, configurable with a new setting 2017-02-09 15:00:22 -05:00
Neil Lalonde
d68dd5b967 Revert "UX: Observe changes to plugin to hide/show plugin admin link without refresh." 2017-02-09 12:11:53 -05:00
Jeff Atwood
77033f4855 simpler twitter onebox CSS that works everywhere 2017-02-08 17:18:53 -08:00
Jeff Atwood
933af0b40e align onebox twitter date 2017-02-08 17:14:11 -08:00
Jeff Atwood
485c36141c onebox right padding should not be asymmetric 2017-02-08 17:11:19 -08:00
Jeff Atwood
fe32c64dd9 FIX: twitter onebox styling was poor on mobile 2017-02-08 17:08:40 -08:00
Jeff Atwood
3b4248b454 add primary class to password reset button 2017-02-08 16:11:24 -08:00
Jeff Atwood
1883ab3ca1 minor copyedit 2017-02-08 15:38:39 -08:00
Jeff Atwood
0088dd77af copyedit 2017-02-08 15:37:43 -08:00
Régis Hanol
91d09ebc08 post ids are always an integer 2017-02-08 23:46:11 +01:00