Bianca Nenciu
b9e3db6387
UX: Add link to user email preferences in admin view ( #10169 )
2020-07-07 10:20:14 +10:00
Joffrey JAFFEUX
6ef0e98f4e
DEV: flexify post actions ( #9926 )
...
* DEV: flexify post actions
* more tweaks
2020-07-07 10:18:01 +10:00
Kris
1f5cecaf28
Minor follow up fix to 4f12768 for mobile
2020-07-06 19:17:30 -04:00
Kris
4f12768d10
UX: Remove extra space added by img resize controls in composer preview
2020-07-06 19:11:58 -04:00
Jarek Radosz
194c962124
FIX: Do not rerender widget-dropdown on all clicks ( #10100 )
...
Because of how the dropdown was structured, as long it was in the DOM, all clicks outside the widget would rerender it.
This commit introduces `widget-dropdown-body` that handles the `clickOutside` callback and is rendered conditionally, so it won't get called when the dropdown is closed.
2020-07-06 17:04:16 +02:00
Jarek Radosz
3b51e05de2
FIX: CookText may be gone before promise resolves ( #10097 )
...
* FIX: CookText may be gone before promise resolves
Bug introduced in 293467a37a232311aa8c
2020-07-06 17:03:27 +02:00
Mark VanLandingham
3792ffa556
DEV: Update method documentation in lib/computed.js ( #10172 )
2020-07-06 09:26:21 -05:00
Joe
6e341f1839
UX: restore table borders
...
Newer versions of Normalize remove the `border-collapse: collapse;` property and fallback to browser defaults. This commit restores that property because we're using it in quite a few places.
2020-07-06 21:25:41 +08:00
David Taylor
98786cb037
DEV: Refactor basic-topic-list to use topic-list-item on mobile ( #10105 )
...
Previously, basic-topic-list had its own implementation of topic-list-item on mobile, which made it more difficult to maintain and extend. The visible difference was that the basic-topic-list implementation had no large avatar on the left. This commit adds a new hideMobileAvatar parameter to topic-list-item and topic-list, and sets it to `true` for the basic-topic-list component.
2020-07-06 13:58:57 +01:00
Régis Hanol
525a2174b3
Restore 'pointer' cursor on buttons
...
Normalize removed their opinionated cursor styling of buttons in [4.0.1](170455d6f61fd3a30a59
2020-07-06 13:15:31 +02:00
David Taylor
5284d41a8e
FEATURE: Optionally skip the create account popup for external auth
2020-07-06 10:18:57 +01:00
David Taylor
041d28295f
UX: Hide login button during externally authenticated account creation
...
Also switch to use the new d-button loading property for the create account button
2020-07-06 10:18:49 +01:00
David Taylor
977766e7a8
FEATURE: sso_overrides_(email|username|name) for all auth methods
...
These settings previously applied only to discourse-sso. Now they work for all external authentication methods.
2020-07-06 10:18:45 +01:00
Joffrey JAFFEUX
789a15a897
DEV: allows autocomplete to be debounced ( #10166 )
...
Usage:
```
$(".foo").autocomplete({debounced: true});
```
2020-07-06 09:28:57 +02:00
Krzysztof Kotlarek
1fd3a30a59
FIX: update normalize css from 3.0.1 to 8.0.1 ( #10141 )
...
It is a second attempt to this update. First one was reverted here https://github.com/discourse/discourse/pull/8618
We noticed a problem that `like` counter had incorrect colour on mobile.
I added a missing rule to the bottom of the file (that rule existed in normalize-3 and was removed in normalize-8)
```
button,
input,
optgroup,
select,
textarea {
color: inherit;
}
```
2020-07-06 09:09:30 +10:00
Sam Saffron
a9c703c230
FIX: emoji autocomplete not triggering correctly
...
08044b4f👍 t` would not trigger an autocomplete to pick skin tone.
2020-07-03 16:56:11 +10:00
Ahmed Gagan
04d7693355
FIX: Filter read/unread notifications on the server side ( #10152 )
...
https://meta.discourse.org/t/notifications-unread-only-filter/37621/32
2020-07-02 11:06:00 +01:00
David Taylor
95153356ea
PERF: Refactor lightbox decorator to use querySelectorAll ( #10158 )
...
Previously we were using `$elem.find(...).not($elem.find(...))`. This took approximately 2ms on my machine with a test post.
This commit switches to using a native querySelectorAll method, which takes less than 0.5ms on the same test post.
2020-07-02 11:04:19 +01:00
Kris
490939a1c9
UX: Truncate long badge names in the mobile usercard
2020-07-01 21:39:40 -04:00
Robin Ward
8bc61e84a7
FIX: Support root paths that omit the trailing slash and have QPs
2020-07-01 14:55:20 -04:00
David Taylor
76d5e54aab
PERF: Check for modal visibility in a more efficient way
...
This code runs on every keyup event in the application, so it needs to be efficient. Previously we were iterating over the whole document using the JQuery :visible selector. Per the JQuery docs at https://api.jquery.com/visible-selector/
> Using this selector heavily can have performance implications, as it may force the browser to re-render the page before it can determine visibility. Tracking the visibility of elements via other methods, using a class for example, can provide better performance.
We already had a `hidden` class on the modal element which we can check, so we can check that instead.
2020-07-01 17:49:23 +01:00
Mark VanLandingham
57a8b3b964
DEV: Add group name as class to group-box ( #10150 )
2020-06-30 10:49:31 -05:00
David Taylor
4db9f7bb73
FIX: Hide publish_read_state option from non-admin users ( #10148 )
2020-06-30 16:49:04 +01:00
Sam Saffron
67a310db02
FIX: emoji_autocomplete_min_chars failing when not 0
...
autocomplete resolving to [] was causing it to stop working.
Instead we have a special const (SKIP) which ensures it will
continue to be evaluated and only this instance is skipped.
2020-06-30 17:39:52 +10:00
Roman Rizzi
7ddd83dfcf
FIX: Uploads cannot be mapped due to the cook-text's element attr being null ( #10136 )
2020-06-29 15:37:40 -03:00
Joffrey JAFFEUX
df1f804400
FIX: ensures moderation history is accessible from topic/post admin menu ( #10118 )
2020-06-24 10:49:47 +02:00
Bianca Nenciu
42226e12ee
FEATURE: Add after-user-name plugin outlet ( #10113 )
2020-06-24 15:45:11 +10:00
Jarek Radosz
13087cab54
FIX: Prevent typing "#" when showing "Jump to…"
...
Closes https://meta.discourse.org/t/the-shortcut-behaves-wrong-in-some-browsers/155531
2020-06-24 00:25:54 +02:00
Bianca Nenciu
aff9bfd5bc
FIX: Fix select kit size ( #10094 )
2020-06-22 16:48:00 +03:00
Martin Brennan
516a03be09
FIX: Improve admin permalink UX ( #10101 )
...
The admin permalink list was a little tricky to use because the URLs are easily reduced with a ... if they are too long. This adds a copy to clipboard button for the URL and a title on hover so the full text of the URL can be seen.
2020-06-22 13:14:16 +10:00
Kris
02d3bf304a
remove inaccurate comment, follow up to c028936
2020-06-19 16:49:56 -04:00
Kris
c0289362f7
Safari icon fix, follow up to 5cc0369
2020-06-19 16:44:34 -04:00
Mark VanLandingham
0b58414de2
DEV: Add classes to admin customize nav items ( #10092 )
2020-06-19 10:51:53 -05:00
Robin Ward
4a2871f7f6
FEATURE: Don't display muted/ignored users under "who liked" ( #10084 )
...
* FEATURE: Don't display muted/ignored users under "who liked"
Previously, if you clicked on the heart icon below a post
it would show you the avatar for a user even if you ignored or muted
them.
This commit will instead display a (?) icon. The count of likes will
remain correct, but you needn't be reminded of the person you
preferred not to see.
* Use a circle instead of (?) for unknown user
2020-06-19 10:44:21 -04:00
Martin Brennan
b5495b8e9c
FIX: Do not incorrectly add topic bookmark on Escape ( #10088 )
...
* The first post was showing as bookmarked incorrectly after pressing f to open the topic modal then pressing escape to cancel without saving, because the closeWithoutSaving option was not being respected.
* Also re-introduce the enter shortcut when the name input is focused to saveAndClose the bookmark modal by pressing enter.
2020-06-19 11:17:18 +10:00
Kris
5faf074e61
minor fix to post admin menu button class
2020-06-18 19:18:00 -04:00
Robin Ward
6cb6faff29
UX: Ignore modal margin was too tight
2020-06-18 13:26:25 -04:00
Joffrey JAFFEUX
b8c676e727
FEATURE: allows to ignore a user forever ( #10074 )
2020-06-18 11:24:07 -04:00
Mark VanLandingham
ec794c7f29
DEV: Plugin outlet after user-info ( #10072 )
2020-06-18 10:18:34 -05:00
Dan Ungureanu
62faa0f5fe
FIX: Do not show Add or Change buttons if email is not editable ( #10068 )
2020-06-18 11:15:44 +03:00
Penar Musaraj
d72ed8c5a8
UX: Include category name in hyperlink modal results on mobile
2020-06-17 14:46:01 -04:00
Dan Ungureanu
a60a67c431
FIX: Show unconfirmed emails too when checking emails ( #10062 )
...
When checking emails through user preferences, it did not display the
unconfirmed emails.
2020-06-17 21:41:01 +03:00
Jeff Wong
81a3129ffb
ARIA - add aria-label on topic input and post textarea ( #10057 )
...
Add reply form role with label as create/reply, and aria-labels on text inputs
2020-06-17 08:55:19 -07:00
Joffrey JAFFEUX
9da3a7f436
FEATURE: allows published pages to be public ( #10053 )
2020-06-17 12:42:20 +02:00
Jarek Radosz
7d289a4f3e
UX: Style video elements, show descriptions ( #10040 )
...
It's a stop gap – ideally we would generate a thumbnail for uploaded videos. For now, a bit of intentionality in the style and a pinch of context should do.
2020-06-17 12:38:00 +02:00
Jarek Radosz
a859d507e7
FIX: Prevent producing "undefined" strings ( #10042 )
...
Fixes a bug in search-menu-results (type: "group"), where:
```javascript
const fullName = escapeExpression(group.fullName);
const name = escapeExpression(group.name);
const groupNames = [h("span.name", fullName || name)];
```
`groupNames` could end up having value "undefined" if a group doesn't have a `fullName`.
2020-06-17 12:37:06 +02:00
Faizaan Gagan
d66ccabdb1
DEV: Added topic-list-after-title outlet in the mobile template ( #10059 )
2020-06-17 10:05:37 +01:00
Guo Xiang Tan
52580605d8
FIX: select-kit components not being hidden.
2020-06-17 09:39:51 +08:00
tshenry
a3e812453e
FEATURE: new category-list-above-each-category plugin outlet ( #10037 )
2020-06-16 11:53:36 -07:00
Jarek Radosz
df0e3b4ed4
FIX: Allow opening FAQ in a new tab ( #10039 )
2020-06-16 17:35:04 +02:00
Samuel Carvalho Santos
ce37561e10
UX: Improve revert label in post history modal ( #10038 )
2020-06-16 11:31:25 -04:00
spirobel
4b4f568ec0
add showPreview to composer fields plugin outlet ( #10019 )
...
showPreview is necessary because we need to add 50% width class similar to: class="title-and-category with-preview" on the category and title div if the preview is shown.
2020-06-16 10:50:55 -04:00
Krzysztof Kotlarek
6258406419
FIX: secondary_emails, unconfirmed_emails, group_users are private fields
...
Those fields should be only visible to the user.
2020-06-16 12:46:27 +03:00
Penar Musaraj
298393a5bc
FIX: Keep onebox styling in edit history
2020-06-15 15:23:14 -04:00
Arpit Jalan
6780d4d70c
FIX: process /invites/ route from server side only
2020-06-15 12:31:27 +05:30
Martin Brennan
35a157619a
FEATURE: Add "Now" as an option (default hidden) to the future date input selector ( #10047 )
...
Sometimes you need to schedule things from now onward. "Now" in this case is now + 1 minute. this option is hidden by default.
2020-06-15 14:06:03 +10:00
Kris
7429512ced
FIX: Get correct right/left offset for topic progress bar on compose
2020-06-12 18:44:42 -04:00
Kris
16b41aa485
Save button alignment fixes for admin badge page
2020-06-12 17:15:59 -04:00
Kris
2adad96d05
Center align items in select kit headers
2020-06-12 17:07:50 -04:00
Kris
d0a7f15764
Usercard buttons on mobile should utilize full width
2020-06-12 16:24:25 -04:00
Bianca Nenciu
ff6811ceb8
Allow multiple groups which can vote when creating a poll ( #10015 )
...
* FEATURE: Allow multiple groups which can vote when creating a poll
* DEV: Fix select-kit deprecations
* DEV: Fix lint
2020-06-12 14:52:32 +03:00
Bianca Nenciu
60196cc192
FIX: Hide bootbox after a negative answer ( #10028 )
...
Starting to reply and then editing a post was not possible because of a
bootbox which kept showing up.
2020-06-12 13:48:45 +02:00
Penar Musaraj
f57ecf22e0
UX: Send background color to iPad app too
...
Previously, we were only updating mobile devices.
2020-06-11 23:20:25 -04:00
Guo Xiang Tan
62ad473716
FIX: Preload readonly mode attribute seperately.
...
There are two problems I'm trying to tackle here.
1. The site json is cached for anonymous users so readonly mode can be
cached for up to 30 minutes which makes it confusing.
2. We've already checked for readonly mode in the controller so having
to check for readonly mode again in `SiteSerializer` is adding an extra
Redis query on every request.
2020-06-12 09:54:05 +08:00
Bianca Nenciu
dd85d44dda
FIX: Show tag count for existing tags ( #9892 )
...
* FIX: Show tag count for existing tags
* Add test
2020-06-11 14:13:48 +03:00
Joffrey JAFFEUX
6fa990f05d
FIX: prevents emoji in links to appear as large emojis ( #10027 )
2020-06-11 12:27:48 +02:00
Sam Saffron
a26b490047
FIX: present correct new/unread counts when filtered by tag
...
Previously we would incorrectly ignore tags.
This ensures tracking state is properly shipped to client if
show_filter_by_tag is enabled.
2020-06-11 16:47:57 +10:00
Mark VanLandingham
b8acb36532
DEV: Plugin outlet at top of user preference interface ( #10020 )
2020-06-10 13:36:50 -05:00
Dan Ungureanu
5bfe1ee4f1
FEATURE: Improve UX support for multiple email addresses ( #9691 )
2020-06-10 19:11:49 +03:00
Dan Ungureanu
3a7ca97c36
FIX: Use include-subcategories filter in report export ( #10007 )
...
Some filters were renamed and the conversion of the filter names and arguments
was removed.
2020-06-10 18:57:39 +03:00
Joffrey JAFFEUX
8fe074430b
REVERT: partly revert change to ensure context is the same ( #10012 )
2020-06-10 11:10:39 +02:00
David Taylor
9e98c02dd7
FIX: Don't call cooked decorators in composer if cooked is unchanged
...
If cooked is unchanged, ember will not re-render the preview area, so we should not re-run the post-processing decorators. This can cause issues when decorateCooked functions are not idempotent.
2020-06-09 23:01:07 +01:00
Vinoth Kannan
f67e7d2fad
FIX: add attributes of params to topic findOpts.
...
If `params` is ignored then `findTopicList` won't get the `no_subcategories` attribute.
d27b877a40
2020-06-10 01:33:58 +05:30
Joffrey JAFFEUX
43e17f92e0
DEV: allows to call a widget function without re-rendering the widget ( #10004 )
2020-06-09 19:58:17 +02:00
Joffrey JAFFEUX
84d767716f
linting ( #10008 )
2020-06-09 19:54:06 +02:00
Joffrey JAFFEUX
a3cf1cf6ff
DEV: allows to prepend widgets to post nav controls ( #10005 )
...
Co-authored-by: Régis Hanol <regis@hanol.fr>
2020-06-09 19:37:06 +02:00
Joffrey JAFFEUX
23ed16339f
DEV: adds mouse{Over,Out} and touch{Start,End} to widgets ( #10003 )
2020-06-09 19:36:28 +02:00
Joe
415c1bb9e1
FIX: don't show create topic suggestion to users who can't
...
Users with TL below the "min trust to create topic" setting used to see a prompt to create new topics in the footer message below the topic list. Those topics would never be submitted because those users don't meet the TL requirements to create a new topic (based on that site setting). This PR removes that prompt for those users.
2020-06-10 00:02:11 +08:00
Arpit Jalan
3094459cd9
FEATURE: multiple use invite links ( #9813 )
2020-06-09 20:49:32 +05:30
David Taylor
f1fc6cd40d
DEV: Add user-card-additional-buttons plugin outlet
...
The user-card-additional-controls outlet is outside the `<li>` element, which makes styling difficult. Placing an outlet inside the button list means that themes/plugins can easily reuse core styling.
2020-06-09 14:33:24 +01:00
Sam Saffron
08044b4f94
FIX: emoji autocomplete triggering incorrectly
...
Previous to this fix the we were checking for non letters.
This was mismatching what pretty-text/addon/emoji.js was doing.
`ù:su`
and
`1:su`
Would lead to an emoji autocomplete popup in the composer.
2020-06-09 17:22:51 +10:00
Martin Brennan
3e210b76d9
FIX: Change bookmark name "name" attr to disable autocomplete
2020-06-09 14:47:30 +10:00
Kris
d09bf892c7
UX: Improve layout of topic pin admin modal
2020-06-08 23:58:53 -04:00
Penar Musaraj
c5b1f028ed
FIX: update minimum required tag when switching categories in composer
2020-06-08 17:10:26 -04:00
Kris
fbeaba4acf
FIX: don't override category text color in dropdown
2020-06-08 16:45:30 -04:00
Penar Musaraj
bdba17cdf7
FIX: Restore stream position in safari ( #9993 )
...
Safari uses an aggressive back/forward cache, which means the app loads
very quickly when hitting Back. But, in topics with > 30 posts, hitting
Back runs post stream calculations too early, which means that users
get taken back to an earlier point in the stream, consistently.
Using `onpageshow`, we can restore the correct location before the post
stream calculations take place.
2020-06-08 10:13:46 -04:00
Joffrey JAFFEUX
cb13152a43
FIX: ensures edit-category-setting is correctly casting boolean ( #9999 )
2020-06-08 15:16:42 +02:00
David Taylor
833b5d89e0
PERF: Cache PrettyText instance for rendering composer preview ( #9987 )
...
Previously we were building pretty-text from scratch on every keypress
2020-06-08 10:42:59 +01:00
David Taylor
293467a37a
REFACTOR: Remove jquery usage from resolveAllShortUrls, and fix debounce
...
- This function now requires an explicit scope. It will never run on the entire document.
- Previously debounce was being used with an anonymous function, which means it was having no effect.
2020-06-05 17:15:14 +01:00
David Taylor
0f09fd22f3
DEV: Remove attachment css handling from resolveAllShortUrls
...
This was moved inside the markdown processor in 65481858
2020-06-05 15:12:30 +01:00
Robin Ward
a9def011d0
FIX: (getURL "") was not working with the i18n helper
2020-06-05 09:53:43 -04:00
David Taylor
be5974734d
PERF: Pass element to resolveAllShortUrl function, not text selector ( #9988 )
...
We already have a reference to the preview element, so there is no need to look it up again. This saves about 1ms per keypress in my testing.
2020-06-05 13:37:07 +01:00
David Taylor
731263b81c
PERF: Correctly memoize baseUri value in javascript app ( #9986 )
...
An empty string is a falsey value in javascript, so we were looking for the meta tag every time getURL was called, which took approximately 1.5ms every time.
2020-06-05 13:36:48 +01:00
Penar Musaraj
2de2537595
UX: add bottom padding to user lists on mobile
...
In some cases, when lists had a handful of items, the last item would be covered by the footer-nav eoverlay on PWAs and DiscourseHub.
2020-06-04 21:42:01 -04:00
Penar Musaraj
f6c3962e3c
UX: Change collapsed draft z-index on mobile
2020-06-04 21:24:14 -04:00
Kris
5cea4a6cc2
icon color fix, follow-up to 5cc0369
2020-06-04 17:29:28 -04:00
Kris
5cc0369898
Minor dropdown icon width fix
2020-06-04 17:26:57 -04:00
Rafael dos Santos Silva
f00e5515e4
FIX: Service Worker URL was broken
...
Behavior was changed in #9966 , which made the URL be relative.
If the user landed in a topic, for example, the browser was given a
service worker URL under that specific topic URL, which was a 404.
Fixes broken PWA install and broken push notifications
2020-06-04 14:49:39 -03:00
Joffrey JAFFEUX
a23d31e4d6
DEV: removes unecessary casting ( #9982 )
2020-06-04 19:07:34 +02:00
Penar Musaraj
2d880b42a3
UX: Add simple-list setting type ( #9970 )
2020-06-04 10:44:54 -04:00
Arpit Jalan
40dfac176f
FIX: client side /my/ redirects were appending extra slash
2020-06-04 17:32:34 +05:30
Mark VanLandingham
c200238bdc
DEV: Reorder appending extra header icons ( #9973 )
2020-06-03 14:28:02 -05:00
Vinoth Kannan
3e7f7fdde8
FEATURE: category setting for default list filter. ( #9975 )
2020-06-04 00:56:56 +05:30
Robin Ward
ba00cc8ec4
DEV: Move Discourse.getURL and related functions to a module ( #9966 )
...
* DEV: Move `Discourse.getURL` and related functions to a module
* DEV: Remove `Discourse.getURL` and `Discourse.getURLWithCDN`
* FIX: `get-url` is required for server side code
* DEV: Deprecate `BaseUri` too.
2020-06-03 12:45:26 -04:00
Joffrey JAFFEUX
d27b877a40
FIX: prevents false boolean param to be filtered as non existant ( #9968 )
...
* FIX: prevents false boolean param to be filtered as non existant
This was preventing to filter top category route to be filtered by replies.
* if order is different ascending should be true on first click
* test
* fix
* just pass params
* more fixxes
2020-06-03 10:19:53 -06:00
Guo Xiang Tan
141fba8866
UX: Ensure that select-kit is hidden consistently.
2020-06-03 11:51:01 +08:00
Kris
1b5a505930
Small fixes to image uploaders
2020-06-02 20:36:01 -04:00
Sam Saffron
10e321a96f
Revert "DEV: makes autocomplete debounced ( #9941 )"
...
This reverts commit f9e715672b
2020-06-03 08:40:21 +10:00
Kris
688d9428fe
Use an em-based width for better scaling with font-size changes
2020-06-02 17:14:04 -04:00
Kris
9e9ff01e86
Add missing text back in
2020-06-02 16:39:18 -04:00
Gerhard Schlager
0cf297725f
DEV: Use consistent interpolation key format in translations
...
From now on client strings can easily be reused on the server and you don’t have to think about choosing the right format anymore.
2020-06-02 19:05:10 +02:00
Mark VanLandingham
b3c8d36412
DEV: Plugin api for adding extra header icons ( #9964 )
2020-06-02 11:39:12 -05:00
Jarek Radosz
3e8d548d35
FIX: Prevent clipping user mentions ( #9962 )
2020-06-02 16:30:34 +02:00
Bianca Nenciu
d76ea9fa6b
FIX: Do not destroy $.fileupload element ( #9888 )
...
conditional-loading-section component rerendered the <input> element
and lost the necessary event handlers for jQuery-File-Upload.
2020-06-02 16:14:41 +10:00
Dan Ungureanu
ef3e3077d0
FIX: Staff users can bypass tag validation rule ( #9924 )
2020-06-02 16:11:25 +10:00
Joffrey JAFFEUX
f9e715672b
DEV: makes autocomplete debounced ( #9941 )
...
* DEV: makes autocomplete debounced
* better wording
2020-06-02 15:20:14 +10:00
Penar Musaraj
2a0a689442
UX: prevent devices from miscalculating fullscreen composer height
...
Fixes issue seen in some Chromebooks that flip between tablet and regular notebook window size
2020-06-01 22:24:16 -04:00
Sam Saffron
7e52106812
DEV: when synchornizing state pull tags
...
In some cases we may want topic tracking state to keep track of tags
this small change ensures we do not remove them if they are already in place
2020-06-02 11:42:00 +10:00
Robin Ward
a95826f60c
Remove discourse constants ( #9958 )
...
* DEV: `Discourse.baseUri` does not exist
This never could have worked - should have been `Discourse.BaseUri` if
anything.
* DEV: Remove Discourse.Environment
* DEV: Remove `Discourse.disableMissingIconWarning`
* DEV: A bunch more missing environment checks
2020-06-01 16:33:43 -04:00
Kane York
9162cd8f3d
FIX: Only render group card if user title is from group ( #9946 )
...
This was failing when a user with a primary_group chose to display a title coming from a badge.
2020-06-01 11:44:41 -07:00
Mark VanLandingham
b6709f0dda
DEV: Add option to only show icons to header widget ( #9935 )
2020-06-01 12:26:59 -05:00
tshenry
0d6b638dac
FEATURE: New plugin outlet under badges page title ( #9936 )
2020-06-01 08:55:51 -07:00
Jarek Radosz
e19d907f0f
FIX: Correct the misalignment of popover arrows ( #9947 )
...
* Fixes position of the top arrow, and border width of both
* Merged top and transform properties
* .5px values are required to make arrow border appear the same with as overall popover border width
I did have a chance to try it out on a Windows machine with a non-high DPI display and there were no issues. And I just re-tested it with Firefox on macOS using the "Open in Low Resolution" option and it looked more or less ok (bearing in mind that it the whole app is then a blurry mess, and that using custom zoom levels causes the arrow to break slightly, but that was also the case on Firefox before this change)
2020-06-01 16:31:53 +02:00
Penar Musaraj
c2abf88a61
UX: Adjustments to topic admin menu on mobile ( #9945 )
2020-06-01 09:39:38 -04:00
Jarek Radosz
921751f128
UX: Remove box-shadow from kbd, unify styling ( #9948 )
...
Having many elements with multiple box-shadows (e.g. in keyboard shortcuts modal) was tanking scrolling performance in some browsers.
2020-06-01 15:00:56 +02:00
Jarek Radosz
ef8e44af73
FIX: Don't change the button height when spinner appears
...
on the exception page.
2020-06-01 14:15:41 +02:00
Joffrey JAFFEUX
57e587f39f
DEV: removes dead code of dropdown-menu ( #9942 )
2020-06-01 11:22:35 +02:00
Jarek Radosz
6ed3dbef03
UX: Fix border radius artifacts on dashboard pills ( #9949 )
2020-06-01 11:21:07 +02:00
Joffrey JAFFEUX
40c4a8e3fc
DEV: skips/tweaks brittle tests ( #9952 )
2020-06-01 11:09:34 +02:00
Sam Saffron
82de9c5308
DEV: add countTags to topic tracking state
...
This introduces a new core API to get counts per tag from topic
tracking state
This API will only be useful if a plugin enable tags in topic
tracking state using
`TopicTrackingState.include_tags_in_report = true`
2020-06-01 17:05:24 +10:00
Jarek Radosz
9ee77eae98
FIX: z helper doesn't resolve inside calc
...
It resulted in invalid `z-index: calc(z("tooltip") - 100)` in the output CSS. `calc` wasn't necessary here anyway since both operands are constant.
2020-06-01 05:50:50 +02:00
Jarek Radosz
7bcee784c8
DEV: Remove an obsolete comment
...
Its first part was removed with other changes and this one got displaced after a `prettier` pass.
2020-06-01 05:50:49 +02:00
Jarek Radosz
754a255ef7
UX: Remove the period after "Enable Notifications" button
2020-06-01 05:50:49 +02:00
Jarek Radosz
7ac9a79ecb
UX: Fix inputs alignment in admin/customize/colors
2020-06-01 05:50:49 +02:00
Penar Musaraj
f2647f1f36
UX: Position topic admin menu next to wrench ( #9932 )
2020-05-30 15:32:57 -04:00
Vinoth Kannan
e1af91f5ae
Revert "FEATURE: category setting for default list filter."
...
This reverts commit 6f03d14c23
2020-05-30 20:53:53 +05:30
Joffrey JAFFEUX
93bd1ff228
FIX: topic-admin-popup-menu was overflowing on small screens ( #9944 )
2020-05-30 10:53:08 +02:00
Kris
530c6594cb
follow-up fix due to adding overflow hidden in 32e40ea
2020-05-29 22:23:23 -04:00
Kris
3c11c5dcdc
show-replies styles were lost with some menu changes
2020-05-29 22:05:58 -04:00
Kris
32e40ea133
UX: Make the menu links header within the user panel more flexible
2020-05-29 21:02:26 -04:00
Joffrey JAFFEUX
8f59f155fb
UI: makes topic count less visible in category drop ( #9938 )
2020-05-30 00:32:20 +02:00
Joffrey JAFFEUX
c5ccf5f93c
UI: removes font-weight: bold from category-drop names ( #9937 )
2020-05-30 00:06:35 +02:00
Joffrey JAFFEUX
03c3448b15
UX: better alignment of icons in notifications menu ( #9934 )
2020-05-29 22:48:47 +02:00
Joe
7a76f3c295
UX: Relocate before-topic-list outlet so it shows up on Top as well
2020-05-30 03:31:28 +08:00
Joe
8e6d95a309
DEV: adds a few plugin outlets required for themes ( #9929 )
2020-05-30 03:04:12 +08:00
Joffrey JAFFEUX
931bfca454
DEV: allows categories-admin-dropdown to have custom items ( #9931 )
...
Usage:
```
modifySelectKit("categories-admin-dropdown").appendContent(function() {
return {
id: "foo",
name: I18n.t("foo"),
description: I18n.t("foo_description"),
icon: "gear",
onChange: () => alert("Foo.")
};
});
```
2020-05-29 21:01:19 +02:00
Robin Ward
2b2434b82d
Start Discourse in an initializer ( #9930 )
...
* DEV: To be pedantic, there is more than EMBER in there now
* DEV: Use less globals. Have `Discourse` start in an initializer
* DEV: Remove another global
2020-05-29 14:37:02 -04:00
Robin Ward
3fe5eacd1b
DEV: Abstract Ember.testing so our application code doesn't use it
2020-05-29 12:16:58 -04:00
Robin Ward
e5cd331fb3
DEV: Why use a whole object when a functionw will do?
2020-05-29 11:56:45 -04:00
Joffrey JAFFEUX
5d792483f0
UI: various select-kit dropdown tweaks/cleaning ( #9922 )
2020-05-29 11:11:28 +02:00
Joffrey JAFFEUX
d7d5bb4454
UX: homogenises sk row padding and topic-admin-menu ( #9920 )
2020-05-29 09:35:43 +02:00
Joffrey JAFFEUX
4be45bec7e
UI: homogenise topic-footer-mobile-dropdown styles ( #9919 )
2020-05-29 08:34:19 +02:00
Joffrey JAFFEUX
31d1468922
UX: reworks various menus to homogenize them ( #9905 )
...
- bookmark modal menu
- topic-footer-mobile-dropdown
- post-admin-menu
- topic-admin-menu
- quick-access menus
- toolbar-popup-menu
2020-05-29 08:05:21 +02:00
Vinoth Kannan
ef5320dd47
FIX: don't rerender whole users page while typing on input.
2020-05-29 09:06:26 +05:30
Kris
c7d75bc3a0
Minor adjustment to menu-links-header spacing to avoid some wrapping
2020-05-28 18:40:22 -04:00
Vinoth Kannan
ce1491e830
UX: remove in:unpinned filter from advanced search page. ( #9911 )
2020-05-29 00:47:28 +05:30
Penar Musaraj
a98182debf
UX: Fix activity column display in wizard homepage step
...
Followup to f8f281cdad
2020-05-28 11:24:24 -04:00
Robin Ward
2033c3ec9c
Revert "Revert "DEV: Import MessageBus from message-bus-client instead of globals""
...
This reverts commit b10e995d9d
2020-05-28 08:42:36 -04:00
Joffrey JAFFEUX
0854785175
FIX: allows to define label/title properties for display instead of name
...
Usage:
```
const content = [{foo: "FOO", bar: "BAR", value: 1, name: "foo-bar"}];
{{combo-box
content=content
value=value
labelProperty="foo"
titleProperty="bar"
}}
```
2020-05-28 08:30:31 +02:00
Sam Saffron
ecc8e559ec
UX: remove edit PM button
...
Edit PM button leads to confusion and is uneeded
2020-05-28 15:15:27 +10:00
Kris
b9d9bbb95f
UX: More consistent alignment of topic timer's selected datetimes
2020-05-27 22:19:00 -04:00
Sam Saffron
9841569bba
Revert "DEV: Fix a deprecated ember import ( #9903 )"
...
This reverts commit 75f46ca632
2020-05-28 10:06:05 +10:00
Blake Erickson
b10e995d9d
Revert "DEV: Import MessageBus from message-bus-client instead of globals"
...
This reverts commit 9dddbcc00d
2020-05-27 16:14:09 -06:00
Jarek Radosz
75f46ca632
DEV: Fix a deprecated ember import ( #9903 )
...
See the following for `Ember.testing` and `@ember/debug isTesting`:
* 8cf29959f7/packages/ember/index.js (L372-L376)8cf29959f7/packages/%40ember/debug/lib/testing.ts
2020-05-27 22:47:46 +02:00
Robin Ward
9dddbcc00d
DEV: Import MessageBus from message-bus-client instead of globals
2020-05-27 16:42:42 -04:00
Robin Ward
0f71d38d3a
Revert "DEV: Import MessageBus from message-bus-client instead of globals ( #9902 )"
...
This reverts commit d3bd482142
2020-05-27 16:34:30 -04:00
Robin Ward
d3bd482142
DEV: Import MessageBus from message-bus-client instead of globals ( #9902 )
2020-05-27 15:56:46 -04:00
Joffrey JAFFEUX
77801aa9be
FIX: allows to have custom emoji translation without static file ( #9893 )
2020-05-27 20:11:52 +02:00
Roman Rizzi
207b72ade1
UX: Don't show the suspension date if the user is permantently suspended. ( #9895 )
...
Use the same pattern used in user.hbs
2020-05-27 14:50:17 -03:00
Penar Musaraj
7bc496070f
UX: Keep focus on input after selecting an autocomplete option
...
This is particularly helpful on mobile, now tapping on an item from
the autocomplete dropdown keeps the keyboard visible.
2020-05-27 12:45:03 -04:00
Arpit Jalan
68fdfd76f5
fix the build
2020-05-27 22:06:45 +05:30
Arpit Jalan
8d2908dd9e
UX: do not show redundant user count
...
UX: add spacing between +member_count and "more"
2020-05-27 21:53:59 +05:30
Roman Rizzi
461df7d050
UX: Rename Priority to score for sorting. ( #9846 )
2020-05-27 12:50:28 -03:00
Joffrey JAFFEUX
f51093dde7
FIX: correctly set values and defaults for group-form-interaction-fields ( #9891 )
2020-05-27 12:10:27 +02:00
Sam Saffron
1cf2d1f9f2
FIX: when destroying a draft always ensure saving is done
...
There was a race condition where drafts could be either saving
or queued to be saved and a user canceled draft leading to destroying
it.
This cancels debounce save and waits for save in the pipeline to
be over prior to firing off a DELETE on the draft
2020-05-27 18:46:19 +10:00
Sam Saffron
f41fcad6c3
FIX: opening cancel draft dialog broke autosave
...
cancelComposer would leak a promise that never got resolved if
you aborted cancelling a composer.
This change ensured the promise will always be resolved
2020-05-27 18:16:48 +10:00
Kris
66ec634cb3
Composer whisper icon missing margin when editing replies
2020-05-26 19:17:09 -04:00
Jordan Vidrine
5f61deff80
FIX: updates variables for HTML to use em instead of px in font-size ( #9883 )
2020-05-26 17:48:35 -05:00
Penar Musaraj
b1c726be0d
Remove support for FontAwesome 4.7 icon names ( #9871 )
2020-05-26 14:53:32 -04:00
Mark VanLandingham
7820686f73
FIX: Wizard previews if color step is excluded ( #9881 )
2020-05-26 12:56:36 -05:00
Joffrey JAFFEUX
675e9b81c6
FIX: document.activeElement can be null on IE11 ( #9880 )
2020-05-26 16:51:55 +02:00
Joffrey JAFFEUX
253a185769
FIX: makes focust text area after complete more resilient ( #9879 )
2020-05-26 16:27:02 +02:00
Joffrey JAFFEUX
d9f915b195
FIX: documentation was using incorrect function ( #9876 )
2020-05-25 21:55:30 +02:00
Joffrey JAFFEUX
be16205118
DEV: plugin api should have been bumped for #8825395 ( #9874 )
2020-05-25 21:44:15 +02:00
Joffrey JAFFEUX
8825395bdc
DEV: allows to decorate username selector ( #9869 )
...
Usage:
```
api.addUsernameSelectorDecorator(username => {
return iconHTML("calendar-alt");
});
```
2020-05-25 19:09:55 +02:00
Gerhard Schlager
631024ae5d
FEATURE: Permalinks for tags
2020-05-25 14:51:01 +02:00
Sam Saffron
48fb354bce
PERF: avoid traversing DOM in loadScript
...
Once a script is loaded operation should be very fast.
This optimisation avoids a DOM traverse and call to getURL on
every invocation.
2020-05-25 18:19:59 +10:00
Vinoth Kannan
47c6fe9bfa
Merge branch 'master' of github.com:discourse/discourse
2020-05-25 11:36:18 +05:30
Bianca Nenciu
e31adef32d
FIX: Keep composer title and reply when switching to PM ( #9851 )
2020-05-25 15:46:02 +10:00
Vinoth Kannan
8e56197728
UX: use "icon-picker" & "image-uploader" fields to set group flair. ( #9779 )
2020-05-25 11:08:47 +05:30
Vinoth Kannan
6f03d14c23
FEATURE: category setting for default list filter.
2020-05-25 00:04:06 +05:30
Vinoth Kannan
058bf56b4c
FIX: group card not showing if user can't see its members.
2020-05-24 23:08:51 +05:30
Vinoth Kannan
60a3110113
FIX: call getURL method explicitly to prevent this context override.
2020-05-24 21:58:03 +05:30
Michael Brown
d9a02d1336
Revert "Revert "Merge branch 'master' of https://github.com/discourse/discourse ""
...
This reverts commit 20780a1eeee62a85cf2660c2e203d26cd6
2020-05-23 00:56:13 -04:00
Jeff Atwood
20780a1eee
Revert "Merge branch 'master' of https://github.com/discourse/discourse "
...
This reverts commit e62a85cf6f2660c2e21d
2020-05-22 20:25:56 -07:00
Jordan Vidrine
bf8085e436
FIX: Double Button Alignment Mobile ( #9862 )
2020-05-22 13:33:29 -05:00
Joffrey JAFFEUX
06e1d430c1
FIX: better cross browser topic footer buttons alignment ( #9860 )
2020-05-22 17:03:22 +02:00
Mark VanLandingham
f9649c92b5
FIX: Live reloading of css in development ( #9859 )
2020-05-22 16:37:35 +02:00
Joffrey JAFFEUX
793085c703
REFACTOR: slightly cleaner topic admin button css ( #9858 )
2020-05-22 15:23:17 +02:00
Joffrey JAFFEUX
e71f5e8951
UI: apply margin only if the menu has content ( #9857 )
2020-05-22 15:19:55 +02:00
Neil Lalonde
5a71c51ddd
FIX: tag input says tags are optional when they're required
2020-05-21 12:40:33 -04:00
Mark VanLandingham
1a5bcf2a64
UX: Remove live theme previewing in favor of refresh ( #9798 )
2020-05-21 08:32:50 -05:00
Joffrey JAFFEUX
66960563ea
FIX: ensures category chooser is case insensitive ( #9850 )
2020-05-21 11:16:44 +02:00
Arpit Jalan
18959ff9da
UX: user name instead username for profile link title
2020-05-21 14:02:12 +05:30
Arpit Jalan
3c9212fd88
UX: add title for user profile link
2020-05-21 13:00:05 +05:30
Kris
62ecb2885f
glob @import desktop and mobile scss
2020-05-20 18:05:27 -04:00
Roman Rizzi
234933c781
FIX: Show staff counters if the rejected posts count is the only value to show ( #9845 )
2020-05-20 19:00:35 -03:00
Kris
eef47a26d9
UX: More consistent mobile banner/alert styles, css cleanup
2020-05-20 17:17:47 -04:00
Robin Ward
ba04bb7552
FIX: Path should be addon not app
2020-05-20 12:13:15 -04:00
Robin Ward
3062036f2f
FIX: Allow deprecation to work with Ember CLI
2020-05-20 12:05:56 -04:00
Robin Ward
09ca75d17e
FIX: select-kit was in the wrong place
...
`app/` means we want to merge it into our application there. `addon`
means give it its own module namespace, which is what we wanted.
2020-05-20 11:51:49 -04:00
Robin Ward
6c9c8dfefd
FIX: guidFor is not part of Ember.Object
2020-05-20 11:31:11 -04:00
Mark VanLandingham
bd57ae83f1
DEV: Guardian for hiding about stats ( #9841 )
2020-05-20 10:26:20 -05:00
Joffrey JAFFEUX
30631a963f
UX: moves editFirstPost in taggable Pms in dropdown on mobile ( #9840 )
2020-05-20 14:07:00 +02:00
Bianca Nenciu
fb15da43da
Remove old web hooks in favor of 'reviewable' web hook ( #9776 )
...
* FIX: Emit web hooks for flags
* FEATURE: Remove 'flag' web hook in favor of 'reviewable' web hook
* FEATURE: Remove 'queued post' web hook in favor of 'reviewable' web hook
* FIX: Do not set a default value for web hooks with no events
2020-05-20 12:07:48 +03:00
Sam Saffron
e97cb20c2a
UX: strip text from PM bookmark and share buttons
...
Also organize priorities in an easier to reason about way and
shift bookmark topic so it is after link. (consistent with posts)
2020-05-20 16:46:49 +10:00
Kris
a93d0a8fcc
UX: Remove bold from category badge text
2020-05-19 21:11:49 -04:00
Roman Rizzi
52228b1fa6
DEV: These routes don't exist anymore ( #9823 )
2020-05-19 16:09:03 -03:00
Joffrey JAFFEUX
a239900522
UI: reduces category row description margin ( #9834 )
2020-05-19 20:44:54 +02:00
Joffrey JAFFEUX
05d8091bd3
DEV: adds triggerOnChangeOnTab option to select-kit ( #9833 )
...
Usage:
```
options=(hash triggerOnChangeOnTab=false)
```
This will prevent to select the row when pressing tab.
2020-05-19 20:39:29 +02:00
Joffrey JAFFEUX
ab6737c44a
UX: improves topic-notifications-button loading behavior ( #9832 )
2020-05-19 17:13:40 +02:00
Joffrey JAFFEUX
7c3663ff73
UX: adds visual feedback when changing topic notifications level ( #9831 )
2020-05-19 13:27:57 +02:00
Joffrey JAFFEUX
1647ba4624
FIX: applies flex on topic-footer-main-buttons ( #9829 )
2020-05-19 11:29:38 +02:00
Joffrey JAFFEUX
3623a395dc
UI: refinements to topic footer buttons ( #9780 )
2020-05-19 09:51:34 +02:00
Guo Xiang Tan
062cb1e1cb
UX: Remove caret from notifications-button.
2020-05-19 13:41:13 +08:00
Kris
864fb45ff0
Improve mobile friendliness of crawler view
2020-05-19 00:24:17 -04:00
Joffrey JAFFEUX
cfad38184d
FIX: improves and fixes a regression with category-selector ( #9821 )
2020-05-18 17:44:47 +02:00
Joffrey JAFFEUX
1876b3cc4c
FIX: more resilient/consistent date-picker loading ( #9817 )
2020-05-18 15:29:24 +02:00
Joffrey JAFFEUX
48ed1b40cf
REFACTOR: ensures later is correctly canceled ( #9796 )
2020-05-18 14:20:23 +02:00
Joffrey JAFFEUX
9482ddff73
UX: show caret only in topic footer buttons dropdown select boxes ( #9816 )
2020-05-18 14:07:40 +02:00
Joffrey JAFFEUX
320b21ab5b
UX: allows dropdown-select-box to display a caret ( #9803 )
...
```
selectKitOptions: {
showCaret: true // default false
}
```
2020-05-18 10:50:33 +02:00
Joffrey JAFFEUX
e5dc843185
FIX: ensures hide is called when card is destroyed ( #9814 )
2020-05-18 10:10:40 +02:00
Joffrey JAFFEUX
e81a4048e3
REFACTOR: s/focusAfterOnchange/focusAfterOnChange ( #9801 )
2020-05-16 11:20:37 +02:00
Robin Ward
db8e872bda
DEV: Move select kit to an addon ( #9797 )
2020-05-15 16:07:35 -04:00
Alan Guo Xiang Tan
7f07c513a7
FIX: Switching composer action does not refresh composer actions content ( #9791 )
2020-05-15 13:54:44 -04:00
Robin Ward
6b04760572
FIX: Component was still used by data explorer
2020-05-15 13:52:03 -04:00
Joffrey JAFFEUX
7edd312f85
UX: focus category name when editing category ( #9795 )
2020-05-15 18:27:06 +02:00
Joffrey JAFFEUX
b07f1bfd93
FIX: displays a title on sk header if no selected name ( #9794 )
...
none has to be defined.
2020-05-15 17:36:00 +02:00
Justin DiRose
9810ca1dbd
UX: Add copied text upon copy button click ( #9793 )
2020-05-15 17:08:46 +02:00
Guo Xiang Tan
d1146ccb7b
Revert "FIX: Correct plugin api version bump."
...
This reverts commit 6a96c424b7
2020-05-15 21:22:44 +08:00
Guo Xiang Tan
6a96c424b7
FIX: Correct plugin api version bump.
...
It doesn't seem to be following semver.
2020-05-15 21:17:50 +08:00
Guo Xiang Tan
162d125b83
Fix lint.
2020-05-15 20:23:17 +08:00
Guo Xiang Tan
dada1fc417
UX: Better composer-action icon when creating new topic.
2020-05-15 16:40:49 +08:00
Guo Xiang Tan
f9a9bd136b
FEATURE: Expose Composer.serializeToTopic in client side plugin api.
2020-05-15 16:16:58 +08:00
Blake Erickson
1a2b9435b0
DEV: Standardize table sorting verbiage ( #9757 )
...
* DEV: Standardize table sorting verbiage
This commit creates a common component that tables can use to make their
headers sortable. This commit also standardizes on using `desc` as the
default and passing in the `asc=true` flag to adjust the sorting
direction.
* Add deprecation warnings
Adds deprecation warnings if using previous params and maintains
backwards compatibility. Set the default sort value for group members to
be asc.
* switch group requests to use common table-header-toggle
* update fixture
2020-05-14 20:10:59 -06:00
Kane York
869f9b20a2
PERF: Dematerialize topic_reply_count ( #9769 )
...
* PERF: Dematerialize topic_reply_count
It's only ever used for trust level promotions that run daily, or compared to 0. We don't need to track it on every post creation.
* UX: Add symbol in TL3 report if topic reply count is capped
* DEV: Drop user_stats.topic_reply_count column
2020-05-14 15:42:00 -07:00
Kane York
e0e967ac46
FIX: Apply code quoting with no syntax highlighting ( #9784 )
2020-05-14 13:03:42 -07:00
Mark VanLandingham
bec6bace53
DEV: Allow plugins to hide user stats by new guardian method ( #9772 )
2020-05-14 11:57:35 -05:00
Penar Musaraj
87b9488137
UX: Limit iOS modal keyboard changes to composer
...
Followup to 423802fbc
2020-05-14 12:48:28 -04:00
Robin Ward
aa2d040526
DEV: Update ESLint to remove I18n global
...
Also fixes missed imports in core.
2020-05-14 10:18:12 -04:00
