github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-12-04 20:20:28 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity
33,643 Commits 214 Branches 500 Tags 960 MiB
48b9e0d749
Commit Graph

10748 Commits

Author SHA1 Message Date
Roman Rizzi
77931b70c3
Revert "DEV: Upgrade to Ember 3.7.0 (#6977)" (#7165) 
This reverts commit 3eebf8be73.
 2019-03-13 15:49:47 -03:00
Maja Komel
65f3ed0689 UX: make name optional for confirmation user field (#7149) 2019-03-13 18:40:43 +01:00
Maja Komel
12c37ada2e UX: focus on search box when emoji picker is opened (#7098) 2019-03-13 17:48:40 +01:00
Dan Ungureanu
91bd0becaa DEV: Allow topics to register default topic order criteria. (#7158) 2019-03-13 16:44:08 +01:00
Vinoth Kannan
c773f82ba1 DEV: Added qunit test functions and did minor refactoring 
135191d1d1
 2019-03-13 18:38:27 +05:30
Joffrey JAFFEUX
d32557ea32 Revert "FIX: Better emoji escaping for topic title" 
This reverts commit 35426b5ad6.
 2019-03-13 13:02:56 +01:00
Maja Komel
3eebf8be73
DEV: Upgrade to Ember 3.7.0 (#6977) 
* Upgrade to Ember 3.7.0

* use ember source 3.7.0.2

* fix mobile header

* fix navigation
 2019-03-13 12:16:06 +01:00
Vinoth Kannan
1b454c73ae FIX: 'topic' can have null value 2019-03-13 16:34:47 +05:30
Tim Lange
35426b5ad6 FIX: Better emoji escaping for topic title 
This commit also puts emojiVersion in its own erb file.
 2019-03-13 11:17:59 +01:00
Vinoth Kannan
135191d1d1 DEV: Option to add extra topic status icons in its widget and component 
and did some refactoring
 2019-03-13 15:17:26 +05:30
Guo Xiang Tan
b0c8fdd7da FIX: Properly support defaults for upload site settings. 2019-03-13 16:36:57 +08:00
Tim Lange
d1c4981f65 UX: Added tooltips to topic admin menu (#7146) 
* UX: Added tooltips to topic admin menu

* FIX: Prettyfied code

* FIX: Fixed typo

* Update config/locales/client.en.yml

Co-Authored-By: venarius <tim.lange@online.de>
 2019-03-13 17:11:36 +11:00
Joffrey JAFFEUX
edc6d87862 FIX: invite-panels regressions on private topics (#7157) 2019-03-13 16:34:23 +11:00
Tarek Khalil
db08b59eb2
UX: Change ignore button color (#7150) 2019-03-12 11:10:18 +00:00
Joffrey JAFFEUX
90965e1c18
FIX: error with two inputs having the same id (#7147) 2019-03-12 09:46:58 +01:00
Bianca Nenciu
e6c2faf186 FIX: Disable 'Create Topic' button if tag is staff-only. (#6984) 
* FIX: Disable 'Create Topic' button if tag is staff-only.

* FIX: Staff-only tags should always return 404.
 2019-03-12 19:23:36 +11:00
venarius
dc4541a95c FIX: Text content search warning if more than 50 results 2019-03-11 12:56:15 -04:00
Robin Ward
da7406e567 Update app/assets/javascripts/discourse/controllers/full-page-search.js.es6 
Co-Authored-By: venarius <tim.lange@online.de>
 2019-03-11 11:33:24 -04:00
venarius
5f00624814 FIX: Fixed vanishing select boxes on full search as new content loads 2019-03-11 11:33:24 -04:00
Neil Lalonde
cbc8236288 UX: add a paragraph description on the tags tab of the category settings 2019-03-08 16:46:32 -05:00
Dan Ungureanu
35942f7c7c
FEATURE: Special call-out for new / returning posters. (#7115) 2019-03-08 10:48:35 +02:00
Simon Cossar
65464969cd Change searchTearm to searchTerm (#7130) 2019-03-08 09:24:14 +01:00
Joffrey JAFFEUX
3acf8a95f3
UX: various tweaks to search-menu (#7114) 2019-03-08 09:23:44 +01:00
Joffrey JAFFEUX
c90267db52
FIX: do not display add/remove participants if you can’t actually do it (#7125) 2019-03-08 09:23:26 +01:00
Kris
ccff1d2dbb prettier 2019-03-07 13:30:39 -05:00
Kris
837452794b Target active nav pill with single style 2019-03-07 13:21:42 -05:00
Arpit Jalan
2c8e1d3578 FEATURE: remove all expired invitations by default 2019-03-07 15:28:39 +05:30
Arpit Jalan
caef0a56d1 FEATURE: create a new message via URL without specifying user or group 2019-03-07 11:30:24 +05:30
Kris
a917a93990 fix active class, remove style 2019-03-06 17:29:19 -05:00
Bianca Nenciu
733deba585 FIX: Loading draft also replaces the recipients (#7122) 2019-03-07 08:14:55 +11:00
Kris
078c02cd24 UX: More consistent structure for active nav-pill 2019-03-06 16:10:22 -05:00
Vinoth Kannan
5ba2ef4274 UX: Display error message if no time frame selected in topic status update 2019-03-07 02:17:29 +05:30
Kris
2db3652338 UX: Fix redeemed invite table layout 2019-03-06 11:05:45 -05:00
Kris
5cf63e43c6 FEATURE: Add about-after-description plugin outlet 2019-03-06 10:26:34 -05:00
Tarek Khalil
0a9a11094d
FEATURE: Save ignored usernames in user preferences (#7117) 
* FEATURE: Save ignored usernames in user preferences
 2019-03-06 11:21:58 +00:00
Tarek Khalil
b58eea1fcb
FEATURE: Hide ignored user's Original Post content (#7113) 
* FEATURE: Hide ignored user's Original Post content
 2019-03-06 09:20:45 +00:00
Arpit Jalan
05ebb52ec4
FEATURE: defer flags when deleting child replies (#7111) 2019-03-06 14:32:25 +05:30
Kris
b5804c410e UX: Add slash to mobile category page totals 2019-03-05 20:16:12 -05:00
Kris
84892429ed UX: Improve layout of invite table 2019-03-05 14:50:27 -05:00
Gerhard Schlager
671cec4bd2 DEV: Use Discourse.getURL for creating URL 
follow-up to ccb48bef75
 2019-03-05 17:52:18 +01:00
Tarek Khalil
190b19f3c2
FEATURE: Add ignored user list to the User's preference page (#7107) 
* FEATURE: Add ignored user list to the User's preference page

## Why?

Part of: https://meta.discourse.org/t/ability-to-ignore-a-user/110254

We want to add list of Ignored users under or along with the muted users preferences section.
This way Users can find and update their list of ignored users.

## UI


![gif](https://user-images.githubusercontent.com/45508821/53746179-8e9b3c00-3e98-11e9-9e90-94b8520896a6.gif)

## Open questions

Two of many options to represent a list of ignored users is that we can:

1. We can represent the ignored user list as a table with the ability to `un-ignore` but NOT to add new ignored users.
2. We can keep it functioning as the `muted user list` where you can `un-ignore` or `ignore` users.
 2019-03-05 14:47:51 +00:00
Tarek Khalil
f19d36cbba
REFACTOR: Change watch wording to unignore (#7112) 
* REFACTOR: Change `watch` wording to `unignore`
 2019-03-05 14:40:31 +00:00
Gerhard Schlager
ccb48bef75 UX: Make Uncategorized category less confusing 
* Adds warnings to the "Edit Category" dialog
* Doesn't hide the "Security" tab on the "Edit Category" dialog anymore. Instead, it shows an explanation why permissions can't be changed.
* Makes the category name translatable
* Hides the category name from the edit dialog (it can be customized by overriding the translation)
* Creates a translation override if the category has been renamed in the past
 2019-03-05 14:42:41 +01:00
Gerhard Schlager
68e4aba369 UX: Don't concatenate title on "Edit Category" dialog 2019-03-05 14:42:41 +01:00
Tarek Khalil
079b0f4bff
FIX: Remove ignore user feature from user-card-contents component (#7104) 
Based on our discussions, we want to have the `Ignore button will ONLY be on the User’s profile page`.
 2019-03-04 15:21:45 +00:00
Joffrey JAFFEUX
2e881adb6e
FIX: select-kit perf and positioning improvements (#7093) 2019-03-04 10:30:22 +01:00
Joffrey JAFFEUX
dc4001370c
FEATURE: displays groups in menu search (#7090) 2019-03-04 10:30:09 +01:00
Joffrey JAFFEUX
075b264338
DEV: replaces DOMNodeInserted by the better MutationObserver (#6884) 2019-03-04 10:28:59 +01:00
Arpit Jalan
824d9402a4 FIX: pending counts were not shown on invites tab 2019-03-04 14:14:13 +05:30
Joffrey JAFFEUX
bb39a6f7d7 REFACTOR: topic-list-header-column (#7099) 2019-03-04 14:45:52 +11:00
Jeff Atwood
9585e2dff2 change separator from | to • for editor image sizing 2019-03-03 17:55:21 -08:00
Gerhard Schlager
14f9e55977 FIX: Error when filtering site settings 
Happened only when none of the logo settings had an image assigned.
 2019-03-03 20:43:22 +01:00
Dan Ungureanu
fd9671f7fe
DEV: Minor code improvements. 2019-03-02 19:07:54 +02:00
Sam
03a70ef69c FIX: allow underscore and dash in username search 
_ and - are technically punctuations, but we allow them in usernames so
accept them in search
 2019-03-01 15:23:45 +11:00
Sam
cdf34657f6 FEATURE: focus on composer TEXTAREA when iPad has a physical keyboard 
This disables a bunch of hacks that bypassed "focus" on iOS (cause focus
events that involve a virtual keyboard on iOS cause browser havoc unless
a physical keyboard is attached)

Also will focus on title on new topic
 2019-03-01 11:31:52 +11:00
Dan Ungureanu
6bc8382555 FEATURE: Use smooth scrolling for J/K keyboard shortcuts. (#7084) 2019-03-01 09:31:40 +11:00
Vinoth Kannan
be436066ff FIX: Prevent default event and stop bubbling up when card popup is closed in mobile 2019-03-01 01:42:17 +05:30
Penar Musaraj
64a3d63ddc DEV: Rename some icons with deprecated names 2019-02-28 13:03:14 -05:00
David Taylor
e67474daf4 UX: Don't link to theme source unless it's http(s) 2019-02-28 17:01:59 +00:00
Joffrey JAFFEUX
1cd64f68f1
FIX: staff/admin shouldn’t be able to create uncategorized topics (#7077) 2019-02-28 15:51:13 +01:00
David Taylor
3517103398 UX: Correct locale key for theme compatibility error 2019-02-28 14:40:33 +00:00
Arpit Jalan
c02956e29c
FIX: when posts are moved to a message then small action post should not be publicly visible (#7085) 
This fix is inspired from what we do in discourse-assigned plugin.
https://github.com/discourse/discourse-assign/blob/master/lib/topic_assigner.rb#L184
https://github.com/discourse/discourse-assign/blob/master/assets/javascripts/discourse-assign/initializers/extend-for-assigns.js.es6#L125-L133
 2019-02-28 19:49:26 +05:30
Maja Komel
bb5119b88f FIX: only profile owner can see links to watched/tracked/muted topics (#7083) 2019-02-28 14:58:49 +01:00
Joffrey JAFFEUX
883a18547e
FIX: shows invite panel on mobile from topic footer buttons (#7080) 2019-02-28 14:56:22 +01:00
David Taylor
6296554ed1 DEV: Add additional hook for theme-creator 2019-02-28 10:48:30 +00:00
Sam
06abecdb41 FEATURE: on iPad bluetooth keyboard use ALT-ENTER for post submit 
Command and Control can not be properly detected via JavaScript so lean on
Alt that can be detected.
 2019-02-28 16:41:31 +11:00
Sam
0b86a99c39 FEATURE: allow iPad users to specify they have a physical keyboard 
Sadly there is no clean way of detecting a keyboard is connected to an iPad

If the keyboard is connected we want to disable all the touch related hacks
on iOS

This allows iPad users to specify they have a keyboard connected. Setting
is per device.
 2019-02-28 15:59:44 +11:00
Kris
cafbb3aea7 UX: Use official Facebook logo 2019-02-27 09:52:06 -05:00
Tarek Khalil
986cc8a0fb FEATURE: Introduce Ignore user (#7072) 2019-02-27 14:49:07 +01:00
Joffrey JAFFEUX
5c476f639c
REFACTOR: user-invited-show (#7078) 2019-02-27 12:59:57 +01:00
Joffrey JAFFEUX
8ff3fc20a6
REFACTOR: tags-show (#7079) 2019-02-27 12:59:39 +01:00
Maja Komel
7d2ea2d4dd FEATURE: image resizing discoverability (#6804) 2019-02-27 11:46:16 +01:00
Maja Komel
6f427589b2 FIX: make it possible to use backup code everywhere where 2FA required (#7010) 2019-02-27 10:37:33 +01:00
Erick Guan
e1d1073273 FIX: use * when apply italics in the editor instead of _ (#7063) 2019-02-27 10:36:14 +01:00
Kris
ef9b249cd2 UX: More consistent table header styles, removing duplicate styles 2019-02-26 21:40:17 -05:00
Vinoth Kannan
59c66fd226
REFACTOR: Improve the readability of code (#7076) 2019-02-26 23:03:49 +05:30
Joffrey JAFFEUX
fbedaea5ed
FIX: prevents double network calls and other quirks on admin emails (#7074) 2019-02-26 17:53:52 +01:00
Joffrey JAFFEUX
8c706b0ff7
fix tests (#7073) 2019-02-26 16:49:29 +01:00
Joffrey JAFFEUX
d04c4bf8e7
UX: puts back share-panel as floating pane on post actions (#7066) 2019-02-26 14:15:25 +01:00
Arpit Jalan
6ea9f5c9c5 FIX: do not update tag name on /tags/intersection 2019-02-26 16:43:39 +05:30
Joffrey JAFFEUX
1cee8a86f6
fix prettier (#7071) 2019-02-26 11:24:02 +01:00
Joffrey JAFFEUX
a206c7f5d5
FIX: attempts to fix an error with EXTEND_PROTOTYPES (#7067) 2019-02-26 11:04:05 +01:00
Joffrey JAFFEUX
71360436ff
FIX: users list show was loading multiple times with different params (#7058) 
A first load was happening in route, which was setting properties on controller. These properties were observed on the controller and were triggering a reload of the AdminUser model.

Not only was it doing loading two times it was also sometimes resulting on the controller model refresh end to happen after route has been changed, resulting in a wrong model.
 2019-02-26 10:43:24 +01:00
Vinoth Kannan
ed0120171c FIX: Hide 'show associated accounts' button if moderators can't see emails 
And minor prettier code alignments
 2019-02-26 13:49:27 +05:30
Simon Cossar
c742d42031 FIX: rtl topic progress wrapper position (#7070) 
* Set left/right topic-progress-wrapper CSS from text-direction

* Remove unnecessary CSS rule
 2019-02-25 20:56:52 -05:00
Osama Sayegh
d5efe2d7ee UX: make composer resize work on touch devices (#7068) 
* UX: make composer resize work on touch devices

This also replaces a vendor dependency with a small built-in resize mechanism.

* Make blue bar's larger padding specific to touch devices
 2019-02-26 08:04:14 +11:00
Joffrey JAFFEUX
5952a6c0ad
DEV: uses find() helper instead of this.$() in js tests (#7062) 2019-02-25 16:04:55 +01:00
Joffrey JAFFEUX
c0dd171cf1
REFACTOR: bread-crumbs (#7064) 2019-02-25 14:51:14 +01:00
Joffrey JAFFEUX
6930706830
REFACTOR: new message route (#7061) 2019-02-25 14:01:00 +01:00
Arpit Jalan
91e771ece6 FIX: send test email doesn't show a status 2019-02-25 17:42:58 +05:30
Joffrey JAFFEUX
900e187627
DEV: removing blank files (#7057) 2019-02-25 09:52:44 +01:00
Joffrey JAFFEUX
919839fd97
FIX: allows {{d-button}} to set a form attribute (#7056) 
This attribute is used when a submit button is out of a form. It makes it explicit which form this button is submitting.

It's currently used in our login modal form.
 2019-02-25 09:49:49 +01:00
Joffrey JAFFEUX
87f4ee13ef
UX: puts more emphasis on the shared url on share panel (#7055) 2019-02-22 23:22:11 +01:00
Jeff Wong
8be7878656 FEATURE: add ability to clear previously set mobile_view with mobile_view=auto 2019-02-22 10:44:49 -08:00
Joffrey JAFFEUX
8aca26cce3
FIX: allows right-click on post-date sharing link (#7054) 2019-02-22 15:18:05 +01:00
Vinoth Kannan
d1bad881ea
FEATURE: Allow moderators to change topic timestamps (#7053) 2019-02-22 14:33:52 +05:30
Kris
87b5003453 UX: Increase width of hamburger menu to 320px 2019-02-21 21:52:21 -05:00
Sam
31d41f532e PERF: do not include suggested topics when loading new posts 
When a new post is triggered via message bus post stream will attempt to load
it, previously the `/topic/TOPIC_ID/posts.json` would unconditionally include
suggested topics, this caused excessive load on the server.

New pattern defaults to exclude suggested and related topics from this API
unless people explicitly ask for suggested.
 2019-02-22 10:37:18 +11:00
Penar Musaraj
74ed72e825 DEV: Remove d-checkbox component 
Replaces the last occurrence of `d-checkbox` with a regular input element.

Includes a minor refactor of admin site text search.
 2019-02-21 09:54:54 -05:00
Guo Xiang Tan
1dee71d760 UX: Disabled lightbox expand button when loading image meta. 2019-02-21 22:30:57 +08:00
Joffrey JAFFEUX
090acb5b11
FIX: s/isMessage/isPM (#7048) 
Regression due to refactoring
 2019-02-21 13:53:50 +01:00
Joffrey JAFFEUX
8d779db270
FIX: allows invite modal from topic-map post-actions (#7047) 2019-02-21 13:48:03 +01:00
Guo Xiang Tan
46e62c0d22
UX: Default user facing routes to /g instead of /groups. (#7042) 2019-02-21 13:44:25 +08:00
Sam
07b856700d REFACTOR: remove disallowEmails option from user-selector 
Negative option was leading to a fair amount of confusion, going forward
if we want to allow selection of emails from user selector it must be
supplied with `allowEmails=true`

This corrects a regression in 1f4ace4f which broke invite by emails and
start PM to email
 2019-02-21 16:37:26 +11:00
Sam
79841cf7dd FEATURE: add missing autocomplete suppressions 
Following 1f4ace4f add a couple more autocomplete suppressions (in polls
and invite ui)
 2019-02-21 16:37:26 +11:00
Guo Xiang Tan
d3cd314a98 Make eslint happy. 2019-02-21 10:26:56 +08:00
Guo Xiang Tan
58b0e945bd
UX: Lightbox support for image uploader. (#7034) 2019-02-21 10:13:37 +08:00
Penar Musaraj
cc1f9e7be6 Fix share button in post menu 2019-02-20 16:27:59 -05:00
Joffrey JAFFEUX
353eeef72a
fix prettier offense (#7041) 2019-02-20 22:22:38 +01:00
Penar Musaraj
cafe637407
UX: List popular themes and components in admin panel (#6997) 
Reorganizes theme create/upload flows into one install flow
Adds quick list of popular themes/components with one-click installation
 2019-02-20 14:58:31 -05:00
Penar Musaraj
4955ab1689 DEV: add replaceTagRenderer to pluginApi 2019-02-20 14:52:56 -05:00
Joffrey JAFFEUX
18296b4211
FIX: more reliable native sharing (#7039) 2019-02-20 20:43:48 +01:00
Joffrey JAFFEUX
9618300d69
s/share/nativeShare (#7038) 2019-02-20 20:03:30 +01:00
Joffrey JAFFEUX
994a09e5e8
FIX: stricter window.navigator.share check (#7037) 2019-02-20 19:40:51 +01:00
Joffrey JAFFEUX
28c24631b8
FIX: ensures panel's shareUrl is not erased by topic's shareUrl (#7035) 2019-02-20 19:33:54 +01:00
Joffrey JAFFEUX
04a63cfaaa
[WIP] FEATURE: merge share and invite actions together (#7021) 
This commit also:
- removes [+ New Topic] behaviour from share, this feature has been duplicated in composer actions, months ago
- introduces our new experimental spacing standard for css: eg: `s(2)`
- introduces a new panel UI for modals
 2019-02-20 15:42:44 +01:00
Gerhard Schlager
6a8007e5fb FEATURE: Improve handling of backup storage errors 2019-02-20 15:16:49 +01:00
Guo Xiang Tan
31ffa5f64e
UX: Allow users to see filename in image-uploader component. (#7022) 
https://meta.discourse.org/t/downsides-of-the-new-logo-ui-in-site-settings/102247/23?u=tgxworld
 2019-02-20 13:55:55 +08:00
Sam
1f4ace4f56 FEATURE: autocomplete usernames early in topic based on participation 
Following this change when a user hits `@` and is replying to a topic they
will see usernames of people who were last seen and participated in the topic

This is somewhat experimental, we may tweak this, or make it optional.

Also, a regression in a423a938 where hitting TAB would eat a post you were writing:

Eg this would eat a post:

``` text
@hello, testing 123 <tab>
```
 2019-02-20 13:34:43 +11:00
Sam
918a0ea3a4 FIX: use autocomplete="discourse" to disable Chrome address autofill 
https://stackoverflow.com/a/47822599/17174

Chrome 63 and up start ignoring `autofill="off"`

Per: https://bugs.chromium.org/p/chromium/issues/detail?id=468153#c164

> The tricky part here is that somewhere along the journey of the web autocomplete=off become a default for many form fields, without any real thought being given as to whether or not that was good for users. This doesn't mean there aren't very valid cases where you don't want the browser autofilling data (e.g. on CRM systems), but by and large, we see those as the minority cases. And as a result, we started ignoring autocomplete=off for Chrome Autofill data

So to work around this decision we now explicitly say: autocomplete="discourse"
when we don't want Chrome to randomly fill in addressed (aka. always)
 2019-02-20 10:15:59 +11:00
Jeff Wong
246997dbd9 FIX: an <a> with a target of _blank wants a new window 2019-02-19 14:44:30 -08:00
David Taylor
49e7073438 FIX: Hide advanced theme fields behind a flag, pending UI improvement 2019-02-19 22:25:00 +00:00
David Taylor
d08939ab05 FIX: Should be possible to save an empty theme_field in the editor 
Removing the theme_field JS object when the value was empty caused the server to maintain the previous value, making it impossible to delete the content of a field.
 2019-02-19 21:49:31 +00:00
David Taylor
dbcf05d62c DEV: Code style improvements following review 
Followup to 05ee1d1aba
 2019-02-19 20:02:29 +00:00
Joffrey JAFFEUX
9ade04b709
FIX: removes legacy browsers-refresh button (#7028) 2019-02-19 16:38:21 +01:00
David Taylor
05ee1d1aba
FEATURE: Added settings/translations support to theme editor UI (#7026) 
- These advanced fields are hidden behind an 'advanced' button, so will not affect normal use
- The editor has been refactored into a component, and styling cleaned up so menu items do not overlap on small screens
- Styling has been added to indicate which fields are in use for a theme
- Icons have been added to identify which fields have errors
 2019-02-19 12:56:01 +00:00
Joffrey JAFFEUX
0616837a5d
UX: moves wizard's "Finish" button to the left of back and next (#7027) 
This was done to avoid clicking finish when clicking fast on next.
 2019-02-19 13:32:01 +01:00
Joffrey JAFFEUX
8a4cd15e46
REFACTOR: topic model (#7020) 2019-02-19 10:13:46 +01:00
Joffrey JAFFEUX
15fd875855
REFACTOR: color-scheme-color model (#7019) 2019-02-19 09:31:26 +01:00
Joffrey JAFFEUX
cba0dd33ee
REFACTOR: admin-customize-color (#7018) 2019-02-19 09:31:11 +01:00
Joffrey JAFFEUX
2c6bf184bc
REFACTOR: admin-badge-preview (#7017) 2019-02-19 09:30:52 +01:00
Joffrey JAFFEUX
3bf61fca66
REFACTOR: admin-user-field-item (#7016) 2019-02-19 09:30:38 +01:00
Joffrey JAFFEUX
ee692414ce
REFACTORING: admin-edit-badge-groupings (#7015) 2019-02-19 09:30:24 +01:00
Arpit Jalan
50f833def0 fix the build 
JsPrettier on Sublime was failing because: https://github.com/jonlabelle/SublimeJsPrettier/issues/157#issuecomment-458175837
 2019-02-18 11:52:11 +05:30
Arpit Jalan
dc2776bcdd FIX: do not show "move to new PM" option to moderators 2019-02-18 11:35:00 +05:30
peterlamber
159dd69fcb UX: make adding permissions more visible and intuitive to click. (#6999) 2019-02-15 12:01:10 -05:00
Dan Ungureanu
a423a9383f FIX: Stop autocomplete for invalid usernames. (#7005) 2019-02-15 11:29:26 +11:00
Maja Komel
39522659a6 FIX: validate parent category/subcategories permissions 
See: https://meta.discourse.org/t/subcategories-do-not-inherit-permissions-from-parent-category/17174/23 for more details

This ensures users with access to child category can always at least see parent
 2019-02-14 16:38:52 +11:00
Penar Musaraj
090e9c8432
FIX: make composer full screen shortcut work when inputs have focus (#6907) 
- Uses a Mousetrap plugin for global shortcuts
- Implemented for search `ctrl+alt+f` and composer fullscreen `shift+f11` shortcuts
 2019-02-14 00:19:27 -05:00
Régis Hanol
0476169692 make prettier happy 2019-02-13 22:16:38 +01:00
Régis Hanol
94fe0af900 FIX: upload emojis sequentially to prevent rate limit 2019-02-13 22:07:37 +01:00
Joffrey JAFFEUX
560cc4e73e
FIX: sets categoryId but do not scope when replying as new topic (#7002) 2019-02-13 15:19:58 +01:00
Jeff Wong
1328a127ee FIX: translate bootbox confirmation dialog (#6981) 2019-02-13 14:04:56 +11:00
Jeff Wong
467cfc9e08 FIX: remove extra periods (#6998) 
Periods are belong in the translation files not in our templates, if we have them in the templates sentences can not be localized properly.
 2019-02-13 12:54:34 +11:00
Joffrey JAFFEUX
47fe34d794 FEATURE: makes create-account userfields using dropdowns accessible (#6991) 2019-02-13 12:52:55 +11:00
David Taylor
59640ef373 DEV: Add additional hooks for theme-creator plugin 2019-02-12 14:17:34 +00:00
Régis Hanol
b8b1759de9 UX: show envelope when tag is only used in PM 
UX: use regular envelope instead of solid envelope

REFACTOR: %s/enveloppe/envelope/g
 2019-02-12 11:34:25 +01:00
Jeff Wong
d997b01a24 FIX: Scale down swipe in detection to 20px from edge of the screen 
...and slightly increase velocity required for menu actions
 2019-02-11 21:22:50 -08:00
Jeff Wong
c3cbff55be FIX: only respond to menu open swipes on Andorid 2019-02-11 20:56:25 -08:00
Penar Musaraj
c50db76f5d FIX: do not treat TIFF, BMP, WEBP as images 
Treating TIFF and BMP as images cause us to add them to IMG tags, this is very inconsistent across browsers.

You can still upload these files they will simply not be displayed in IMG tags.
 2019-02-11 16:28:43 +11:00
David Taylor
60fa4fe692 DEV: Make interface route/controller more resilient to missing values 2019-02-08 16:54:15 +00:00
David Taylor
747fea8458 DEV: Remove unused import 2019-02-08 16:05:39 +00:00
David Taylor
95eb4c67f2 FIX: Allow reverting theme/text settings from cookie back to default 2019-02-08 15:39:44 +00:00
Penar Musaraj
62043e6904 UX: Hide branch/private repo options in admin theme import modal 2019-02-08 10:17:29 -05:00
Joffrey JAFFEUX
44d9bc12c9
FEATURE: color-palettes component (#6992) 2019-02-08 14:01:14 +01:00
David Taylor
babd80dfd1 FIX: Allow subexpressions in raw handlebars helpers 
Helpers registered via `registerUnbound` did not receive parameters if they were subexpressions.
For example: `{{helper1 key=(helper2 value)}}`
 2019-02-08 12:58:10 +00:00
Joffrey JAFFEUX
e3324737ee
FIX: position invite footer button before archive (#6990) 2019-02-08 12:21:51 +01:00
Joffrey JAFFEUX
e54612c914
fix tests (#6987) 2019-02-08 11:38:15 +01:00
Kris
f849169619 UX: Modifications to admin/customize layout 2019-02-07 22:27:35 -05:00
Penar Musaraj
2a007bafa2 FEAT: Allow image resize by width or height 
`|150x` resizes to 150px wide + auto-height. `x150` resizes to 150px tall and auto-width.

Resize value can be from 1 to 999 (incl. for percentages).
 2019-02-07 15:04:39 -05:00
Joffrey JAFFEUX
c0ccf21970
FIX: hides topic-footer-mobile-dropdown when no content (#6985) 2019-02-07 18:37:20 +01:00
Joffrey JAFFEUX
6c195640b9
FEATURE: adds an API to register topic footer buttons 2019-02-07 14:43:33 +01:00
Joffrey JAFFEUX
92c52c0724
FEATURE: displays report description when hovering activity metrics (#6983) 2019-02-07 13:33:05 +01:00
Dan Ungureanu
fc4c015bee FEATURE: Shortcut 'g s' goes to first suggested topic 2019-02-07 08:43:07 +11:00
Kris
56a9f777cb UX: Turn off autocomplete on composer title 2019-02-06 14:37:29 -05:00
Régis Hanol
057d1dc077 UX: disable browser's autocomplete in search menu 2019-02-06 17:06:23 +01:00
Kris
a52b2c9625 UX: Moving the create theme buttons, adding buttons to theme index 2019-02-05 21:40:17 -05:00
Dan Ungureanu
31ffcf989c
UX: Use translatedLabel for aria-label in buttons. 2019-02-05 13:11:07 +02:00
Dan Ungureanu
2c222e16fe FEATURE: Returning falsy value from upload handler stops upload. (#6969) 2019-02-05 10:54:11 +01:00
Kris
58d5fc3632 UX: Minor button icon color fixes 2019-02-04 12:46:12 -05:00
Jeff Wong
9de906ddab
FIX: Register pan events for touch only 
* touch events - only register touch, not pointer events
* immediately request redraw frame, do not wait for after render to fire.
 2019-02-04 08:27:40 -08:00
Bianca Nenciu
e0e91fad87 FIX: Fix delete button for Tag Groups. (#6965) 2019-02-04 12:46:39 +01:00
David Taylor
eb617dea4b DEV: Run prettier on report.js.es6 
The prettier version I was running was different to the CI pipeline
 2019-02-01 13:22:31 +00:00
David Taylor
5c9426be48 SECURITY: Escape HTML in dashboard report tables 2019-02-01 13:10:59 +00:00
Penar Musaraj
3500acf2f6 FIX: refresh admin/customize/themes route after import 
Fixes an issue where the imported color schemes of a theme were not available immediately in the UI.
 2019-01-31 14:29:09 -05:00
Kris
94f16ba931 UX: Make button icons use lighter color instead of opacity 2019-01-31 13:59:49 -05:00
Arpit Jalan
4786b7ff81 FEATURE: when only option is "existing topic", autofocus input field 2019-01-31 11:23:04 +05:30
Jeff Wong
4763d6c9d7 FEATURE: add the show user action to the user-card-after-username plugin outlet 2019-01-30 14:56:14 -08:00
Robin Ward
bb8808985a REFACTOR: Remove a couple more self uses 2019-01-30 14:41:49 -05:00
Robin Ward
dca5486b78 REFACTOR: Prefer this over self 2019-01-30 14:29:45 -05:00
Penar Musaraj
c02e81fe01 FIX: regression with composer warnings 
Fixes composer warnings when: a) mentioning groups ("By mentioning @group, you are about to notify x people...") and b) mentioning users in a PM ("You mentioned @user but they won`t be notified...")
 2019-01-30 11:37:16 -05:00
Vinoth Kannan
096974d178 FIX: user_id attribute not found in posters array 2019-01-30 15:28:03 +05:30
Jeff Wong
fc5b2de85d FEATURE: add topic list before status plugin outlet for mobile 2019-01-29 17:15:31 -08:00
Joffrey JAFFEUX
0d0303e7ea
FIX: more resilient lookup in plugin-api (#6961) 
Ember3 is more picky about having a container being destroyed and it's easier to cause exceptions, especially in tests.

This fix has been initially created for an exception occuring in tests when running discourse-code-review and discourse-polls tests at the same time. `getCurrentUser` method body was failing as the container was destroyed.

Original  stacktrace:

```
"Error: Assertion Failed: expected container not to be destroyed
    at new EmberError (ember:2929:31)
    at assert (ember:1793:23)
    at Container.lookup (ember:17736:64)
    at PluginApi.getCurrentUser (discourse/lib/plugin-api:56:31)
    at allowUser (javascripts/discourse/initializers/init-code-review:38:29)
    at eval (javascripts/discourse/initializers/init-code-review:78:11)
    at eval (select-kit/mixins/plugin-api:86:19)
    at Array.forEach (<anonymous>)
    at eval (select-kit/mixins/plugin-api:85:44)
    at Array.forEach (<anonymous>)"
```
 2019-01-29 16:54:04 +01:00
Sam Saffron
32f9fd1e51 FIX: add autocomplete=off to composer textarea 
Somehow a plugin or some new Chrome bug is causing its heuristic to detect
our textarea for the composer as a target for address autocomplete

This is likely a chrome bug but this change is very safe regardless.
 2019-01-29 15:05:29 +02:00
Kris
f7deb52c90 FIX: Class name for external-link on customize page 2019-01-28 17:15:36 -05:00
Vinoth Kannan
62a0f88e97 FIX: More link in topic page search shouldn't navigate to full page result 2019-01-29 02:26:55 +05:30
David Taylor
aca0b32fda
FEATURE: Allow overriding text size from a different device (#6955) 
This brings the feature in line with the theme selection system
 2019-01-28 11:19:50 +00:00
Vinoth Kannan
7e4edcfae8 FIX: Convert lightbox html into proper image markdown 2019-01-27 01:21:56 +05:30
Neil Lalonde
cd3a167c63 FIX: javascript error when opening rename tag modal 2019-01-25 17:34:05 -05:00
Penar Musaraj
84a3da4b18 FIX: match drafts using key when deleting 
Using "sequence" when removing drafts was buggy, it would remove more than one draft from the stream sometimes.
 2019-01-25 13:55:40 -05:00
Joffrey JAFFEUX
0e1862013a
FIX: prevents race condition where the same report is loaded multiple times (#6953) 2019-01-25 19:29:45 +01:00
Joffrey JAFFEUX
7caa28cf45
FIX: ensures ordering set in tags-show queryString works at first load (#6951) 2019-01-25 16:48:20 +01:00
David Taylor
d338e54f59
FEATURE: Allow setting font size per-device using a cookie (#6947) 2019-01-25 15:06:06 +00:00
Vinoth Kannan
65caf04ddc clean up unused code 
Unused PM topic list column 'Users' is removed
 2019-01-25 20:13:54 +05:30
David Taylor
a48731e359
FEATURE: Support additional metadata in theme about.json (#6944) 
New `about.json` fields (all optional):
 - `authors`: An arbitrary string describing the theme authors
 - `theme_version`: An arbitrary string describing the theme version
 - `minimum_discourse_version`: Theme will be auto-disabled for lower versions. Must be a valid version descriptor.
 - `maximum_discourse_version`: Theme will be auto-disabled for lower versions. Must be a valid version descriptor.

A localized description for a theme can be provided in the language files under the `theme_metadata.description` key

The admin UI has been re-arranged to display this new information, and give more prominence to the remote theme options.
 2019-01-25 14:19:01 +00:00
Vinoth Kannan
2d6aa2aea2 FEATURE: Add recipient avatars in PM topic list even if they not yet replied 2019-01-25 19:41:49 +05:30
Robin Ward
a518950e52 FIX: Use context sensitive "create topic" via keyboard if possible 2019-01-24 13:20:33 -05:00
Kris
8e795d82f9 UX: Bump up notification panel width to accommodate larger text 2019-01-24 12:48:48 -05:00
Penar Musaraj
755b47b4bc UX: change topic reminder notification icon 2019-01-24 10:07:24 -05:00
Joffrey JAFFEUX
e5765fe1f5
FIX: ensures correct scroll position of textarea after autocomplete (#6942) 2019-01-24 15:19:19 +01:00
Vinoth Kannan
c88fd49591 DEV: refactor user preferences path method 2019-01-24 18:39:13 +05:30
Vinoth Kannan
b9bf751b88 FIX: link to the user preferences page is incorrect in user admin page 2019-01-24 18:31:00 +05:30
Angus McLeod
b1297a5f5a FIX: replaces inline button message with d-button 2019-01-24 13:19:52 +01:00
Joffrey JAFFEUX
1f8ff85ff9
FIX: displays user-card when clicking on avatar of post small action (#6941) 2019-01-24 10:46:06 +01:00
Daniel
48c9234545 FIX: Lazy Loading: copy only present srcset 
When showing a lazy-loaded image, copy the `srcset` property only when
it is actually set. `copyImg.srcset = copyImg.srcset` is not actually a
noop but creates an empty `srcset`, changing content security rules on
the image.
 2019-01-23 14:04:43 -05:00
Joffrey JAFFEUX
bd31423137
DEV: refactoring admin-logs-screened-ip-addresses (#6932) 2019-01-23 17:40:37 +01:00
Joffrey JAFFEUX
0aa049791e
DEV: refactoring admin-backups-index (#6933) 2019-01-23 17:40:24 +01:00
Joffrey JAFFEUX
60974932c4
DEV: refactoring api-keys (#6931) 2019-01-23 17:40:05 +01:00
David Taylor
afd449089f
FEATURE: Import and export themes in a .tar.gz format (#6916) 2019-01-23 14:40:21 +00:00
Joffrey JAFFEUX
d0129b85f4
FIX: stop propagating keyboard event when replying to topic/post (#6930) 2019-01-23 14:38:20 +01:00
Joe
d720215183 UX: admin badge page improvements 2019-01-23 11:29:51 +01:00
David Taylor
2e59a37687
FEATURE: List unused theme components (#6924) 2019-01-23 09:20:13 +00:00
Penar Musaraj
9886934ef5 DEV: fix some deprecated SVG icon refs 2019-01-22 14:42:00 -05:00
Kris
66f6382090 FIX: Icon missing due to typo 2019-01-22 13:01:21 -05:00
Robin Ward
a834245683 FIX: Keep tags when switching to shared draft 2019-01-22 11:26:52 -05:00
Joffrey JAFFEUX
fc710de3ab
DEV: refactoring admin user index (#6927) 2019-01-22 16:44:55 +01:00
Joffrey JAFFEUX
31a700daf8
DEV: refactoring emoji-uploader (#6926) 2019-01-22 16:44:40 +01:00
Joffrey JAFFEUX
bce9c37f15
DEV: refactoring permalink-form (#6925) 2019-01-22 15:09:21 +01:00
Joffrey JAFFEUX
ea8373351b
DEV: refactoring ip-lookup (#6923) 2019-01-22 15:09:04 +01:00
Joffrey JAFFEUX
80d42b4ea2
icons deprecations fixes (#6920) 2019-01-22 12:02:02 +01:00
Joffrey JAFFEUX
9148f7675b
FIX: better handling of resizing in stacked charts (#6921) 2019-01-22 11:20:50 +01:00
Joffrey JAFFEUX
7161304842
minor cosmetic improvements to charts (#6919) 2019-01-22 10:22:41 +01:00
Joffrey JAFFEUX
b1b27d9f7b
FEATURE: add total on stacked-chart tooltip (#6917) 2019-01-22 09:57:34 +01:00
Kris
fe6d571021 FIX: Alignment for small-actions, gap, removing unneeded clearfix 2019-01-21 17:57:47 -05:00
Kris
4ddc28f194 FIX: Whitespace breaks activity column in Firefox 2019-01-21 16:26:34 -05:00
Penar Musaraj
916219f48e Remove "Users" heading in wizard homepage preview 2019-01-21 11:31:00 -05:00
Joffrey JAFFEUX
3e1e9fce7e
FIX: better legend labels for stacked-charts (#6914) 2019-01-21 17:10:10 +01:00
Joffrey JAFFEUX
a9edcb2e10
fixes few icons deprecations warnings (#6915) 2019-01-21 16:56:05 +01:00
Joffrey JAFFEUX
b95165b838
FEATURE: adds a new chart report to track pageviews (#6913) 2019-01-21 15:17:04 +01:00
Joffrey JAFFEUX
52f2e0d6b9
SECURITY: fix possible XSS with badges (#6912) 2019-01-21 13:08:26 +01:00
Joffrey JAFFEUX
502b1316d0
DEV: s/this._super()/this._super(...arguments) (#6908) 2019-01-19 10:05:51 +01:00
Kris
3b7ac3f6eb UX: We don't have bulk select on mobile, so we should hide the button 2019-01-18 20:26:58 -05:00
Joffrey JAFFEUX
7908a522a0
FIX: postLabel was not working for totals (#6904) 2019-01-18 17:06:43 +01:00
Penar Musaraj
f8f281cdad UI: update "latest" canvas layout in wizard 2019-01-18 09:56:39 -05:00
Joffrey JAFFEUX
b20ad9d684
FIX: since Ember 3 interceptClick was not working on buffered links (#6898) 2019-01-18 11:01:19 +01:00
Bianca Nenciu
cf6223226d DEV: Do the draft conflict check async. (#6895) 2019-01-18 15:51:56 +11:00
Penar Musaraj
2274d6d7ac FIX: refresh "/categories" on logo click (#6891) 
* FIX: refresh discovery categories on logo click

* Fix prettier offence
 2019-01-18 12:08:42 +08:00
Kris
9f52306861 Keep avatar image at native size for normal font-size, remove unneeded clearfix 2019-01-17 21:54:22 -05:00
Kris
d5d994e24a UX: Improving user stream alignment and spacing 2019-01-17 17:29:27 -05:00
Penar Musaraj
3501533a2b DEV: unpin Prettier version, apply to YAML files 
We had Prettier pinned because of https://github.com/prettier/prettier/issues/5529. Since that bug is fixed, unpinning.

Prettier now supports YAML, so this applies Prettier to all .yml except for translations, which should not be edited directly anyway.
 2019-01-17 13:05:39 -05:00
Vinoth Kannan
b9215ddaea FIX: Navigate to full page search when enter key used in topic 2019-01-17 22:34:23 +05:30
Kris
675bf94133 UX: Bump up base font size 1px, add smaller text size option 2019-01-17 10:30:34 -05:00
David Taylor
880311dd4d
FEATURE: Support for localized themes (#6848) 
- Themes can supply translation files in a format like `/locales/{locale}.yml`. These files should be valid YAML, with a single top level key equal to the locale being defined. For now these can only be defined using the `discourse_theme` CLI, importing a `.tar.gz`, or from a GIT repository.

- Fallback is handled on a global level (if the locale is not defined in the theme), as well as on individual keys (if some keys are missing from the selected interface language).

- Administrators can override individual keys on a per-theme basis in the /admin/customize/themes user interface.

- Theme developers should access defined translations using the new theme prefix variables:
  JavaScript: `I18n.t(themePrefix("my_translation_key"))`
  Handlebars: `{{theme-i18n "my_translation_key"}}` or `{{i18n (theme-prefix "my_translation_key")}}`

- To design for backwards compatibility, theme developers can check for the presence of the `themePrefix` variable in JavaScript

- As part of this, the old `{{themeSetting.setting_name}}` syntax is deprecated in favour of `{{theme-setting "setting_name"}}`
 2019-01-17 11:46:11 +00:00
Joffrey JAFFEUX
740d047365
FIX: regression lead to a 404 when trying to filter user posts (#6893) 2019-01-17 11:31:23 +01:00
Jeff Atwood
1d4d4b81e6 remove stray chars 2019-01-16 15:05:43 -08:00
Jeff Atwood
f0999f27a7 UX: soften the "problems" alert on dashboard 2019-01-16 14:58:19 -08:00
Robin Ward
16a7102dad FIX: Ember.warn needs an id 
This way errors can be customized/silenced in the console.
 2019-01-16 14:53:13 -05:00
David Taylor
98f26bcaf5 Revert "FIX: makes click-interceptor working with touchstart (#6890)" 
This reverts commit fd2dd8d67d.
 2019-01-16 17:47:40 +00:00
Joffrey JAFFEUX
fd2dd8d67d
FIX: makes click-interceptor working with touchstart (#6890) 
Probable regression due to the removal of Modernizr.
 2019-01-16 17:56:43 +01:00
Penar Musaraj
18055f5e37 DEV: show remote theme repository URL 2019-01-16 11:09:16 -05:00
Joffrey JAFFEUX
1ac4dc5b73
FIX: makes whisper state more resilient (#6889) 
This commit also moves some logic from model to controller.
 2019-01-16 15:23:06 +01:00
Angus McLeod
54f95bb335 rm period (#6886) 2019-01-16 10:58:43 +01:00
Joffrey JAFFEUX
486df57a23
FIX: tweaking topic footer dropdowns (#6882) 
- no description on mobile for notifications
- better reason text positioning
 2019-01-16 10:27:27 +01:00
Guo Xiang Tan
f8db93df5f FIX: Consolidated like notifications links to wrong user on user page. 2019-01-16 15:55:18 +08:00
Penar Musaraj
71a69c1976 Revert "FIX: refresh topic list on logo click" 
This reverts commit 037776881b.
 2019-01-15 22:54:53 -05:00
Arpit Jalan
1591c42a06 FIX: profile picture not showing up on user admin page 2019-01-16 09:21:11 +05:30
Guo Xiang Tan
40533bc570 REFACTOR: filterBy in UserStream. 
Follow up to ebe65577ed.
 2019-01-16 10:53:44 +08:00
Guo Xiang Tan
ebe65577ed
FEATURE: Consolidate likes notifications. (#6879) 2019-01-16 10:40:16 +08:00
Penar Musaraj
037776881b FIX: refresh topic list on logo click 
Fixes a regression where, when homepage is set to "categories", clicking on logo would no longer reload topic list.
 2019-01-15 17:01:09 -05:00
David Taylor
b69e57e2f3 FIX: Prevent layout changes while images are lazy-loading 
This commit moves the temporary image to be adjacent to the original image in the DOM. Previously the temporary image was appended to the parent element. Normally this makes no difference because the temporary element has position:absolute. However, if the `:last-child` selector is being used on the parent, it can cause layout changes during loading.
 2019-01-15 17:35:55 +00:00
Gerhard Schlager
70cdb42173 FIX: Tooltip for unlisted topics wasn't shown in topic list 
The locale key had to be renamed, because this key is also used as CSS class.
The "invisible" CSS class makes the icon invisible. "unlisted" doesn't have that effect.
 2019-01-15 16:13:06 +01:00
Arpit Jalan
c4422fdc13 UX: sort admins and moderators by last seen date on /about page 
UX: only show active admins and moderators on /about page
 2019-01-15 17:26:11 +05:30
Robin Ward
f75915efa4 FIX: expandAllPinned was not resetting after visiting a category 
This resulted in a bug where if you saw a pinned topic in a category,
then went back to latest, the same topic would show an excerpt even
though it shouldn't on the latest view.

See:
https://meta.discourse.org/t/pinned-post-excerpt-no-longer-appears-after-refreshing-the-page/106222
 2019-01-14 13:02:25 -05:00
David Taylor
1ebd3dbbd0
FEATURE: Allow the base font size to be changed on a per-user basis (#6859) 2019-01-14 13:21:46 +00:00
Arpit Jalan
59e3eecfa6 FEATURE: allow staff to select existing message via ID or URL 2019-01-14 15:29:05 +05:30
Arpit Jalan
a121d40771
FIX: do not show PM topics when moving posts to an existing public topic (#6876) 2019-01-14 15:00:45 +05:30
David Taylor
49593d1a00 FIX: Fix registration dialog popup for 'full screen' social logins 
Regression following the ember3 upgrade. In addition to fixing, this commit consolidates our social registration logic into one place, and adds tests for the behaviour.
 2019-01-12 12:08:13 +00:00
Joffrey JAFFEUX
dcdcaebd0f
FIX: checkEmail was calling itself (#6878) 2019-01-12 11:12:17 +01:00
Kris
8176d26dbd UX: Reducing usage of btn-small, simplifying styles 2019-01-11 19:41:09 -05:00
Kris
e4c593f1e7 removing some dupe styles, adding button class 2019-01-11 15:41:51 -05:00
Joffrey JAFFEUX
1a3655b787
DEV: s/Em/Ember (#6874) 2019-01-11 17:54:23 +01:00
Guo Xiang Tan
0fa92699e2 UX: Don't save automatically when resetting site settings in admin page. 2019-01-11 16:39:21 +08:00
Guo Xiang Tan
2956c52e57 FIX: Show title as home logo if title has been set and logo is blank. 
https://meta.discourse.org/t/default-text-logo-not-working/103936
 2019-01-11 15:46:58 +08:00
Joffrey JAFFEUX
9f39ac8366
FIX: ember3 regression, uses model as bufferedProperty for badges (#6875) 2019-01-11 00:46:03 +01:00
Penar Musaraj
49e3a83062 FIX: minor regression when acting on queued post 2019-01-10 15:32:33 -05:00
Vinoth Kannan
0744e84604 UX: always scope the composer categories dropdown to current category 2019-01-11 01:07:23 +05:30
Vinoth Kannan
a8ff4a8a78 UX: search all categories even if category-chooser is scoped to particular category 2019-01-10 21:19:53 +05:30
Joffrey JAFFEUX
f9648de897
DEV: upgrades from Ember 2.13 to Ember 3.5.1 (#6808) 
Co-Authored-By: Bianca Nenciu <nbianca@users.noreply.github.com>
Co-Authored-By: David Taylor <david@taylorhq.com>
 2019-01-10 11:06:01 +01:00
Angus McLeod
798e98a7cc remove safari check from isAppleDevice (#6869) 2019-01-10 13:02:55 +11:00
Maja Komel
51b13ec86f FIX: show lock glyph to a user without permissions to see quote (#6854) 2019-01-10 09:48:05 +08:00
Robin Ward
312e282b6a FIX: Apply classes when lazily loading images 
If an image had extra classes (for example oneboxes), then while loading
the copy of the image would lose those classes and look differently
until the image had loaded fully.

This fix copies the classes while loading.
 2019-01-09 12:56:25 -05:00
Jeff Wong
439eff4709 revert null checking around interceptClick 2019-01-09 09:44:30 -08:00
Robin Ward
8b3ddcf646 FIX: Add topic status to flagged topics list 
Previously at a glance it was impossible to tell if a topic was closed
before digging deeper.
 2019-01-09 10:59:35 -05:00
Vinoth Kannan
1f12a377fa minor refactoring of card-contents-base mixin 2019-01-09 19:32:30 +05:30
Vinoth Kannan
b7c501bf52 FIX: full page search results are unclickable 
data-ember-action can have empty value in favor of data-ember-action-ID attribute
 2019-01-09 10:59:37 +05:30
Zach Whitehead
2748822576 FEATURE: Remove option for Google Plus sharing (#6864) 
* Remove option for Google Plus sharing

* remove google+ share translations
 2019-01-09 10:17:50 +08:00
Joffrey JAFFEUX
25269a37aa FIX: do not show #uncategorized in category drop if setting is disabled (#6856) 2019-01-09 09:44:24 +08:00
Jeff Wong
09cbd08c64 FIX: ensure ember transitions do not get hijacked by discourse intercept-click 
explicit null checks as a blank string evaluates to false
 2019-01-08 15:38:13 -08:00
Jeff Wong
d75262046d Revert "FIX: ensure ember transitions do not get hijacked by discourse intercept-click" 
This reverts commit a2cb2f2366.
 2019-01-08 15:37:10 -08:00
Jeff Wong
a2cb2f2366 FIX: ensure ember transitions do not get hijacked by discourse intercept-click 
explicit null checks as a blank string evaluates to false
 2019-01-08 15:09:50 -08:00
Joe
3457395f75
UX: moves topic-list excerpts out of category / tag div 2019-01-08 14:55:15 +08:00
Arpit Jalan
4ebf170fe4 DEV: no need for conditional redirect in invites 2019-01-08 11:34:26 +05:30
Guo Xiang Tan
ef72a9a1fe UX: Default search log index to yearly. 2019-01-08 13:40:38 +08:00
Arpit Jalan
e0bc82657b FIX: better accept invite flow when user is invited via a link 2019-01-07 14:22:08 +05:30
Vinoth Kannan
3589f3e023 UX: Display user and group cards over the small PM header 2019-01-05 04:58:56 +05:30
Régis Hanol
5ac1e3d4cd FIX: emojis are hard 🤷 2019-01-04 17:21:16 +01:00
Penar Musaraj
f400830575 DEV: Remove old _firefoxPastingHack 2019-01-04 11:14:35 -05:00
Régis Hanol
95e5f8380d FEATURE: Allow plugins to add custom emoji translations 
FIX: buildTranslationTree was erroring when translations overlapped (ie. ":-)" and ":-))")
FIX: emoji translations wasn't working properly when translations overlapped
 2019-01-04 15:27:46 +01:00
David Taylor
5bf16d7d10 FEATURE: Topic timer for bumping a topic in the future 2019-01-04 13:08:04 +00:00
Sam
d0f38dbb07 FIX: image rendered temporarily in wrong position while loading 
Previously non lightboxed images would render in the wrong spot while loading.

We assumed the image we were rendering while loading was at 0,0 position.
This is not the case on non-lightboxed images cause they have no surrounding
DIV.
 2019-01-04 11:50:44 +11:00
Vinoth Kannan
385829d7be FEATURE: Display error message when category restriction is applied for tags 2019-01-04 00:29:13 +05:30
Penar Musaraj
a953b71797 FEATURE: allow custom HighlightJS languages 
Adds pluginApi function that allows themes and plugins to register languages for HighlightJS.
 2019-01-02 19:07:36 -05:00
Jeff Wong
49fbedc445
FIX: make full height menu and cloak respect custom headers (#6845) 2019-01-02 14:18:14 -08:00
Jeff Wong
e8a75628fd Revert "FIX: make full height menu and cloak respect custom headers" 
This reverts commit a61d9deba1.
 2019-01-02 11:51:03 -08:00
Gerhard Schlager
dc477d1228 FIX: "Toggle topic bump" wasn't visible for TL4 users 2019-01-02 20:16:55 +01:00
Jeff Wong
a61d9deba1 FIX: make full height menu and cloak respect custom headers 2019-01-02 11:05:44 -08:00
Gerhard Schlager
c30996129f FEATURE: Allow TL4 users to reset bump date 2019-01-02 16:57:05 +01:00
Vinoth Kannan
0884cd218d UX: Add group name next to PM recipient avatar 
Also changed group icon color and did minor refactoring
 2019-01-02 15:26:42 +05:30
David Taylor
27ed60bad0 FIX: Quote selection in IE11 2018-12-31 13:54:05 +00:00
Arpit Jalan
70fdc10365
FEATURE: move posts to new/existing PM (#6802) 2018-12-31 17:17:22 +05:30
Saurabh Patel
0fca3205b5 FIX: show error msg on grant badge if message available from backend (#6801) 2018-12-31 10:46:39 +01:00
Arpit Jalan
1381dc603d UX: show generic message when reloading 'activation email resent' page 2018-12-31 13:12:37 +05:30
Vinoth Kannan
021f11b68e FEATURE: Display avatars of PM recepients in small topic header when scrolling down 2018-12-30 20:10:40 +05:30
Joffrey JAFFEUX
f1269fa807
FEATURE: Add Top Uploads report (#6825) 
Co-Authored-By: I am very Pro-Grammer. <khalilovcmded@users.noreply.github.com>
 2018-12-28 20:48:54 +01:00
Joffrey JAFFEUX
7b15b87cf5
FIX: better left/right positioning in select-kit components (#6824) 2018-12-28 19:46:31 +01:00
Joffrey JAFFEUX
0f09cb50e9
FIX: less fancy pages computation for browser compatibility (#6823) 2018-12-28 19:07:29 +01:00
Penar Musaraj
4f6ca66df5 FIX: routeToTag mini-fix for IE11 
skip "a.host" for IE11 since IE11 does not support URL interface
 2018-12-28 11:49:51 -05:00
Joffrey JAFFEUX
942114b34c
FIX: optimize collapse/expand select-kit codepath (#6818) 2018-12-27 23:38:01 +01:00
Joffrey JAFFEUX
695894d458 FIX: delete dataset doesn’t work on safari 2018-12-27 06:49:49 +02:00
Vinoth Kannan
2076f371b3 FIX: Hashtags should work for non-english characters 2018-12-26 22:12:40 +05:30
Joffrey JAFFEUX
0402f0f357
UX: new site setting to define activity metrics displayed on dashboard 2018-12-26 10:29:07 +01:00
Sam Saffron
69aa8f18c2 FEATURE: allow for custom excerpt BBCODE 
This allows fidelity in controlling excerpt (text that shows up when you pin a topic or link to it externally):

```
I am some text

[excerpt]
This is some **custom** markdown that should be the excerpt
[/excerpt]

More text
```

Previous solution relied on DIVs, unfortunately DIVs do not play well,
by design with mixing markdown unless you have a preceding newline eg:

```
<div class='hello'>

this will be treated properly as markdown

</div>
```

This extra newline is not desirable.

I am also considering adding

```
[div class=excerpt]
[/div]
```

This would offer lots of flexibility to themes and plugins that do not want the extra annoying newline.
 2018-12-25 17:02:28 +02:00
Arpit Jalan
1e2b81991f fix the build 2018-12-25 10:27:51 +05:30
Jeff Atwood
a74e49c87c use proper typographical × instead of x 2018-12-24 20:33:17 -08:00
Vinoth Kannan
b3df4bee9c FIX: Hide group membership request button for existing members 2018-12-24 13:49:05 +05:30
Saurabh Patel
f4d8a330c3 Merge pull request #6761 from mrfinch/saurabh/show-popup 
FIX:show popup before bulk invite
 2018-12-21 21:36:17 +01:00
Robin Ward
0e710dc573 Improvements to Lazy Loading 
- Now applied to all images over 150x150px

- Stores the width and height in the WeakMap rather than using
percentages for accuracy

- When oneboxed images are hidden, they are given a subtle border for better
visibility.

- Don't apply when in the composer. Causes flickering.
 2018-12-21 11:31:27 -05:00
Robin Ward
a2ae67509d Don't use getAttribute if we don't need to 2018-12-20 16:41:04 -05:00
Sam Saffron
400eea4d13 UX: show lazy loaded images while they are downloading 
Also shows fuzzy image right away prior to it being downloaded
 2018-12-20 22:04:30 +08:00
Joe
d7466156ae UX: adds missing wizard icons 
With our recent move to SVG icons, the font file does not work in the wizard. I've opted for path2D, which accepts an SVG path

Path2D is not supported by IE11 but the chances of admins running the wizard on IE11 are practically none. 

https://caniuse.com/#feat=path2d
 2018-12-20 14:55:40 +02:00
Rishabh
3d2c72dd33 UX: Switch placeholder to an SSH url if importing a private theme 2018-12-20 17:01:50 +05:30
Vinoth Kannan
dc292d4598 FIX: Use one-way binding to prevent unnecessary updates in site.periods 2018-12-20 03:39:05 +05:30
Joffrey JAFFEUX
e655e1863f
UX: Adding reports dashboard tab, new layout, report descriptions (#6790) 
Co-Authored-By: Kris  <shout@k-ris.com>
 2018-12-19 14:44:43 +01:00
Penar Musaraj
f5c4ab0573 Add category link renderer to plugin API (#6787) 
* Add category link renderer to plugin API

- lets themes/plugins override the category link display

- planning to use this in a "category icons" theme component

* small code review fix

* Code review refactor
 2018-12-19 10:26:09 +01:00
Bianca Nenciu
7050ce4638 FIX: Bypass draft check when switching to shared draft. (#6782) 2018-12-19 10:25:33 +01:00
Maja Komel
0ce5f05b2a FIX: hide emails on admin user list for moderators (#6781) 2018-12-19 10:24:57 +01:00
Neil Lalonde
6774b64aef FEATURE: add /conduct as an alias for /guidelines 2018-12-18 16:40:24 -05:00
Robin Ward
662cfc416b FEATURE: Show a blurry preview when lazy loading images 
This generates a 10x10 PNG thumbnail for each lightboxed image.
If Image Lazy Loading is enabled (IntersectionObserver API) then
we'll load the low res version when offscreen. As the image scrolls
in we'll swap it for the high res version.

We use a WeakMap to track the old image attributes. It's much less
memory than storing them as `data-*` attributes and swapping them
back and forth all the time.
 2018-12-19 01:57:30 +08:00
Gerhard Schlager
32784ad11a FIX: Disable multipart backup uploads to S3 
Multipart upload from within the browser result in corrupt files on S3.
 2018-12-18 16:01:15 +01:00
Gerhard Schlager
081aa6ad2b UX: Use new FA5 icons on Backups tab 2018-12-18 16:01:14 +01:00
Vinoth Kannan
341a6bd78a
REFACTOR: Calculate CTR in SearchLog model and hide unique column (#6791) 2018-12-18 19:13:46 +05:30
Maja Komel
98d09c90ac Current user serializer groups (ef7f84b follow-up) 2018-12-18 09:05:45 +01:00
Vinoth Kannan
ece44a44f8 UX: Change default date range of dashboard trending search report to a month 2018-12-18 03:00:30 +05:30
Bianca Nenciu
f0027961c7 FIX: Properly reset controller of admin-user-index. (#6760) 2018-12-17 15:28:29 +01:00
Joffrey JAFFEUX
22cea9ce90
FIX: adusts select-kit position even if not expanded (#6785) 2018-12-17 12:29:51 +01:00
Joffrey JAFFEUX
6ee3900791
FIX: ensures nothing is triggering rendering loop in after render (#6784) 2018-12-17 12:15:03 +01:00
Gerhard Schlager
1a8ca68ea3 FEATURE: Improve backup stats on admin dashboard 
* Dashboard doesn't timeout anymore when Amazon S3 is used for backups
* Storage stats are now a proper report with the same caching rules
* Changing the backup_location, s3_backup_bucket or creating and deleting backups removes the report from the cache
* It shows the number of backups and the backup location
* It shows the used space for the correct backup location instead of always showing used space on local storage
* It shows the date of the last backup as relative date
 2018-12-17 11:35:11 +01:00
Saurabh Patel
ed1a309fe4 FIX: use new key for delete topic to make it lowercased as all other buttons label around it (#6778) 2018-12-17 10:55:19 +08:00
Joffrey JAFFEUX
d803dfc14a
FIX: makes more resilient select-kit positioning (#6776) 2018-12-15 16:23:23 +01:00
Penar Musaraj
a19f69590a DEV: add "topic-list-before-relative-date" plugin outlet 2018-12-14 10:39:22 -05:00
Joffrey JAFFEUX
03014b0d05
FEATURE: adds security tab to dashboard (#6768) 
This commit also includes the new staff_logins report
 2018-12-14 13:47:59 +01:00
Maja Komel
9f89aadd33 FIX: delete all posts in batches without hijack (#6747) 2018-12-14 11:04:18 +01:00
Guo Xiang Tan
05104600ea FIX: Incorrect translation key on admin search logs. 2018-12-14 17:12:33 +08:00
Joffrey JAFFEUX
afdd244486
UX: removes superfluous posters column header (#6765) 2018-12-13 21:29:00 +01:00
Joffrey JAFFEUX
bcf4a17751
FIX: apply original margin-bottom to fix position placeholder (#6764) 2018-12-13 18:21:12 +01:00
Joffrey JAFFEUX
5cb99d08ed
FIX: define actions on connector class early (#6763) 
This would prevent failure with connectors templates defining actions as closures. In this case action existence is checked at compile time and not runtime.
 2018-12-13 15:43:30 +01:00
Kyle Zhao
92df7b212c rename visible to visibleSiteSettings 2018-12-13 13:00:13 +11:00
Kyle Zhao
c9279a118e FIX: always show filtered site settings 2018-12-13 13:00:13 +11:00
Joffrey JAFFEUX
793f1274d1
FIX: makes charts more resilient to resizing (#6758) 2018-12-12 11:11:56 +01:00
Joffrey JAFFEUX
3a799ed922
FEATURE: Check if draft exists before starting a new one (#6755) 
Co-Authored-By: Bianca Nenciu <nbianca@users.noreply.github.com>
Co-Authored-By: zogstrip <regis@hanol.fr>
 2018-12-12 10:21:51 +01:00
Sam
0ca61242b8 FEATURE: polyfill intersection observer for IE11 / iOS Safari 
This feature is used for defer loading of images and in future for post cloaking

This gives us a polyfill so we can safely use the feature in problem browsers

The polyfill supports "polling" but it does not appear we need it yet.

If we discover anything odd here, consider setting poll interval per:

https://github.com/w3c/IntersectionObserver/tree/master/polyfill

```
var io = new IntersectionObserver(callback);
io.POLL_INTERVAL = 100; // Time in milliseconds.
```

Keeping the mutation observer cause we often mutate the DOM
 2018-12-12 15:36:08 +11:00
Robin Ward
6797a710aa FEATURE: Lazily Load Images as they scroll into the viewport. 
This feature uses the Intersection Observer API

https://developer.mozilla.org/en-US/docs/Web/API/Intersection_Observer_API

It should be compatible with all modern browsers. Non-Edge IE is *NOT*
supported, so in that particular browser images are loaded by default.
 2018-12-12 10:12:49 +11:00
Jeff Wong
5358f25fc6 FIX: Support RTL languages in header menu 2018-12-11 10:33:56 -08:00
Jeff Wong
d2569f8e77 make linter happy 2018-12-11 09:41:40 -08:00
Jeff Wong
71d8807fec
Full height swipe-able menus (#6566) 
* Feature: Full height swipe enabled menus

support pan events on iphone
 2018-12-11 09:15:20 -08:00
David Taylor
c7c56af397
FEATURE: Allow connecting associated accounts when two-factor is enabled (#6754) 
Previously the 'reconnect' process was a bit magic - IF you were already logged into discourse, and followed the auth flow, your account would be reconnected and you would be 'logged in again'.

Now, we explicitly check for a reconnect=true parameter when the flow is started, store it in the session, and then only follow the reconnect logic if that variable is present. Setting this parameter also skips the 'logged in again' step, which means reconnect now works with 2fa enabled.
 2018-12-11 13:19:00 +00:00
Sam Saffron
bb4ef644bf UX: reduce show dismiss.. at top of unread/new to 15 
Previously we would require 30 unread or new topic to show the button at the top.
 2018-12-11 14:11:54 +11:00
Kris
73d2fc194d UX: More consistent category lock and topic-status styles 2018-12-10 16:06:26 -05:00
David Taylor
071bd15463 FIX: Redirect to default homepage when visiting /login 
Previously this was hard-coded to redirect to `/latest`
 2018-12-10 15:39:05 +00:00
Joffrey JAFFEUX
e06a8980fb
FIX: category-drop initial state was incorrect (#6743) 2018-12-10 14:05:00 +01:00
Gerhard Schlager
0f41770547 Make Danger happy by running prettier 2018-12-08 02:59:09 +01:00
Penar Musaraj
67450ba402 UX: when composer is minimized, let user open composer in regular size instead of full screen 2018-12-07 17:45:13 -05:00
Xiao Guan
7ec124fc89 FEATURE: Improved deprecation warnings (#6722) 
* FEATURE: Discourse.deprecate can report version

* Ember counterpart for deprecation
 2018-12-06 11:38:01 +00:00
Maja Komel
1d649e147b FEATURE: show avatar flair on group, badges and directory pages (#6732) 2018-12-06 12:18:52 +01:00
Kris
a88f931d6f UX: Moving categories under topic title in topic list, removing category column (#6731) 
* Starting to remove category column from topic list

* stacked nav alignment adjustment

* Revert "stacked nav alignment adjustment"

This reverts commit 98800c7058.

* remove comment

* removing function
 2018-12-05 16:12:26 -08:00
Bianca Nenciu
a8e8473ea5 DEV: Apply code review. 2018-12-05 21:58:55 +01:00
Bianca Nenciu
79d987e483 FEATURE: Show autocomplete when enable_inline_emoji_translation is true. 2018-12-05 21:58:55 +01:00
Bianca Nenciu
e9bbdef156 FEATURE: Add support for inline emoji translation. 2018-12-05 21:58:55 +01:00
Bianca Nenciu
0c88052641 UX: Wrap pre element. 2018-12-05 21:56:18 +01:00
Bianca Nenciu
b585f7f336 DEV: Apply code review. 2018-12-05 21:56:18 +01:00
Bianca Nenciu
56890efd7a FEATURE: Add 'Advanced Test' for admin panel. 2018-12-05 21:56:18 +01:00
David Taylor
8aff99761a FIX: Ignore query parameters when displaying counter on internal links 
This matches the server-side behaviour, so that the links display counters correctly
 2018-12-05 18:29:54 +00:00
Guo Xiang Tan
978f0db109 SECURITY: Require groups to be given when inviting to a restricted category. (#6715) 2018-12-05 16:43:07 +01:00
Kyle Zhao
97e6e3b133 DEV: duplicate and unreachable code after return 2018-12-05 09:17:20 -05:00
Vinoth Kannan
d33d031742
FEATURE: Filter topic and post web hook events by tags (#6726) 
* FEATURE: Filter topic and post web hook events by tags

* Add a spec test with unmatched tags
 2018-12-05 14:44:06 +05:30
Vinoth Kannan
ec26a59eac FIX: variable name typo in subcategory image 2018-12-05 10:41:06 +05:30
Sam
5c17e46274 FEATURE: allow advanced specification of excerpts for posts 
Previously users could control excerpt with `<span class='excerpt'>`
in Markdown, this is somewhat limited for plugins that need to define this
across a section. This adds support for DIV as well
 2018-12-04 15:13:34 +11:00
Penar Musaraj
56948896ff UX: replace FA5 compress/expand icons 
Adds a new SVG sprite file that contains non-FontAwesome 5 icons to our subset.

Adds the FontAwesome 4.7.0 icons for expand / collapse.
 2018-12-03 22:29:20 -05:00
Penar Musaraj
923692d45a FIX: tooltip regression in admin dashboard 
- adds registerHoverTooltip in tooltip qunit test
 2018-12-03 11:15:31 -05:00
Maja Komel
142361d6da FIX: don't steal focus when text in editor is replaced (#6712) 2018-12-03 09:49:17 +01:00
Penar Musaraj
7dec963f2e FIX: add vkontakte icon alias 2018-11-30 08:50:38 -05:00
Arpit Jalan
40f10855c6
FIX: defer flags (only) when handling a flag and deleting replies (#6702) 2018-11-29 22:44:18 +05:30
Maja Komel
4a8f21d387 FIX: prevent minimum_required_tags on category being set to null (#6703) 
* FIX: prevent minimum_required_tags on category being set to null

* add migration for NOT_NULL constraint for minimum_required_tags

* add specs
 2018-11-29 18:10:14 +01:00
Joffrey JAFFEUX
4f24d7dec8
FIX: more resilient whisper state between composer states (#6687) 2018-11-29 16:16:34 +01:00
Joffrey JAFFEUX
8da8f5d0f7
FIX: call onSelect plugin callbacks for noop rows (#6682) 2018-11-29 15:56:19 +01:00
Joffrey JAFFEUX
4c7dfed32e
FIX: error with tags enabled and no tags created (#6701) 2018-11-29 10:39:09 +01:00
Vinoth Kannan
5db50d6cdc UX: Use aspect ratio to calculate width and height precisely 
Followup on 1da265d
 2018-11-29 09:32:03 +05:30
Penar Musaraj
c388cacb81 UX: Style group flair in /groups same as in topic avatars 2018-11-28 16:02:49 -05:00
Penar Musaraj
6568832235 FIX: map discord/patreon FA5 icons for login buttons correctly 2018-11-28 14:36:36 -05:00
Saurabh Patel
49c3cf9c75 UX: Topic stats were hard to translate 2018-11-28 14:25:22 +01:00
Sam
912a7105d2 DEV: polyfill Object.values and use where needed 
We now have polyfills for `values` IE and `entries` IE

This commit uses values where appropriate to eliminate an extra lookup
This simplifies the code a bit.

Followup to: 7f089f07a7
 2018-11-28 10:07:05 +11:00
Sam
3cb88bc566 DEV: Run file through prettier 
We only alert on .js.es6 this is a js file so it is bypassed
 2018-11-28 10:03:54 +11:00
Joffrey JAFFEUX
7f089f07a7
FIX: better fix for #ca84c06 (#6684) 2018-11-27 16:12:07 +01:00
David Taylor
f993aca363 FIX: Fix editing built-in badges after removing _.include 
We want to send the unprotected fields to the server. Corrects 4c8cfe0f
 2018-11-27 15:01:02 +00:00
Joffrey JAFFEUX
ca84c06c59
FIX: revert to using _.each (#6683) 
Should be replaced with Object.keys variation when reproducible
 2018-11-27 15:55:56 +01:00
Maja Komel
a2bff038e8 FIX: set overridden param for customize site text query only when checkbox value changes 2018-11-27 14:29:48 +01:00
Guo Xiang Tan
c92c56d986 FIX: Randomly failing QUnit test. 
The `post` variable can be an actual post object or a `new Placeholder("post-placeholder")` which does not define the function `get`.

* QUNIT_SEED=11414431645131211212599424733847938795
 2018-11-27 16:00:46 +08:00
Guo Xiang Tan
a1e77aa2ed
FEATURE: Reimplement SiteSetting.max_oneboxes_per_post. (#6668) 
Previously, the site setting was only effective on the client side of
things. Once the site setting was been reached, all oneboxes are not
rendered. This commit changes it such that the site setting is respected
both on the client and server side. The first N oneboxes are rendered and
once the limit has been reached, subsequent oneboxes will not be
rendered.
 2018-11-27 16:00:31 +08:00
Dan Ungureanu
38e29d8c94 DEV: Fix coding style. 2018-11-27 13:05:27 +11:00
Dan Ungureanu
d657ce844b DEV: Call onClose for closing modals. 2018-11-27 13:05:27 +11:00
Dan Ungureanu
0005bded6c DEV: Added composer-action-after plugin outlet. 2018-11-27 13:05:27 +11:00
Dan Ungureanu
1f9f00a629 DEV: Add data-topic-id to more elements containing titles. 2018-11-27 13:05:27 +11:00
Dan Ungureanu
8837fe47d7 DEV: Add app event triggered when composer's reply is reloaded. 2018-11-27 13:05:27 +11:00
Dan Ungureanu
b65e5d263e DEV: Add a plugin outlet for top-side notices. 2018-11-27 13:05:27 +11:00
Vinoth Kannan
1da265db11 UX: category images have no sizes (#6662) 2018-11-27 08:40:06 +08:00
Penar Musaraj
03deda2147
Upgrade to FontAwesome 5 (take two) (#6673) 
* Add missing icons to set

* Revert FA5 revert

 This reverts commit 42572ff

* use new SVG syntax in locales

* Noscript page changes (remove login button, center "powered by" footer text)

* Cast wider net for SVG icons in settings

- include any _icon setting for SVG registry (offers better support for plugin settings)

- let themes store multiple pipe-delimited icons in a setting

- also replaces broken onebox image icon with SVG reference in cooked post processor

* interpolate icons in locales

* Fix composer whisper icon alignment

* Add support for stacked icons

* SECURITY: enforce hostname to match discourse hostname

This ensures that the hostname rails uses for various helpers always matches
the Discourse hostname

* load SVG sprite with pre-initializers

* FIX: enable caching on SVG sprites

* PERF: use JSONP for SVG sprites so they are served from CDN

This avoids needing to deal with CORS for loading of the SVG

Note, added the svg- prefix to the filename so we can quickly tell in
dev tools what the file is

* Add missing SVG sprite JSONP script to CSP

* Upgrade to FA 5.5.0

* Add support for all FA4.7 icons

- adds complete frontend and backend for renamed FA4.7 icons

- improves performance of SvgSprite.bundle and SvgSprite.all_icons

* Fix group avatar flair preview

- adds an endpoint at /svg-sprites/search/:keyword

- adds frontend ajax call that pulls icon in avatar flair preview even when it is not in subset

* Remove FA 4.7 font files
 2018-11-26 16:49:57 -05:00
Robin Ward
8bca2647ea FIX: Upwards scrolling occasionally broken 
This fixes a bug in Chrome where upwards scrolling would occasionally
not work properly.
 2018-11-26 13:37:12 -05:00
Penar Musaraj
2e4706b787 FIX: bug and typo in admin user badges 2018-11-26 10:24:46 -05:00
Joffrey JAFFEUX
3453707784
FEATURE: allows html tooltips (#6665) 2018-11-26 11:15:23 +01:00
Joffrey JAFFEUX
e47b478b83
DEV: removes _.toArray from codebase (#6654) 2018-11-26 11:15:05 +01:00
Guo Xiang Tan
d4aaa968bb Fix linting. 2018-11-26 09:38:22 +08:00
Guo Xiang Tan
57e2f4990d
PERF: Move processing of inline onebox out of V8 context. (#6658) 2018-11-26 09:21:38 +08:00
Bianca Nenciu
172b3bf4d3 FIX: Fix broken theme field URLs. (#6622) 2018-11-23 16:11:05 +01:00
Joe
336436dfb4
UX: better handling of logo size 2018-11-23 22:04:42 +08:00
Joe
98354bd34c
fix the build 2018-11-23 11:27:59 +08:00
Joe
c4fca36255
FIX: don't trigger header:hide-topic at the bottom on desktops 
On mobile we trigger `header:hide-topic` at the very bottom of topics to switch the header contents back from small logo + topic info to large logo + user panels. 

Given that the `topic-progress` component is sometimes loaded on desktop - E.g composer is open or on narrow desktop screens - we need a guard to prevent this logic from firing on desktops.
 2018-11-23 10:14:13 +08:00
Joffrey JAFFEUX
f4432648fd
FIX: categories/delete_categories can be undefined (#6657) 2018-11-23 00:57:18 +01:00
David Taylor
f645cb9c14
FEATURE: Use translated name for 'your email has been authenticated by' (#6649) 2018-11-22 19:12:04 +00:00
Joffrey JAFFEUX
7e20a0b917
DEV: removes _.indexOf from codebase (#6652) 2018-11-22 17:38:58 +01:00
David Taylor
0083eec686 FEATURE: Allow logo URLs to be overridden easily using reopenWidget() 2018-11-22 16:29:12 +00:00
Joffrey JAFFEUX
56478166e5
FIX: broken badge groupings modal UI (#6653) 2018-11-22 17:09:45 +01:00
Joffrey JAFFEUX
2843944315
FIX: better alignment of badge selector and edit btn (#6651) 
Input located at /admin/badges/new
 2018-11-22 16:21:15 +01:00
Kyle Zhao
80398d0b8f
Extract inline JS on embedded comments (#6645) 
* use the meta refresh tag instead

* extract inline JS in embedded comment
 2018-11-22 10:02:58 -05:00
Vinoth Kannan
036790d13c FIX: Assign default value for category.findByIds method 2018-11-22 12:51:04 +05:30
Guo Xiang Tan
c5a70eca6e
PERF: Move mention lookups out of the V8 context. (#6640) 
We were looking up each mention one by one without any form of caching and that results
in a problem somewhat similar to an N+1. When we have to do alot of DB
lookups, it also increased the time spent in the V8 context which may
eventually lead to a timeout. The change here makes it such that mention lookups only does a single
DB query per post that happens outside of the V8 context.
 2018-11-22 14:28:48 +08:00
Joe
ee6c0170ce FEATURE: Scroll-based logo on mobile (#6632) 2018-11-21 21:21:49 -05:00
Kris
0381e99b71 UX: improving theme upload modal alignment, markup 2018-11-21 16:50:49 -05:00
Joffrey JAFFEUX
58c795ef30 DEV: adds test for image-short-url (#6642) 2018-11-22 07:48:52 +11:00
Sam
0a86ef69bb FIX: browser infinite recursion when editing post 
This was a result of:

c4ed353fae

jQuery map on a jQuery object, returns a jQuery object http://api.jquery.com/map/

So you need to convert it to an array prior to mapping
 2018-11-21 12:51:14 +11:00
Kris
17bc21abff trashing an empty wrapper 2018-11-20 15:42:18 -05:00
Kris
17f3080d01 UX: More consistent category setting layout 2018-11-20 15:16:17 -05:00
Joffrey JAFFEUX
9672c92045
DEV: removes _.each from codebase (#6629) 2018-11-20 14:46:58 +01:00
Joffrey JAFFEUX
86dafc1f25
DEV: removes _.reduce from codebase (#6628) 2018-11-19 13:04:57 +01:00
Joffrey JAFFEUX
0a8227d19c
DEV: removes _.some from codebase (#6627) 2018-11-19 12:32:51 +01:00
Joffrey JAFFEUX
4c8cfe0f29
DEV: removes _.include from codebase (#6620) 2018-11-19 12:08:54 +01:00
Joffrey JAFFEUX
b1727537b2
DEV: removes _.find from codebase 2018-11-19 11:46:26 +01:00
Joffrey JAFFEUX
30e0d744db DEV: removes _.delay from codebase (#6619) 2018-11-19 10:47:00 +01:00
Joffrey JAFFEUX
c4ed353fae DEV: removes _.map from codebase (#6616) 2018-11-19 10:46:46 +01:00
Joffrey JAFFEUX
907cf3ee2f DEV: replaces setTimeout by Ember.run.later (#6618) 2018-11-19 10:46:38 +01:00
Bianca Nenciu
f2c227432c FIX: Do not show nested user cards. (#6621) 2018-11-19 10:01:22 +01:00
Joe
94c724fb89
UX: fixes display issues in split to existing topic modal 2018-11-19 13:12:42 +08:00
Sam
6aea185ab4 FEATURE: plugin outlets on about page 
Added about-after-admins and about-after-moderators
 2018-11-19 10:12:44 +11:00
Robin Ward
e37c4a4525 FIX: Don't show the Quote popup if posting is disabled 2018-11-16 11:00:22 -05:00
Joffrey JAFFEUX
dcc6527dff
FIX: s/save/finish for wizard exit early button (#6614) 2018-11-15 21:26:26 +01:00
Joffrey JAFFEUX
1730e0bc73
UX: shows a save changes for intermediate steps (#6612) 2018-11-15 20:44:19 +01:00
Vinoth Kannan
d5df746cc3 UX: Improve category reordering functionality 2018-11-16 00:52:10 +05:30
Kyle Zhao
5f754b43f1
extract inline onpopstate handler on 404 page (#6613) 2018-11-15 13:35:38 -05:00
Kris
f0760908e3 Missing space between class names 2018-11-15 12:17:37 -05:00
Joffrey JAFFEUX
9911a41f4c
FIX: improves category/tag drops header shortcuts (#6610) 
- wont appear when filtering
- can now be selected with keyboard
- fix bugs on click with safari/firefox
 2018-11-15 15:21:40 +01:00
Vinoth Kannan
fdccfcfa59 FIX: Only use blockquote which is immediate child of aside 2018-11-15 18:07:16 +05:30
Régis Hanol
1c678c8c54 This should not have been removed 2018-11-14 23:23:02 +01:00
Régis Hanol
0f5aeab003 DEV: enable no-alert & no-console eslint rules 2018-11-14 23:17:56 +01:00
Régis Hanol
4bac77800a DEV: remove 'console.log' (cc @eviltrout) 2018-11-14 21:45:41 +01:00
Régis Hanol
20899654aa Make code prettier 💅 2018-11-14 17:57:22 +01:00
Régis Hanol
c78dcde973 FIX: only send originalText when we need to 2018-11-14 17:47:59 +01:00
Kris
1e15c16f77 UX: Condense layout when suggested and related messages are available 2018-11-14 11:01:50 -05:00
Bianca Nenciu
34e4d82f1a FEATURE: Report edit conflicts when saving draft. (#6585) 2018-11-14 12:56:25 +01:00
Vinoth Kannan
d078808144 UX: Use header top to calculate docking position 2018-11-14 16:31:39 +05:30
Guo Xiang Tan
44391ee8ab
FEATURE: Upload Site Settings. (#6573) 2018-11-14 15:03:02 +08:00
Robin Ward
fc9aafaa6a New outlet above the main container 2018-11-13 14:34:20 -05:00
Robin Ward
467be59d75 FEATURE: Allow expanded posts to return user custom fields 2018-11-13 12:44:54 -05:00
Joffrey JAFFEUX
7fa21ce199
UX: minor tweaks to theme components selection UI (#6596) 2018-11-13 14:57:50 +01:00
Joffrey JAFFEUX
c1e82e7442
FIX: category row title (#6597) 2018-11-13 13:35:45 +01:00
Joe
ac7b058849
UX: take custom markup into account when docking header 2018-11-13 14:47:12 +08:00
Kris
27ce8cf851 UX: Improving group directory layout for small screens 2018-11-12 18:13:42 -05:00
Kyle Zhao
d25ae13f0f FIX: stricter window.opener checks (#6578) 2018-11-13 09:56:31 +11:00
Robin Ward
0cb33d2b52 UX: Rename Most Disagreed Flaggers report to "User Flagging Ratio" 2018-11-12 16:23:37 -05:00
Vinoth Kannan
44d95ad5ab FIX: Cache url data for failed inline oneboxes 2018-11-13 01:44:20 +05:30
David Taylor
ba00fcc371 FIX: Translation improvements for unused tags (d89ffbe) 2018-11-12 16:36:56 +00:00
David Taylor
d89ffbeffd
FEATURE: Add button to delete unused tags (#6587) 
This is particularly useful if you have uploaded a CSV file, and wish
to bulk-delete all of the tags that you uploaded.
 2018-11-12 16:24:34 +00:00
Joffrey JAFFEUX
599ab4e966
UX: inform users old dashboard is going to b removed (#6592) 2018-11-12 15:20:00 +01:00
Joffrey JAFFEUX
9c616e0679
FIX: handles not found reports in bulk loading (#6582) 2018-11-12 13:47:24 +01:00
Gerhard Schlager
7c4d4331bc FEATURE: Better handling of quotation marks in site text search 
It also matches 3 dots with the ellipsis symbol.
 2018-11-12 13:26:41 +01:00
Guo Xiang Tan
c7377e2f2d UX: Trash icon displaying when there is no upload take 2. 2018-11-12 16:19:17 +08:00
Guo Xiang Tan
d50f4fdd7a Oops. 2018-11-12 16:07:33 +08:00
Guo Xiang Tan
10c6211cdf UX: Trash icon displaying when there is no upload. 2018-11-12 16:06:32 +08:00
Sam
e17a13ce19 FEATURE: additional "related messages" section 
This splits out previous message correspondence from suggeted and instead
has a dedicated section called "related messages"
 2018-11-12 13:04:42 +11:00
Joffrey JAFFEUX
f8838ac9cd
FIX: fix/removes broken elements of old dashboard 2018-11-09 17:18:19 +01:00
Gerhard Schlager
24e5be3f0c FIX: Relative links in translations should work with subfolder 2018-11-08 23:31:05 +00:00
Sam
42572ff138 Revert font awesome 5 changes 
We are still pushing ahead on this 100% just need a bit longer to prepare
all plugins
 2018-11-08 16:12:18 +11:00
Penar Musaraj
09dc922b3b Fix several FontAwesome 5 issues 
add missing icons, update SvgSprite methods (to fix ruby 2.4 issues), update whisper icon in composer, fix alignment issues
 2018-11-07 22:20:53 -05:00
Penar Musaraj
9a34c6153e Fix small issues with FA5 icons 2018-11-07 16:39:04 -05:00
Penar Musaraj
005e1ecb9b
FEATURE: Update Font Awesome to v5.4.1 and SVGs (#6557) 
* First take on subsetting svg icons

* FontAwesome 5 svg subset WIP

* Include icons from plugins/badges into svg sprite subset

* add svg icon support to themes

* Add spec for SvgSprite

* Misc. SVG icon fixes

* Use FA5 svgs in local-dates plugin

* CSS adjustments, fix SVG icons in group flair

* Use SVG icons in poll plugin

* Add SVG icons to /wizard
 2018-11-07 13:05:43 -05:00
Gerhard Schlager
6b60646330 FIX: Relative links in templates should work with subfolders 2018-11-07 11:35:04 +01:00
Matthew Campbell
a2044c4528 UX: Make the edits indicator a real link for accessibility (#6570) 
This link didn't have an `href` attribute, so it wasn't in the tab
order. This commit fixes that, while adding a call to `preventDefault`
in the event handler to avoid any regression in event handling.
 2018-11-07 10:11:52 +11:00
Joffrey JAFFEUX
75b1865d15
UX: adds new categories layouts to the wizard (#6569) 2018-11-06 15:52:13 +01:00
Joffrey JAFFEUX
fdad24e2e4
FIX: edit category tags select-kit inputs width were wrong (#6568) 2018-11-06 11:30:12 +01:00
Jeff Atwood
afbdf9c2d2
Merge pull request #6558 from pmusaraj/disallow-flagging-deleted-post 
FIX: disable flagging hidden posts
 2018-11-05 11:05:32 -08:00
Maja Komel
ae9eddb002 FIX: don't allow adding a value containing vertical bar char to the secret list 2018-11-05 12:14:56 +01:00
Joffrey JAFFEUX
cc9869a61b
FIX: topic-map spec with VDOM and i18n plural (#6564) 
It appears that in vdom nodes, pluralized i18n strings are not compiled into a string before widget is compiled and result in an error as VDOM is expecting a string and not an object.
 2018-11-05 12:02:18 +01:00
Joffrey JAFFEUX
4d74688b50
UX: uses presentation role for accessibility in topic map (#6561) 
Co-Authored-By: mwcampbell <mwc+github@mwcampbell.us>
 2018-11-05 09:45:32 +01:00
Penar Musaraj
94f628fb4c FIX: disable flagging hidden posts 2018-11-02 13:54:45 -04:00
Joffrey JAFFEUX
4417faa7e5 Revert "FIX: uses more semantically correct spans in post map (#6555)" 
This reverts commit 5cd055fd30.
 2018-11-02 15:07:22 +01:00
Joffrey JAFFEUX
5cd055fd30
FIX: uses more semantically correct spans in post map (#6555) 2018-11-02 13:09:58 +01:00
Robin Ward
c4ca5ed50b FIX: Translation error 2018-11-01 17:44:55 -04:00
Robin Ward
ec91450aae FEATURE: Track how many user flags are agreed/disagreed/ignored 
Display the percentage when reviewing flags.
 2018-11-01 09:59:50 -04:00
Sam
ceafcbc898 FEATURE: show added date when looking at group members 2018-11-01 15:33:28 +11:00
Vinoth Kannan
28cf4d535e UX: Include subcategories in search result of all categories drop down 2018-10-31 23:03:24 +05:30
David Taylor
ff6676094f FIX: Correct bookmark button class 2018-10-31 11:22:24 +00:00
Régis Hanol
0bf52d422c FEATURE: new 'simultaneous_uploads' site setting 2018-10-31 10:58:09 +01:00
Kris
f97cf10676 Removing edit button from mobile category list 2018-10-30 22:57:06 -04:00
Bianca Nenciu
e1e392f15b DEV: Use DiscourseIpInfo for all IP queries. (#6482) 
* DEV: Use DiscourseIpInfo for all IP queries.

* UX: Use latitude and longitude for more precision.
 2018-10-30 22:08:57 +00:00
Joffrey JAFFEUX
11ee07093c FEATURE: revamps search-menu layout (#6543) 2018-10-30 10:44:49 -04:00
Gerhard Schlager
5b14f713a0 Use class instead of inline style 2018-10-30 11:25:51 +01:00
Joffrey JAFFEUX
af465effef
FIX: prevents y-axis labels to show useless/wrong values 2018-10-30 09:58:03 +01:00
Sam
f8305f53c7 FEATURE: special offline support restricted to Android only 
The special offline page with fetch interception in service worker
is only strongly required on Android ad a pre-req for PWAs

This is now strongly restricted only to Android while iOS PWA support
gets better

Long term if we build offline support we can unlock it more globally
 2018-10-29 16:29:19 +11:00
Jeff Atwood
817cf8b229 remove extraneous two factor auth info popup 2018-10-27 14:10:26 -07:00
Jeff Atwood
58b53f7841 update copy for "was this you?" login dialog 2018-10-27 13:57:30 -07:00
David Taylor
375bba3c31 FIX: Add String.includes polyfill for IE11 2018-10-26 23:10:03 +01:00
Kris
fb15e04e48 Fixing broken badge grant layout 2018-10-26 11:06:31 -04:00
Kris
7c2618e914
Adding classes to login for external auth and user fields (#6535) 2018-10-26 10:33:06 -04:00
Joffrey JAFFEUX
b2585524a9
FEATURE: adds a most disagreed flaggers report 2018-10-26 15:59:04 +02:00
David Taylor
e955a1f24b DEV: Skip ESLint on polyfill 2018-10-26 13:54:03 +01:00
David Taylor
af84949f25 FIX: Add polyfill so that Array.includes works in IE11 2018-10-26 13:45:29 +01:00
Joffrey JAFFEUX
398f98c568
FIX: ensures reports links are correct on subfolder installs 2018-10-26 12:32:02 +02:00
Penar Musaraj
3c92202654 Set individual future-date-input components as clearable, fixes admin Safari bug (#6522) 2018-10-26 11:34:55 +11:00
Kyle Zhao
a6eca28ec6
CSP - extract all other inline JavaScripts (#6528) 
* wizard page inline js

* print topic inline js

* drop JS for preventing double submission

this is the default behavior with Rails' UJS `disable_with` helper

* omniauth complete redirect JS

* account activate inline js
 2018-10-25 09:52:01 -04:00
Bianca Nenciu
2a77550f8c FIX: Do not track right clicks. (#6530) 2018-10-25 09:46:04 +00:00
Jeff Atwood
c62a8ee335 switch topic jump glyphs to better signify move to top/bottom 2018-10-24 18:41:41 -07:00
Kris
c219a5fb1e
Add btn-default class to all default buttons (#6521) 2018-10-24 16:09:36 -04:00
Kris
0140844eb0 Remove whitespace in template so we can use :empty psuedo 2018-10-24 16:00:22 -04:00
Matthew Campbell
05438d99a8 FIX: Ensure the like button always has a title, for accessibility (#6525) 
The like button previously didn't have a title for anonymous users,
because the `canToggleLike` flag wasn't set, but the `liked` flag wasn't
set either. This made the button inaccessible to blind users.
 2018-10-24 13:58:42 +00:00
Kris
541b6a8446 UX: Allow vertical timeline to fit on narrower screens 2018-10-22 22:16:59 -04:00
Joffrey JAFFEUX
7d2e582b28 FIX: validates import theme form (#6513) 2018-10-23 12:09:06 +11:00
Kyle Zhao
2cc195f3d9 prettier linting fix 2018-10-22 14:18:26 -04:00
Bianca Nenciu
37fa7775f1 FIX: Fix order of recently connected devices. (#6517) 2018-10-22 17:30:23 +00:00
Jeff Wong
ec2613699f Change box category view to use flexbox 2018-10-22 10:15:31 -07:00
Régis Hanol
b9261588f9 make the code prettier 2018-10-22 19:07:41 +02:00
Régis Hanol
3e232412e3 UX: show error when hitting the rate limit on password reset 2018-10-22 19:00:30 +02:00
David Taylor
37b7afa522 FIX: Sanitize tags before creation 2018-10-22 10:53:42 +01:00
Kris
b35c8fb336 Add offset to topic footer admin menu, to avoid header overlap 2018-10-19 11:30:11 -04:00
David Taylor
0dd717e641 Revert "FIX: Sanitize tags before creation" 
This reverts commit 18ae8de9e5.
 2018-10-19 15:49:05 +01:00
David Taylor
18ae8de9e5 FIX: Sanitize tags before creation 2018-10-19 15:43:31 +01:00
David Taylor
7166d7de9a
FIX: Prevent duplicate tags in tag-choosers (#6512) 
* FIX: Prevent duplicate tags in tag-choosers

This reverts 5685b45, which fixes the duplicate tags problem.
The fix introduced by 5685b45 is re-implemented on the server.
 2018-10-19 13:44:43 +01:00
Bianca Nenciu
22ada32d4d FIX: Strip @ when searching for users and groups. (#6506) 2018-10-19 11:56:10 +11:00
Guto Foletto
0abc932056 add styles so permalinks admin could fit mobile screen (#6496) 2018-10-17 17:37:14 +02:00
Bianca Nenciu
f60b10d090 UX: Warn users if the post that's currently edited has changed. (#6498) 2018-10-17 15:35:32 +02:00
David Taylor
065bf0762c FEATURE: New plugin outlets for user card customization 2018-10-17 14:15:48 +01:00
Joe
5815a33a9a
FIX: closing an empty fullscreen composer with toggler prevents scrolling 2018-10-17 13:52:47 +08:00