Osama Sayegh
525920a979
FIX: Better error when SSO fails due to blank secret ( #7946 )
...
* FIX: Better error when SSO fails due to blank secret
* Update spec/requests/session_controller_spec.rb
Co-Authored-By: Robin Ward <robin.ward@gmail.com>
2019-07-26 17:37:23 +03:00
Joffrey JAFFEUX
fe7f0982af
DEV: attemps to limit Discourse.User.current() usage ( #7943 )
2019-07-26 11:20:11 +02:00
Arpit Jalan
0603636cea
FIX: include default label when exporting reports
2019-07-26 12:57:13 +05:30
Kris
0f4fa98a82
Margin applied too broadly, caused extra space on like-count
2019-07-25 16:00:13 -04:00
Robin Ward
a727968112
FIX: Provide an error message if no valid tags were selected
2019-07-25 12:46:16 -04:00
Gerhard Schlager
fd12c414e7
DEV: Refactor helper methods for upload markdown
...
Follow-up to a61ff167
2019-07-25 16:36:35 +02:00
Vinoth Kannan
2ba4de2d45
REVERT: DEV: should ignore missing post uploads when a user export destroyed
...
Reverts 793915fe6a
. We no longer need this since we're destroying each posts in commit 028121b95b
.
2019-07-25 19:41:25 +05:30
Gerhard Schlager
7e0eeed292
FEATURE: Add attachments to outgoing emails
...
This feature is off by default and can can be configured with the `email_total_attachment_size_limit_kb` site setting.
Co-authored-by: Maja Komel <maja.komel@gmail.com>
2019-07-25 15:57:45 +02:00
Kyle Zhao
0e1d6151b9
FIX: Frozen string error in TopicEmbed.import
( #7938 )
...
When `SiteSetting.embed_truncate` is enabled (by default), the truncated
string is mutatable and does not raise an error.
However, when the setting is disabled, the `contents` string is frozen
and immutable, and will raise a `FrozenError`.
2019-07-25 09:21:01 -04:00
Gerhard Schlager
a61ff16740
DEV: Make attachment markdown reusable
2019-07-25 14:04:18 +02:00
Arpit Jalan
6a0787445c
Bump onebox version.
...
- Deprioritize Twitter card in generic onebox
2019-07-25 17:13:23 +05:30
David Taylor
4f1382a54a
FIX: Hide live-loaded posts from ignored users
2019-07-25 12:01:29 +01:00
Joffrey JAFFEUX
0c7df55686
DEV: uses router.currentRouteName instead of application ( #7942 )
...
https://deprecations.emberjs.com/v3.x/#toc_application-controller-router-properties
2019-07-25 12:50:30 +02:00
Joffrey JAFFEUX
1dde6a5355
DEV: prevents post.siteSettings computed property to be overridden ( #7941 )
...
This happens when loading a post from a json object and is a behavior which will be impossble in future Ember updates.
2019-07-25 11:54:23 +02:00
Joffrey JAFFEUX
460d431621
DEV: uses ember-cli recommended chrome flags ( #7939 )
2019-07-25 11:38:05 +02:00
Joffrey JAFFEUX
c7b146cbdf
FIX: reverts #18e2816 ( #7940 )
2019-07-25 11:14:23 +02:00
Vinoth Kannan
47deb8b3da
FIX: use same id for both original & optimized inventories in multisite setup.
2019-07-25 14:16:47 +05:30
Jeff Atwood
db39eae683
make security commits search order by date
2019-07-25 00:08:03 -07:00
Osama Sayegh
997add3af9
DEV: Add extension point to allow modifying SSO URL ( #7937 )
...
This allows plugins to, for example, add extra query params to the SSO URL when discourse redirects to to the SSO website.
2019-07-25 00:18:27 +03:00
Joffrey JAFFEUX
c1d2fb115c
DEV: prevents staff computed property to be overridden ( #7931 )
2019-07-24 22:01:08 +02:00
Joffrey JAFFEUX
cc46de8f46
s/discourse-staff-notes/discourse-user-notes ( #7936 )
2019-07-24 20:04:27 +02:00
Régis Hanol
ae05245b00
DEV: plugin API to register User custom field types
2019-07-24 18:38:44 +02:00
Kris
2ab022494a
UX: Add expanded/collapsed class to post-controls ( #7932 )
2019-07-24 10:08:59 -04:00
David Taylor
b3e5f7a8c6
SECURITY: Sanitize email id for use as mutex key
2019-07-24 13:45:02 +01:00
Joffrey JAFFEUX
1d38bf7e2c
DEV: removes deprecated property() usage from topic-footer-button api ( #7930 )
2019-07-24 13:55:18 +02:00
Joffrey JAFFEUX
e83dcfdb7b
DEV: ensures application.hbs is using router currentPath ( #7929 )
2019-07-24 13:33:59 +02:00
Joffrey JAFFEUX
e444ce7ccd
REFACTOR: this.$() deprecation ( #7928 )
2019-07-24 13:17:36 +02:00
David Taylor
864f68725a
DEV: Correct test from 9c1c8b45
2019-07-24 11:45:36 +01:00
David Taylor
b084d6c8df
DEV: Add missing parenthesis for 47ad2a4d
2019-07-24 11:29:18 +01:00
David Taylor
0a6cae654b
SECURITY: Add confirmation screen when connecting associated accounts
2019-07-24 10:28:15 +01:00
David Taylor
da4c1c5afc
DEV: Remove trailing whitespace from 47ad2a4d
2019-07-24 10:27:44 +01:00
Angus McLeod
47ad2a4d7a
DEV: Handle both name formats in managed authenticator ( #7925 )
2019-07-24 10:22:26 +01:00
Joffrey JAFFEUX
02e27b5cff
UX: fixes onebox favicon vertical alignment ( #7926 )
2019-07-24 09:40:32 +02:00
Michael Brown
31f583855a
DEV: pull static check out of loop
...
* followup to 08b28680
* as per https://review.discourse.org/t/4713/2
2019-07-23 17:18:16 -04:00
Osama Sayegh
8b5f44a9a7
FIX: apply defaults constraints to routes format (take 2) ( #7920 )
...
Reapplies 7d01c5de1a
2019-07-23 20:17:44 +03:00
Saurabh Patel
9e0a3b8229
bug: keep query params present in auth_redirect ( #7923 )
...
https://meta.discourse.org/t/user-api-keys-payload-and-existing-query-string-leads-to-a-double-question-mark/123617
2019-07-23 12:16:03 -04:00
Gerhard Schlager
abe6202af9
DEV: Fix heisentest
2019-07-23 18:04:53 +02:00
Gerhard Schlager
68b082e1a4
FIX: Ensure that jobs don't run immediately after migrate_to_s3
2019-07-23 17:42:12 +02:00
Kris
3fdc10337d
follow up fix to 7d27b8b
2019-07-23 11:37:34 -04:00
Kris
7d27b8bb8c
add class for extra post buttons
2019-07-23 11:32:04 -04:00
Joffrey JAFFEUX
e117b10ea8
FIX: improves tags checking when updating category of topic ( #7921 )
...
- will ensure this tag is not restricted to another category, and not only ensure this category can use it
- will clean tags param, in case client is sending an empty array, eg: [""], this could be solved client-side, but we ensure it won't happen ever this way
2019-07-23 17:06:25 +02:00
Joffrey JAFFEUX
8a9ce7336d
FIX: removes uncategorized context if not allowed in composer ( #7922 )
2019-07-23 17:05:49 +02:00
Saurabh Patel
4bc5ccf7e4
BUG: send featuredLink as featured_link to backend to update correct … ( #7915 )
...
* BUG: send featuredLink as featured_link to backend to update correct value
https://meta.discourse.org/t/editing-a-topic-link-does-not-change-its-featured-link/123007
* review fix
2019-07-23 09:49:04 -04:00
romanrizzi
c4be8541f6
FIX: use uniq instead of uniq! when checking for uncompressed root path. Use rails naming convention for ZipUtils
2019-07-23 07:57:50 -03:00
Régis Hanol
afe2be4f62
Follow-up for 89efcfcf
to properly fix nested arrays
2019-07-23 10:29:18 +02:00
OsamaSayegh
f364317625
PERF: Improve query speed when looking up direct PMs
...
Follow up to 5fc5a7f5ae
2019-07-23 03:52:52 +00:00
Gerhard Schlager
89efcfcf28
Follow-up for a8cdd685
to fix nested array
2019-07-22 22:30:57 +02:00
Gerhard Schlager
a8cdd68518
FIX: Migrations tried to change frozen string
...
Also, makes the migration work with locales which use more than just the "one" and "other" keys.
2019-07-22 22:16:43 +02:00
Gerhard Schlager
845fd42153
FIX: Update reply count when moving posts
2019-07-22 21:42:24 +02:00
Gerhard Schlager
271ddac467
FIX: Delete notifications users can't see after moving posts
...
No need to let notifications stay around when users can't access
a topic after it was converted into a PM or posts were moved
into a restricted topic.
Also makes sure that moving to a new topic correctly uses the
guardian for the first post by enqueuing jobs outside of a
transaction.
2019-07-22 19:02:21 +02:00