Commit Graph

29866 Commits

Author SHA1 Message Date
Joe
e844fa5370
UX: general cleanup of inputs, buttons and select elements - part 1 2018-09-19 20:37:04 +08:00
Guo Xiang Tan
667e68ec58 Prefer create over create! when not checking for response. 2018-09-19 18:22:54 +08:00
Guo Xiang Tan
d4bd04c3a7 Allow purge_deleted_uploads_grace_period_days to be shadowed. 2018-09-19 17:49:00 +08:00
Guo Xiang Tan
d403883d16 DEV: Improve specs for 293cf600f0. 2018-09-19 16:03:52 +08:00
Guo Xiang Tan
293cf600f0 FIX: Use a tmp file in UploadRecovery for local store. 2018-09-19 15:47:15 +08:00
Sam
e0e6dae6a7 minor cleanup to previous commit from code review 2018-09-19 16:07:29 +10:00
Sam
5302709343 FIX: in redis readonly raise an exception from DistributedMutex
If we detect redis is in readonly we can not correctly get a mutex
raise an exception to notify caller

When getting optimized images avoid the distributed mutex unless
for some reason it is the first call and we need to generate a thumb

In redis readonly no thumbnails will be generated
2018-09-19 15:50:58 +10:00
Arpit Jalan
80229668f9 bump onebox version
- FIX: user correct steam placeholder image url
- catch up Ruby 2.6
2018-09-19 10:06:43 +05:30
Guo Xiang Tan
95293a6997 Re-run Jobs::RecoverPostUploads.
Previously, `UploadRecovery` did not account for uploads which
may be present in links. This meant that attachments were not
recovered.
2018-09-19 12:17:01 +08:00
Guo Xiang Tan
bc7f58191e FIX: UploadRecovery should look at links too. 2018-09-19 11:52:57 +08:00
Guo Xiang Tan
4a92c5b2d6 UploadRecovery should recover attachments too. 2018-09-19 10:44:36 +08:00
Guo Xiang Tan
5a9b029014 Improve error messaging in SocketServer. 2018-09-19 09:11:10 +08:00
Jeff Atwood
b33a623774 very minor copyedit 2018-09-18 15:48:48 -07:00
Vinoth Kannan
4383afb769
Merge pull request #6413 from vinothkannans/log-entity-export
FEATURE: Log entity export in staff logs
2018-09-19 03:18:28 +05:30
Vinoth Kannan
9281b72308 FEATURE: Log entity export in staff logs 2018-09-19 03:16:45 +05:30
Jeff Atwood
f43b5bb3c1 considerably simplify copy for change owner 2018-09-18 14:15:08 -07:00
Kris
e95d6a12c5 prettier 2018-09-18 13:39:58 -04:00
Kris
8bfb016386 remove trailing spaces 2018-09-18 13:25:50 -04:00
Kris
d20a174a6b UX: Lighter style for category and tag dropdown nav 2018-09-18 13:11:00 -04:00
Kris
4cf3ef53bc Prevent spinner in tag dropdown from being squished 2018-09-18 11:27:01 -04:00
Joffrey JAFFEUX
a713c0d366
FIX: ensures onSelect/onDeselect are called
This commit also add a FIX and a test for toolbar-popup-menu-options which had a behavior slightly specific.
2018-09-18 11:31:23 +02:00
Arpit Jalan
fadcd36f92 FIX: do not treat ignore_redirects domains as blacklisted
This fix prevents domains present in `ignore_redirects` to be treated as
blacklisted domains and makes sure that onboxing happens for those domains.
Issue reported here: https://meta.discourse.org/t/steam-store-oneboxing-no-longer-works/97266
2018-09-18 10:38:02 +05:30
Guo Xiang Tan
ce6a0a5e9e FIX: Moving upload to tombstone should update modification time.
A upload created a long time ago will be nuked from the tombstone
immediately if it gets deleted.
2018-09-18 10:48:29 +08:00
Guo Xiang Tan
f2fbf1fdb0 DEV: Basic specs for TagGroupsController. 2018-09-18 08:22:03 +08:00
Sam
7d6b348d0b SECURITY: correct XSS on long topic titles 2018-09-18 08:54:44 +10:00
Sam
0e9841b995 SECURITY: remove admin memory diagnostics routes 2018-09-18 08:35:09 +10:00
Joffrey JAFFEUX
2ff2c49908 Revert "FIX: ensures onSelect/onDeselect are called"
This reverts commit 52eed73294.
2018-09-17 22:14:41 +02:00
Kris
7f420b61cb Removing unneeded theme intro text 2018-09-17 12:00:20 -04:00
Neil Lalonde
6f1b8ad16d FIX: tag groups page should only be visible to staff
No security concern here because nothing private was visible,
and no actions could be taken by non-staff users.
2018-09-17 11:41:18 -04:00
Gerhard Schlager
fb9e3e6423 Update aws-sdk-s3
In preparation for https://github.com/discourse/discourse/pull/6345
2018-09-17 17:39:46 +02:00
Neil Lalonde
b9891c2641 FIX: error because last_id is nil in discourse_merger script 2018-09-17 09:57:11 -04:00
Vinoth Kannan
16d7132ba1 SPEC: Check date and time values separately 2018-09-17 18:39:59 +05:30
Vinoth Kannan
b13b6e30d6 DEV: Skip converting local dates as json 2018-09-17 18:18:43 +05:30
Régis Hanol
4481836de2 FEATURE: new 'search_ignore_accents' site setting 2018-09-17 10:42:30 +02:00
Joffrey JAFFEUX
52eed73294
FIX: ensures onSelect/onDeselect are called 2018-09-17 10:36:14 +02:00
Kyle Zhao
7a0232249a
extract inline JS that's used to store preloaded data (#6370) 2018-09-17 16:31:46 +08:00
Joffrey JAFFEUX
01913b9dc0 FIX: improves themes/components UI on mobile 2018-09-17 10:05:18 +02:00
Kyle Zhao
7b19ed06c1 reworked specs of existing group behavior 2018-09-17 17:46:43 +10:00
Kyle Zhao
6751662bf8
DEV: yarn prettier in Danger (#6405)
Use `yarn --silent` to suppress yarn console logs, and only allow for
prettier output.

Escape sequence (`\n`) does not work in single quotes
2018-09-17 15:10:00 +08:00
Guo Xiang Tan
b71af05d62 Backward compatibility for dropping functions in ColumnDropper.
https://meta.discourse.org/t/launcher-rebuild-error-pg-error-schema-discourse-functions-does-not-exist/96209
2018-09-17 14:46:05 +08:00
Kyle Zhao
6659417807 FEATURE: match user title when primary group changes
When primary group changes and the user's title is the previous primary
group's title, change the title to the new primary group's title
2018-09-17 15:08:39 +10:00
Guo Xiang Tan
53d34c69fc Fix lint. 2018-09-17 10:26:48 +08:00
Joffrey JAFFEUX
4b3c2490c3 FIX: allowes forcing timezone displayed in local-dates
Use case being you might want to always display a specific timezone, but still have the possibility to show the tooltip with various timezones.
2018-09-17 10:06:57 +08:00
Sam
33541c4096 FEATURE: unconditionally omit no-follow for staff
Previously TL2 and below staff would have links
no-followed which was never intended
2018-09-17 12:02:20 +10:00
Sam
37c5280f73 correct spec 2018-09-17 11:37:01 +10:00
Sam
e15a1e7c38 lint code 2018-09-17 11:10:09 +10:00
CheshireVillageSoftware
f3214889dc FEATURE: Updated CORS config to explicitly specifyhttp methods
See: https://stackoverflow.com/questions/20478312/default-value-for-access-control-allow-methods 

In particular we now explicitly allow DELETE and PUT which is inconsistently allowed depending on browser
2018-09-17 11:01:08 +10:00
Rishabh
4f46aa1ba3 FEATURE: Add SiteSetting for s3_configure_tombstone_policy
Add SiteSetting for s3_configure_tombstone_policy, skip policy generation if turned off (default on)
2018-09-17 10:57:50 +10:00
Sam
725d2c0d47 correct spec 2018-09-17 10:54:35 +10:00
Sam
b63630d70b use Mixin postfix when importing tags mixin 2018-09-17 10:46:57 +10:00