Commit Graph

29866 Commits

Author SHA1 Message Date
Sam
5b630f3188 FIX: stop logging every time invalid params are sent
Previously we were logging warning for invalid encoded params, this can
cause a log flood
2018-10-05 14:33:19 +10:00
Guo Xiang Tan
da39a310c3 Fix missing quotes in unicorn_launcher. 2018-10-05 12:21:07 +08:00
Guo Xiang Tan
07eca289d3 Fix invalid bash syntax. 2018-10-05 12:18:20 +08:00
Guo Xiang Tan
00ae94cb4d DEV: Prevent unicorn_launcher from looping forever.
For some reason, the new master unicorn process that we
detect might be replaced with another process causing
the script to loop forever.
2018-10-05 12:12:54 +08:00
Guo Xiang Tan
3400624d70 Log pid of launcher script when logging. 2018-10-05 11:48:32 +08:00
Guo Xiang Tan
77c293f82d Prefer Process.clock_gettime over Time.now. 2018-10-05 10:25:52 +08:00
Jeff Atwood
2bdc36bd8c very minor copyedit on bump date 2018-10-04 17:22:44 -07:00
Kris
948c556cc6 decrease contrast on danger-low color 2018-10-04 17:30:10 -04:00
Kris
98b9913033 UX: Disable button hover effects on touch devices 2018-10-04 17:15:37 -04:00
David Taylor
9554d657c5 DEV: Remove underscore from tags-test 2018-10-04 21:14:52 +01:00
Kris
ab1e5732d7 UX: Category colorpicker restyle 2018-10-04 15:47:46 -04:00
Vinoth Kannan
3faa022c6f
Merge pull request #6453 from vinothkannans/sso_provider_redirect
FIX: redirect users to SSO client URL after social login
2018-10-05 00:34:34 +05:30
Vinoth Kannan
ca74246651 FIX: redirect users to SSO client URL after social login 2018-10-05 00:01:08 +05:30
Kris
2e28116243 Period-chooser should have visible overflow 2018-10-04 12:28:48 -04:00
Kris
09caf95e7d create account inputs too wide on iOS 2018-10-04 12:02:28 -04:00
Kris
8e0fe32f37 Minor login layout fixes 2018-10-04 11:54:51 -04:00
Bianca Nenciu
e0e0a91e7d FIX: Retry sending email in case of temporary issue. (#6375) 2018-10-04 22:56:24 +08:00
David Taylor
5b56a8cd09 DEV: Merge multiple discourse_tagging_spec files 2018-10-04 15:44:29 +01:00
David Taylor
3c2608d41c
FIX: Correctly censor strings starting or ending with non-word characters (#6445) 2018-10-04 15:15:10 +01:00
Maja Komel
361ad7ed2b FEATURE: add indication if incoming email attachment was rejected and inform sender about it (#6376)
* FEATURE: add indication if incoming email attachment was rejected and inform sender about it

* include errors for rejected attachments in email

* don't send warning email to staged users

* use user object instead of user_id in add_attachments method
2018-10-04 22:08:28 +08:00
Bianca Nenciu
6ad13e5ae9 FIX: Avoid redirection when not leaving forum. (#6419)
* FIX: Avoid redirection when not leaving forum.

* DEV: Updated click-track's tests.
2018-10-04 22:06:31 +08:00
Paul Trippett
b8a1196b6b Add missing fields to Upload Fabricator (#6448) 2018-10-04 22:00:07 +08:00
Gerhard Schlager
d902bb90ae Update yarn.lock with integrity hashes
This should prevent the stable version of yarn from rewriting the lock file all the time.
2018-10-04 11:21:13 +02:00
Guo Xiang Tan
16dedb5498 Avoid hardcoded value in unicorn_launcher take 2. 2018-10-04 17:13:27 +08:00
Rishabh Nambiar
943f017a17 Mark discourse-perspective-api as an official plugin 2018-10-04 14:34:22 +05:30
Guo Xiang Tan
a8368318fe Revert "Avoid hardcoded value in unicorn_launcher."
This seems to be causing problem with the unicorn master pid
tracking so revert for now.

This reverts commit 09d0216e84.
2018-10-04 16:26:13 +08:00
Guo Xiang Tan
09d0216e84 Avoid hardcoded value in unicorn_launcher.
On slower instances, spinning up a new master process
can take more than 10 secs.
2018-10-04 15:44:13 +08:00
Sam
378584fdc0 correct under reporting of memory in memory profiler 2018-10-04 17:02:53 +10:00
Guo Xiang Tan
d43ed4afa2 Remove unused variable. 2018-10-04 13:21:37 +08:00
Lucas Nicodemus
1907338834 FIX: No longer educate users who are editing
A user editing a post will no longer get composer messages that are
meant for new users posting replies and threads. These messages don't
make sense in an edit context at all -- they're usually discussing
making salient replies or topics, or adding avatars. They make even less
sense when a user is an admin attempting to change the default topics
for the first time.

Since these messages actually do make sense for a user when they have a
low post count, though, they're still going to occur. They just occur
when a user is creating new content (and thus, more likely to read the
notice), not during edits.

This is in response to this issue:
https://meta.discourse.org/t/education-message-for-editing-wiki-topic/66682
2018-10-04 13:20:13 +08:00
Kris
ff47609141 UX: Improve custom field layout on signup 2018-10-03 22:26:05 -04:00
Jeff Wong
632ca42db9 FIX: edit checks for editing posts with no topic 2018-10-03 18:34:47 -07:00
Rafael dos Santos Silva
b8d3fbd08b FEATURE: Enable the notification prompt by default 2018-10-03 19:58:24 -03:00
Vinoth Kannan
a651d39b8a
FIX: Display errors in single theme pages (#6449)
Currently the errors are not well handled. So it breaks the whole UI of admin themes list page.
2018-10-04 02:33:06 +05:30
Penar Musaraj
b5bdd42838 Progress bar CSS refactoring (#6444)
* Less magic in calculating topic progress bar

* more minor adjustments to topic progress CSS

* Bounce back button again

* Fix prettier warning
2018-10-03 13:21:57 -04:00
Penar Musaraj
9e008047db reset before running docker tests 2018-10-03 10:32:16 -04:00
Kris
46563082a9 FIX: Move overflow from cooked to parent element to allow for slight overflow of blur/italic/shadow 2018-10-03 10:18:36 -04:00
Penar Musaraj
dc8a16b43b
Use Yarn to manage dependencies, cleanup unused bootstrap libs (#6436) 2018-10-03 10:15:43 -04:00
Arpit Jalan
420e7bccca bump onebox version (take 2)
- better detection of zero dollar amazon price
2018-10-03 17:54:56 +05:30
Arpit Jalan
b56d0026b9 bump onebox version
- do not display zero dollar price on Amazon onebox
- fix google play store onebox
2018-10-03 17:05:51 +05:30
Guo Xiang Tan
13dde44c72 FIX: Limit concurrent assets:precompile to number of available cores. 2018-10-03 16:46:21 +08:00
Vinoth Kannan
23b4ab9bf9 DEV: Do not use concatenation in translations 2018-10-03 11:59:21 +05:30
Guo Xiang Tan
4b367dc61e FIX: unicorn_launcher should shut down unicorn gracefully. 2018-10-03 14:27:05 +08:00
Vinoth Kannan
2912170e9e Update placeholder github url in correct format 2018-10-03 11:14:36 +05:30
Sam
0e10b47618 UX: make responsive_post_image_sizes a visible site setting
This is useful for sites that want to cut bandwidth by decreasing
fidelity of thumbnails.
2018-10-03 15:06:37 +10:00
Sam
eba3117e08 Missed one spot where url needed cooking 2018-10-03 15:06:37 +10:00
Jeff Atwood
76d8d1bd4d
Merge pull request #6446 from hakusaro/readme-remove-gs
Readme: Remove reference to old dev environment setup blog post
2018-10-02 21:14:55 -07:00
Sam
41eacd859e temporarily comment out test 2018-10-03 14:07:30 +10:00
Lucas Nicodemus
b800833ddc Readme: Remove ref to old dev env blog post
The old "Discourse as your first rails app" blog post points people in
the direction of Vagrant, which is no longer maintained. That blog post
now points people in the direction of guides that have been wiki-fied on
Meta, which can also be replied to if there are questions. The existing
setup guides appear to be relevant still, but the community wikis are
probably better for new people to reference.

If you ask me, though, there's a great debate here about whether or not
setup documentation should live in this repo or on Meta -- but I don't
have the answer for that. It's more important to get the effectively
dead guide off the front page, since it's Hacktoberfest and I'm sure
people want to contribute, but need a clear starting point.
2018-10-02 21:02:11 -07:00
Sam
ad0e768742 FEATURE: add support for responsive images in posts
When creating lightboxes we will attempt to create 1.5x and 2x thumbnails
for retina screens, this can be controlled with a new hidden site setting
called responsice_post_image_sizes, if you wish to create 3x images run

SiteSetting.responsive_post_image_sizes = "1|1.5|2|3"


The default should be good for most of the setups as it balances filesize
with quality. 3x thumbs can get big.
2018-10-03 13:44:53 +10:00