Guo Xiang Tan
5bca1aec48
FIX: Clean up topic_timers when no longer valid.
...
This was causing a bug where the jobs for the topic_timers will keep
getting enqueued over and over again.
2020-08-26 12:18:51 +08:00
Guo Xiang Tan
1e8f216e17
FIX: Ensure autoclose based on last post is executed by system user.
2020-08-26 12:08:46 +08:00
Guo Xiang Tan
ffc5bb7278
Revert "FIX: Topic Timer auto opening closed topics ( #10524 )"
...
This reverts commit 7cfd5f87ff
2020-08-26 09:32:11 +08:00
Blake Erickson
7cfd5f87ff
FIX: Topic Timer auto opening closed topics ( #10524 )
...
This commit is addressing an issue where it is possible that there could
be multiple topic timer jobs running to close a topic or a weird race
condition state causing a topic that was just closed to be re-opened.
By removing the logic from the Topic Timer model into the Topic Timer
controller endpoint we isolate the code that is used for setting an
auto-open or an auto-close timer to just that functionality making the
topic timer background jobs safer if multiple are running.
Possibly in the future if we would like this logic back in the model a
refactor will be needed where we actually pass in the auto-close and
auto-open action instead of mixing it with the close and open
action that is currently being passed to the controller.
2020-08-26 11:17:12 +10:00
Kane York
93e136ae0e
UX: show a generic error on upload for XHR status 0 ( #10521 )
...
This indication covers all cases of network errors, not just "cancelled by user".
The post upload component already has its own handling for user-cancelled uploads, but the generic upload component does not.
Tested by stopping my localhost server right before attempting to upload a file.
2020-08-25 12:08:03 -07:00
Penar Musaraj
7277ca6cb6
UX: Add category-title-before to categories-boxes layout
...
Makes it consistent with the other /categories layouts
2020-08-25 13:35:13 -04:00
dependabot-preview[bot]
f670f93223
Build(deps): Bump rubocop-rspec from 1.43.1 to 1.43.2
...
Bumps [rubocop-rspec](https://github.com/rubocop-hq/rubocop-rspec ) from 1.43.1 to 1.43.2.
- [Release notes](https://github.com/rubocop-hq/rubocop-rspec/releases )
- [Changelog](https://github.com/rubocop-hq/rubocop-rspec/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop-hq/rubocop-rspec/compare/v1.43.1...v1.43.2 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-08-25 09:57:45 -04:00
Faizaan Gagan
2100de449e
Update spec/components/concern/has_custom_fields_spec.rb
...
Co-authored-by: Régis Hanol <regis@hanol.fr>
2020-08-25 09:52:18 -04:00
Faizaan Gagan
7e5290203f
Update spec/components/concern/has_custom_fields_spec.rb
...
Co-authored-by: Régis Hanol <regis@hanol.fr>
2020-08-25 09:52:18 -04:00
fzngagan
c363189858
Accounted for the change while reading the fields added specs to confirm working
2020-08-25 09:52:18 -04:00
fzngagan
352ad826c1
FIX: symbols and strings should be treated similarly while saving custom fields
2020-08-25 09:52:18 -04:00
Robin Ward
71e747b160
FIX: QUnit site has to be set before reset()
2020-08-25 09:16:32 -04:00
Robin Ward
2523a21fc3
FIX: Server side rendering was broken with new helperContext()
2020-08-25 09:16:32 -04:00
Robin Ward
a3fb732b23
REFACTOR: We can reuse getOwner for some container stuff
2020-08-25 09:16:32 -04:00
Robin Ward
347a4981a0
REFACTOR: Remove Discourse constant from get-owner
2020-08-25 09:16:32 -04:00
Robin Ward
185ed80702
REFACTOR: Remove Discourse constants from nav-item
2020-08-25 09:16:32 -04:00
Robin Ward
c068098f75
REFACTOR: Remove container from User class
2020-08-25 09:16:32 -04:00
Robin Ward
c94ba34882
REFACTOR: Remove __container__ from Site
2020-08-25 09:16:32 -04:00
Robin Ward
ac498ae2a0
REFACTOR: Remove container from ajax
2020-08-25 09:16:32 -04:00
Robin Ward
df8ae6891c
REFACTOR: Remove constants from text helper
2020-08-25 09:16:32 -04:00
Robin Ward
4063cab8c2
REFACTOR: Missed containers in DiscourseURL
2020-08-25 09:16:32 -04:00
Robin Ward
02e8d84e30
REFACTOR: Remove Discourse constant from showModal
2020-08-25 09:16:32 -04:00
Robin Ward
98e5e1cd53
REFACTOR: Remove container from DiscourseURL
2020-08-25 09:16:32 -04:00
Robin Ward
dae8b9bcfb
FIX: Remove container from utilities
2020-08-25 09:16:32 -04:00
Robin Ward
89d766d089
REFACTOR: Remove container from safari-hacks
2020-08-25 09:16:32 -04:00
Robin Ward
c7c3fd4209
REFACTOR: Remove container from pwa-utils
2020-08-25 09:16:32 -04:00
Robin Ward
ebc0298ea0
REFACTOR: Remove Discourse.authenticationComplete
2020-08-25 09:16:32 -04:00
Robin Ward
20e1233f89
REFACTOR: Remove container from raw template helper
2020-08-25 09:16:32 -04:00
Robin Ward
e08545cf99
Add a pull request template to remind people to add tests.
2020-08-25 09:03:38 -04:00
Discourse Translator Bot
d495464ead
Update translations
2020-08-25 13:02:37 +00:00
Gerhard Schlager
dac0e5b3cc
Merge pull request #10519 from gschlager/get-url
...
Fixes for getURL() in subfolders and basePath in translations
2020-08-25 11:42:50 +02:00
Jarek Radosz
e66f95de3a
FIX: DEV: Lock-on improvements ( #10448 )
...
* DEV: Don't listen for deprecated events
https://developer.mozilla.org/en-US/docs/Web/API/Element/DOMMouseScroll_event
https://developer.mozilla.org/en-US/docs/Web/API/Element/mousewheel_event
* DEV: Listen only on the `body` element
* DEV: clearLock after a while if target is missing
* DEV: Bind the callback
* FIX: Use `requestAnimationFrame`
Prevents content jumps
2020-08-25 11:42:00 +02:00
Gerhard Schlager
6c09fd4289
DEV: Remove unused code and translations
2020-08-25 11:41:19 +02:00
Jarek Radosz
d684d5fba4
DEV: Don't lint core files when target == plugins ( #10259 )
...
* DEV: Don't lint core files when target == plugins
* Prettier the plugin/*.js files
* Update eslintignore/prettierignore
* Add eslint-plugin-ember and eslint-plugin-node
* Properly lint all js files in all plugins
* LINT: run prettier on test/*.js files
* DEV: Run prettier checks on test/*.js files
* ESLint plugins' assets/javascripts and test/javascripts directories only
2020-08-25 11:40:40 +02:00
Gerhard Schlager
10e6e8d307
Use quotes instead of grave accent
2020-08-25 11:39:11 +02:00
Joe
66aa94c515
UX: Timeline should jump to the bottom of the post in single-post topics ( #10503 )
2020-08-25 16:22:07 +08:00
siriwatknp
80b92cf469
test: 💍 add test for thai tag
2020-08-25 16:12:26 +08:00
siriwatknp
1a2800ad07
fix: 🐛 category & tag search regex to support thai character
2020-08-25 16:12:26 +08:00
Guo Xiang Tan
f08d440ea0
DEV: Disable migration advisory locks in dev and test environment.
...
There is a bug in Rails that leaks an idle PG session which will prevent
the dropping of the database.
2020-08-25 14:20:58 +08:00
dependabot-preview[bot]
5d7055779a
Build(deps): Bump sidekiq from 6.0.7 to 6.1.1
...
Bumps [sidekiq](https://github.com/mperham/sidekiq ) from 6.0.7 to 6.1.1.
- [Release notes](https://github.com/mperham/sidekiq/releases )
- [Changelog](https://github.com/mperham/sidekiq/blob/master/Changes.md )
- [Commits](https://github.com/mperham/sidekiq/compare/v6.0.7...v6.1.1 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-08-25 11:19:41 +08:00
Kris
a92a6b7b10
UX: Minor layout fixes and improved consistency on theme admin
2020-08-24 22:51:58 -04:00
Mark VanLandingham
cef51b3489
DEV: Remove hasBlock from user-info component ( #10415 )
2020-08-24 21:44:01 -05:00
Guo Xiang Tan
9c997ae117
Revert "DEV: allow plugins to send extra silenced message params"
...
This reverts commit c3aeb442d7
2020-08-25 09:57:57 +08:00
Jeff Wong
c3aeb442d7
DEV: allow plugins to send extra silenced message params
...
allows plugins to send extra custom message params so that they can
include things such as silence reason and message_body if desired
2020-08-24 18:34:18 -07:00
Guo Xiang Tan
9354ee35d2
DEV: Ensure test resets to original constant.
...
Also simplifies the test to reduce amount of test setup done.
2020-08-25 09:24:59 +08:00
Krzysztof Kotlarek
7b6f8517bf
FIX: limit number of users addable to group at once ( #10510 )
...
When someone wants to add > 1000 users at once they will hit a timeout.
Therefore, we should introduce limit and inform the user when limit is exceeded.
2020-08-25 08:55:21 +10:00
Neil Lalonde
ed30f49315
FIX: duplicate categories and tags allowed in inputs where they shouldn't be allowed
...
blocklist was renamed to blockedCategories/Tags
2020-08-24 17:37:04 -04:00
Neil Lalonde
52217099ed
FIX: group categories inputs not filled sometimes
...
If you land on the group > manage > categories page or reload it,
the fields will all be blank when there should be categories.
2020-08-24 17:15:37 -04:00
Rachel Carvalho
812e0d6b5e
FIX: improve Vanilla importing ( #10478 )
...
* ensure emails don't have spaces
* import banned users as suspended for 1k yrs
* upgrade users to TL2 if they have comments
* topic: import views, closed and pinned info
* import messages
* encode vanilla usernames for permalinks. Vanilla usernames can contain spaces and special characters.
* parse Vanilla's new rich body format
2020-08-24 16:19:57 -04:00
Gerhard Schlager
1959745c2c
FIX: Current title wasn't visible when assigning badge title
2020-08-24 21:39:44 +02:00
