Joffrey JAFFEUX
f9e715672b
DEV: makes autocomplete debounced ( #9941 )
...
* DEV: makes autocomplete debounced
* better wording
2020-06-02 15:20:14 +10:00
Guo Xiang Tan
3dd1778199
PERF: Reduce number of queries from 3 -> 1 when fetching web manifest.
2020-06-02 12:04:02 +08:00
Guo Xiang Tan
7897010dfd
Fix lint.
2020-06-02 10:45:18 +08:00
Guo Xiang Tan
370cba451d
DEV: Refactor away conditionals that we don't need.
2020-06-02 10:40:29 +08:00
Guo Xiang Tan
c21e3bbd1b
DEV: Prefer create! over create when not checking return value.
...
We don't want stuff to silently fail.
2020-06-02 10:34:05 +08:00
Penar Musaraj
2a0a689442
UX: prevent devices from miscalculating fullscreen composer height
...
Fixes issue seen in some Chromebooks that flip between tablet and regular notebook window size
2020-06-01 22:24:16 -04:00
Sam Saffron
7e52106812
DEV: when synchornizing state pull tags
...
In some cases we may want topic tracking state to keep track of tags
this small change ensures we do not remove them if they are already in place
2020-06-02 11:42:00 +10:00
Penar Musaraj
fa6aa7f627
FIX: Digest frequency issue on user creation
...
If `default email digest frequency` was set to "Never", users would get
a `digest_after_minutes` set to `nil` which triggered this error
in the logs if/when the site eventually changed that setting and
enabled digests:
```
NoMethodError (undefined method `>=' for nil:NilClass)
/var/www/discourse/app/mailers/user_notifications.rb:227:in `digest'
```
2020-06-01 17:39:16 -04:00
Robin Ward
a95826f60c
Remove discourse constants ( #9958 )
...
* DEV: `Discourse.baseUri` does not exist
This never could have worked - should have been `Discourse.BaseUri` if
anything.
* DEV: Remove Discourse.Environment
* DEV: Remove `Discourse.disableMissingIconWarning`
* DEV: A bunch more missing environment checks
2020-06-01 16:33:43 -04:00
Kane York
9162cd8f3d
FIX: Only render group card if user title is from group ( #9946 )
...
This was failing when a user with a primary_group chose to display a title coming from a badge.
2020-06-01 11:44:41 -07:00
Mark VanLandingham
b6709f0dda
DEV: Add option to only show icons to header widget ( #9935 )
2020-06-01 12:26:59 -05:00
David Taylor
3106f85983
FIX: Support exporting reports which reference topics ( #9957 )
2020-06-01 18:23:58 +01:00
tshenry
0d6b638dac
FEATURE: New plugin outlet under badges page title ( #9936 )
2020-06-01 08:55:51 -07:00
tshenry
c01a994263
DEV: Better error handling for destroy:users task ( #9939 )
2020-06-01 08:55:08 -07:00
Jarek Radosz
e19d907f0f
FIX: Correct the misalignment of popover arrows ( #9947 )
...
* Fixes position of the top arrow, and border width of both
* Merged top and transform properties
* .5px values are required to make arrow border appear the same with as overall popover border width
I did have a chance to try it out on a Windows machine with a non-high DPI display and there were no issues. And I just re-tested it with Firefox on macOS using the "Open in Low Resolution" option and it looked more or less ok (bearing in mind that it the whole app is then a blurry mess, and that using custom zoom levels causes the arrow to break slightly, but that was also the case on Firefox before this change)
2020-06-01 16:31:53 +02:00
Penar Musaraj
c2abf88a61
UX: Adjustments to topic admin menu on mobile ( #9945 )
2020-06-01 09:39:38 -04:00
Jarek Radosz
921751f128
UX: Remove box-shadow from kbd, unify styling ( #9948 )
...
Having many elements with multiple box-shadows (e.g. in keyboard shortcuts modal) was tanking scrolling performance in some browsers.
2020-06-01 15:00:56 +02:00
Jarek Radosz
ef8e44af73
FIX: Don't change the button height when spinner appears
...
on the exception page.
2020-06-01 14:15:41 +02:00
Joffrey JAFFEUX
57e587f39f
DEV: removes dead code of dropdown-menu ( #9942 )
2020-06-01 11:22:35 +02:00
Jarek Radosz
6ed3dbef03
UX: Fix border radius artifacts on dashboard pills ( #9949 )
2020-06-01 11:21:07 +02:00
Joffrey JAFFEUX
40c4a8e3fc
DEV: skips/tweaks brittle tests ( #9952 )
2020-06-01 11:09:34 +02:00
Sam Saffron
82de9c5308
DEV: add countTags to topic tracking state
...
This introduces a new core API to get counts per tag from topic
tracking state
This API will only be useful if a plugin enable tags in topic
tracking state using
`TopicTrackingState.include_tags_in_report = true`
2020-06-01 17:05:24 +10:00
Jarek Radosz
00aab49829
FIX: Restore the ability to rebake posts in deleted topics ( #9951 )
...
Lost in #9852
2020-06-01 07:04:16 +02:00
Jarek Radosz
9ee77eae98
FIX: z helper doesn't resolve inside calc
...
It resulted in invalid `z-index: calc(z("tooltip") - 100)` in the output CSS. `calc` wasn't necessary here anyway since both operands are constant.
2020-06-01 05:50:50 +02:00
Jarek Radosz
7bcee784c8
DEV: Remove an obsolete comment
...
Its first part was removed with other changes and this one got displaced after a `prettier` pass.
2020-06-01 05:50:49 +02:00
Jarek Radosz
754a255ef7
UX: Remove the period after "Enable Notifications" button
2020-06-01 05:50:49 +02:00
Jarek Radosz
7ac9a79ecb
UX: Fix inputs alignment in admin/customize/colors
2020-06-01 05:50:49 +02:00
Krzysztof Kotlarek
9a6ef80739
FEATURE: notify admins about old credentials ( #9918 )
...
* FEATURE: notify admins about old credentials
Security and API keys should be renewed periodically.
This additional notification should help admins keep their Discourse safe and secure.
2020-06-01 13:49:27 +10:00
Penar Musaraj
f2647f1f36
UX: Position topic admin menu next to wrench ( #9932 )
2020-05-30 15:32:57 -04:00
Vinoth Kannan
e1af91f5ae
Revert "FEATURE: category setting for default list filter."
...
This reverts commit 6f03d14c23
2020-05-30 20:53:53 +05:30
Joffrey JAFFEUX
93bd1ff228
FIX: topic-admin-popup-menu was overflowing on small screens ( #9944 )
2020-05-30 10:53:08 +02:00
Kris
530c6594cb
follow-up fix due to adding overflow hidden in 32e40ea
2020-05-29 22:23:23 -04:00
Kris
3c11c5dcdc
show-replies styles were lost with some menu changes
2020-05-29 22:05:58 -04:00
Kris
32e40ea133
UX: Make the menu links header within the user panel more flexible
2020-05-29 21:02:26 -04:00
Joffrey JAFFEUX
8f59f155fb
UI: makes topic count less visible in category drop ( #9938 )
2020-05-30 00:32:20 +02:00
Joffrey JAFFEUX
c5ccf5f93c
UI: removes font-weight: bold from category-drop names ( #9937 )
2020-05-30 00:06:35 +02:00
Joffrey JAFFEUX
03c3448b15
UX: better alignment of icons in notifications menu ( #9934 )
2020-05-29 22:48:47 +02:00
Joe
7a76f3c295
UX: Relocate before-topic-list outlet so it shows up on Top as well
2020-05-30 03:31:28 +08:00
Joe
8e6d95a309
DEV: adds a few plugin outlets required for themes ( #9929 )
2020-05-30 03:04:12 +08:00
Joffrey JAFFEUX
931bfca454
DEV: allows categories-admin-dropdown to have custom items ( #9931 )
...
Usage:
```
modifySelectKit("categories-admin-dropdown").appendContent(function() {
return {
id: "foo",
name: I18n.t("foo"),
description: I18n.t("foo_description"),
icon: "gear",
onChange: () => alert("Foo.")
};
});
```
2020-05-29 21:01:19 +02:00
Robin Ward
2b2434b82d
Start Discourse in an initializer ( #9930 )
...
* DEV: To be pedantic, there is more than EMBER in there now
* DEV: Use less globals. Have `Discourse` start in an initializer
* DEV: Remove another global
2020-05-29 14:37:02 -04:00
David Taylor
ecfce93f28
FIX: Support IRIs (unicode URIs) when pulling hotlinked images ( #9928 )
2020-05-29 17:47:05 +01:00
Robin Ward
3fe5eacd1b
DEV: Abstract Ember.testing so our application code doesn't use it
2020-05-29 12:16:58 -04:00
Robin Ward
e5cd331fb3
DEV: Why use a whole object when a functionw will do?
2020-05-29 11:56:45 -04:00
Mark VanLandingham
94cb5ab172
DEV: Remove unused variable topic_tracking_state ( #9915 )
2020-05-29 09:47:25 -05:00
David Taylor
28f46c171c
FIX: Pull hotlinked images even when edited by system users ( #9890 )
...
Previously the pull hotlinked images job was skipped after system edits. This ensured that we never had an infinite loop of system-edit/pull-hotlinked/system-edit/pull-hotlinked etc.
A side effect was that edits made by system for any other reason (e.g. API, removing full quotes) would prevent pulling hotlinked images. This commit removes the system edit check, and replaces it with another method to avoid an infinite job scheduling loop.
2020-05-29 13:07:47 +01:00
David Taylor
d29d69e10d
FIX: Invalidate database theme cache when hostname changes ( #9908 )
...
Hostname can vary per-site on a multisite cluster, so this change requires converting the compiler_version from a constant into a class method which is evaluated at runtime. The value is stored in the theme DistributedCache, so performance impact should be negligible.
2020-05-29 13:04:51 +01:00
Joffrey JAFFEUX
5d792483f0
UI: various select-kit dropdown tweaks/cleaning ( #9922 )
2020-05-29 11:11:28 +02:00
Guo Xiang Tan
81de592804
PERF: Use more efficient query when checking for existence.
2020-05-29 15:47:05 +08:00
Joffrey JAFFEUX
d7d5bb4454
UX: homogenises sk row padding and topic-admin-menu ( #9920 )
2020-05-29 09:35:43 +02:00
Joffrey JAFFEUX
4be45bec7e
UI: homogenise topic-footer-mobile-dropdown styles ( #9919 )
2020-05-29 08:34:19 +02:00
Joffrey JAFFEUX
31d1468922
UX: reworks various menus to homogenize them ( #9905 )
...
- bookmark modal menu
- topic-footer-mobile-dropdown
- post-admin-menu
- topic-admin-menu
- quick-access menus
- toolbar-popup-menu
2020-05-29 08:05:21 +02:00
Vinoth Kannan
ef5320dd47
FIX: don't rerender whole users page while typing on input.
2020-05-29 09:06:26 +05:30
Sam Saffron
2acec4370b
FIX: muted tags removed topics with no tags from counts
...
We previously did not account for completely untagged topics when
looking at muted tags, this caused new/unread counts to be off if
1. You had muted tags
2. You had an unread/new topic
3. This topic had no tags
2020-05-29 12:59:47 +10:00
Sam Saffron
136835370c
FEATURE: optionally allow tags in topic tracking state
...
This feature allows certain plugins to output tag information
to topic tracking state, this allows per tag stats which can be
used by sidebars and other plugins that need per tag stats
Not enabled by default cause this would add cost to a critical
query
2020-05-29 12:59:47 +10:00
Kris
c7d75bc3a0
Minor adjustment to menu-links-header spacing to avoid some wrapping
2020-05-28 18:40:22 -04:00
Jeff Wong
b6ff3b6a26
SECURITY: make find topic by slug adhere to SiteSetting.detailed_404 ( #9898 )
2020-05-28 13:54:10 -07:00
Vinoth Kannan
ce1491e830
UX: remove in:unpinned filter from advanced search page. ( #9911 )
2020-05-29 00:47:28 +05:30
Andrew Schleifer
74d28a43d1
new S3 backup layout ( #9830 )
...
* DEV: new S3 backup layout
Currently, with $S3_BACKUP_BUCKET of "bucket/backups", multisite backups
end up in "bucket/backups/backups/dbname/" and single-site will be in
"bucket/backups/".
Both _should_ be in "bucket/backups/dbname/"
- remove MULTISITE_PREFIX,
- always include dbname,
- method to move to the new prefix
- job to call the method
* SPEC: add tests for `VacateLegacyPrefixBackups` onceoff job.
Co-authored-by: Vinoth Kannan <vinothkannan@vinkas.com>
2020-05-29 00:28:23 +05:30
Jeff Wong
1509afefba
DEV: simplify detailed_404 logic
2020-05-28 10:54:02 -07:00
Penar Musaraj
a98182debf
UX: Fix activity column display in wizard homepage step
...
Followup to f8f281cdad
2020-05-28 11:24:24 -04:00
Roman Rizzi
a41476800b
FIX: Don't raise an exception if a topic cannot be retrieved ( #9906 )
2020-05-28 11:59:20 -03:00
Robin Ward
2033c3ec9c
Revert "Revert "DEV: Import MessageBus from message-bus-client instead of globals""
...
This reverts commit b10e995d9d
2020-05-28 08:42:36 -04:00
David Taylor
8a3d9d7036
DEV: Run jobs sequentially in test mode ( #9897 )
...
When running jobs in tests, we use `Jobs.run_immediately!`. This means that jobs are run synchronously when they are enqueued. Jobs sometimes enqueue other jobs, which are also executed synchronously. This means that the outermost job will block until the inner jobs have finished executing. In some cases (e.g. process_post with hotlinked images) this can lead to a deadlock.
This commit changes the behavior slightly. Now we will never run jobs inside other jobs. Instead, we will queue them up and run them sequentially in the order they were enqueued. As a whole, they are still executed synchronously. Consider the example
```ruby
class Jobs::InnerJob < Jobs::Base
def execute(args)
puts "Running inner job"
end
end
class Jobs::OuterJob < Jobs::Base
def execute(args)
puts "Starting outer job"
Jobs.enqueue(:inner_job)
puts "Finished outer job"
end
end
Jobs.enqueue(:outer_job)
puts "All jobs complete"
```
The old behavior would result in:
```
Starting outer job
Running inner job
Finished outer job
All jobs complete
```
The new behavior will result in:
```
Starting outer job
Finished outer job
Running inner job
All jobs complete
```
2020-05-28 12:52:27 +01:00
Guo Xiang Tan
8c86a109bb
DEV: Add ENV flag to test out ActiveRecord::Failover.
2020-05-28 16:24:22 +08:00
Joffrey JAFFEUX
0854785175
FIX: allows to define label/title properties for display instead of name
...
Usage:
```
const content = [{foo: "FOO", bar: "BAR", value: 1, name: "foo-bar"}];
{{combo-box
content=content
value=value
labelProperty="foo"
titleProperty="bar"
}}
```
2020-05-28 08:30:31 +02:00
Sam Saffron
ecc8e559ec
UX: remove edit PM button
...
Edit PM button leads to confusion and is uneeded
2020-05-28 15:15:27 +10:00
Kris
b9d9bbb95f
UX: More consistent alignment of topic timer's selected datetimes
2020-05-27 22:19:00 -04:00
Sam Saffron
9841569bba
Revert "DEV: Fix a deprecated ember import ( #9903 )"
...
This reverts commit 75f46ca632
2020-05-28 10:06:05 +10:00
Blake Erickson
b10e995d9d
Revert "DEV: Import MessageBus from message-bus-client instead of globals"
...
This reverts commit 9dddbcc00d
2020-05-27 16:14:09 -06:00
Blake Erickson
6548cd1a96
FIX: sending messages to groups with non-lowercase names
...
Fixes a regression in
e8fb9d4066https://meta.discourse.org/t/-/152999
2020-05-27 14:52:08 -06:00
Jarek Radosz
75f46ca632
DEV: Fix a deprecated ember import ( #9903 )
...
See the following for `Ember.testing` and `@ember/debug isTesting`:
* 8cf29959f7/packages/ember/index.js (L372-L376)8cf29959f7/packages/%40ember/debug/lib/testing.ts
2020-05-27 22:47:46 +02:00
Robin Ward
9dddbcc00d
DEV: Import MessageBus from message-bus-client instead of globals
2020-05-27 16:42:42 -04:00
Robin Ward
0f71d38d3a
Revert "DEV: Import MessageBus from message-bus-client instead of globals ( #9902 )"
...
This reverts commit d3bd482142
2020-05-27 16:34:30 -04:00
Robin Ward
d3bd482142
DEV: Import MessageBus from message-bus-client instead of globals ( #9902 )
2020-05-27 15:56:46 -04:00
Blake Erickson
a788427b46
FIX: broken query if upload id is missing ( #9900 )
...
Log warnings if there are any errors trying to upload group flair image
and ensure upload.id exists before trying to use it in a sql query.
2020-05-27 12:39:30 -06:00
Jeff Wong
a9d92f338e
SECURITY: make find topic by slug adhere to SiteSetting.detailed_404 ( #9898 )
2020-05-27 11:28:38 -07:00
Joffrey JAFFEUX
77801aa9be
FIX: allows to have custom emoji translation without static file ( #9893 )
2020-05-27 20:11:52 +02:00
Roman Rizzi
207b72ade1
UX: Don't show the suspension date if the user is permantently suspended. ( #9895 )
...
Use the same pattern used in user.hbs
2020-05-27 14:50:17 -03:00
Dan Ungureanu
570b12a903
FEATURE: Show a detailed 404 page for private topics ( #9894 )
2020-05-27 20:10:01 +03:00
Penar Musaraj
7bc496070f
UX: Keep focus on input after selecting an autocomplete option
...
This is particularly helpful on mobile, now tapping on an item from
the autocomplete dropdown keeps the keyboard visible.
2020-05-27 12:45:03 -04:00
Arpit Jalan
68fdfd76f5
fix the build
2020-05-27 22:06:45 +05:30
Arpit Jalan
8d2908dd9e
UX: do not show redundant user count
...
UX: add spacing between +member_count and "more"
2020-05-27 21:53:59 +05:30
Artem Vasiliev
12544c02c1
FIX: add X-Robots-Tag header for check_xhr-covered GET actions, too ( #9868 )
...
* FIX: add X-Robots-Tag header for check_xhr-covered GET actions, too
see https://meta.discourse.org/t/missing-x-robots-tag/152593/3 for context
* test: a spec making sure X-Robots-Tag header is present when needed
/groups path responds to anonymous requests and doesn't skip `check_xhr` method, so we can use it here.
2020-05-27 11:57:05 -04:00
Roman Rizzi
461df7d050
UX: Rename Priority to score for sorting. ( #9846 )
2020-05-27 12:50:28 -03:00
Blake Erickson
745d1de40c
SECURITY: Use FinalDestination for topic embeds
2020-05-27 09:31:15 -06:00
Blake Erickson
da839e6d26
SECURITY: Use FinalDestination for topic embeds
2020-05-27 09:26:09 -06:00
Régis Hanol
2a4db15544
FIX: don't send digests to users with no primary email
...
It might happen that some User records have no associated primary emails.
In which case we don't ever want to send them a digest.
Also added a new "user_email_no_email" skipped email log to ensure these cases
are properly handled and surfaced.
2020-05-27 17:09:40 +02:00
Arpit Jalan
2152e70e0d
DEV: annotate models
2020-05-27 19:05:24 +05:30
Joffrey JAFFEUX
f51093dde7
FIX: correctly set values and defaults for group-form-interaction-fields ( #9891 )
2020-05-27 12:10:27 +02:00
Joffrey JAFFEUX
1d685c22af
REVERT: removes translate_emoji ( #9889 )
...
This API is actually used in some plugins.
2020-05-27 12:08:24 +02:00
Sam Saffron
1cf2d1f9f2
FIX: when destroying a draft always ensure saving is done
...
There was a race condition where drafts could be either saving
or queued to be saved and a user canceled draft leading to destroying
it.
This cancels debounce save and waits for save in the pipeline to
be over prior to firing off a DELETE on the draft
2020-05-27 18:46:19 +10:00
Sam Saffron
f41fcad6c3
FIX: opening cancel draft dialog broke autosave
...
cancelComposer would leak a promise that never got resolved if
you aborted cancelling a composer.
This change ensured the promise will always be resolved
2020-05-27 18:16:48 +10:00
Sam Saffron
5bfb6830c9
SECURITY: missing security check prior to redirect
...
In some rare cases, if a user knows the exact title of a topic
they could possibly determine that it really exists in the system
2020-05-27 10:58:22 +10:00
Martin Brennan
2d534bf2e0
FIX: Pass current_user to TopicQuery in for categories_and_top_topics ( #9885 )
2020-05-27 10:05:06 +10:00
Krzysztof Kotlarek
34e5f0a9a3
Revert "FEATURE: notify admins about old credentials ( #9854 )" ( #9886 )
...
This reverts commit 349a67bee6
2020-05-27 09:52:53 +10:00
Kris
66ec634cb3
Composer whisper icon missing margin when editing replies
2020-05-26 19:17:09 -04:00
Jordan Vidrine
5f61deff80
FIX: updates variables for HTML to use em instead of px in font-size ( #9883 )
2020-05-26 17:48:35 -05:00
Krzysztof Kotlarek
349a67bee6
FEATURE: notify admins about old credentials ( #9854 )
...
* FEATURE: notify admins about old credentials
Security and API keys should be renewed periodically.
This additional notification should help admins keep their Discourse safe and secure.
2020-05-27 08:13:47 +10:00
Neil Lalonde
2c880b9bf9
FIX: wizard fails to start when default_theme_id is -1
2020-05-26 16:08:35 -04:00
Penar Musaraj
b1c726be0d
Remove support for FontAwesome 4.7 icon names ( #9871 )
2020-05-26 14:53:32 -04:00
Mark VanLandingham
7820686f73
FIX: Wizard previews if color step is excluded ( #9881 )
2020-05-26 12:56:36 -05:00
Joffrey JAFFEUX
675e9b81c6
FIX: document.activeElement can be null on IE11 ( #9880 )
2020-05-26 16:51:55 +02:00
Guo Xiang Tan
26c7fa2c29
FIX: rescue_from doesn't bubble up.
...
See a47e0c19e6/actionpack/lib/action_controller/metal/rescue.rb (L25)
2020-05-26 22:43:29 +08:00
Joffrey JAFFEUX
253a185769
FIX: makes focust text area after complete more resilient ( #9879 )
2020-05-26 16:27:02 +02:00
Bianca Nenciu
f47400475e
FEATURE: Send a private message when a group membership is accepted ( #9822 )
...
* FEATURE: Send a private message when a group membership is accepted
* DEV: Small code improvements
* FIX: Send PM as group owner
* Copy edits
2020-05-26 16:28:03 +03:00
Sam Saffron
76c4bc925d
DEV: followup to prev commit
...
337bd9a0f7
2020-05-26 16:19:05 +10:00
Sam Saffron
337bd9a0f7
FIX: concurrency bug when creating topic thumbnails
...
We were failing erratically when backfilling topic thumbnails.
This ensures that racing threads/processes will not conflict.
2020-05-26 16:10:22 +10:00
Osama Sayegh
2211581a85
FIX: Don't responde with error 500 if domain is invalid when adding automatic membership domain ( #9655 )
2020-05-26 15:40:09 +10:00
Arpit Jalan
5462fe9462
FIX: do not allow tag with name 'none' ( #9867 )
...
https://meta.discourse.org/t/none-tag-is-uneditable/152003
2020-05-26 08:15:45 +05:30
Guo Xiang Tan
878f06f1fe
DEV: Remove custom connection reaper.
...
Rails 6 fixed the reaper to use one thread to reap all the connection pools.
2020-05-26 09:09:46 +08:00
Sam Saffron
fc97f7e0e7
FIX: properly ban non human users from draft system
...
Previously we had a partial fix in place where non human users
were not allowed draft sequences, this left edges around where non
human users asked for drafts yet had none.
For example system could already have a few drafts in place.
This also removes and extensibility point we added that is not in use
2020-05-26 10:07:09 +10:00
Joffrey JAFFEUX
d9f915b195
FIX: documentation was using incorrect function ( #9876 )
2020-05-25 21:55:30 +02:00
Joffrey JAFFEUX
be16205118
DEV: plugin api should have been bumped for #8825395 ( #9874 )
2020-05-25 21:44:15 +02:00
Vinoth Kannan
5fb9271878
DEV: ignore flair_url column in group model. ( #9873 )
2020-05-26 00:43:50 +05:30
Joffrey JAFFEUX
8825395bdc
DEV: allows to decorate username selector ( #9869 )
...
Usage:
```
api.addUsernameSelectorDecorator(username => {
return iconHTML("calendar-alt");
});
```
2020-05-25 19:09:55 +02:00
Robin Ward
fd2d7ca992
FIX: Email Styles were evaluated out of order
...
`yield` puts the content in the template right away unless explicitly
`capture`'d.
2020-05-25 12:47:23 -04:00
Arpit Jalan
e8fb9d4066
FIX: when creating new PM username/groupname should be case-insensitive
...
(take 2)
https://meta.discourse.org/t/case-sensitivity-in-links-to-groupname/147596
https://meta.discourse.org/t/remove-case-sensitive-in-adding-users-to-a-message/151275
2020-05-25 21:34:05 +05:30
Arpit Jalan
302b37c805
Revert "FIX: when creating new PM username/groupname should be case-insensitive"
...
This reverts commit 2be79d94f5
2020-05-25 20:10:14 +05:30
Arpit Jalan
2be79d94f5
FIX: when creating new PM username/groupname should be case-insensitive
...
https://meta.discourse.org/t/case-sensitivity-in-links-to-groupname/147596
https://meta.discourse.org/t/remove-case-sensitive-in-adding-users-to-a-message/151275
2020-05-25 19:04:59 +05:30
Gerhard Schlager
631024ae5d
FEATURE: Permalinks for tags
2020-05-25 14:51:01 +02:00
Sam Saffron
48fb354bce
PERF: avoid traversing DOM in loadScript
...
Once a script is loaded operation should be very fast.
This optimisation avoids a DOM traverse and call to getURL on
every invocation.
2020-05-25 18:19:59 +10:00
Vinoth Kannan
505122bb45
FIX: skip onceoff job for groups with invalid flair URL.
2020-05-25 13:11:00 +05:30
Sam Saffron
c011b817b2
FIX: do not fallback to flair_url column
...
flair_url is not loaded by our query anymore so avoid falling back
to the old value
2020-05-25 16:25:42 +10:00
Vinoth Kannan
47c6fe9bfa
Merge branch 'master' of github.com:discourse/discourse
2020-05-25 11:36:18 +05:30
Bianca Nenciu
e31adef32d
FIX: Keep composer title and reply when switching to PM ( #9851 )
2020-05-25 15:46:02 +10:00
Vinoth Kannan
8e56197728
UX: use "icon-picker" & "image-uploader" fields to set group flair. ( #9779 )
2020-05-25 11:08:47 +05:30
Gerhard Schlager
13d5ccedf5
FIX: Destroying a user failed when it had title
...
...because updating the user caused a validation of the primary email and the UserEmail records are already deleted at that time.
2020-05-24 22:14:50 +02:00
Vinoth Kannan
6f03d14c23
FEATURE: category setting for default list filter.
2020-05-25 00:04:06 +05:30
Vinoth Kannan
058bf56b4c
FIX: group card not showing if user can't see its members.
2020-05-24 23:08:51 +05:30
Vinoth Kannan
60a3110113
FIX: call getURL method explicitly to prevent this context override.
2020-05-24 21:58:03 +05:30
Michael Brown
d9a02d1336
Revert "Revert "Merge branch 'master' of https://github.com/discourse/discourse ""
...
This reverts commit 20780a1eeee62a85cf2660c2e203d26cd6
2020-05-23 00:56:13 -04:00
Jeff Atwood
20780a1eee
Revert "Merge branch 'master' of https://github.com/discourse/discourse "
...
This reverts commit e62a85cf6f2660c2e21d
2020-05-22 20:25:56 -07:00
Blake Erickson
7f6a321fec
SECURITY: ensure embed_url contains valid http(s) uri
2020-05-22 15:15:44 -06:00
Blake Erickson
03d26cd6f0
SECURITY: ensure embed_url contains valid http(s) uri
2020-05-22 14:54:56 -06:00
Jordan Vidrine
bf8085e436
FIX: Double Button Alignment Mobile ( #9862 )
2020-05-22 13:33:29 -05:00
Joffrey JAFFEUX
06e1d430c1
FIX: better cross browser topic footer buttons alignment ( #9860 )
2020-05-22 17:03:22 +02:00
Roman Rizzi
671f882fa3
FIX: We don't create a Post object if the queued post gets rejected. We need to count review items directly. ( #9856 )
2020-05-22 11:50:28 -03:00
Mark VanLandingham
f9649c92b5
FIX: Live reloading of css in development ( #9859 )
2020-05-22 16:37:35 +02:00
Joffrey JAFFEUX
793085c703
REFACTOR: slightly cleaner topic admin button css ( #9858 )
2020-05-22 15:23:17 +02:00
Joffrey JAFFEUX
e71f5e8951
UI: apply margin only if the menu has content ( #9857 )
2020-05-22 15:19:55 +02:00
Martin Brennan
f9d55b4941
FEATURE: Update the topic excerpt when the OP is rebaked ( #9852 )
...
* We now have a site setting "topic_excerpt_maxlength" that is used when the OP is created or revised to generate a topic excerpt.
* However, posts created before this setting was introduced cannot benefit from this change unless they are revised, and if the topic excerpt length setting is changed that situation is also not covererd.
* This PR makes a change to rebake! to update the topic excerpt IF the post is the OP.
2020-05-22 13:04:15 +10:00
Martin Brennan
c0779df99d
FIX: Remove access control post FK from uploads ( #9853 )
2020-05-22 11:20:25 +10:00
Robin Ward
a55d5bd1b0
SECURITY: ERB execution in custom Email Style
2020-05-21 14:49:06 -04:00
Robin Ward
d11c462104
SECURITY: ERB execution in custom Email Style
2020-05-21 14:48:30 -04:00
Neil Lalonde
5a71c51ddd
FIX: tag input says tags are optional when they're required
2020-05-21 12:40:33 -04:00
Mark VanLandingham
1a5bcf2a64
UX: Remove live theme previewing in favor of refresh ( #9798 )
2020-05-21 08:32:50 -05:00
Joffrey JAFFEUX
66960563ea
FIX: ensures category chooser is case insensitive ( #9850 )
2020-05-21 11:16:44 +02:00
Joffrey JAFFEUX
7b6fbe9af2
FIX: adds missing tags to published page header ( #9835 )
2020-05-21 11:04:23 +02:00
Arpit Jalan
18959ff9da
UX: user name instead username for profile link title
2020-05-21 14:02:12 +05:30
Arpit Jalan
3c9212fd88
UX: add title for user profile link
2020-05-21 13:00:05 +05:30
Martin Brennan
df68d11c38
FEATURE: Add topic excerpt max length site setting ( #9847 )
...
Adds a new topic_excerpt_maxlength site setting.
* When topic excerpt is requested for a post, use the new topic_excerpt_maxlength site setting to limit the size of the excerpt
* Remove code for getting/setting Post.excerpt_size as it is not used anywhere
2020-05-21 13:19:48 +10:00
Guo Xiang Tan
68db5deaec
FIX: Badge granter was disabled by default.
2020-05-21 06:55:22 +08:00
Kris
62ecb2885f
glob @import desktop and mobile scss
2020-05-20 18:05:27 -04:00
Roman Rizzi
234933c781
FIX: Show staff counters if the rejected posts count is the only value to show ( #9845 )
2020-05-20 19:00:35 -03:00
Kris
eef47a26d9
UX: More consistent mobile banner/alert styles, css cleanup
2020-05-20 17:17:47 -04:00
Robin Ward
096eca0ee8
FIX: Requests were not being logged correctly
...
`enable` was defaulting to `nil` which is not what we wanted.
2020-05-20 15:09:17 -04:00
Robin Ward
ba04bb7552
FIX: Path should be addon not app
2020-05-20 12:13:15 -04:00
Robin Ward
3062036f2f
FIX: Allow deprecation to work with Ember CLI
2020-05-20 12:05:56 -04:00
Régis Hanol
8851b79472
DEV: less code for Category#url
2020-05-20 18:01:06 +02:00
Robin Ward
09ca75d17e
FIX: select-kit was in the wrong place
...
`app/` means we want to merge it into our application there. `addon`
means give it its own module namespace, which is what we wanted.
2020-05-20 11:51:49 -04:00
Jordan Vidrine
8e7efb48ae
FIX: Update default_template.html
2020-05-20 10:39:04 -05:00
Robin Ward
6c9c8dfefd
FIX: guidFor is not part of Ember.Object
2020-05-20 11:31:11 -04:00
Mark VanLandingham
bd57ae83f1
DEV: Guardian for hiding about stats ( #9841 )
2020-05-20 10:26:20 -05:00
Joffrey JAFFEUX
30631a963f
UX: moves editFirstPost in taggable Pms in dropdown on mobile ( #9840 )
2020-05-20 14:07:00 +02:00
Bianca Nenciu
fb15da43da
Remove old web hooks in favor of 'reviewable' web hook ( #9776 )
...
* FIX: Emit web hooks for flags
* FEATURE: Remove 'flag' web hook in favor of 'reviewable' web hook
* FEATURE: Remove 'queued post' web hook in favor of 'reviewable' web hook
* FIX: Do not set a default value for web hooks with no events
2020-05-20 12:07:48 +03:00
Guo Xiang Tan
f7f436e536
DEV: Install rails_failover gem to test our Redis changes.
2020-05-20 15:40:27 +08:00
Sam Saffron
e97cb20c2a
UX: strip text from PM bookmark and share buttons
...
Also organize priorities in an easier to reason about way and
shift bookmark topic so it is after link. (consistent with posts)
2020-05-20 16:46:49 +10:00
Guo Xiang Tan
234cd5c3e7
FIX: Switch discobot to pull avatar from gravatar.
2020-05-20 10:20:08 +08:00
Sam Saffron
6b92c78033
FIX: purge all associated data on user delete
...
This commit reorganises the delete dependencies on users and make sure
all are covered. We forgot some on bookmarks, security keys, anon users
and so on.
2020-05-20 11:27:57 +10:00
Kris
a93d0a8fcc
UX: Remove bold from category badge text
2020-05-19 21:11:49 -04:00
Roman Rizzi
52228b1fa6
DEV: These routes don't exist anymore ( #9823 )
2020-05-19 16:09:03 -03:00
Joffrey JAFFEUX
a239900522
UI: reduces category row description margin ( #9834 )
2020-05-19 20:44:54 +02:00
Joffrey JAFFEUX
05d8091bd3
DEV: adds triggerOnChangeOnTab option to select-kit ( #9833 )
...
Usage:
```
options=(hash triggerOnChangeOnTab=false)
```
This will prevent to select the row when pressing tab.
2020-05-19 20:39:29 +02:00
Joffrey JAFFEUX
ab6737c44a
UX: improves topic-notifications-button loading behavior ( #9832 )
2020-05-19 17:13:40 +02:00
Arpit Jalan
f038f8f154
FIX: description for 'uncategorized' category was blank
2020-05-19 18:45:43 +05:30
Joffrey JAFFEUX
7c3663ff73
UX: adds visual feedback when changing topic notifications level ( #9831 )
2020-05-19 13:27:57 +02:00
Dan Ungureanu
05ca0c908f
FIX: GroupArchivedMessage belongs to Group, not User
2020-05-19 14:13:28 +03:00
David Taylor
725e38f9d7
DEV: Allow plugins to request topic thumbnail sizes ( #9828 )
...
In plugin.rb, you can register new sizes like
```
register_topic_thumbnail_size [512, 512]
```
For more information about thumbnails see 03818e642a
2020-05-19 10:38:58 +01:00
Joffrey JAFFEUX
1647ba4624
FIX: applies flex on topic-footer-main-buttons ( #9829 )
2020-05-19 11:29:38 +02:00
Joffrey JAFFEUX
3623a395dc
UI: refinements to topic footer buttons ( #9780 )
2020-05-19 09:51:34 +02:00
Guo Xiang Tan
062cb1e1cb
UX: Remove caret from notifications-button.
2020-05-19 13:41:13 +08:00
Kris
864fb45ff0
Improve mobile friendliness of crawler view
2020-05-19 00:24:17 -04:00
Gerhard Schlager
6d5e9db883
FIX: Restoring backup didn't clear cached translation overrides
2020-05-18 18:51:51 +02:00
Gerhard Schlager
27c611b1d1
FIX: Reverting multiple translation overrides didn't clear cache
2020-05-18 18:51:29 +02:00
Joffrey JAFFEUX
cfad38184d
FIX: improves and fixes a regression with category-selector ( #9821 )
2020-05-18 17:44:47 +02:00
David Taylor
96848b7649
UX: Allow secure media URLs to be cached for a short period of time
...
Signed S3 URLs are valid for 15 seconds, so we can safely allow the browser to cache them for 10 seconds. This should help with large numbers of requests when composing a post with many images.
2020-05-18 15:00:41 +01:00
Joffrey JAFFEUX
1876b3cc4c
FIX: more resilient/consistent date-picker loading ( #9817 )
2020-05-18 15:29:24 +02:00
Joffrey JAFFEUX
48ed1b40cf
REFACTOR: ensures later is correctly canceled ( #9796 )
2020-05-18 14:20:23 +02:00
Joffrey JAFFEUX
9482ddff73
UX: show caret only in topic footer buttons dropdown select boxes ( #9816 )
2020-05-18 14:07:40 +02:00
David Taylor
f968155288
FIX: Ensure no image downloads during topic thumbnail serialization
...
If image uploads are missing a width/height, we re-download them to update the width/height in the database. However, this takes significant resources so we don't want to run this logic during topic serialization.
2020-05-18 12:04:29 +01:00
Joffrey JAFFEUX
918bd75909
FIX: allows to remove a topic timer with delete_replies as type ( #9800 )
2020-05-18 11:47:08 +02:00
Guo Xiang Tan
d01c336899
DEV: Clean up some Redis leaks in test env.
2020-05-18 17:27:37 +08:00
Joffrey JAFFEUX
320b21ab5b
UX: allows dropdown-select-box to display a caret ( #9803 )
...
```
selectKitOptions: {
showCaret: true // default false
}
```
2020-05-18 10:50:33 +02:00
Joffrey JAFFEUX
e5dc843185
FIX: ensures hide is called when card is destroyed ( #9814 )
2020-05-18 10:10:40 +02:00
Joffrey JAFFEUX
e81a4048e3
REFACTOR: s/focusAfterOnchange/focusAfterOnChange ( #9801 )
2020-05-16 11:20:37 +02:00
Robin Ward
db8e872bda
DEV: Move select kit to an addon ( #9797 )
2020-05-15 16:07:35 -04:00
Alan Guo Xiang Tan
7f07c513a7
FIX: Switching composer action does not refresh composer actions content ( #9791 )
2020-05-15 13:54:44 -04:00
Robin Ward
6b04760572
FIX: Component was still used by data explorer
2020-05-15 13:52:03 -04:00
David Taylor
eee20a9814
FIX: Include plugin CSS assets when previewing themes
2020-05-15 18:12:53 +01:00
