Mark VanLandingham
737e8bdb2c
FIX: Prettier on iframed-html component ( #9062 )
2020-02-27 11:57:18 -06:00
Mark VanLandingham
df70b9118e
Merge pull request from GHSA-vw39-6w7q-gfx5
...
Co-authored-by: Robin Ward <robin.ward@gmail.com>
2020-02-27 11:57:10 -06:00
Neil Lalonde
4d611dcaed
Merge diffs from master
2020-02-25 17:23:37 -05:00
Neil Lalonde
52c10848bc
Merge master
2020-02-25 17:21:37 -05:00
David Taylor
96ac4fc072
FIX: Include .json
suffix for email login route ( #9041 )
...
In IE11, the browser returns the cached HTML response, rather than the JSON formatted response. Adding the `.json` suffix ensures that the cache is not shared. Same root cause as b0211772
2020-02-25 18:01:33 +00:00
Dan Ungureanu
514c22e64b
FIX: Make reviewable claiming work with deleted topics ( #9040 )
...
This fixes the case when the reviewed topic is deleted (for example, in
discourse-akismet).
2020-02-25 15:49:23 +02:00
Joffrey JAFFEUX
bd49368942
FIX: ensures topic count is correctly showing in box category badges ( #9034 )
2020-02-24 23:41:36 +01:00
Penar Musaraj
d6a603cc50
FIX: Translate none-tag and all-tags labels in tag filter ( #9030 )
...
* FIX: Translate none-tag and all-tags labels in tag filter
* Add test
2020-02-25 07:57:24 +11:00
Joffrey JAFFEUX
f336aeee6f
FIX: ensures scoped search category is searching in all categories ( #9031 )
2020-02-24 19:19:53 +01:00
Joffrey JAFFEUX
0ea11a9d49
FIX: ensures we don't attempt to create a new PM on an existing topic ( #9029 )
...
This fix attempts to both fix it at UI level and server side. A previous attempt related to this behavior has been made in commit: 49c750ca78
2020-02-24 08:55:12 -06:00
Joffrey JAFFEUX
69a2ad626b
FIX: ensures group automatic membership dropdown works ( #9022 )
...
This commit also fixes a deprecation warning as the previous component was overriding a computed property from the group model.
Finally a test has been added as this is the only place where we use list-setting outside of the settings, this was highly subject to regressions.
2020-02-21 22:14:24 +01:00
Joffrey JAFFEUX
0b0290cddb
FIX: muted was not working in topic timeline ( #9021 )
2020-02-21 21:32:58 +01:00
Dan Ungureanu
533495169e
FEATURE: Publish a message when reviewable claimer changes ( #9019 )
...
This commit ensures that all users are kept in sync and no user can claim
a topic that has been claimed already.
2020-02-21 19:11:50 +02:00
Jarek Radosz
6ba326a9f4
DEV: Deprecate ember
module imports ( #9011 )
...
Removes remaining `ember` module imports.
2020-02-21 15:56:49 +01:00
Jarek Radosz
c607870f08
DEV: Add more @ember
imports ( #9012 )
2020-02-21 14:27:04 +01:00
Joffrey JAFFEUX
cb69e89d7c
FIX: correctly shows suggested topics label ( #9017 )
2020-02-21 12:35:49 +01:00
Joffrey JAFFEUX
e807dff6fc
FIX: ensures mini-tag-chooser is respecting max_tags_per_topic ( #9018 )
2020-02-21 12:16:05 +01:00
Vinoth Kannan
8a031f19dc
FIX: use dedicated site attribute in category + tag filtered pages too.
2020-02-21 15:55:17 +05:30
Martin Brennan
3af2670bd5
FIX: Consider webp a supported image format for upload ( #9015 )
...
* Also fixes an issue where if webp was a downloaded hotlinked
image and then secure + sent in an email, it was not being
redacted because webp was not a supported media format in
FileHelper
* Webp originally removed as an image format in
https://github.com/discourse/discourse/pull/6377
and there was a spec to make sure a .bin webp
file did not get renamed from its type to webp.
However we want to support webp images now to make
sure they are properly redacted if secure media is
on, so change the example in the spec to use tiff,
another banned format, instead
2020-02-21 13:08:01 +10:00
David Taylor
19dcc6bb7b
FIX: Restore initState() call within discourse-location for subfolder
...
d7d4612b2d
removed the duplicate call to initState(). However, we are relying on a side effect of the duplicate call for subfolder sites to function correctly when accessed without a trailing slash. To avoid a large refactor before the stable release, this commit restores the old behavior.
Long term we should look at migrating to Ember's built-in location library, rather than maintaining our own (very similar) version
https://github.com/emberjs/ember.js/blob/master/packages/%40ember/-internals/routing/lib/location/history_location.ts
2020-02-20 16:41:50 +00:00
Dan Ungureanu
20b90afad9
FIX: Remove broken error dismiss button
2020-02-19 23:03:52 +02:00
Kris
2a7f53065d
FEATURE: Add plugin outlet below login/create, add outlet to mobile
2020-02-19 14:08:35 -05:00
David Taylor
8ec2d8a814
FIX: Disable save button for API key creation when invalid ( #9005 )
2020-02-19 16:33:09 +00:00
Kris
de559f3fe3
FIX: Remove border-box from modal-body to avoid iOS fixed position bug
2020-02-19 11:08:15 -05:00
Robin Ward
c954d083df
Link website when reviewing users
2020-02-19 10:18:05 -05:00
Joffrey JAFFEUX
74f2d48018
FIX: makes setting-object capable of defining value/name properties itself ( #9003 )
2020-02-19 10:01:21 +01:00
Joffrey JAFFEUX
30e2867547
FIX: prevents setting default values on setting component to reload page
...
This would happen when clicking on "add all themes" for example.
2020-02-19 09:04:57 +01:00
jjaffeux
32b3f55ef6
Revert "FIX: enums should be treated as flat arrays ( #8995 )"
...
This reverts commit 05be9beefd
.
2020-02-19 07:53:29 +01:00
Jarek Radosz
9f8a27a132
DEV: Import makeArray
from discourse-common
instead using Ember
global ( #8977 )
2020-02-19 00:57:58 +01:00
Joffrey JAFFEUX
25ebfd5998
DEV: allows to import isPresent ( #8993 )
2020-02-18 23:41:15 +01:00
Joffrey JAFFEUX
05be9beefd
FIX: enums should be treated as flat arrays ( #8995 )
2020-02-18 23:25:12 +01:00
Joffrey JAFFEUX
67ee79f023
FIX: group members dropdown was broken on mobile ( #8994 )
2020-02-18 23:23:38 +01:00
Vinoth Kannan
7a054fc142
FIX: remove anchors from banner headings.
...
Else it will create UX issues when the banner is visible on top of the banner topic.
2020-02-19 02:55:04 +05:30
Robin Ward
041168c9b6
FIX: Group mentions were not being cooked the same was as previewed
...
If a group mention could be notified on preview it was given an `<a>`
tag with the `.notify` class. When cooked it would display differently.
This patch makes the server side cooking match the client preview.
2020-02-18 15:45:02 -05:00
Joffrey JAFFEUX
99746c2850
FIX: ensures report-filter/category is correctly filtering ( #8992 )
2020-02-18 17:37:43 +01:00
Vinoth Kannan
2e397c78c4
FIX: use separate site attribute for single category "top tags" list.
...
And use it only in the single category pages.
38dd184a16
2020-02-17 21:09:27 +05:30
David Taylor
f1f9648e88
Revert "FIX: sk body should follow wrapper width ( #8984 )"
...
This was causing very narrow dropdowns in the composer and notification level dropdowns.
This reverts commit d33aaa0292
.
2020-02-17 13:10:26 +00:00
Joffrey JAFFEUX
d33aaa0292
FIX: sk body should follow wrapper width ( #8984 )
2020-02-17 10:39:20 +01:00
Joffrey JAFFEUX
9feace3388
FIX: prevents error when loading tag groups ( #8983 )
2020-02-17 10:39:04 +01:00
Joffrey JAFFEUX
d827430ea6
FIX: prevents expand post to trigger page routing ( #8982 )
2020-02-17 10:06:38 +01:00
Kris
f81bebf93f
UX: Cap staff action detail height
2020-02-14 14:23:31 -05:00
Roman Rizzi
99305511bc
DEV: Remove unused BreakString class ( #8942 )
2020-02-14 15:32:59 -03:00
Robin Ward
d51107e2c9
FIX: If a group is unmentionable, don't render it as mentionable
...
Now if a group is visible but unmentionable, users can search for it
when composing by typing with `@`, but it will be rendered without the
grey background color.
It will also no longer pop up a JIT warning saying "You are about to
mention X people" because the group will not be mentioned.
2020-02-14 12:29:56 -05:00
Penar Musaraj
ea0f20e331
DEV: Concatenate value-list choices array
...
Followup to 89d9704194
2020-02-14 11:33:17 -05:00
Penar Musaraj
89d9704194
FIX: value-list choices when removing a value
...
Fixes an issue where choices were broken when removing an item from the value-list component.
Adds test case for this scenario.
2020-02-14 11:21:06 -05:00
Joffrey JAFFEUX
7d94de6439
FIX: brings back castInteger as a safer migration path for sk2 ( #8966 )
2020-02-14 10:00:39 +01:00
Vinoth Kannan
38dd184a16
FIX: update Site.top_tags
in "categories" route if topic list available.
...
Else it is not updating the tags dropdown while navigate between the category pages.
2020-02-14 09:53:41 +05:30
Joffrey JAFFEUX
149196b9ce
FIX: displays selection text when no default_notification_level is set ( #8962 )
2020-02-13 23:45:03 +01:00
Joffrey JAFFEUX
6405159484
FEATURE: adds a new plugin api to decorate plugin outlets ( #8937 )
...
```
api.decoratePluginOutlet(
"discovery-list-container-top",
elem => {
if (elem.classList.contains("foo")) {
elem.style.backgroundColor = "yellow";
}
}
);
```
2020-02-13 23:44:34 +01:00
Gerhard Schlager
a7efca1fa9
DEV: Remove unused "search help"
2020-02-13 18:31:21 +01:00