Alan Guo Xiang Tan
773b22e8d0
DEV: Seperate concerns of tracking GC stat from MethodProfiler ( #22921 )
...
Why this change?
This is a follow up to e8f7b62752
2023-08-02 10:46:37 +08:00
Alan Guo Xiang Tan
e8f7b62752
DEV: Add site setting to allow collection of GC stats during requests ( #22898 )
...
What does this change do?
This change adds a hidden `track_gc_stat_per_request` site setting which
when enabled will track the time spent in GC, major GC count and minor
GC count during a request.
Why is this change needed?
We have plans to tune our GC in production but without any
instrumentation, we will not be able to know if our tuning is effective
or not. This commit takes the first step at instrumenting some basic GC
stats in core during a request which can then be consumed by the discourse-prometheus plugin.
2023-08-02 09:16:32 +08:00
dependabot[bot]
e88452a247
Build(deps): Bump handlebars in /app/assets/javascripts ( #22919 )
...
Bumps [handlebars](https://github.com/handlebars-lang/handlebars.js ) from 4.7.7 to 4.7.8.
- [Release notes](https://github.com/handlebars-lang/handlebars.js/releases )
- [Changelog](https://github.com/handlebars-lang/handlebars.js/blob/v4.7.8/release-notes.md )
- [Commits](https://github.com/handlebars-lang/handlebars.js/compare/v4.7.7...v4.7.8 )
---
updated-dependencies:
- dependency-name: handlebars
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-08-02 01:07:36 +02:00
dependabot[bot]
cd90deb4bd
Build(deps-dev): Bump sass in /app/assets/javascripts ( #22918 )
...
Bumps [sass](https://github.com/sass/dart-sass ) from 1.64.1 to 1.64.2.
- [Release notes](https://github.com/sass/dart-sass/releases )
- [Changelog](https://github.com/sass/dart-sass/blob/main/CHANGELOG.md )
- [Commits](https://github.com/sass/dart-sass/compare/1.64.1...1.64.2 )
---
updated-dependencies:
- dependency-name: sass
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-08-02 01:06:41 +02:00
Isaac Janzen
ecd9e6d4b7
DEV: Convert watched-word-test modal to component-based API ( #22911 )
2023-08-01 16:08:56 -05:00
Isaac Janzen
7c8b0b9869
DEV: Convert delete-user-posts-progress modal to component-based API ( #22916 )
...
https://github.com/discourse/discourse/assets/50783505/414ffcc5-06e9-470f-b160-83b4c12bbb96
2023-08-01 15:49:26 -05:00
Roman Rizzi
514f5d25e6
FIX: Default to the first list if the preferred one is empty ( #22915 )
2023-08-01 17:01:00 -03:00
Isaac Janzen
da6ddb638f
DEV: Convert api-key-urls modal to component-based API ( #22913 )
...
<img width="474" alt="Screenshot 2023-08-01 at 1 29 26 PM" src="https://github.com/discourse/discourse/assets/50783505/1a46901f-8231-46fb-8c36-cb441b7fd883 ">
2023-08-01 14:51:18 -05:00
Daniel Waterworth
50d527b80c
DEV: Remove db_timeout setting ( #22912 )
...
It doesn't actually do anything.
2023-08-01 14:17:43 -05:00
David Taylor
945bb9161f
UX: Do not scroll-top for aborted transitions ( #22744 )
...
We only want to scroll to the top for successful transitions. If a transition is aborted (e.g. when clicking a chat link when chat is in drawer mode) then we should maintain the existing scroll location.
2023-08-01 18:44:25 +01:00
David Taylor
2c4faf48f9
DEV: Fix ember-cli proxy assets ( #22674 )
...
We were proxying all `/assets/*` requests through to the origin. In local development that was fine, because Rails was able to serve files from the `dist/` directory. But when proxying to a remote origin, we want the local ember-cli to serve its own JS assets
2023-08-01 18:43:33 +01:00
Roman Rizzi
a418dce1aa
FIX: Display similar topics for anons on mobile. ( #22907 )
...
We never propagated the preference change because of the early return, meaning lists listening to it never got to decide if they had to remain hidden.
Also, we don't want to track the preference when there's a single list, as the user didn't choose to see it.
2023-08-01 13:34:02 -03:00
Isaac Janzen
ed000be722
DEV: Convert merge-users modals to component-based API ( #22727 )
2023-08-01 10:35:36 -05:00
Rafael dos Santos Silva
5be658849b
UX: Fixes for new related topic styles ( #22906 )
2023-08-01 11:57:29 -03:00
Discourse Translator Bot
d5f4b8e02c
Update translations ( #22904 )
2023-08-01 16:05:44 +02:00
Isaac Janzen
542b3ffc32
DEV: Convert change-timestamp modal to component-based API ( #22832 )
2023-08-01 08:52:03 -05:00
Isaac Janzen
6b9e208612
DEV: Convert download-calendar modal to component-based API ( #22837 )
2023-08-01 08:50:52 -05:00
Isaac Janzen
6c8af90f5d
DEV: Convert start-backup modal to component-based API ( #22812 )
2023-08-01 08:40:25 -05:00
Isaac Janzen
106a0498f1
DEV: Convert convert-to-public-topic modal to component-based API ( #22835 )
2023-08-01 08:18:03 -05:00
Isaac Janzen
99e05b1280
DEV: Convert edit-slow-mode modal to component-based API ( #22840 )
...
<img width="772" alt="Screenshot 2023-07-28 at 1 41 18 PM" src="https://github.com/discourse/discourse/assets/50783505/9e97c4c8-af29-4e56-80dc-4f0244e2c4db ">
2023-08-01 08:17:49 -05:00
dependabot[bot]
4191b631bf
Build(deps): Bump rack-mini-profiler from 3.1.0 to 3.1.1 ( #22903 )
...
Bumps [rack-mini-profiler](https://github.com/MiniProfiler/rack-mini-profiler ) from 3.1.0 to 3.1.1.
- [Release notes](https://github.com/MiniProfiler/rack-mini-profiler/releases )
- [Changelog](https://github.com/MiniProfiler/rack-mini-profiler/blob/master/CHANGELOG.md )
- [Commits](https://github.com/MiniProfiler/rack-mini-profiler/compare/v3.1.0...v3.1.1 )
---
updated-dependencies:
- dependency-name: rack-mini-profiler
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-08-01 13:38:01 +01:00
dependabot[bot]
00d99ab24d
Build(deps): Bump sass-embedded from 1.64.1 to 1.64.2 ( #22902 )
...
Bumps [sass-embedded](https://github.com/ntkme/sass-embedded-host-ruby ) from 1.64.1 to 1.64.2.
- [Commits](https://github.com/ntkme/sass-embedded-host-ruby/compare/v1.64.1...v1.64.2 )
---
updated-dependencies:
- dependency-name: sass-embedded
dependency-type: indirect
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-08-01 14:23:44 +02:00
Gerhard Schlager
ad0b8aed51
FIX: Use category hashtag instead of link in discourse_welcome_topic.body ( #22875 )
...
Linking to the #feedback category can break if the category gets renamed or a different site locale is used. By using the correct hashtag (at the time of seeding) this issues can be avoided.
2023-08-01 13:53:23 +02:00
David Taylor
20481abefc
Bump version to v3.2.0.beta1-dev
2023-08-01 09:50:46 +01:00
David Taylor
9b339bcd2c
Bump version to v3.1.0.beta8
2023-08-01 09:50:45 +01:00
David Taylor
bb217bbcc8
FIX: Ensure PresenceChannel does not raise error during readonly ( #22899 )
...
PresenceChannel configuration is cached using redis. That cache is used, and sometimes repopulated, during normal GET requests. When the primary redis server was readonly, that `redis.set` call would raise an error and cause the entire request to fail. Instead, we should ignore the failure and continue without populating the cache.
2023-08-01 09:34:57 +01:00
Martin Brennan
6286e790b2
DEV: Remove unread_private_messages and deprecation ( #22893 )
...
This was added all the way back in 2020 in b79ea986ac
2023-08-01 14:44:39 +10:00
Roman Rizzi
dd8d89d9c8
UX: Use full width when displaying a single recommendations list. ( #22896 )
2023-08-01 13:49:24 +10:00
dependabot[bot]
6a9726e252
Build(deps-dev): Bump webdrivers from 5.2.0 to 5.3.1 ( #22886 )
...
Bumps [webdrivers](https://github.com/titusfortner/webdrivers ) from 5.2.0 to 5.3.1.
- [Release notes](https://github.com/titusfortner/webdrivers/releases )
- [Changelog](https://github.com/titusfortner/webdrivers/blob/main/CHANGELOG.md )
- [Commits](https://github.com/titusfortner/webdrivers/compare/v5.2.0...v5.3.1 )
---
updated-dependencies:
- dependency-name: webdrivers
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-08-01 10:56:04 +08:00
dependabot[bot]
85a9b358a8
Build(deps-dev): Bump rubocop-rspec from 2.22.0 to 2.23.0 ( #22867 )
...
Bumps [rubocop-rspec](https://github.com/rubocop/rubocop-rspec ) from 2.22.0 to 2.23.0.
- [Release notes](https://github.com/rubocop/rubocop-rspec/releases )
- [Changelog](https://github.com/rubocop/rubocop-rspec/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop-rspec/compare/v2.22.0...v2.23.0 )
---
updated-dependencies:
- dependency-name: rubocop-rspec
dependency-type: indirect
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-08-01 10:55:25 +08:00
dependabot[bot]
6db82ad898
Build(deps): Bump rexml from 3.2.5 to 3.2.6 ( #22843 )
...
Bumps [rexml](https://github.com/ruby/rexml ) from 3.2.5 to 3.2.6.
- [Release notes](https://github.com/ruby/rexml/releases )
- [Changelog](https://github.com/ruby/rexml/blob/master/NEWS.md )
- [Commits](https://github.com/ruby/rexml/compare/v3.2.5...v3.2.6 )
---
updated-dependencies:
- dependency-name: rexml
dependency-type: indirect
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-08-01 10:55:05 +08:00
Alan Guo Xiang Tan
18358c448c
DEV: Assert that user has been signed in successfully in system tests ( #22892 )
...
We have seen instances where the user has not been signed in but we need
more debugging information to know why.
Exmaple where test fails due to user not being signed in https://github.com/discourse/discourse/actions/runs/5718655343/job/15494917165
2023-08-01 09:06:56 +08:00
Jarek Radosz
a83c1d8f60
DEV: Fix a flaky quote post spec ( #22891 )
2023-08-01 00:48:40 +02:00
Kris
6bf0c0a52e
UX: fix long image titles in experimental lightbox ( #22883 )
2023-07-31 18:36:33 -04:00
dependabot[bot]
03bc9b2569
Build(deps): Bump rack from 2.2.7 to 2.2.8 ( #22888 )
...
Bumps [rack](https://github.com/rack/rack ) from 2.2.7 to 2.2.8.
- [Release notes](https://github.com/rack/rack/releases )
- [Changelog](https://github.com/rack/rack/blob/main/CHANGELOG.md )
- [Commits](https://github.com/rack/rack/compare/v2.2.7...v2.2.8 )
---
updated-dependencies:
- dependency-name: rack
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-08-01 00:33:29 +02:00
dependabot[bot]
1fd04b2546
Build(deps-dev): Bump rouge from 4.1.2 to 4.1.3 ( #22889 )
...
Bumps [rouge](https://github.com/rouge-ruby/rouge ) from 4.1.2 to 4.1.3.
- [Release notes](https://github.com/rouge-ruby/rouge/releases )
- [Changelog](https://github.com/rouge-ruby/rouge/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rouge-ruby/rouge/compare/v4.1.2...v4.1.3 )
---
updated-dependencies:
- dependency-name: rouge
dependency-type: indirect
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-08-01 00:33:06 +02:00
dependabot[bot]
d2f7df3bd2
Build(deps): Bump oj from 3.15.0 to 3.15.1 ( #22885 )
...
Bumps [oj](https://github.com/ohler55/oj ) from 3.15.0 to 3.15.1.
- [Changelog](https://github.com/ohler55/oj/blob/develop/CHANGELOG.md )
- [Commits](https://github.com/ohler55/oj/compare/v3.15.0...v3.15.1 )
---
updated-dependencies:
- dependency-name: oj
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-08-01 00:18:18 +02:00
Roman Rizzi
e7fb4be23e
UX: Topic recommendations tweaks. ( #22880 )
...
This PR updates how we display related and suggested topics on mobile and desktop. It adds a new `PluginOutlet` specifically designed for adding new topic lists, which automatically work if following the same conventions as the ones inside `<MoreTopics />`.
While we display lists side by side on desktop, we only display one in mobile. You can switch to another one by clicking on the nav pills, and we'll automatically save your preference for next time.
2023-07-31 18:33:21 -03:00
Penar Musaraj
318bdbdb46
DEV: Cleanup onebox spec discourse topic fixtures ( #22881 )
2023-07-31 15:09:47 -04:00
Penar Musaraj
26a8e7da28
DEV: Remove redundant case in import script ( #22882 )
2023-07-31 14:52:06 -04:00
David Taylor
7ecaf6295d
DEV: Correctly strip sourcemap URL from splash-screen js ( #22879 )
...
In e1d27400f5
2023-07-31 16:49:27 +01:00
David Taylor
8a0d00b866
DEV: Introduce version_bump rake tasks ( #22817 )
...
This commit introduces five rake tasks to help us with version bump procedures:
- `version_bump:beta` and `version_bump:minor_stable` are for our minor releases
- `version_bump:major_stable_prepare` and `version_bump:major_stable_merge` are for our major release process
- `version_bump:stage_security_fixes` is to collate multiple security fixes from private branches into a single branch for release
The scripts will stage the necessary commits in a branch and prompt you to create a PR for review. No changes to release branches or tags will be made without the PR being approved, and explicit confirmation of prompts in the scripts.
To avoid polluting the operator's primary working tree, the scripts create a temporary git worktree in a temporary directory and perform all checkouts/commits there.
2023-07-31 16:05:13 +01:00
Bianca Nenciu
a68752df25
UX: Move Admin Guide link to URL ( #22789 )
...
Co-authored-by: David Taylor <david@taylorhq.com>
Co-authored-by: Jarek Radosz <jradosz@gmail.com>
2023-07-31 15:30:27 +01:00
David Taylor
6e8e3c3151
FIX: Validate page/limit params for directory, user-badges and groups ( #22877 )
...
We'll now return a 400 error instead of 500. 400 is a better description of the issue, and also avoids creating unnecessary noise in the logs.
2023-07-31 15:00:05 +01:00
chapoi
984dd89cb4
Revert "UX: fix alignment extra buttons in post controls" ( #22876 )
...
This reverts commit 507551ea73
2023-07-31 14:46:36 +02:00
David Taylor
d0cbbbe773
UX: Clarify 'disable tag/category edit notifications' site settings ( #22874 )
...
Toggling these settings will prevent 'published' topics (e.g. from shared drafts) from creating notifications for people watching the relevant category/tag.
2023-07-31 13:36:13 +01:00
Gerhard Schlager
76649550c2
Fix typo in not_enough_dice
...
From https://www.collinsdictionary.com/dictionary/english/dice :
> In old-fashioned English, 'dice' was used only as a plural form, and the singular was die, but now 'dice' is used as both the singular and the plural form.
2023-07-31 13:28:42 +02:00
Gerhard Schlager
1af33fdb71
REFACTOR: Use pluralized string for js.badges.awarded
2023-07-31 13:28:42 +02:00
chapoi
6a67d69f7a
UX: fix alignment extra buttons in post controls ( #22872 )
2023-07-31 11:55:46 +02:00
Loudghiri Ahmed
3232c83bf3
FIX: ensure presence channels 'leave' correctly when the tab is backgrounded
...
Co-authored-by: David Taylor <david@taylorhq.com>
2023-07-31 09:41:56 +01:00
