github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-15 18:32:46 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity
11,757 Commits 214 Branches 500 Tags 960 MiB
8199c3b440
Commit Graph

293 Commits

Author SHA1 Message Date
Martin Meyerhoff
3fd8fc97a2 BUGFIX: Handle text input in keypress handler for I18n 
While the `keydown` handler is the only way of reliably catching special keys,
for textual input `keypress` is preferable, as it can handle thing like parens
without having to hardcode a keyboard.

I moved that code and in the process converted some magic numbers to constants
- mostly so I can read stuff better.
 2014-10-01 15:50:09 +02:00
Robin Ward
d1d3e5dd8c Remove broken debouncePromise and clean up some deprecations 2014-09-23 16:16:44 -04:00
Sam
e8bbc147ad Merge pull request #2815 from cpradio/tab-to-first-link-on-post-when-using-keyboard 
FIX: j/k place tab focus accordingly so tab will go to the first linked ...
 2014-09-23 07:38:49 +10:00
cpradio
caac05dbba FIX: j/k place tab focus accordingly so tab will go to the first linked item in the selected post/row 
Allow tabbing to continue from the selected post/topic when using the j/k keyboard shortcuts
https://meta.discourse.org/t/when-a-post-is-selected-tab-should-take-you-to-the-first-link/16212
 2014-09-22 15:07:50 -04:00
Sam
cfa0d66548 Merge pull request #2807 from techAPJ/patch-2 
UX: show category when moving post to exisiting topic
 2014-09-22 11:59:02 +10:00
Sam
aa39a3b4b0 Merge pull request #2810 from cpradio/opera-composer-keyboard-shortucts 
FIX: Opera Composer Keyboard Shortcuts
 2014-09-22 11:50:14 +10:00
cpradio
9e3060a6f7 FIX: Opera Improvements (v12) 
Fix issues with Opera 12 and its ability to utilize Discourse Composer window
https://meta.discourse.org/t/support-for-opera/20218
 2014-09-19 22:47:27 -04:00
Arpit Jalan
ae8f7748f8 UX: show category when moving post to exisiting topic 2014-09-19 21:00:35 +05:30
Sam
14936ed9c9 Merge pull request #2795 from lidlanca/fix-link-release 
Fix: Cancel link click if triggered as part of text selection
 2014-09-19 13:35:13 +10:00
Sam
bf51fbf030 Merge pull request #2806 from Elberet/fix-escape-single-quotes 
FIX: double-escaped single quotes in URLs
 2014-09-19 13:32:43 +10:00
Sam Saffron
5132f217c4 FIX: link to sub category not working in search 2014-09-19 12:55:30 +10:00
Jens Maier
543bc53598 FIX: double-escaped single quotes in URLs 2014-09-18 22:07:42 +02:00
Sam
0855fe5438 Merge pull request #2798 from lidlanca/patch-3 
Fix: rapid/continuous keyboard Next event under Topics List view may lose selected item on "load more"
 2014-09-17 00:25:12 +10:00
cpradio
eaf0cf0519 FIX: Using k on Firefox to navigate up the topic list 
Using k wouldn't always bring the topic in focus as you moved up the topic list
https://meta.discourse.org/t/topic-list-keyboard-shortcut-previous-k-does-not-scroll-properly-leaving-selected-item-hidden-firefox/20050
 2014-09-15 21:10:24 -04:00
lidlanca
e277287b2e Fix: rapid/continuous keyboard Next event under Topics List view may lose selected item on "load more" 
Using Next keyboard shortcut (J) rapidly while reaching last item in the topic list and
causing a "load more". The handler might get into a state where it can not detect any selected item due to the delay from Em.run.next
and will result in position reset.

+added boundary check of last item on next, early in the handler to avoid unnecessary computations 


https://meta.discourse.org/t/keyboard-shortcut-next-previous-continues-key-down-reset-to-first-item-in-list-on-load-more/20042
 2014-09-13 23:59:20 -04:00
lidlanca
13cedce0cf Fix: Cancel link click if triggered as part of text selection 
Prevent a click if the user select content in a topic and release the mouse over a link.

https://meta.discourse.org/t/selecting-a-link-results-in-it-being-opened/14846
 2014-09-13 04:05:03 -04:00
Robin Ward
a09ff29dd9 UX: Only intercept Cmd-F/Ctrl-F for search on a topic when not all posts 
are available in the DOM.
 2014-09-09 16:05:17 -04:00
Robin Ward
8b33e659a1 FIX: Only use cached topic lists on popState 2014-09-09 12:57:51 -04:00
Régis Hanol
eb34ecfc0c FEATURE: new 'prevent anons from download files' site setting 2014-09-09 18:41:13 +02:00
Robin Ward
8ac955247c Convert category helpers to ES6. 2014-09-04 11:32:30 -04:00
Sam
0ade9bafff FIX: highlight in yellow, not blue 
FEATURE: highlight in title
 2014-09-04 15:01:13 +10:00
Sam
b8c36bd2da FIX: broken search for admins when selecting topics 2014-09-04 12:21:57 +10:00
Robin Ward
065101afac Merge pull request #2734 from cpradio/readd-dismiss-bindings 
FIX: Readd the dismiss keybindings
 2014-09-02 10:42:53 -04:00
Sam
202656a679 Merge pull request #2725 from cpradio/german-keyboard-support 
FIX: Support J/K bindings on German Keyboards
 2014-09-02 08:02:10 +10:00
Sam
69e418facf FEATURE: wider search with more context 2014-09-01 17:04:57 +10:00
cpradio
42c052d21b FIX: Readd the dismiss keybindings 
https://meta.discourse.org/t/new-updated-bar-and-dismiss-new-button-unreachable-by-keyboard/18946/10?u=cpradio
 2014-08-31 21:56:38 -04:00
cpradio
6234284243 FIX: Remove the old keyboard bindings for next/prev section, update client.en.yml to reflect the new bindings 2014-08-31 21:42:03 -04:00
Sam
5c244c6f8f FIX: autocomplete username failing to pop up 
Janky autocomplete behavior due to debounce not being accounted for
correctly when dealing with promises

This also fixes a promise leak
 2014-09-01 01:48:17 +10:00
cpradio
37639308c0 FIX: Firefox j/k post navigation is inconsistent 
https://meta.discourse.org/t/j-k-navigation-in-lengthy-topics/18945
 2014-08-30 08:59:08 -04:00
cpradio
3f5d530553 Change SHIFT+J and SHIFT+K to move up/down sections instead of posts. 2014-08-30 07:31:38 -04:00
cpradio
89eb03aff0 FIX: Support J/K bindings on German Keyboards 
J/K are not supported on German keyboards, shift+j and shift+k have been added to remedy this.
https://meta.discourse.org/t/keyboard-shortcuts-for-next-previous-section-do-not-work-with-german-keyboard-layout/18902
 2014-08-29 22:18:03 -04:00
cpradio
d2dea54c88 Merge remote-tracking branch 'cpradio/keyboard-binding-incoming-updated-topics' 
Conflicts:
	config/locales/client.en.yml
 2014-08-29 19:53:54 -04:00
cpradio
68e807f791 UX: Add keyboard binding for reply as new topic 2014-08-29 19:14:42 -04:00
Neil Lalonde
1291e94c78 Merge pull request #2715 from cpradio/master 
UX: Add focus to menu only if it comes from a keyboard shortcut and improve keyboard functionality for search
 2014-08-29 17:04:52 -04:00
cpradio
8033972536 UX: Add keyboard bidning for incoming/updated topics 
Fixed the selector used to gain access to the clickable div
 2014-08-29 10:01:36 -04:00
cpradio
5ca96e741d UX: Add keyboard bidning for incoming/updated topics 2014-08-29 09:44:26 -04:00
cpradio
1acb2a13f1 Added a:first 2014-08-28 16:06:48 -04:00
cpradio
4fd73a2b2f Set focus on site-map and user menu 
Set focus on first item in the site-map and user drop down for keyboard users, so they can quickly tab to the link/item of their choosing.
https://meta.discourse.org/t/keyboard-shortcuts-wish-list/15952
 2014-08-28 16:04:54 -04:00
Robin Ward
8a6c4234fc FIX: Re-enable searching for topic by id when using the split topic 
interface.
 2014-08-28 15:42:29 -04:00
Arpit Jalan
3a76f9e79f FIX: allow localization in timestamp 2014-08-27 20:57:06 +05:30
Arpit Jalan
0453da6fa5 FIX: use short date format for timestamp 2014-08-27 12:56:52 +05:30
cpradio
1678a91a60 Add shortcuts for Profile Menu and Hamburger Menu 
Added shortcuts of p and = for the profile and hamburger menu
https://meta.discourse.org/t/keyboard-shortcuts-wish-list/15952
 2014-08-26 20:30:20 -04:00
Sam
f331855482 FIX: username autocomplete more reliable, cancel old reqs 2014-08-26 11:32:50 +10:00
Robin Ward
0fba445bc1 FIX: Broken build 2014-08-25 13:35:40 -04:00
Robin Ward
f10f9585ae Better Support for whitelisting caja tags 2014-08-25 13:11:20 -04:00
Sam
9ecbfad5fa only hijack search on topic page 2014-08-22 08:53:00 +10:00
Robin Ward
65297533fa FIX: Allow links to name attributes 2014-08-19 16:51:53 -04:00
Robin Ward
b175abbfb5 FIX: Admin group search was failing 2014-08-18 14:08:21 -04:00
riking
8539c08d35 Fix assignment of post number to progress position 2014-08-14 17:31:34 -07:00
Robin Ward
dd8e5583d7 ES6: Transition helper 2014-08-12 16:33:53 -04:00
Robin Ward
3930d933ca Revert "CLEANUP: This file no longer seems to be used" 
This reverts commit 5c2893c8f9.
 2014-08-12 16:23:44 -04:00
Robin Ward
5c2893c8f9 CLEANUP: This file no longer seems to be used 2014-08-12 16:22:06 -04:00
Robin Ward
3b76fd82fd ES6: user-search lib and autocomplete. Cancels many promises rather than 
leaving them as pending forever.
 2014-08-08 13:10:13 -04:00
Robin Ward
271374a8c6 Remove some Ember.Deferred usage. It's deprecated. 2014-08-07 17:22:00 -04:00
Sam
e227b68f8d FEATURE: make # more useful for keyboard users 2014-07-30 12:16:11 +10:00
Sam
871f2113e4 BUGFIX: don't move selection when nothing is selected 2014-07-30 11:22:41 +10:00
Sam
367d699247 FIX: enter on invite to PM was broken 2014-07-30 08:46:59 +10:00
Régis Hanol
b196de0821 TRIVIAL: use class instead of id for the 'topic-list' 2014-07-29 23:38:36 +02:00
Robin Ward
16dfedef8f ES6: Remove dynamically generated static routes. They were causing lots 
of confusion and bugs.
 2014-07-29 14:24:16 -04:00
Sam
32cea9d8cc Feature: Show keyboard shortcuts link on desktop hamburger 
(only shows up for desktop, hides "mobile view")

If you really need mobile view add ?mobile_view=1 to end of URL (also fixed)
 2014-07-28 11:48:56 +10:00
Neil Lalonde
5a33e6f00c Move FAQ, Terms of Service, and Privacy Policy into topics in the Staff category. First post of those topics will be rendered on their respective pages. Site settings and content are not used for these documents anymore. Translations of the default text is moved into the standard YML files. 2014-07-25 14:41:20 -04:00
Sam
1297243759 FIX: stop tracking broken links 2014-07-25 15:34:31 +10:00
Sam
fbbd4999b6 FIX: remove invalid hack, correct whitelist to use value returned from callback 2014-07-25 12:16:00 +10:00
Robin Ward
b88a8d2416 FIX: Clicking navigation pills a second time should refresh the list 
you're looking at.
 2014-07-24 14:59:53 -04:00
Robin Ward
fa25700400 FIX: Direct links to hash URLS were broken. Regression? 2014-07-24 12:52:43 -04:00
Robin Ward
59c3ca7e7b PLUGIN: New API for decorating a post with jQuery 2014-07-21 11:38:38 -04:00
Robin Ward
da717c55d7 FEATURE: Like button should act like a toggle and stay there once you've 
clicked it.
 2014-07-18 17:01:27 -04:00
Régis Hanol
c7330ed73f BUGFIX: errors when post-processing 'data images' 2014-07-18 17:54:18 +02:00
Sam
b522f6116f FIX: strip out some more undo/redo stuff 2014-07-18 10:32:55 +10:00
Sam
da26aae41e FIX: somehow button is not set 2014-07-18 10:31:02 +10:00
Sam
de7e6a9545 Feature: allow mods to cut pinned topic excerpts 2014-07-17 21:32:37 +10:00
Sam
91cd4f2d66 SECURITY: improve escaping protection 2014-07-17 16:11:10 +10:00
Sam
c12a131fb4 SECURITY: sanitizer allowing invalid attributes 2014-07-17 16:11:09 +10:00
Robin Ward
62ef81d895 FIX: Don't scroll to top if there's an anchor present. 2014-07-16 18:14:39 -04:00
Régis Hanol
a9342dbf92 SECURITY: fix XSS in link's href 2014-07-15 16:11:37 +02:00
Jason Taylor
df2c259836 BUGFIX: exception validating 'data-' attributes 2014-07-14 17:43:38 -07:00
Robin Ward
1886ffaff2 FIX: Work with phpBB import style links with ellipsis 2014-07-14 14:27:17 -04:00
Robin Ward
186ce78cb5 FIX: BBCode sanitization and tests 2014-07-14 11:24:25 -04:00
Sam
d54c28adc1 FIX: better whitelisting 2014-07-10 09:59:54 +10:00
Sam
9828a268b9 Fix: whitelist regex for bbcode too wide 2014-07-10 09:17:04 +10:00
Régis Hanol
6b45b635f8 FIX: properly whitelist <code> classes needed for syntax highlighting 2014-07-09 16:27:47 +02:00
Sam
9ffcbfca98 FIX: disable whitelist temporarily 
more complete fix to follow
 2014-07-09 22:13:27 +10:00
Sam
0d281d9de6 FIX: Firefox chucks exceptions on localStorage with cookies disabled 2014-07-09 16:15:52 +10:00
Sam
8e31fe4835 FIX: select context when search triggered via CTRL-F 2014-07-08 12:40:51 +10:00
Sam
fcbc7729b6 FIX: missing BBCODE whitelists 
FEATURE: ability whitelist a RegExp
 2014-07-08 10:33:59 +10:00
Sam
8298929b67 FIX: autocomplete quirks 2014-07-05 11:45:13 +10:00
Robin Ward
fc1ce96dbb FIX: Change the approach to sanitization. Includes a more detailed API 
for allowing classes and attributes for only certain tag names.
 2014-07-03 16:55:36 -04:00
Robin Ward
f62b05c985 FIX: Apply category class when inside a topic of that category 2014-07-01 16:06:48 -04:00
Jeff Atwood
6bb17b7214 x is no sexy, &times; is yes sexy 2014-06-28 02:17:18 -07:00
Robin Ward
7f6bace7c5 FIX: In IE9 *shudder* the path will be incorrect and reloading the 
latest posts will fail.
 2014-06-25 12:09:47 -04:00
Robin Ward
39c2c958e6 ES6: ComposerView 2014-06-24 16:53:10 -04:00
Sam
bd13fedba5 display probe function to help debugging mobile etc. 2014-06-24 12:04:04 +10:00
Robin Ward
56096619c0 FIX: Use secondary category color for stripes when only showing the 
stripe.
 2014-06-20 12:46:42 -04:00
Neil Lalonde
eeeb834b6b FIX: strip html tags from category badge tooltips 2014-06-19 18:18:09 -04:00
Robin Ward
7ae4c4dedc COSMETIC: visual tweaks to the categories page 2014-06-19 17:11:45 -04:00
Robin Ward
f0da4bf632 We don't need an empty app-events file. 2014-06-19 15:28:42 -04:00
Robin Ward
49ae01ddea TWEAK: Don't focus on progress expansion on touch interfaces. 2014-06-19 15:19:49 -04:00
Sam
806ddb4ccb FEATURE: Quote reply at cursor 2014-06-18 15:17:55 +10:00
Sam Saffron
6f88fc3aa3 HACK: disable undo/redo editor functionality 
TODO in a few weeks, rip out all code.
 2014-06-16 10:39:51 +10:00
Robin Ward
cf165320e2 Keyboard shortcuts for new progress expansion 2014-06-13 14:03:12 -04:00