Joe
98354bd34c
fix the build
2018-11-23 11:27:59 +08:00
Joe
c4fca36255
FIX: don't trigger header:hide-topic at the bottom on desktops
...
On mobile we trigger `header:hide-topic` at the very bottom of topics to switch the header contents back from small logo + topic info to large logo + user panels.
Given that the `topic-progress` component is sometimes loaded on desktop - E.g composer is open or on narrow desktop screens - we need a guard to prevent this logic from firing on desktops.
2018-11-23 10:14:13 +08:00
Guo Xiang Tan
7f7464e3e6
DEV: Remove unused variable.
2018-11-23 08:32:29 +08:00
Sam
7ba681383d
DEV: run plugin tests in autospec
2018-11-23 11:27:08 +11:00
Joffrey JAFFEUX
f4432648fd
FIX: categories/delete_categories can be undefined ( #6657 )
2018-11-23 00:57:18 +01:00
Vinoth Kannan
06b3621e80
Revert "DEV: Use equal method instead of deepEqual"
...
This reverts commit 5969a31d73
2018-11-23 04:08:51 +05:30
Penar Musaraj
7fd9e9e320
Pin Prettier to 1.14.3
2018-11-22 15:51:04 -05:00
Vinoth Kannan
5969a31d73
DEV: Use equal method instead of deepEqual
2018-11-23 01:53:13 +05:30
David Taylor
f645cb9c14
FEATURE: Use translated name for 'your email has been authenticated by' ( #6649 )
2018-11-22 19:12:04 +00:00
Joffrey JAFFEUX
7e20a0b917
DEV: removes _.indexOf from codebase ( #6652 )
2018-11-22 17:38:58 +01:00
David Taylor
0083eec686
FEATURE: Allow logo URLs to be overridden easily using reopenWidget()
2018-11-22 16:29:12 +00:00
Joffrey JAFFEUX
3ff3bb6e2a
FIX: improves code, tests and utc handling of local-dates ( #6644 )
2018-11-22 17:19:24 +01:00
Joffrey JAFFEUX
56478166e5
FIX: broken badge groupings modal UI ( #6653 )
2018-11-22 17:09:45 +01:00
David Taylor
052bf37578
FIX: Use Discourse.deprecate instead of Rails.logger.warn
...
This will significantly reduce the volume of logs when the condition is hit
2018-11-22 15:59:47 +00:00
Joffrey JAFFEUX
2843944315
FIX: better alignment of badge selector and edit btn ( #6651 )
...
Input located at /admin/badges/new
2018-11-22 16:21:15 +01:00
Joffrey JAFFEUX
e77cc44f07
FIX: better alignment of groups header filters ( #6650 )
...
This is located at the top of the /groups page.
2018-11-22 16:18:02 +01:00
Kyle Zhao
80398d0b8f
Extract inline JS on embedded comments ( #6645 )
...
* use the meta refresh tag instead
* extract inline JS in embedded comment
2018-11-22 10:02:58 -05:00
David Taylor
1fd0787dd7
UX: Ensure unstyled .btn-social elements have a contrasting background
...
For example, in plugins where the background color is not explicitly set
2018-11-22 15:00:32 +00:00
Gerhard Schlager
2ef16e9f4e
FIX: Failed to delete post belonging to non-existent topic
2018-11-22 15:08:37 +01:00
Gerhard Schlager
bf27aecce2
REFACTOR: compact! works since the array can't contain empty strings
2018-11-22 13:27:34 +01:00
Arpit Jalan
60941f214c
FIX: remove unneeded keys from failed response
2018-11-22 14:59:50 +05:30
Guo Xiang Tan
96168cb3c6
DEV: Use a set in SiteSetting.settings_hash.
2018-11-22 17:16:40 +08:00
Guo Xiang Tan
4752ddc908
Avoid DB query when there are no mentions.
2018-11-22 16:44:17 +08:00
Guo Xiang Tan
a57baeec2a
Fix the build.
2018-11-22 16:37:24 +08:00
Guo Xiang Tan
28a6cf8228
FIX: Mention lookup should be case insensitive.
2018-11-22 16:32:56 +08:00
Guo Xiang Tan
3f636b2d19
FIX: Check whether group is mentionable by user when cooking post.
2018-11-22 16:16:33 +08:00
Sam
0739c3b1d1
DEV: this introduces a script capable of caching critical DNS locally
...
This is useful for cases where you want to add resiliency to DNS lookups
for redis and postgres, so they will continue to work even if there is
a DNS outage
2018-11-22 18:46:59 +11:00
Vinoth Kannan
036790d13c
FIX: Assign default value for category.findByIds method
2018-11-22 12:51:04 +05:30
Guo Xiang Tan
672e95bcb4
FIX: Staged users should not be mentionable.
2018-11-22 15:00:46 +08:00
Guo Xiang Tan
6111b285d9
DEV: Remove comment that links to a private topic.
...
Not going to be useful for other developers.
2018-11-22 14:55:02 +08:00
Guo Xiang Tan
c5a70eca6e
PERF: Move mention lookups out of the V8 context. ( #6640 )
...
We were looking up each mention one by one without any form of caching and that results
in a problem somewhat similar to an N+1. When we have to do alot of DB
lookups, it also increased the time spent in the V8 context which may
eventually lead to a timeout. The change here makes it such that mention lookups only does a single
DB query per post that happens outside of the V8 context.
2018-11-22 14:28:48 +08:00
Guo Xiang Tan
596e09aaf9
FIX: Wizard icons step fields have incorrect values.
...
https://meta.discourse.org/t/is-the-wizard-supposed-to-not-let-you-skip-adding-icons/102417
2018-11-22 14:19:36 +08:00
Guo Xiang Tan
ba280f9cf3
FIX: Give up migrating url site setting if endpoint doesn't return data.
2018-11-22 12:16:52 +08:00
Guo Xiang Tan
a8603e04ab
FIX: Give up migration of URL site settings if there is an SSL error.
2018-11-22 12:14:27 +08:00
Maja Komel
993d8f346e
FIX notifications for flag PMs ( #6641 )
2018-11-22 10:25:19 +08:00
Kyle Zhao
8e32aa1483
FEATURE: show post approvals in Moderation History ( #6643 )
2018-11-22 10:22:23 +08:00
Joe
ee6c0170ce
FEATURE: Scroll-based logo on mobile ( #6632 )
2018-11-21 21:21:49 -05:00
Saurabh Patel
d984323e23
FEATURE: Show change name of user in staff logs ( #6647 )
...
https://meta.discourse.org/t/admins-changing-users-name-not-username-should-be-logged/99511
2018-11-22 10:13:02 +08:00
Guo Xiang Tan
d298f00046
DEV: Improve specs to be more specific about what has changed.
2018-11-22 10:10:07 +08:00
Gerhard Schlager
a3f8ef89a6
FIX: Setting DISCOURSE_S3_REGION env variable had no effect
2018-11-21 23:15:28 +01:00
Kris
0381e99b71
UX: improving theme upload modal alignment, markup
2018-11-21 16:50:49 -05:00
Gerhard Schlager
c376670bd2
FIX: a search term containing '& could lead to errors
...
This also makes sure that the search term in front or after special characters isn't ignored.
2018-11-21 22:07:56 +01:00
Joffrey JAFFEUX
58c795ef30
DEV: adds test for image-short-url ( #6642 )
2018-11-22 07:48:52 +11:00
Régis Hanol
a0f0bac752
Add a comment to run the 'import:ensure_consistency' rake task after a bulk import
2018-11-21 16:28:35 +01:00
Maja Komel
715b2e85fc
FIX: make danger locale warning work with plugin locales ( #6639 )
2018-11-21 10:13:25 +01:00
Arpit Jalan
61eff22b29
FIX: raise Discourse::NotFound unless the user is present
2018-11-21 10:57:42 +05:30
Arpit Jalan
10cc698df3
FIX: respond with proper error message if user not found
2018-11-21 10:47:37 +05:30
Arpit Jalan
539f1c6252
FIX: raise Discourse::NotFound unless the topic is present
2018-11-21 09:48:38 +05:30
Guo Xiang Tan
439b3fe10a
Fix MigratePollsData failing when poll-votes have duplicated options.
2018-11-21 10:52:21 +08:00
Guo Xiang Tan
f4020d9134
UX: Contain site setting uploads within the div.
2018-11-21 10:09:53 +08:00
