github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-12-03 13:53:44 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity
32,834 Commits 214 Branches 500 Tags 960 MiB
abbc639e0d
Commit Graph

32834 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Guo Xiang Tan
abbc639e0d FIX: Only unregister service workers that belongs to Discourse. 2019-05-07 13:08:06 +08:00
Arpit Jalan
03169401ff UX: correct order of site statistics on /about page 2019-05-07 09:50:41 +05:30
Daniel Waterworth
e219588142 DEV: Prefabrication (test optimization) (#7414) 
* Introduced fab!, a helper that creates database state for a group

It's almost identical to let_it_be, except:

 1. It creates a new object for each test by default,
 2. You can disable it using PREFABRICATION=0
 2019-05-07 13:12:20 +10:00
Guo Xiang Tan
329969ea20 FIX: Discobot mention tutorial should be case insensitive. 2019-05-07 10:54:22 +08:00
Sam Saffron
e2bcf55077 DEV: move send => public_send in lib folder 
This handles most of the cases in `lib` where we were using send instead
of public_send
 2019-05-07 12:25:44 +10:00
Guo Xiang Tan
451f7842ff DEV: More send -> public_send. 2019-05-07 10:05:58 +08:00
Sam Saffron
cac80cdc3b DEV: more send -> public_send changes 
This is a work in progress commit for more send to public_send conversions

Also adds some comments for cases where we need to keep send
 2019-05-07 11:58:06 +10:00
Guo Xiang Tan
61cc0f8c5f Follow up to 152238b4cf. 2019-05-07 09:57:27 +08:00
Guo Xiang Tan
1e7c4592dc Fix rebase fail in 152238b4cf. 2019-05-07 09:46:07 +08:00
Guo Xiang Tan
152238b4cf DEV: Prefer public_send over send. 2019-05-07 09:33:21 +08:00
Sam Saffron
9be70a22cd DEV: introduce new API to look up dynamic site setting 
This removes all uses of both `send` and `public_send` from consumers of
SiteSetting and instead introduces a `get` helper for dynamic lookup

This leads to much cleaner and safer code long term as we are always explicit
to test that a site setting is really there before sending an arbitrary
string to the class

It also removes a couple of risky stubs from the auth provider test
 2019-05-07 11:00:30 +10:00
Robin Ward
47995d2d89 FIX: Your own likes were missing on posts 2019-05-06 20:03:50 -04:00
Sam Saffron
20f84a364b Correct regression, correctly raise exception when setting incorrect param 2019-05-07 09:48:14 +10:00
Sam Saffron
c8418595bf SECURITY: avoid use of send in favor of public_send 2019-05-07 09:41:05 +10:00
Robin Ward
e9564c999f FIX: We just show likes to see like count 2019-05-06 18:19:45 -04:00
Robin Ward
310e196aca FIX: like-count has been removed from the post menu 2019-05-06 17:48:57 -04:00
Robin Ward
18d742d334 FIX: Broken spec 2019-05-06 17:09:08 -04:00
Robin Ward
31e100530f FEATURE: Flag count in post menu 
This change shows a notification number besides the flag icon in the
post menu if there is reviewable content associated with the post.
Additionally, if there is pending stuff to review, the icon has a red
background.

We have also removed the list of links below a post with the flag
status. A reviewer is meant to click the number beside the flag icon to
view the flags. As a consequence of losing those links, we've removed
the ability to undo or ignore flags below a post.
 2019-05-06 16:13:31 -04:00
Neil Lalonde
e6843afa9e FIX: don't send post edit notification when hidden tags are changed 2019-05-06 15:45:06 -04:00
Neil Lalonde
5de750d373 FIX: don't bump topics when hidden tags are added or removed 2019-05-06 14:52:18 -04:00
Bianca Nenciu
39260c841e DEV: Add test for click-track and mention links. 
Follow-up to b81d169e.
 2019-05-06 19:29:51 +03:00
Bianca Nenciu
233d3f611b DEV: Fix test. 2019-05-06 19:29:51 +03:00
Roman Rizzi
20d4093a67
FIX: When mutating a string to build a diff. Duplicate it first (#7482) 2019-05-06 13:20:10 -03:00
Bianca Nenciu
e67ba8517d DEV: Add test for click-track and <a> without href. 
Follow-up to b9339e15.
 2019-05-06 18:38:57 +03:00
Penar Musaraj
5e546ba7d1 Standardize viewport rules for mobile and desktop 
Also removes`maximum-scale` on non-mobile devices, better for accessibility.
 2019-05-06 10:28:29 -04:00
Régis Hanol
e2e72f4e8e DEV: rename ReadOnly module to ReadOnlyHeader 2019-05-06 16:07:49 +02:00
Dan Ungureanu
33e06dd796
FIX: Make select all and below skip small actions. (#7425) 2019-05-06 16:22:11 +03:00
Dan Ungureanu
a40dcbde9b
FIX: Do not move hidden post actions. (#7424) 
Hidden (staff-only) post actions are whisper posts with no content, that
are later transformed by the client into post actions (discourse-assign
uses this).
 2019-05-06 16:21:42 +03:00
Arpit Jalan
d679c4e0eb Bump onebox version. 
- FIX: encode the URL per RFC 3986 spec
 2019-05-06 18:17:42 +05:30
Gerhard Schlager
74ca49d7cd FIX: Importing of polls from phpBB3 was broken 
Follow-up to 24369a81
 2019-05-06 12:37:19 +02:00
Guo Xiang Tan
c96b617bf6 FIX: Don't trigger PG failover when running db:migrate. 2019-05-06 17:03:28 +08:00
Guo Xiang Tan
8217d5be78 UX: Switch mobile header back for 5s when notification comes in. 2019-05-06 16:58:25 +08:00
Sam Saffron
bcdf5823a0 DEV: correct frozen string and broken spec 
This needs to be properly handled so the correct message is raised

1 item was removed from the serializer (avg_time)
 2019-05-06 17:31:35 +10:00
Arpit Jalan
6ba914033c FEATURE: rake task to bulk grant badge to members of a group 2019-05-06 12:41:50 +05:30
Sam Saffron
f8eddd40ad PERF: remove avg_time calculations and regular jobs from posts and topics 
After careful analysis of large data-sets it became apparent that avg_time
had no impact whatsoever on "best of" topic scoring. Calculating avg_time
was a very costly operation especially on large databases.

We have some longer term plans of introducing other weighting that is read
time based into our scoring for "best of" and "top" topics, but in the
interim to stop a large amount of work that is not achieving any value we
are removing the jobs.

Column removal will follow once we decide on a new replacement metric.
 2019-05-06 15:59:01 +10:00
Guo Xiang Tan
ba3cf7109c DEV: Remove unused lines of code. 2019-05-06 13:48:51 +08:00
Guo Xiang Tan
b7b9960558 DEV: Fix missing port in URLs in development mode. 2019-05-06 13:26:57 +08:00
Sam Saffron
267d129f38 FEATURE: only scroll to bottom for discobot 
Non discobot replies on PMs triggering scroll cause confusion.
 2019-05-06 10:55:58 +10:00
Sam Saffron
d4bf7d6831 FIX: correctly display browser is old message to IE10 
We dropped support for IE10 a while back but never amended the banner to
show it is not supported.

This properly drops support.
 2019-05-06 10:45:45 +10:00
Sam Saffron
12e78d8915 DEV: add wrapper for rspec running in docker 2019-05-05 13:43:45 +10:00
Jeff Atwood
7799d29b12 copyedits on approval descriptions 2019-05-04 20:25:46 -07:00
Robin Ward
99a2a769d4 FIX: Conflict error (version was already used) 2019-05-03 16:36:37 -04:00
Vinoth Kannan
e8fafbc123 List and restore missing post uploads from S3 inventory. 2019-05-04 01:16:20 +05:30
Régis Hanol
bfcbfd7864 FIX: don't remap readonly columns 2019-05-03 20:30:23 +02:00
David Taylor
d82da69c2c FIX: Fail gracefully if username parameter is missing when creating user 2019-05-03 17:17:06 +01:00
Robin Ward
15c9b00307 FEATURE: Show edit indicator on review queue 
If a flagged post has edits, show the pencil icon and pop up the history
window when clicked.
 2019-05-03 11:21:33 -04:00
Joffrey JAFFEUX
5f78bbebe9
FIX: forces a reload of emoji list if clicked on more (#7473) 
This is a bit hacky but it's much more simple and reliable than many other solutions and doesnt involve having to manage some variable state.
 2019-05-03 16:11:03 +02:00
David Taylor
0644c10bfe FIX: Prioritize VERP key over final_recipient header in bounced email 
Per RFC3464 2.3.2, the final_recipient header may not match the address we originally sent the email to.
 2019-05-03 12:12:44 +01:00
Régis Hanol
0d41d58d27 FIX: add ReadOnly hear to /srv/status 2019-05-03 12:21:07 +02:00
Sam Saffron
16ef060a76 DEV: correct Rails 6 deprecation 
render template is backwards compatible with Rails 5, code is simpler.

Thanks @jhawthorn, this is our last Rails 6 deprecation
 2019-05-03 16:20:18 +10:00