Krzysztof Kotlarek
bd0b558a89
FIX: paste the spreadsheet to the composer ( #11163 )
...
* FIX: paste the spreadsheet to the composer
If we paste spreadsheet with the missing label we receive
`" this \n1 2"`
If we trim whitespace at the beginning then our later calculation to determine if it is a table is incorrect:
```
const columns = rows.map((r) => r.split("\t").length);
const isTable =
columns.reduce((a, b) => a && columns[0] === b && b > 1)
```
https://meta.discourse.org/t/pasting-from-spreadsheet-wont-work-if-corner-cell-is-empty/169443
2020-11-13 13:01:22 +11:00
dependabot[bot]
89e10bd053
Build(deps-dev): Bump webmock from 3.9.5 to 3.10.0 ( #11227 )
...
Bumps [webmock](https://github.com/bblimke/webmock ) from 3.9.5 to 3.10.0.
- [Release notes](https://github.com/bblimke/webmock/releases )
- [Changelog](https://github.com/bblimke/webmock/blob/master/CHANGELOG.md )
- [Commits](https://github.com/bblimke/webmock/compare/v3.9.5...v3.10.0 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-11-13 02:22:57 +01:00
dependabot[bot]
c94cbcca72
Build(deps): Bump rubocop from 1.2.0 to 1.3.0 ( #11226 )
...
Bumps [rubocop](https://github.com/rubocop-hq/rubocop ) from 1.2.0 to 1.3.0.
- [Release notes](https://github.com/rubocop-hq/rubocop/releases )
- [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop-hq/rubocop/compare/v1.2.0...v1.3.0 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-11-13 00:55:46 +01:00
Bianca Nenciu
e98c7b15d6
FIX: Do not optimize animated images in cooked posts ( #11214 )
...
CookedPostProcessor replaces all large images with their optimized
versions, but for GIF images the optimized version is limited to first
frame only. This caused animations it cooked posts to require a click
to show up the lightbox and start playing.
2020-11-12 21:47:30 +02:00
tshenry
e1fbd56f6f
UX: Use appropriate logo on static pages ( #11211 )
...
Now that we have dark logo settings in core, we can relatively easily ensure that static pages (such as the 404 page) use a logo that is appropriate for the given light or dark color scheme.
2020-11-12 10:50:55 -08:00
Roman Rizzi
ffd1b7c234
Revert "topic fixup" ( #11223 )
...
The review queue page fails to load with the error: "TypeError: category is null"
This reverts commit 19b7cdd21f
.
2020-11-12 15:15:25 -03:00
Penar Musaraj
89fc11e93b
UX: Layout changes to edit category page ( #11222 )
2020-11-12 12:51:25 -05:00
Mark VanLandingham
fa29c2e7b9
DEV: Refactor default new group permissions ( #11221 )
2020-11-12 10:37:33 -06:00
Penar Musaraj
7fe0830fa8
DEV: Delete en-SG moment-locale ( #11220 )
...
This is now in the lowercase en-sg file, and it causes issues on macOS dev environments to have both en-SG and en-sg files in the same location.
2020-11-12 11:24:59 -05:00
Penar Musaraj
698b7ace10
FIX: Reset category edit page button state ( #11218 )
...
Fixes two small issues:
- buttons stayed disabled after deleting a category
- on a newly-created category, the Edit button was missing on the category landing page
2020-11-12 10:03:58 -05:00
Arpit Jalan
df003eaf7b
FIX: add a way to cancel initialization of new draft ( #11106 )
2020-11-12 19:13:52 +05:30
David Taylor
5be78bb2d9
FIX: Use filters
parameter instead of filter
for staff action log ( #11217 )
...
Fixing this also means that ember takes care of JSON encoding the query parameter
Follow-up to a4441b3984
2020-11-12 13:31:28 +00:00
David Taylor
4f1bb184b1
FIX: Add history icon to svg_sprite list ( #11216 )
...
Follow-up to a4441b3984
2020-11-12 13:11:03 +00:00
Gerhard Schlager
6ff07bb73f
FEATURE: Create revision when bulk moving topics ( #10802 )
...
This behavior can be configured with the new "create_revision_on_bulk_topic_moves" site setting. It's enabled by default.
2020-11-12 13:57:12 +01:00
David Taylor
a4441b3984
FEATURE: Link site setting titles directly to their change log ( #11215 )
...
This makes it much easier to check the staff action logs for a specific site setting. A small history icon will appear when hovering over a site setting name. On click, you will be taken to the pre-filtered staff action log for the site setting.
2020-11-12 12:07:36 +00:00
Gerhard Schlager
6d4711ca10
DEV: Fix lint ( #11213 )
2020-11-12 12:15:55 +01:00
Kris
a90c18e033
DEV: Account for below-site-header and above-site-header outlets when positioning timeline and usercards ( #10434 )
2020-11-12 11:45:09 +01:00
Tobias Eigen
ec49394bd1
DEV: improve text shown when no invitations have been sent out
...
this copy is also shown when viewing invite tabs of other users, so the instructions don't make sense in all cases. shortened it to just say "No invitations to display on this page." users can discover this on their own.
2020-11-12 16:03:28 +11:00
Dan Ungureanu
74a118c13a
FIX: Ensure staff can see /tag/none ( #11208 )
...
TopicQueryParams#build_topic_list_options changes params which could
lead to options[:no_tags] and options[:tags] be set simultaneously.
2020-11-12 12:21:53 +11:00
Bianca Nenciu
2910996feb
FIX: Do not optimize uploaded custom emoji ( #11203 )
...
Animated emojis were converted to static images. This commit moves the
responsability on site admins to optimize their animated emojis before
uploading them (gifsicle is no longer used).
2020-11-12 11:22:38 +11:00
David Taylor
5d480257d4
FIX: Precompile all plugin and color definition CSS assets ( #11210 )
2020-11-12 10:17:38 +11:00
Jarek Radosz
cd6dbd3e9c
FIX: Restore (deprecated) ability to overwrite a property ( #11207 )
...
It should be a `readOnly` but some themes/plugins still pass the `categories` property into this component, so…
2020-11-11 22:16:20 +01:00
David Taylor
803b8933fa
DEV: Ensure DiscourseEvent handlers cleaned up during specs ( #11205 )
2020-11-11 19:46:13 +00:00
David Taylor
24976669b8
DEV: Skip parallel autospec spec for a single file ( #11206 )
...
turbo_rspec can't parallelize a single spec file, so it's not worth the extra setup time for the parallel runner
2020-11-11 19:13:32 +00:00
Jarek Radosz
ae8c96ed35
DEV: Wait for debounced functions
...
Modern Ember testing environment requires calling `await settled()` to wait for delayed runloop-aware functions.
2020-11-11 13:32:42 -05:00
Jarek Radosz
80ef210730
Imports lint
2020-11-11 13:32:29 -05:00
Jarek Radosz
b1bbcb2415
DEV: Use topic property setter
2020-11-11 13:32:29 -05:00
Jarek Radosz
cb4c9eeab8
DEV: Don't eagerly find and assign Topic.category
2020-11-11 13:32:29 -05:00
Jarek Radosz
19b7cdd21f
topic fixup
2020-11-11 13:32:29 -05:00
Jarek Radosz
20108f834c
DEV: Don't overwrite computed props in tests
2020-11-11 13:32:29 -05:00
Jarek Radosz
25524a213d
DEV: Remove duplicated code
...
Fixes "overwriting computed property" warnings
2020-11-11 13:32:29 -05:00
Jarek Radosz
883da89c70
DEV: Replace a full computed prop with readOnly
2020-11-11 13:32:29 -05:00
Jarek Radosz
44de03e409
Imports
2020-11-11 13:32:29 -05:00
Jarek Radosz
0fc944889b
DEV: Replace observers in User model
2020-11-11 13:32:29 -05:00
Jarek Radosz
fe2c3e3e38
DEV: Replace the Topic.category observer
...
Fixes an issue in Ember CLI environment
2020-11-11 13:32:29 -05:00
Gerhard Schlager
811c610108
DEV: Assign id to button for easier finding via CSS selectors ( #11200 )
2020-11-11 18:33:23 +01:00
Roman Rizzi
331517abe6
UI: Blur review queue images. ( #11187 )
...
We blur images by default to protect reviewers against NSFW content. To see the image, they'll have to hover over it.
2020-11-11 14:09:42 -03:00
Arpit Jalan
80759c9619
UX: add a confirmation dialog for draft deletion ( #11198 )
2020-11-11 22:02:52 +05:30
Arpit Jalan
6ea9eb0260
UX: add a link to invites on quick access profile panel ( #11202 )
2020-11-11 22:02:27 +05:30
David Taylor
255633578c
DEV: Move logout redirect logic to server and add plugin hook ( #11199 )
...
This will allow authentication plugins to provide single-logout functionality by redirect users to the identity provider after logout.
2020-11-11 15:47:42 +00:00
Mark VanLandingham
be07853cc1
DEV: Add plugins client/server translation yml file priority structure ( #11194 )
...
Plugin client.en.yml and server.en.yml can now be client/server-(1-100).en.yml. 1 is the lowest priority, and 100 is the highest priority. This allows plugins to set their priority higher than other plugins, so that they can override eachothers' translations.
2020-11-11 09:44:01 -06:00
Bianca Nenciu
a48f7ba61c
FEATURE: Improve errors when title is invalid ( #11149 )
...
It used to simply say "title is invalid" without giving any hint what
the problem could be. This commit adds different errors messages for
all caps titles, low entropy titles or titles with very long words.
2020-11-11 15:11:36 +02:00
Dan Ungureanu
ab314218d3
FEATURE: Implement edit functionality for post notices ( #11140 )
...
All post notice related custom fields were moved to a single one.
2020-11-11 14:49:53 +02:00
Bianca Nenciu
84e2915e71
UX: Increase the hit area of pinned topics on mobile ( #11147 )
...
It used to be only the topic title, but that area has been increased to
include the excerpt too.
2020-11-11 13:46:53 +02:00
David Taylor
5289fc7886
FIX: Improve failover for multisite clusters ( #11150 )
...
- Bump rails_failover for new per-backend callback feature
- If the master backend fails over, make all sites readonly. And vice-versa for fallback
- If a single backend fails over, make that individual site readonly. And vice-versa for fallback
- When a single backend fails, also check connection to the master backend
2020-11-11 10:27:24 +00:00
Tobias Eigen
0a0fd6eace
DEV: fixed capitalization in rate limit message ( #11193 )
2020-11-11 12:35:03 +11:00
Rafael dos Santos Silva
cdb7ddc258
DEV: Update MomentJS and highlightJS
...
We updated version of moment and moment-timezone as our current versions are outdated making Discourse Dates broken on places where timezone had updates, like here in Brazil.
This also update highlightJS to the latest version and corrected a test that relied on a no longer supported locale in
moment.
2020-11-11 12:34:26 +11:00
dependabot[bot]
621da7fc4c
Build(deps-dev): Bump listen from 3.2.1 to 3.3.0 ( #11197 )
...
Bumps [listen](https://github.com/guard/listen ) from 3.2.1 to 3.3.0.
- [Release notes](https://github.com/guard/listen/releases )
- [Commits](https://github.com/guard/listen/compare/v3.2.1...v3.3.0 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-11-11 02:06:57 +01:00
dependabot[bot]
4615f820dd
Build(deps): Bump bootsnap from 1.5.0 to 1.5.1 ( #11196 )
...
Bumps [bootsnap](https://github.com/Shopify/bootsnap ) from 1.5.0 to 1.5.1.
- [Release notes](https://github.com/Shopify/bootsnap/releases )
- [Changelog](https://github.com/Shopify/bootsnap/blob/master/CHANGELOG.md )
- [Commits](https://github.com/Shopify/bootsnap/compare/v1.5.0...v1.5.1 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-11-11 01:39:26 +01:00
dependabot[bot]
9f61db0cdc
Build(deps): Bump oj from 3.10.15 to 3.10.16 ( #11195 )
...
Bumps [oj](https://github.com/ohler55/oj ) from 3.10.15 to 3.10.16.
- [Release notes](https://github.com/ohler55/oj/releases )
- [Changelog](https://github.com/ohler55/oj/blob/develop/CHANGELOG.md )
- [Commits](https://github.com/ohler55/oj/compare/v3.10.15...v3.10.16 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-11-11 01:38:57 +01:00