discourse

mirror of https://github.com/discourse/discourse.git synced 2024-12-17 12:05:58 +08:00

Author	SHA1	Message	Date
Penar Musaraj	09dc922b3b	Fix several FontAwesome 5 issues add missing icons, update SvgSprite methods (to fix ruby 2.4 issues), update whisper icon in composer, fix alignment issues	2018-11-07 22:20:53 -05:00
David Taylor	37fb8fc0e7	FIX: Do not display broken image on crawler/print view (#6575 )	2018-11-07 22:28:45 +00:00
Penar Musaraj	9a34c6153e	Fix small issues with FA5 icons	2018-11-07 16:39:04 -05:00
Penar Musaraj	a5871b6dd1	Rename conflicting SCSS mixin	2018-11-07 14:18:55 -05:00
Penar Musaraj	005e1ecb9b	FEATURE: Update Font Awesome to v5.4.1 and SVGs (#6557 ) * First take on subsetting svg icons * FontAwesome 5 svg subset WIP * Include icons from plugins/badges into svg sprite subset * add svg icon support to themes * Add spec for SvgSprite * Misc. SVG icon fixes * Use FA5 svgs in local-dates plugin * CSS adjustments, fix SVG icons in group flair * Use SVG icons in poll plugin * Add SVG icons to /wizard	2018-11-07 13:05:43 -05:00
Gerhard Schlager	6b60646330	FIX: Relative links in templates should work with subfolders	2018-11-07 11:35:04 +01:00
Sam	0a442e319c	FIX: correct svg handling for images We regressed and optimized images no longer worked with svg The following adds the correct logic to simply copy file for svgs and bypasses resizing for svg avatars	2018-11-07 15:29:26 +11:00
Guo Xiang Tan	7534042427	DEV: Update annotations.	2018-11-07 11:11:19 +08:00
Bianca Nenciu	2070edf889	FIX: Clarify User.group_locked_trust_level. * Rename User.group_locked_trust_level to User.group_granted_trust_level. * Remove the column from users table.	2018-11-07 10:27:44 +08:00
Matthew Campbell	a2044c4528	UX: Make the edits indicator a real link for accessibility (#6570 ) This link didn't have an `href` attribute, so it wasn't in the tab order. This commit fixes that, while adding a call to `preventDefault` in the event handler to avoid any regression in event handling.	2018-11-07 10:11:52 +11:00
Kris	ef368ec2ff	Minor spacing adjustments for new search results	2018-11-06 10:01:24 -05:00
Joffrey JAFFEUX	75b1865d15	UX: adds new categories layouts to the wizard (#6569 )	2018-11-06 15:52:13 +01:00
Joffrey JAFFEUX	fdad24e2e4	FIX: edit category tags select-kit inputs width were wrong (#6568 )	2018-11-06 11:30:12 +01:00
Jeff Atwood	afbdf9c2d2	Merge pull request #6558 from pmusaraj/disallow-flagging-deleted-post FIX: disable flagging hidden posts	2018-11-05 11:05:32 -08:00
Kris	d7e38d2be8	Adding IE11 Grid support for admin dashboard	2018-11-05 12:52:02 -05:00
Maja Komel	ae9eddb002	FIX: don't allow adding a value containing vertical bar char to the secret list	2018-11-05 12:14:56 +01:00
Joffrey JAFFEUX	cc9869a61b	FIX: topic-map spec with VDOM and i18n plural (#6564 ) It appears that in vdom nodes, pluralized i18n strings are not compiled into a string before widget is compiled and result in an error as VDOM is expecting a string and not an object.	2018-11-05 12:02:18 +01:00
Joffrey JAFFEUX	4d74688b50	UX: uses presentation role for accessibility in topic map (#6561 ) Co-Authored-By: mwcampbell <mwc+github@mwcampbell.us>	2018-11-05 09:45:32 +01:00
Penar Musaraj	94f628fb4c	FIX: disable flagging hidden posts	2018-11-02 13:54:45 -04:00
Robin Ward	931c3d165b	Revert "FIX: We shouldn't include topics when mobile view is enabled" This reverts commit `2feadcdafb`.	2018-11-02 10:29:44 -04:00
Joffrey JAFFEUX	4417faa7e5	Revert "FIX: uses more semantically correct spans in post map (#6555 )" This reverts commit `5cd055fd30`.	2018-11-02 15:07:22 +01:00
Joffrey JAFFEUX	8067f8a32c	FIX: disables dates filtering on most_disagreed_flags report (#6556 )	2018-11-02 14:42:52 +01:00
Joffrey JAFFEUX	5cd055fd30	FIX: uses more semantically correct spans in post map (#6555 )	2018-11-02 13:09:58 +01:00
Joffrey JAFFEUX	4e0f033fae	FEATURE: adds ignored flags to most_disagreed_flags report (#6554 )	2018-11-02 11:08:00 +01:00
Sam	d84256a876	FEATURE: add Noindex to robots.txt for disallowed routes This strips pages out of indexes that should not exist see: https://meta.discourse.org/t/pages-listed-in-the-robots-txt-are-crawled-and-indexed-by-google/100309/11?u=sam	2018-11-02 16:39:47 +11:00
Joe	4234058358	UX: don't show crawler navigation in print view (#6551 ) * UX: adds CSS classes to crawler navigation links * UX: hide crawler navigation in print view	2018-11-02 09:18:07 +11:00
Robin Ward	c4ca5ed50b	FIX: Translation error	2018-11-01 17:44:55 -04:00
Joffrey JAFFEUX	d37e8e17ef	UX: bumps the user-api-key version to 3 (#6526 ) * UX: bumps the user-api-key version to 3 * fix spec	2018-11-01 21:29:29 +01:00
Joffrey JAFFEUX	5a114df088	FEATURE: adds latest to user-api-key session scope	2018-11-01 21:29:19 +01:00
Joffrey JAFFEUX	b8aec7777c	FEATURE: adds list#(unread\|new) to user api key routes (#6494 )	2018-11-01 21:29:13 +01:00
Joffrey JAFFEUX	38ad1b96cb	FEATURE: adds header text/background color to site (#6462 )	2018-11-01 21:29:04 +01:00
Kyle Zhao	f9b36820ef	FIX: only extract script tags with certain types (#6553 ) `script` tags with custom types (e.g. `text/template`) are not executed by the browser, and should not be extracted into an external theme JavaScript	2018-11-01 16:01:46 -04:00
Robin Ward	2feadcdafb	FIX: We shouldn't include topics when mobile view is enabled This setting was set to be the opposite of what we want	2018-11-01 14:47:06 -04:00
Robin Ward	ec91450aae	FEATURE: Track how many user flags are agreed/disagreed/ignored Display the percentage when reviewing flags.	2018-11-01 09:59:50 -04:00
Sam	ceafcbc898	FEATURE: show added date when looking at group members	2018-11-01 15:33:28 +11:00
Sam	aa044623bd	FIX: do not create superflous sessions when logged on In some SSO implementations we may want to issue SSO pipelines for already logged on users In these cases do not re-log-in a user if they are clearly logged on	2018-11-01 12:54:01 +11:00
Vinoth Kannan	0084b0c26e	Merge pull request #6548 from vinothkannans/category-drop-search UX: Include subcategories in search result of all categories drop down	2018-10-31 23:44:54 +05:30
Vinoth Kannan	28cf4d535e	UX: Include subcategories in search result of all categories drop down	2018-10-31 23:03:24 +05:30
Bianca Nenciu	fa0e421af3	FIX: Do not leak information about post revisions. (#6536 )	2018-10-31 14:47:00 +00:00
David Taylor	ff6676094f	FIX: Correct bookmark button class	2018-10-31 11:22:24 +00:00
Régis Hanol	0bf52d422c	FEATURE: new 'simultaneous_uploads' site setting	2018-10-31 10:58:09 +01:00
Kris	f97cf10676	Removing edit button from mobile category list	2018-10-30 22:57:06 -04:00
Sam	23423ba112	correct spec and error reporting previous commit misused warn_exception which caused a spec to fail	2018-10-31 13:38:05 +11:00
Blake Erickson	589e3fcaa0	FIX: return 400 for missing required params (#6546 ) If a required param is missing return a 400 and show a message displaying which param was missing. Added this to the application controller so that we don't have to add this logic to every controller action.	2018-10-31 13:02:48 +11:00
Sam	32b1f34910	PERF: avoid DNS lookups when getting IP info Also cleans up interface in DiscourseIpInfo grew cache to 2000 entries	2018-10-31 12:38:57 +11:00
Bianca Nenciu	e0ccd36dbe	FEATURE: Suspicious logins report. (#6544 )	2018-10-30 22:51:58 +00:00
Bianca Nenciu	e1e392f15b	DEV: Use DiscourseIpInfo for all IP queries. (#6482 ) * DEV: Use DiscourseIpInfo for all IP queries. * UX: Use latitude and longitude for more precision.	2018-10-30 22:08:57 +00:00
Bianca Nenciu	4b7ab97a01	FIX: Add 'log in via link' to email templates. (#6545 )	2018-10-30 19:15:05 +00:00
Joffrey JAFFEUX	11ee07093c	FEATURE: revamps search-menu layout (#6543 )	2018-10-30 10:44:49 -04:00
Gerhard Schlager	733b8af47b	FIX: Uploads didn't work for subfolder anymore	2018-10-30 12:53:57 +01:00
Gerhard Schlager	5b14f713a0	Use class instead of inline style	2018-10-30 11:25:51 +01:00
Joffrey JAFFEUX	af465effef	FIX: prevents y-axis labels to show useless/wrong values	2018-10-30 09:58:03 +01:00
Vinoth Kannan	92bf3c667e	FIX: Flash authentication data not rendered in latest iOS safari browser	2018-10-30 04:00:36 +05:30
Sam	f8305f53c7	FEATURE: special offline support restricted to Android only The special offline page with fetch interception in service worker is only strongly required on Android ad a pre-req for PWAs This is now strongly restricted only to Android while iOS PWA support gets better Long term if we build offline support we can unlock it more globally	2018-10-29 16:29:19 +11:00
Jeff Atwood	760e09907b	add a tad more width for user pref forms	2018-10-27 20:20:01 -07:00
Jeff Atwood	817cf8b229	remove extraneous two factor auth info popup	2018-10-27 14:10:26 -07:00
Jeff Atwood	58b53f7841	update copy for "was this you?" login dialog	2018-10-27 13:57:30 -07:00
David Taylor	375bba3c31	FIX: Add `String.includes` polyfill for IE11	2018-10-26 23:10:03 +01:00
Kris	cd9a41be55	IE11 fix for create account modal alignment	2018-10-26 17:04:28 -04:00
Kris	0bf413be3e	IE11 fix for category dropdown search icon position	2018-10-26 13:28:05 -04:00
Kris	1f88f69a7f	IE11 Fix for tracking dropdown	2018-10-26 12:55:26 -04:00
Rafael dos Santos Silva	84f858fc23	FIX: Remove orientation from the webmanifest We don't really care about orientation, so let the user OS handle it.	2018-10-26 13:48:14 -03:00
Rafael dos Santos Silva	2450f178ca	FEATURE: Allow admins to control PWA display mode per user agent	2018-10-26 13:47:22 -03:00
Kris	fb15e04e48	Fixing broken badge grant layout	2018-10-26 11:06:31 -04:00
Kris	7c2618e914	Adding classes to login for external auth and user fields (#6535 )	2018-10-26 10:33:06 -04:00
Joffrey JAFFEUX	b2585524a9	FEATURE: adds a most disagreed flaggers report	2018-10-26 15:59:04 +02:00
David Taylor	e955a1f24b	DEV: Skip ESLint on polyfill	2018-10-26 13:54:03 +01:00
David Taylor	af84949f25	FIX: Add polyfill so that `Array.includes` works in IE11	2018-10-26 13:45:29 +01:00
Joffrey JAFFEUX	398f98c568	FIX: ensures reports links are correct on subfolder installs	2018-10-26 12:32:02 +02:00
Penar Musaraj	3c92202654	Set individual future-date-input components as clearable, fixes admin Safari bug (#6522 )	2018-10-26 11:34:55 +11:00
Penar Musaraj	ed9c21e42c	FEATURE: hide muted categories from /categories list (#6531 )	2018-10-26 11:34:39 +11:00
Régis Hanol	d17c8df926	Only check for suspicious login for staff members	2018-10-26 00:29:28 +02:00
Kyle Zhao	a6eca28ec6	CSP - extract all other inline JavaScripts (#6528 ) * wizard page inline js * print topic inline js * drop JS for preventing double submission this is the default behavior with Rails' UJS `disable_with` helper * omniauth complete redirect JS * account activate inline js	2018-10-25 09:52:01 -04:00
Bianca Nenciu	effbef7d0b	UX: Use user locale for locations. (#6527 ) * UX: Use user locale for locations. * DEV: Added MaxMindDB test data and fixed test.	2018-10-25 10:54:01 +00:00
Joffrey JAFFEUX	8e274f7296	UX: bumps the user-api-key version to 3 (#6526 ) * UX: bumps the user-api-key version to 3 * fix spec	2018-10-25 09:46:34 +00:00
Bianca Nenciu	2a77550f8c	FIX: Do not track right clicks. (#6530 )	2018-10-25 09:46:04 +00:00
Bianca Nenciu	6a3767cde7	FEATURE: Warn users via email about suspicious logins. (#6520 ) * FEATURE: Warn users via email about suspicious logins. * DEV: Move suspicious login check to a job.	2018-10-25 09:45:31 +00:00
Sam Saffron	abaa3f0650	FEATURE: add server:before-head-close-crawler outlet for plugins This outlet allows plugins to inject html prior to closing head tag	2018-10-25 16:31:05 +11:00
Kris	1d7720ef99	UX: Adding Google-compliant logo	2018-10-24 22:11:19 -04:00
Jeff Atwood	c62a8ee335	switch topic jump glyphs to better signify move to top/bottom	2018-10-24 18:41:41 -07:00
Jeff Wong	0ead513fb0	PERF: remove total unread notifications from message bus (#6529 )	2018-10-25 12:14:34 +11:00
Kris	36e2f863ee	UX: Increase size of topic title tap target on mobile	2018-10-24 20:43:38 -04:00
Kris	c219a5fb1e	Add btn-default class to all default buttons (#6521 )	2018-10-24 16:09:36 -04:00
Kris	0140844eb0	Remove whitespace in template so we can use :empty psuedo	2018-10-24 16:00:22 -04:00
Matthew Campbell	05438d99a8	FIX: Ensure the like button always has a title, for accessibility (#6525 ) The like button previously didn't have a title for anonymous users, because the `canToggleLike` flag wasn't set, but the `liked` flag wasn't set either. This made the button inaccessible to blind users.	2018-10-24 13:58:42 +00:00
Sam	5fd94d3211	PERF: limit unread count to 99 in blue circle This revises: `e605542c4e` Previous commit was faulty	2018-10-24 12:10:27 +11:00
Sam	e605542c4e	PERF: limit unread count to 99 in the blue circle This safeguard is in place to avoid very expensive queries on the server side	2018-10-24 11:53:28 +11:00
Kris	0b4edfc7d6	UX: improve spacing on composer controls	2018-10-23 16:37:36 -04:00
Kris	a82dfbd2dc	Mobile timeline fix	2018-10-23 07:59:00 -04:00
Kris	541b6a8446	UX: Allow vertical timeline to fit on narrower screens	2018-10-22 22:16:59 -04:00
Sam	de6b585368	minor, bypass gravatar update if user does not match this protects against a race condition that can happen when a user record is destroyed reasonably quickly	2018-10-23 12:20:41 +11:00
Daniel Hollas	cee51672c9	FIX: Strip accents from search query `4481836` introduced accent stipping in search_indexer, but we need to strip it from the query itself as well TODO in search with diacritics: - Still need to fix excerpts on search page - need to support accent stripping in in_topic search - need to make sure that in:title works correctly - need to fix "word boldening" in titles	2018-10-23 12:10:33 +11:00
Joffrey JAFFEUX	7d2e582b28	FIX: validates import theme form (#6513 )	2018-10-23 12:09:06 +11:00
Sam	b74dd7d379	FIX: stop logging every 404 error when searching for gravatars	2018-10-23 11:43:14 +11:00
Kyle Zhao	2cc195f3d9	prettier linting fix	2018-10-22 14:18:26 -04:00
Bianca Nenciu	37fa7775f1	FIX: Fix order of recently connected devices. (#6517 )	2018-10-22 17:30:23 +00:00
Kyle Zhao	e9a971a2b6	FEATURE: [Experimental] Content Security Policy (#6514 ) do not register new MIME type, parse raw body instead	2018-10-22 13:22:23 -04:00
Jeff Wong	ec2613699f	Change box category view to use flexbox	2018-10-22 10:15:31 -07:00
Régis Hanol	b9261588f9	make the code prettier	2018-10-22 19:07:41 +02:00
Régis Hanol	3e232412e3	UX: show error when hitting the rate limit on password reset	2018-10-22 19:00:30 +02:00
David Taylor	3377f26eba	FIX: Clean tag before searching for matches	2018-10-22 11:09:06 +01:00
David Taylor	37b7afa522	FIX: Sanitize tags before creation	2018-10-22 10:53:42 +01:00
Kyle Zhao	dca830cb73	Revert "FEATURE: [Experimental] Content Security Policy (#6504 )" This reverts commit `fb8231077a`.	2018-10-19 11:53:29 -04:00
Kris	b35c8fb336	Add offset to topic footer admin menu, to avoid header overlap	2018-10-19 11:30:11 -04:00
David Taylor	0dd717e641	Revert "FIX: Sanitize tags before creation" This reverts commit `18ae8de9e5`.	2018-10-19 15:49:05 +01:00
David Taylor	18ae8de9e5	FIX: Sanitize tags before creation	2018-10-19 15:43:31 +01:00
Kyle Zhao	fb8231077a	FEATURE: [Experimental] Content Security Policy (#6504 )	2018-10-19 10:39:22 -04:00
Bianca Nenciu	b69652278f	FEATURE: Add Wiki Editor badge. (#6511 )	2018-10-19 15:30:27 +02:00
David Taylor	7166d7de9a	FIX: Prevent duplicate tags in tag-choosers (#6512 ) * FIX: Prevent duplicate tags in tag-choosers This reverts `5685b45`, which fixes the duplicate tags problem. The fix introduced by `5685b45` is re-implemented on the server.	2018-10-19 13:44:43 +01:00
Joffrey JAFFEUX	5f86564da1	FEATURE: adds latest to user-api-key session scope	2018-10-19 09:54:06 +02:00
Sam	9bfc939692	cleanup so gravatar download failures are consistent previously we would ignore socket error, but this would mean that there could be conditions where we would keep trying to download gravatars forever (in an hourly job)	2018-10-19 12:51:55 +11:00
Angus McLeod	85ef8e5a9f	auto is not a valid value for min/max height (#6509 )	2018-10-18 21:33:45 -04:00
Bianca Nenciu	22ada32d4d	FIX: Strip @ when searching for users and groups. (#6506 )	2018-10-19 11:56:10 +11:00
Robin Ward	f0af61da41	FIX: User `AvatarLookup` for looking up avatar details (#6508 ) This allows plugins with their own avatar logic to work in the user summary sections.	2018-10-18 15:49:34 -04:00
Blake Erickson	93485facaf	FIX: lowercase username for add/rem group members This fix searches for users based on the downcased username so that if you pass in usernames to add/remove from a group and you don't have the casing just right it will still find the correct users. I updated the tests to add a username that has a mix of upper and lowercase letters to verify this functionality.	2018-10-18 13:17:24 -06:00
Régis Hanol	3973823a33	FIX: always update 'last_gravatar_download_attempt' when updating gravatar	2018-10-18 11:02:54 +02:00
Kyle Zhao	0f1afad6da	FIX: extracted theme JavaScripts for multisite (#6502 ) * FIX: extracted theme javascripts for multisite * onceoff to rebake all theme fields	2018-10-18 17:05:34 +11:00
Guo Xiang Tan	22408f93c9	FIX: Wrap custom fields database statements in a transaction. Kind of strange that we don't do it because a database statement may fail and leave us in a weird state.	2018-10-18 12:23:04 +08:00
Guo Xiang Tan	44eba0bb60	FIX: Don't rescue `PG::UniqueViolation` within a transaction. Also acquire a transaction per link instead of failing when any of the links can't be processed. This prevents ActiveRecord from rolling back the transaction and the next SQL statement sent to PG will fail. This is however hard to test as it only happens when there are two competing process trying to process this method at the same time.	2018-10-18 10:54:30 +08:00
Guto Foletto	0abc932056	add styles so permalinks admin could fit mobile screen (#6496 )	2018-10-17 17:37:14 +02:00
Bianca Nenciu	f60b10d090	UX: Warn users if the post that's currently edited has changed. (#6498 )	2018-10-17 15:35:32 +02:00
David Taylor	065bf0762c	FEATURE: New plugin outlets for user card customization	2018-10-17 14:15:48 +01:00
David Taylor	c6f364224e	FEATURE: Allow plugins to whitelist user custom fields for public display (#6499 ) This works exactly the same as `whitelist_staff_user_custom_fields`, but is not limited to staff	2018-10-17 10:33:27 +01:00
Arpit Jalan	42c405a820	FIX: use topic summary for meta description if topic excerpt is blank	2018-10-17 14:13:30 +05:30
Joe	1b5ba899a1	UX: header items wrap on small screens for anon	2018-10-17 14:19:20 +08:00
Joe	5815a33a9a	FIX: closing an empty fullscreen composer with toggler prevents scrolling	2018-10-17 13:52:47 +08:00
Kris	b23ebf10c2	Minor post alignment fixes	2018-10-16 12:39:55 -04:00
Vinoth Kannan	e3c6dd26c4	FIX: Do not set null value to remove cookie	2018-10-16 06:48:54 +05:30
Sam	19d7543004	FIX: clear color scheme cache when clearing theme cache	2018-10-16 12:00:46 +11:00
Vinoth Kannan	08c404e138	FIX: Do not set null value to remove cookie	2018-10-16 06:12:32 +05:30
Sam	8d06731484	FIX: reduce amount of work onceoff does In the past onceoff was forcing inline download of gravatars, this can be so expensive that it will never finish This fix ensures it only marks avatars stale which will be picked up by regular schedules	2018-10-16 10:29:16 +11:00
Kyle Zhao	99d1ded3b3	rename route `/javascripts` to `/theme-javascripts` (#6495 )	2018-10-15 11:32:52 -04:00
Maja Komel	c104256991	FIX: SSO provider secrets - check wildcard domains last, toggle secrets visibility	2018-10-15 16:18:29 +02:00
Joffrey JAFFEUX	f6eff38c0e	FEATURE: adds list#(unread\|new) to user api key routes (#6494 )	2018-10-15 15:48:35 +02:00
David Taylor	7ac08f936e	FEATURE: Upload tags from CSV (#6484 )	2018-10-15 09:12:54 +01:00
Sam	4c8fe13500	FIX: remove code that restricted "header" theme field from admin There was some old code that restricted a percentage of a themes code from admin, only when admin was refreshed, this leads to lots of confusion Conditional is now removed	2018-10-15 17:29:10 +11:00
Maja Komel	27e732a58d	FEATURE: allow multiple secrets for Discourse SSO provider This splits off the logic between SSO keys used incoming vs outgoing, it allows to far better restrict who is allowed to log in using a site. This allows for better auditing of the SSO provider feature	2018-10-15 16:03:53 +11:00
Kyle Zhao	6acdea37c4	DEV: extract inline js when baking theme fields (#6447 ) * extract inline js when baking theme fields * destroy javascript cache when destroying theme fields This work is needed to support CSP work	2018-10-15 15:55:23 +11:00
Guo Xiang Tan	aa60936115	DEV: Add order to avoid randomly failing test.	2018-10-15 11:42:45 +08:00
Joe	2acb885c72	FEATURE: fullscreen composer mode on desktop Adds keyboard shortcut and icon that allows expanding composer to full screen.	2018-10-15 13:59:49 +11:00
Maja Komel	57b52cd1de	FIX: keep emoji syntax for custom emojis in quotes (#6488 )	2018-10-15 10:57:15 +08:00
Guo Xiang Tan	84d4c81a26	FEATURE: Support backup uploads/downloads directly to/from S3. This reverts commit `3c59106bac`.	2018-10-15 09:43:31 +08:00
Joe	6a59187ae8	UX: images should be responsive in embedded comments	2018-10-14 23:38:07 +08:00
Robin Ward	2178f7768f	FIX: Don't show empty user stats in the card when profile is hidden	2018-10-12 12:33:27 -04:00
Sam	a1c912b630	Return 400 instead of 404 for bad token	2018-10-12 10:51:41 +11:00
Bianca Nenciu	048cdfbcfa	FIX: Do not allow revoking the token of current session. (#6472 ) * FIX: Do not allow revoking the token of current session. * DEV: Add getter of current auth_token from Guardian.	2018-10-12 10:40:48 +11:00
Bianca Nenciu	e68ecf1f1d	UX: Add link to Groups in admin dashboard. (#6480 ) * UX: Add link to Groups in admin dashboard. * UX: Site settings have immediate effect.	2018-10-12 10:34:47 +11:00
Vinoth Kannan	39b7e32848	DEV: Require sso and sig query string params for sso_login	2018-10-12 05:03:30 +05:30
Blake Erickson	13b3cead06	FEATURE: Allow bulk removing users from a group This change maintains backwards compatibility to allow you to remove a single user from a group but allows you to specify a comma separated list of users for bulk removal from a group. Also it extracts out common functionality for fetching users from params used in bulk adding users so it can also be used for removing users.	2018-10-11 15:30:54 -06:00
Neil Lalonde	12f132736b	FIX: error looking at users in admin when tl3_promotion_min_duration is set to a very high value	2018-10-11 15:11:48 -04:00
Robin Ward	c2add85e75	FIX: Typo, should be `authentication` cc @xrav3nz	2018-10-11 14:58:46 -04:00
Bianca Nenciu	ded5ff90aa	FIX: Groups list does not refresh when query changes. (#6481 )	2018-10-11 21:20:17 +08:00
David Taylor	1b0fbc4d30	FIX: Allow theme edit route name to be overridden This is required for the theme-creator plugin, this change won't have any effect on regular Discourse installations	2018-10-11 13:20:04 +01:00
Vinoth Kannan	6a444eee56	Merge pull request #6476 from vinothkannans/tl4-flag FEATURE: automatically hide non-TL4 posts when flagged by a TL4 user	2018-10-11 17:13:26 +05:30
Vinoth Kannan	227a49bb32	FEATURE: automatically hide non-TL4 posts when flagged by a TL4 user	2018-10-11 17:11:46 +05:30
Bianca Nenciu	f1a52138d6	UX: Move Recently Used Devices to the bottom. (#6483 )	2018-10-11 19:22:30 +08:00
Jeff Wong	b5b382dcd6	Feature: add boxes with subcategories option for desktop categories page (#6471 ) * Feature: add boxes with subcategories option for desktop categories page * only add subclass div when subclasses exist	2018-10-11 15:59:37 +08:00
Bianca Nenciu	6275e745a7	FIX: Fix open quote links in new window. (#6477 )	2018-10-11 15:51:14 +08:00
Régis Hanol	09961fb425	FIX: properly escape name of custom emoji	2018-10-11 09:35:23 +02:00
Guo Xiang Tan	3c59106bac	Revert "FEATURE: Support backup uploads/downloads directly to/from S3." This reverts commit `c29a4dddc1`. We're doing a beta bump soon so un-revert this after that is done.	2018-10-11 11:08:23 +08:00
Gerhard Schlager	c29a4dddc1	FEATURE: Support backup uploads/downloads directly to/from S3.	2018-10-11 10:38:43 +08:00
Kyle Zhao	ffc241eb25	FIX: multiple loadScript to the same url may resolve prematurely (#6474 ) This is how `loadScript(url)` currently deals with multiple concurrent requests 1. Check existing `<script>` tags, and mark existing scripts (other than the input `url`) as loaded 2. Find "true" `url` of the requested resource (CDN, subfolder path, etc) 3. Check if we have loaded the resource with that "true" `url`, and resolve immediately if we have 4. Otherwise insert a `<script>` tag with the "true" `url` to load it For example, in a subfolder install: - Input `url` = `/javascripts/script.js` - "True" `url` = `/subfolder/javascript/script.js` And the _very_ subtle bug here is that we should use also use the true `url` for step (1), because: - Since the input and true `url` are different, we mistakenly mark the true `url` as loaded in step one - After finding the true `url`, and setting `loaded[trueUrl] = true` in (1), we resolve the promise prematurely, when the resource could still be loading	2018-10-11 08:55:36 +08:00
Robin Ward	a566ed42ae	FEATURE: Option to disable user presence and profile This allows users who are privacy conscious to disable the presence features of the forum as well as their public profile.	2018-10-10 17:34:33 -04:00
Kris	34e8d17ad0	Fixing left alignment of post controls	2018-10-10 12:11:47 -04:00
David Taylor	98211f945f	FIX: 'none' tag page would not load	2018-10-10 16:00:33 +01:00
Kris	94b115f7d9	increase contrast for $danger-medium on dark themes	2018-10-10 09:51:50 -04:00
Arpit Jalan	c84415b1f2	FEATURE: support category slug when creating new topic via URL	2018-10-10 17:06:02 +05:30
Guo Xiang Tan	ae6a5419e0	DEV: Report the backtrace as well.	2018-10-10 17:43:42 +08:00
Penar Musaraj	0ea8c1943f	Let plugins decorate banner topic, fixes local dates in banners (#6452 )	2018-10-10 17:27:23 +08:00
Kris	1f14fb5e1e	Don't override category badge icon color in similar topic JIT	2018-10-09 15:38:49 -04:00
Bianca Nenciu	1d26a473e7	FEATURE: Show "Recently used devices" in user preferences (#6335 ) * FEATURE: Added MaxMindDb to resolve IP information. * FEATURE: Added browser detection based on user agent. * FEATURE: Added recently used devices in user preferences. * DEV: Added acceptance test for recently used devices. * UX: Do not show 'Show more' button if there aren't more tokens. * DEV: Fix unit tests. * DEV: Make changes after code review. * Add more detailed unit tests. * Improve logging messages. * Minor coding style fixes. * DEV: Use DropdownSelectBoxComponent and run Prettier. * DEV: Fix unit tests.	2018-10-09 22:21:41 +08:00
Erin Kosewic	51aba32651	FEATURE: add branch option to remote theme import * FEATURE: add branch option to remote theme import * FIX: Add missing variable in params * FIX: Add missing param for import_theme method * SPEC: Add test methods for branch support in git import * FIX: Add missing space to scss style * Do not assume default branch as master * Change branch field placeholder * FIX: add missing div start tag	2018-10-09 17:01:08 +11:00
Kyle Zhao	acba7d2a5d	Extract `discourse_javascript.html.erb` to a scrip include * extract omniauth auth complete inline JS * extract Ember error logging inline JS * transpile `authentication-complete` This is CSP related work	2018-10-09 16:50:45 +11:00
Kyle Zhao	8b2a379e4e	DEV: transpile certain ES6 files without producing a module (#6460 ) `.js.no-module.es6` files will be transpiled without producing a module. import/export statements are deliberately not supported, so one would still need to use `const module = require('moduleName').default.`	2018-10-09 09:18:23 +08:00
Jeff Wong	e55f220b33	add category style boxes with featured topics option	2018-10-08 16:19:54 -07:00
Kris	c889c0daee	Only prevent checkbox/radio from flex-grow	2018-10-08 13:10:51 -04:00
Gerhard Schlager	97ad9e9d9b	UX: Prompt for custom invite message was hard to translate	2018-10-08 18:01:21 +02:00
Gerhard Schlager	eb3ed7f6fd	Add missing annotations	2018-10-08 18:01:21 +02:00
Kris	ec33b46d31	IE11 doesn't support nested calc	2018-10-08 11:55:54 -04:00
Joffrey JAFFEUX	da8916aecd	FIX: adds a title attribute on value list input (#6463 )	2018-10-08 12:08:36 +02:00
Joffrey JAFFEUX	22187508e3	FEATURE: adds header text/background color to site (#6462 )	2018-10-08 11:52:57 +02:00
Guo Xiang Tan	3c0ec317ac	DEV: Fix wizard qunit tests not running.	2018-10-08 14:45:56 +08:00
Guo Xiang Tan	43512e9865	Merge pull request #6457 from pmusaraj/yarn-manage-test-vendor-dependencies DEV: Use Yarn managed test vendor dependencies	2018-10-08 09:26:26 +08:00
Sam	550e108a8c	FEATURE: only export settings that changed via rake task	2018-10-08 11:54:52 +11:00
Kris	41ceb6ca88	topic body and small action widths inconsistent	2018-10-05 18:37:23 -04:00
David Taylor	cbb8f6f0fe	UX: Use 'trash' icon instead of 'times' for deleting small actions	2018-10-05 22:31:56 +01:00
Kris	0a1ac88f2c	last visit line needs more contrast	2018-10-05 15:28:10 -04:00
Kris	fa21b39875	FIX: topic admin menu was clipped on short posts due to overflow hidden	2018-10-05 10:51:27 -04:00
Penar Musaraj	be56f18cdd	Replace deprecated dropdown-button with DropdownSelectBoxComponent (#6451 )	2018-10-05 09:48:17 -04:00
David Taylor	75488257c5	FIX: Redirect users to top when `latest` is the homepage	2018-10-05 12:14:57 +01:00
David Taylor	9bf522f227	FEATURE: Mixed case tagging (#6454 ) - By default, behaviour is not changed: tags are made lowercase upon creation and edit. - If force_lowercase_tags is disabled, then mixed case tags are allowed. - Tags must remain case-insensitively unique. This is enforced by ActiveRecord and Postgres. - A migration is added to provide a `UNIQUE` index on `lower(name)`. Migration includes a safety to correct any current tags that do not meet the criteria. - A `where_name` scope is added to `models/tag.rb`, to allow easy case-insensitive lookups. This is used instead of `Tag.where(name: "blah")`. - URLs remain lowercase. Mixed case URLs are functional, but have the lowercase equivalent as the canonical.	2018-10-05 10:23:52 +01:00
Vinoth Kannan	8430ea927e	FIX: Generate webhook payloads before destroy events (#6325 )	2018-10-05 16:53:59 +08:00
Sam	5b630f3188	FIX: stop logging every time invalid params are sent Previously we were logging warning for invalid encoded params, this can cause a log flood	2018-10-05 14:33:19 +10:00
Kris	948c556cc6	decrease contrast on danger-low color	2018-10-04 17:30:10 -04:00
Kris	98b9913033	UX: Disable button hover effects on touch devices	2018-10-04 17:15:37 -04:00
Kris	ab1e5732d7	UX: Category colorpicker restyle	2018-10-04 15:47:46 -04:00
Vinoth Kannan	3faa022c6f	Merge pull request #6453 from vinothkannans/sso_provider_redirect FIX: redirect users to SSO client URL after social login	2018-10-05 00:34:34 +05:30
Vinoth Kannan	ca74246651	FIX: redirect users to SSO client URL after social login	2018-10-05 00:01:08 +05:30
Penar Musaraj	4ae9cb28e4	remove probes.js, highlight.pack.js	2018-10-04 13:50:54 -04:00
Kris	2e28116243	Period-chooser should have visible overflow	2018-10-04 12:28:48 -04:00
Kris	09caf95e7d	create account inputs too wide on iOS	2018-10-04 12:02:28 -04:00
Kris	8e0fe32f37	Minor login layout fixes	2018-10-04 11:54:51 -04:00
Bianca Nenciu	e0e0a91e7d	FIX: Retry sending email in case of temporary issue. (#6375 )	2018-10-04 22:56:24 +08:00
David Taylor	3c2608d41c	FIX: Correctly censor strings starting or ending with non-word characters (#6445 )	2018-10-04 15:15:10 +01:00
Bianca Nenciu	6ad13e5ae9	FIX: Avoid redirection when not leaving forum. (#6419 ) * FIX: Avoid redirection when not leaving forum. * DEV: Updated click-track's tests.	2018-10-04 22:06:31 +08:00
Kris	ff47609141	UX: Improve custom field layout on signup	2018-10-03 22:26:05 -04:00
Vinoth Kannan	a651d39b8a	FIX: Display errors in single theme pages (#6449 ) Currently the errors are not well handled. So it breaks the whole UI of admin themes list page.	2018-10-04 02:33:06 +05:30
Penar Musaraj	b5bdd42838	Progress bar CSS refactoring (#6444 ) * Less magic in calculating topic progress bar * more minor adjustments to topic progress CSS * Bounce back button again * Fix prettier warning	2018-10-03 13:21:57 -04:00
Kris	46563082a9	FIX: Move overflow from cooked to parent element to allow for slight overflow of blur/italic/shadow	2018-10-03 10:18:36 -04:00
Penar Musaraj	dc8a16b43b	Use Yarn to manage dependencies, cleanup unused bootstrap libs (#6436 )	2018-10-03 10:15:43 -04:00
Vinoth Kannan	23b4ab9bf9	DEV: Do not use concatenation in translations	2018-10-03 11:59:21 +05:30
Vinoth Kannan	2912170e9e	Update placeholder github url in correct format	2018-10-03 11:14:36 +05:30
Maja Komel	73443d889c	FIX: keep files in order when adding multiple uploads (#6306 ) * FIX: keep files in order when adding multiple uploads * use filename in the placeholder when uploading files * add tests * add consecutive nr to the placeholder when multiple uploads with the same filename	2018-10-03 11:12:36 +10:00
Kris	07be8e5447	caret icon is redundant on hamburger menu button	2018-10-02 15:06:50 -04:00
Neil Lalonde	dc1e7bb645	UX: when admin is deleted, make it clear in staff action logs when records belong to a deleted user and show their username in the details	2018-10-02 13:46:54 -04:00
Penar Musaraj	98aaad6675	Improve "hit area" for topic progress bar on mobile (#6442 ) * Improve "hit area" for topic progress bar on mobile * Only target admin wrench on mobile	2018-10-02 12:26:16 -04:00
Kris	7228c4964c	Flag reason "something else" fix	2018-10-02 12:05:21 -04:00
Penar Musaraj	34516c72bd	FIX: Recover public actions (likes) when recovering a post (#6412 )	2018-10-02 11:25:08 -04:00
Kris	324b57c207	Prevent flexbox from shrinking inputs	2018-10-02 10:42:49 -04:00
Gerhard Schlager	7fe17e93e2	UX: Label of checkbox site setting needs a span for nested HTML	2018-10-02 16:25:05 +02:00
Gerhard Schlager	3a6ab02563	FEATURE: Notify admins when scheduling of backup fails	2018-10-02 15:48:16 +02:00
Jeff Atwood	40d0fc9259	UX: slightly taller progress bar for mobile	2018-10-02 03:21:08 -07:00
Joffrey JAFFEUX	a515ba8612	FIX: corrects typo and adds a spec for likes report (#6439 ) * FIX: corrects typo and adds a spec for likes report * save!	2018-10-02 02:27:43 -07:00
Joffrey JAFFEUX	f34d9202b4	UX: makes reports fade in when loading is done (#6440 )	2018-10-02 09:20:04 +02:00
Kyle Zhao	7591da1e64	FIX: `s3BaseUrl` with small s	2018-10-02 13:06:33 +08:00
Bianca Nenciu	719a433c03	FIX: Sync client & server rules regarding tag names. (#6400 )	2018-10-01 21:45:44 -07:00
Kyle Zhao	d9bea66365	UX: confirmation before changing group membership in admin (#6426 )	2018-10-01 21:34:08 -07:00
Kyle Zhao	ab448ca8f3	extract client side `Discourse` setup inline JS (#6409 )	2018-10-01 21:29:04 -07:00
Sam	580c923ff3	UX: remove flex basis from first item We do not want to take up 100% width for name/username on first line	2018-10-02 13:16:51 +10:00
Sam	120c220c18	UX: correct ordering of username / fullname in UX	2018-10-02 12:56:50 +10:00
Penar Musaraj	533315a607	Fix progress bar position when theme has header elements outside #main (#6425 )	2018-10-02 10:45:23 +10:00
Kris	42066e407d	UX: updating style of mobile navigation dropdown	2018-10-01 14:49:00 -04:00
Kris	eeffac3186	label needs a span to contain nested HTML in description	2018-10-01 13:42:35 -04:00
Kris	1897155479	prettier	2018-10-01 11:59:21 -04:00
Kris	eca671b972	Prevent category dropdowns from cropping text, simplify styles	2018-10-01 11:53:18 -04:00
Maja Komel	1add11d8c9	FIX: don't send multiple requests when changing category notification (#6435 )	2018-10-01 23:41:23 +08:00
Kris	fc4a6ca724	Prevent adming setting input from being too small in Safari	2018-10-01 10:39:55 -04:00
Prssanna Desai	8bb0bca808	UX: Improve spacing & alignment for Category edit modal (#6432 )	2018-10-01 10:21:40 -04:00
Prssanna Desai	f1bc1780a6	FIX: hide Delete Category button while creating a new category	2018-10-01 14:31:05 +02:00
Guo Xiang Tan	05fe5c9188	Fix onceoff job in `cfa7173da3` not running.	2018-10-01 18:37:05 +08:00
Guo Xiang Tan	cf60ae32ea	FIX: Onceoff job to fix missing user profile backgrounds.	2018-10-01 18:31:09 +08:00
Guo Xiang Tan	d8fa7fbbab	Fix onceoff job in `cfa7173da3` not running.	2018-10-01 17:14:04 +08:00
Guo Xiang Tan	cfa7173da3	FIX: Onceoff job to fix missing user profile backgrounds.	2018-10-01 16:26:40 +08:00
Kyle Zhao	d0f660806d	FIX: close `data-preloaded` div tag	2018-10-01 15:24:27 +08:00
Kyle Zhao	373d6e3fe6	always `loadScript` with a script tag (#6411 ) to avoid Content Security Policy unsafe-line violations	2018-10-01 10:06:01 +08:00
Robin Ward	02da022c70	PERF: Quit out of the email job quickly if disabled (#6423 ) This prevents sidekiq from doing a bunch of queries when email is disabled. Critical emails are a special case and will be sent.	2018-10-01 01:15:45 +08:00
Kyle Zhao	819f090d6a	move large blobs out of `<head>` (#6428 ) it unnecessarily bloats the section and increases the payload dramatically for open graph tags.	2018-09-28 17:28:33 +08:00
Gerhard Schlager	b0a383561e	FEATURE: Add Lithuanian locale	2018-09-27 05:26:38 +02:00
David Taylor	19c9a6699a	FIX: Validate auto_close_hours category setting This prevents server errors when the value is set too high	2018-09-26 16:04:49 +01:00
Kyle Zhao	e2462ada68	FIX: make theme import's public key field `readonly` (#6424 ) `disabled` attribute prevents the user from clicking or selecting in the control whereas `readonly` does not.	2018-09-24 09:12:49 +08:00
David Taylor	84f5448a92	FEATURE: Display trust level descriptions in site settings (#6421 )	2018-09-21 15:10:38 +01:00
Joe	b44bcdefd9	UX: improves topic-title flexbox alignment	2018-09-21 12:41:35 +08:00
Kyle Zhao	e402394375	FEATURE: auto grant an available title when removing old title * FEATURE: auto grant an available title when removing old title	2018-09-21 12:06:08 +10:00
Sam	e622adfb89	correct warning	2018-09-21 12:05:08 +10:00
Sam	ae674dcb4e	Merge branch 'theme-select-mobile' of https://github.com/jjaffeux/discourse	2018-09-21 12:04:07 +10:00
Kyle Zhao	4bb980b9f7	FEATURE: do not allow moderators to export user list (#6418 )	2018-09-21 09:07:13 +08:00
Kris	5f042a2c8d	Prevent move to new topic tag input from becoming too wide on click	2018-09-20 16:12:08 -04:00
Arpit Jalan	3e17ef0507	Merge pull request #6414 from techAPJ/user-field-unique-key FEATURE: add external details to user fields	2018-09-20 22:29:39 +05:30
Kris	e43a05fa10	Timeline back button too tall	2018-09-20 10:28:26 -04:00
Joffrey JAFFEUX	87a97cbf4b	Merge branch 'master' into theme-select-mobile	2018-09-20 10:31:41 +02:00
Sam	df45e82377	SECURITY: only allow picking of avatars created by self (#6417 ) * SECURITY: only allow picking of avatars created by self Also adds origin tracking to all uploads including de-duplicated uploads	2018-09-19 22:33:10 -07:00
Guo Xiang Tan	195bd02fce	FIX: Avoid race condition when enqueuing job.	2018-09-20 11:24:01 +08:00
Arpit Jalan	72be638728	FEATURE: add external details to user fields	2018-09-20 08:10:51 +05:30
Kris	dfbc93aa2e	Prevent post date from overflowing with long usernames	2018-09-19 18:53:48 -04:00
Gerhard Schlager	681262ddce	FIX: Backup logs were usually missing the first few lines And because of debouncing, the log wasn't always reset at the beginning of a backup or restore.	2018-09-19 20:27:35 +02:00
Gerhard Schlager	18d5d51d98	UX: Remove double scrollbars from backup logs * Removes the wrapping, because the log is easier to read without it. * Fixes the automatic scrolling to the bottom, which didn't work anymore	2018-09-19 20:27:34 +02:00
Joe	8d6ccde402	UX: removes bottom margins from inputs in admin controls	2018-09-20 00:32:41 +08:00
Joe	2144009520	UX: ensure ac-wrap input height matches other inputs	2018-09-20 00:02:45 +08:00
Joe	0010e7ddd2	UX: better padding for multi-select items	2018-09-19 23:56:26 +08:00
Joe	026bab116a	UX: label alignment for Firefox / IE	2018-09-19 23:48:48 +08:00
Guo Xiang Tan	d41f74578a	Fix JS build.	2018-09-19 23:12:34 +08:00
Guo Xiang Tan	767f27929d	Rename `Jobs::RecoverPostUploads` to rerun the job take 2.	2018-09-19 22:40:32 +08:00
Joe	b64436ba09	UX: select-kit filter input size fix	2018-09-19 22:05:56 +08:00
Guo Xiang Tan	6dbe1d832d	Rename `Jobs::RecoverPostUploads` to rerun the job. Running a migration to destroy the onceoff job doesn't work because an instance running the old code may execute the job.	2018-09-19 21:59:44 +08:00
Joe	0ac64b6d50	UX: radio / checkbox inputs margin fix	2018-09-19 21:22:40 +08:00
Joe	8fb50a7e8b	UX: last-seen input alignment fix	2018-09-19 21:20:04 +08:00
Joe	9e9fdac023	UX: multi-select items alignment fixes	2018-09-19 21:14:27 +08:00
Joe	acd18ff9d8	Fixes typo	2018-09-19 21:08:03 +08:00
Joe	e844fa5370	UX: general cleanup of inputs, buttons and select elements - part 1	2018-09-19 20:37:04 +08:00
Guo Xiang Tan	667e68ec58	Prefer `create` over `create!` when not checking for response.	2018-09-19 18:22:54 +08:00
Sam	e0e6dae6a7	minor cleanup to previous commit from code review	2018-09-19 16:07:29 +10:00
Sam	5302709343	FIX: in redis readonly raise an exception from DistributedMutex If we detect redis is in readonly we can not correctly get a mutex raise an exception to notify caller When getting optimized images avoid the distributed mutex unless for some reason it is the first call and we need to generate a thumb In redis readonly no thumbnails will be generated	2018-09-19 15:50:58 +10:00
Sam	abc39c492a	FIX: in redis readonly raise an exception from DistributedMutex If we detect redis is in readonly we can not correctly get a mutex raise an exception to notify caller When getting optimized images avoid the distributed mutex unless for some reason it is the first call and we need to generate a thumb In redis readonly no thumbnails will be generated	2018-09-19 15:49:18 +10:00
Guo Xiang Tan	4a92c5b2d6	`UploadRecovery` should recover attachments too.	2018-09-19 10:44:36 +08:00
Vinoth Kannan	4383afb769	Merge pull request #6413 from vinothkannans/log-entity-export FEATURE: Log entity export in staff logs	2018-09-19 03:18:28 +05:30
Vinoth Kannan	9281b72308	FEATURE: Log entity export in staff logs	2018-09-19 03:16:45 +05:30
Jeff Atwood	f43b5bb3c1	considerably simplify copy for change owner	2018-09-18 14:15:08 -07:00
Kris	e95d6a12c5	prettier	2018-09-18 13:39:58 -04:00
Kris	8bfb016386	remove trailing spaces	2018-09-18 13:25:50 -04:00
Kris	d20a174a6b	UX: Lighter style for category and tag dropdown nav	2018-09-18 13:11:00 -04:00
Kris	4cf3ef53bc	Prevent spinner in tag dropdown from being squished	2018-09-18 11:27:01 -04:00
Joffrey JAFFEUX	a713c0d366	FIX: ensures onSelect/onDeselect are called This commit also add a FIX and a test for toolbar-popup-menu-options which had a behavior slightly specific.	2018-09-18 11:31:23 +02:00
Sam	7b70a208ba	SECURITY: correct XSS on long topic titles	2018-09-18 08:56:10 +10:00
Sam	7d6b348d0b	SECURITY: correct XSS on long topic titles	2018-09-18 08:54:44 +10:00
Sam	c662e0918f	SECURITY: remove admin memory diagnostics routes	2018-09-18 08:36:24 +10:00
Sam	0e9841b995	SECURITY: remove admin memory diagnostics routes	2018-09-18 08:35:09 +10:00
Joffrey JAFFEUX	2ff2c49908	Revert "FIX: ensures onSelect/onDeselect are called" This reverts commit `52eed73294`.	2018-09-17 22:14:41 +02:00
Kris	7f420b61cb	Removing unneeded theme intro text	2018-09-17 12:00:20 -04:00
Neil Lalonde	6f1b8ad16d	FIX: tag groups page should only be visible to staff No security concern here because nothing private was visible, and no actions could be taken by non-staff users.	2018-09-17 11:41:18 -04:00
Régis Hanol	4481836de2	FEATURE: new 'search_ignore_accents' site setting	2018-09-17 10:42:30 +02:00
Joffrey JAFFEUX	52eed73294	FIX: ensures onSelect/onDeselect are called	2018-09-17 10:36:14 +02:00
Kyle Zhao	7a0232249a	extract inline JS that's used to store preloaded data (#6370 )	2018-09-17 16:31:46 +08:00
Joffrey JAFFEUX	01913b9dc0	FIX: improves themes/components UI on mobile	2018-09-17 10:05:18 +02:00
Kyle Zhao	7b19ed06c1	reworked specs of existing group behavior	2018-09-17 17:46:43 +10:00
Kyle Zhao	6659417807	FEATURE: match user title when primary group changes When primary group changes and the user's title is the previous primary group's title, change the title to the new primary group's title	2018-09-17 15:08:39 +10:00
Sam	33541c4096	FEATURE: unconditionally omit no-follow for staff Previously TL2 and below staff would have links no-followed which was never intended	2018-09-17 12:02:20 +10:00
Sam	b63630d70b	use Mixin postfix when importing tags mixin	2018-09-17 10:46:57 +10:00
pmusaraj	0a2efd8ff1	Add async search to tags dropdown, always show selected tag	2018-09-17 10:40:47 +10:00
Joffrey JAFFEUX	e51c676135	refactors trending search report to use SearchLog	2018-09-17 10:19:40 +10:00
Bianca Nenciu	8f39cf6bfc	FIX: Permit unpinning an unlisted topic.	2018-09-17 10:03:06 +10:00
Kyle Zhao	f666d72606	extract inline JS for google tag manager	2018-09-17 09:56:00 +10:00
Kyle Zhao	38c70bfda2	extract inline JS for google analytics	2018-09-17 09:56:00 +10:00
OsamaSayegh	5625461c05	clear error if you can contact theme repo again	2018-09-17 09:49:53 +10:00
OsamaSayegh	c9a5438a88	use `woman_artist` emoji	2018-09-17 09:49:53 +10:00
OsamaSayegh	c7d81e2682	FIX/FEATURE: don't blow up when can't reach theme's repo, show problem themes on dashboard	2018-09-17 09:49:53 +10:00
OsamaSayegh	ca28548762	feedback (see commit description for details) * fill blank space when no theme is selected * animate row's height in themes/components list when selecting, and hide children list * show warning when you move to a different page and have unsaved changes * refactor `adminCustomizeThemes.show` controller * allow collapsing/expanding children lists * fix a bug when adding components to a theme (changed the way it works slightly) * a bunch of other minor things	2018-09-17 09:49:53 +10:00
OsamaSayegh	a4f057a589	UX: improvements to admin theme UI	2018-09-17 09:49:53 +10:00
Kris	2ef16d0719	button missing no-text class	2018-09-14 20:52:25 -04:00
Jeff Atwood	7e5000b472	change close to delete glyph on associated accounts	2018-09-14 12:01:49 -07:00
Kris	acddbe22c6	FIX: Poll modal date selector width	2018-09-14 13:38:58 -04:00
Sam	419b14e58b	FIX: correctly keep stylesheet cache entries The intent from day one was to keep MAX_TO_KEEP stylesheets per target however the DELETE statement did not perform target filtering This meant we often deleted the wrong stylesheets from the cache	2018-09-14 12:54:11 +10:00
Guo Xiang Tan	8ddcb6564e	FIX: Onceoff job to recover missing post uploads. This fixes the regression due to `1f636c445b`	2018-09-14 10:52:33 +08:00
Guo Xiang Tan	9d81a6cc72	DEV: Avoid using `send` and make the method public instead.	2018-09-14 10:52:16 +08:00
Guo Xiang Tan	dffd4fa9e6	Add extra protection in `Upload#get_from_url`. In case the extension goes missing from the URL.	2018-09-14 10:49:34 +08:00
Régis Hanol	39a2d92417	FIX: don't index urls to local files	2018-09-14 12:31:35 +10:00
Guo Xiang Tan	6a2589353b	Merge pull request #6394 from tgxworld/recover_broken_uploads FIX: Onceoff job to recover missing post uploads.	2018-09-13 18:16:56 -07:00
Guo Xiang Tan	aa1af9fc22	FIX: Onceoff job to recover missing post uploads. This fixes the regression due to `1f636c445b`	2018-09-14 09:04:01 +08:00
Régis Hanol	30619c244c	FIX: don't index urls to local files	2018-09-13 18:53:53 +02:00
Joffrey JAFFEUX	a6502ce879	FIX: ensures errors in report initialization fail nicely (#6392 )	2018-09-13 17:36:55 +02:00
Joffrey JAFFEUX	18fcd483f2	FIX: ensures we have a color for reports (#6396 )	2018-09-13 17:36:39 +02:00
Joffrey JAFFEUX	7bf8b0d305	FIX: treats users_(by_type\|tl) as other reports (#6391 )	2018-09-13 17:35:54 +02:00
Guo Xiang Tan	2ae7d3a118	Merge pull request #6388 from pmusaraj/drafts-second-user-test Add test to ensure a user cannot see drafts stream of another user	2018-09-13 06:53:44 -07:00
pmusaraj	5bdf476de7	raise error early in drafts controller	2018-09-13 08:40:57 -04:00
Arpit Jalan	74eec1849d	FIX: ignore and log bad json values for custom fields	2018-09-13 17:42:48 +05:30
Arpit Jalan	d288462abf	Merge pull request #6393 from techAPJ/bad-json FIX: ignore and log bad json values for custom fields	2018-09-13 15:54:01 +05:30
Arpit Jalan	e364547ff7	FIX: ignore and log bad json values for custom fields	2018-09-13 14:26:30 +05:30
Guo Xiang Tan	529e4018f0	DEV: Avoid using `send` and make the method public instead.	2018-09-13 16:34:32 +08:00
Sam	daa02431df	FIX: remove div used to measure textarea position Also corrects the positioning of autocomplete (when typing @ or emoji) Previously there were edge conditions where autocomplete would be hundreds of pixels away due to a bug measuring. This correct an issue where Firefox ends up having an enormous blank space at the bottom of topics after editing.	2018-09-13 14:53:32 +10:00
pmusaraj	aa614e393c	return 403 when trying drafts of another user	2018-09-12 13:08:02 -04:00
Joffrey JAFFEUX	38668818a5	FIX: allows forcing unsafe string in select-kit (#6386 ) forceEscape will be defaulted to true before next release.	2018-09-12 12:19:04 +02:00
Guo Xiang Tan	3884e99e88	Add extra protection in `Upload#get_from_url`. In case the extension goes missing from the URL.	2018-09-12 00:12:14 -07:00
Guo Xiang Tan	f31758cc70	FIX: Uploads not being linked correctly to posts. Regression due to `1f636c445b`.	2018-09-11 23:54:07 -07:00
Guo Xiang Tan	b3469bea2d	FIX: Uploads not being linked correctly to posts. Regression due to `1f636c445b`.	2018-09-11 23:50:23 -07:00
Sam	d1984a0b4d	FIX: display a correct error when attempting to agree on a deferred flag Previously we would raise a 500 error if a moderator tried to agree on a flag another moderator deferred. This can happen cause the UX for flags does not live refresh as flags are handled	2018-09-12 13:16:59 +10:00
Guo Xiang Tan	71185c13b5	Merge pull request #6377 from tgxworld/remove_tif_tiff Drop `tif`, `tiff`, `webp` and `bmp` from supported images.	2018-09-12 09:32:32 +08:00
Guo Xiang Tan	e1b16e445e	Rename `FileHelper.is_image?` -> `FileHelper.is_supported_image?`.	2018-09-12 09:22:28 +08:00
Osama Sayegh	16bd3f2cf2	FIX: use current user color scheme when filling `theme-color` attribute (#6384 ) * FIX: use current user color scheme when filling `meta` attribute `theme-color` * update manifest.webmanifest colors	2018-09-12 11:04:58 +10:00
Guo Xiang Tan	a033327b93	Manage qunit via yarn.	2018-09-11 15:07:28 +08:00
Neil Lalonde	ea7ee8e9f7	Merge master	2018-09-10 19:39:09 -04:00
Sam	a5ae7ee8e2	SECURITY: correct edge case when SSO provides unvalidated emails	2018-09-11 08:25:19 +10:00
Sam	e64402cb3b	SECURITY: correct edge case when SSO provides unvalidated emails	2018-09-11 08:24:02 +10:00
Blake Erickson	1d41f3c3fb	Merge pull request #6380 from discourse/rake-destroy-sub-category FIX: Allow `rake destroy:topics` to delete topics in sub-categories	2018-09-10 10:26:04 -06:00
Kris	2b7e50cab8	Prevent fade-out from overlapping button in admin nav	2018-09-10 11:25:41 -04:00
David Taylor	84fc7abb73	FIX: Allow `rake destroy:topics` to delete topics in sub-categories	2018-09-10 12:52:14 +01:00
Joffrey JAFFEUX	d4080c020f	FIX: sets trends to 7 days instead of 3 (#6379 )	2018-09-10 10:40:19 +02:00
Guo Xiang Tan	04d26c65e2	Refactor `Upload.get_from_url` to check length of sha1.	2018-09-10 10:10:39 +08:00
Joffrey JAFFEUX	2ad882113e	FIX: corrects top-referred and trending-search dates (#6372 )	2018-09-07 16:49:44 +02:00
Neil Lalonde	9e77fd8fc3	FIX: wrong category links on subfolder install in rss feed for a category topic list	2018-09-07 10:03:30 -04:00
Guo Xiang Tan	d788555994	DEV: Manage pretender with yarn.	2018-09-07 16:01:49 +08:00
Guo Xiang Tan	039afe0d2c	Apply prettier.	2018-09-07 15:19:34 +08:00
Sam	879067d000	FIX: check admin theme cookie against user selectable previously admin got a free pass and could set theme via cookie to anything including themes that are not selectable this refactor ensures that only "preview" gets a free pass, all the rest goes through the same pipeline	2018-09-07 10:47:28 +10:00
Gerhard Schlager	797cbf8653	FIX: Remove user fields when anonymizing user	2018-09-07 00:02:56 +02:00
Joffrey JAFFEUX	6c1e70d554	FIX: do no reset tags selection on category selection (#6369 ) We will instead implement a server side solution to this in the future.	2018-09-06 10:35:07 +02:00
Sam	56b6a4779d	FIX: make route to tag more robust There are some edge cases where code would fail here, so adding protection	2018-09-06 17:24:32 +10:00
Guo Xiang Tan	1f636c445b	PERF: Add fast path to find uploads before resorting to `LIKE` query. For a normal upload url Before ``` Warming up -------------------------------------- 264.000 i/100ms Calculating ------------------------------------- 2.754k (± 8.4%) i/s - 13.728k in 5.022066s ``` After ``` Warming up -------------------------------------- 341.000 i/100ms Calculating ------------------------------------- 3.435k (±11.6%) i/s - 17.050k in 5.045676s ```	2018-09-06 14:44:24 +08:00
Guo Xiang Tan	d4b05d7bc5	Always link post to uploads in post process. The operation is cheap anyway so no point skipping.	2018-09-06 14:08:03 +08:00
Guo Xiang Tan	b6a139b581	Fix broken spec.	2018-09-06 12:41:43 +08:00
Guo Xiang Tan	434035f167	FIX: Link post to uploads in `PostCreator`. * This ensures that uploads are linked to their post on creation instead of a background job which may be delayed if Sidekiq is facing difficulties.	2018-09-06 11:18:11 +08:00
Sam	5bdc00c3be	FIX: do not automatically route all actions to hovered posts This feature (hitting d when a post is hovered with mouse deletes) causes a lot of confusion and is very risky.	2018-09-06 10:34:58 +10:00
Kris	8cff3c9bbc	UX: Prevent long names from overflowing post	2018-09-05 17:48:31 -04:00
Joffrey JAFFEUX	e59622f2ba	FIX: deactivate chart trends for now (#6364 )	2018-09-05 23:33:29 +02:00
Kris	1c65969bb4	post read-state icon alignment	2018-09-05 13:19:36 -04:00
Joffrey JAFFEUX	17087eff2a	FIX: Reset tags on category change (#6363 )	2018-09-05 17:18:52 +02:00
Gerhard Schlager	3134dd4763	FIX: Wizard didn't change locale when Enter key was used in drop-down	2018-09-05 15:14:09 +02:00
Gerhard Schlager	2801376df5	FIX: Wizard didn't load translations correctly * Translations from the js.* namespace were not found, because the i18n-patches were not loaded. * The extra-locales didn't use a hash in the URL.	2018-09-05 15:14:09 +02:00
Gerhard Schlager	2c5d9269a0	FIX: Notifications shouldn't use user locale unless allow_user_locale is enabled	2018-09-05 11:44:28 +02:00
Sam	d9c0dc8687	correct prev commit s3. did not exists it is s3-	2018-09-05 16:11:44 +10:00
Sam	83e1315e42	FIX: correct urls in uploads table to point at dualstack Last week we added support for dual stack urls but did not remap the the old records in the uploads and optimized images table This caused a few minor edge cases worst was that if you rebaked old images S3 CDN was not repopulated.	2018-09-05 15:58:04 +10:00
Gerhard Schlager	9d35240620	Revert "FIX: Notifications shouldn't use user locale unless allow_user_locale is enabled" This reverts commit `c788737eed`.	2018-09-05 01:53:22 +02:00
Gerhard Schlager	c788737eed	FIX: Notifications shouldn't use user locale unless allow_user_locale is enabled	2018-09-05 00:47:39 +02:00
Vinoth Kannan	8a952a2cc2	Make prettier happy	2018-09-05 02:00:13 +05:30
Kris	5cf1a9a23a	UX: primary & danger buttons should lighten on hover in dark themes	2018-09-04 16:18:10 -04:00
Vinoth Kannan	d8b543bb67	FIX: redirect to original URL after social signup	2018-09-05 01:44:23 +05:30
David Taylor	4382fb5fac	DEV: Allow plugins to whitelist specific user custom_fields for editing (#6358 )	2018-09-04 20:45:36 +10:00
Sam	e4498d2a8a	FIX: keep db and job correctly in multisite logs This ensures we report job and db correctly, previously we were only reporting this on default	2018-09-04 16:05:44 +10:00
Sam	ad70502ab8	FIX: ignore invalid usernames in incoming link tracker If an incoming link username has NULL in it simply ignore it	2018-09-04 12:28:32 +10:00
Guo Xiang Tan	8dc1463ab3	Enable `Lint/ShadowingOuterLocalVariable` for Rubocop.	2018-09-04 10:16:42 +08:00
Sam	2f5c21e28c	FIX: return a 400 error instead of 500 for null injections Many security scanners like to inject NULL in inputs causing application to exception out and return a 500 We now handle this exception and render a 400 status back	2018-09-04 12:11:52 +10:00
Sam	3748d3e281	UX: hide associate accounts if second factor is enabled Once second factor is enabled all login via associated accounts is banned showing this section just leads to confusion	2018-09-04 10:42:39 +10:00
Sam	155eb02c7e	UX: remove auth token log from user page This feature is not quite ready so we are deferring on it for a few more weeks	2018-09-04 10:28:33 +10:00
Vinoth Kannan	fe6c3b7d2e	Make prettier happy	2018-09-04 00:31:41 +05:30
Vinoth Kannan	24a14af15a	FIX: Respect invalidate_oneboxes option for inline oneboxes	2018-09-03 22:33:43 +05:30
Gerhard Schlager	f33433bf9e	Validation of params should restrict to max int (#6331 ) * FIX: Validation of params should restrict to max int * FIX: Send status 400 when "page" param isn't between 1 and max int	2018-09-03 14:45:32 +10:00
Guo Xiang Tan	59c9051a2e	REFACTOR: Rescue error at the specific spot that is raising the error.	2018-09-03 11:04:58 +08:00
Guo Xiang Tan	7256b3bf68	REFACTOR: Use `UserAuthTokenLogSerializer` instead of conditionals.	2018-09-03 10:44:22 +08:00
Jeff Atwood	c3a898795a	Merge pull request #6351 from gschlager/btn_primary UX: Primary button didn't have hover effect anymore	2018-09-02 14:26:40 -07:00
Bianca Nenciu	f5e0356fb2	correct miscellaneous issues with user login history	2018-09-02 17:24:54 +10:00
Osama Sayegh	8e70b82baa	FIX: maintain theme preview when refreshing (#6356 )	2018-09-02 17:23:46 +10:00
Rishabh Nambiar	4194d1f875	UX: Add padding between fa-chevron-up/down and heading for groups page	2018-09-01 10:14:54 +05:30
Gerhard Schlager	16974df1e9	FIX: Resetting site setting didn't remove "overriden" state	2018-09-01 02:09:23 +02:00
Neil Lalonde	f0b551b684	UX: avatar on collapsed user profile was the wrong size	2018-08-31 10:38:58 -04:00
Bianca Nenciu	39414068ff	FIX: User agent browser detection (#6352 )	2018-08-31 14:49:38 +02:00
Gerhard Schlager	ddfd02ad36	FIX: Deleting backup failed after uploading backup	2018-08-31 13:50:32 +02:00
Gerhard Schlager	91b3f200f4	UX: Primary button didn't have hover effect anymore	2018-08-31 12:14:41 +02:00
Gerhard Schlager	5310b4841d	UX: Show Rollback and Backup buttons on same line	2018-08-31 12:01:59 +02:00
Guo Xiang Tan	5a214a687c	FIX: Exclude `UserAuthToken` and `UserAuthTokenLog` in user webhook.	2018-08-31 17:25:56 +08:00
Régis Hanol	6ada825a4d	fix linting	2018-08-31 10:49:44 +02:00
Bianca Nenciu	931cffcebe	FEATURE: Let users see their user auth tokens. (#6313 )	2018-08-31 10:18:06 +02:00
Sam	b3aab1770f	FIX: set old last modified date for invalid avatars In some cases Akami was holding tight to these invalid avatars, to avoid this happening we explain the avatar image is ancient then when a new upload is added it automatically is older than this.	2018-08-31 17:07:31 +10:00
Sam	e1975e293f	FIX: when uploads are destroyed clear up avatar refs in user table This also auto corrects twice daily when we ensure consistency	2018-08-31 14:46:42 +10:00
Arpit Jalan	6b9aeeea73	bump onebox version	2018-08-31 08:40:36 +05:30
Sam	9b7cab589a	FIX: revert diacritic stripping See more details in test case and at: https://meta.discourse.org/t/discourse-should-ignore-if-a-character-is-accented-when-doing-a-search/90198/16?u=sam	2018-08-31 11:46:55 +10:00
Joshua Rosenfeld	f3afc0cf76	Add raw date to title attribute on old flags page (#6349 )	2018-08-31 11:01:10 +10:00
Blake Erickson	ae532f8548	FIX: return 422 for an invalid group name on category create	2018-08-30 14:28:55 -06:00
Joffrey JAFFEUX	bb93179609	FEATURE: charts will now use tertiary color (#6342 )	2018-08-30 14:56:11 +02:00
David Taylor	825dee5598	SECURITY: Prevent users from modifying custom fields	2018-08-30 13:00:51 +01:00
David Taylor	103509b9dd	SECURITY: Prevent users from modifying custom fields	2018-08-30 12:59:36 +01:00
Vinoth Kannan	3eff6a0e9b	DEV: Export Tag class to modify methods in plugin	2018-08-30 16:53:02 +08:00
Guo Xiang Tan	0f812aa768	Make prettier happy.	2018-08-30 15:56:30 +08:00
Guo Xiang Tan	4f81d4cc8e	Minor fixes to `Jobs::BulkInvite`.	2018-08-30 15:35:16 +08:00
Vinoth Kannan	092fb0c170	Merge pull request #6333 from vinothkannans/rich-text-pasting FIX: Use tight list format for GDocs html to markdown	2018-08-30 12:14:50 +05:30
David Taylor	f0abb4d09a	FIX: Allow user actions to be saved even if the post has nil user This issue made it impossible to delete users if they had flagged a post with nil user	2018-08-30 01:03:32 +01:00
Sam	e6970151a6	FEATURE: allow specifying locale via SSO Use: locale locale_force_update To force user locale on users where SiteSetting.allow_user_locale is enabled Note: If an invalid locale is specified no action will occur	2018-08-30 09:58:03 +10:00
Jeff Atwood	22110d3106	minor copyedit on pm a/r button	2018-08-29 16:51:38 -07:00
Bianca Nenciu	72ffabf619	UX: Improve email testing admin tool. (#6308 )	2018-08-29 23:14:16 +02:00
Bianca Nenciu	c1a5a7504e	FIX: Reset email preferences controller. (#6316 )	2018-08-29 23:10:56 +02:00
Vinoth Kannan	4c99acea1b	FIX: Use tight list format for GDocs html to markdown	2018-08-29 16:21:31 +00:00
Kris	8ff83d174e	FIX: Changing tag name class to data attribute (#6326 )	2018-08-29 10:49:19 -04:00
Kris	78089e3577	Removing unneeded background color	2018-08-29 08:58:28 -04:00
Gerhard Schlager	b2cf725700	FIX: Don't try to send invite email when invite was deleted	2018-08-29 12:43:12 +02:00
Joffrey JAFFEUX	1281fb964e	FIX: prevents remove user btn to overflow parent (#6329 )	2018-08-29 10:11:44 +02:00
Vinoth Kannan	26f17150e1	Merge pull request #6327 from vinothkannans/rich-text-pasting FIX: Keep emojis and remove clicks count on html to markdown	2018-08-29 13:38:55 +05:30
Joffrey JAFFEUX	ad34bdca09	UI: minor tweaks to new message participants list (#6328 ) * Icon for button * Display name when editing on mobile * Always display name on mobile when less/or 4 participants involved	2018-08-29 10:07:49 +02:00
Vinoth Kannan	fb35b0b3c3	FIX: Keep emojis and remove clicks count	2018-08-29 07:26:25 +00:00
Sam	44cf3cf975	FIX: queue heartbeats in readonly modes If sidekiq is paused or Discourse is in readonly continue to queue heartbeats If we do not do that then a master process can end up reaping sidekiq workers and causing various badness This also impacts restore which can do weird stuff TM in cases like this	2018-08-29 12:36:59 +10:00
Neil Lalonde	7516f5159e	FIX: /rules route showed error page	2018-08-28 20:40:37 -04:00
Kris	feeaac81df	FIX: Mobile admin menu iOS rendering bug	2018-08-28 16:39:20 -04:00
Kris	3a4a6cb41a	alignment fix	2018-08-28 16:27:34 -04:00
Kris	7deb86ad8b	A more subtle mobile lightbox hint	2018-08-28 15:25:54 -04:00
Sam	740308675b	FEATURE: erode bounce score every time an email is sent Introduces a hidden setting (default is 0.1) that erodes bounce score every time we send an email. This means that erratic failures are less painful cause system auto corrects	2018-08-28 17:02:12 +10:00
Kyle Zhao	e25a6e085e	FIX: drop title updates through RSS feeds can create an update loop	2018-08-28 16:25:04 +10:00
Sam	9ab1fb7dfc	FEATURE: correctly store width and height on uploads Previously we used width and height for thumbnails, new code ensures 1. We auto correct width and height 2. We added extra columns for thumbnail_width and height, this is determined by actual upload and no longer passed in as a side effect 3. Optimized Image now stores filesize which can be used for analysis, decisions Also - fixes Android image manifest as a side effect - fixes issue where a thumbnail generated that is smaller than the upload is no longer used	2018-08-28 12:59:22 +10:00
Neil Lalonde	ebe7835316	FIX: links in rss feeds are sometimes wrong on subfolder installs	2018-08-27 18:05:15 -04:00
Vinoth Kannan	26e05933cd	FIX: Use proper markdown syntax for image urls	2018-08-28 00:29:26 +05:30
Joffrey JAFFEUX	b12cf08c57	minor css tweak	2018-08-27 16:38:57 +02:00
Joffrey JAFFEUX	4fdc27bab5	UI: improves participants list in messages (#6320 )	2018-08-27 15:41:34 +02:00
Joffrey JAFFEUX	c8ffe0fda3	FIX: term should be handled as text (#6321 )	2018-08-27 11:58:46 +02:00
Guo Xiang Tan	cf3b7ccae2	Merge pull request #6295 from nbianca/fix_mobile_images UX: Show only the expand icon in lightboxes on mobile.	2018-08-27 13:07:55 +08:00
Guo Xiang Tan	53a6c31107	Merge pull request #6310 from nbianca/ux_ip_lookup UX: Improve copying from IP lookup component.	2018-08-27 13:04:35 +08:00
Guo Xiang Tan	3584af4e51	Merge pull request #6314 from nbianca/groups_directory UX: Do not show the groups directory if disabled.	2018-08-27 13:00:39 +08:00
Joe	fb0b54f7f8	UX: Styles for user-cards should the same with badges on / off	2018-08-27 11:16:48 +08:00
Joe	1f4af5ab36	UX: Super short tags shouldn't display on same line as title	2018-08-27 10:35:15 +08:00
Sam	4205c528d0	FEATURE: hide enable_personal_email_messages and min_trust_to_send_email_messages These site settings are very hard to explain and only applicable for very specific Discourse setups. If an admin "enables staged users" which is used in support scenarios then all staff can send "messages" directly to an "email". The setting allows you to extend this to TL4 or any trust level. Actual use case would be a support type setup with restricted staff. It is quite rare so hiding this for now and re-evaluate keeping the setting in 2019	2018-08-27 11:38:22 +10:00
Raul Tambre	2271918be2	FEATURE: Use S3 dualstack endpoints Allows S3 without a CDN to serve images from dualstack domains that also support ipv6	2018-08-27 11:22:46 +10:00
Bianca Nenciu	5ccf581e1e	UX: Improve copying from IP lookup component. - Removed trailing whitespaces caused by textarea. - Clicking the Copy button will show "copied" for 2 seconds.	2018-08-26 22:20:24 +02:00
Bianca Nenciu	5be41faa8c	UX: Do not show the groups directory if disabled. Staff could still the groups directory before.	2018-08-26 00:21:16 +02:00
Kris	64c4171937	add no-text to PM bulk select button	2018-08-25 00:07:35 -04:00
Jeff Wong	c3ba822489	remove debug	2018-08-24 16:46:55 -07:00
Jeff Wong	3743e90316	FIX: second factor input for username password is disabled when hidden.	2018-08-24 16:15:34 -07:00
Kris	faf09bb8c8	Replacing default brown category color	2018-08-24 14:18:14 -04:00
Joffrey JAFFEUX	2dbd75d4d2	minor css tweaks on reports	2018-08-24 17:16:01 +02:00
Neil Lalonde	9bf4333491	FIX: redirect to wrong URL after account creation on subfolder install	2018-08-24 10:34:44 -04:00
Joffrey JAFFEUX	82dcc5cbfa	FEATURE: makes reports loadable in bulk (#6309 )	2018-08-24 15:28:01 +02:00
James Kiesel	a4001c1ea0	FEATURE: Pop revise modal on post edited notification (#6287 ) * Add revision number to notification url * Pop modal on route change * Add semicolon * Ensure modal pops even when navigating within a topic * Ensure modal pops when visiting from other page * Fix eslint errors * Fix prettier errors * Add callback for notification item click * Remove stray revisionUrl function * Rename to afterRouteComplete	2018-08-24 09:13:07 -04:00
Guo Xiang Tan	932195d828	DEV: Update test case for `TopicEmbed`.	2018-08-24 09:42:12 +08:00
Guo Xiang Tan	1ba24496ab	Merge pull request #6261 from xrav3nz/fix/topic-embed-import-updates FIX: update TopicEmbed's title and user correctly	2018-08-24 09:32:03 +08:00
Osama Sayegh	e0cc29d658	FEATURE: themes and components split * FEATURE: themes and components split * two seperate methods to switch theme type * use strict equality operator	2018-08-24 11:30:00 +10:00
Sam	ac11f8df52	correct regression searching with diacritics	2018-08-24 10:00:51 +10:00
Sam	29315b73c2	FIX: improve last_modified date returned for avatars instead of hard coding a date: 1. For optimized images use the upload date when on s3 2. For not-found use 10 minutes ago to match the expiry	2018-08-24 09:36:11 +10:00
Régis Hanol	c26de01399	Use NFKD normalization instead of NFD	2018-08-24 00:52:53 +02:00
Régis Hanol	bc7b530b0a	FIX: remove diacritics instead of transliterating	2018-08-24 00:38:44 +02:00
Régis Hanol	f4ae53d52b	Return immediately when there's no html to scrub	2018-08-23 18:00:07 +02:00
Régis Hanol	2fcf2b899e	FIX: remove diacritics when tokenizing html for search	2018-08-23 17:13:52 +02:00
Gerhard Schlager	409ee66839	Add optional "ignore_case" parameter to posts:remap rake task	2018-08-23 14:49:17 +02:00
Arpit Jalan	7a91df3248	Merge pull request #6290 from techAPJ/latest-full-name UX: show full name on /latest page	2018-08-23 17:34:54 +05:30
Arpit Jalan	1a7cd6648b	UX: show full name on /latest page	2018-08-23 14:41:06 +05:30
Joffrey JAFFEUX	07e11a223c	FIX: prefills username for new message on first post (#6305 )	2018-08-23 11:09:35 +02:00
Gerhard Schlager	3d176d9984	Add missing copy	2018-08-23 09:44:15 +02:00
Guo Xiang Tan	72ed6ae951	Raise an error if update fails.	2018-08-23 15:40:21 +08:00
Guo Xiang Tan	bd66fbef7f	FIX: Post time query filter not set correctly when loaded from params. https://meta.discourse.org/t/before-and-after-are-not-implemented-right-in-search/92515	2018-08-23 14:06:28 +08:00
Osama Sayegh	2711f173dc	FIX: don't allow inviting more than `max_allowed_message_recipients` * FIX: don't allow inviting more than `max_allowed_message_recipients` setting allows * add specs for guardian * user preferences for auto track shouldn't be applicable to PMs (it auto watches on visit) Execlude PMs from "Automatically track topics I enter..." and "When I post in a topic, set that topic to..." user preferences * groups take only 1 slot in PM * just return if topic is a PM	2018-08-23 14:36:49 +10:00
James Kiesel	b2ce33be26	FIX: tag intersection not populating (#6296 ) * Fix for tag intersection not populating * Fix prettier * Add acceptance test for tags intersection	2018-08-23 14:22:47 +10:00
Guo Xiang Tan	36a7028f19	FEATURE: Clean up `PostReplyKey` records. * Default retention of 90 days.	2018-08-23 10:40:02 +08:00
Bianca Nenciu	4436024563	UX: Show only the expand icon in lightboxes on mobile.	2018-08-22 19:21:42 +02:00
Joffrey JAFFEUX	a48059fd8f	FIX: uses localized string for 429 in reports (#6302 ) NGINX was retuning an html page instead of single string for some users. Seems safer to not risk showing anything from server anyways.	2018-08-22 18:13:29 +02:00
Joffrey JAFFEUX	c08dea386b	FIX: better handling of no prev30Days (#6301 )	2018-08-22 18:00:11 +02:00
Régis Hanol	f01169d6ff	FIX: don't send email when the post was deleted	2018-08-22 13:13:58 +02:00
Joffrey JAFFEUX	774e6bc795	FIX: handle rate limiting from nginx (#6300 )	2018-08-22 13:10:57 +02:00
Joffrey JAFFEUX	87d443f070	FIX: counters were showing future instead of past (#6299 )	2018-08-22 12:37:05 +02:00
Joffrey JAFFEUX	599cebf8ad	FIX: better message if request for report is rate limited (#6298 )	2018-08-22 11:25:12 +02:00
Bianca Nenciu	758fae7f9f	UX: Keyboard shortcuts will automatically select hovered post	2018-08-22 15:47:17 +10:00
James Kiesel	cdea969c6a	FEATURE: Make initial admins TL1 * Match register controller TL to rake admin:create * Don't promote if trust_level > 1	2018-08-22 15:45:24 +10:00
Sam	5a6d1ee257	FIX: defer actions in a static method This avoids capturing a huge closure and passing to defer	2018-08-22 14:36:56 +10:00
Sam	5d96809abd	FIX: improve support for subfolder S3 CDN	2018-08-22 12:31:13 +10:00
Gerhard Schlager	bed34b52b5	UX: Blue "Resend Activation Email" button in wizzard	2018-08-21 22:18:08 +02:00
Régis Hanol	a00d368d0f	remove empty line	2018-08-21 19:46:04 +02:00
Régis Hanol	61447a8046	UX: don't show the whisper toggle when replying to a whisper	2018-08-21 19:35:40 +02:00
Gerhard Schlager	17dc8f2490	UX: Wizard resends activation email when user exists	2018-08-21 19:13:41 +02:00
Régis Hanol	3e436e2daf	FIX: doesn't translate group permission keys	2018-08-21 12:56:56 +02:00
Kyle Zhao	baf413d527	FIX: update TopicEmbed's title and user correctly	2018-08-21 18:31:01 +08:00
Guo Xiang Tan	8bdf14834b	PERF: Restrict number of skipped email log for `Jobs::UserEmail`.	2018-08-21 11:14:43 +08:00
Guo Xiang Tan	7c69fa8cfd	PERF: Memoize `SkippedEmailLog.reason_types`.	2018-08-21 10:25:06 +08:00
Guo Xiang Tan	2c70d3f443	Take 2 on `ba6f11c521`.	2018-08-21 10:06:36 +08:00
Sam	2d96160192	FEATURE: improve API error reporting for invalid records	2018-08-21 11:54:34 +10:00
Kris	45cd141ed6	Need to clear subcategories	2018-08-20 21:07:07 -04:00
Gerhard Schlager	96d1ea03e7	Sorting is hard. This should really fix user profiles.	2018-08-20 18:56:21 +02:00
Gerhard Schlager	209ed105f9	FIX: User profiles didn't work when API keys exist	2018-08-20 18:21:40 +02:00
Bianca Nenciu	dc5fddbfe6	FIX: Do not show an empty modal when an IP address is allowed or blocked. (#6265 )	2018-08-20 17:37:30 +02:00
Bianca Nenciu	860c1c3dcd	FEATURE: Automatically expire keys if not used for a configurable amount of time. (#6264 )	2018-08-20 17:36:14 +02:00
Misaka 0x4e21	1d913d3204	UX: Allow admin to copy IP address details of a user. (#6270 )	2018-08-20 17:29:20 +02:00
Gerhard Schlager	5ed582551a	FIX: SpamRulesEnforcer should use default locale	2018-08-20 15:08:12 +02:00
Gerhard Schlager	cc851af750	FIX: HTML lang attribute expects hyphen instead of underscore	2018-08-20 13:55:58 +02:00
Gerhard Schlager	14af90df5b	UX: Stop putting usernames in edit reason when changing post owner	2018-08-20 12:28:04 +02:00
Guo Xiang Tan	b4f92a05b3	FIX: Load more on groups page does not account for params. https://meta.discourse.org/t/cant-scroll-through-list-of-users-groups-if-more-than-one-page/92259	2018-08-20 17:08:50 +08:00
Guo Xiang Tan	658b55c406	FIX: Search does not retrigger when context has changed. Take 2. https://meta.discourse.org/t/using-the-search-this-topic-check-box-blocks-search-on-other-pages/56832/6?u=tgxworld	2018-08-20 15:46:02 +08:00
Sam	ce4b12ae59	FIX: if we have not target available do not redirect	2018-08-20 13:10:59 +10:00
Guo Xiang Tan	9c3ba98ef1	FIX: User can't save gravatar as profile picture after refresh. https://meta.discourse.org/t/gravatar-issue-cant-save-changes/95076	2018-08-20 10:29:50 +08:00
Sam	8b5e42ea16	FIX: always test and coerce to image on upload In the past the filename of the origin was used as the source for the extension of the file when optimizing on upload. We now use the actual calculated extension based on upload data.	2018-08-20 12:18:59 +10:00
Bianca Nenciu	975a72ab7a	FEATURE: Make links indexable. (#6285 )	2018-08-20 10:39:19 +10:00
Kris	a15a43605e	Simplifying category page markup	2018-08-17 23:07:07 -04:00
David Taylor	e7e8f4ef4c	Add plugin API for handling uploads with specific file extensions	2018-08-17 16:08:47 +01:00
Joffrey JAFFEUX	37d4f27c44	FIX: quality/bugfix dashboard/reports pass (#6283 )	2018-08-17 16:19:25 +02:00
Guo Xiang Tan	16c0ebe8a8	Fix the build.	2018-08-17 16:53:07 +08:00
Bianca Nenciu	b69f72853f	UX: Show static page title. (#6273 )	2018-08-17 10:47:11 +02:00
Sam	9628c3cf97	FEATURE: automatically correct extension for bad uploads This fixes with post thumbnails on the fly	2018-08-17 14:00:27 +10:00
Régis Hanol	93201d8dbe	FIX: don't trigger 'flag_reviewed' when no flags were reviewed	2018-08-16 18:11:29 +02:00
Joffrey JAFFEUX	3fbf7b164d	FEATURE: emoji 11.0 "recently added" update (#6275 ) Adds support for emojis in the http://www.unicode.org/emoji/charts-11.0/emoji-released.html list	2018-08-16 11:59:45 +02:00
Sam	baa72d18f8	FIX: simplify so we ban all auth paths previously plugins that have auth paths were not disallowed and robots tend to call them	2018-08-16 19:16:47 +10:00
Sam	f62073a22a	correct regression uploading images	2018-08-16 18:49:08 +10:00
Sam	796164b58c	FIX: automatically correct bad avatars on access Also start relying on upload extension for optimized images	2018-08-16 16:32:56 +10:00
Kris	8e240af3ea	FIX: z-index fix for tag input on mobile	2018-08-16 01:17:15 -04:00
Kris	8c46ecf7f3	UX: Improving tag topic list navigation consistency	2018-08-16 00:02:26 -04:00
Sam	1f17b84b63	FEATURE: more context for error reporting on jobs fails	2018-08-16 12:38:49 +10:00
Rafael dos Santos Silva	c8b5e6baae	FEATURE: Use `display: browser` in webmanifest for iOS devices Since iOS doesn't have a back button and can have issues on log in. See https://twitter.com/firt/status/1021477243909033984	2018-08-15 23:36:08 -03:00
Guo Xiang Tan	5778c33ee7	FIX: Compatibility with ImageMagick 7. http://www.imagemagick.org/Usage/misc/ "The "-interpolate" setting of 'Catrom' (generally imprecisely known as 'BiCubic' interpolation)"	2018-08-16 09:49:52 +08:00
Kris	7b412727bb	Fixing HTML structure of tag filtered topic list	2018-08-15 19:45:37 -04:00
Sam	243fc9d0f9	FIX: refreshing auto groups when min_username_length is long	2018-08-15 16:59:56 +10:00
Sam	33b5cc6bbd	FIX: Add gif to list of allowed decoders	2018-08-15 13:56:57 +10:00
Sam	cf788582cc	DEV: split optimize image failure warnings in logs	2018-08-15 13:27:24 +10:00
Misaka 0x4e21	d4fd19d49a	UX: Replace Google search with Discourse search on not found page * UX: Replace Google search with Discourse search on not found page. * FIX: Update application_controller_spec.rb.	2018-08-15 11:53:04 +10:00
Régis Hanol	12bab65167	FIX: going from /categories to /latest on mobile might break infinite scrolling	2018-08-15 01:22:03 +02:00
Gerhard Schlager	c358421ca5	FIX: Bulk updating category failed when topic title was too short	2018-08-14 16:37:52 +02:00
Joffrey JAFFEUX	7290765a62	FIX: uses touchstart/mousedown for selected tags (#6268 ) It seems to be way more reliable on firefox and safari in the case of hot replaced content not using ember.	2018-08-14 16:16:13 +02:00
Régis Hanol	de92913bf4	FIX: store the topic links using the cooked upload url	2018-08-14 12:23:32 +02:00
Sam	ad5f502332	FIX: add a basic validator for topic params This cuts down on log noise when people try out sql injection	2018-08-14 17:01:04 +10:00
Kyle Zhao	983dba37ce	FIX: use BasicUserSerializer for user_badge.granted_by (#6266 ) BasicUserSerializer contains enough information for the badges page, while UserSerializer issues ~100 SQL queries on the fly when serializing the field without preloading.	2018-08-14 08:11:14 +10:00
Neil Lalonde	37a01975e9	SECURITY: prevent use of X-Forwarded-Host to perform XSS	2018-08-13 17:10:06 -04:00
Neil Lalonde	71b65be6f6	SECURITY: prevent use of X-Forwarded-Host to perform XSS	2018-08-13 16:45:22 -04:00
Joe	075d80862f	UX: topic-timer modal style fixes	2018-08-13 14:04:20 +08:00
tshenry	03010571f5	Remove unnecessary code (#6262 ) "border-bottom: none;" gets overridden a few lines below by "border-bottom: 1px solid $primary-low;" making it unnecessary.	2018-08-13 15:43:03 +10:00
Misaka 0x4e21	e26437f334	FEATURE: Do encodeURI on share links Some Discourse-supported sharing platforms such as Twitter are unable to determine the end of a unicode URL. If you post a URL "https://example.org/t/测试/1" on Twitter, it will be a link of href="https://example.org/t/" If the URL contains any unicode character (usually in the slug part) , it must be urlencoded with encodeURI(url) before being passed to source.generateUrl(link, title), or it will be a malformed URL in the sharing tweet.	2018-08-13 15:35:56 +10:00
Joe	7e68062a46	Topic meta-data flexbox fixes (#6263 ) Topic meta-data flexbox fixes	2018-08-13 13:29:46 +08:00
Sam	83fd308963	FEATURE: group error message regarding image optimization failures	2018-08-13 14:48:25 +10:00
Guo Xiang Tan	ba022234c6	Add onceoff job to fix incorrect upload extensions.	2018-08-13 10:44:08 +08:00
Peter Borsa	a6820d8767	Add Hungarian locale (#6260 )	2018-08-13 01:02:35 +02:00
Gerhard Schlager	6d813c2b52	FIX: Importers failed to import avatars	2018-08-12 22:02:17 +02:00
Gerhard Schlager	448e95b97d	UX: Show anchor icon instead of text when topic bump is disabled	2018-08-11 21:51:13 +02:00
Kris	a960a57c72	Improving category reorder modal layout	2018-08-10 22:09:46 -04:00
Kris	e53983b53b	Alignment fix	2018-08-10 14:00:06 -04:00
Gerhard Schlager	b73950692b	FIX: Parsing non-existent feed should not fail	2018-08-10 18:37:14 +02:00
Osama Sayegh	865cb3feb9	FIX: allow selecting site's default theme from preference	2018-08-10 14:12:02 +03:00
Sam	6f6b4ff988	regression: don't return from a block also clean up some warnings (shadowed var, unused var)	2018-08-10 14:53:55 +10:00
Kris	0451dba27a	Table margin adjustment	2018-08-09 21:24:26 -04:00
Simon Cossar	093c3510e6	Rework moderators activity query (#6230 ) * Order rows in query * Don't increment revisions when moderator revises their own post	2018-08-10 10:51:31 +10:00
Gerhard Schlager	b9072e8292	FEATURE: Add "Reset Bump Date" action to topic admin wrench (#6246 )	2018-08-10 10:51:03 +10:00
Misaka 0x4e21	6db623ef6b	UX: Improve category filtering and include subcategories * category_filtering 1. report_top_referred_topics 2. report_top_traffic_sources 3. report_post_edit * category_filtering with subcategory topics 1. report_top_referred_topics 2. report_top_traffic_sources 3. report_post_edit 4. report_posts 5. report_topics 6. report_topics_with_no_response * category_filtering tests (without subcategory topics) 1. report_posts 2. report_topics_with_no_response * subcategory topics tests `in_category_and_subcategories` in `topic_spec.rb` 1. `in_category_and_subcategories` in `topic_spec.rb` 2. topics, posts, flags and topics_with_no_response in `report_spec.rb`	2018-08-10 10:50:05 +10:00
Gerhard Schlager	ef4b9f98c1	FEATURE: Allow admins to reply without topic bump	2018-08-10 10:48:30 +10:00
Kris	6ec92d5845	prettier	2018-08-09 20:45:47 -04:00
Kris	2e1049a75a	Minor dashboard style adjustments	2018-08-09 20:43:18 -04:00
Simon Cossar	3cd4dc0f5f	Allow users with group_locked_trust_level to be promoted to tl3 (#6249 )	2018-08-10 10:42:23 +10:00
Joffrey JAFFEUX	6a2ca60b48	FIX: ember click event not reliably working on fx (#6256 )	2018-08-09 22:41:35 +02:00
Kris	04658bb2f1	UX: prevent text from wrapping below notification icons	2018-08-09 12:04:34 -04:00
Neil Lalonde	2c4d7225d8	FIX: permalink redirects with subfolder	2018-08-09 11:05:27 -04:00
Neil Lalonde	701c5ae781	UX: admin permalink form can fit on one line	2018-08-09 11:05:27 -04:00
Joffrey JAFFEUX	da1d520d4c	FIX: simplifies mini tag chooser events handling (#6252 )	2018-08-09 14:23:28 +02:00
Joffrey JAFFEUX	bfcf8ed61b	FIX: prevents focus of input on mobile (#6251 )	2018-08-09 14:23:09 +02:00
Joffrey JAFFEUX	523acfcea4	FIX: checks on parent visibility instead of filter itself (#6250 )	2018-08-09 10:45:53 +02:00
Sam	7aef604f7d	regression, if there is not excerpt skip	2018-08-09 15:07:18 +10:00
Sam	ed4c0f256e	FIX: check permalinks for deleted topics - allow to specify 410 vs 404 in Discourse::NotFound exception - remove unused `permalink_redirect_or_not_found` which - handle JS side links to topics via Discourse-Xhr-Redirect mechanism	2018-08-09 15:05:12 +10:00
Neil Lalonde	f7b4a2b3ba	FIX: ensure URLs include subfolder in admin emails UI	2018-08-08 16:48:03 -04:00
Kris	b53d3457c8	updating color scheme attribution	2018-08-08 16:01:21 -04:00
Kris	cc96af07d1	Full-width markdown table on mobile	2018-08-08 15:51:11 -04:00
Neil Lalonde	35bef72d4e	FIX: subfolder redirects to wrong URL if the subfolder appears in the slug	2018-08-08 13:41:29 -04:00
Guo Xiang Tan	94622b451a	FIX: Search does not retrigger when context has changed. https://meta.discourse.org/t/using-the-search-this-topic-check-box-blocks-search-on-other-pages/56832/6?u=tgxworld	2018-08-08 17:55:37 +08:00
David Taylor	d3a9596d08	Remove unused import	2018-08-08 10:46:43 +01:00
David Taylor	d4d5088324	FIX: Don't require device capabilities when calculating login methods	2018-08-08 10:37:25 +01:00
David Taylor	575d9e0b1a	FIX: Include parameters in function call	2018-08-08 10:09:22 +01:00
Guo Xiang Tan	ba6f11c521	PERF: Only log the first skipped email when user exceeds daily limit. https://meta.discourse.org/t/cleaning-up-e-mail-logs/39132	2018-08-08 16:25:00 +08:00
Osama Sayegh	0d45826d22	fix theme previewing (#6245 )	2018-08-08 10:58:45 +03:00
Osama Sayegh	0b7ed8ffaf	FEATURE: backend support for user-selectable components * FEATURE: backend support for user-selectable components * fix problems with previewing default theme * rename preview_key => preview_theme_id * omit default theme from child themes dropdown and try a different fix * cache & freeze stylesheets arrays	2018-08-08 14:46:34 +10:00
Sam	3f6ad65aec	FEATURE: include excerpt in HTML view for pinned topics	2018-08-08 11:15:49 +10:00
Neil Lalonde	4e6e4a83df	FIX: subfolder digest emails have incorrect URLs	2018-08-07 16:38:17 -04:00
Kris	17d8fea796	Markdown tables should have vertical margin	2018-08-07 16:15:28 -04:00
Kris	48ecad53f2	additional hamburger alignment fix	2018-08-07 09:47:01 -04:00
Joffrey JAFFEUX	67ec81babf	FIX: fixes last backup/last_update dates (#6242 )	2018-08-07 08:19:52 -04:00
David Taylor	aa9a9a5a72	FIX: Include auth_providers for anonymous users when login_required	2018-08-07 09:24:16 +01:00
Guo Xiang Tan	d5a7b818ba	FIX: Move Jobs::CreateAvatarThumbnails to low priority queue.	2018-08-07 16:05:54 +08:00
Guo Xiang Tan	2b57239389	FIX: Upload's content is the only source of truth for the file type.	2018-08-07 13:15:00 +08:00
Sam	6797395bd0	FIX: staff should be allowed to agree and keep post	2018-08-07 10:05:43 +10:00
Joffrey JAFFEUX	8477501e83	FIX: imrpoves alert-error styles in counters reports (#6240 )	2018-08-06 16:59:45 -04:00
Joffrey JAFFEUX	7f2f3b8b22	FIX: improves reports resilience (#6239 ) This commit makes most of the reports now lazy loaded, and making them benefits from graceful failures.	2018-08-06 16:57:40 -04:00
Joffrey JAFFEUX	c301111461	FIX: display select kit body if no choices (#6237 )	2018-08-06 11:22:48 -04:00
Kris	74269ad585	FIX: hamburger menu category alignment	2018-08-06 11:11:29 -04:00
Leo McArdle	9b04921616	FIX: don't require auth providers to set full_screen_login_setting	2018-08-06 10:24:39 +01:00
David Taylor	812add18bd	REFACTOR: Serve auth provider information in the site serializer. At the moment core providers are hard-coded in Javascript, and plugin providers get added to the JS payload at compile time. This refactor means that we only ship enabled providers to the client.	2018-08-06 09:25:48 +01:00
Guo Xiang Tan	4e11811321	FIX: `UserAvatar#update_gravatar!` does not update `User#uploaded_avatar`. https://meta.discourse.org/t/missing-user-profile-pictures/93844/4	2018-08-06 13:29:44 +08:00
Osama Sayegh	18b396ad56	FEATURE: add link to see new commits when updates are available for themes (#6233 ) * FEATURE: add link to see new commits when updates are available for themes * shorten regexp	2018-08-06 15:29:15 +10:00
Joe	cc77a285ee	UX: improves edit reason contrast in dark themes	2018-08-06 10:53:46 +08:00
Régis Hanol	0cd9e2acb9	fix build	2018-08-04 01:56:26 +02:00
Régis Hanol	bf4d98e89d	FIX: always store topic links using the upload url	2018-08-04 01:29:32 +02:00
Kris	84d822959a	Reducing some specificity, color fix	2018-08-03 17:44:22 -04:00
Joffrey JAFFEUX	066010db7d	FEATURE: introduces list/compact_list components	2018-08-03 16:41:37 -04:00
Kris	072f5ce825	Increase ruby character size	2018-08-03 13:37:08 -04:00
Régis Hanol	535732bdc1	FIX: ensure the 'email_revoked' PM template is customizable	2018-08-03 17:10:20 +02:00
Sam	280c318c49	FEATURE: allow ruby tags in Markdown	2018-08-03 11:47:36 +10:00
Osama Sayegh	880462a41c	FEATURE: display out of date themes on admin dashboard * FEATURE: disaply out of date themes on admin dashboard * Update copy	2018-08-03 09:53:48 +10:00
Neil Lalonde	864e279aaf	FIX: wrong links to subcategories in top categories section of user summary	2018-08-02 17:38:42 -04:00
Joffrey JAFFEUX	1ca999fdb5	FIX: formats topic report only if we have one (#6231 )	2018-08-02 08:01:17 -04:00
Sam	0b3d51a8bc	FEATURE: whitelist lang attribute	2018-08-02 16:53:08 +10:00
Kris	9499693baa	Layout works better with auto columns	2018-08-01 22:37:21 -04:00
Joffrey JAFFEUX	60f62f6f36	FIX: improves report-show mobile UI (#6229 )	2018-08-01 19:54:27 -04:00
Joffrey JAFFEUX	859c98743f	FIX: removes ellipsis from activity-metrics report cells	2018-08-01 19:08:53 -04:00
Joffrey JAFFEUX	8cbe3cbe26	this file shouldn’t have been comitted	2018-08-01 19:01:47 -04:00
Joffrey JAFFEUX	9073e11943	FIX: improves number/percent support in reports	2018-08-01 18:40:59 -04:00
Penar Musaraj	4a872823e7	Improvements to user drafts (#6226 ) * drafts in user profile: only show to user herself (not to admins), use avatar replying to (instead of topic OP), add keyboard shortcut for drafts, simplify display labels * use JSON when testing Draft.stream	2018-08-02 07:41:27 +10:00
Kris	8147130412	Group icon misalignment	2018-08-01 17:30:17 -04:00
Kris	d678ef2653	group icon needs margin	2018-08-01 17:05:35 -04:00
Kris	04255d1dce	removing unneeded styles	2018-08-01 16:38:47 -04:00
Kris	f0bea4ae55	Improve PM participant list	2018-08-01 16:20:14 -04:00
Robin Ward	4eef41ea1b	FIX: Error with debouncing mentions	2018-08-01 15:57:24 -04:00
Gerhard Schlager	2ec1aec2be	FIX: Clicking admin wrench in topic footer didn't hide post select box	2018-08-01 21:29:35 +02:00
Dan Ungureanu	1a0ffc5ace	FEATURE: Added method to get multiple values at once from PluginStore. (#6225 )	2018-08-01 18:42:40 +02:00
Gerhard Schlager	f4ca105498	FIX: Moving posts to existing topic didn't update topic metadata	2018-08-01 18:05:43 +02:00
Robin Ward	d7b463a03d	FIX: Remove unused import	2018-08-01 11:54:47 -04:00
Robin Ward	7c950321d1	FIX: Allow non-english usernames in autocomplete Also add support for username formatters	2018-08-01 11:53:20 -04:00
Neil Lalonde	b829452c75	Merge pull request #6209 from discourse/mini_scheduler REFACTOR: extract scheduler to the mini_scheduler gem	2018-08-01 10:28:24 -04:00
Joffrey JAFFEUX	0b9437cee7	FIX: more resilient/consistent dashboard caching (#6223 )	2018-08-01 09:45:50 -04:00
Joffrey JAFFEUX	7c7dfa4e5e	FIX: wraps any query with the slow query guard (#6222 )	2018-08-01 07:39:57 -04:00
Vinoth Kannan	8178444382	Make prettier happy	2018-08-01 15:13:54 +05:30
Vinoth Kannan	8556288397	DEV: Export Tag class to modify methods in plugin	2018-08-01 15:10:15 +05:30
Gerhard Schlager	a115aae45f	Use rchardet instead of charlock_holmes gem	2018-08-01 10:41:20 +02:00
Gerhard Schlager	5d421fb946	FIX: Try respecting charset in HTTP header of RSS feed	2018-08-01 10:41:20 +02:00
Gerhard Schlager	ff942ed2f3	FIX: Try detecting encoding of RSS feed	2018-08-01 10:41:20 +02:00
Penar Musaraj	1f45215537	FEATURE: Drafts view in user profile * add drafts.json endpoint, user profile tab with drafts stream * improve drafts stream display in user profile * truncate excerpts in drafts list, better handling for resume draft action * improve draft stream SQL query, add rspec tests * if composer is open, quietly close it when user opens another draft from drafts stream; load PM draft only when user is in /u/username/messages (instead of /u/username) * cleanup * linting fixes * apply prettier styling to modified files * add client tests for drafts, includes a fixture for drafts.json * improvements to code following review * refresh drafts route when user deletes a draft open in the composer while being in the drafts route; minor prettier scss fix * added more spec tests, deleted an acceptance test for removing drafts that was too finicky, formatting and code style fixes, added appEvent for draft:destroyed * prettier, eslint fixes * use "username_lower" from users table, added error handling for rejected promises * adds guardian spec for can_see_drafts, adds improvements following code review * move DraftsController spec to its own file * fix failing drafts qunit test, use getOwner instead of deprecated this.container * limit test fixture for draft.json testing to new_topic request only	2018-08-01 16:34:54 +10:00
Guo Xiang Tan	70ea153dce	Fix lint.	2018-08-01 12:23:36 +08:00
Guo Xiang Tan	53adbf70f3	FIX: Nav item missing for plugins that don't include a custom filter.	2018-08-01 11:50:14 +08:00
Joffrey JAFFEUX	5febe71baa	FIX: prevents crash if flagger doesn’t exist (#6219 )	2018-07-31 23:48:54 -04:00
Joffrey JAFFEUX	849f0d00f6	FEATURE: adds revision_count to moderators_activity (#6218 ) Co-Authored-By: Simon Cossar <scossar@users.noreply.github.com>	2018-07-31 23:40:45 -04:00
Guo Xiang Tan	919e8db686	FIX: Check for group name availability should skip reserved usernames.	2018-08-01 11:09:33 +08:00
Kris	129268ddc6	Highlighted titles too wide on mobile	2018-07-31 21:24:43 -04:00
Joffrey JAFFEUX	2b2a506a7b	FIX: makes dashboard more resilient to errors (#6217 ) This commit is an attempt to limit cases where the dashboard will generate a full exception page and also make it easier to track the error.	2018-07-31 21:23:28 -04:00
Joffrey JAFFEUX	0715aa18da	UI: uses tiny avatars for reports (#6215 )	2018-07-31 18:57:00 -04:00
Joffrey JAFFEUX	37252c1a5e	UI: improves dashboard table reports - support for avatars - support for topic/post/user type in reports - improved totals row UI - minor css tweaks	2018-07-31 17:35:13 -04:00
Neil Lalonde	4ad7ce70ce	REFACTOR: extract scheduler to the mini_scheduler gem	2018-07-31 17:12:55 -04:00
Robin Ward	4b166cccc1	FIX: Linting error	2018-07-31 14:19:45 -04:00
Robin Ward	b6bb8df622	FIX: We loosened username restrictions some time ago Additionally, remove `Discourse.User` constant	2018-07-31 13:53:31 -04:00
Vinoth Kannan	ece3cb73df	Rename humburger_menu_categories_count site setting to header_dropdown_category_count	2018-07-31 09:12:30 +05:30
Neil Lalonde	fd29ecb91a	UX: include a flag reason in the post-deleted-by-staff-because-of-flags message	2018-07-30 16:45:46 -04:00
Neil Lalonde	c12a9279f6	post deleted notification regression because controller was agreeing with all flags too early	2018-07-30 16:45:46 -04:00
Vinoth Kannan	c1e62808ed	FIX: Top site categories are displayed in random order	2018-07-31 01:01:03 +05:30
Kris	7368dd8e7d	Prevent activity-metrics stats from wrapping	2018-07-30 14:40:26 -04:00
Joffrey JAFFEUX	c6fd506a15	fix eslint	2018-07-30 13:10:20 -04:00
Joffrey JAFFEUX	2c90a2e5c2	FIX: prevents mini-tag-chooser to catch unwanted focus	2018-07-30 13:03:40 -04:00
Joffrey JAFFEUX	a327393651	fix 1.14.0 prettier offenses	2018-07-30 11:56:48 -04:00
Joffrey JAFFEUX	536f88b95b	Revert "DEV: prettier 1.14.0" This reverts commit `1f899bec21`.	2018-07-30 11:52:05 -04:00
Joffrey JAFFEUX	1f899bec21	DEV: prettier 1.14.0	2018-07-30 11:09:08 -04:00
Vinoth Kannan	c54b5824d4	REFACTOR: Prioritize unread categories in hamburger menu	2018-07-30 20:20:10 +05:30
David Taylor	6566b2f11a	FEATURE: Allow revoke and connect for Instagram logins	2018-07-30 14:38:53 +01:00
Joffrey JAFFEUX	d494feaa32	FIX: should not be needed as we have itemprop='url'	2018-07-30 09:31:27 -04:00
Arpit Jalan	dfcb2a0d42	FEATURE: include published_time in metadata	2018-07-30 17:09:56 +05:30
Vinoth Kannan	50df2d7241	FIX: Should not include regular categories in top_category_ids array	2018-07-30 16:06:36 +05:30
Maja Komel	04baddf731	DEV: migrate tests to async/await	2018-07-30 12:21:05 +02:00
Vinoth Kannan	176d8ca78d	FIX: Hide muted categories from hamburger menu top categories block	2018-07-30 15:39:37 +05:30
Vinoth Kannan	249b16e8e3	FIX: Hide muted categories from hamburger menu top categories block	2018-07-30 15:37:41 +05:30
Guo Xiang Tan	581cf62bcf	UX: Allow emojis to be displayed in nav-item.	2018-07-30 18:02:34 +08:00
Guo Xiang Tan	ef78268c01	Give `ExtraNavItem` more control over when it can be displayed.	2018-07-30 17:30:13 +08:00
Arpit Jalan	ba64ebbf10	FIX: preserve whitespace between uploads when the process is complete	2018-07-30 14:49:33 +05:30
Vinoth Kannan	78d91b1daf	UX: Changes in top categories of hamburger menu (#6200 )	2018-07-30 14:13:00 +05:30
Guo Xiang Tan	acde8d4323	Fix the build.	2018-07-30 15:07:03 +08:00
Guo Xiang Tan	96a0448c52	FIX: Add onceoff job to fix incorrect extension for gravatar uploads.	2018-07-30 14:44:02 +08:00
Guo Xiang Tan	87537b679c	Drop `reply_key`, `skipped` and `skipped_reason` from `email_logs`.	2018-07-30 11:39:28 +08:00
Guo Xiang Tan	b94633e844	FIX: `FileHelper` should prioritize response content-type. Request to a URL with `.png` extension may return a jpg instead causing us to attach the wrong extension to an upload.	2018-07-30 10:54:36 +08:00
Arpit Jalan	fc3b904e1f	remove "track external right clicks" feature	2018-07-29 15:01:33 +05:30
Joe	3dbaaf0d74	UX: gives wizard language selector more room to expand	2018-07-28 11:51:53 +08:00
Kris	7a1a1eb4c0	improve header scaling with font size	2018-07-27 16:49:28 -04:00
Joffrey JAFFEUX	a8f1b07686	FIX: prevents exception when loading old dashboard (#6196 )	2018-07-27 16:29:30 -04:00
Kris	3159c46613	Making dataless sections stand out less	2018-07-27 14:55:51 -04:00
Kris	60b2c3207e	larger mobile topic list badges	2018-07-27 13:10:13 -04:00
David Taylor	5f1fd0019b	FEATURE: Allow revoke and connect for GitHub logins	2018-07-27 17:18:53 +01:00
David Taylor	6296f63804	FEATURE: Revoke and connect for Yahoo logins	2018-07-27 16:20:47 +01:00
Vinoth Kannan	a9c959e3e2	Make prettier happy	2018-07-27 20:39:44 +05:30
Vinoth Kannan	bc501038cb	FIX: Remove null value from categories list	2018-07-27 20:00:39 +05:30
Joe	85291e53f1	UX: more categories link alignment	2018-07-27 22:17:29 +08:00
David Taylor	9c72c00206	FEATURE: Revoke and reconnect for Twitter logins	2018-07-27 12:28:51 +01:00
Vinoth Kannan	5b4e13bfcc	Make prettier happy	2018-07-27 13:20:21 +05:30
Vinoth Kannan	c0f7d95bb8	Include subcategories in hamburger menu top categories	2018-07-27 13:05:18 +05:30
Vinoth Kannan	dac29b5ebc	UX: Display only top categories in hamburger menu (#6146 )	2018-07-27 12:11:07 +05:30
Joffrey JAFFEUX	b7d1864d0a	FIX: simplify filters on admin-report component (#6193 )	2018-07-27 01:22:00 -04:00
Guo Xiang Tan	6f9a91cbd5	Merge pull request #6175 from vinothkannans/post_approval_webhook FEATURE: Webhook for post approval events	2018-07-27 10:50:49 +08:00
Guo Xiang Tan	ccf76d45f2	FIX: Missing variable outside of `begin` block.	2018-07-27 08:19:11 +08:00
Joffrey JAFFEUX	262beed1cf	FIX: fixes regression with category filtering (#6190 )	2018-07-26 19:08:06 -04:00
Joffrey JAFFEUX	59684adc43	FIX: shows disk usage even if no backups taken (#6189 )	2018-07-26 18:38:55 -04:00
Neil Lalonde	1708ff1808	UX: add a route /rules as an alias for /faq and /guidelines	2018-07-26 15:38:08 -04:00
Joffrey JAFFEUX	56ae826efb	UI: improves no data notice in reports (#6187 )	2018-07-26 15:26:53 -04:00
Joffrey JAFFEUX	330cf78c83	FIX: don’t break browser history on dashboard visit (#6186 )	2018-07-26 14:59:28 -04:00
Kris	8d67b20d37	z-index fix	2018-07-26 12:11:40 -04:00
David Taylor	88241f57a3	FEATURE: allow auth plugins to have a site setting for full screen login	2018-07-26 11:11:16 +01:00
David Taylor	63e15aa41a	Add missing semicolon	2018-07-26 10:30:10 +01:00
Maja Komel	e8d82f48bc	add maxlength attribute for 2FA input fields	2018-07-26 10:31:20 +02:00
Vinoth Kannan	af5b88f8e2	Rename approval web hook event type to queued post	2018-07-26 10:29:38 +05:30
Kris	67b6539d98	rounder topic-list badges in iOS	2018-07-25 23:58:23 -04:00
Kris	998b7fb87a	Rounder topic-list badges on mobile	2018-07-25 22:30:30 -04:00
Guo Xiang Tan	f8b367cc9c	Fix the build.	2018-07-26 10:17:51 +08:00
Kris	c5e7c60a37	Fixing profile avatar flair poisition on mobile	2018-07-25 22:00:56 -04:00
Kyle Zhao	1ed3a89ac9	UX: clear topic timer text when manually closing/opening (#6123 ) * UX: clear topic timer text when manually closing/opening * added test for clearing topic timer status text	2018-07-26 11:48:38 +10:00
Guo Xiang Tan	30242972d3	Add spec for `4bf3bf6786`.	2018-07-26 09:16:14 +08:00
Nick Shearer	def2c977ce	allow auth plugins to have a site setting for if they should be full screen vs popup window	2018-07-25 19:20:11 -05:00
Régis Hanol	aeaf6b5a7c	SECURITY: force IM decoder based on file extension - part 3	2018-07-25 23:55:41 +02:00
Régis Hanol	f94aeaf6cf	SECURITY: force IM decoder based on file extension - part 3	2018-07-25 23:55:06 +02:00
Régis Hanol	01714e40f4	SECURITY: force IM decoder based on file extension - part 2	2018-07-25 23:08:38 +02:00
Régis Hanol	800c57c6ab	SECURITY: force IM decoder based on file extension - part 2	2018-07-25 23:08:02 +02:00
Régis Hanol	b04b7c366c	SECURITY: force IM decoder based on file extension	2018-07-25 22:01:08 +02:00
Régis Hanol	4bf3bf6786	SECURITY: force IM decoder based on file extension	2018-07-25 22:00:04 +02:00
Kris	0e84024958	Updating style of theme options in wizard (#6177 )	2018-07-25 15:32:14 -04:00
Kris	3fd2571abc	Fix typo in color scheme	2018-07-25 15:12:01 -04:00
Joffrey JAFFEUX	ad95c24307	FEATURE: displays a notice if report has no data (#6178 )	2018-07-25 14:28:41 -04:00
Vinoth Kannan	5059dad8f0	FEATURE: Webhook for post approval events	2018-07-25 23:43:19 +05:30
Joffrey JAFFEUX	6ee1ea96ef	fixes tests (#6176 )	2018-07-25 14:02:21 -04:00
Joffrey JAFFEUX	01d1f850e9	FEATURE: uses category-chooser for report filtering (#6174 )	2018-07-25 13:16:35 -04:00
David Taylor	6520697b5c	FIX: Remove `plugin.enabled?` checks at initialization time (#6166 ) Checking `plugin.enabled?` while initializing plugins causes issues in two ways: - An application restart is required for changes to take effect. A load-balanced multi-server environment could behave very weirdly if containers restart at different times. - In a multisite environment, it takes the `enabled?` setting from the default site. Changes on that site affect all other sites in the cluster. Instead, `plugin.enabled?` should be checked at runtime, in the context of a request. This commit removes `plugin.enabled?` from many `instance.rb` methods. I have added a working `plugin.enabled?` implementation for methods that actually affect security/functionality: - `post_custom_fields_whitelist` - `whitelist_staff_user_custom_field` - `add_permitted_post_create_param`	2018-07-25 16:51:45 +01:00
Joffrey JAFFEUX	fa6b7f6b8c	DEV: adds Object.entries and Object.assign polyfills (#6173 )	2018-07-25 11:45:29 -04:00
David Taylor	0d0d78841b	FIX: Remove `plugin.enabled?` checks at initialization time (#6166 ) Checking `plugin.enabled?` while initializing plugins causes issues in two ways: - An application restart is required for changes to take effect. A load-balanced multi-server environment could behave very weirdly if containers restart at different times. - In a multisite environment, it takes the `enabled?` setting from the default site. Changes on that site affect all other sites in the cluster. Instead, `plugin.enabled?` should be checked at runtime, in the context of a request. This commit removes `plugin.enabled?` from many `instance.rb` methods. I have added a working `plugin.enabled?` implementation for methods that actually affect security/functionality: - `post_custom_fields_whitelist` - `whitelist_staff_user_custom_field` - `add_permitted_post_create_param`	2018-07-25 16:44:09 +01:00
Joffrey JAFFEUX	796639a797	FIX: makes disk_space computation more resilient (#6172 )	2018-07-25 11:04:01 -04:00
David Taylor	fa399ce1c5	FEATURE: Add revoke and reconnect functionality for google logins	2018-07-25 16:03:14 +01:00
Joffrey JAFFEUX	578c8e861b	FIX: refreshes disk_space on backup create/destroy (#6169 )	2018-07-25 08:26:30 -04:00
Régis Hanol	637850d867	REFACTOR: new 'show-avatar-select' app event to trigger the avatar selector modal	2018-07-25 12:38:15 +02:00
Gerhard Schlager	9989c8179d	FIX: Translation for default (light) color scheme was missing	2018-07-25 11:28:14 +02:00
Dan Ungureanu	44a5c29d42	Clear old text and URL when showing up the "Insert Hyperink" modal. (#6138 )	2018-07-25 17:12:49 +10:00
Dan Ungureanu	f540020d1d	Add different trigger for the emoji popup of French users. (#6140 )	2018-07-25 16:39:06 +10:00
Gerhard Schlager	1ac643d71c	FIX: Email template for "Queued Posts Reminder" was not found	2018-07-24 17:26:52 +02:00
Régis Hanol	8ca25f5aed	UX: open the change avatar modal when clicking the profile picture	2018-07-24 15:13:21 +02:00
Joffrey JAFFEUX	7a3c541077	UX: Preview multiple color schemes in wizard (#6151 ) It was a dropdown to provide choices of color schemes, and only one scheme could be shown. With this commit, multiple color scheme previews can be displayed on one page at the same time, making admins choose color schemes more easily. Theme preview windows are shrinked. Imported default color schemes. Co-Authored-By: Misaka 0x4e21 <misaka4e21@gmail.com>	2018-07-24 09:00:20 -04:00
Gerhard Schlager	c3b6811651	PERF: Split loading of posts to speed up user renames	2018-07-24 11:57:04 +02:00
Guo Xiang Tan	fa19d3a53c	Merge pull request #6108 from discourse/transaction-sidekiq-fix Fix notifications for topics moved between categories	2018-07-24 17:44:03 +08:00
David Taylor	20a21b1240	Move into MiniSQLMultisiteConnection, and add test for rollback	2018-07-24 09:41:55 +01:00
Guo Xiang Tan	98f84d1a4e	Update annotations.	2018-07-24 15:49:55 +08:00
Guo Xiang Tan	7a2bf8e368	Fix invalid query syntax when `CategoryCustomField#value` is blank.	2018-07-24 14:48:27 +08:00
Guo Xiang Tan	663d78414b	Merge pull request #6104 from tgxworld/split_up_reply_key_from_email_logs PERF: Move `EmailLog#reply_key` into new `post_reply_keys` table.	2018-07-24 14:33:48 +08:00
Guo Xiang Tan	fad9c2b971	PERF: Move `EmailLog#reply_key` into new `post_reply_keys` table.	2018-07-24 13:51:53 +08:00
Guo Xiang Tan	5760873580	Fix linting.	2018-07-24 13:43:52 +08:00

... 13 14 15 16 17 ...

18870 Commits