discourse

mirror of https://github.com/discourse/discourse.git synced 2024-12-21 23:24:07 +08:00

Author	SHA1	Message	Date
Guo Xiang Tan	861b52b6f3	Fix the build take 2.	2018-11-14 18:07:04 +08:00
Guo Xiang Tan	72370b9c36	Add deprecation warnings for url based site settings.	2018-11-14 16:09:26 +08:00
Guo Xiang Tan	44391ee8ab	FEATURE: Upload Site Settings. (#6573 )	2018-11-14 15:03:02 +08:00
David Taylor	17bc82765b	FEATURE: Log password changes in UserHistory (#6600 )	2018-11-14 08:32:42 +08:00
Kyle Zhao	38a9bc740d	FIX: change title when primary group changes (#6602 )	2018-11-14 08:28:41 +08:00
Robin Ward	467be59d75	FEATURE: Allow expanded posts to return user custom fields	2018-11-13 12:44:54 -05:00
Vinoth Kannan	2374f3e8ac	remove unnecessary expectation lines	2018-11-13 16:52:08 +05:30
Guo Xiang Tan	d5df1db3c4	DEV: Improve tests to provide better errors when it fails.	2018-11-13 16:48:04 +08:00
Guo Xiang Tan	e28af0429c	DEV: Improve tests to be more specific.	2018-11-13 15:02:46 +08:00
Sam	80ceb57c76	DEV: add API endpoint to destroy_timings only of last post Previously API only allowed you to nuke all timings from a topic, new API is less punishing and allows you just to remove 1 post.	2018-11-13 16:07:48 +11:00
Guo Xiang Tan	7b44339529	FIX: Prevent uploads used in site settings from being deleted.	2018-11-13 09:15:16 +08:00
Kyle Zhao	3493ea85cc	remove Logster from CSP whitelist (#6593 ) Logster 1.3 no longer has inline JS and is now CSP compliant	2018-11-13 09:55:57 +11:00
Robin Ward	0cb33d2b52	UX: Rename Most Disagreed Flaggers report to "User Flagging Ratio"	2018-11-12 16:23:37 -05:00
Vinoth Kannan	dda1824270	Use hijack in inline onebox controller	2018-11-13 02:39:20 +05:30
Penar Musaraj	4f81bb8303	Disallow revision edits with empty raw content	2018-11-12 15:28:38 -05:00
Vinoth Kannan	44d95ad5ab	FIX: Cache url data for failed inline oneboxes	2018-11-13 01:44:20 +05:30
David Taylor	d89ffbeffd	FEATURE: Add button to delete unused tags (#6587 ) This is particularly useful if you have uploaded a CSV file, and wish to bulk-delete all of the tags that you uploaded.	2018-11-12 16:24:34 +00:00
Bianca Nenciu	5af9a69a3b	FIX: Do not check for suspicious login when impersonating. (#6534 ) * FIX: Do not check for suspicious login when impersonating. * DEV: Add 'impersonate' parameter to log_on_user.	2018-11-12 15:34:12 +01:00
Maja Komel	012da86a07	FIX user directory time period count (#6586 )	2018-11-12 15:30:05 +01:00
Joffrey JAFFEUX	9c616e0679	FIX: handles not found reports in bulk loading (#6582 )	2018-11-12 13:47:24 +01:00
Gerhard Schlager	7c4d4331bc	FEATURE: Better handling of quotation marks in site text search It also matches 3 dots with the ellipsis symbol.	2018-11-12 13:26:41 +01:00
Guo Xiang Tan	575d6855ea	DEV: Improve specs for `Validators::UploadValidator`.	2018-11-12 14:11:32 +08:00
Sam	e17a13ce19	FEATURE: additional "related messages" section This splits out previous message correspondence from suggeted and instead has a dedicated section called "related messages"	2018-11-12 13:04:42 +11:00
Régis Hanol	6b51d84dc5	FIX: Don't enqueue topics if the user can't create them Co-authored-by: Vinoth Kannan <vinothkannan@vinkas.com>	2018-11-09 18:24:28 +01:00
Sam	64d9be726f	the protection I placed was in the wrong path moved to /session/sso correct previous commit	2018-11-09 17:18:01 +11:00
Sam	3ae4fcd1f7	Improve redirect avoidance for /sso paths `e6b3310577` was missing an ege case where return url included current_hostname	2018-11-09 17:03:58 +11:00
Sam	7d52f5869d	Revert "FIX: Don't enqueue topics if the user can't create them" This reverts commit `515e103db6`.	2018-11-09 15:25:38 +11:00
Sam	e6b3310577	FIX: never redirect back to `/sso` it will cause a loop If for any reason our return url is set to `/sso` bypass using it for login redirect	2018-11-09 14:27:36 +11:00
Vinoth Kannan	515e103db6	FIX: Don't enqueue topics if the user can't create them	2018-11-09 06:10:23 +05:30
Sam	15991677d4	FIX: ensure we never cache login redirects by mistake	2018-11-09 11:14:35 +11:00
Gerhard Schlager	24e5be3f0c	FIX: Relative links in translations should work with subfolder	2018-11-08 23:31:05 +00:00
Guo Xiang Tan	57f92ac808	Revert "Swtich to regexp for `DbHelper.remap`." Regexp is so much slower. This reverts commit `c3f89e3cd7`.	2018-11-08 14:20:09 +08:00
Guo Xiang Tan	c3f89e3cd7	Swtich to regexp for `DbHelper.remap`.	2018-11-08 14:08:38 +08:00
Sam	42572ff138	Revert font awesome 5 changes We are still pushing ahead on this 100% just need a bit longer to prepare all plugins	2018-11-08 16:12:18 +11:00
Guo Xiang Tan	9737938a4a	Add option to skip tabels when using `DbHelper.remap`.	2018-11-08 12:29:37 +08:00
Penar Musaraj	09dc922b3b	Fix several FontAwesome 5 issues add missing icons, update SvgSprite methods (to fix ruby 2.4 issues), update whisper icon in composer, fix alignment issues	2018-11-07 22:20:53 -05:00
Guo Xiang Tan	3365753bd0	PERF: Reduce number of database queries for `DbHelper.remap` * Cuts number of queries from 273 to 89 * Add some specs * For a table with 500 posts, benchmarks locally shows a runtime reduction from 0.046929135 to 0.032694705.	2018-11-08 10:54:39 +08:00
Gerhard Schlager	0122b8cd8b	Fix random build error Request specs could poison the cache since clear_cache! deletes only today and yesterday from the cache.	2018-11-08 02:51:42 +01:00
Penar Musaraj	005e1ecb9b	FEATURE: Update Font Awesome to v5.4.1 and SVGs (#6557 ) * First take on subsetting svg icons * FontAwesome 5 svg subset WIP * Include icons from plugins/badges into svg sprite subset * add svg icon support to themes * Add spec for SvgSprite * Misc. SVG icon fixes * Use FA5 svgs in local-dates plugin * CSS adjustments, fix SVG icons in group flair * Use SVG icons in poll plugin * Add SVG icons to /wizard	2018-11-07 13:05:43 -05:00
Guo Xiang Tan	1e64658c25	Fix brittle specs.	2018-11-07 15:02:53 +08:00
Sam	0a442e319c	FIX: correct svg handling for images We regressed and optimized images no longer worked with svg The following adds the correct logic to simply copy file for svgs and bypasses resizing for svg avatars	2018-11-07 15:29:26 +11:00
Bianca Nenciu	2070edf889	FIX: Clarify User.group_locked_trust_level. * Rename User.group_locked_trust_level to User.group_granted_trust_level. * Remove the column from users table.	2018-11-07 10:27:44 +08:00
Guo Xiang Tan	bdb8e9efdb	DEV: Remove mocks from specs.	2018-11-07 09:55:58 +08:00
Sam	06b9d8223a	FIX: search within topic not working correctly in CJK We were splitting the term prior to search causing everything to miss	2018-11-07 09:41:55 +11:00
Jeff Atwood	afbdf9c2d2	Merge pull request #6558 from pmusaraj/disallow-flagging-deleted-post FIX: disable flagging hidden posts	2018-11-05 11:05:32 -08:00
Penar Musaraj	7b3432f711	Enforce disabling flagging hidden posts server-side	2018-11-05 10:00:59 -05:00
Joffrey JAFFEUX	78954672f9	FIX: uses hex to compare images It prevents some terminals from crashing in case of errors and dumping the whole file content into the terminal.	2018-11-05 09:47:15 -05:00
Maja Komel	1ac3e5473a	FIX: don't strip eml attachments from received emails	2018-11-05 09:35:22 +01:00
Sam	d84256a876	FEATURE: add Noindex to robots.txt for disallowed routes This strips pages out of indexes that should not exist see: https://meta.discourse.org/t/pages-listed-in-the-robots-txt-are-crawled-and-indexed-by-google/100309/11?u=sam	2018-11-02 16:39:47 +11:00
Kyle Zhao	f9b36820ef	FIX: only extract script tags with certain types (#6553 ) `script` tags with custom types (e.g. `text/template`) are not executed by the browser, and should not be extracted into an external theme JavaScript	2018-11-01 16:01:46 -04:00
Robin Ward	ec91450aae	FEATURE: Track how many user flags are agreed/disagreed/ignored Display the percentage when reviewing flags.	2018-11-01 09:59:50 -04:00
Sam	ceafcbc898	FEATURE: show added date when looking at group members	2018-11-01 15:33:28 +11:00
Sam	aa044623bd	FIX: do not create superflous sessions when logged on In some SSO implementations we may want to issue SSO pipelines for already logged on users In these cases do not re-log-in a user if they are clearly logged on	2018-11-01 12:54:01 +11:00
Bianca Nenciu	fa0e421af3	FIX: Do not leak information about post revisions. (#6536 )	2018-10-31 14:47:00 +00:00
Sam	23423ba112	correct spec and error reporting previous commit misused warn_exception which caused a spec to fail	2018-10-31 13:38:05 +11:00
Blake Erickson	589e3fcaa0	FIX: return 400 for missing required params (#6546 ) If a required param is missing return a 400 and show a message displaying which param was missing. Added this to the application controller so that we don't have to add this logic to every controller action.	2018-10-31 13:02:48 +11:00
Bianca Nenciu	e0ccd36dbe	FEATURE: Suspicious logins report. (#6544 )	2018-10-30 22:51:58 +00:00
Bianca Nenciu	e1e392f15b	DEV: Use DiscourseIpInfo for all IP queries. (#6482 ) * DEV: Use DiscourseIpInfo for all IP queries. * UX: Use latitude and longitude for more precision.	2018-10-30 22:08:57 +00:00
Sam	9933059426	FEATURE: push related PMs to take first 3 slots Previously the related PMs were last meaning you would have to work through all unread to see them. Also amends it so it either asks for related by group OR user not both.	2018-10-29 10:47:59 +11:00
Rafael dos Santos Silva	2450f178ca	FEATURE: Allow admins to control PWA display mode per user agent	2018-10-26 13:47:22 -03:00
Joffrey JAFFEUX	b2585524a9	FEATURE: adds a most disagreed flaggers report	2018-10-26 15:59:04 +02:00
Penar Musaraj	ed9c21e42c	FEATURE: hide muted categories from /categories list (#6531 )	2018-10-26 11:34:39 +11:00
Régis Hanol	d17c8df926	Only check for suspicious login for staff members	2018-10-26 00:29:28 +02:00
Régis Hanol	306d77b54f	FIX: don't use srcset on cropped thumbnails	2018-10-25 16:08:10 +02:00
Kyle Zhao	a6eca28ec6	CSP - extract all other inline JavaScripts (#6528 ) * wizard page inline js * print topic inline js * drop JS for preventing double submission this is the default behavior with Rails' UJS `disable_with` helper * omniauth complete redirect JS * account activate inline js	2018-10-25 09:52:01 -04:00
David Taylor	56e0f47bcd	FIX: Do not update `last_seen` for API access This regressed in `2dc3a50`. I have now added tests for the behavior.	2018-10-25 13:38:57 +01:00
Bianca Nenciu	effbef7d0b	UX: Use user locale for locations. (#6527 ) * UX: Use user locale for locations. * DEV: Added MaxMindDB test data and fixed test.	2018-10-25 10:54:01 +00:00
Joffrey JAFFEUX	8e274f7296	UX: bumps the user-api-key version to 3 (#6526 ) * UX: bumps the user-api-key version to 3 * fix spec	2018-10-25 09:46:34 +00:00
Bianca Nenciu	6a3767cde7	FEATURE: Warn users via email about suspicious logins. (#6520 ) * FEATURE: Warn users via email about suspicious logins. * DEV: Move suspicious login check to a job.	2018-10-25 09:45:31 +00:00
Régis Hanol	addf6f6d17	FIX: support comma in 'sso_provider_secrets' site setting	2018-10-24 21:23:18 +02:00
Sam	e955a7b49d	Revert "Revert "FIX: GlobalPath#upload_cdn_path when S3 bucket has a folder (#6523 )"" This reverts commit `322b27b6dc`. Oops rushed on the revert here... should be good	2018-10-24 15:14:01 +11:00
Sam	322b27b6dc	Revert "FIX: GlobalPath#upload_cdn_path when S3 bucket has a folder (#6523 )" This reverts commit `63356d883e`. This caused an outage, got to revert	2018-10-24 15:03:58 +11:00
Kyle Zhao	63356d883e	FIX: GlobalPath#upload_cdn_path when S3 bucket has a folder (#6523 )	2018-10-24 14:34:10 +11:00
Sam	5fd94d3211	PERF: limit unread count to 99 in blue circle This revises: `e605542c4e` Previous commit was faulty	2018-10-24 12:10:27 +11:00
Daniel Hollas	cee51672c9	FIX: Strip accents from search query `4481836` introduced accent stipping in search_indexer, but we need to strip it from the query itself as well TODO in search with diacritics: - Still need to fix excerpts on search page - need to support accent stripping in in_topic search - need to make sure that in:title works correctly - need to fix "word boldening" in titles	2018-10-23 12:10:33 +11:00
Sam	b74dd7d379	FIX: stop logging every 404 error when searching for gravatars	2018-10-23 11:43:14 +11:00
Sam	adab7a3a48	improve test, also ensure no zero size is generated	2018-10-23 08:50:07 +11:00
Sam	bea8d337b2	DEV: ensure resizing test does not raise bad error Current resizing test was showing binary diff in terminal and failing in latest image magick 7, this fixes both issues	2018-10-23 08:45:06 +11:00
Kyle Zhao	e9a971a2b6	FEATURE: [Experimental] Content Security Policy (#6514 ) do not register new MIME type, parse raw body instead	2018-10-22 13:22:23 -04:00
Régis Hanol	3e232412e3	UX: show error when hitting the rate limit on password reset	2018-10-22 19:00:30 +02:00
Bianca Nenciu	99b43f281b	FIX: Fix browser detection for Microsoft Edge. (#6516 ) cool!	2018-10-22 23:15:41 +11:00
David Taylor	3377f26eba	FIX: Clean tag before searching for matches	2018-10-22 11:09:06 +01:00
Arpit Jalan	ce0a51665e	FIX: count emoji shortcuts in topic title https://meta.discourse.org/t/max-emojis-in-title-set-to-0-conflicting-with-emoji-shortcuts/98368/3?u=techapj	2018-10-22 13:44:05 +05:30
Kyle Zhao	dca830cb73	Revert "FEATURE: [Experimental] Content Security Policy (#6504 )" This reverts commit `fb8231077a`.	2018-10-19 11:53:29 -04:00
Kyle Zhao	fb8231077a	FEATURE: [Experimental] Content Security Policy (#6504 )	2018-10-19 10:39:22 -04:00
David Taylor	7166d7de9a	FIX: Prevent duplicate tags in tag-choosers (#6512 ) * FIX: Prevent duplicate tags in tag-choosers This reverts `5685b45`, which fixes the duplicate tags problem. The fix introduced by `5685b45` is re-implemented on the server.	2018-10-19 13:44:43 +01:00
Guo Xiang Tan	65faff5832	DEV: Improve specs to provide a better error message.	2018-10-19 14:31:17 +08:00
Sam	9bfc939692	cleanup so gravatar download failures are consistent previously we would ignore socket error, but this would mean that there could be conditions where we would keep trying to download gravatars forever (in an hourly job)	2018-10-19 12:51:55 +11:00
Blake Erickson	f1ba981ae9	Improve add user to group spec for uppercase usernames Oops forgot to check for this. See previous commit for more details.	2018-10-18 13:32:36 -06:00
Blake Erickson	93485facaf	FIX: lowercase username for add/rem group members This fix searches for users based on the downcased username so that if you pass in usernames to add/remove from a group and you don't have the casing just right it will still find the correct users. I updated the tests to add a username that has a mix of upper and lowercase letters to verify this functionality.	2018-10-18 13:17:24 -06:00
Régis Hanol	3973823a33	FIX: always update 'last_gravatar_download_attempt' when updating gravatar	2018-10-18 11:02:54 +02:00
Guo Xiang Tan	bbf542da01	DEV: Prefer `<<~` over `<<`.	2018-10-18 14:17:30 +08:00
Kyle Zhao	0f1afad6da	FIX: extracted theme JavaScripts for multisite (#6502 ) * FIX: extracted theme javascripts for multisite * onceoff to rebake all theme fields	2018-10-18 17:05:34 +11:00
Bianca Nenciu	f60b10d090	UX: Warn users if the post that's currently edited has changed. (#6498 )	2018-10-17 15:35:32 +02:00
David Taylor	501ac4dfa6	DEV: Cleanup properly after user_serializer test	2018-10-17 10:54:22 +01:00
David Taylor	c6f364224e	FEATURE: Allow plugins to whitelist user custom fields for public display (#6499 ) This works exactly the same as `whitelist_staff_user_custom_fields`, but is not limited to staff	2018-10-17 10:33:27 +01:00
Arpit Jalan	42c405a820	FIX: use topic summary for meta description if topic excerpt is blank	2018-10-17 14:13:30 +05:30
Sam	19d7543004	FIX: clear color scheme cache when clearing theme cache	2018-10-16 12:00:46 +11:00
Penar Musaraj	b06dccac49	FIX: force enable a user's email_private_messages option when user replies via email (#6478 ) * Enable user email PM when posting to group or replying to topic via email * remove extra line * Add test and fix snake_case * Only reenable email_private_messages for PM replies	2018-10-16 10:51:57 +11:00
Davide Porrovecchio	005e1f5373	Add Cache-Control header to CORS (#6490 )	2018-10-16 10:46:55 +11:00
Sam	fc94732f88	avoid looking up badge multiple times in spec	2018-10-16 10:42:16 +11:00
Bianca Nenciu	c68a456baa	FIX: Do not award badges for links in restricted categories. (#6492 )	2018-10-16 10:38:59 +11:00
Neil Lalonde	0724948878	fix failing spec when HUB_BASE_URL is present	2018-10-15 15:06:02 -04:00
Neil Lalonde	d166c38ab7	REFACTOR: distributed_cache is moved to the message_bus gem	2018-10-15 15:01:45 -04:00
Kyle Zhao	99d1ded3b3	rename route `/javascripts` to `/theme-javascripts` (#6495 )	2018-10-15 11:32:52 -04:00
Maja Komel	c104256991	FIX: SSO provider secrets - check wildcard domains last, toggle secrets visibility	2018-10-15 16:18:29 +02:00
David Taylor	7ac08f936e	FEATURE: Upload tags from CSV (#6484 )	2018-10-15 09:12:54 +01:00
Guo Xiang Tan	8fa59f0548	FIX: Can't clean a tag if the given string is frozen.	2018-10-15 14:48:45 +08:00
Maja Komel	27e732a58d	FEATURE: allow multiple secrets for Discourse SSO provider This splits off the logic between SSO keys used incoming vs outgoing, it allows to far better restrict who is allowed to log in using a site. This allows for better auditing of the SSO provider feature	2018-10-15 16:03:53 +11:00
Kyle Zhao	6acdea37c4	DEV: extract inline js when baking theme fields (#6447 ) * extract inline js when baking theme fields * destroy javascript cache when destroying theme fields This work is needed to support CSP work	2018-10-15 15:55:23 +11:00
Guo Xiang Tan	aa60936115	DEV: Add order to avoid randomly failing test.	2018-10-15 11:42:45 +08:00
Guo Xiang Tan	5ae4cbcf88	DEV: Clear `ColorScheme.hex_cache` to avoid leaking state.	2018-10-15 11:16:26 +08:00
Guo Xiang Tan	2ce684b134	DEV: Clear `hex_cache` after each test.	2018-10-15 10:24:46 +08:00
Guo Xiang Tan	84d4c81a26	FEATURE: Support backup uploads/downloads directly to/from S3. This reverts commit `3c59106bac`.	2018-10-15 09:43:31 +08:00
Sam	057087e0e8	FEATURE: log long running jobs in the defer queue If a job in the defer queue takes longer than 90 seconds log an error	2018-10-12 17:03:47 +11:00
Sam	a1c912b630	Return 400 instead of 404 for bad token	2018-10-12 10:51:41 +11:00
Bianca Nenciu	048cdfbcfa	FIX: Do not allow revoking the token of current session. (#6472 ) * FIX: Do not allow revoking the token of current session. * DEV: Add getter of current auth_token from Guardian.	2018-10-12 10:40:48 +11:00
Blake Erickson	13b3cead06	FEATURE: Allow bulk removing users from a group This change maintains backwards compatibility to allow you to remove a single user from a group but allows you to specify a comma separated list of users for bulk removal from a group. Also it extracts out common functionality for fetching users from params used in bulk adding users so it can also be used for removing users.	2018-10-11 15:30:54 -06:00
Neil Lalonde	12f132736b	FIX: error looking at users in admin when tl3_promotion_min_duration is set to a very high value	2018-10-11 15:11:48 -04:00
Gerhard Schlager	7a41a783a4	FIX: Don't reply to Unsubscribe email sent to mailing list mirror	2018-10-11 16:09:22 +02:00
Vinoth Kannan	6a444eee56	Merge pull request #6476 from vinothkannans/tl4-flag FEATURE: automatically hide non-TL4 posts when flagged by a TL4 user	2018-10-11 17:13:26 +05:30
Vinoth Kannan	227a49bb32	FEATURE: automatically hide non-TL4 posts when flagged by a TL4 user	2018-10-11 17:11:46 +05:30
Guo Xiang Tan	3c59106bac	Revert "FEATURE: Support backup uploads/downloads directly to/from S3." This reverts commit `c29a4dddc1`. We're doing a beta bump soon so un-revert this after that is done.	2018-10-11 11:08:23 +08:00
Gerhard Schlager	c29a4dddc1	FEATURE: Support backup uploads/downloads directly to/from S3.	2018-10-11 10:38:43 +08:00
Guo Xiang Tan	5039a6c3f1	FIX: Strip null bytes in mail subjects.	2018-10-11 09:46:32 +08:00
Vinoth Kannan	59be289084	FIX: Do not add lightbox to onebox images (#6479 )	2018-10-11 08:57:21 +11:00
Robin Ward	a566ed42ae	FEATURE: Option to disable user presence and profile This allows users who are privacy conscious to disable the presence features of the forum as well as their public profile.	2018-10-10 17:34:33 -04:00
Bianca Nenciu	4e0533a20b	FIX: Generate Onebox for posts of type moderator_action. (#6466 )	2018-10-10 18:39:03 +08:00
Sam	45f01e637b	FIX: when associating Github account disassociate others There are some cases where an email floats from one GitHub account to another if this happens just take over the Github mapping record	2018-10-10 15:46:50 +11:00
Guo Xiang Tan	f26804394a	DEV: Remove the use of stubs on `Rails.logger` in our test suite.	2018-10-10 09:34:50 +08:00
Bianca Nenciu	1d26a473e7	FEATURE: Show "Recently used devices" in user preferences (#6335 ) * FEATURE: Added MaxMindDb to resolve IP information. * FEATURE: Added browser detection based on user agent. * FEATURE: Added recently used devices in user preferences. * DEV: Added acceptance test for recently used devices. * UX: Do not show 'Show more' button if there aren't more tokens. * DEV: Fix unit tests. * DEV: Make changes after code review. * Add more detailed unit tests. * Improve logging messages. * Minor coding style fixes. * DEV: Use DropdownSelectBoxComponent and run Prettier. * DEV: Fix unit tests.	2018-10-09 22:21:41 +08:00
Bianca Nenciu	1fb1f4c790	FIX: Make error in Discourse Hub more descriptive. (#6438 )	2018-10-09 22:05:31 +08:00
David Taylor	ac89a728f8	DEV: Remove autospec hacks for social auth providers This was causing erratic test failures. Autospec continues to work after removing, so this 5-year-old code is no longer needed.	2018-10-09 12:42:57 +01:00
Erin Kosewic	51aba32651	FEATURE: add branch option to remote theme import * FEATURE: add branch option to remote theme import * FIX: Add missing variable in params * FIX: Add missing param for import_theme method * SPEC: Add test methods for branch support in git import * FIX: Add missing space to scss style * Do not assume default branch as master * Change branch field placeholder * FIX: add missing div start tag	2018-10-09 17:01:08 +11:00
Gerhard Schlager	2f90c15d7a	Fix random build error	2018-10-09 01:03:05 +02:00
Gerhard Schlager	4881fb028f	FIX: allow_uppercase_posts didn't work for topic titles	2018-10-08 23:50:06 +02:00
Joffrey JAFFEUX	22187508e3	FEATURE: adds header text/background color to site (#6462 )	2018-10-08 11:52:57 +02:00
Guo Xiang Tan	40fa96777d	FEATURE: Post deployment migrations. (#6406 ) This moves us away from the delayed drops pattern which was problematic on two counts. First, it uses a hardcoded "delay for" duration which may be too short for certain deployment strategies. Second, delayed drop doesn't ensure that it only runs after the latest application code has been deployed. If the migration runs and the application code fails to deploy, running the migration after "delay for" has been met will cause the application to blow up. The new strategy allows post deployment migrations to be skipped if the env `SKIP_POST_DEPLOYMENT_MIGRATIONS` is provided. ``` SKIP_POST_DEPLOYMENT_MIGRATIONS=1 rake db:migrate -> deploy app servers SKIP_POST_DEPLOYMENT_MIGRATIONS=0 rake db:migrate ``` To aid with the generation of a post deployment migration, a generator has been added. Simply run `rails generate post_migration`.	2018-10-08 15:47:38 +08:00
Arpit Jalan	c0bb04d89d	FIX: convert tag string to array when filtering topic list by tags	2018-10-08 08:56:25 +05:30
Guo Xiang Tan	1b1ef21481	DEV: Improve `Jobs::CleanUpEmailLogs` specs.	2018-10-08 11:11:20 +08:00
Penar Musaraj	26956bbe1a	FIX: Safari issue with some emojis (#6456 ) https://meta.discourse.org/t/emojis-selected-on-ios-displaying-additional-rectangles/86132/8	2018-10-08 10:32:25 +08:00
Sam	550e108a8c	FEATURE: only export settings that changed via rake task	2018-10-08 11:54:52 +11:00
Vinoth Kannan	4000dddd32	Merge pull request #6458 from vinothkannans/fix-giphy FIX: Display large/broken image placeholders for image oneboxes	2018-10-07 18:08:54 +05:30
Vinoth Kannan	c499872597	FIX: Display large/broken image placeholders for image oneboxes	2018-10-07 17:42:41 +05:30
David Taylor	9bf522f227	FEATURE: Mixed case tagging (#6454 ) - By default, behaviour is not changed: tags are made lowercase upon creation and edit. - If force_lowercase_tags is disabled, then mixed case tags are allowed. - Tags must remain case-insensitively unique. This is enforced by ActiveRecord and Postgres. - A migration is added to provide a `UNIQUE` index on `lower(name)`. Migration includes a safety to correct any current tags that do not meet the criteria. - A `where_name` scope is added to `models/tag.rb`, to allow easy case-insensitive lookups. This is used instead of `Tag.where(name: "blah")`. - URLs remain lowercase. Mixed case URLs are functional, but have the lowercase equivalent as the canonical.	2018-10-05 10:23:52 +01:00
Vinoth Kannan	8430ea927e	FIX: Generate webhook payloads before destroy events (#6325 )	2018-10-05 16:53:59 +08:00
Sam	5b630f3188	FIX: stop logging every time invalid params are sent Previously we were logging warning for invalid encoded params, this can cause a log flood	2018-10-05 14:33:19 +10:00
Vinoth Kannan	3faa022c6f	Merge pull request #6453 from vinothkannans/sso_provider_redirect FIX: redirect users to SSO client URL after social login	2018-10-05 00:34:34 +05:30
Vinoth Kannan	ca74246651	FIX: redirect users to SSO client URL after social login	2018-10-05 00:01:08 +05:30
David Taylor	5b56a8cd09	DEV: Merge multiple discourse_tagging_spec files	2018-10-04 15:44:29 +01:00
Maja Komel	361ad7ed2b	FEATURE: add indication if incoming email attachment was rejected and inform sender about it (#6376 ) * FEATURE: add indication if incoming email attachment was rejected and inform sender about it * include errors for rejected attachments in email * don't send warning email to staged users * use user object instead of user_id in add_attachments method	2018-10-04 22:08:28 +08:00
Paul Trippett	b8a1196b6b	Add missing fields to Upload Fabricator (#6448 )	2018-10-04 22:00:07 +08:00
Guo Xiang Tan	d43ed4afa2	Remove unused variable.	2018-10-04 13:21:37 +08:00
Lucas Nicodemus	1907338834	FIX: No longer educate users who are editing A user editing a post will no longer get composer messages that are meant for new users posting replies and threads. These messages don't make sense in an edit context at all -- they're usually discussing making salient replies or topics, or adding avatars. They make even less sense when a user is an admin attempting to change the default topics for the first time. Since these messages actually do make sense for a user when they have a low post count, though, they're still going to occur. They just occur when a user is creating new content (and thus, more likely to read the notice), not during edits. This is in response to this issue: https://meta.discourse.org/t/education-message-for-editing-wiki-topic/66682	2018-10-04 13:20:13 +08:00
Vinoth Kannan	a651d39b8a	FIX: Display errors in single theme pages (#6449 ) Currently the errors are not well handled. So it breaks the whole UI of admin themes list page.	2018-10-04 02:33:06 +05:30
Sam	ad0e768742	FEATURE: add support for responsive images in posts When creating lightboxes we will attempt to create 1.5x and 2x thumbnails for retina screens, this can be controlled with a new hidden site setting called responsice_post_image_sizes, if you wish to create 3x images run SiteSetting.responsive_post_image_sizes = "1\|1.5\|2\|3" The default should be good for most of the setups as it balances filesize with quality. 3x thumbs can get big.	2018-10-03 13:44:53 +10:00
Neil Lalonde	dc1e7bb645	UX: when admin is deleted, make it clear in staff action logs when records belong to a deleted user and show their username in the details	2018-10-02 13:46:54 -04:00
Penar Musaraj	34516c72bd	FIX: Recover public actions (likes) when recovering a post (#6412 )	2018-10-02 11:25:08 -04:00
Joffrey JAFFEUX	a515ba8612	FIX: corrects typo and adds a spec for likes report (#6439 ) * FIX: corrects typo and adds a spec for likes report * save!	2018-10-02 02:27:43 -07:00
Bianca Nenciu	e0d7cdac12	UX: Improve error messages for minimum and maximum username lengths.	2018-10-02 13:10:20 +08:00
Penar Musaraj	da9eee5262	FIX: Force enable user PM emails option when user posts to a group by email.	2018-10-02 12:38:10 +08:00
Gerhard Schlager	e2770bc1c4	FIX: async reload of locales could result in missing translations	2018-10-01 17:14:36 +02:00
Guo Xiang Tan	cfa7173da3	FIX: Onceoff job to fix missing user profile backgrounds.	2018-10-01 16:26:40 +08:00
Guo Xiang Tan	de85bb0a39	FIX: Don't update user_profile URLs unless upload is persisted.	2018-10-01 14:21:39 +08:00
Guo Xiang Tan	e262a08350	Add `UploadRecovery#recover_user_profile_backgrounds`.	2018-10-01 10:51:54 +08:00
Robin Ward	02da022c70	PERF: Quit out of the email job quickly if disabled (#6423 ) This prevents sidekiq from doing a bunch of queries when email is disabled. Critical emails are a special case and will be sent.	2018-10-01 01:15:45 +08:00
Kyle Zhao	819f090d6a	move large blobs out of `<head>` (#6428 ) it unnecessarily bloats the section and increases the payload dramatically for open graph tags.	2018-09-28 17:28:33 +08:00
Penar Musaraj	70d74f8fc1	FIX: advanced search ordering broken when using tags	2018-09-28 17:27:08 +08:00
Bianca Nenciu	5407036ef9	DEV: Run prettier. (#6420 )	2018-09-21 11:02:23 +00:00
Kyle Zhao	e402394375	FEATURE: auto grant an available title when removing old title * FEATURE: auto grant an available title when removing old title	2018-09-21 12:06:08 +10:00
Kyle Zhao	4bb980b9f7	FEATURE: do not allow moderators to export user list (#6418 )	2018-09-21 09:07:13 +08:00
Guo Xiang Tan	1a64b3a487	FIX: Don't try to recover an invalid sha1.	2018-09-20 14:21:57 +08:00
Sam	df45e82377	SECURITY: only allow picking of avatars created by self (#6417 ) * SECURITY: only allow picking of avatars created by self Also adds origin tracking to all uploads including de-duplicated uploads	2018-09-19 22:33:10 -07:00
Guo Xiang Tan	195bd02fce	FIX: Avoid race condition when enqueuing job.	2018-09-20 11:24:01 +08:00
Jeff Wong	d5442fbf08	FIX: do not send tl1 welcome message when a user has the basic user badge	2018-09-19 12:53:36 -07:00
Guo Xiang Tan	767f27929d	Rename `Jobs::RecoverPostUploads` to rerun the job take 2.	2018-09-19 22:40:32 +08:00
Guo Xiang Tan	d403883d16	DEV: Improve specs for `293cf600f0`.	2018-09-19 16:03:52 +08:00
Sam	5302709343	FIX: in redis readonly raise an exception from DistributedMutex If we detect redis is in readonly we can not correctly get a mutex raise an exception to notify caller When getting optimized images avoid the distributed mutex unless for some reason it is the first call and we need to generate a thumb In redis readonly no thumbnails will be generated	2018-09-19 15:50:58 +10:00
Guo Xiang Tan	bc7f58191e	FIX: `UploadRecovery` should look at links too.	2018-09-19 11:52:57 +08:00
Guo Xiang Tan	4a92c5b2d6	`UploadRecovery` should recover attachments too.	2018-09-19 10:44:36 +08:00
Vinoth Kannan	9281b72308	FEATURE: Log entity export in staff logs	2018-09-19 03:16:45 +05:30
Arpit Jalan	fadcd36f92	FIX: do not treat ignore_redirects domains as blacklisted This fix prevents domains present in `ignore_redirects` to be treated as blacklisted domains and makes sure that onboxing happens for those domains. Issue reported here: https://meta.discourse.org/t/steam-store-oneboxing-no-longer-works/97266	2018-09-18 10:38:02 +05:30
Guo Xiang Tan	ce6a0a5e9e	FIX: Moving upload to tombstone should update modification time. A upload created a long time ago will be nuked from the tombstone immediately if it gets deleted.	2018-09-18 10:48:29 +08:00
Guo Xiang Tan	f2fbf1fdb0	DEV: Basic specs for `TagGroupsController`.	2018-09-18 08:22:03 +08:00
Sam	7d6b348d0b	SECURITY: correct XSS on long topic titles	2018-09-18 08:54:44 +10:00
Régis Hanol	4481836de2	FEATURE: new 'search_ignore_accents' site setting	2018-09-17 10:42:30 +02:00
Kyle Zhao	7a0232249a	extract inline JS that's used to store preloaded data (#6370 )	2018-09-17 16:31:46 +08:00
Kyle Zhao	7b19ed06c1	reworked specs of existing group behavior	2018-09-17 17:46:43 +10:00
Kyle Zhao	6659417807	FEATURE: match user title when primary group changes When primary group changes and the user's title is the previous primary group's title, change the title to the new primary group's title	2018-09-17 15:08:39 +10:00
Sam	33541c4096	FEATURE: unconditionally omit no-follow for staff Previously TL2 and below staff would have links no-followed which was never intended	2018-09-17 12:02:20 +10:00
Sam	37c5280f73	correct spec	2018-09-17 11:37:01 +10:00
Rishabh	4f46aa1ba3	FEATURE: Add SiteSetting for s3_configure_tombstone_policy Add SiteSetting for s3_configure_tombstone_policy, skip policy generation if turned off (default on)	2018-09-17 10:57:50 +10:00
Sam	725d2c0d47	correct spec	2018-09-17 10:54:35 +10:00
Sam	173d0d53d5	correct erratic spec	2018-09-17 10:12:00 +10:00
OsamaSayegh	c7d81e2682	FIX/FEATURE: don't blow up when can't reach theme's repo, show problem themes on dashboard	2018-09-17 09:49:53 +10:00
Neil Lalonde	526ffc4966	FIX: error in response body to blocked crawlers, showing 500 Internal Server Error with status of 403	2018-09-14 15:40:20 -04:00
Neil Lalonde	b87a089822	FIX: don't block api requests when whitelisted_crawler_user_agents is set	2018-09-14 15:40:20 -04:00
Guo Xiang Tan	c3f6b4d966	DEV: Test against real `Upload#url` format.	2018-09-14 13:43:33 +08:00
Sam	419b14e58b	FIX: correctly keep stylesheet cache entries The intent from day one was to keep MAX_TO_KEEP stylesheets per target however the DELETE statement did not perform target filtering This meant we often deleted the wrong stylesheets from the cache	2018-09-14 12:54:11 +10:00
Guo Xiang Tan	6a2589353b	Merge pull request #6394 from tgxworld/recover_broken_uploads FIX: Onceoff job to recover missing post uploads.	2018-09-13 18:16:56 -07:00
Guo Xiang Tan	aa1af9fc22	FIX: Onceoff job to recover missing post uploads. This fixes the regression due to `1f636c445b`	2018-09-14 09:04:01 +08:00
Gerhard Schlager	fd931b948d	Use a more helpful failure message in spec	2018-09-13 21:31:44 +02:00
Régis Hanol	30619c244c	FIX: don't index urls to local files	2018-09-13 18:53:53 +02:00
Joffrey JAFFEUX	a6502ce879	FIX: ensures errors in report initialization fail nicely (#6392 )	2018-09-13 17:36:55 +02:00
Guo Xiang Tan	2ae7d3a118	Merge pull request #6388 from pmusaraj/drafts-second-user-test Add test to ensure a user cannot see drafts stream of another user	2018-09-13 06:53:44 -07:00
Arpit Jalan	d288462abf	Merge pull request #6393 from techAPJ/bad-json FIX: ignore and log bad json values for custom fields	2018-09-13 15:54:01 +05:30
Arpit Jalan	e364547ff7	FIX: ignore and log bad json values for custom fields	2018-09-13 14:26:30 +05:30
Guo Xiang Tan	0a06b3d977	Accept custom AR relation for `UploadRecovery`.	2018-09-13 16:33:14 +08:00
Guo Xiang Tan	6c65718301	Include response body when raising an error in `FileHelper#download`.	2018-09-13 15:43:58 +08:00
Guo Xiang Tan	05a57d4f27	DEV: Clear cache after not before. * Clearing after ensures that state does not leak to specs in other files.	2018-09-13 14:23:32 +08:00
Guo Xiang Tan	5eb65ad612	FIX: Do not try to recover invalid `Upload#short_url` in `UploadRecovery`.	2018-09-13 13:59:17 +08:00
Guo Xiang Tan	1afe7162e1	Fix the build.	2018-09-13 13:41:38 +08:00
Guo Xiang Tan	d99dd840e4	Add basic test case for `UploadRecovery`.	2018-09-13 13:26:23 +08:00
pmusaraj	7f05af5995	cleanup	2018-09-12 13:10:14 -04:00
pmusaraj	aa614e393c	return 403 when trying drafts of another user	2018-09-12 13:08:02 -04:00
pmusaraj	b8c0a29bec	better test name	2018-09-12 11:09:30 -04:00
pmusaraj	11fd18b254	code-styling fixes	2018-09-12 11:06:30 -04:00
pmusaraj	3a00c2adeb	add test to ensure that userA cannot see drafts stream of userB	2018-09-12 10:13:20 -04:00
Guo Xiang Tan	3884e99e88	Add extra protection in `Upload#get_from_url`. In case the extension goes missing from the URL.	2018-09-12 00:12:14 -07:00
Guo Xiang Tan	b3469bea2d	FIX: Uploads not being linked correctly to posts. Regression due to `1f636c445b`.	2018-09-11 23:50:23 -07:00
Sam	d1984a0b4d	FIX: display a correct error when attempting to agree on a deferred flag Previously we would raise a 500 error if a moderator tried to agree on a flag another moderator deferred. This can happen cause the UX for flags does not live refresh as flags are handled	2018-09-12 13:16:59 +10:00
Guo Xiang Tan	71185c13b5	Merge pull request #6377 from tgxworld/remove_tif_tiff Drop `tif`, `tiff`, `webp` and `bmp` from supported images.	2018-09-12 09:32:32 +08:00
Guo Xiang Tan	71caf7521d	Drop `tif`, `tiff`, `webp` and `bmp` from supported images. https://meta.discourse.org/t/cr2-raw-files-are-being-treated-as-tiff-files/96775/3?u=tgxworld	2018-09-12 09:29:54 +08:00
Osama Sayegh	16bd3f2cf2	FIX: use current user color scheme when filling `theme-color` attribute (#6384 ) * FIX: use current user color scheme when filling `meta` attribute `theme-color` * update manifest.webmanifest colors	2018-09-12 11:04:58 +10:00
Robin Ward	3bb4f4c5ef	Adds test to make sure moderators can't make master keys It wasn't obvious from the code, plus we'd never want this to regress!	2018-09-11 12:02:06 -04:00
Gerhard Schlager	1a01385e88	FIX: "false" didn't work as locale_default	2018-09-11 13:42:10 +02:00
Guo Xiang Tan	85620abb71	DEV: Clear connections after multisite specs.	2018-09-11 10:15:06 +08:00
Sam	e64402cb3b	SECURITY: correct edge case when SSO provides unvalidated emails	2018-09-11 08:24:02 +10:00
Rishabh	80eace4268	Merge pull request #6383 from discourse/fix_username_suggester FIX: don't raise an error on integer usernames in user_name_suggester	2018-09-11 00:30:29 +05:30
Rishabh Nambiar	81c87df18a	FIX: don't raise an error on integer usernames	2018-09-10 22:17:56 +05:30
David Taylor	84fc7abb73	FIX: Allow `rake destroy:topics` to delete topics in sub-categories	2018-09-10 12:52:14 +01:00
Guo Xiang Tan	df04e69cde	FIX: `S3Helper#list` creates incorrect prefix.	2018-09-10 16:34:40 +08:00
Neil Lalonde	9e77fd8fc3	FIX: wrong category links on subfolder install in rss feed for a category topic list	2018-09-07 10:03:30 -04:00
Sam	879067d000	FIX: check admin theme cookie against user selectable previously admin got a free pass and could set theme via cookie to anything including themes that are not selectable this refactor ensures that only "preview" gets a free pass, all the rest goes through the same pipeline	2018-09-07 10:47:28 +10:00
Gerhard Schlager	797cbf8653	FIX: Remove user fields when anonymizing user	2018-09-07 00:02:56 +02:00
Guo Xiang Tan	1f636c445b	PERF: Add fast path to find uploads before resorting to `LIKE` query. For a normal upload url Before ``` Warming up -------------------------------------- 264.000 i/100ms Calculating ------------------------------------- 2.754k (± 8.4%) i/s - 13.728k in 5.022066s ``` After ``` Warming up -------------------------------------- 341.000 i/100ms Calculating ------------------------------------- 3.435k (±11.6%) i/s - 17.050k in 5.045676s ```	2018-09-06 14:44:24 +08:00
Guo Xiang Tan	d4b05d7bc5	Always link post to uploads in post process. The operation is cheap anyway so no point skipping.	2018-09-06 14:08:03 +08:00
Guo Xiang Tan	434035f167	FIX: Link post to uploads in `PostCreator`. * This ensures that uploads are linked to their post on creation instead of a background job which may be delayed if Sidekiq is facing difficulties.	2018-09-06 11:18:11 +08:00
Gerhard Schlager	26082688d1	FIX: Zero is a valid value for the page parameter	2018-09-05 20:43:05 +02:00
Guo Xiang Tan	f3aef2cc83	FIX: Incorrect/missing extension in short_url fails to map to upload. `Hash#invert` causes us to lose keys if the hash contains similar values.	2018-09-05 21:48:58 +08:00
Gerhard Schlager	2c5d9269a0	FIX: Notifications shouldn't use user locale unless allow_user_locale is enabled	2018-09-05 11:44:28 +02:00
Sam	d9c0dc8687	correct prev commit s3. did not exists it is s3-	2018-09-05 16:11:44 +10:00
Sam	83e1315e42	FIX: correct urls in uploads table to point at dualstack Last week we added support for dual stack urls but did not remap the the old records in the uploads and optimized images table This caused a few minor edge cases worst was that if you rebaked old images S3 CDN was not repopulated.	2018-09-05 15:58:04 +10:00
Gerhard Schlager	b8fc699164	FIX: Detect {{foo}} as interpolation key	2018-09-05 00:47:39 +02:00
Vinoth Kannan	d9be4f47e8	SPEC: redirect to original URL after social signup	2018-09-05 03:24:50 +05:30
Vinoth Kannan	d8b543bb67	FIX: redirect to original URL after social signup	2018-09-05 01:44:23 +05:30
David Taylor	4382fb5fac	DEV: Allow plugins to whitelist specific user custom_fields for editing (#6358 )	2018-09-04 20:45:36 +10:00
Guo Xiang Tan	3b337bfc6b	Revert "FIX: Don't rate limit admin and staff constraints when matching routes." This reverts commit `651b50b1a1`.	2018-09-04 14:27:21 +08:00
Guo Xiang Tan	19182c0c8f	DEV: Skip fragile tests for now.	2018-09-04 13:58:09 +08:00
Guo Xiang Tan	651b50b1a1	FIX: Don't rate limit admin and staff constraints when matching routes. * When an error is raised when checking route constraints, we can only return true/false which either lets the request through or return a 404 error. Therefore, we just skip rate limiting here and let the controller handle the rate limiting.	2018-09-04 13:52:58 +08:00
Guo Xiang Tan	08b268c5bc	Be more forceful in disconnecting connections during failover.	2018-09-04 10:32:43 +08:00
Sam	ad70502ab8	FIX: ignore invalid usernames in incoming link tracker If an incoming link username has NULL in it simply ignore it	2018-09-04 12:28:32 +10:00
Guo Xiang Tan	8dc1463ab3	Enable `Lint/ShadowingOuterLocalVariable` for Rubocop.	2018-09-04 10:16:42 +08:00
Sam	2f5c21e28c	FIX: return a 400 error instead of 500 for null injections Many security scanners like to inject NULL in inputs causing application to exception out and return a 500 We now handle this exception and render a 400 status back	2018-09-04 12:11:52 +10:00
Gerhard Schlager	eeedc3901e	FIX: Replying to deleted post via email should create new reply to topic	2018-09-03 23:06:40 +02:00
Vinoth Kannan	24a14af15a	FIX: Respect invalidate_oneboxes option for inline oneboxes	2018-09-03 22:33:43 +05:30
Guo Xiang Tan	ecf60c0c33	DEV: More attempts at stablizing specs in Travis. Re-enable skipped test because it doesn't fail locally for me to debug it.	2018-09-03 14:52:15 +08:00
Gerhard Schlager	f33433bf9e	Validation of params should restrict to max int (#6331 ) * FIX: Validation of params should restrict to max int * FIX: Send status 400 when "page" param isn't between 1 and max int	2018-09-03 14:45:32 +10:00
Guo Xiang Tan	747c9bb47f	Merge pull request #6317 from nbianca/ignore_blacklisted_domains FIX: Ignore OneBox blacklisted domains.	2018-09-03 11:10:52 +08:00
Guo Xiang Tan	0fac6cdba9	DEV: Better debugging information when test fails.	2018-09-03 10:55:25 +08:00
Maja Komel	182d9a4666	FIX: escape regex chars when searching site texts	2018-09-02 17:25:57 +10:00
Bianca Nenciu	f5e0356fb2	correct miscellaneous issues with user login history	2018-09-02 17:24:54 +10:00
Osama Sayegh	60eff9421a	FIX: precompile `desktop_theme` and `mobile_theme` stylesheets required for environments that pre stage docker images and keep old image running during the deploy	2018-08-31 21:23:55 +10:00
Guo Xiang Tan	5a214a687c	FIX: Exclude `UserAuthToken` and `UserAuthTokenLog` in user webhook.	2018-08-31 17:25:56 +08:00
Guo Xiang Tan	ae2f00ee73	DEV: Include the thread in the error message.	2018-08-31 17:14:19 +08:00
Bianca Nenciu	931cffcebe	FEATURE: Let users see their user auth tokens. (#6313 )	2018-08-31 10:18:06 +02:00
Sam	b3aab1770f	FIX: set old last modified date for invalid avatars In some cases Akami was holding tight to these invalid avatars, to avoid this happening we explain the avatar image is ancient then when a new upload is added it automatically is older than this.	2018-08-31 17:07:31 +10:00
Sam	1866a8e8da	correct invalid spec	2018-08-31 15:06:30 +10:00
Sam	e1975e293f	FIX: when uploads are destroyed clear up avatar refs in user table This also auto corrects twice daily when we ensure consistency	2018-08-31 14:46:42 +10:00
Sam	9b7cab589a	FIX: revert diacritic stripping See more details in test case and at: https://meta.discourse.org/t/discourse-should-ignore-if-a-character-is-accented-when-doing-a-search/90198/16?u=sam	2018-08-31 11:46:55 +10:00
Guo Xiang Tan	81b99efc68	DEV: Raise an error if thread doesn't return within expected time.	2018-08-31 09:26:28 +08:00
Vinoth Kannan	297e8aaf2e	FIX: Escape regex pattern variable before using it	2018-08-31 03:02:24 +05:30
Blake Erickson	c6f339a0b5	format json better with spaces in my test	2018-08-30 14:39:40 -06:00
Blake Erickson	ae532f8548	FIX: return 422 for an invalid group name on category create	2018-08-30 14:28:55 -06:00
David Taylor	103509b9dd	SECURITY: Prevent users from modifying custom fields	2018-08-30 12:59:36 +01:00
Osama Sayegh	9efbf2c49f	FIX: changing component settings should trigger refresh for parent theme CSS (#6340 )	2018-08-30 20:53:03 +10:00
Guo Xiang Tan	9c7e029d01	DEV: Attempt to stablize multisite tests.	2018-08-30 17:31:17 +08:00
David Taylor	f0abb4d09a	FIX: Allow user actions to be saved even if the post has nil user This issue made it impossible to delete users if they had flagged a post with nil user	2018-08-30 01:03:32 +01:00
Sam	e6970151a6	FEATURE: allow specifying locale via SSO Use: locale locale_force_update To force user locale on users where SiteSetting.allow_user_locale is enabled Note: If an invalid locale is specified no action will occur	2018-08-30 09:58:03 +10:00
Bianca Nenciu	72ffabf619	UX: Improve email testing admin tool. (#6308 )	2018-08-29 23:14:16 +02:00
Gerhard Schlager	b2cf725700	FIX: Don't try to send invite email when invite was deleted	2018-08-29 12:43:12 +02:00
Sam	44cf3cf975	FIX: queue heartbeats in readonly modes If sidekiq is paused or Discourse is in readonly continue to queue heartbeats If we do not do that then a master process can end up reaping sidekiq workers and causing various badness This also impacts restore which can do weird stuff TM in cases like this	2018-08-29 12:36:59 +10:00
Sam	740308675b	FEATURE: erode bounce score every time an email is sent Introduces a hidden setting (default is 0.1) that erodes bounce score every time we send an email. This means that erratic failures are less painful cause system auto corrects	2018-08-28 17:02:12 +10:00
Kyle Zhao	e25a6e085e	FIX: drop title updates through RSS feeds can create an update loop	2018-08-28 16:25:04 +10:00
Sam	9ab1fb7dfc	FEATURE: correctly store width and height on uploads Previously we used width and height for thumbnails, new code ensures 1. We auto correct width and height 2. We added extra columns for thumbnail_width and height, this is determined by actual upload and no longer passed in as a side effect 3. Optimized Image now stores filesize which can be used for analysis, decisions Also - fixes Android image manifest as a side effect - fixes issue where a thumbnail generated that is smaller than the upload is no longer used	2018-08-28 12:59:22 +10:00
Davide Porrovecchio	1826626272	FEATURE: Add Content-Type header to CORS - add Content-Type to Access-Control-Allow-Headers - update test accordingly	2018-08-28 11:19:38 +10:00
Neil Lalonde	ebe7835316	FIX: links in rss feeds are sometimes wrong on subfolder installs	2018-08-27 18:05:15 -04:00
Bianca Nenciu	b6963b8ffb	FIX: Ignore OneBox blacklisted domains.	2018-08-27 20:40:55 +02:00
Sam	dc17ae3b2f	correct specs	2018-08-27 14:50:56 +10:00
Sam	4205c528d0	FEATURE: hide enable_personal_email_messages and min_trust_to_send_email_messages These site settings are very hard to explain and only applicable for very specific Discourse setups. If an admin "enables staged users" which is used in support scenarios then all staff can send "messages" directly to an "email". The setting allows you to extend this to TL4 or any trust level. Actual use case would be a support type setup with restricted staff. It is quite rare so hiding this for now and re-evaluate keeping the setting in 2019	2018-08-27 11:38:22 +10:00
Raul Tambre	2271918be2	FEATURE: Use S3 dualstack endpoints Allows S3 without a CDN to serve images from dualstack domains that also support ipv6	2018-08-27 11:22:46 +10:00
Maja Komel	020eba4623	FIX: find tags with non-latin names (#6312 )	2018-08-27 11:05:28 +10:00
Kris	faf09bb8c8	Replacing default brown category color	2018-08-24 14:18:14 -04:00
Joffrey JAFFEUX	82dcc5cbfa	FEATURE: makes reports loadable in bulk (#6309 )	2018-08-24 15:28:01 +02:00
James Kiesel	a4001c1ea0	FEATURE: Pop revise modal on post edited notification (#6287 ) * Add revision number to notification url * Pop modal on route change * Add semicolon * Ensure modal pops even when navigating within a topic * Ensure modal pops when visiting from other page * Fix eslint errors * Fix prettier errors * Add callback for notification item click * Remove stray revisionUrl function * Rename to afterRouteComplete	2018-08-24 09:13:07 -04:00
Guo Xiang Tan	932195d828	DEV: Update test case for `TopicEmbed`.	2018-08-24 09:42:12 +08:00
Guo Xiang Tan	1ba24496ab	Merge pull request #6261 from xrav3nz/fix/topic-embed-import-updates FIX: update TopicEmbed's title and user correctly	2018-08-24 09:32:03 +08:00
Osama Sayegh	e0cc29d658	FEATURE: themes and components split * FEATURE: themes and components split * two seperate methods to switch theme type * use strict equality operator	2018-08-24 11:30:00 +10:00
Guo Xiang Tan	4a552fb967	Merge pull request #6303 from nbianca/user_serializer_spec Add spec for UserSerializer and UserApiKey.	2018-08-24 08:16:11 +08:00
Sam	ac11f8df52	correct regression searching with diacritics	2018-08-24 10:00:51 +10:00
Sam	29315b73c2	FIX: improve last_modified date returned for avatars instead of hard coding a date: 1. For optimized images use the upload date when on s3 2. For not-found use 10 minutes ago to match the expiry	2018-08-24 09:36:11 +10:00
Régis Hanol	bc7b530b0a	FIX: remove diacritics instead of transliterating	2018-08-24 00:38:44 +02:00
Bianca Nenciu	ff441bc4ca	Add spec for UserSerializer and UserApiKey.	2018-08-23 19:01:02 +02:00
Régis Hanol	2fcf2b899e	FIX: remove diacritics when tokenizing html for search	2018-08-23 17:13:52 +02:00
Arpit Jalan	7a91df3248	Merge pull request #6290 from techAPJ/latest-full-name UX: show full name on /latest page	2018-08-23 17:34:54 +05:30
Arpit Jalan	1a7cd6648b	UX: show full name on /latest page	2018-08-23 14:41:06 +05:30
Guo Xiang Tan	dd810b8b05	Merge pull request #6304 from tgxworld/create_functions_in_different_schema FIX: Create `BaseDropper` functions in a different schema.	2018-08-23 15:01:41 +08:00
Guo Xiang Tan	212ee15804	FIX: Create `BaseDropper` functions in a different schema. https://meta.discourse.org/t/error-when-restore-db-backup/93145/25?u=tgxworld	2018-08-23 12:52:21 +08:00
Osama Sayegh	2711f173dc	FIX: don't allow inviting more than `max_allowed_message_recipients` * FIX: don't allow inviting more than `max_allowed_message_recipients` setting allows * add specs for guardian * user preferences for auto track shouldn't be applicable to PMs (it auto watches on visit) Execlude PMs from "Automatically track topics I enter..." and "When I post in a topic, set that topic to..." user preferences * groups take only 1 slot in PM * just return if topic is a PM	2018-08-23 14:36:49 +10:00
Guo Xiang Tan	36a7028f19	FEATURE: Clean up `PostReplyKey` records. * Default retention of 90 days.	2018-08-23 10:40:02 +08:00
Régis Hanol	f01169d6ff	FIX: don't send email when the post was deleted	2018-08-22 13:13:58 +02:00
James Kiesel	cdea969c6a	FEATURE: Make initial admins TL1 * Match register controller TL to rake admin:create * Don't promote if trust_level > 1	2018-08-22 15:45:24 +10:00
Sam	272de95175	FIX: client duplicate registration should be cleaned up If for any reason we are unable to correct client id on a user api key invalidate old keys for client/user	2018-08-22 12:56:49 +10:00
Sam	5d96809abd	FIX: improve support for subfolder S3 CDN	2018-08-22 12:31:13 +10:00
Sam	f5142861e5	Revert "Revert "FIX: upload URLs from S3 on subfolder installs"" This reverts commit `26c96e97e5`. We have no choice but to run this code	2018-08-22 11:31:33 +10:00
Sam	26c96e97e5	Revert "FIX: upload URLs from S3 on subfolder installs" This reverts commit `357df2ff4f`.	2018-08-22 10:51:40 +10:00
Neil Lalonde	357df2ff4f	FIX: upload URLs from S3 on subfolder installs	2018-08-21 14:58:55 -04:00
Gerhard Schlager	17dc8f2490	UX: Wizard resends activation email when user exists	2018-08-21 19:13:41 +02:00
Régis Hanol	d1607a387a	FIX: only allow printable characters in uploads filename	2018-08-21 18:11:01 +02:00
Régis Hanol	3e436e2daf	FIX: doesn't translate group permission keys	2018-08-21 12:56:56 +02:00
Kyle Zhao	baf413d527	FIX: update TopicEmbed's title and user correctly	2018-08-21 18:31:01 +08:00
Guo Xiang Tan	7dcc69aef4	DEV: Refactor test to not call private method.	2018-08-21 14:29:58 +08:00
Guo Xiang Tan	48f499b324	DEV: Refactor some mail receiver related specs.	2018-08-21 14:00:45 +08:00
Guo Xiang Tan	d104de2a09	Remove line that is no longer required.	2018-08-21 11:48:58 +08:00
Guo Xiang Tan	8bdf14834b	PERF: Restrict number of skipped email log for `Jobs::UserEmail`.	2018-08-21 11:14:43 +08:00
Guo Xiang Tan	2c70d3f443	Take 2 on `ba6f11c521`.	2018-08-21 10:06:36 +08:00
Sam	2d96160192	FEATURE: improve API error reporting for invalid records	2018-08-21 11:54:34 +10:00
Bianca Nenciu	860c1c3dcd	FEATURE: Automatically expire keys if not used for a configurable amount of time. (#6264 )	2018-08-20 17:36:14 +02:00
Gerhard Schlager	14af90df5b	UX: Stop putting usernames in edit reason when changing post owner	2018-08-20 12:28:04 +02:00
Guo Xiang Tan	b4f92a05b3	FIX: Load more on groups page does not account for params. https://meta.discourse.org/t/cant-scroll-through-list-of-users-groups-if-more-than-one-page/92259	2018-08-20 17:08:50 +08:00
Sam	f5fe58384f	correct regression around file renaming	2018-08-20 16:08:05 +10:00
Sam	ce4b12ae59	FIX: if we have not target available do not redirect	2018-08-20 13:10:59 +10:00
Sam	d7b1919ead	correct specs	2018-08-20 12:46:14 +10:00
Sam	8b5e42ea16	FIX: always test and coerce to image on upload In the past the filename of the origin was used as the source for the extension of the file when optimizing on upload. We now use the actual calculated extension based on upload data.	2018-08-20 12:18:59 +10:00
Bianca Nenciu	975a72ab7a	FEATURE: Make links indexable. (#6285 )	2018-08-20 10:39:19 +10:00
Robin Ward	a83f662492	FIX: Allow silenced users to like / bookmark, just not flag.	2018-08-17 11:06:18 -04:00
Guo Xiang Tan	010fe479cb	Fix linting.	2018-08-17 17:34:25 +08:00
Guo Xiang Tan	16c0ebe8a8	Fix the build.	2018-08-17 16:53:07 +08:00
Guo Xiang Tan	a26ef7738f	FIX: `FileHelper#download` should return nil if max size is exceeded.	2018-08-17 16:19:59 +08:00
Guo Xiang Tan	4b7c5ba162	Update `UploadCreator` specs to include cropping code path.	2018-08-17 15:22:12 +08:00
Guo Xiang Tan	fae8757cd4	FIX: `Guardian#post_can_act?` shouldn't raise an error if user of post has been deleted.	2018-08-17 15:11:30 +08:00
Guo Xiang Tan	a9e502936f	FIX: Converting PNG to JPEG does not set the correct extension.	2018-08-17 13:09:48 +08:00
Régis Hanol	93201d8dbe	FIX: don't trigger 'flag_reviewed' when no flags were reviewed	2018-08-16 18:11:29 +02:00
Joffrey JAFFEUX	10a3499d68	uses emoji versions for specs (#6276 )	2018-08-16 13:45:30 +02:00
Sam	f62073a22a	correct regression uploading images	2018-08-16 18:49:08 +10:00
Gerhard Schlager	937ab3f213	FIX: Validation of min_posts and max_posts didn't work	2018-08-16 10:36:53 +02:00
Sam	796164b58c	FIX: automatically correct bad avatars on access Also start relying on upload extension for optimized images	2018-08-16 16:32:56 +10:00
Sam	243fc9d0f9	FIX: refreshing auto groups when min_username_length is long	2018-08-15 16:59:56 +10:00
Sam	38c10a3dc2	correct the validator	2018-08-15 14:56:24 +10:00
Sam	91e0a77a60	FEATURE: silenced users should not be allowed to edit posts	2018-08-15 14:29:36 +10:00
Misaka 0x4e21	d4fd19d49a	UX: Replace Google search with Discourse search on not found page * UX: Replace Google search with Discourse search on not found page. * FIX: Update application_controller_spec.rb.	2018-08-15 11:53:04 +10:00
Sam	06f82a7d72	correct exception handling, always do to_i in array	2018-08-15 11:31:42 +10:00
Sam	bc47148d35	add validation to exclude_category_ids	2018-08-15 09:53:28 +10:00
Régis Hanol	12bab65167	FIX: going from /categories to /latest on mobile might break infinite scrolling	2018-08-15 01:22:03 +02:00
Gerhard Schlager	ba0e322fd0	FIX: Validation of topic params broke discourse-assign	2018-08-14 18:45:46 +02:00
Robin Ward	87fa26b6c8	FIX: Silenced users shouldn't be able to act on posts	2018-08-14 11:43:39 -04:00
Gerhard Schlager	c358421ca5	FIX: Bulk updating category failed when topic title was too short	2018-08-14 16:37:52 +02:00
Gerhard Schlager	216f4c99b0	Correct flaky spec	2018-08-14 12:43:57 +02:00
Régis Hanol	de92913bf4	FIX: store the topic links using the cooked upload url	2018-08-14 12:23:32 +02:00
Sam	ad5f502332	FIX: add a basic validator for topic params This cuts down on log noise when people try out sql injection	2018-08-14 17:01:04 +10:00
Guo Xiang Tan	664186a2a4	DEV: Remove stub to make test more reliable.	2018-08-13 14:48:46 +08:00
Guo Xiang Tan	d10c9d7d75	FIX: Missing extensions for non-image uploads due to `2b57239389`.	2018-08-13 10:58:55 +08:00
Gerhard Schlager	b73950692b	FIX: Parsing non-existent feed should not fail	2018-08-10 18:37:14 +02:00
Osama Sayegh	865cb3feb9	FIX: allow selecting site's default theme from preference	2018-08-10 14:12:02 +03:00
Sam	2b2612d0f5	correct flaky spec after(:all) and before(:all) are to be avoided, state can leak	2018-08-10 16:08:07 +10:00
Simon Cossar	093c3510e6	Rework moderators activity query (#6230 ) * Order rows in query * Don't increment revisions when moderator revises their own post	2018-08-10 10:51:31 +10:00
Gerhard Schlager	b9072e8292	FEATURE: Add "Reset Bump Date" action to topic admin wrench (#6246 )	2018-08-10 10:51:03 +10:00
Misaka 0x4e21	6db623ef6b	UX: Improve category filtering and include subcategories * category_filtering 1. report_top_referred_topics 2. report_top_traffic_sources 3. report_post_edit * category_filtering with subcategory topics 1. report_top_referred_topics 2. report_top_traffic_sources 3. report_post_edit 4. report_posts 5. report_topics 6. report_topics_with_no_response * category_filtering tests (without subcategory topics) 1. report_posts 2. report_topics_with_no_response * subcategory topics tests `in_category_and_subcategories` in `topic_spec.rb` 1. `in_category_and_subcategories` in `topic_spec.rb` 2. topics, posts, flags and topics_with_no_response in `report_spec.rb`	2018-08-10 10:50:05 +10:00
Gerhard Schlager	ef4b9f98c1	FEATURE: Allow admins to reply without topic bump	2018-08-10 10:48:30 +10:00
Simon Cossar	3cd4dc0f5f	Allow users with group_locked_trust_level to be promoted to tl3 (#6249 )	2018-08-10 10:42:23 +10:00
Osama Sayegh	0d5ebcb21d	fix flaky specs (#6255 )	2018-08-10 10:38:36 +10:00
Neil Lalonde	d77dccc636	FIX: user-deleted posts with deferred flags can be destroyed	2018-08-09 14:54:31 -04:00
Neil Lalonde	2c4d7225d8	FIX: permalink redirects with subfolder	2018-08-09 11:05:27 -04:00
Sam	ed4c0f256e	FIX: check permalinks for deleted topics - allow to specify 410 vs 404 in Discourse::NotFound exception - remove unused `permalink_redirect_or_not_found` which - handle JS side links to topics via Discourse-Xhr-Redirect mechanism	2018-08-09 15:05:12 +10:00
Guo Xiang Tan	ba6f11c521	PERF: Only log the first skipped email when user exceeds daily limit. https://meta.discourse.org/t/cleaning-up-e-mail-logs/39132	2018-08-08 16:25:00 +08:00
Guo Xiang Tan	1ea23b1eae	FIX: Wrong order for `S3Helper#copy_file`.	2018-08-08 15:58:54 +08:00
Sam	a35f2984e9	FIX: support Arrays with Marshal dump in distributed cache Theme cache uses arrays here	2018-08-08 16:44:56 +10:00
Osama Sayegh	0b7ed8ffaf	FEATURE: backend support for user-selectable components * FEATURE: backend support for user-selectable components * fix problems with previewing default theme * rename preview_key => preview_theme_id * omit default theme from child themes dropdown and try a different fix * cache & freeze stylesheets arrays	2018-08-08 14:46:34 +10:00
Guo Xiang Tan	aafff740d2	Add `FileStore::S3Store#copy_file`.	2018-08-08 11:30:34 +08:00
Neil Lalonde	4e6e4a83df	FIX: subfolder digest emails have incorrect URLs	2018-08-07 16:38:17 -04:00
David Taylor	aa9a9a5a72	FIX: Include auth_providers for anonymous users when login_required	2018-08-07 09:24:16 +01:00
Guo Xiang Tan	2b57239389	FIX: Upload's content is the only source of truth for the file type.	2018-08-07 13:15:00 +08:00
Guo Xiang Tan	d1860a4f7d	DEV: Fix test to use an actual PNG instead of a GIF.	2018-08-07 12:02:35 +08:00
Sam	6797395bd0	FIX: staff should be allowed to agree and keep post	2018-08-07 10:05:43 +10:00
David Taylor	812add18bd	REFACTOR: Serve auth provider information in the site serializer. At the moment core providers are hard-coded in Javascript, and plugin providers get added to the JS payload at compile time. This refactor means that we only ship enabled providers to the client.	2018-08-06 09:25:48 +01:00
Guo Xiang Tan	4e11811321	FIX: `UserAvatar#update_gravatar!` does not update `User#uploaded_avatar`. https://meta.discourse.org/t/missing-user-profile-pictures/93844/4	2018-08-06 13:29:44 +08:00
Osama Sayegh	18b396ad56	FEATURE: add link to see new commits when updates are available for themes (#6233 ) * FEATURE: add link to see new commits when updates are available for themes * shorten regexp	2018-08-06 15:29:15 +10:00
Régis Hanol	bf4d98e89d	FIX: always store topic links using the upload url	2018-08-04 01:29:32 +02:00
Joffrey JAFFEUX	066010db7d	FEATURE: introduces list/compact_list components	2018-08-03 16:41:37 -04:00
Régis Hanol	ac2513b0f2	FEATURE: automatic PM when a user's email is revoked	2018-08-03 16:39:22 +02:00
Sam	280c318c49	FEATURE: allow ruby tags in Markdown	2018-08-03 11:47:36 +10:00
Osama Sayegh	880462a41c	FEATURE: display out of date themes on admin dashboard * FEATURE: disaply out of date themes on admin dashboard * Update copy	2018-08-03 09:53:48 +10:00
Jeff Atwood	c81bad3232	Merge pull request #6232 from OsamaSayegh/message-email-short-reply UX: better rejection message when reply via email is too short	2018-08-02 14:25:04 -07:00
OsamaSayegh	a157dfd418	UX: better rejection message when reply via email is too short	2018-08-02 22:43:53 +03:00
Sam	0b3d51a8bc	FEATURE: whitelist lang attribute	2018-08-02 16:53:08 +10:00
Penar Musaraj	4a872823e7	Improvements to user drafts (#6226 ) * drafts in user profile: only show to user herself (not to admins), use avatar replying to (instead of topic OP), add keyboard shortcut for drafts, simplify display labels * use JSON when testing Draft.stream	2018-08-02 07:41:27 +10:00
Dan Ungureanu	1a0ffc5ace	FEATURE: Added method to get multiple values at once from PluginStore. (#6225 )	2018-08-01 18:42:40 +02:00
Gerhard Schlager	f4ca105498	FIX: Moving posts to existing topic didn't update topic metadata	2018-08-01 18:05:43 +02:00
Neil Lalonde	b829452c75	Merge pull request #6209 from discourse/mini_scheduler REFACTOR: extract scheduler to the mini_scheduler gem	2018-08-01 10:28:24 -04:00
Joffrey JAFFEUX	499ed469b0	FIX: disk_space refresh is now on demand	2018-08-01 10:06:20 -04:00
Gerhard Schlager	a115aae45f	Use rchardet instead of charlock_holmes gem	2018-08-01 10:41:20 +02:00
Gerhard Schlager	5d421fb946	FIX: Try respecting charset in HTTP header of RSS feed	2018-08-01 10:41:20 +02:00
Gerhard Schlager	ff942ed2f3	FIX: Try detecting encoding of RSS feed	2018-08-01 10:41:20 +02:00
Penar Musaraj	1f45215537	FEATURE: Drafts view in user profile * add drafts.json endpoint, user profile tab with drafts stream * improve drafts stream display in user profile * truncate excerpts in drafts list, better handling for resume draft action * improve draft stream SQL query, add rspec tests * if composer is open, quietly close it when user opens another draft from drafts stream; load PM draft only when user is in /u/username/messages (instead of /u/username) * cleanup * linting fixes * apply prettier styling to modified files * add client tests for drafts, includes a fixture for drafts.json * improvements to code following review * refresh drafts route when user deletes a draft open in the composer while being in the drafts route; minor prettier scss fix * added more spec tests, deleted an acceptance test for removing drafts that was too finicky, formatting and code style fixes, added appEvent for draft:destroyed * prettier, eslint fixes * use "username_lower" from users table, added error handling for rejected promises * adds guardian spec for can_see_drafts, adds improvements following code review * move DraftsController spec to its own file * fix failing drafts qunit test, use getOwner instead of deprecated this.container * limit test fixture for draft.json testing to new_topic request only	2018-08-01 16:34:54 +10:00
Joffrey JAFFEUX	849f0d00f6	FEATURE: adds revision_count to moderators_activity (#6218 ) Co-Authored-By: Simon Cossar <scossar@users.noreply.github.com>	2018-07-31 23:40:45 -04:00
Guo Xiang Tan	919e8db686	FIX: Check for group name availability should skip reserved usernames.	2018-08-01 11:09:33 +08:00
Joffrey JAFFEUX	2b2a506a7b	FIX: makes dashboard more resilient to errors (#6217 ) This commit is an attempt to limit cases where the dashboard will generate a full exception page and also make it easier to track the error.	2018-07-31 21:23:28 -04:00
Joffrey JAFFEUX	8299fe0947	fix report spec (#6214 )	2018-07-31 18:15:14 -04:00
Vinoth Kannan	6aee22b88f	FIX: Onebox images are not downloaded locally without css class	2018-08-01 02:51:02 +05:30
Neil Lalonde	4ad7ce70ce	REFACTOR: extract scheduler to the mini_scheduler gem	2018-07-31 17:12:55 -04:00
Arpit Jalan	afe3b00c0f	FIX: use hidden setting for max export file size	2018-07-31 11:25:28 +05:30
Vinoth Kannan	50df2d7241	FIX: Should not include regular categories in top_category_ids array	2018-07-30 16:06:36 +05:30
Guo Xiang Tan	87537b679c	Drop `reply_key`, `skipped` and `skipped_reason` from `email_logs`.	2018-07-30 11:39:28 +08:00
Guo Xiang Tan	b94633e844	FIX: `FileHelper` should prioritize response content-type. Request to a URL with `.png` extension may return a jpg instead causing us to attach the wrong extension to an upload.	2018-07-30 10:54:36 +08:00
David Taylor	5f1fd0019b	FEATURE: Allow revoke and connect for GitHub logins	2018-07-27 17:18:53 +01:00
David Taylor	6296f63804	FEATURE: Revoke and connect for Yahoo logins	2018-07-27 16:20:47 +01:00
David Taylor	9c72c00206	FEATURE: Revoke and reconnect for Twitter logins	2018-07-27 12:28:51 +01:00
Vinoth Kannan	dac29b5ebc	UX: Display only top categories in hamburger menu (#6146 )	2018-07-27 12:11:07 +05:30
Guo Xiang Tan	6f9a91cbd5	Merge pull request #6175 from vinothkannans/post_approval_webhook FEATURE: Webhook for post approval events	2018-07-27 10:50:49 +08:00
Joffrey JAFFEUX	313cd9940d	starts refactoring report spec	2018-07-26 19:24:18 -04:00
Neil Lalonde	1708ff1808	UX: add a route /rules as an alias for /faq and /guidelines	2018-07-26 15:38:08 -04:00
Neil Lalonde	135c803f49	FIX: don't send PM if flagged post is deleted but flags were deferred or cleared	2018-07-26 15:12:31 -04:00
Vinoth Kannan	af5b88f8e2	Rename approval web hook event type to queued post	2018-07-26 10:29:38 +05:30
Guo Xiang Tan	f8b367cc9c	Fix the build.	2018-07-26 10:17:51 +08:00
Guo Xiang Tan	30242972d3	Add spec for `4bf3bf6786`.	2018-07-26 09:16:14 +08:00
Régis Hanol	4bf3bf6786	SECURITY: force IM decoder based on file extension	2018-07-25 22:00:04 +02:00
Vinoth Kannan	5059dad8f0	FEATURE: Webhook for post approval events	2018-07-25 23:43:19 +05:30
David Taylor	f38942d121	FIX: Destroy session between omniauth callbacks controller tests	2018-07-25 16:33:42 +01:00
Joffrey JAFFEUX	796639a797	FIX: makes disk_space computation more resilient (#6172 )	2018-07-25 11:04:01 -04:00
David Taylor	fa399ce1c5	FEATURE: Add revoke and reconnect functionality for google logins	2018-07-25 16:03:14 +01:00
Gerhard Schlager	84d14fd8a0	FIX: Don't rely on setting data type read from database	2018-07-25 11:40:59 +02:00
Neil Lalonde	417bcf7d2e	add checks for staff and system user before sending flags_agreed_and_post_deleted message	2018-07-24 19:25:11 -04:00
Neil Lalonde	fe39cdc90a	FEATURE: when a post is deleted because a moderator agreed with flags, send a message to the post author	2018-07-24 17:17:56 -04:00
Robin Ward	7058205f70	FIX: Broken specs	2018-07-24 12:00:34 -04:00
Gerhard Schlager	1ac643d71c	FIX: Email template for "Queued Posts Reminder" was not found	2018-07-24 17:26:52 +02:00
Robin Ward	236243f38a	SECURITY: Consider `0.0.0.0` a private IP	2018-07-24 11:16:27 -04:00
Joffrey JAFFEUX	7a3c541077	UX: Preview multiple color schemes in wizard (#6151 ) It was a dropdown to provide choices of color schemes, and only one scheme could be shown. With this commit, multiple color scheme previews can be displayed on one page at the same time, making admins choose color schemes more easily. Theme preview windows are shrinked. Imported default color schemes. Co-Authored-By: Misaka 0x4e21 <misaka4e21@gmail.com>	2018-07-24 09:00:20 -04:00
David Taylor	abddb48260	Rubocop fix	2018-07-24 10:49:20 +01:00
Guo Xiang Tan	fa19d3a53c	Merge pull request #6108 from discourse/transaction-sidekiq-fix Fix notifications for topics moved between categories	2018-07-24 17:44:03 +08:00
David Taylor	20a21b1240	Move into MiniSQLMultisiteConnection, and add test for rollback	2018-07-24 09:41:55 +01:00
Guo Xiang Tan	7a2bf8e368	Fix invalid query syntax when `CategoryCustomField#value` is blank.	2018-07-24 14:48:27 +08:00
Guo Xiang Tan	fad9c2b971	PERF: Move `EmailLog#reply_key` into new `post_reply_keys` table.	2018-07-24 13:51:53 +08:00
Guo Xiang Tan	ae8b0a517f	PERF: Split skipped email logs into a seperate table.	2018-07-24 13:14:37 +08:00
Davide Porrovecchio	dd9d815178	FIX: Add User Api Key headers to CORS - add User-Api-Key and User-Api-Client-Id to Access-Control-Allow-Headers - update test	2018-07-24 10:28:23 +10:00
Neil Lalonde	f4b5eccad3	FIX: categories page crawler view had incorrect URLs	2018-07-23 14:54:41 -04:00
David Taylor	eda1462b3b	FEATURE: List, revoke and reconnect associated accounts. Phase 1 (#6099 ) Listing connections is supported for all built-in auth providers. Revoke and reconnect is currently only implemented for Facebook.	2018-07-23 16:51:57 +01:00
Joffrey JAFFEUX	32062864d3	FIX: removes system from user to user report (#6144 )	2018-07-23 10:33:12 -04:00
David Taylor	d7b5a374c2	Fix indentation	2018-07-23 10:42:15 +01:00
Vinoth Kannan	84ab825e41	FEATURE: Webhook for user destroyed event (#6124 )	2018-07-23 13:19:49 +05:30
Vinoth Kannan	f8e9190617	FEATURE: Retry web hook when it is failed	2018-07-23 10:12:04 +08:00
Joffrey JAFFEUX	06323f9c89	FIX: takes old dashboard out of caching job	2018-07-21 12:42:03 -04:00
Maja Komel	368d4e8eae	FIX: notify staff about whispers in watched categories (#6128 )	2018-07-21 11:20:21 +02:00
Guo Xiang Tan	b4ef7dfe9a	DEV: Make spec less brittle.	2018-07-21 09:13:11 +08:00
Guo Xiang Tan	7cf6c2825e	Merge pull request #6106 from OsamaSayegh/watch-when-splitting FIX: topic owner should watch the new topic when moving posts to a new topic	2018-07-20 15:18:59 +08:00
OsamaSayegh	69450750d1	shorter method name and better specs	2018-07-20 10:13:27 +03:00
Joffrey JAFFEUX	1a78e12f4e	FEATURE: part 2 of dashboard improvements - moderation tab - sorting/pagination - improved third party reports support - trending charts - better perf - many fixes - refactoring - new reports Co-Authored-By: Simon Cossar <scossar@users.noreply.github.com>	2018-07-19 14:33:11 -04:00
Joffrey JAFFEUX	a2281fbb19	FEATURE: allows to jump to a date in a topic	2018-07-19 16:00:13 +02:00
Maja Komel	a9ebad3f6c	FIX: do not add a moderator post when post is flagged via direct message (#6100 )	2018-07-18 23:18:14 +02:00
David Taylor	32db976156	FIX: Stop race condition when topic notification jobs are scheduled during a database transaction This was not picked up by tests because scheduled jobs are run immediately and in the current thread (and therefore the current database transaction). This particular case sometimes occurs inside multiple nested transactions, so simply moving the offending line outside of the transaction is not enough. Implemented TransactionHelper, which allows us to use `TransactionHelper.after_commit` to define code to be run after the current transaction has been committed.	2018-07-18 22:04:43 +01:00
Neil Lalonde	afc94ac9e4	FEATURE: add a Top Categories section to the user summary page, showing the categories in which a user has the most activity	2018-07-18 16:39:16 -04:00
David Taylor	2dc3a50dac	FIX: Do not update `last seen` time for suspended users	2018-07-18 16:04:57 +01:00
OsamaSayegh	547b571d84	FIX: topic owner should watch the new topic when moving posts to a new topic	2018-07-18 15:23:32 +03:00
Régis Hanol	6d6e026e3c	FEATURE: selectable avatars	2018-07-18 12:57:43 +02:00
Guo Xiang Tan	b068a8a771	Fix the build.	2018-07-18 14:03:27 +08:00
Arpit Jalan	7da22e395b	FIX: do not show links with 0 click on topic map	2018-07-18 10:50:01 +05:30
OsamaSayegh	281538ae61	FIX: theme JS should only run when needed global objects exist (#6098 )	2018-07-18 15:13:47 +10:00
Sam	0c159f17b7	skip failing spec	2018-07-18 14:43:06 +10:00
Sam	379384ae1e	FIX: never block /srv/status which is used for health checks This route is also very cheap so blocking it is not required It is still rate limited and so on elsewhere	2018-07-18 12:37:01 +10:00
Guo Xiang Tan	3874d40910	Prepare to drop `EmailLog#topic_id`.	2018-07-18 10:22:24 +08:00
Sam	02628883d2	FEATURE: adjust autobump system - We spread out bumping through the day, if you are bumping 4 topics then a topic will be bumped every 6 hours - We add a small, bumping action at the bottom of the post to denote a topic got bumped	2018-07-18 10:17:33 +10:00
Guo Xiang Tan	202b839208	Fix the build.	2018-07-17 17:20:57 +08:00
Guo Xiang Tan	d839a42bf9	Skip imagemagick tests on Travis.	2018-07-17 17:11:05 +08:00
Guo Xiang Tan	3553375dd2	PERF: Store `EmailLog#reply_key` as `uuid` data type.	2018-07-17 17:05:42 +08:00
Guo Xiang Tan	1d74ccaaf8	Add compatibility for ImageMagick7.	2018-07-17 15:50:58 +08:00
Sam	91266cdabb	correct auto bump topic logic	2018-07-17 09:33:33 +10:00
Guo Xiang Tan	c0c263405a	PERF: Store `EmailLog#bounce_key` as `uuid` data type. (#6093 ) PERF: Store `EmailLog#bounce_key` as `uuid` data type.	2018-07-16 20:05:54 +08:00
Sam	ac0053f491	FEATURE: navigate to first post and auto bump category settings ### navigate_to_first_post_after_read setting for categories When enabled on categories logged on users will return to OP after reading the entire category. (useful for documentation categories) ### num_auto_bump_daily Set a number of topics that will automatically bump daily on a category. - Every 15 minutes we will check if any category has this setting - Categories with the setting are shuffled - We exclude pinned, closed, category description and archived topics - Maximum of 1 topic for the list of categories is bumped till limit reached per category - We always try to bump oldest first - Limit is elastic using a RateLimiter that ensures that we only bump N per day Also some minor organisation on category settings Froze strings on category.rb	2018-07-16 18:10:35 +10:00
Leo McArdle	21ebb1cd54	FEATURE: Secondary emails support.	2018-07-16 11:09:49 +08:00
Arpit Jalan	b1082924b9	FIX: do not validate topic deletions	2018-07-13 22:53:36 +05:30
Guo Xiang Tan	711371e8c8	FIX: Select+below will ask server for post ids on megatopics.	2018-07-13 15:10:39 +08:00
Guo Xiang Tan	c722b07057	FIX: `/t/:topic_id/last` route did not return any posts.	2018-07-13 14:26:10 +08:00
Kyle Zhao	2901691e87	FEATURE: per-category approval settings (#5778 ) - disallow moving topics to a category that requires topic approval	2018-07-13 12:51:08 +10:00
Guo Xiang Tan	79ba418edd	DEV: Don't join on a thread forever.	2018-07-12 15:46:07 +08:00
Guo Xiang Tan	258e9e35ca	PERF: Make mega topics work without a stream. There are tradeoffs that we took here. For the complete story see https://meta.discourse.org/t/performance-improvements-on-long-topics/30187/27?u=tgxworld.	2018-07-12 12:46:12 +08:00
OsamaSayegh	decf1f27cf	FEATURE: Groundwork for user-selectable theme components * Phase 0 for user-selectable theme components - Drops `key` column from the `themes` table - Drops `theme_key` column from the `user_options` table - Adds `theme_ids` (array of ints default []) column to the `user_options` table and migrates data from `theme_key` to the new column. - Removes the `default_theme_key` site setting and adds `default_theme_id` instead. - Replaces `theme_key` cookie with a new one called `theme_ids` - no longer need Theme.settings_for_client	2018-07-12 14:18:21 +10:00
Maja Komel	0942e2c795	allow adding tags as a custom subject format for emails (#5846 ) allow adding tags as a custom subject format for emails	2018-07-11 12:24:07 +10:00
Guo Xiang Tan	bdf3da8f80	DEV: Raise an error if any test finishes with more than 1 busy AR connection.	2018-07-11 09:54:01 +08:00
OsamaSayegh	f2cc05c6c6	FIX: ignore self-quotes from the same post when saving (#6082 )	2018-07-10 16:17:28 +08:00
Guo Xiang Tan	0a28181c62	Fix the build take 2.	2018-07-10 11:27:03 +08:00
Guo Xiang Tan	4163f9e61e	DEV: Better clean up for PostgreSQL failover test.	2018-07-10 09:53:25 +08:00
Guo Xiang Tan	5374a0e720	Fix the build.	2018-07-10 09:48:57 +08:00
Jordan Seanor	10bc69a62f	FEATURE: Event on topic merge (#6057 )	2018-07-10 09:28:57 +08:00
Guo Xiang Tan	4172e1dd52	FIX: Rename `User#usernames` that clashes with `Group#name`. (#6069 )	2018-07-09 16:54:57 +08:00
Guo Xiang Tan	96aca6d7e6	Remove legacy vote post action code. (#6009 )	2018-07-09 16:54:18 +08:00
David Taylor	9a813210b9	SECURITY: Do not allow authentication with disabled plugin-supplied a… (#6071 ) Do not allow authentication with disabled plugin-supplied auth providers	2018-07-09 14:25:58 +10:00
Guo Xiang Tan	9948f57a99	REFACTOR: Update test to assert for the right objects.	2018-07-09 09:54:14 +08:00
Andrew Schleifer	dba22bbde2	rollback changes This reverts: * 1baba84c438e "fix s3 subfolders harder" * ea5e57938edf "fix test for absolute_base_url change"	2018-07-06 17:16:40 -05:00
Andrew Schleifer	f8b90226cb	fix test for absolute_base_url change	2018-07-06 17:08:18 -05:00
Andrew Schleifer	52e9f49ec1	fix s3 subfolders harder specifically, include the folder in absolute_base_url	2018-07-06 16:28:40 -05:00
Maja Komel	18f5f646b1	FEATURE: allow selecting a tag when moving posts to a new topic (#6072 )	2018-07-06 18:21:32 +02:00
Guo Xiang Tan	7163bf9323	FIX: `Upload.get_from_url` not respective subfolder in s3 bucket names.	2018-07-06 11:37:11 +08:00
Neil Lalonde	211981ef23	add specs for min_trust_to_create_tag set to staff and admin	2018-07-05 11:39:32 -04:00
Patrick Gansterer	28dd7fb562	FEATURE: Create hidden posts for received spam emails (#6010 ) * Add possibility to add hidden posts with PostCreator * FEATURE: Create hidden posts for received spam emails Spamchecker usually have 3 results: HAM, SPAM and PROBABLY_SPAM SPAM gets usually directly rejected and needs no further handling. HAM is good message and usually gets passed unmodified. PROBABLY_SPAM gets an additional header to allow further processing. This change addes processing capabilities for such headers and marks new posts created as hidden when received via email.	2018-07-05 11:07:46 +02:00
Sam	0408e87e00	remove uneeded specs	2018-07-05 15:34:58 +10:00
Sam	b54ba4c952	FIX: mentions broken after adding an <abbr> tag A previous shortcut used was not allowing for <abbr and other tags starting with a If <abbr> appeared anywhere in the text all mentions would fail to link	2018-07-05 09:27:11 +10:00
Régis Hanol	272646c1df	FIX: only show the sequential replies warning for regular posts	2018-07-04 22:51:19 +02:00
Régis Hanol	8a53941fe0	FIX: less aggressive gmail eliding	2018-07-04 20:04:46 +02:00
Neil Lalonde	24882ce1a5	make rubocop happy	2018-07-04 09:42:31 -04:00
Neil Lalonde	f134701c7b	FIX: user topic and post counts can become negative when staff deletes posts in personal messages	2018-07-04 09:31:16 -04:00
Sam	e72fd7ae4e	FIX: move crawler blocking into anon cache This refinement of previous fix moves the crawler blocking into anonymous cache This ensures we never poison the cache incorrectly when blocking crawlers	2018-07-04 11:14:43 +10:00
Sam	7f98ed69cd	FIX: move crawler blocking to app controller We need access to site settings in multisite, we do not have access yet if we attempt to get them in request tracker middleware	2018-07-04 10:30:50 +10:00
Neil Lalonde	e8a6323bea	remove crawler blocking until multisite support	2018-07-03 17:54:45 -04:00
Leo McArdle	c3129444ea	FIX: allow multiple secondary emails	2018-07-03 18:21:35 +08:00
Kasia Bułat	b71cf6d422	FEATURE: Add search not operator for tags.	2018-07-03 15:57:34 +08:00
Jeff Wong	d7f6d37a98	refactor: promotion spec	2018-07-02 16:23:45 -07:00
Guo Xiang Tan	969e79d7c6	PERF: Do not calculate gaps for `TopicViewPostsSerializer`. The client doesn't use the gaps results when loading new posts.	2018-07-02 14:01:50 +08:00
Arpit Jalan	7550e9ff95	FIX: purge unactivated users with a message from non-human users	2018-06-29 13:03:04 +05:30
hellekin	25cfc98b67	Fix 'asscoiated' typo I know that Naming is CRITICAL and that Refactoring only NOT welcome. But since I spotted this (consistent) typo and the change does not affect any functionality -- I checked the presence of "asscoiated" in the code base, I guess the first rule trumps the second one. It also gave me a false pretext to bypass my reluctance to use Google forms and sign de CLA. Typos hurt the eye.	2018-06-29 11:10:05 +10:00
Sam	982df3c17b	FIX: return status 400 for invalid member params previously error returned was a 500 which is not ideal and is logged	2018-06-29 10:15:17 +10:00
Robin Ward	fd7bb8e656	FIX: Scope the `cn` to the subfolder	2018-06-28 11:03:36 -04:00
Sam	db14e10943	SECURITY: category badges should HTML escape names	2018-06-28 18:15:07 +10:00
Maja Komel	ec3e6a81a4	FEATURE: Second factor backup	2018-06-28 10:12:32 +02:00
Guo Xiang Tan	cfa7898c2d	Rename `TopicView#last_read_post_id` to `TopicView#filtered_post_id`.	2018-06-27 12:33:57 +08:00
Guo Xiang Tan	cb69888758	PERF: Don't pluck all the columns just to retrieve a single value.	2018-06-27 11:41:35 +08:00
Arpit Jalan	6bcdc3ba4b	FEATURE: allow author to delete posts irrespective of post_edit_time_limit	2018-06-26 21:43:06 +05:30
Arpit Jalan	7efdccdbc5	FIX: allow staff to remove tags from queued topics	2018-06-26 17:08:40 +05:30
Guo Xiang Tan	49ffc1eb61	Revert "PERF: Send down gaps as the relevant posts load instead of front loading." This reverts commit `4c3352528e`.	2018-06-26 12:54:14 +08:00
Guo Xiang Tan	4c3352528e	PERF: Send down gaps as the relevant posts load instead of front loading.	2018-06-26 12:49:06 +08:00
Guo Xiang Tan	0b6a2e9d1f	Remove force summary mode for megatopics for now. The logic is too hairy and we can't reliably determine when to force summary mode. Work is underway to improve perf for megatopics so this will not be required eventually.	2018-06-26 12:49:06 +08:00
Gerhard Schlager	50192de046	Fix the specs	2018-06-25 16:18:07 +10:00
Ernesto Serrano	93e60a59f5	Added rspec test	2018-06-25 16:18:07 +10:00
David Lee	4644d777bd	FEATURE: add website field to SSO	2018-06-25 16:09:39 +10:00
Jeff Wong	41f76a74f8	FEATURE: send message when a user reaches tl1	2018-06-22 13:20:00 -07:00
Guo Xiang Tan	f69356e628	FIX: Users can't "show all posts" in forced summary topics.	2018-06-22 11:32:45 +08:00
Guo Xiang Tan	bad6a5142c	PERF: Don't include entire post stream when we're loading more posts.	2018-06-22 10:49:03 +08:00
Jeff Wong	bc52bdfa12	Feature: unconditionally consider TL0 users as "first day" users	2018-06-21 10:53:08 -07:00
Guo Xiang Tan	9a7a079f4d	Force summary mode when user enters at the top of megalodoon topics.	2018-06-21 15:18:52 +08:00
Guo Xiang Tan	f7d22bad90	FEATURE: Forced summary mode for megalodon topics. This is mainly done for performance reasons and megalodon topics are usually a byproduct of imports where site setting limits are not respected.	2018-06-21 14:00:20 +08:00
Guo Xiang Tan	6ddd214476	FIX: `Post#summary` returning posts from other topics.	2018-06-21 12:00:54 +08:00
Sam	f66efc601d	FIX: cubot android devices were detected as crawlers	2018-06-21 10:56:46 +10:00
Guo Xiang Tan	0365806b93	FIX: Properly display error when post action fails to create.	2018-06-20 21:20:23 +08:00
Guo Xiang Tan	ff5fc3cb08	Use a fixed limit for mega topic posts count.	2018-06-20 16:58:52 +08:00
Guo Xiang Tan	9c925a66ff	PERF: Don't display days ago on timeline for megatopics. Analysis using `pg_stat_statements` showed this query to be eating up a significant portion of CPU.	2018-06-20 16:25:54 +08:00
Sam	44091f20c6	DEV: allow for method deprecation using Discourse.deprecate New method deprecator will ensure one log message an hour happens for all deprecated method calls per call site Also removes unused monkey patches to ActiveRecord::Base	2018-06-20 17:53:49 +10:00
Sam	cb824a6b33	DEV: remove all calls to SqlBuilder use DB.build instead This is part of the migration to mini_sql, SqlBuilder.new is being deprecated and replaced with DB.build	2018-06-20 17:53:49 +10:00
Guo Xiang Tan	806f0ca19d	FIX: URL with params for svg images should not be light boxed.	2018-06-20 10:47:14 +08:00
riking	7f37ee9152	SearchLog: fix specs	2018-06-20 10:44:11 +10:00
Sam	94124ee2a6	skip erratic spec	2018-06-20 10:08:06 +10:00
Sam	4d984a5a63	extra diagnostics for thread issues	2018-06-20 09:19:16 +10:00
Sam	cbaf521fc1	correct regression and add integrity spec for onceoffs	2018-06-20 09:09:31 +10:00
Jeff Wong	2ff226e509	FIX: consider staged users mature (no spam checks) after 1 day	2018-06-19 09:41:10 -07:00
Andrew Schleifer	2f7a8ed86c	use different example domain	2018-06-19 11:15:27 -05:00
Arpit Jalan	784202170b	fix the build	2018-06-19 21:40:08 +05:30
Arpit Jalan	aedc61a3b4	FEATURE: allow large icon to be uploaded in wizard	2018-06-19 21:08:02 +05:30
Michael Brown	ae5d255f83	FIX: Reference example.com instead of somesite.com in examples * somesite.com actually exists... * example.com should be used in examples and is harmless to visit	2018-06-19 10:37:24 -04:00
Joffrey JAFFEUX	24c27b5321	FEATURE: adds a add_report method accessible in plugin.rb	2018-06-19 15:00:11 +02:00
Sam	5f64fd0a21	DEV: remove exec_sql and replace with mini_sql Introduce new patterns for direct sql that are safe and fast. MiniSql is not prone to memory bloat that can happen with direct PG usage. It also has an extremely fast materializer and very a convenient API - DB.exec(sql, params) => runs sql returns row count - DB.query(sql, params) => runs sql returns usable objects (not a hash) - DB.query_hash(sql, params) => runs sql returns an array of hashes - DB.query_single(sql, params) => runs sql and returns a flat one dimensional array - DB.build(sql) => returns a sql builder See more at: https://github.com/discourse/mini_sql	2018-06-19 16:13:36 +10:00
Jeff Wong	68e4e6a575	FIX: staged users are still tl0 but do not trigger spam if 1 week old.	2018-06-18 17:20:04 -07:00
Guo Xiang Tan	630b4570ef	Add specs for `RateLimiter::LimitExceeded#description`.	2018-06-19 07:48:03 +08:00
Neil Lalonde	3725fd8345	Merge pull request #6002 from featheredtoast/trust-previously-staged-users FIX: don't punish a user for being previously staged for spam flags.	2018-06-18 15:14:31 -04:00
Guo Xiang Tan	c18b86d9b2	UX: Don't add light box for SVG images.	2018-06-18 17:11:06 +08:00
Arpit Jalan	f1d1207725	FIX: improve context when user deletes self	2018-06-18 11:36:22 +05:30
Jeff Wong	9e55767f6a	FIX: don't punish a user for being previously staged for spam flags.	2018-06-15 12:25:25 -07:00
Arpit Jalan	c7ee70941e	FEATURE: show category page options on wizard 'homepage' step	2018-06-15 19:11:41 +05:30
OsamaSayegh	2427c0a17c	FIX: theme CSS should recompile when theme uploads change	2018-06-15 13:12:09 +10:00
Sam	5f86434bf1	DEV: make tests less fragile	2018-06-14 18:31:07 +10:00
Sam	87fabdc2f3	FIX: correct pool reaper This removes a freedom patch and replaces with a custom reaper thread it also captures an issue where reaper would fail when connections where empty	2018-06-14 18:22:02 +10:00
Sam	1d9fdcd9d3	Attempt to make spec more robust	2018-06-14 16:10:30 +10:00
Sam	71aa20bd30	FIX: pool drainer to use Rails 5.2 implementation old implementation did not reap abandoned connections	2018-06-14 15:54:48 +10:00
Rafael dos Santos Silva	8fc08aad09	FEATURE: Update the webmanifest - Remove share target because the spec is changing - Allow any orientation again because natural is too restrictive - Use correct file and mime types for the manifest	2018-06-14 00:13:28 -03:00
Robin Ward	fd54c92a52	FEATURE: New site setting, whitelisted_link_domains If provided, users who normally couldn't post links (say, due to a low trust level), can post links to those specific hosts.	2018-06-13 16:11:22 -04:00
OsamaSayegh	4a9dadb646	Add test case for topic embed CSS	2018-06-13 16:22:54 +10:00
Maja Komel	6c9190357c	fix get from url for external uploads without CDN	2018-06-13 16:21:28 +10:00
Arpit Jalan	ced3c8e5cf	remove unused variable	2018-06-12 15:00:50 +05:30
Arpit Jalan	59a8471308	FIX: do not show SSO external_email to moderators	2018-06-12 14:20:44 +05:30
Guo Xiang Tan	7c173265d5	FIX: Don't clear connections on the same process.	2018-06-12 13:06:25 +08:00
Sam Saffron	003df147a5	workaround fabricator not working correctly	2018-06-12 14:44:59 +10:00
Guo Xiang Tan	646ed87aba	Clear all connections once master recovers.	2018-06-12 12:13:59 +08:00
Guo Xiang Tan	50b2152ef7	DEV: Clean up freeze time stubs after each test.	2018-06-12 11:43:41 +08:00
Guo Xiang Tan	fd75e54793	Disconnect the pool during failover and fallback.	2018-06-12 11:09:19 +08:00
riking	13a5e41fca	TEST: TopicViewItem ip logging test	2018-06-12 12:43:56 +10:00
Jeff Wong	4599cc8435	FIX: PM participants listed inline	2018-06-11 18:14:25 -07:00
Gerhard Schlager	89bbc94331	Add spec for `a26889a`	2018-06-11 18:43:56 +02:00
Gerhard Schlager	150ae21489	FEATURE: Log user merge in staff logs	2018-06-11 18:43:56 +02:00
Guo Xiang Tan	bfa0f71e2b	FIX: `Discouse.keep_readonly_mode` incorrect extends expiry.	2018-06-12 00:21:29 +08:00
Guo Xiang Tan	204db00563	Skip postgres failover tests until we figure out why.	2018-06-11 15:51:16 +08:00
OsamaSayegh	6ddf32da7c	Merge pull request #5981 from OsamaSayegh/fix-build Fix build	2018-06-11 09:13:10 +03:00
OsamaSayegh	249a256cd2	Fix build	2018-06-11 09:12:28 +03:00
Guo Xiang Tan	f9761c41a9	DEV: Stablize postgresql fallback adapter spec.	2018-06-11 13:58:04 +08:00
Guo Xiang Tan	91557063d8	Fix the build.	2018-06-11 13:39:52 +08:00
OsamaSayegh	77f1cdf20e	REFACTOR: admin backups controller specs to requests (#5953 )	2018-06-11 13:26:24 +08:00
OsamaSayegh	1dbe13886f	REFACTOR: admin site texts controller specs to requests (#5958 )	2018-06-11 12:59:21 +08:00
OsamaSayegh	4f06d6078b	REFACTOR: admin themes controller specs to requests (#5954 )	2018-06-11 12:54:16 +08:00
OsamaSayegh	1fe092da0a	REFACTOR: admin badges controller specs to requests (#5960 )	2018-06-11 12:50:56 +08:00
OsamaSayegh	bf8d392a51	REFACTOR: admin user fields controller specs to requests (#5961 )	2018-06-11 12:50:21 +08:00
OsamaSayegh	4c8939d530	REFACTOR: admin email controller specs to requests (#5962 )	2018-06-11 12:50:08 +08:00
OsamaSayegh	c0776884dd	REFACTOR: admin reports controller specs to requests (#5963 )	2018-06-11 12:49:28 +08:00
OsamaSayegh	da94eaa81d	REFACTOR: admin color schemes controller specs to requests (#5964 )	2018-06-11 12:48:58 +08:00
OsamaSayegh	767f022b29	REFACTOR: admin screened ip addresses controller specs to requests (#5965 )	2018-06-11 12:48:34 +08:00
OsamaSayegh	93b1386fb2	REFACTOR: admin site settings controller specs to requests (#5966 )	2018-06-11 12:48:09 +08:00
OsamaSayegh	325f975ed3	REFACTOR: admin dashboard controller specs to requests (#5967 )	2018-06-11 12:47:42 +08:00
OsamaSayegh	a4574cf2ca	REFACTOR: admin webhooks controller specs to requests (#5969 )	2018-06-11 12:47:29 +08:00
OsamaSayegh	a914ec28fc	REFACTOR: admin impersonate controller specs to requests (#5968 )	2018-06-11 12:47:14 +08:00
OsamaSayegh	d22b552c9b	REFACTOR: admin emojis controller specs to requests (#5974 )	2018-06-11 12:39:31 +08:00
OsamaSayegh	12b1687e1f	REFACTOR: admin permalinks controller specs to requests (#5970 )	2018-06-11 12:37:21 +08:00
OsamaSayegh	37c84451ed	REFACTOR: admin staff action logs controller specs to requests (#5971 )	2018-06-11 12:37:06 +08:00
OsamaSayegh	65241c6778	REFACTOR: admin api controller specs to requests (#5972 )	2018-06-11 12:35:45 +08:00
OsamaSayegh	2c8a9d36af	REFACTOR: admin versions controller specs to requests (#5973 )	2018-06-11 12:35:05 +08:00
OsamaSayegh	237559c76f	REFACTOR: admin screened emails controller specs to requests (#5975 )	2018-06-11 12:33:54 +08:00
OsamaSayegh	f30c2dacb2	REFACTOR: admin screened urls controller specs to requests (#5976 )	2018-06-11 12:33:38 +08:00
OsamaSayegh	63b2207065	REFACTOR: admin plugins controller specs to requests (#5977 )	2018-06-11 12:33:07 +08:00
OsamaSayegh	c6fe082fe4	REFACTOR: admin controller specs to requests (#5978 )	2018-06-11 12:32:55 +08:00
OsamaSayegh	4ac7be1d1c	REFACTOR: admin embeddable hosts controller specs to requests (#5979 )	2018-06-11 12:32:13 +08:00
OsamaSayegh	062aecd239	REFACTOR: admin embedding controller specs to requests (#5980 )	2018-06-11 12:31:58 +08:00
Guo Xiang Tan	5656e8f366	FIX: Can't boot Discourse with a read-only PG connection.	2018-06-11 12:29:23 +08:00
Neil Lalonde	b8cf0788c6	FIX: broken mailto href's in emails	2018-06-08 13:11:58 -04:00
Gerhard Schlager	2564a8285d	REFACTOR: Run some parts of user anonymizing in background job	2018-06-08 15:50:07 +02:00
Gerhard Schlager	cf038cf72a	FEATURE: Remove more PII during user anonymizing Removes * invite if the user was invited * email tokens * incoming emails * email log entries * raw emails from posts	2018-06-08 15:50:07 +02:00
OsamaSayegh	f5ad0022f7	REFACTOR: admin users controller specs to requests (#5946 )	2018-06-08 12:42:06 +08:00
Guo Xiang Tan	8e0c1c8782	Re-enable skipped specs.	2018-06-08 10:04:06 +08:00
Arpit Jalan	f9ab3848ed	FEATURE: support disabling emails for non-staff users	2018-06-07 18:31:08 +05:30
Sam	945cb90e7e	update specs	2018-06-07 20:55:42 +10:00
Guo Xiang Tan	3a8f69c3d2	DEV: Assert for 200 response code to avoid changing magic helper in the future.	2018-06-07 16:11:09 +08:00
OsamaSayegh	1e805cfd3e	REFACTOR: composer messages controller specs to requests (#5940 )	2018-06-07 13:51:52 +08:00
OsamaSayegh	c6c1ef71c1	REFACTOR: inline onebox controller specs to requests	2018-06-07 13:11:45 +08:00
OsamaSayegh	30be1b0d2b	REFACTOR: category hashtags controller specs to requests (#5936 )	2018-06-07 13:09:23 +08:00
OsamaSayegh	9975f9751e	REFACTOR: metadata controller specs to requests (#5935 )	2018-06-07 13:08:28 +08:00
OsamaSayegh	1957cb541b	REFACTOR: permalinks controller specs to requests (#5934 )	2018-06-07 13:08:13 +08:00
OsamaSayegh	f2a5a84f0b	REFACTOR: similar topics controller specs to requests (#5933 )	2018-06-07 13:07:53 +08:00
OsamaSayegh	37829a521a	REFACTOR: stylesheets controller specs to requests	2018-06-07 13:06:32 +08:00
OsamaSayegh	a8d33603f9	REFACTOR: export CSV controller specs to requests	2018-06-07 13:02:02 +08:00
OsamaSayegh	0124209a96	REFACTOR: site controller specs to requests	2018-06-07 12:58:33 +08:00
OsamaSayegh	3c96ee4b6f	REFACTOR: clicks controller specs to requests (#5929 )	2018-06-07 12:57:29 +08:00
OsamaSayegh	2688cc6241	REFACTOR: post action users controller specs to requests	2018-06-07 12:55:01 +08:00
OsamaSayegh	e2e566214d	REFACTOR: user avatars controller spec to requests	2018-06-07 12:53:33 +08:00
OsamaSayegh	05c1fe5c8f	REFACTOR: user actions controller specs to requests	2018-06-07 12:52:06 +08:00
OsamaSayegh	7f21892ad0	REFACTOR: finish installation controller specs to requests	2018-06-07 12:49:47 +08:00
OsamaSayegh	5ecaa55e50	REFACTOR: webhooks controller specs to requests	2018-06-07 12:46:29 +08:00
Guo Xiang Tan	4782f6cd01	Remove controller type spec for post actions.	2018-06-07 12:45:38 +08:00
OsamaSayegh	cc82fb33b5	REFACTOR: queued posts controller specs to requests	2018-06-07 12:41:26 +08:00
OsamaSayegh	1b7d46c054	REFACTOR: post actions controller specs to requests	2018-06-07 12:38:17 +08:00
OsamaSayegh	f75d1e958d	REFACTOR: extra locales controller specs to requests	2018-06-07 12:34:39 +08:00
Sam	f331d2603d	DEV: improve design of site setting default provider This refactors it so "Defaults provider" is only responsible for "defaults" Locale handling and management of locale settings is moved back into SiteSettingExtension This eliminates complex state management using DistributedCache and makes it way easier to test SiteSettingExtension	2018-06-07 14:33:41 +10:00
OsamaSayegh	d2880246cd	REFACTOR: steps controller specs to requests	2018-06-07 12:31:13 +08:00
Guo Xiang Tan	47ddb3a7ca	Merge branch 'wizard-controller' of https://github.com/OsamaSayegh/discourse into OsamaSayegh-wizard-controller	2018-06-07 12:27:48 +08:00
OsamaSayegh	600ff85ecd	REFACTOR: draft controller specs to requests (#5942 )	2018-06-07 12:24:20 +08:00
OsamaSayegh	f5178ded56	REFACTOR: offline controller spec to requests (#5943 )	2018-06-07 12:24:05 +08:00
Sam	89ad2b5900	DEV: Rails 5.2 upgrade and global gem upgrade This updates tests to use latest rails 5 practice and updates ALL dependencies that could be updated Performance testing shows that performance has not regressed if anything it is marginally faster now.	2018-06-07 14:21:33 +10:00
Vinoth Kannan	d8e641cd98	FIX: avatar_url includes upload_path twice when local storage used	2018-06-06 18:27:30 +05:30
OsamaSayegh	3244fb8959	REFACTOR: wizard controller specs to requests	2018-06-06 12:07:55 +03:00
Guo Xiang Tan	a83ab01264	REFACTOR: Remove extra param for group mentionable and messableable route.	2018-06-06 09:42:09 +08:00
Arpit Jalan	f8d82f135f	FIX: do not verify group visibility when checking for mentionable/messageable	2018-06-05 16:59:21 +05:30
OsamaSayegh	d3e610eed9	REFACTOR: topic controller (2) specs to requests (#5911 )	2018-06-05 12:03:49 +08:00
OsamaSayegh	475d944d74	REFACTOR: onebox controller specs to requests (#5914 )	2018-06-05 11:36:08 +08:00
OsamaSayegh	22fcc04d38	REFACTOR: user badges controller specs to requests (#5912 )	2018-06-05 10:59:01 +08:00
OsamaSayegh	79dcd79470	REFACTOR: email controller specs to requests (#5917 )	2018-06-05 10:57:11 +08:00
Guo Xiang Tan	a508e6a5f6	DEV: Stablize `requests/search_controller_spec`.	2018-06-05 10:07:05 +08:00
Guo Xiang Tan	aaea24448e	DEV: Add specs for `085eaaf18d`.	2018-06-05 10:03:26 +08:00
Guo Xiang Tan	d600e71b3d	FIX: Clean up stale `UserExport` records daily. * Add tests for `UserExport.remove_old_exports`	2018-06-05 09:43:40 +08:00
Guo Xiang Tan	dcba320bf6	Remove spec that isn't testing for anything.	2018-06-05 09:30:02 +08:00
Arpit Jalan	46fc57222f	FEATURE: improve handling of site setting secrets	2018-06-04 21:31:34 +05:30
OsamaSayegh	bc75cfe4b5	REFACTOR: tags controller specs (#5908 )	2018-06-04 14:09:14 +08:00
OsamaSayegh	1f8805d3af	REFACTOR: user api keys contoller specs to request	2018-06-04 16:07:53 +10:00
OsamaSayegh	807223deef	REFACTOR: notifications controller specs to requests	2018-06-04 16:06:53 +10:00
OsamaSayegh	e4bdafb550	REFACTOR: categories controller specs to requests (#5903 ) REFACTOR: categories controller specs to requests	2018-06-04 12:04:32 +08:00
OsamaSayegh	e58ed247f2	REFACTOR: uploads controller specs to requests (#5907 )	2018-06-04 11:13:52 +08:00
OsamaSayegh	cfea837e88	REFACTOR: search controller specs to requests (#5906 )	2018-06-04 11:12:38 +08:00
OsamaSayegh	9b4a98695e	REFACTOR: list controller specs to requests (#5902 )	2018-06-04 11:09:59 +08:00
Arpit Jalan	36f9af4fa4	minor optimizations for post rejected logs	2018-06-02 09:44:55 +05:30
Arpit Jalan	89eca87f16	FEATURE: add staff action log for post rejections	2018-06-01 21:48:27 +05:30
Gerhard Schlager	c0bab84dc1	Fix random build error Spec usually failed when there was an UpdateGravatar job for the system user.	2018-06-01 17:34:19 +02:00
Gerhard Schlager	b970b072f6	FIX: User merge should not fail when primary email address is missing The merge process might move all email addresses of the source user to the target user. Destroying the source user failed in that case.	2018-06-01 16:23:21 +02:00
OsamaSayegh	474ff94df3	REFACTOR: convert invites controller specs to requests (#5898 ) REFACTOR: convert invites controller specs to requests	2018-06-01 13:06:08 +08:00
Guo Xiang Tan	d57a5d3e8c	Fix brittle spec.	2018-06-01 11:56:56 +08:00
Guo Xiang Tan	12a0f12530	Fix the build.	2018-06-01 11:24:32 +08:00
Blake Erickson	7750b30016	FIX: Allow a user to remove their title Somewhere there was a regression and a user couldn't remove their own title. If they selected '(none)' in the UI it would say it was saved, but it would not actually be updated in the db.	2018-05-31 17:16:52 -06:00
OsamaSayegh	d4848f2d58	REFACTOR: topics controller specs to requests (#5886 ) * REFACTOR: topics controller specs to requests	2018-05-31 22:45:32 +08:00
Guo Xiang Tan	7fc8a36529	DEV: Take 2 Queue jobs in tests by default. On my machine this cuts the time taken to run our test suite from ~11mins to ~9mins.	2018-05-31 16:23:23 +08:00
Guo Xiang Tan	56e9ff6853	Revert "DEV: Queue jobs in tests by default." Too risky for now This reverts commit `be28154d3b`.	2018-05-31 15:34:46 +08:00
Guo Xiang Tan	2b783997fa	Refactor tests to complete assertions within a single `it` block.	2018-05-31 15:05:47 +08:00
Sam	5086fdc76d	FIX: add protection for scss removal during upgrade In some cases plugins would remove scss files or change them, but CSS was still calculated based off stale data in old instance cache	2018-05-31 17:02:48 +10:00
Guo Xiang Tan	be28154d3b	DEV: Queue jobs in tests by default.	2018-05-31 14:45:47 +08:00
Guo Xiang Tan	95f9b72351	FIX: Update activation email route was returning a generic json error.	2018-05-31 14:19:43 +08:00
OsamaSayegh	4e21a031df	Remove trailing whitespace	2018-05-31 12:31:46 +10:00
OsamaSayegh	23e3a68592	REFACTOR: session controller specs to requests	2018-05-31 12:31:46 +10:00
Guo Xiang Tan	f623740ffc	DEV: Stablize DiscourseRedis tests.	2018-05-30 14:45:19 +08:00
Guo Xiang Tan	21e9315416	FIX: Use user account email instead of auth email when totp is enabled. https://meta.discourse.org/t/github-2fa-flow-broken/88674	2018-05-30 12:15:12 +08:00
Guo Xiang Tan	543b7cddfb	FIX: Extra comma resulted in Github auth email result being an array. https://meta.discourse.org/t/github-2fa-flow-broken/88674	2018-05-30 12:15:12 +08:00
Neil Lalonde	e26a14dc29	FIX: error when flagging to notify moderators because message title is too long	2018-05-29 12:21:47 -04:00
Sam	df815d6c0e	DEV: prefer using ordering in relation over default scope	2018-05-29 09:34:12 +10:00
Arpit Jalan	c8bc942333	FIX: do not add invited user to automatic groups	2018-05-28 17:17:48 +05:30
Guo Xiang Tan	81b5d61fa7	FIX: `topic_destroyed` web hook couldn't find topic.	2018-05-28 17:38:02 +08:00
Gerhard Schlager	ed2ae3cb0a	FIX: Load post revisions in correct order	2018-05-28 11:25:24 +02:00
Guo Xiang Tan	123a22e6d8	DEV: Clean up omniauth after mocking.	2018-05-28 15:12:54 +08:00
Guo Xiang Tan	a081771950	Merge pull request #5872 from OsamaSayegh/users-controller-specs-to-request REFACTOR: users contollers specs => request specs	2018-05-28 13:32:37 +08:00
Sam	e501936405	FIX: search server side error in rare condition	2018-05-28 15:28:18 +10:00
OsamaSayegh	0347c97520	tgxworld feedback	2018-05-28 06:20:47 +03:00
Sam	5a32a70d6c	FIX: ColorScheme color missing was returning "nil"	2018-05-28 11:46:00 +10:00
Robin Ward	4195c7c9ea	FEATURE: Ability to clear a user's penalty history You can do this manually if you want to allow them to reach TL3 without their penalty history counting against them.	2018-05-25 12:54:22 -04:00
Gerhard Schlager	20b94bc714	FIX: Extraction of quoted posts failed in some cases * It stored only oneboxed "quotes" when [quote] and links to topics or posts were mixed. * Revising a post didn't add or remove records from the quoted_posts table.	2018-05-25 12:00:17 +02:00
riking	12e4dd59b7	Style fix for test	2018-05-25 15:54:14 +10:00
riking	501bc0e9af	FIX: UserProfileView: Do not log IP of logged-in users	2018-05-25 15:54:14 +10:00
Sam	9c91c2509e	improve spec stability	2018-05-25 15:16:40 +10:00
Sam	610bfec73e	DEV: correct fragile spec	2018-05-25 14:29:11 +10:00
Sam	720a12ce76	correct time dependent spec	2018-05-25 14:26:05 +10:00
Sam	be1b8fc3a8	DEV: ensure specs run in consistent times	2018-05-25 14:22:43 +10:00
Guo Xiang Tan	755b511b5c	PERF: Destroy collapsed notifications in 1 query instead of 3.	2018-05-25 12:01:36 +08:00
Sam	80adc1ee80	DEV: stabilize site setting spec side effects could cause specs to fail in rare conditions	2018-05-25 12:16:00 +10:00
OsamaSayegh	bac0482061	REFACTOR: users contollers specs => request specs	2018-05-25 05:04:25 +03:00
Guo Xiang Tan	58fbe74b6f	Remove assertion `to_not raise_error`. If an error is raised the test would fail anyway.	2018-05-25 09:57:08 +08:00
Guo Xiang Tan	1f27c91924	DEV: Better diagnostic when topic tracking state tests fail.	2018-05-24 15:36:41 +08:00
Guo Xiang Tan	43f7cb05c9	FIX: Broken ping event for web hooks due to missing payload.	2018-05-24 15:16:52 +08:00
Sam	d366f8d888	remove hack that destabliazed tese suite	2018-05-24 10:48:16 +10:00
Neil Lalonde	3db1032bfd	FIX: not found page shouldn't include the Google search form for sites with login_required enabled	2018-05-23 16:59:02 -04:00
Andrew Schleifer	4be0e31459	fix s3_cdn_url when the s3 bucket contains a folder	2018-05-23 15:51:02 -05:00
Ryan Mulligan	fac4bf2f85	ignore emails that are from the reply by email addresses (#5843 )	2018-05-23 10:04:45 +02:00
Guo Xiang Tan	ad9e0d6bea	Merge pull request #5848 from OsamaSayegh/fix-social-login-groups FIX: apply automatic group rules when using social login providers	2018-05-23 08:17:42 +08:00
OsamaSayegh	f6d412465b	FIX: apply automatic group rules when using social login providers	2018-05-23 02:26:07 +03:00
Blake Erickson	3edca8b104	Return a 403 instead of 200 when trying to delete a user with posts See [this commit][1] for more info [1]: `bd352a17bf`	2018-05-22 17:02:02 -06:00
OsamaSayegh	609804f5ef	REFACTOR: merge posts controller specs into request specs	2018-05-23 08:53:46 +10:00
Sam	45f65859c9	improve erraticly failing spec	2018-05-23 08:39:15 +10:00
Gerhard Schlager	beed676b04	FIX: Check group names when checking username availability	2018-05-22 21:55:54 +02:00
Gerhard Schlager	95db5f0c8c	FIX: Do not replace wrong avatars when renaming user	2018-05-22 13:41:51 +02:00
Sam	1ac1ee4287	FEATURE: allow registration of an array custom field	2018-05-22 16:48:39 +10:00
Sam	bcfd9cf8b5	attempt to stabilize spec	2018-05-22 16:15:24 +10:00
riking	d4639bc734	TEST: Add TopicLinkClick spec for ip logging	2018-05-22 16:05:38 +10:00
OsamaSayegh	450a600721	REFACTOR: about & badge controllers => requests	2018-05-22 13:45:13 +10:00
Sam	661d89f489	skip erratic spec	2018-05-22 09:42:50 +10:00
Sam	788ca1f112	FIX: stop adding email to unsubscribe url Instead of adding email to unsubscribe url store it in redis for 1 hour rate limit calls to unsubscribe endpoint to ensure there is no risk of bloating redis Also move controller to request specs	2018-05-22 09:07:03 +10:00
Guo Xiang Tan	37ad2dd936	Fix the build.	2018-05-21 17:59:47 +08:00
Guo Xiang Tan	aae5575d33	Remove spec file that was accidentally added.	2018-05-21 17:35:55 +08:00
Guo Xiang Tan	467d91347a	Missing specs for `Group`, `Tag`, `Category` and `Flag` web hooks.	2018-05-21 17:29:58 +08:00
Guo Xiang Tan	bf84037f79	FIX: Payload for webhooks should be current as of the time the event was triggered. https://meta.discourse.org/t/group-category-tag-user-deleted-webhooks-not-firing/87752	2018-05-21 17:29:58 +08:00
Guo Xiang Tan	00c6b078e3	Trim `WebHookUserSerializer`.	2018-05-21 17:29:58 +08:00
Guo Xiang Tan	60e7b13f59	Trim `WebHookPostSerializer` further.	2018-05-21 17:29:58 +08:00
Guo Xiang Tan	3ff0074e9d	Trim `WebHookTopicSerializer` further.	2018-05-21 17:29:58 +08:00
Sam	ec337bbcb3	DEV: attempt to report last exception as the "cause" for failures This allows our request specs to report exceptions so we can debug May have a few false positives but generally should be quiet TODO only wire magic in for request specs, currently happens for all	2018-05-21 17:01:50 +10:00
Guo Xiang Tan	b7b08b4173	Fix regression introduced in `2ceb107074`.	2018-05-21 13:26:23 +08:00
Guo Xiang Tan	2ceb107074	Refactor tests to use the json extension instead of headers.	2018-05-21 09:49:46 +08:00
Arpit Jalan	9f422c93f6	FIX: restrict updates on `confirm_old_email` email templates	2018-05-19 12:19:59 +05:30
Arpit Jalan	290ee312e6	FIX: handle invalid mailto links	2018-05-18 18:02:52 +05:30
Guo Xiang Tan	b9dfb0ba10	Partially revert `531baec5b5`.	2018-05-18 15:01:36 +08:00
Guo Xiang Tan	531baec5b5	Remove unused fabricator.	2018-05-18 13:37:39 +08:00
Guo Xiang Tan	416d19af27	FIX: Wrong target user displayed for user actions in activity stream. https://meta.discourse.org/t/wrong-assigned-username-in-activity-list/73816	2018-05-18 11:28:13 +08:00
Guo Xiang Tan	417bcc5f2a	Remove blank test.	2018-05-18 11:07:57 +08:00
Jeff Wong	04c7dbafa3	FIX: manifest.json better detection at mime type. Find size if uploaded	2018-05-17 14:45:24 -07:00
Jeff Wong	41ffafb65e	FIX: best effort at returning correct mime types in manifest.json	2018-05-17 12:14:39 -07:00
Régis Hanol	53f8f6095d	FEATURE: staff action logs when creating/updating/deleting badges	2018-05-17 18:09:27 +02:00
Arpit Jalan	9532d9a555	FIX: handle invalid tags	2018-05-17 19:33:12 +05:30
Guo Xiang Tan	b74c108c09	UX: Display group tabs in user's messages tab for non-staff as well. https://meta.discourse.org/t/group-inboxes-in-user-messages/86787	2018-05-17 18:10:17 +08:00
Guo Xiang Tan	147ea37115	FIX: Missing notification for watching first post users when topic is recategorized. https://meta.discourse.org/t/not-receiving-notifications-for-announcements/87275/2?u=tgxworld	2018-05-17 16:15:29 +08:00
Arpit Jalan	33899664ce	FIX: handle bad user profile website	2018-05-17 13:21:24 +05:30
Arpit Jalan	539cf32f87	FIX: handle encoded mailto links when looking for upload record	2018-05-17 12:44:53 +05:30
Arpit Jalan	aee4045dd0	FIX: suggest name when username/name is provided	2018-05-17 10:36:36 +05:30
Guo Xiang Tan	f21a47eadd	Improve specs to assert for the right record instead of just a count.	2018-05-17 08:47:24 +08:00
Régis Hanol	a9ebde5111	FEATURE: new 'staged' users list for admins	2018-05-17 01:52:49 +02:00
Régis Hanol	39aceed63d	FIX: don't purge unactivated users with a message	2018-05-16 18:24:11 +02:00
Gerhard Schlager	ae6236d090	FIX: Changing owner of deleted reply didn't work	2018-05-16 17:03:09 +02:00
Régis Hanol	4103783821	FIX: don't use PMs in Incoming Links reports	2018-05-16 16:55:54 +02:00
Régis Hanol	131b7f5da5	make 🤖 rubocop happy	2018-05-16 16:35:04 +02:00
Joe Buhlig	3cd4c82c49	Allow parameters for group and username filters on directory (#5815 )	2018-05-16 16:20:17 +02:00
Régis Hanol	5e97a9bfb7	FIX: tags in a 'visible by everyone but usable only by staff' group weren't visible by everyone	2018-05-16 09:48:19 +02:00
Guo Xiang Tan	565fa1f60e	Fix regression introduced in `8cf0f51eb2`.	2018-05-16 14:26:03 +08:00
Sam	21e0b7c818	avoid async report pattern and replace with simpler hijack	2018-05-16 16:05:03 +10:00
Gerhard Schlager	74c4af279a	Improvements to user renaming * don't update search index if post belongs to deleted topic * log errors instead of crashing when updating post or revision fails * update mentions even when the href attribute is missing * run the background job with low priority * replace username in all notifications * update `action_code_who` used by small action posts	2018-05-15 21:05:51 +02:00
Gerhard Schlager	2e1b5bc8d3	FIX: Transaction in UserAnonymizer prevented avatar from updating	2018-05-15 20:47:58 +02:00
Sam	b9c6821261	correct spec	2018-05-15 15:20:36 +10:00
Arpit Jalan	abcb6af8f9	FIX: scrub secret setting values from logs	2018-05-15 09:19:26 +05:30
Régis Hanol	a28c58feb1	FIX: automatic group membership when using SSO	2018-05-15 01:48:30 +02:00
riking	d2347474a5	Tests for IncomingLink IP logging	2018-05-15 09:32:29 +10:00
Joffrey JAFFEUX	e474351ae4	inactive users report is not used anymore	2018-05-14 21:31:14 +02:00
Gerhard Schlager	c67c2dc638	FIX: Username update should ignore revisions without raw	2018-05-14 15:22:42 +02:00
Gerhard Schlager	8232aba743	FIX: Update search index after renaming user within posts	2018-05-14 13:20:30 +02:00
Gerhard Schlager	02cb84847c	FIX: Update avatar in oneboxed posts when renaming user	2018-05-14 13:20:29 +02:00
Gerhard Schlager	49392fb105	FIX: Anonymizing user didn't replace uploaded avatar in posts	2018-05-14 13:20:29 +02:00
Régis Hanol	9d9332d8c9	FIX: allow user quotes in HTML digest emails	2018-05-13 18:23:17 +02:00
Régis Hanol	37232fcb58	FIX: staff members should see all tags	2018-05-13 17:50:21 +02:00
Régis Hanol	2cf6fb7359	FIX: always unstage users when they log in	2018-05-13 17:00:02 +02:00
Sam	67054d524d	correct missing day from async reports	2018-05-11 15:06:23 +10:00
Sam	8a783412b7	UX: improvements to new dashboard - remove inactive user report and replace with posts - clean up internals so grouping by week happens on client - when switching periods old report was not destroyed leading to bugs - calculate trend based on previous interval ... not previous 30 days - show percentages for mau/dau - be more careful about utc date usage - show uniqu and click through rate on search panel - publish key of report with report so we only load the correct one - subscribe earlier in channel in case of concurrency issues	2018-05-11 13:30:32 +10:00
Blake Erickson	bd352a17bf	FIX: Show a json api response when deleting a user with posts A 500 error was actually caused with no response when using the api, so it wasn't very clear that you need to delete the posts first when using the api.	2018-05-10 13:04:36 -06:00
Régis Hanol	86eb3528ec	FEATURE: clearer error message when receiving a reply to an old notification	2018-05-09 18:51:01 +02:00
Régis Hanol	6b1ff0edd3	FIX: always update bounce score (instead of doing it once per day)	2018-05-09 16:40:52 +02:00
Guo Xiang Tan	2eb2f273a8	Refactor of `PushSubscriptionPusher`.	2018-05-09 08:14:14 +08:00
Jeff Wong	7f1f697e97	FIX: de-duplicate push subscriptions - ensure unique user/key	2018-05-08 15:20:39 -07:00
Gerhard Schlager	52db0b31c1	FIX: Automatically add user to groups after updating email address	2018-05-08 21:27:22 +02:00
Arpit Jalan	83245aa508	FIX: better handling of invite links after they are redeemed FIX: deprecate invite_passthrough_hours setting	2018-05-08 20:17:57 +05:30
Gerhard Schlager	2e67998319	Improvements for user renaming (#5810 ) * FEATURE: Update avatars in posts and revisions when user gets renamed * FIX: Replace username in deleted posts when user gets renamed * FEATURE: Replace username in notifications when user gets renamed FEATURE: Update mentions and quotes when user gets merged	2018-05-08 10:02:43 -04:00
Robin Ward	8262fc5d15	Merge pull request #5807 from discourse/min-flags-by-topic FEATURE: New site setting `min_flags_staff_visibility`	2018-05-08 09:17:29 -04:00
Sam	858a266031	FIX: exact matching should also match on title	2018-05-08 15:59:03 +10:00
Guo Xiang Tan	086cb0f849	Fix brittle spec.	2018-05-08 10:52:03 +08:00
Guo Xiang Tan	8cf0f51eb2	UX: Display site settings shortcut for `poll` and `discourse-nginx-performance-report`. https://meta.discourse.org/t/improving-admin-plugins/84585/29?u=tgxworld	2018-05-08 10:34:32 +08:00
Robin Ward	ac60a84329	FEATURE: New site setting `min_flags_staff_visibility` When set higher than 1, flags won't show up for staff in the admin section unless the minimum threshold of flags on a post is reached.	2018-05-07 16:05:13 -04:00
Guo Xiang Tan	ee1eb1a5bd	FIX: Retrigger notification when a topic is recategorized. https://meta.discourse.org/t/notifications-when-a-topic-is-recategorized/63079	2018-05-07 21:29:06 +08:00
Régis Hanol	a98aae3bcd	FIX: topic search wasn't working for unlisted topics	2018-05-07 11:43:55 +02:00
Misaka 0x4e21	ff6be3c2e3	FEATURE: add profile_background fields into SSO (#5701 ) Add profile_background and card_background fields into Discourse SSO.	2018-05-07 10:03:26 +02:00
Guo Xiang Tan	21007a4a8d	Rewrite push notifications controller specs as request specs. * Improve assertions to test for the outcome we expected instead of just asserting for a 200 response. * Remove duplicated assertion.	2018-05-07 15:40:46 +08:00
Guo Xiang Tan	ad833c4485	FIX: Don't downcase group name.	2018-05-07 14:02:11 +08:00
Guo Xiang Tan	aa0d32231c	FIX: Incorrect query when removing a group owner. https://meta.discourse.org/t/group-rename-and-group-owners-removal-problems/85596	2018-05-07 13:57:00 +08:00
Guo Xiang Tan	77eb93ffb7	Fabricate records with the right attributes during fabrication.	2018-05-07 11:26:38 +08:00
Jeff Wong	91b31860a1	Feature: Push notifications for Android (#5792 ) * Feature: Push notifications for Android Notification config for desktop and mobile are merged. Desktop notifications stay as they are for desktop views. If mobile mode, push notifications are enabled. Added push notification subscriptions in their own table, rather than through custom fields. Notification banner prompts appear for both mobile and desktop when enabled.	2018-05-04 15:31:48 -07:00
Gerhard Schlager	40e22b14f3	Fix specs (didn't work on UTC+xx timezones)	2018-05-04 08:21:57 +02:00
Gerhard Schlager	ee426623e4	Dashboard next: correctly group inactive member count	2018-05-04 07:48:55 +02:00
Gerhard Schlager	41cd8c169c	Add specs for inactive users report	2018-05-04 07:48:55 +02:00
Sam	3a06cb461e	FEATURE: remove support for legacy auth tokens	2018-05-04 10:12:10 +10:00
Jeff Wong	62a8904729	Feature: Include participants at the bottom of PM emails (#5797 ) * Feature: Include participants at the bottom of PM emails ... as undecorated links. https://meta.discourse.org/t/email-notification-recipients-unclear-when-pm-is-sent-to-multiple-users/26934/13?u=featheredtoast Fix: missing translation for PM mentions * display membership count as `group (count)`	2018-05-03 15:50:06 -07:00
Joffrey JAFFEUX	980972182f	dashboard next: caching, mobile support and new charts	2018-05-03 15:41:41 +02:00
Robin Ward	05dddcb2fd	Add an event that is triggered when a user is anonymized	2018-05-02 12:25:29 -04:00
Sam	bdd9775869	improve spec	2018-05-02 17:16:00 +10:00
Kyle Zhao	0cc4b42180	FIX: TopicEmbed.import should update title and author	2018-05-02 17:12:31 +10:00
Gerhard Schlager	3be3c50c7e	FEATURE: Rename user in mentions and quotes Co-authored-by: Robin Ward <robin.ward@gmail.com>	2018-05-01 13:49:14 -04:00
Robin Ward	079caf08d6	FIX: leftover debug statement	2018-04-30 14:41:11 -04:00
Robin Ward	e21a4ce1dd	FEATURE: Support anonymizing a user's IP addresses	2018-04-30 14:09:03 -04:00
Arpit Jalan	d074a39d39	fix the build	2018-04-27 20:04:24 +05:30
Arpit Jalan	67357b84b9	FIX: only allow one user to be created per invite	2018-04-27 19:21:10 +05:30
Neil Lalonde	f7c4c71409	FIX: title selector needs to flag whether title comes from badge or not	2018-04-26 16:51:11 -04:00
Neil Lalonde	bd77795d7a	REFACTOR: move support for user card badge images to a plugin discourse-user-card-badges	2018-04-26 13:25:24 -04:00
Joffrey JAFFEUX	9fabf2543b	dashboard next: activity metrics and new contributors This commit also introduces a better grouping of data points.	2018-04-26 14:49:41 +02:00
Sam	b26e27bdab	correct specs	2018-04-26 17:24:16 +10:00
Sam	88f5251415	FIX: disallow invalid top_menu and post_menu and share_links In the past any text could be entered there causing big potential issues	2018-04-26 17:00:56 +10:00
Sam	6676bbd38b	FEATURE: index YouTube titles in search Previously we omitted the titles for videos that YouTube provided	2018-04-26 15:46:52 +10:00
Sam	a0cd54750c	FIX: inline [code] not handled properly The text a [code]test[/code] Would eat up the `test` text cause translation from inline to block for replace rule was not properly handled	2018-04-26 15:18:22 +10:00
Régis Hanol	598aba3261	fix the build	2018-04-25 22:34:23 +02:00
Régis Hanol	ddb092f397	FIX: update mail gem to fix UTF-8 parsing issue	2018-04-25 21:53:37 +02:00
Robin Ward	a5172a37e0	Allow staff members to enable safe mode, even if disabled	2018-04-25 11:49:57 -04:00
Guo Xiang Tan	ee82abba3c	Prefer `save!/create!` over `save/create`.	2018-04-25 13:39:45 +08:00
Arpit Jalan	65be3c627d	further optimize spec	2018-04-25 11:08:38 +05:30
Arpit Jalan	9d7f4cec3e	optimize spec	2018-04-25 10:27:56 +05:30
Arpit Jalan	d2cc5452ec	add spec for user csv export	2018-04-25 10:22:39 +05:30
Robin Ward	456e40a709	FIX: Don't allow a user to become TL3 if they've ever been penalized Previously the code would only check if they were currently suspended or silenced.	2018-04-24 15:15:32 -04:00
Gerhard Schlager	ec29869350	FIX: Merging users failed when PM was sent to source and target user	2018-04-24 11:08:29 -04:00
Gerhard Schlager	ed4c0c4a63	FEATURE: Add option to delete all replies of flagged post	2018-04-24 11:08:05 -04:00
Sam	035312d501	FIX: specify path for dosp cookie	2018-04-24 11:07:58 -04:00
Sam	146a6c3592	FIX: exclude topics from latest in /categories on refresh When you hit refresh on categories page it would not supress correctly	2018-04-24 11:07:26 -04:00
Robin Ward	fd14ee4797	FEATURE: Allow safe mode to be disabled	2018-04-24 11:03:33 -04:00
Arpit Jalan	0a442977b3	FEATURE: add staff action log for post approvals	2018-04-23 11:28:44 +05:30
Guo Xiang Tan	c148500d51	FIX: Deadlock when topic with auto close topic timers exceeds `auto_close_topics_post_count`.	2018-04-23 13:34:24 +08:00
Guo Xiang Tan	9eabf7c02c	Fix randomly failing specs due to SearchLog cache.	2018-04-23 10:10:10 +08:00
Sam	ded84a4b58	PERF: improve performance once logged in rate limiter hits If "logged in" is being forced anonymous on certain routes, trigger the protection for any requests that spend 50ms queueing This means that ... 1. You need to trip it by having 3 requests take longer than 1 second in 10 second interval 2. Once tripped, if your route is still spending 50m queueuing it will continue to be protected This means that site will continue to function with almost no delays while it is scaling up to handle the new load	2018-04-23 11:55:25 +10:00
Neil Lalonde	70f2c5d3fd	FEATURE: move staff tags setting to tag group settings	2018-04-20 15:34:23 -04:00
Guo Xiang Tan	98d880b67a	Missed a spot in `45fe5dc793`	2018-04-20 13:59:19 +08:00
Guo Xiang Tan	70d181bff8	FIX: Better error message in `GroupsController#add_members`. https://meta.discourse.org/t/cant-add-members-to-a-group/85738?u=tgxworld	2018-04-20 10:28:52 +08:00
Arpit Jalan	9a912b9b35	fix the build	2018-04-20 00:39:12 +05:30
Arpit Jalan	91bf10bd12	FIX: create upload record for exported csv files	2018-04-20 00:27:49 +05:30
Joffrey JAFFEUX	0e414d0890	dashboard next: trending search report This commit also improves how data is loaded sync and async	2018-04-19 18:19:21 +02:00
Régis Hanol	45850a0cd6	FIX: don't break when posting invalid URIs	2018-04-19 12:29:35 +02:00
Joffrey JAFFEUX	01c061d20d	dashboard next: perf and UI tweaks * cache CORE reports * adds backups/uploads section * few css tweaks	2018-04-18 21:30:41 +02:00
Neil Lalonde	5b93d69939	FIX: error when non-staff user edits their topic after a hidden tag is added to it	2018-04-18 12:51:25 -04:00
Arpit Jalan	c61ce66411	fix the build	2018-04-18 13:38:45 +05:30
Sam	59cd7894d9	FEATURE: if site is under extreme load show anon view If a particular path is being hit extremely hard by logged on users, revert to anonymous cached view. This will only come into effect if 3 requests queue for longer than 2 seconds on a single path. This can happen if a URL is shared with the entire forum base and everyone is logged on	2018-04-18 16:58:57 +10:00
Arpit Jalan	3566c6f02b	FIX: strip emoji string from slug	2018-04-18 11:32:32 +05:30
Neil Lalonde	b87fa6d749	FIX: blacklisted crawlers could get through by omitting the accept header	2018-04-17 12:39:30 -04:00
Régis Hanol	2585ada5ca	FIX: don't allow spaces in 'reply_by_email_address' site setting	2018-04-17 17:08:12 +02:00
Sam	9980f18d86	FEATURE: track request queueing as early as possible	2018-04-17 18:06:17 +10:00
Guo Xiang Tan	64a45b0980	FIX: Missing `Group#bio_raw` attribute for group owners. https://meta.discourse.org/t/group-description-does-not-load-in-editor-for-owners-who-are-not-staff/85345	2018-04-17 15:57:52 +08:00
Guo Xiang Tan	828bfd9d27	Add specs for `c74c933996`.	2018-04-17 10:08:39 +08:00
Robin Ward	3d7dbdedc0	FEATURE: An API to help sites build robots.txt files programatically This is mainly useful for subfolder sites, who need to expose their robots.txt contents to a parent site.	2018-04-16 15:43:20 -04:00
Joffrey JAFFEUX	a4a0b8e922	fix spec	2018-04-16 13:40:44 +02:00
Joffrey JAFFEUX	06b6c805d5	dashboard next: adds report for user types	2018-04-16 13:03:43 +02:00
Maja Komel	3d99726981	FIX: set notification level when changing post owner (#5616 ) FIX: do not notify last post editor if they mention themself	2018-04-16 11:48:06 +02:00
Arpit Jalan	a1ef455c78	SECURITY: do not show private topic title on /unsubscribed page	2018-04-16 10:35:57 +05:30
Arpit Jalan	0183656631	FIX: verify filtered tags when checking for category minimum required tags	2018-04-14 23:20:43 +05:30
Neil Lalonde	06022d042c	fix failing spec user_profile_spec	2018-04-13 10:32:28 -04:00
Sam	3632b8d8d6	FEATURE: provide extra signal about content age to crawlers Adds Last-Modified field to help teach crawlers not to crawl old content	2018-04-13 14:58:33 +10:00
Arpit Jalan	00f59f648d	Merge pull request #5755 from techAPJ/flag-webhook FEATURE: webhook for flag events	2018-04-13 07:50:21 +05:30
Arpit Jalan	a16b616861	FEATURE: webhook for flag events	2018-04-13 07:47:58 +05:30
Régis Hanol	a0a06492d8	FIX: make get_hostname more lenient to user input	2018-04-12 17:09:09 +02:00
Gerhard Schlager	f042a9529b	FIX: users shouldn't get notifications about mentions from system users (unless the mentioned users are participants in a PM with the system user)	2018-04-12 16:19:44 +02:00
Régis Hanol	df7970a6f6	prefix the robots.txt rules with the directory when using subfolder	2018-04-11 22:05:02 +02:00
Régis Hanol	3c8b43bb01	FIX: non-oneboxed links on separate lines should stay on separate lines	2018-04-11 21:33:45 +02:00
Sam	bf2955cd98	stablize spec	2018-04-11 15:45:27 +10:00
Arpit Jalan	48d43b33cc	add client side validation for category minimum_required_tags	2018-04-11 07:17:52 +05:30
Arpit Jalan	9ca6ebe8fe	FEATURE: enforce tagging on categories	2018-04-11 07:15:24 +05:30
Joffrey JAFFEUX	45f657336e	FEATURE: adds support for loading existing core asset in pretty text	2018-04-10 08:37:16 +02:00
Guo Xiang Tan	874003b7b1	FIX: Group can't be deleted if certain users are demoted.	2018-04-10 14:19:35 +08:00
Sam	fe37ce165d	correct issue where groups was never being blanked	2018-04-10 15:30:18 +10:00
Sam	71d0035a7e	groups should be text to match add_group etc.	2018-04-10 13:47:07 +10:00
Sam	afaeb20f27	FEATURE: Add option to have sso synchronize group membership In some cases add_groups and remove_groups is too much work, some sites may wish to simply synchronize group membership based on a list. When sso_overrides_groups is on all not automatic group membership is sourced from SSO. Note if you omit to specify groups, they will be cleared out.	2018-04-10 13:17:23 +10:00
Guo Xiang Tan	d9d86577ff	FIX: Staff users are not affected by `enable_group_directory` site setting.	2018-04-10 09:22:01 +08:00
Gerhard Schlager	62aacce8f4	FEATURE: Notify flaggers when flagged post is edited by author	2018-04-09 16:45:33 +02:00
Guo Xiang Tan	c82b2dcc24	Remove admin group management pages.	2018-04-09 15:14:50 +08:00
osamasayegh	fe8301007c	Add spec + make it work with .raw templates	2018-04-09 16:47:28 +10:00
Sam	4111f17f64	add missing test for rel next/prev	2018-04-09 15:01:16 +10:00
Neil Lalonde	f6cfff3cea	UX: user preferences allows users to choose which title to use from their badges and groups	2018-04-06 14:34:36 -04:00
jose-hms	b87205831b	FEATURE: Staged user moderation (#5721 )	2018-04-06 11:41:25 +02:00
Guo Xiang Tan	0623785f69	FIX: Prevent group owners from editing admin only settings.	2018-04-06 11:44:58 +08:00
Guo Xiang Tan	eb755dd2a7	Fix the build.	2018-04-06 10:40:57 +08:00
Sam	3a7b696703	FEATURE: allow for setting crawl delay per user agent Also moved to default crawl delay bing so no more than a req every 5 seconds is allowed New site settings: "slow_down_crawler_user_agents" - list of crawlers that will be slowed down "slow_down_crawler_rate" - how many seconds to wait between requests Not enforced server side yet	2018-04-06 10:15:23 +10:00
Gerhard Schlager	56ca87bb01	Improve spec	2018-04-05 17:27:32 +02:00
Gerhard Schlager	cd6a99a027	FEATURE: Send a different PM when a post has been hidden more than once	2018-04-05 14:03:21 +02:00
Gerhard Schlager	f2d00e5eff	FEATURE: Use Message-ID for detecting email replies to group Ignores the site setting "find_related_post_with_key" and always tries to honor the `In-Reply-To` and `References` header for emails sent to a group. The senders email address must be included in the `To` or `CC` header of a previous email sent to the group and the `Message-ID` of that email must be included in the current email's `In-Reply-To` or `References` header.	2018-04-05 11:00:38 +02:00
Guo Xiang Tan	e36e9de28a	Allow admin to view logs of automatic groups.	2018-04-05 16:31:55 +08:00
Sam	f8637ed616	FIX: if a message is partially archived consider it not archived	2018-04-05 17:17:47 +10:00
Guo Xiang Tan	8760c4d68c	Fix `GroupsController#group_params` to allow more group attributes to be updated.	2018-04-05 13:53:00 +08:00
Arpit Jalan	10759677db	FIX: when uploading image newuser restrictions should not apply to staff	2018-04-05 09:51:03 +05:30
Vinoth Kannan	434cbc649f	FEATURE: Webhook for tag events	2018-04-04 17:49:20 +05:30
Arpit Jalan	b49f2bf7d9	fix false spec	2018-04-04 12:20:50 +05:30
Arpit Jalan	c36e201eb3	FIX: update categories topic_count when converting topic to a PM and vice versa	2018-04-04 12:01:56 +05:30
Robin Ward	d690ae0281	FIX: Broken specs too. Quotes are fragile!	2018-04-02 14:23:10 -04:00
Guo Xiang Tan	221503cd10	FIX: Add server side uniqueness validations for `Group#name` and `User#username`. https://meta.discourse.org/t/groups-can-be-given-same-name-as-existing-username/74010	2018-04-02 18:19:18 +08:00

... 16 17 18 19 20 ...

6650 Commits