dependabot[bot]
2ebfadd973
Build(deps-dev): Bump rubocop-capybara from 2.19.0 to 2.20.0 ( #25124 )
...
Bumps [rubocop-capybara](https://github.com/rubocop/rubocop-capybara ) from 2.19.0 to 2.20.0.
- [Release notes](https://github.com/rubocop/rubocop-capybara/releases )
- [Changelog](https://github.com/rubocop/rubocop-capybara/blob/main/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop-capybara/compare/v2.19.0...v2.20.0 )
---
updated-dependencies:
- dependency-name: rubocop-capybara
dependency-type: indirect
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-01-03 22:54:01 +01:00
dependabot[bot]
4767eeda68
Build(deps): Bump sass-embedded from 1.69.6 to 1.69.7 ( #25123 )
...
Bumps [sass-embedded](https://github.com/sass-contrib/sass-embedded-host-ruby ) from 1.69.6 to 1.69.7.
- [Commits](https://github.com/sass-contrib/sass-embedded-host-ruby/compare/v1.69.6...v1.69.7 )
---
updated-dependencies:
- dependency-name: sass-embedded
dependency-type: indirect
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-01-03 22:46:58 +01:00
dependabot[bot]
ae0ecbe9cb
Build(deps): Bump puma from 6.4.0 to 6.4.1 ( #25120 )
...
Bumps [puma](https://github.com/puma/puma ) from 6.4.0 to 6.4.1.
- [Release notes](https://github.com/puma/puma/releases )
- [Changelog](https://github.com/puma/puma/blob/master/History.md )
- [Commits](https://github.com/puma/puma/compare/v6.4.0...v6.4.1 )
---
updated-dependencies:
- dependency-name: puma
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-01-03 22:46:46 +01:00
dependabot[bot]
d5c2321f8e
Build(deps-dev): Bump sass from 1.69.6 to 1.69.7 in /app/assets/javascripts ( #25118 )
...
* Build(deps-dev): Bump sass in /app/assets/javascripts
Bumps [sass](https://github.com/sass/dart-sass ) from 1.69.6 to 1.69.7.
- [Release notes](https://github.com/sass/dart-sass/releases )
- [Changelog](https://github.com/sass/dart-sass/blob/main/CHANGELOG.md )
- [Commits](https://github.com/sass/dart-sass/compare/1.69.6...1.69.7 )
---
updated-dependencies:
- dependency-name: sass
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
* Update lockfiles for ember version flag
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: discoursebuild <build@discourse.org>
2024-01-03 22:45:51 +01:00
dependabot[bot]
e0f9f62e4c
Build(deps): Bump excon from 0.108.0 to 0.109.0 ( #25121 )
...
Bumps [excon](https://github.com/excon/excon ) from 0.108.0 to 0.109.0.
- [Changelog](https://github.com/excon/excon/blob/master/changelog.txt )
- [Commits](https://github.com/excon/excon/compare/v0.108.0...v0.109.0 )
---
updated-dependencies:
- dependency-name: excon
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-01-03 22:44:53 +01:00
dependabot[bot]
b397dca417
Build(deps-dev): Bump shoulda-matchers from 2a2b062 to d611911 ( #25122 )
...
Bumps [shoulda-matchers](https://github.com/thoughtbot/shoulda-matchers ) from `2a2b062` to `d611911`.
- [Release notes](https://github.com/thoughtbot/shoulda-matchers/releases )
- [Commits](2a2b06276f...d611911f01
2024-01-03 22:44:31 +01:00
Isaac Janzen
c689eeef31
FIX: move-topics topic search losing focus ( #25116 )
...
- [Meta Report](https://meta.discourse.org/t/moving-posts-the-input-focus-shifts-when-searching-for-a-topic-to-move-a-post-to-as-typing/284924/1 )
### Correct Focus kept during Search
https://github.com/discourse/discourse/assets/50783505/ae9b4480-208e-470a-98c4-5ba10a053eb7
### Search Log after search
<img width="430" alt="Screenshot 2024-01-03 at 11 08 08 AM" src="https://github.com/discourse/discourse/assets/50783505/155f413a-adc1-4e59-a74b-dcef7af01990 ">
2024-01-03 14:21:43 -07:00
Rafael dos Santos Silva
46777b379e
Revert "DEV: Remove precompiled protobuf requirement for Ruby 3.3 compatibility ( #25115 )" ( #25117 )
...
This reverts commit 0546b4622a
2024-01-03 16:07:14 -03:00
Isaac Janzen
1f94da349b
DEV: Make the Glimmer Search Menu the new default ( #25092 )
...
- Convert group based `experimental_search_menu_groups_enabled` site setting to be a _hidden_ boolean `experimental_search_menu` setting.
- Make default `true`
- Remove widget search menu tests
Discourse Encrypt Test Failure Fix - https://github.com/discourse/discourse-encrypt/pull/301
2024-01-03 09:07:27 -07:00
Jan Cernik
117611ea82
FIX: 500 error when reviewable has a missing message ( #25113 )
2024-01-03 11:49:54 -03:00
Rafael dos Santos Silva
0546b4622a
DEV: Remove precompiled protobuf requirement for Ruby 3.3 compatibility ( #25115 )
2024-01-03 11:48:41 -03:00
David Taylor
0cf4870cfb
DEV: Upgrade from Ember 5.4 to 5.5 ( #25114 )
...
This change only applies when EMBER_VERSION=5. Discourse's default is still Ember 3.28
2024-01-03 14:42:42 +00:00
Arpit Jalan
4bf60b3e5b
FEATURE: include username link in the microdata schema ( #25112 )
2024-01-03 20:11:41 +05:30
Godfrey Chan
9ac3961f23
DEV: patch @ember/test-helpers ( #24896 )
...
Mainly we are after https://github.com/emberjs/ember-test-helpers/pull/1445
so the Ember 5 test suite doesn't fail on canary, but also took
some code from https://github.com/emberjs/ember-test-helpers/pull/1378
as needed to make the code make sense.
2024-01-03 14:29:07 +00:00
Jordan Vidrine
8dad9788a3
FIX: Drop down fix ( #25093 )
2024-01-03 08:02:32 -06:00
David Taylor
07caa5bc03
FEATURE: Show warning banner for critical JS deprecations to admins ( #25091 )
...
Ported from d95706b25a
2024-01-03 11:41:09 +00:00
Jarek Radosz
b9f6e6d637
DEV: Skip flaky specs ( #25111 )
...
Dynamically adding and removing deprecated or TL-related site settings in specs is leaky
2024-01-03 12:32:26 +01:00
David Taylor
6e7356e7c3
DEV: Add production-mode shim for Em deprecation ( #25109 )
2024-01-03 10:39:59 +00:00
David Taylor
451581d50a
DEV: Remove unmaintained tidy-jsdoc dependency ( #25110 )
...
This was used by chat's HTML documentation experiment. That documentation experiment isn't being actively used/updated, but may be revisited in future. Therefore, this commit updates the jsdoc config to remove the custom theme, but keeps it functional (with the default jsdoc theme).
2024-01-03 10:30:54 +00:00
dependabot[bot]
6a60fe5ac1
Build(deps-dev): Bump the embroider group in /app/assets/javascripts with 1 update ( #25024 )
...
* Build(deps-dev): Bump the embroider group
Bumps the embroider group in /app/assets/javascripts with 1 update: [@embroider/compat](https://github.com/embroider-build/embroider/tree/HEAD/packages/compat ).
Updates `@embroider/compat` from 3.4.2 to 3.4.3
- [Release notes](https://github.com/embroider-build/embroider/releases )
- [Changelog](https://github.com/embroider-build/embroider/blob/main/CHANGELOG.md )
- [Commits](https://github.com/embroider-build/embroider/commits/HEAD/packages/compat )
---
updated-dependencies:
- dependency-name: "@embroider/compat"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: embroider
...
Signed-off-by: dependabot[bot] <support@github.com>
* Update lockfiles for ember version flag
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: discoursebuild <build@discourse.org>
2024-01-03 10:24:05 +01:00
Martin Brennan
e8deed874b
FIX: Do not allow setting admin and staff for TrustLevelSetting ( #25107 )
...
This fixes an issue where any string for an enum site setting
(such as TrustLevelSetting) would be converted to an integer
if the default value for the enum was an integer. This is an
issue because things like "admin" and "staff" would get silently
converted to 0 which is "valid" because it's TrustLevel[0],
but it's unexpected behaviour. It's best to just let the site
setting validator catch this broken value.
2024-01-03 16:55:28 +10:00
Martin Brennan
4e6d4193ea
DEV: Fix spec for post menu ( #25100 )
...
Followup to b92993fcee
2024-01-03 16:55:08 +10:00
Arpit Jalan
69383e9afd
FIX: include only author username in the schema ( #25106 )
2024-01-03 12:16:29 +05:30
Alan Guo Xiang Tan
5530cb574b
DEV: Fix test incorrectly removing stylesheet cache of other processes ( #25103 )
...
Why this change?
The `can survive cache miss` test in `spec/requests/stylesheets_controller_spec.rb`
was failing because the file was not found on disk for the cache to be
regenerated. This is because a test in
`spec/lib/stylesheet/manager_spec.rb` was removing the entire
`tmp/stylesheet-cache` directory which is incorrect because the folder
in the test environment further segretates the stylesheet caches based
on the process of the test.
What does this change do?
1. Introduce `Stylesheet::Manager.rm_cache_folder` method for the test
environment to properly clean up the cache folder.
2. Make `Stylesheet::Manager::CACHE_PATH` a private constant since the
cache path should be obtained from the `Stylesheet::Manager.cache_fullpath` method.
2024-01-03 13:15:35 +08:00
Alan Guo Xiang Tan
1a423f3c2d
DEV: Enable query_log_tags_enabled in the test environment ( #25104 )
...
Why this change?
When logging ActiveRecord query logs in the test environment, we want to
include more runtime information about the SQL statement as well.
See
https://guides.rubyonrails.org/debugging_rails_applications.html#verbose-query-logs
for more details
2024-01-03 13:11:16 +08:00
Arpit Jalan
fb056ae719
FIX: add required metadata schema for subsequent pages ( #25102 )
...
This commits adds missing metadata schema for subsequent pages (?page=2)
https://meta.discourse.org/t/discussion-forum-schema-improvements/287347/21
2024-01-03 09:37:04 +05:30
Natalie Tay
dc263b5189
FIX: Syntax error ( #25101 )
2024-01-03 11:01:42 +08:00
Ted Johansson
a0fbce996a
FEATURE: Buffer file names of failed uploads when bulk uploading ( #25068 )
...
Currently, when bulk uploading and multiple uploads fail, we show a number of dialogs in quick succession. This is of course a terrible user experience.
With this change, we buffer the error messages until there are no more pending uploads. Then we combine the buffered errors and display a single dialog with a list of failed files.
2024-01-03 10:29:23 +08:00
Kelv
b4a89ea610
FEAT: add cc addresses and post_id to sent email logs ( #25014 )
...
* add cc addresses and post_id to sent email logs
* sort cc addresses by email address filter value and collapse additional addreses into tooltip
* add slice helper for use in ember tempaltes
2024-01-03 09:27:25 +08:00
Sam
7b12be866d
FIX: never skip push notifications ( #25099 )
...
* FIX: never skip push notifications
According to Apple, silent push notifications are automatically punished per:
https://developer.apple.com/videos/play/wwdc2022/10098/?time=814
> As mentioned when I showed you the code on how to request a push
> subscription, you must promise that pushes will be user visible.
> Handling a push event is not an invitation for your JavaScript to
> get silent background runtime. Doing so would violate both a user’s
> trust and a user’s battery life. When handling a push event, you are
> in fact required to post a notification to Notification Center.
> Other browsers all have countermeasures against violating the promise
> to make pushes user visible, and so does Safari.
> In the beta build of macOS Ventura, after three push events where you
> fail to post a notification in a timely manner, your site’s push
> subscription will be revoked. You will need to go through the permission
> workflow again.
The isIdle check was causing certain push notifications to be silent
Additionally, the auto dismissal logic was causing delays which may cause
the device to think the push was a silent one.
By removing this we hope to ensure push notification delivery is more robust
and consistent on iOS.
2024-01-03 12:23:04 +11:00
Kris
e8509ddf50
FIX: github onebox styles for commits ( #25098 )
2024-01-02 17:29:56 -05:00
Kris
f999cde159
UX: update post background highlight ( #25094 )
2024-01-02 16:53:40 -05:00
Kris
c2dc2cd727
UX: add gap between category and tags in suggested topics ( #25097 )
2024-01-02 16:40:35 -05:00
dependabot[bot]
cee446f62a
Build(deps-dev): Bump shoulda-matchers from b8d04ee to 2a2b062 ( #25096 )
...
Bumps [shoulda-matchers](https://github.com/thoughtbot/shoulda-matchers ) from `b8d04ee` to `2a2b062`.
- [Release notes](https://github.com/thoughtbot/shoulda-matchers/releases )
- [Commits](b8d04ee4c5...2a2b06276f
2024-01-02 22:40:23 +01:00
Isaac Janzen
4886c1fddc
DEV: Update when / how we display of full name on search-item-user ( #25090 )
...
- Full name should only be displayed within `initial options`
- Keep results on a single line unless full name is included
# Initial Options
<img width="416" alt="Screenshot 2024-01-02 at 9 58 07 AM" src="https://github.com/discourse/discourse/assets/50783505/a9f6880a-86e0-4683-978a-c0391a90c78e ">
# Other
<img width="432" alt="Screenshot 2024-01-02 at 9 58 43 AM" src="https://github.com/discourse/discourse/assets/50783505/83b508b0-c501-4fb7-89f7-8e66dc88979f ">
<img width="424" alt="Screenshot 2024-01-02 at 9 58 18 AM" src="https://github.com/discourse/discourse/assets/50783505/b98223d7-f92c-4803-87bf-0470e6ce05ed ">
2024-01-02 10:26:40 -07:00
Discourse Translator Bot
8e1fc93748
Update translations ( #25088 )
2024-01-02 15:25:58 +01:00
Arpit Jalan
878d973d90
FIX: fixes for microdata schema rendering ( #25082 )
...
d9ca6c3bb9 (r135940042)
2024-01-02 19:23:57 +05:30
David Taylor
7d0e0c3110
DEV: Collect css assets from webpack build ( #25087 )
...
fb95ab8e00
2024-01-02 12:45:34 +00:00
dependabot[bot]
37127ec141
Build(deps): Bump the babel group in /app/assets/javascripts with 2 updates ( #25075 )
...
* Build(deps): Bump the babel group
Bumps the babel group in /app/assets/javascripts with 2 updates: [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core ) and [@babel/standalone](https://github.com/babel/babel/tree/HEAD/packages/babel-standalone ).
Updates `@babel/core` from 7.23.6 to 7.23.7
- [Release notes](https://github.com/babel/babel/releases )
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md )
- [Commits](https://github.com/babel/babel/commits/v7.23.7/packages/babel-core )
Updates `@babel/standalone` from 7.23.6 to 7.23.7
- [Release notes](https://github.com/babel/babel/releases )
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md )
- [Commits](https://github.com/babel/babel/commits/v7.23.7/packages/babel-standalone )
---
updated-dependencies:
- dependency-name: "@babel/core"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: babel
- dependency-name: "@babel/standalone"
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: babel
...
Signed-off-by: dependabot[bot] <support@github.com>
* Update lockfiles for ember version flag
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: discoursebuild <build@discourse.org>
2024-01-02 11:51:42 +01:00
David Taylor
34ae2080c6
DEV: Merge mobile/desktop navigation-bar templates ( #25017 )
...
Having separate mobile/desktop templates is something we're moving away from. This commit moves the mobile-specific logic into a conditional in the main colocated template.
2024-01-02 10:48:31 +00:00
David Taylor
fb95ab8e00
DEV: Use webpack to load table-builder dependencies ( #25018 )
...
This avoids the need to vendor the JS/CSS in our git repository
2024-01-02 10:47:47 +00:00
David Taylor
e47ad13122
DEV: Colocate mobile-nav template ( #25016 )
...
Previously it was relying on the `templates/mobile` logic to make this a simple div wrapper on mobile, and a more complex implementation on mobile. This commit colocates the template so it's active on mobile and desktop, but adds an `{{#if` block to explicitly change the behavior.
2024-01-02 10:47:21 +00:00
David Taylor
236f3cc6eb
UX: Add 'edit' link to theme colour palette selector ( #25073 )
2024-01-02 10:45:52 +00:00
David Taylor
641c689ac1
DEV: Patch deprecated-run-loop-and-computed-dot-access in production ( #25074 )
...
In Ember, these deprecations are wrapped in an `if(DEBUG)` check, so they are optimized out of the production build. We prefer to keep deprecations in production so that we can collect telemetry and warn theme authors who do not use local development environments.
This commit restores the deprecations as part of our ember-production-deprecations addon.
2024-01-02 10:44:26 +00:00
Natalie Tay
b4f36507e0
FIX: Allow the flags to be cleaned up ( #25085 )
...
Currently, the reviewable queue includes ReviewableFlaggedPost with posts that have already been hidden. This allows for such hidden posts to be cleared up by the auto-tool.
2024-01-02 18:32:50 +08:00
Martin Brennan
b92993fcee
FIX: Post copy link not working ( #25086 )
...
Followup to c6cb319671
2024-01-02 19:23:41 +10:00
Alan Guo Xiang Tan
6b8e051e73
DEV: Update Rails to 7.0.8 ( #25084 )
...
See https://github.com/rails/rails/releases/tag/v7.0.8
2024-01-02 10:19:08 +08:00
dependabot[bot]
a2e4cc0903
Build(deps-dev): Bump sass from 1.69.5 to 1.69.6 in /app/assets/javascripts ( #25076 )
...
* Build(deps-dev): Bump sass in /app/assets/javascripts
Bumps [sass](https://github.com/sass/dart-sass ) from 1.69.5 to 1.69.6.
- [Release notes](https://github.com/sass/dart-sass/releases )
- [Changelog](https://github.com/sass/dart-sass/blob/main/CHANGELOG.md )
- [Commits](https://github.com/sass/dart-sass/compare/1.69.5...1.69.6 )
---
updated-dependencies:
- dependency-name: sass
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
* Update lockfiles for ember version flag
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: discoursebuild <build@discourse.org>
2024-01-02 08:43:40 +08:00
dependabot[bot]
187d5c7b0d
Build(deps-dev): Bump shoulda-matchers from 4886266 to b8d04ee ( #25077 )
...
Bumps [shoulda-matchers](https://github.com/thoughtbot/shoulda-matchers ) from `4886266` to `b8d04ee`.
- [Release notes](https://github.com/thoughtbot/shoulda-matchers/releases )
- [Commits](48862663f8...b8d04ee4c5
2024-01-02 08:43:24 +08:00
dependabot[bot]
a9ee94c818
Build(deps): Bump sassc-embedded from 1.68.6 to 1.69.1 ( #25079 )
...
Bumps [sassc-embedded](https://github.com/sass-contrib/sassc-embedded-shim-ruby ) from 1.68.6 to 1.69.1.
- [Commits](https://github.com/sass-contrib/sassc-embedded-shim-ruby/compare/v1.68.6...v1.69.1 )
---
updated-dependencies:
- dependency-name: sassc-embedded
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-01-02 08:40:54 +08:00
