Commit Graph

8016 Commits

Author SHA1 Message Date
Sam
5942ad83c0 Skip inline onebox for domain only 2017-08-02 17:27:58 -04:00
Sam
902be91a5a FEATURE: CTRL+/ to trigger search even from composer 2017-08-02 16:26:03 -04:00
Sam
a4e1920604 FIX: inline oneboxer not applying to lists 2017-08-02 16:10:08 -04:00
Erick Guan
468a8fcd20 FEATURE: Site settings defaults per locale
This change-set allows setting different defaults for different locales. 

It also:

- Adds extensive testing around site setting validation

- raises deprecation error if site setting has the default property based on env

- relocated site settings for dev and tests in the initializer

- deprecated client_setting in the site setting's loading process

- ensure it raises when a enum site setting being set

- default_locale is promoted to `required` category.

- fixes incorrect default setting and validation

- fixes ensure type check for site settings

- creates a benchmark for site setting

- sets reasonable defaults for Chinese
2017-08-02 12:24:19 -04:00
Neil Lalonde
be30d4510a FIX: change email success message container was too narrow 2017-08-02 10:50:18 -04:00
Neil Lalonde
47fa536f46 FIX: plugin outlet in user preferences nav needs to be li tag 2017-08-02 10:05:11 -04:00
Guo Xiang Tan
1c80c233cf FIX: Adding group owners returns 400 error. 2017-08-02 19:18:41 +09:00
Robin Ward
53e78edbef Silence ESLint 2017-08-01 17:26:49 -04:00
Robin Ward
8dd7c0c984 UX: Convert buttons to d-button 2017-08-01 17:24:06 -04:00
Robin Ward
75d10a4098 UX: Add consistent classes to buttons 2017-08-01 17:24:06 -04:00
Robin Ward
513b7bf706 REFACTOR: DRY up New Topic button code 2017-08-01 15:04:07 -04:00
Neil Lalonde
fa3c240e8b Merge pull request #4981 from dmacjam/fix_limited_search_results
FIX: limited search results
2017-07-31 20:23:57 -04:00
Neil Lalonde
ec85b41078 UX: Move watched words to the Logs section of admin 2017-07-31 17:06:50 -04:00
Robin Ward
ce27783da4 UX: Add new plugin outlet before reply count 2017-07-31 16:50:25 -04:00
Neil Lalonde
7c1d7fb423 Merge branch 'master' into fix_limited_search_results 2017-07-31 15:55:31 -04:00
Neil Lalonde
4a5907b116 Merge branch 'master' into search_posts_with_images 2017-07-31 10:44:41 -04:00
Robin Ward
31deebc8e6 FIX: Extra < character after icon refactor 2017-07-31 10:18:56 -04:00
Jakub Macina
f8edf2636c Fix rspec tests for search pagination. 2017-07-31 12:16:23 +02:00
Guo Xiang Tan
83bb042311 FIX: Group#visibility_level isn't shown in admin group edit page. 2017-07-31 16:34:22 +09:00
jomaxro
65c4e81bb2 Add placeholder text to group member add field 2017-07-30 23:52:46 -04:00
Robin Ward
307311fdb1 Add class to admin wrench button 2017-07-28 16:38:10 -04:00
Robin Ward
15fa514791 Add classes to notification dropdown buttons 2017-07-28 16:35:14 -04:00
Robin Ward
67556e6381 REFACTOR: Category / Tag Dropdown headers had extra classes 2017-07-28 16:19:33 -04:00
Robin Ward
e4c2b5e430 REFACTOR: CSS improvements to improve targetting and remove !important 2017-07-28 15:52:57 -04:00
Sam
a13d146251 Correct post deletion spec so it is async 2017-07-28 10:50:18 -04:00
Sam
64d54bc549 FIX: when quoting add a newline
so **highlight** > quote

Does not end like:

[quote]
test
[quote]~
2017-07-28 10:49:49 -04:00
Sam
ae68795d82 FIX: deleting own post results in error 2017-07-28 10:14:11 -04:00
Guo Xiang Tan
4620dfe92d FEATURE: Add group settngs to allow users to leave a group freely.
https://meta.discourse.org/t/split-join-leave-freely-setting-on-groups/65565
2017-07-28 15:00:25 +09:00
Robin Ward
ff4e295c4f FIX: Notifications dropdown had incorrect spacing 2017-07-27 19:22:19 -04:00
Sam
4f574e7c93 FEATURE: support inline bbcode blocks eg: [quote]test[/quote] 2017-07-27 17:55:17 -04:00
Robin Ward
c3b7419a08 UX: Remove hidden from the #discourse-modal when the modal is shown 2017-07-27 17:14:41 -04:00
Robin Ward
1b1fd64639 FIX: Badge icons disappeared 2017-07-27 16:57:26 -04:00
Robin Ward
41afd9c818 Bump Plugin API version for icon api 2017-07-27 15:13:03 -04:00
Robin Ward
5b590b9637 REFACTOR: Replace some fa-* uses with helpers 2017-07-27 14:55:41 -04:00
Robin Ward
d0c41a578e Rename {{fa-icon}} to {{d-icon}} so it can be more generic 2017-07-27 14:55:41 -04:00
Neil Lalonde
68b3dd43ce fix intermittent failing tests, some watched word refactoring 2017-07-27 12:27:01 -04:00
Robin Ward
32c9ad6f7f FIX: Wizard was broken 2017-07-27 10:48:31 -04:00
Guo Xiang Tan
75374c76b3 UX: Display button to message group on group page.
https://meta.discourse.org/t/make-it-easier-to-send-a-message-to-groups/65065
2017-07-27 17:51:25 +09:00
Guo Xiang Tan
4d25d61e9c UX: Change group membership requests icons on groups pages.
https://meta.discourse.org/t/make-it-easier-to-send-a-message-to-groups/65065
2017-07-27 16:24:15 +09:00
Guo Xiang Tan
2442bba131 UX: Better group creation workflow.
* Owners and users can now be added to a group during creation.

https://meta.discourse.org/t/you-cannot-allow-membership-requests-without-any-owners/64760/3
2017-07-27 16:12:42 +09:00
Robin Ward
e87125b63c FEATURE: Plugins can overwrite and add support for new icons 2017-07-26 13:21:17 -04:00
Neil Lalonde
24cb950432 FEATURE: Watched Words: when posts contain words, do one of flag, require approval, censor, or block 2017-07-26 11:01:09 -04:00
David Taylor
27539e15e1 Allow whitespace around % scaler in markdown image syntax (#5000) 2017-07-26 10:54:20 -04:00
Neil Lalonde
ea0e90b2b0 Merge branch 'master' into search_posts_with_images 2017-07-26 10:15:55 -04:00
David Taylor
febd7621ea Qunit plugin rake tasks (#4985)
* Allow running specific plugin tests using ENV variables

* Add a `rake plugin:qunit` task to match the existing `rake plugin:spec` task

* Improve docker.rake to allow running specific plugin qunit tests

* Purge cache before and after qunit tests

* Stop module auto-loader trying to auto-load tests

* Use URL query parameters to pass config into Qunit, avoiding caching issues

* Oops, searchParams doesn’t work in phantomJS. Parse the URL manually.

* Escape ampersands before passing URL to phantomJS, otherwise multiple parameters go wrong
2017-07-26 09:07:46 -04:00
Guo Xiang Tan
f9627f4533 UX: Don't show empty user list for groups without members. 2017-07-26 16:11:06 +09:00
Sam
17d56a4cb7 FEATURE: use Markdown for image pasted in as opposed to IMG tags 2017-07-25 15:11:38 -04:00
Robin Ward
f2e592c1ab UX: Apply btn-flat class to flat buttons on posts 2017-07-25 12:00:19 -04:00
Robin Ward
3152eabbb0 UX: Use flat button style for bulk selection 2017-07-25 12:00:19 -04:00
Robin Ward
5da848088a UX: Refactor composer buttons into flat buttons 2017-07-25 12:00:19 -04:00
Guo Xiang Tan
601064a95a Remove stray debugger. 2017-07-25 22:51:47 +09:00
Guo Xiang Tan
bdf1be65a3 FIX: Broken topic invite button. 2017-07-25 22:48:10 +09:00
Jakub Macina
2d45b3fc6d Add infinite loading to full page search. 2017-07-25 15:33:25 +02:00
Joffrey JAFFEUX
8556d3c27f FIX: emoji-picker do not reload all everything when changing diversity 2017-07-25 12:23:38 +02:00
Joffrey JAFFEUX
22c5fb20b4 FIX: emoji-picker broken and skipped specs 2017-07-25 12:23:38 +02:00
Sam
4da98cdcfe FIX: allow bbcode to be unquoted for default 2017-07-24 18:36:17 -04:00
Neil Lalonde
25097deb39 FIX: saving profile preferences removes name in account preferences 2017-07-24 13:13:50 -04:00
Sam
40abcfc2f5 FIX: smart quote edge case with quotes 2017-07-24 12:21:49 -04:00
Joffrey JAFFEUX
d9696c98c3 FIX: broken spec 2017-07-24 13:59:36 +02:00
Joffrey JAFFEUX
995d253030 FIX: improves efficiency 2017-07-24 12:42:54 +02:00
Guo Xiang Tan
1b0750d7ef Merge pull request #4983 from tgxworld/group_owners_can_invite_users_to_groups
Group owners can invite users to groups
2017-07-24 16:21:19 +09:00
Guo Xiang Tan
6593f0355f FIX: Exclude www in topic map links.
https://meta.discourse.org/t/topic-popular-links-panel-domain-extraction-doesnt-handle-country-tlds/60156/38?u=tgxworld
2017-07-24 10:14:33 +09:00
Guo Xiang Tan
887c3b66f5 Revert "UX: Don't try to figure out root domain."
This reverts commit 7690cc6ca5.
2017-07-24 09:40:57 +09:00
Régis Hanol
65ab5f58fe FIX: keep newlines between paragraphs when quoting a post 2017-07-23 15:25:28 +02:00
Joffrey JAFFEUX
f68e711fb2 FIX: makes emoji filter case insensitive 2017-07-22 22:48:22 +02:00
Joffrey JAFFEUX
e2e0221dd7 FIX: make sure there are meaningful titles on the picker 2017-07-22 17:32:12 +02:00
Robin Ward
bc3a32385c FIX: Empty lines should be selected for block quotes 2017-07-21 16:32:29 -04:00
Sam
9b4f5710e6 api cleanup for before / after rules 2017-07-21 16:12:11 -04:00
Joffrey JAFFEUX
bb35d9fc07 FIX: do not restore scroll on successive click on the same first emoji 2017-07-21 21:42:23 +02:00
Arpit Jalan
9727977fef Fix the build. 2017-07-22 00:34:39 +05:30
Joffrey JAFFEUX
8c17596aa5 FIX: keep scroll position when adding first recent emoji 2017-07-21 20:57:17 +02:00
Joffrey JAFFEUX
cdefb58018 FIX: emoji-picker filtering false positive 2017-07-21 20:42:34 +02:00
Arpit Jalan
6d09fbde44 UX: use down chevron icon to expand "show more links.." 2017-07-22 00:10:37 +05:30
Joffrey JAFFEUX
c2db2c5c78 FIX: do not store scroll position in local storage 2017-07-21 20:18:32 +02:00
Joffrey JAFFEUX
d5f53da43f FIX: filtered emojis now correctly include custom emojis 2017-07-21 19:46:40 +02:00
Joffrey JAFFEUX
e36d9f55c3 replaces links/imgs by buttons in the emoji-picker 2017-07-21 19:42:50 +02:00
Sam
e1ce47a901 Pass the full CommonMark spec 2017-07-21 13:20:52 -04:00
Robin Ward
aa5b8a5749 REFACTOR: Merge onebox and inline onebox code paths 2017-07-21 13:12:30 -04:00
Guo Xiang Tan
2a17f1ccd7 FIX: Group owners should be able to invite users to their groups.
https://meta.discourse.org/t/group-owner-cannot-send-an-invite-to-a-group/60617/12
2017-07-21 23:48:25 +09:00
Joffrey JAFFEUX
c7f2b0fe58 tweaks to copy and styles 2017-07-21 14:19:04 +02:00
Joffrey JAFFEUX
79c8b505e8 FIX: faster successive loading of emojis 2017-07-21 14:18:02 +02:00
Joffrey JAFFEUX
1ce1953ee1 FIX: makes sure we don’t track when clicking on recent emojis 2017-07-21 13:35:55 +02:00
Joffrey JAFFEUX
c906bd3f22 emoji-picker refactoring 2017-07-21 13:35:29 +02:00
Joffrey JAFFEUX
1ca0c33802 FIX: dot not close emoji-picker when click is inside picker 2017-07-21 12:01:39 +02:00
Joffrey JAFFEUX
0c9ea1aaf2 reduce emoji loading threshold 2017-07-21 11:46:34 +02:00
Jakub Macina
44bd8f3837 Add info about more results to full-page search frontend. 2017-07-21 09:35:04 +02:00
Robin Ward
657e592a39 FIX: Oneboxes were not being previewed 2017-07-20 17:12:54 -04:00
Robin Ward
3882722195 FEATURE: Inline (Mini) Oneboxing
see:
https://meta.discourse.org/t/mini-inline-onebox-support-rfc/66400?source_topic_id=66066
2017-07-20 15:38:04 -04:00
Sam
44fb2a2833 DEV: support multiple capture groups for text post process 2017-07-20 15:33:44 -04:00
Joffrey JAFFEUX
d7a20c8e93 FIX: Object.assign is not supported in all browsers 2017-07-20 20:27:59 +02:00
Joffrey JAFFEUX
ac6413f456 FIX: broken specs 2017-07-20 20:08:11 +02:00
Sam
1096dcd602 correct bbcode parsing edge case 2017-07-20 13:02:40 -04:00
Sam
0791d740a6 FIX: only highlight exact word matches in results
- also fixes phrase highlighting
2017-07-20 12:26:46 -04:00
Sam
911ffbb98c Correct mention edge cases
@sam. was not correctly detected as a mention
2017-07-20 11:52:38 -04:00
Joffrey JAFFEUX
a9ab3f9ef0 FIX: emoji-picker positioning glitches on few edge cases 2017-07-20 17:03:45 +02:00
Joffrey JAFFEUX
a5a3651cf3 FIX: improves emoji-picker handling of its different states
- closing modal with escape
- using modal less frequently
- closing the picker by clicking anywhere
2017-07-20 16:08:25 +02:00
Joffrey JAFFEUX
739794f0cb resets img src before changing it 2017-07-19 23:24:50 +02:00
Joffrey JAFFEUX
26a7ae3750 increase time needed to load section in emoji-picker 2017-07-19 23:20:27 +02:00
Joffrey JAFFEUX
d27f744d16 refactor async code of the emoji-picker 2017-07-19 22:54:58 +02:00
Joffrey JAFFEUX
ce982d9935 enforce that emoji-picker is not active by default 2017-07-19 22:54:57 +02:00
Joffrey JAFFEUX
bb7241ccc2 simplify emoji-picker recent usage logic 2017-07-19 22:54:56 +02:00
Joffrey JAFFEUX
f32950a475 unbind div-resizing event 2017-07-19 22:54:55 +02:00
Joffrey JAFFEUX
bd0607b15b makes emoji-picker position more dynamic 2017-07-19 22:54:55 +02:00
Joffrey JAFFEUX
d238de87a4 FIX: infinite rebinding when filtering emojis 2017-07-19 22:54:53 +02:00
Joffrey JAFFEUX
69a52cca83 improve emoji picker filter style 2017-07-19 22:54:52 +02:00
Joffrey JAFFEUX
a1de26d614 more consistent positioning 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX
81c1cc4f22 should be a const 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX
33c1ce8d55 better scroll/touch handling on mobiles 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX
b3454b535f refactoring 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX
4ef52d5e88 correctly hide the picker 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX
8d91e7d493 pixel perfect position 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX
2322118d4f es-lint 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX
c99a5bce8f faster tests 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX
b83f430ef0 better positioning on mobile devices 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX
8cf7e614d9 move picker at top of the screen on mobile 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX
9956a58df0 uses es6 shorthands 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX
0b98bfe1dc function is not needed 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX
7739b2f53e reduces element search scope 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX
d992ef24ce emphasizes it's a jquery object 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX
b5c5c9c883 formating 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX
6ebdf86ec1 storing scroll position every 100 ms should be enough 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX
9a4dcd1a1c es-lint 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX
bd0e5b91c0 function is not needed 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX
f4c20472d2 refactoring 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX
80ff685148 disable modale escape for now 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX
60c0b5f0d2 bind hover only on desktop 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX
38be969727 do not apply touch start hack on emojis 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX
89573e3427 simplifying code 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX
03508b72b9 clarification 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX
6a4d74d9f8 performance/memory optimizations 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX
9664fd7302 fixes es-lint errors 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX
6de258d4cf FEATURE: Introduces new emoji-picker 2017-07-19 16:48:23 +02:00
Guo Xiang Tan
87a1ff15fd Treat URL as loaded when loading script with tag. 2017-07-19 10:25:13 +09:00
Sam
c7b0764089 correct more edge cases with new engine 2017-07-17 17:44:48 -04:00
Sam
8921058c67 FIX: medium URL with @ incorrectly handled as mention
Also:

- remove unused code
- rename bbcode_ruler to bbcode.ruler
- add md.core.textPostProcess.ruler to apply at end of chain (excluding links)
2017-07-17 17:44:48 -04:00
Robin Ward
29d529020b UX: Allow site settings to display as textareas if they like 2017-07-17 16:38:26 -04:00
Robin Ward
cdb3706025 Track clicks on topics in search results 2017-07-17 15:42:32 -04:00
Sam Saffron
d0c5205a52 Feature: Change markdown engine to markdown it
This commit removes the old evilstreak markdownjs engine.

- Adds specs to WhiteLister and changes it to stop using globals
    (Fixes large memory leak)
- Fixes edge cases around bbcode handling
- Removes mdtest which is no longer valid (to be replaced with
    CommonMark)
- Updates MiniRacer to correct minor unmanaged memory leak
- Fixes plugin specs
2017-07-17 11:41:34 -04:00
Guo Xiang Tan
2ddf2e0e95 FIX: Concurently loading deferred loading of a script incorrectly resolves the promise. 2017-07-17 14:41:46 +09:00
Guo Xiang Tan
d613f3f559 Fix guard against concurrently loading of assets. 2017-07-17 13:04:30 +09:00
Guo Xiang Tan
c5401a0927 Log errors when trying to load a markdown-it-bunlde.js. 2017-07-17 11:21:57 +09:00
Sam
79a084dd58 Revert "remove old markdown engine work-in-progress"
This reverts commit ee470b5317.
2017-07-12 18:10:51 -04:00
Sam
bcbb9f208d Revert "Integrate new engine, correct old specs"
This reverts commit f1b38ba4fb.
2017-07-12 18:10:07 -04:00
Sam
d609f8a53c Revert "correct more specs"
This reverts commit 40bcc6bbdc.
2017-07-12 18:10:05 -04:00
Sam
40bcc6bbdc correct more specs 2017-07-12 17:44:40 -04:00
Sam
f1b38ba4fb Integrate new engine, correct old specs
corrects edge cases with

- full quotes
- [url] with nested tags
- engine overrides
- onebox applying to non http srcs
2017-07-12 17:44:40 -04:00
Sam Saffron
ee470b5317 remove old markdown engine work-in-progress 2017-07-12 17:44:40 -04:00
Arpit Jalan
76981605fa FIX: don't raise error when inviting existing user to private topic via email
https://meta.discourse.org/t/inviting-existing-user-to-a-private-topic-message-via-email-shows-error-message/65994
2017-07-12 21:51:21 +05:30
Sam
98e03b04b5 Don't depend on imports for md extensions 2017-07-11 16:48:25 -04:00
Sam
5d139e461c FIX: multi option poll not working (new engine) 2017-07-11 14:43:34 -04:00