Guo Xiang Tan
d4aaa968bb
Fix linting.
2018-11-26 09:38:22 +08:00
Guo Xiang Tan
57e2f4990d
PERF: Move processing of inline onebox out of V8 context. ( #6658 )
2018-11-26 09:21:38 +08:00
Penar Musaraj
93d4281706
FIX: alignment issue in PM inbox when bulk selecting
2018-11-25 15:24:26 -05:00
Arpit Jalan
0ee822c550
remove unneeded variable assignment
2018-11-25 23:36:34 +05:30
Arpit Jalan
b5bf182ad5
FIX: validate topic deletion when acting on a flag
2018-11-25 23:24:03 +05:30
Régis Hanol
ed400a90fe
FIX: properly migrate polls/votes stored as array
2018-11-24 17:14:03 +01:00
David Taylor
a3ed570124
FIX: Fix routes ending in :username for usernames containing periods ( #6660 )
2018-11-23 17:41:41 +00:00
Régis Hanol
5142911012
FIX: auto-closing poll wasn't working
2018-11-23 17:42:57 +01:00
Bianca Nenciu
c38f7b240b
DEV: Fix build.
2018-11-23 17:34:50 +02:00
Bianca Nenciu
172b3bf4d3
FIX: Fix broken theme field URLs. ( #6622 )
2018-11-23 16:11:05 +01:00
Joe
336436dfb4
UX: better handling of logo size
2018-11-23 22:04:42 +08:00
Régis Hanol
f402d0d74f
FIX: couldn't delete users who voted on a poll
2018-11-23 11:45:53 +01:00
Régis Hanol
606faa2ee5
FIX: ensure poll options keep their order
2018-11-23 10:37:05 +01:00
Joe
e2214b50f3
UX: add height attribute to logo on error pages
...
This matches what we do in the home-logo widget. The height is set as an attribute and we use CSS to get a scaled width that preserves the aspect ratio of the image.
2018-11-23 15:04:34 +08:00
Guo Xiang Tan
a1888b301b
DEV: Don't require login for QUit test path.
2018-11-23 13:50:19 +08:00
Guo Xiang Tan
a19780d7a6
DEV: Don't expose wizard qunit route in production.
2018-11-23 13:49:31 +08:00
Sam
6d9d904df5
add missing newline to end of file
2018-11-23 15:43:27 +11:00
Sam
d7b0f0069c
no need to double strip this line
2018-11-23 14:48:02 +11:00
Sam
4c6eeaac15
Followup on 0739c3b1d1
...
This corrects some minor style issues
2018-11-23 14:43:52 +11:00
Joe
98354bd34c
fix the build
2018-11-23 11:27:59 +08:00
Joe
c4fca36255
FIX: don't trigger header:hide-topic at the bottom on desktops
...
On mobile we trigger `header:hide-topic` at the very bottom of topics to switch the header contents back from small logo + topic info to large logo + user panels.
Given that the `topic-progress` component is sometimes loaded on desktop - E.g composer is open or on narrow desktop screens - we need a guard to prevent this logic from firing on desktops.
2018-11-23 10:14:13 +08:00
Guo Xiang Tan
7f7464e3e6
DEV: Remove unused variable.
2018-11-23 08:32:29 +08:00
Sam
7ba681383d
DEV: run plugin tests in autospec
2018-11-23 11:27:08 +11:00
Joffrey JAFFEUX
f4432648fd
FIX: categories/delete_categories can be undefined ( #6657 )
2018-11-23 00:57:18 +01:00
Vinoth Kannan
06b3621e80
Revert "DEV: Use equal method instead of deepEqual"
...
This reverts commit 5969a31d73
2018-11-23 04:08:51 +05:30
Penar Musaraj
7fd9e9e320
Pin Prettier to 1.14.3
2018-11-22 15:51:04 -05:00
Vinoth Kannan
5969a31d73
DEV: Use equal method instead of deepEqual
2018-11-23 01:53:13 +05:30
David Taylor
f645cb9c14
FEATURE: Use translated name for 'your email has been authenticated by' ( #6649 )
2018-11-22 19:12:04 +00:00
Joffrey JAFFEUX
7e20a0b917
DEV: removes _.indexOf from codebase ( #6652 )
2018-11-22 17:38:58 +01:00
David Taylor
0083eec686
FEATURE: Allow logo URLs to be overridden easily using reopenWidget()
2018-11-22 16:29:12 +00:00
Joffrey JAFFEUX
3ff3bb6e2a
FIX: improves code, tests and utc handling of local-dates ( #6644 )
2018-11-22 17:19:24 +01:00
Joffrey JAFFEUX
56478166e5
FIX: broken badge groupings modal UI ( #6653 )
2018-11-22 17:09:45 +01:00
David Taylor
052bf37578
FIX: Use Discourse.deprecate instead of Rails.logger.warn
...
This will significantly reduce the volume of logs when the condition is hit
2018-11-22 15:59:47 +00:00
Joffrey JAFFEUX
2843944315
FIX: better alignment of badge selector and edit btn ( #6651 )
...
Input located at /admin/badges/new
2018-11-22 16:21:15 +01:00
Joffrey JAFFEUX
e77cc44f07
FIX: better alignment of groups header filters ( #6650 )
...
This is located at the top of the /groups page.
2018-11-22 16:18:02 +01:00
Kyle Zhao
80398d0b8f
Extract inline JS on embedded comments ( #6645 )
...
* use the meta refresh tag instead
* extract inline JS in embedded comment
2018-11-22 10:02:58 -05:00
David Taylor
1fd0787dd7
UX: Ensure unstyled .btn-social elements have a contrasting background
...
For example, in plugins where the background color is not explicitly set
2018-11-22 15:00:32 +00:00
Gerhard Schlager
2ef16e9f4e
FIX: Failed to delete post belonging to non-existent topic
2018-11-22 15:08:37 +01:00
Gerhard Schlager
bf27aecce2
REFACTOR: compact! works since the array can't contain empty strings
2018-11-22 13:27:34 +01:00
Arpit Jalan
60941f214c
FIX: remove unneeded keys from failed response
2018-11-22 14:59:50 +05:30
Guo Xiang Tan
96168cb3c6
DEV: Use a set in SiteSetting.settings_hash.
2018-11-22 17:16:40 +08:00
Guo Xiang Tan
4752ddc908
Avoid DB query when there are no mentions.
2018-11-22 16:44:17 +08:00
Guo Xiang Tan
a57baeec2a
Fix the build.
2018-11-22 16:37:24 +08:00
Guo Xiang Tan
28a6cf8228
FIX: Mention lookup should be case insensitive.
2018-11-22 16:32:56 +08:00
Guo Xiang Tan
3f636b2d19
FIX: Check whether group is mentionable by user when cooking post.
2018-11-22 16:16:33 +08:00
Sam
0739c3b1d1
DEV: this introduces a script capable of caching critical DNS locally
...
This is useful for cases where you want to add resiliency to DNS lookups
for redis and postgres, so they will continue to work even if there is
a DNS outage
2018-11-22 18:46:59 +11:00
Vinoth Kannan
036790d13c
FIX: Assign default value for category.findByIds method
2018-11-22 12:51:04 +05:30
Guo Xiang Tan
672e95bcb4
FIX: Staged users should not be mentionable.
2018-11-22 15:00:46 +08:00
Guo Xiang Tan
6111b285d9
DEV: Remove comment that links to a private topic.
...
Not going to be useful for other developers.
2018-11-22 14:55:02 +08:00
Guo Xiang Tan
c5a70eca6e
PERF: Move mention lookups out of the V8 context. ( #6640 )
...
We were looking up each mention one by one without any form of caching and that results
in a problem somewhat similar to an N+1. When we have to do alot of DB
lookups, it also increased the time spent in the V8 context which may
eventually lead to a timeout. The change here makes it such that mention lookups only does a single
DB query per post that happens outside of the V8 context.
2018-11-22 14:28:48 +08:00
