Joffrey JAFFEUX
a947b7b839
FIX: prevents registering multiple topic-notifications-button:changed ( #9356 )
...
A large topic page will always have the bottom tracking button, and will also have the timeline, meaning we already had 2 tracking events.
But it gets even worse when you know that the timeline button is a component connector which will trigger `didInsertElement` very frequently, meaning we were constantly adding more and more appEvents handlers.
2020-04-06 15:06:26 +02:00
Joffrey JAFFEUX
883901e4c0
FIX: do not attempt to deselect tags if filter is not empty ( #9345 )
2020-04-03 16:27:56 +02:00
Sam Saffron
cade4957ae
DEV: don't use _ cause property is observed
...
Followup on fcc5ef96
2020-04-02 10:22:13 +11:00
Sam Saffron
b8d2261db9
FIX: correctly load drafts based of id
...
Previously we relied on race conditions to correctly open a draft, so this
broke.
New code is deliberate.
Also corrects missing observers on composer action
2020-04-01 14:23:26 +11:00
Sam Saffron
fcc5ef9625
FIX: when switching reply type update options
...
Previously we were not correctly updating reply types leading to inconsistent
behavior when using drop down in composer (for reply type)
2020-03-31 14:40:57 +11:00
Joffrey JAFFEUX
fa5ba6beb8
FIX: ensures mini-tag-chooser display min tags req if no selection ( #9303 )
2020-03-30 19:34:53 +02:00
Vinoth Kannan
dbc323e12a
Fix the typo.
2020-03-25 23:32:32 +05:30
Robin Ward
07813c4a91
Convert select-kit from es6 to js ( #9246 )
...
* Convert select-kit from es6 to js
* Hide more git blames
2020-03-20 12:40:32 -04:00
Vinoth Kannan
aad12822b7
FEATURE: automatically delete replies on a topic after N days. ( #9209 )
2020-03-19 21:06:31 +05:30
Joffrey JAFFEUX
b727e39a42
DEV: gives sk components a way to trigger a search manually ( #9199 )
2020-03-13 12:41:08 +01:00
Joffrey JAFFEUX
683cb28099
DEV: enforces ember-template-lint: no-triple-curlies ( #9165 )
...
This pr replaces `{{{ }}}` usage by a {{html-safe}} helper. While it doesn't solve the underlying issue, it gives us a path forward without risking breaking too much existing behavior.
Also introduces an htmlSafe computed macro:
```
import { htmlSafe } from "discourse/lib/computed";
htmlDescription: htmlSafe("description")
```
Overtime {{html-safe}} usage should be removed and moved to components properties or specialized components/helpers.
2020-03-11 09:23:10 +01:00
Joffrey JAFFEUX
e848d98782
FIX: ensures category exists for hideParent in categoryBadgeHTML ( #9161 )
2020-03-11 00:58:46 +01:00
romanrizzi
f795c1b8e8
Revert "DEV: enforces ember-template-lint: no-triple-curlies ( #9150 )"
...
This reverts commit d436b600fb
2020-03-10 15:00:12 -03:00
Joffrey JAFFEUX
3f2c0b42fe
FIX: throttles topic tracking shortcut and enforces topic id ( #9159 )
2020-03-10 17:17:54 +01:00
Joffrey JAFFEUX
d436b600fb
DEV: enforces ember-template-lint: no-triple-curlies ( #9150 )
...
This pr replaces `{{{ }}}` usage by a {{html-safe}} helper. While it doesn't solve the underlying issue, it gives us a path forward without risking breaking too much existing behavior.
Also introduces an htmlSafe computed macro:
```
import { htmlSafe } from "discourse/lib/computed";
htmlDescription: htmlSafe("description")
```
Overtime {{html-safe}} usage should be removed and moved to components properties or specialized components/helpers.
2020-03-10 16:46:57 +01:00
Joffrey JAFFEUX
020c1b9cf3
FIX: correctly checks if component is in modal ( #9157 )
2020-03-10 12:22:56 +01:00
Joffrey JAFFEUX
78a6b76310
FIX: ensures pinned-options header is showing correct state ( #9156 )
2020-03-10 09:56:55 +01:00
Jarek Radosz
5037b80c9c
Merge imports from the same module ( #9144 )
2020-03-09 17:38:37 +01:00
Joffrey JAFFEUX
4f37233208
DEV: enforces ember-template-lint: simple-unless ( #9146 )
2020-03-09 13:44:34 +01:00
Jarek Radosz
48ba65f406
DEV: Clean up Ember imports ( #8979 )
...
Includes:
* Import `computed` helpers
* Import `@ember/application`
* Import `isBlank` from `@ember/utils`
* Import `A` from `@ember/array`
* Import `EmberArray` from `@ember/array`
* Import `ArrayProxy` from `@ember/array/proxy`
* Import `warn` from `@ember/debug`
* Import `EmberObject` from `@ember/object`
* Import `Application` from `@ember/application`
* Import `EmberRouter` from `@ember/routing/router`
* Import `isPresent` from `@ember/utils`
* Import `computed` from `@ember/object`
* Import `guidFor` from `@ember/object`
* Import `isArray` from `@ember/array`
* Import `TextField` from `@ember/component`
* Import `TextArea` from `@ember/component`
* Import `Promise` from `rsvp`
* Import `Evented` from `@ember/object/evented`
* Replace deprecated `ember-addons/ember-computed-decorators` imports
2020-03-06 23:49:28 +01:00
Joffrey JAFFEUX
bb5990781e
FIX: allows to define placement strategy of select-kit body ( #9109 )
2020-03-06 20:27:33 +01:00
Joffrey JAFFEUX
29c9d8a133
FIX: uses only global allow_uncategorized_topics for category drop ( #9130 )
2020-03-06 20:11:21 +01:00
Joffrey JAFFEUX
ed85cfe141
FIX: prevents click on sk header to bubble ( #9084 )
2020-03-02 20:06:02 +01:00
Joffrey JAFFEUX
2db8ada222
FIX: ensures category url of category drop is built using slug and id ( #9069 )
2020-02-28 17:58:22 +01:00
Joffrey JAFFEUX
501936f0da
FIX: prevents loading to show during debouncing ( #9060 )
...
This will also fix a bug in IE11 where click event would not be triggered on row
2020-02-27 15:20:04 +01:00
Joffrey JAFFEUX
56345faf9a
FIX: prevents row click event to be caught by filter input event ( #9059 )
...
This was causing some dropdowns to not work under IE11
2020-02-27 14:04:23 +01:00
Penar Musaraj
d6a603cc50
FIX: Translate none-tag and all-tags labels in tag filter ( #9030 )
...
* FIX: Translate none-tag and all-tags labels in tag filter
* Add test
2020-02-25 07:57:24 +11:00
Joffrey JAFFEUX
f336aeee6f
FIX: ensures scoped search category is searching in all categories ( #9031 )
2020-02-24 19:19:53 +01:00
Joffrey JAFFEUX
0b0290cddb
FIX: muted was not working in topic timeline ( #9021 )
2020-02-21 21:32:58 +01:00
Joffrey JAFFEUX
e807dff6fc
FIX: ensures mini-tag-chooser is respecting max_tags_per_topic ( #9018 )
2020-02-21 12:16:05 +01:00
Jarek Radosz
9f8a27a132
DEV: Import makeArray from discourse-common instead using Ember global ( #8977 )
2020-02-19 00:57:58 +01:00
Joffrey JAFFEUX
25ebfd5998
DEV: allows to import isPresent ( #8993 )
2020-02-18 23:41:15 +01:00
Joffrey JAFFEUX
67ee79f023
FIX: group members dropdown was broken on mobile ( #8994 )
2020-02-18 23:23:38 +01:00
Vinoth Kannan
2e397c78c4
FIX: use separate site attribute for single category "top tags" list.
...
And use it only in the single category pages.
38dd184a16
2020-02-17 21:09:27 +05:30
David Taylor
f1f9648e88
Revert "FIX: sk body should follow wrapper width ( #8984 )"
...
This was causing very narrow dropdowns in the composer and notification level dropdowns.
This reverts commit d33aaa0292
2020-02-17 13:10:26 +00:00
Joffrey JAFFEUX
d33aaa0292
FIX: sk body should follow wrapper width ( #8984 )
2020-02-17 10:39:20 +01:00
Joffrey JAFFEUX
9feace3388
FIX: prevents error when loading tag groups ( #8983 )
2020-02-17 10:39:04 +01:00
Joffrey JAFFEUX
7d94de6439
FIX: brings back castInteger as a safer migration path for sk2 ( #8966 )
2020-02-14 10:00:39 +01:00
Joffrey JAFFEUX
3875785dcc
FIX: ensures shortcuts work correctly with topic-notifications-button ( #8956 )
2020-02-13 10:01:28 +01:00
Joffrey JAFFEUX
42bda52486
FIX: ensures select-kit can select a row with 0 as value ( #8955 )
2020-02-13 09:04:32 +01:00
Penar Musaraj
efa9ba4975
UX: Prevent category-drop topic count from wrapping to new line ( #8943 )
2020-02-12 14:34:16 -05:00
Joffrey JAFFEUX
adbff5835d
FIX: correctly excludes current user in user-chooser ( #8928 )
2020-02-11 20:41:18 +01:00
Joffrey JAFFEUX
9d50e1b40f
DEV: introducing user-chooser ( #8910 )
2020-02-11 15:54:56 +01:00
Joffrey JAFFEUX
99ad2e408a
DEV: enforces style-concatenation linting rule ( #8888 )
2020-02-10 08:13:50 +01:00
Joffrey JAFFEUX
252989e261
DEV: better detection of new item ( #8889 )
2020-02-07 14:12:17 +01:00
Joffrey JAFFEUX
a0bf2ac313
DEV: applies valueAttribute deprecation when null ( #8887 )
2020-02-07 10:39:39 +01:00
Joffrey JAFFEUX
d86ed028c7
FIX: ensure s2 is working with wizard ( #8886 )
2020-02-07 10:00:39 +01:00
Joffrey JAFFEUX
6bee972a5c
FIX: corrects min/max logic for mini-tag-chooser ( #8871 )
2020-02-05 17:47:20 +01:00
Penar Musaraj
6253ddc74e
DEV: Do not trigger missing icon warning in icon picker
2020-02-05 11:39:46 -05:00
Mark VanLandingham
499b57a9ed
DEV: Ember linting - disallow Ember.* variable usage ( #8782 )
2020-02-05 10:14:42 -06:00
