github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-27 00:43:38 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity
37,062 Commits 214 Branches 500 Tags 960 MiB
f15fc0ebf3
Commit Graph

37062 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
dependabot-preview[bot]
f15fc0ebf3
Build(deps): Bump unicorn from 5.5.4 to 5.5.5 (#9552) 
Bumps [unicorn](https://yhbt.net/unicorn/) from 5.5.4 to 5.5.5.

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
 2020-04-27 12:50:03 -04:00
Jarek Radosz
fb20b57057
DEV: Re-enable "remove featured link" test (#9550) 
It was disabled in ac4b4e30dc
 2020-04-27 17:54:07 +02:00
David Taylor
f95609ae23
FIX: Add additional checks for automatic theme script CSP 
- Skip absolute URLs
- Skip CDN URLs
- Skip invalid URLs
- Properly format protocol-less URLs
 2020-04-27 15:56:29 +01:00
Benno
6e01acb3cb
FIX: Apply category priority for empty query (#9516) 2020-04-27 10:35:27 -04:00
Arpit Jalan
ec84b00aff fix the build. 2020-04-27 11:57:10 +05:30
Arpit Jalan
4c3a01f58d FIX: use absolute URL for YouTube thumbnail images. 2020-04-27 11:43:31 +05:30
Guo Xiang Tan
76fc48b318
DEV: Avoid an additional query in SpamHandler. 
* Also run query against human users only
 2020-04-27 13:03:57 +08:00
Guo Xiang Tan
e0725fd123 Upgrade message_bus to 3.0.0 
Fixes an issue where specifying `group_ids` and `user_ids` while
publishing a message would result in an intersection between both
options.
 2020-04-27 12:45:23 +08:00
Guo Xiang Tan
16f0d1c503
PERF: Remove database query when publishing to staff users. 2020-04-27 11:50:21 +08:00
Jarek Radosz
e0aec23844 DEV: Don't warn about valid data 2020-04-26 22:18:44 +02:00
Dan Ungureanu
0ae504aece
FIX: Raise a 4xx error instead of a 5xx if draft data is invalid 2020-04-25 11:47:22 +03:00
Sam Saffron
3de901e38d
DEV: correct missing file from revert 
Test did not revert cleanly. Corrected.
 2020-04-25 13:29:45 +10:00
Sam Saffron
8c1e008c59
DEV: Skip erratic spec for now 
Spec fails intermittently due to CDN state.
 2020-04-25 13:20:04 +10:00
Sam Saffron
1f6eaf26a1
Revert "UX: replace closed topic icon with discourse-no-entry" 
This reverts commit 040b8c00a4.

We decided to keep status quo for now
 2020-04-25 13:12:56 +10:00
Kris
d516a88b4c DEV: add tag name class to body of tag pages 2020-04-24 22:27:25 -04:00
Kris
67429335d5 Remove SASS spacing function 2020-04-24 19:32:02 -04:00
Kris
040b8c00a4 UX: replace closed topic icon with discourse-no-entry 2020-04-24 17:31:34 -04:00
Jeff Wong
e638d43f0a
FEATURE: dismiss first notification on click anywhere (#9525) 
FEATURE: dismiss first notification on click anywhere

Quicker jumpstart for those already familiar with the platform:

Allow dismissal of first notification mask from any click.
On the dismissal click, we also need to send a "yes I saw it" confirmation
by grabbing a batch of notifications. This prevents the dialog from appearing
again on refresh, or other browsers and ensures we only see it once.
 2020-04-24 13:27:54 -07:00
dependabot-preview[bot]
94d753ad16
Build(deps-dev): Bump better_errors from 2.6.0 to 2.7.0 (#9544) 
Bumps [better_errors](https://github.com/BetterErrors/better_errors) from 2.6.0 to 2.7.0.
- [Release notes](https://github.com/BetterErrors/better_errors/releases)
- [Commits](https://github.com/BetterErrors/better_errors/compare/v2.6.0...v2.7.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
 2020-04-24 14:22:05 -04:00
Penar Musaraj
5a3350cd76 FIX: Do not override all title elements with page title 
This is redudant too, setting document.title is sufficient.
 2020-04-24 10:16:05 -04:00
Penar Musaraj
b45142ef79
FIX: reenable draft check modal and fix focus on iOS for PMs 2020-04-24 09:35:19 -04:00
Gerhard Schlager
30cb5f7d86 Update translations 2020-04-24 15:16:29 +02:00
Joffrey JAFFEUX
d83f39be73
DEV: replaces jquery scrollTop by vanilla js code (#9543) 2020-04-24 12:45:47 +02:00
David Taylor
0616826841
DEV: Add jquery-free decorateCookedElement function to plugin api (#9534) 
This is a replacement for `decorateCooked` which will work without jquery.

A backwards compatibility layer is provided for existing plugins/themes which are currently using `decorateCooked`
 2020-04-24 09:47:33 +01:00
David Taylor
8a112b7464
DEV: Automatically extend CSP when themes link to external scripts (#9531) 2020-04-24 09:47:01 +01:00
Joffrey JAFFEUX
90d6816d19
FIX: removes inheriting as it's too random and can be very hard to track (#9542) 2020-04-24 10:08:22 +02:00
Sam Saffron
cbceadf48b
FEATURE: when blocking emails prefer blocking canonical 
Previously we relied entirely on levenshtein_distance_spammer_emails site
setting to handle "similar looking" emails.

This commit improves the situation by always preferring to block (and check)
canonical emails.

This means that if:

`samevil+test@domain.com` is blocked the system will block `samevil@domain.com`

This means that `samevil+2@domain.com` (ad infinitum) will be blocked
 2020-04-24 14:09:51 +10:00
Sam Saffron
6a18c9aa0b
Revert "FEATURE: enforce_canonical_emails site setting" 
This reverts commit 6f9177e2ed.

We decided on a completely different approach to the problem.

Instead we will let blocked emails be treated as canonical.
 2020-04-24 13:52:06 +10:00
Martin Brennan
6df22638e1 FIX: Make sure new user narrative returns toggleBookmark promise 
* the call to this.super() was not returned so there is no promise
  to chain .then() with, causing errors for bookmarks with reminders
 2020-04-24 13:13:30 +10:00
dependabot-preview[bot]
8b0ac092d8 Build(deps-dev): Bump byebug from 11.1.2 to 11.1.3 
Bumps [byebug](https://github.com/deivid-rodriguez/byebug) from 11.1.2 to 11.1.3.
- [Release notes](https://github.com/deivid-rodriguez/byebug/releases)
- [Changelog](https://github.com/deivid-rodriguez/byebug/blob/master/CHANGELOG.md)
- [Commits](https://github.com/deivid-rodriguez/byebug/compare/v11.1.2...v11.1.3)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
 2020-04-24 09:42:19 +08:00
Martin Brennan
cd1c7d7560
FIX: Copying image markdown for secure media loading full image (#9488) 
* When copying the markdown for an image between posts, we were not adding the srcset and data-small-image attributes which are done by calling optimize_image! in cooked post processor
* Refactored the code which was confusing in its current state (the consider_for_reuse method was super confusing) and fixed the issue
 2020-04-24 10:29:02 +10:00
Blake Erickson
bd3425b389 REFACTOR: Use rescue inside do/end block 
Follow up to 9cbbaf4237
 2020-04-23 16:26:29 -06:00
Kris
9f52997be1 UX: Let's try X for the closed topic icon instead of a \ 2020-04-23 17:23:25 -04:00
Joffrey JAFFEUX
b19d50f355
FIX: site settings dropdown can be 440px width (#9539) 2020-04-23 23:12:58 +02:00
Joffrey JAFFEUX
b871e79c5b
FIX: removes rounding correction as it can be in either direction (#9538) 2020-04-23 23:10:40 +02:00
Penar Musaraj
585e7bcfe8 DEV: update specs followup to 67e96f6 2020-04-23 16:11:17 -04:00
Penar Musaraj
7cd006fe3a Revert "DEV: Draft check async when starting new PM" 
This reverts commit e49212d0bc.

This requires some more work.
 2020-04-23 15:51:54 -04:00
Gerhard Schlager
67e96f6c54 DEV: discourse-backup-uploads-to-s3 plugin isn't supported anymore 2020-04-23 21:37:38 +02:00
Blake Erickson
5b98161f2f
DEV: ember-cli refactor for TextField and TextArea imports (#9480) 
In order to be able to use ember-cli we need to fix the import
statements for `TextField` and `TextArea` in the code base.

The only change I don't fully understand is the one in
`discourse-loader.js`, but adding the components to that file make it
all work.
 2020-04-23 12:36:05 -06:00
Penar Musaraj
e49212d0bc DEV: Draft check async when starting new PM 
When the sequence is missng, the draft check is done synchronously and it results in  iOS devices not launching the keyboard.
 2020-04-23 14:17:15 -04:00
Mark VanLandingham
3e543dfa18
FIX: Do not set title attribute on header-topic-info widget (#9533) 2020-04-23 12:44:20 -05:00
Robin Ward
e35286eda2 Ignore the app move 2020-04-23 13:43:48 -04:00
Joffrey JAFFEUX
82b43451b3
FIX: Inner content of a row could have no max-width and be very large (#9532) 2020-04-23 19:18:01 +02:00
Gerhard Schlager
060eb06a4f
Replace Travis build status with Github Actions status 2020-04-23 18:34:25 +02:00
Arpit Jalan
39be639c37 FIX: update GitHub screen_name on login via GitHub 2020-04-23 20:54:26 +05:30
Joffrey JAFFEUX
be1b7f7468
FIX: fails gracefully if :scope is not handled by a browser (#9529) 2020-04-23 16:50:30 +02:00
Roman Rizzi
7a2e8d3ead
DEV: Add the missing app subdirectory (#9499) 
* DEV: Add missing  directory to the Discourse ember app

* DEV: Resolve imports correctly
 2020-04-23 10:07:54 -03:00
David Taylor
8e28ccb2ea
PERF: Refactor decorateCooked to run in a detached DOM (#9517) 
This means that decorateCooked can be used to modify HTML without triggering the download of remote resources (e.g. images)

In some rare cases (e.g. IntersectionObservers in Chromium), decorating needs to happen in the real DOM. For this, pass `afterAdopt: true` to `decorateCooked`
 2020-04-23 11:03:46 +01:00
Sam Saffron
8dccf0521c
Revert "PERF: stop firing superfluous onSelectionChange" 
This reverts commit fa96054acf.

Sadly this fails a test case, we may have to hunt up all the
parentElements to check for the cooked class to perform the
bypass
 2020-04-23 18:16:13 +10:00
Sam Saffron
fa96054acf
PERF: stop firing superfluous onSelectionChange 
onSelectionChanged fires a debounced event that calls window.getSelection()

window.getSelection() is reasonably expensive. There is no reason to do any
of this work if we have an input field focused, that is not how quote works
 2020-04-23 17:51:23 +10:00