Robin Ward
14a64e7c4c
Move "Hide Post" option up to the top on the review interface
...
If you agree with the post you are likely to want to hide it.
2019-06-26 11:35:59 -04:00
Robin Ward
eedec7d79b
FIX: Only include pending/agreed scores in the total score
...
This should prevent posts from being hidden if a previous flag was
rejected and a new one was added.
2019-06-26 11:21:35 -04:00
Joffrey JAFFEUX
c63268467e
DEV: prettier 1.18.2 ( #7810 )
2019-06-26 17:09:52 +02:00
Penar Musaraj
76307611dc
UX: new inline button to remove a topic timer ( #7790 )
2019-06-26 11:08:53 -04:00
Gerhard Schlager
13f38055ac
SECURITY: XSS in routes
...
Co-authored-by: Guo Xiang Tan <tgx_world@hotmail.com>
Co-authored-by: David Taylor <david@taylorhq.com>
2019-06-26 16:34:15 +02:00
Bianca Nenciu
463db22928
DEV: Add test.
...
Follow-up to bccd090ced
2019-06-26 16:37:01 +03:00
Bianca Nenciu
bccd090ced
SECURITY: Escape email text for posts containing [details].
2019-06-26 16:28:31 +03:00
Joffrey JAFFEUX
56b76f31dc
fix prettier linting ( #7809 )
2019-06-26 15:26:02 +02:00
Joffrey JAFFEUX
dfde59f631
FIX: provides an emoji helper to replace codes by images ( #7802 )
2019-06-26 15:11:04 +02:00
Daniel Waterworth
65a6e2c860
Change Widget#attach signature
...
Take a fallback option instead of a list of names
2019-06-26 09:01:25 -04:00
Daniel Waterworth
37b8f5d989
Use dasherize instead of replace
2019-06-26 09:01:25 -04:00
Daniel Waterworth
d025e188e8
Make the linter happy
2019-06-26 09:01:25 -04:00
Daniel Waterworth
70e27641eb
Pass data to description to prevent duplication
2019-06-26 09:01:25 -04:00
Daniel Waterworth
8c349101c5
Pass data to text method to prevent duplication
2019-06-26 09:01:25 -04:00
Daniel Waterworth
86d5208b31
Pass data to url method to avoid duplication
2019-06-26 09:01:25 -04:00
Daniel Waterworth
ac6f7b3625
Remove notificationType argument from text
2019-06-26 09:01:25 -04:00
Daniel Waterworth
a3254b8446
Pull invitee accepted notification behaviour into its own class
2019-06-26 09:01:25 -04:00
Daniel Waterworth
7c52ba1431
Pull liked consolidated notification behaviour into its own class
2019-06-26 09:01:25 -04:00
Daniel Waterworth
42143a874e
Pull custom notification behaviour into its own class
2019-06-26 09:01:25 -04:00
Daniel Waterworth
305562bf66
Pull title logic into its own method
2019-06-26 09:01:25 -04:00
Daniel Waterworth
d83147d137
Rename "title" variable to more apt "description"
2019-06-26 09:01:25 -04:00
Daniel Waterworth
02deaa4bc6
Pull icon choosing into its own method
2019-06-26 09:01:25 -04:00
Daniel Waterworth
36d7abed0b
Pull group message summary behaviour into its own class
2019-06-26 09:01:25 -04:00
Daniel Waterworth
396e13aaa7
Pull liked notification behaviour in its own class
2019-06-26 09:01:25 -04:00
Daniel Waterworth
bd062fcbef
Export DefaultNotificationItem
2019-06-26 09:01:25 -04:00
Daniel Waterworth
04a75b1cb3
Change the way notification items are created
...
Look for the specialised version first, before falling back to the
default. This allows the behaviour to be customised based on the type of
notification.
2019-06-26 09:01:25 -04:00
Daniel Waterworth
cdf0cd3ecd
createWidgetFrom creates a new widget with an arbitrary base class
2019-06-26 09:01:25 -04:00
Daniel Waterworth
01a7fd4225
Make attach optionally take a list of widget names to try
2019-06-26 09:01:25 -04:00
Daniel Waterworth
41129f933d
Rename notification-item to default-notification-item
2019-06-26 09:01:25 -04:00
Daniel Waterworth
7e70db3fb7
s/notName/notificationName/g
2019-06-26 09:01:25 -04:00
Joffrey JAFFEUX
7c9d62c280
FIX: prevents failure when TL was mutated on internal object ( #7808 )
2019-06-26 14:51:45 +02:00
Arpit Jalan
3c64dc3e7d
FIX: do not allow creation of topic if there is no category available for posting ( #7786 )
2019-06-26 16:32:53 +05:30
Joffrey JAFFEUX
01de7e1444
FIX: calling action with a string is deprecated ( #7807 )
2019-06-26 12:42:46 +02:00
Joffrey JAFFEUX
e64544ae44
icon s/trash/trash-alt ( #7806 )
2019-06-26 12:31:49 +02:00
Joffrey JAFFEUX
ea2a9bc4fc
FIX: closes search-menu on escape ( #7804 )
2019-06-26 11:53:39 +02:00
Arpit Jalan
2af4002817
Bump onebox version.
...
- Add a placeholder icon for Twitch onebox preview
- Add CSS for showing fontawesome play icon for placeholder class
2019-06-26 13:40:14 +05:30
Sam Saffron
39b856dce7
DEV: correct edge case introduced in 333b5a19
...
We need to allow users to edit uncategorized topics out of uncategorized
when for some reason admin just turns it off.
2019-06-26 17:53:29 +10:00
Sam Saffron
333b5a19b2
FIX: do not include uncategorized_category_id in topic_create_allowed if posting in uncategorized is disabled
...
Previously users were still allowed to create topic via API even if
uncategorized was disabled.
Not 100% happy with all this special casing, but I guess we have to do
something.
This also splits up a mega spec now that we have fab! into a more easy to
understand structure (I hope)
2019-06-26 17:41:07 +10:00
Neil Lalonde
7e884cce6b
Update translations
2019-06-25 10:57:18 -04:00
Bianca Nenciu
557805249d
FIX: Ensure topic exists before making a banner. ( #7781 )
2019-06-25 13:49:29 +03:00
Bianca Nenciu
3fd7cf9038
Revert "PERF: Use Oj for serializing JSON. ( #7780 )"
...
This commit broke discourse-prometheus.
This reverts commit b4df8c5466
2019-06-25 11:13:27 +03:00
Guo Xiang Tan
d21594f4f7
Revert changes added by mistake in 2b19e2acc8.
2019-06-25 15:25:12 +08:00
Guo Xiang Tan
2b19e2acc8
Fix typo in a0aeabbb94.
2019-06-25 15:18:57 +08:00
Osama Sayegh
2eece2c41b
UX: add shortcut for deferring topics ( #7798 )
2019-06-25 07:20:55 +03:00
Guo Xiang Tan
a0aeabbb94
DEV: Safer replacement for old scheme uploads for posts:missing_uploads.
2019-06-25 11:34:26 +08:00
David Taylor
afb5ec811d
FIX: Don't use DistributedCache to store redis readonly state
...
This can cause unbound CPU usage in some cases, and excessive logging in other cases. This commit moves redis readonly information into the local process, but maintains the DistributedCache for postgres readonly state.
2019-06-25 11:20:34 +08:00
Sam Saffron
f3e4e6941c
DEV: Correct batch setting of categories
...
followup to #bc03c509
There were 2 problems
1. VALUES was not properly getting multiple results ... we need (1),(2),(3)
not (1,2,3)
2. changes was mistakenly lazy evaluated eg `changed ||=` which meant some
queries were not running
2019-06-25 13:05:43 +10:00
Daniel Waterworth
bc03c509ab
FIX: CategoryUser#batch_set ( #7787 )
...
* Remove unused method
* Prefabricate user in category_user_spec.rb
* FIX: Remove notification_level from category_users unique indexes
* FIX: CategoryUser#batch_set wasn't updating pre-existing records
* Improve tests for CategoryUser#batch_set
* FIX: changed was being reported incorrectly
* DEV: Rewrote query to do a bulk insert
* DEV: remove unnecessary parentheses
2019-06-25 12:13:27 +10:00
Jeff Wong
6de254f642
FIX: iterate when clearing watched words cache
2019-06-24 17:17:56 -07:00
Vinoth Kannan
b1ca64487a
FIX: multisite upload urls must have either db name or the word 'short-url'.
2019-06-25 01:19:58 +05:30
