mirror of
https://github.com/discourse/discourse.git
synced 2024-11-25 06:30:15 +08:00
03b7b7d1bc
This PR enables the [`no-action-modifiers`](https://github.com/ember-template-lint/ember-template-lint/blob/master/docs/rule/no-action-modifiers.md) template lint rule and removes all usages of the `{{action}}` modifier in core. In general, instances of `{{action "x"}}` have been replaced with `{{on "click" (action "x")}}`. In many cases, such as for `a` elements, we also need to prevent default event handling to avoid unwanted side effects. While the `{{action}}` modifier internally calls `event.preventDefault()`, we need to handle these cases more explicitly. For this purpose, this PR also adds the [ember-event-helpers](https://github.com/buschtoens/ember-event-helpers) dependency so we can use the `prevent-default` handler. For instance: ``` <a href {{on "click" (prevent-default (action "x"))}}>Do X</a> ``` Note that `action` has not in general been refactored away as a helper yet. In general, all event handlers should be methods on the corresponding component and referenced directly (e.g. `{{on "click" this.doSomething}}`). However, the `action` helper is used extensively throughout the codebase and often references methods in the `actions` hash on controllers or routes. Thus this refactor will also be extensive and probably deserves a separate PR. Note: This work was done to complement #17767 by minimizing the potential impact of the `action` modifier override, which uses private API and arguably should be replaced with an AST transform. This is a followup to #18333, which had to be reverted because it did not account for the default treatment of modifier keys by the {{action}} modifier. Commits: * Enable `no-action-modifiers` template lint rule * Replace {{action "x"}} with {{on "click" (action "x")}} * Remove unnecessary action helper usage * Remove ctl+click tests for user-menu These tests now break in Chrome when used with addEventListener. As per the comment, they can probably be safely removed. * Prevent default event handlers to avoid unwanted side effects Uses `event.preventDefault()` in event handlers to prevent default event handling. This had been done automatically by the `action` modifier, but is not always desirable or necessary. * Restore UserCardContents#showUser action to avoid regression By keeping the `showUser` action, we can avoid a breaking change for plugins that rely upon it, while not interfering with the `showUser` argument that's been passed. * Revert EditCategoryTab#selectTab -> EditCategoryTab#select Avoid potential breaking change in themes / plugins * Restore GroupCardContents#showGroup action to avoid regression By keeping the `showGroup` action, we can avoid a breaking change for plugins that rely upon it, while not interfering with the `showGroup` argument that's been passed. * Restore SecondFactorAddTotp#showSecondFactorKey action to avoid regression By keeping the `showSecondFactorKey` action, we can avoid a breaking change for plugins that rely upon it, while not interfering with the `showSecondFactorKey` property that's maintained on the controller. * Refactor away from `actions` hash in ChooseMessage component * Modernize EmojiPicker#onCategorySelection usage * Modernize SearchResultEntry#logClick usage * Modernize Discovery::Categories#showInserted usage * Modernize Preferences::Account#resendConfirmationEmail usage * Modernize MultiSelect::SelectedCategory#onSelectedNameClick usage * Favor fn over action in SelectedChoice component * Modernize WizardStep event handlers * Favor fn over action usage in buttons * Restore Login#forgotPassword action to avoid possible regression * Introduce modKeysPressed utility Returns an array of modifier keys that are pressed during a given `MouseEvent` or `KeyboardEvent`. * Don't interfere with click events on links with `href` values when modifier keys are pressed
67 lines
2.7 KiB
Handlebars
67 lines
2.7 KiB
Handlebars
<LoadMore @selector=".email-list tr" @action={{action "loadMore"}}>
|
|
<table class="table email-list">
|
|
<thead>
|
|
<tr>
|
|
<th>{{i18n "admin.email.time"}}</th>
|
|
<th>{{i18n "admin.email.incoming_emails.from_address"}}</th>
|
|
<th>{{i18n "admin.email.incoming_emails.to_addresses"}}</th>
|
|
<th>{{i18n "admin.email.incoming_emails.subject"}}</th>
|
|
<th colspan="2">{{i18n "admin.email.incoming_emails.error"}}</th>
|
|
</tr>
|
|
</thead>
|
|
|
|
<tbody>
|
|
<tr class="filters">
|
|
<td>{{i18n "admin.email.logs.filters.title"}}</td>
|
|
<td><TextField @value={{this.filter.from}} @placeholderKey="admin.email.incoming_emails.filters.from_placeholder" /></td>
|
|
<td><TextField @value={{this.filter.to}} @placeholderKey="admin.email.incoming_emails.filters.to_placeholder" /></td>
|
|
<td><TextField @value={{this.filter.subject}} @placeholderKey="admin.email.incoming_emails.filters.subject_placeholder" /></td>
|
|
<td colspan="2"><TextField @value={{this.filter.error}} @placeholderKey="admin.email.incoming_emails.filters.error_placeholder" /></td>
|
|
</tr>
|
|
|
|
{{#each this.model as |email|}}
|
|
<tr>
|
|
<td class="time">{{format-date email.created_at}}</td>
|
|
<td class="username">
|
|
<div>
|
|
{{#if email.user}}
|
|
<LinkTo @route="adminUser" @model={{email.user}}>
|
|
{{avatar email.user imageSize="tiny"}}
|
|
{{email.from_address}}
|
|
</LinkTo>
|
|
{{else}}
|
|
{{#if email.from_address}}
|
|
<a href="mailto:{{email.from_address}}">{{email.from_address}}</a>
|
|
{{else}}
|
|
—
|
|
{{/if}}
|
|
{{/if}}
|
|
</div>
|
|
</td>
|
|
<td class="addresses">
|
|
{{#each email.to_addresses as |to|}}
|
|
<p><a href="mailto:{{to}}" title="TO">{{to}}</a></p>
|
|
{{/each}}
|
|
{{#each email.cc_addresses as |cc|}}
|
|
<p><a href="mailto:{{cc}}" title="CC">{{cc}}</a></p>
|
|
{{/each}}
|
|
</td>
|
|
<td>{{email.subject}}</td>
|
|
<td class="error">
|
|
<a href {{on "click" (fn this.handleShowIncomingEmail email.id)}}>{{email.error}}</a>
|
|
</td>
|
|
<td class="email-details">
|
|
<a href {{on "click" (fn this.handleShowIncomingEmail email.id)}} title={{i18n "admin.email.details_title"}}>
|
|
{{d-icon "info-circle"}}
|
|
</a>
|
|
</td>
|
|
</tr>
|
|
{{else}}
|
|
<tr><td colspan="6">{{i18n "admin.email.incoming_emails.none"}}</td></tr>
|
|
{{/each}}
|
|
</tbody>
|
|
</table>
|
|
</LoadMore>
|
|
|
|
<ConditionalLoadingSpinner @condition={{this.loading}} />
|