Martin Brennan 8180770e7b

FIX: Do not lose admin sidebar when opening chat drawer (#26235) ...

This commit fixes an issue where the following happens:

1. You open /admin as a member of the admin_sidebar_enabled_groups
1. You then click the chat icon in the header when you prefer to have
   drawer open, or if you just minimise chat into drawer after it opens
   fullscreen
1. You lose the admin sidebar panel, and are reset instead to the main
   panel

Also included is a bit of refactoring to make it so the forcing of
admin sidebar state is in one place.

2024-03-20 09:20:06 +10:00

..

admin

DEV: Allow fab! without block (#24314)

2023-11-09 16:47:59 -06:00

chat/composer

DEV: Remove unnecessary js: true options from specs (#24463)

2023-11-20 17:22:14 +01:00

chat_message

PERF: cook message in background (#24227)

2023-11-06 15:45:30 +01:00

drawer

FIX: instantly removes group message when leaving (#25961)

2024-02-29 23:49:01 +01:00

list_channels

FEATURE: introduces chat_preferred_mobile_index setting (#25927)

2024-02-28 12:05:05 +01:00

page_objects

DEV: attempts to fix flakey spec (#25984)

2024-03-01 10:08:24 +01:00

reply_to_message

DEV: rely on default session in smoke spec (#26054)

2024-03-06 21:08:06 +08:00

select_message

FEATURE: thread pagination (#22624)

2023-07-27 09:57:03 +02:00

shortcuts

DEV: Refactor chat specs related to message creation

2023-08-31 11:21:23 +02:00

thread_list

FIX: do not show threads with no replies (#26033)

2024-03-05 20:26:35 +01:00

thread_tracking

DEV: skip two flakey specs (#24965)

2023-12-19 09:27:09 +01:00

user_menu_notifications

DEV: Remove the use of Capybara::Session#quit (#24978)

2023-12-20 13:20:14 +08:00

user_status

DEV: Remove assertion causing test to be flaky (#25069)

2023-12-29 13:23:16 +08:00

admin_sidebar_navigation_spec.rb

FIX: Do not lose admin sidebar when opening chat drawer (#26235)

2024-03-20 09:20:06 +10:00

anonymous_spec.rb

DEV: Allow fab! without block (#24314)

2023-11-09 16:47:59 -06:00

archive_channel_spec.rb

PERF: cook message in background (#24227)

2023-11-06 15:45:30 +01:00

bookmark_message_spec.rb

DEV: Remove superfluous js: true metadata (#21960)

2023-06-07 09:26:58 +08:00

browse_page_spec.rb

FIX: set channels tab as default on mobile chat footer (#25296)

2024-01-17 17:12:55 +08:00

channel_members_page_spec.rb

FIX: correctly shows as disabled a user who can't chat (#26010)

2024-03-05 09:13:42 +01:00

channel_message_upload_spec.rb

DEV: Fix various rubocop lints (#24749)

2023-12-06 23:25:00 +01:00

channel_settings_page_spec.rb

UX: Chat browse redesign (#25698)

2024-02-15 18:00:22 +01:00

channel_thread_message_echoing_spec.rb

DEV: makes every spec use new messages helper (#23163)

2023-08-21 16:31:58 +02:00

chat_channel_spec.rb

PERF: defer loading channels (#26155)

2024-03-18 08:35:07 +01:00

chat_composer_draft_spec.rb

DEV: Fix random typos (#25957)

2024-02-29 12:24:37 +01:00

chat_composer_spec.rb

DEV: Fix flaky network-based upload spec (#23286)

2023-08-28 12:59:22 +08:00

chat_footer_spec.rb

FIX: Conditionally hide 'My Threads' on mobile (#25494)

2024-01-31 09:09:04 -03:00

chat_message_creator_spec.rb

UX: chat message creator scss cleanup + design tweak to username display (#25928)

2024-03-05 12:49:29 +01:00

chat_message_onebox_spec.rb

DEV: Remove superfluous js: true metadata (#21960)

2023-06-07 09:26:58 +08:00

chat_new_message_spec.rb

PERF: defer loading channels (#26155)

2024-03-18 08:35:07 +01:00

chat_summarization_spec.rb

DEV: Remove unnecessary js: true options from specs (#24463)

2023-11-20 17:22:14 +01:00

closed_channel_spec.rb

DEV: Remove superfluous js: true metadata (#21960)

2023-06-07 09:26:58 +08:00

create_channel_spec.rb

DEV: Remove experimental site setting for chat threads (#22720)

2023-07-26 12:46:23 +02:00

dates_separators_spec.rb

DEV: Remove the use of Capybara::Session#quit (#24978)

2023-12-20 13:20:14 +08:00

deleted_channel_spec.rb

PERF: cook message in background (#24227)

2023-11-06 15:45:30 +01:00

deleted_message_spec.rb

DEV: Remove the use of Capybara::Session#quit (#24978)

2023-12-20 13:20:14 +08:00

document_title_spec.rb

DEV: Remove superfluous js: true metadata (#21960)

2023-06-07 09:26:58 +08:00

drawer_spec.rb

PERF: defer loading channels (#26155)

2024-03-18 08:35:07 +01:00

edited_message_spec.rb

DEV: Remove the use of Capybara::Session#quit (#24978)

2023-12-20 13:20:14 +08:00

flag_message_spec.rb

UX: enhances chat copy features (#23770)

2023-10-04 16:14:37 +02:00

hashtag_autocomplete_spec.rb

FEATURE: Async load of category and chat hashtags (#25526)

2024-02-12 12:07:14 +02:00

invite_users_to_channel_spec.rb

FIX: ensures users can open channel invites (#24067)

2023-10-24 18:51:33 +02:00

kick_user_from_channel_spec.rb

DEV: Remove superfluous js: true metadata (#21960)

2023-06-07 09:26:58 +08:00

mention_warnings_spec.rb

PERF: defer loading channels (#26155)

2024-03-18 08:35:07 +01:00

message_errors_spec.rb

DEV: ensures we have error message before message check (#24647)

2023-11-30 10:55:05 +01:00

message_notifications_mobile_spec.rb

FIX: chat channel row indicator should only show urgent count (#25458)

2024-01-31 16:47:54 +08:00

message_notifications_with_sidebar_spec.rb

PERF: cook message in background (#24227)

2023-11-06 15:45:30 +01:00

message_thread_indicator_spec.rb

DEV: improves reliability of delete/restore/update specs (#24265)

2023-11-07 11:34:35 +01:00

message_user_info_spec.rb

DEV: Fix RSpec/SpecFilePathSuffix / enable 3 chat spec files (#24750)

2023-12-06 22:25:11 +01:00

move_message_to_channel_spec.rb

DEV: makes chat modals use the new <DModal /> component (#22495)

2023-07-10 13:43:33 +02:00

navigation_spec.rb

PERF: defer loading channels (#26155)

2024-03-18 08:35:07 +01:00

react_to_message_spec.rb

DEV: Remove the use of Capybara::Session#quit (#24978)

2023-12-20 13:20:14 +08:00

read_only_spec.rb

DEV: Remove superfluous js: true metadata (#21960)

2023-06-07 09:26:58 +08:00

removing_channel_spec.rb

PERF: defer loading channels (#26155)

2024-03-18 08:35:07 +01:00

restore_message_spec.rb

DEV: Remove the use of Capybara::Session#quit (#24978)

2023-12-20 13:20:14 +08:00

reviewables_spec.rb

FIX: 500 error when reviewable has a missing message (#25113)

2024-01-03 11:49:54 -03:00

send_message_spec.rb

DEV: Remove the use of Capybara::Session#quit (#24978)

2023-12-20 13:20:14 +08:00

separate_sidebar_mode_spec.rb

FIX: Save previous chat state when navigating with the sidebar (#25537)

2024-02-06 13:11:12 -03:00

sidebar_navigation_menu_spec.rb

DEV: correctly uses link to message endpoint in spec (#24652)

2023-11-30 19:33:41 +01:00

sidebars_spec.rb

DEV: Allow fab! without block (#24314)

2023-11-09 16:47:59 -06:00

silenced_user_spec.rb

DEV: Remove superfluous js: true metadata (#21960)

2023-06-07 09:26:58 +08:00

single_thread_spec.rb

FEATURE: allows to force a thread (#25987)

2024-03-06 12:03:42 +01:00

thread_preview_spec.rb

DEV: prevents flakey spec (#25855)

2024-02-26 09:43:29 +01:00

transcript_spec.rb

DEV: Allow fab! without block (#24314)

2023-11-09 16:47:59 -06:00

unfollow_dm_channel_spec.rb

DEV: Remove the use of Capybara::Session#quit (#24978)

2023-12-20 13:20:14 +08:00

update_last_read_spec.rb

DEV: skip flakey last read spec (#26008)

2024-03-04 11:35:49 +01:00

uploads_spec.rb

DEV: skip flaky upload spec for large image thumbnails (#24745)

2023-12-06 19:08:56 +08:00

user_card_spec.rb

FEATURE: add chat direct message button to user profile (#26135)

2024-03-18 11:17:37 +08:00

user_chat_preferences_spec.rb

FIX: correctly check chat tab is present (#23200)

2023-08-23 13:06:29 +02:00

user_profile_spec.rb

FEATURE: add chat direct message button to user profile (#26135)

2024-03-18 11:17:37 +08:00

user_threads_spec.rb

UX: remove last reply from My Threads preview + restyle (#25568)

2024-03-11 17:59:40 +08:00

visit_channel_spec.rb

DEV: Allow fab! without block (#24314)

2023-11-09 16:47:59 -06:00