discourse/plugins/chat/spec/system/mention_warnings_spec.rb
Joffrey JAFFEUX bbb8595107
PERF: defer loading channels (#26155)
Prior to this change we would pre-load all the user channels which making initial page load slower. This change will make them be loaded right after initial load. In the past this was not possible as the channels would have to be loaded on each page transition. However since about a year, we made the channels to be cached on the frontend and no other request will be needed.

I have decided for now to not show a loading state in the sidebar as I think it would be noise, but we can reconsider this later.

Note given we don't have the channels loaded at first certain things where harder to accomplish. The biggest UX change of this commit is that we removed all the complex logic of computing the best channel to display when you load /chat. We will now store the id of the last channel you visited and will use this id to decide which channel to show.
2024-03-18 08:35:07 +01:00

131 lines
4.7 KiB
Ruby
Raw Blame History

This file contains ambiguous Unicode characters

This file contains Unicode characters that might be confused with other characters. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.

# frozen_string_literal: true
RSpec.describe "Mentions warnings", type: :system do
fab!(:current_user) { Fabricate(:user) }
fab!(:channel_1) { Fabricate(:chat_channel) }
fab!(:channel_2) { Fabricate(:chat_channel) }
let(:chat_page) { PageObjects::Pages::Chat.new }
let(:channel_page) { PageObjects::Pages::ChatChannel.new }
before do
chat_system_bootstrap(current_user, [channel_1, channel_2])
sign_in(current_user)
end
describe "composing a message with mentions" do
context "when mentioning a group" do
context "when the group doesnt allow mentions" do
fab!(:admin_mentionable_group) do
Fabricate(:group, mentionable_level: Group::ALIAS_LEVELS[:only_admins])
end
it "displays a warning" do
chat_page.visit_channel(channel_1)
channel_page.type_in_composer("@#{admin_mentionable_group.name} ")
expect(page).to have_css(".chat-mention-warnings")
expect(page.find(".chat-mention-warnings-list__simple")).to have_content(
admin_mentionable_group.name,
)
end
end
context "when the group allow mentions" do
fab!(:publicly_mentionable_group) do
Fabricate(:group, mentionable_level: Group::ALIAS_LEVELS[:everyone])
end
fab!(:user_2) { Fabricate(:user) }
context "when the group has too many members" do
before do
SiteSetting.max_users_notified_per_group_mention = 1
publicly_mentionable_group.add(user_2)
publicly_mentionable_group.add(Fabricate(:user))
end
it "displays a warning" do
chat_page.visit_channel(channel_1)
channel_page.type_in_composer("@#{publicly_mentionable_group.name} ")
expect(page).to have_css(".chat-mention-warnings")
expect(page.find(".chat-mention-warnings-list__simple")).to have_content(
publicly_mentionable_group.name,
)
end
end
context "when typing too many mentions" do
before { SiteSetting.max_mentions_per_chat_message = 1 }
it "displays a warning" do
chat_page.visit_channel(channel_1)
channel_page.type_in_composer(
"@#{user_2.username} @#{publicly_mentionable_group.name} ",
)
expect(page).to have_css(".chat-mention-warnings")
expect(page.find(".chat-mention-warnings-list__simple")).to be_present
end
it "doesnt count duplicates" do
chat_page.visit_channel(channel_1)
channel_page.type_in_composer("@#{user_2.username} @#{user_2.username} ")
expect(page).to have_no_css(".chat-mention-warnings")
end
it "doesn't consider code-blocks when counting mentions" do
raw =
"Hey @#{user_2.username}\n\n```\ndef foo\n @#{publicly_mentionable_group.name} = true\nend\n```\n"
message_1 =
Fabricate(:chat_message, user: current_user, chat_channel: channel_1, message: raw)
chat_page.visit_channel(channel_1)
channel_page.messages.edit(message_1)
expect(page).to have_no_css(".chat-mention-warnings")
end
end
end
end
context "when channel has allow_channel_wide_mentions disabled" do
before { channel_1.update(allow_channel_wide_mentions: false) }
%w[@here @all].each do |mention_text|
it "displays a warning" do
chat_page.visit_channel(channel_1)
channel_page.type_in_composer(mention_text)
expect(page).to have_css(".chat-mention-warnings")
expect(page.find(".chat-mention-warnings-list__simple")).to be_present
end
end
it "retains warnings when loading drafts or changing channels with no draft" do
Chat::Draft.create!(
chat_channel: channel_1,
user: current_user,
data: { message: "@all" }.to_json,
)
chat_page.visit_channel(channel_1)
# Channel 1 has a draft that causes a mention warning. Should appear on load
expect(page).to have_css(".chat-mention-warnings")
expect(page.find(".chat-mention-warnings-list__simple")).to be_present
# Channel 2 doesn't have a draft so it should disappear
chat_page.visit_channel(channel_2)
expect(page).to have_no_css(".chat-mention-warnings")
# Navigating back to channel 1 will make the mention warnings appear b/c the draft
# will trigger the @all mention warning again
chat_page.visit_channel(channel_1)
expect(page).to have_css(".chat-mention-warnings")
expect(page.find(".chat-mention-warnings-list__simple")).to be_present
end
end
end
end