mirror of
https://github.com/discourse/discourse.git
synced 2024-12-04 19:33:41 +08:00
0295b4165c
This moves the logic of setting the correct permalink values back into the controller. And it replaces the validation with a simpler one, that always works, even when the model is loaded from the DB. Follow-up to #29634 which broke import scripts and lots of documentation on Meta.
55 lines
1.5 KiB
Ruby
55 lines
1.5 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
RSpec.describe PermalinksController do
|
|
fab!(:topic)
|
|
fab!(:permalink) { Fabricate(:permalink, url: "deadroute/topic/546", topic_id: topic.id) }
|
|
|
|
describe "show" do
|
|
it "should redirect to a permalink's target_url with status 301" do
|
|
get "/#{permalink.url}"
|
|
|
|
expect(response).to redirect_to(topic.relative_url)
|
|
expect(response.status).to eq(301)
|
|
end
|
|
|
|
it "should work for subfolder installs too" do
|
|
set_subfolder "/forum"
|
|
|
|
get "/#{permalink.url}"
|
|
|
|
expect(response).to redirect_to(topic.relative_url)
|
|
expect(response.status).to eq(301)
|
|
end
|
|
|
|
it "should apply normalizations" do
|
|
permalink.update!(external_url: "/topic/100", topic_id: nil)
|
|
SiteSetting.permalink_normalizations = "/(.*)\\?.*/\\1"
|
|
|
|
get "/#{permalink.url}", params: { test: "hello" }
|
|
|
|
expect(response).to redirect_to("/topic/100")
|
|
expect(response.status).to eq(301)
|
|
|
|
SiteSetting.permalink_normalizations = "/(.*)\\?.*/\\1X"
|
|
|
|
get "/#{permalink.url}", params: { test: "hello" }
|
|
|
|
expect(response.status).to eq(404)
|
|
end
|
|
|
|
it "return 404 if permalink record does not exist" do
|
|
get "/not/a/valid/url"
|
|
expect(response.status).to eq(404)
|
|
end
|
|
|
|
context "when permalink's target_url is an external URL" do
|
|
it "redirects to it properly" do
|
|
permalink.update!(external_url: "https://github.com/discourse/discourse", topic_id: nil)
|
|
|
|
get "/#{permalink.url}"
|
|
expect(response).to redirect_to(permalink.external_url)
|
|
end
|
|
end
|
|
end
|
|
end
|