mirror of
https://github.com/discourse/discourse.git
synced 2024-12-04 15:54:00 +08:00
2dd9ac6277
Why this change? Predicate matchers are poor at providing good error messages when it fails if all the predicate matcher does is to return a boolean. Prior to this change, we were using `has_css? && all?` to assert for the tag section links. There are two problems here. Firstly, when one of the matchers fail, the error message does not provide any indication of which matcher failed making it hard to debug failures. Secondly, the matchers were not able to assert for the ordering of the tag section links which is an important behaviour to assert for. This commit changes `PageObjects::Components::Sidebar#has_tag_section_links?` such that we make use of assertions to ensure ordering. The usage of `all` will also provide a clear error message when things go wrong. |
||
|---|---|---|
| .. | ||
| ace_editor.rb | ||
| base.rb | ||
| category_list.rb | ||
| composer.rb | ||
| dialog.rb | ||
| emoji_picker.rb | ||
| fast_editor.rb | ||
| legacy_header_dropdown.rb | ||
| select_kit.rb | ||
| sidebar_header_dropdown.rb | ||
| sidebar.rb | ||
| topic_list.rb | ||
| topic_query_filter.rb | ||