mirror of
https://github.com/discourse/discourse.git
synced 2024-12-12 21:03:45 +08:00
2dd9ac6277
Why this change? Predicate matchers are poor at providing good error messages when it fails if all the predicate matcher does is to return a boolean. Prior to this change, we were using `has_css? && all?` to assert for the tag section links. There are two problems here. Firstly, when one of the matchers fail, the error message does not provide any indication of which matcher failed making it hard to debug failures. Secondly, the matchers were not able to assert for the ordering of the tag section links which is an important behaviour to assert for. This commit changes `PageObjects::Components::Sidebar#has_tag_section_links?` such that we make use of assertions to ensure ordering. The usage of `all` will also provide a clear error message when things go wrong.
136 lines
3.7 KiB
Ruby
136 lines
3.7 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
module PageObjects
|
|
module Components
|
|
class Sidebar < PageObjects::Components::Base
|
|
def visible?
|
|
page.has_css?("#d-sidebar")
|
|
end
|
|
|
|
def not_visible?
|
|
page.has_no_css?("#d-sidebar")
|
|
end
|
|
|
|
def has_category_section_link?(category)
|
|
page.has_link?(category.name, class: "sidebar-section-link")
|
|
end
|
|
|
|
def click_add_section_button
|
|
click_button(add_section_button_text)
|
|
end
|
|
|
|
def has_no_add_section_button?
|
|
page.has_no_button?(add_section_button_text)
|
|
end
|
|
|
|
def click_edit_categories_button
|
|
within(".sidebar-section[data-section-name='categories']") do
|
|
click_button(class: "sidebar-section-header-button", visible: false)
|
|
end
|
|
|
|
PageObjects::Modals::SidebarEditCategories.new
|
|
end
|
|
|
|
def click_edit_tags_button
|
|
within(".sidebar-section[data-section-name='tags']") do
|
|
click_button(class: "sidebar-section-header-button", visible: false)
|
|
end
|
|
|
|
PageObjects::Modals::SidebarEditTags.new
|
|
end
|
|
|
|
def edit_custom_section(name)
|
|
find(".sidebar-section[data-section-name='#{name.parameterize}']").hover
|
|
|
|
find(
|
|
".sidebar-section[data-section-name='#{name.parameterize}'] button.sidebar-section-header-button",
|
|
).click
|
|
end
|
|
|
|
SIDEBAR_SECTION_LINK_SELECTOR = "sidebar-section-link"
|
|
|
|
def click_section_link(name)
|
|
find(".#{SIDEBAR_SECTION_LINK_SELECTOR}", text: name).click
|
|
end
|
|
|
|
def has_one_active_section_link?
|
|
has_css?(".#{SIDEBAR_SECTION_LINK_SELECTOR}--active", count: 1)
|
|
end
|
|
|
|
def has_section_link?(name, href: nil, active: false)
|
|
section_link_present?(name, href: href, active: active, present: true)
|
|
end
|
|
|
|
def has_no_section_link?(name, href: nil, active: false)
|
|
section_link_present?(name, href: href, active: active, present: false)
|
|
end
|
|
|
|
def custom_section_modal_title
|
|
find("#discourse-modal-title")
|
|
end
|
|
|
|
SIDEBAR_WRAPPER_SELECTOR = ".sidebar-wrapper"
|
|
|
|
def has_section?(name)
|
|
find(SIDEBAR_WRAPPER_SELECTOR).has_button?(name)
|
|
end
|
|
|
|
def has_categories_section?
|
|
has_section?("Categories")
|
|
end
|
|
|
|
def has_tags_section?
|
|
has_section?("Tags")
|
|
end
|
|
|
|
def has_no_tags_section?
|
|
has_no_section?("Tags")
|
|
end
|
|
|
|
def has_all_tags_section_link?
|
|
has_section_link?(I18n.t("js.sidebar.all_tags"))
|
|
end
|
|
|
|
def has_tag_section_links?(tags)
|
|
tag_names = tags.map(&:name)
|
|
|
|
tag_section_links =
|
|
all(
|
|
".sidebar-section[data-section-name='tags'] .sidebar-section-link-wrapper[data-tag-name]",
|
|
count: tag_names.length,
|
|
)
|
|
|
|
expect(tag_section_links.map(&:text)).to eq(tag_names)
|
|
end
|
|
|
|
def has_no_section?(name)
|
|
find(SIDEBAR_WRAPPER_SELECTOR).has_no_button?(name)
|
|
end
|
|
|
|
def primary_section_links(slug)
|
|
all("[data-section-name='#{slug}'] .sidebar-section-link-wrapper").map(&:text)
|
|
end
|
|
|
|
def primary_section_icons(slug)
|
|
all("[data-section-name='#{slug}'] .sidebar-section-link-wrapper use").map do |icon|
|
|
icon[:href].delete_prefix("#")
|
|
end
|
|
end
|
|
|
|
private
|
|
|
|
def section_link_present?(name, href: nil, active: false, present:)
|
|
attributes = { exact_text: name }
|
|
attributes[:href] = href if href
|
|
attributes[:class] = SIDEBAR_SECTION_LINK_SELECTOR
|
|
attributes[:class] += "--active" if active
|
|
page.public_send(present ? :has_link? : :has_no_link?, **attributes)
|
|
end
|
|
|
|
def add_section_button_text
|
|
I18n.t("js.sidebar.sections.custom.add")
|
|
end
|
|
end
|
|
end
|
|
end
|