discourse/plugins/chat/app
Martin Brennan c07f1e442f
DEV: Fix failing chat spec and add unexpected failure indicator (#20299)
This commit fixes the UpdateUserLastRead spec which was checking
for a message ID that did not exist -- this could fail at times
since message ID 2 could exist. Better to create + destroy a message
since then it's guaranteed we have a unique ID.

This also attempts to clarify a step that we expect to fail which
succeeds instead by adding another emoji next to the success tick and
an explanation text.

Also removes some uses of unless in Services::Base, we generally prefer
to use alternatives, since unless can be hard to parse in a lot of
cases.

Co-authored-by: Loïc Guitaut <loic@discourse.org>
2023-02-15 19:16:13 +01:00
..
controllers FEATURE: Chat side panel with threads initial skeleton (#20209) 2023-02-14 11:38:41 +10:00
core_ext
helpers DEV: Chat service object initial implementation (#19814) 2023-02-13 13:09:57 +01:00
jobs DEV: Pass messageId as a dynamic segment instead of a query param (#20013) 2023-02-01 12:39:23 -03:00
models FEATURE: Chat side panel with threads initial skeleton (#20209) 2023-02-14 11:38:41 +10:00
queries
serializers DEV: Remove chat_channel_id from chat-live-pane details (#20302) 2023-02-15 08:27:09 +01:00
services DEV: Fix failing chat spec and add unexpected failure indicator (#20299) 2023-02-15 19:16:13 +01:00
views