Osama Sayegh eaa3f813c1

FIX: Don't secure the about banner image (#29889) ...

Uploads that are linked to site settings shouldn't be flagged as secure in login-required sites that enable secure uploads. However, in order for site setting uploads to not be marked secured, the frontend uploader has to include 2 params in the upload request: `for_site_setting: true` and `type: "site_setting"`.

Since these 2 params are semantically identical, we want the `type: "site_setting"` param alone to make the upload correctly treated as a site setting upload. To achieve that, we need to include the `site_setting` type in the public types list because the `for_site_setting` param has the same effect — it marks the upload as a public type.

b138eaf9e5/lib/upload_security.rb (L128-L131)

2024-11-25 11:12:00 +03:00

..

composer

FIX: resume editing when through /new-message (#29637)

2024-11-07 17:39:58 -03:00

emojis

FEATURE: Introduce site settings which require confirmation (#27315)

2024-06-19 16:01:24 +10:00

groups

FIX: deleting a groups was throwing an error (#26623)

2024-04-15 08:35:50 +02:00

helpers

…

page_objects

DEV: Modernize admin user fields (#29843)

2024-11-25 11:54:43 +08:00

topic_list

FIX: Bulk (glimmer) topic selection on mobile (#28100)

2024-07-26 21:16:19 +02:00

user_page

DEV: Allow enabling safe-mode even when missing required fields (#29310)

2024-10-21 17:11:43 +08:00

about_page_spec.rb

FEATURE: Enable the new /about page for everyone (#29390)

2024-10-29 18:40:11 +03:00

admin_about_config_area_spec.rb

FIX: Don't secure the about banner image (#29889)

2024-11-25 11:12:00 +03:00

admin_backups_spec.rb

UX: Apply admin interface guidelines to Backups page (#28051)

2024-08-20 09:59:43 +10:00

admin_badges_grouping_modal_spec.rb

FIX: correctly pass updateGroupings to the modal (#28683)

2024-09-02 17:32:18 +02:00

admin_badges_spec.rb

FIX: do not overrider trigger when equals 0 (#29269)

2024-10-18 08:34:34 +09:00

admin_customize_emojis_spec.rb

DEV: Convert admin emojis UI to new layout (#29615)

2024-11-11 15:04:15 +08:00

admin_customize_form_templates_spec.rb

FIX: Customize form template view modal footer buttons (#25804)

2024-02-21 22:20:56 -08:00

admin_customize_themes_spec.rb

DEV: fix flaky admin_customize_themes spec (#26842)

2024-05-02 08:26:07 +08:00

admin_dashboard_community_health_spec.rb

FEATURE: Switch to new methods of pageview measurement and reporting (#28729)

2024-09-10 09:51:49 +10:00

admin_dashboard_new_features_spec.rb

UX: New experimental features should be marked clearly (#29622)

2024-11-06 15:26:30 -08:00

admin_editing_objects_typed_theme_setting_spec.rb

DEV: Remove experimental_objects_type_for_theme_settings site setting (#26507)

2024-04-04 12:01:31 +08:00

admin_embeddable_hosts_spec.rb

DEV: remap all core icons for fontawesome 6 upgrade (#28715)

2024-09-13 16:50:52 +01:00

admin_flags_spec.rb

UX: consistent flags page (#29798)

2024-11-19 14:46:08 +11:00

admin_notices_spec.rb

FIX: Only render admin notice dismiss button for admins (#29103)

2024-10-07 13:14:01 +08:00

admin_permalinks_page_spec.rb

UX: redesign admin permalinks page (#29634)

2024-11-14 10:03:58 +11:00

admin_sidebar_navigation_spec.rb

FIX: Routing back to homepage from admin sidebar (#29125)

2024-10-08 10:05:08 -04:00

admin_site_setting_requires_confirmation_spec.rb

DEV: Fix admin confirmation flaky spec (#29456)

2024-10-30 04:59:51 +10:00

admin_site_setting_search_spec.rb

FEATURE: Introduce site settings which require confirmation (#27315)

2024-06-19 16:01:24 +10:00

admin_site_texts_spec.rb

FIX: correctly display category name in replace text modal (#29612)

2024-11-06 13:39:52 +11:00

admin_staff_action_logs_spec.rb

FIX: filterable staff logs for flags (#29695)

2024-11-12 11:23:18 +11:00

admin_user_badges_spec.rb

DEV: Allow fab! without block (#24314)

2023-11-09 16:47:59 -06:00

admin_user_fields_spec.rb

DEV: Modernize admin user fields (#29843)

2024-11-25 11:54:43 +08:00

admin_user_spec.rb

FIX: Don't show silence button on staff users and display similar users (#28423)

2024-08-20 15:27:29 +03:00

admin_watched_words_spec.rb

DEV: Remove extraneous spec code (#29386)

2024-10-24 14:15:32 +02:00

admin_web_hook_events_spec.rb

FEATURE: Add Filter for Webhook Events by Status (#27332)

2024-06-07 10:26:00 -05:00

bookmarks_spec.rb

DEV: Try fix bookmark flaky (#29069)

2024-10-03 14:34:36 +10:00

bootstrap_error_pages_spec.rb

FIX: Improve handling of 'PublicExceptions' when bootstrap_error_pages enabled (#26700)

2024-04-24 09:40:13 +01:00

category_topics_spec.rb

FIX: Dismiss unread posts in subcategories (#29671)

2024-11-14 10:06:12 -05:00

change_owner_spec.rb

DEV: Allow fab! without block (#24314)

2023-11-09 16:47:59 -06:00

composer_spec.rb

FIX: Restore user-cards in composer preview (#27514)

2024-06-19 14:41:32 +02:00

composer_uploads_spec.rb

DEV: Auto grid images no longer experimental (#29572)

2024-11-04 08:21:40 -08:00

content_security_policy_spec.rb

DEV: remove legacy CSP implementation to make strict-dynamic only accepted behaviour (#27486)

2024-06-18 16:40:53 +08:00

create_account_spec.rb

UX: Registration design and validation improvements (#27666)

2024-07-04 09:17:07 -03:00

create_invite_spec.rb

FIX: Add back the option to create invite without emailing (#29641)

2024-11-08 07:59:24 +03:00

csv_exports_spec.rb

DEV: Allow fab! without block (#24314)

2023-11-09 16:47:59 -06:00

custom_sidebar_sections_spec.rb

DEV: fix flakey spec in sidebar (#29254)

2024-10-17 22:28:02 +09:00

discovery_breadcrumb_navigation_spec.rb

FEATURE: Show remaining count in category-drop (#25938)

2024-03-07 16:14:50 +02:00

discovery_category_spec.rb

DEV: Add system spec for categories page (#29621)

2024-11-06 20:01:27 +02:00

discovery_list_spec.rb

FIX: Sorting toggles on topic list (#24465)

2023-11-20 17:45:13 +00:00

dismissing_new_spec.rb

FIX: Dismiss unread posts in subcategories (#29671)

2024-11-14 10:06:12 -05:00

edit_category_form_templates_spec.rb

UX: Add group link to category permission row (#28560)

2024-08-28 16:11:16 +10:00

edit_category_security_spec.rb

UX: Add group link to category permission row (#28560)

2024-08-28 16:11:16 +10:00

editing_sidebar_categories_navigation_spec.rb

FIX: Make edit categories sidebar modal work more intuitively (#27111)

2024-06-14 11:37:32 -05:00

editing_sidebar_community_section_spec.rb

FEATURE: Add invite link to the sidebar (#29448)

2024-10-30 05:31:14 +03:00

editing_sidebar_tags_navigation_spec.rb

UX: Fix edit navigation tags modal height too long on desktop (#24765)

2023-12-07 09:42:04 +08:00

email_change_spec.rb

FIX: User can't reset password with backup codes when only security key is enabled (#27368)

2024-06-06 14:30:42 +08:00

ember_deprecation_spec.rb

DEV: Ensure deprecation warning banner works in development builds (#28302)

2024-08-09 15:04:05 +01:00

filtering_topics_spec.rb

FEATURE: Add Bulk actions to /filter page (#29420)

2024-11-22 11:51:06 +11:00

flagging_post_spec.rb

DEV: move post flags into database (#27125)

2024-05-23 12:19:07 +10:00

forgot_password_spec.rb

FIX: User can't reset password with backup codes when only security key is enabled (#27368)

2024-06-06 14:30:42 +08:00

grant_badge_spec.rb

DEV: Allow fab! without block (#24314)

2023-11-09 16:47:59 -06:00

group_activity_spec.rb

DEV: Update rubocop-discourse to latest version

2024-03-04 15:08:35 +01:00

group_card_spec.rb

DEV: Allow fab! without block (#24314)

2023-11-09 16:47:59 -06:00

hashtag_autocomplete_spec.rb

FEATURE: Async load of category and chat hashtags (#25526)

2024-02-12 12:07:14 +02:00

header_spec.rb

DEV: Remove body docked class and its scroll event listener (#29515)

2024-10-31 10:21:50 -04:00

homepage_spec.rb

FEATURE: "Hot" replacing "Top" as default in the top menu (#28252)

2024-08-08 13:57:42 -04:00

keyboard_shortcuts_spec.rb

DEV: Add disableDefaultKeyboardShortcuts plugin API to disable default keyboard shortcuts (#29401)

2024-10-25 14:14:04 -05:00

login_spec.rb

FIX: Bring back the login-required page for fullpage login (#29316)

2024-10-22 10:05:23 -03:00

navigation_menu_state_integration_spec.rb

DEV: Remove extraneous spec code (#29386)

2024-10-24 14:15:32 +02:00

network_disconnected_spec.rb

DEV: Skip flaky topic map spec on CI (#28159)

2024-07-31 13:04:05 +10:00

new_category_spec.rb

FIX: should not raise error when minimum_required_tags value not defined for category. (#27658)

2024-07-01 07:14:34 +05:30

new_topic_list_spec.rb

DEV: Add/use two topic fabricators (#27603)

2024-06-25 13:47:53 +02:00

post_menu_spec.rb

DEV: Modernize the post menu from widgets to Glimmer components (#28670)

2024-11-11 15:36:08 -03:00

post_replies_spec.rb

SECURITY: add pagination to post replies

2024-10-07 11:48:48 +08:00

post_selection_copy_quote_spec.rb

DEV: Try until success for clipboard copies (#27986)

2024-07-19 19:44:10 +08:00

post_selection_fast_edit_spec.rb

FIX: bypass fast edit when selected text isn't editable

2024-05-24 18:19:28 +02:00

post_small_action_spec.rb

DEV: Remove flaky spec (#24641)

2023-11-30 11:06:27 +08:00

powered_by_discourse_spec.rb

FEATURE: optionally show "Powered by Discourse" link to discourse.org (#26162)

2024-03-14 10:30:12 -04:00

private_message_map_spec.rb

DEV: remap all core icons for fontawesome 6 upgrade (#28715)

2024-09-13 16:50:52 +01:00

request_tracker_spec.rb

DEV: adds logo page component (#28276)

2024-08-08 13:52:48 +02:00

reviewables_spec.rb

FIX: Use site contact user + group for Revise... review action (#29271)

2024-10-28 09:40:10 +10:00

s3_secure_uploads_spec.rb

DEV: Combine S3 system spec helpers into one (#29580)

2024-11-05 09:28:14 +10:00

s3_uploads_spec.rb

DEV: Combine S3 system spec helpers into one (#29580)

2024-11-05 09:28:14 +10:00

scroll_manager_service_spec.rb

DEV: adds logo page component (#28276)

2024-08-08 13:52:48 +02:00

search_spec.rb

DEV: adds logo page component (#28276)

2024-08-08 13:52:48 +02:00

signup_spec.rb

FIX: Correctly load the invites model when using full page logins (#29713)

2024-11-13 08:56:16 -03:00

social_authentication_spec.rb

FIX: Error with social logins and fullpage signup (#29761)

2024-11-14 16:02:17 -03:00

table_builder_spec.rb

FEATURE: allow plugins to specify keyboard shortcuts for hidden toolbar items (#28456)

2024-08-23 09:28:28 +10:00

tag_notification_level_spec.rb

…

tag_synonyms_spec.rb

…

tag_view_spec.rb

FIX: Refresh the edit tag section when navigating to another tag (#28519)

2024-08-23 20:08:24 +03:00

tags_intersection_spec.rb

FIX: Transitioning to tag-intersection route (#23931)

2023-10-13 16:23:04 +01:00

theme_qunit_spec.rb

DEV: Stop building test assets in production under Embroider (#23388)

2023-09-11 09:12:37 +01:00

topic_admin_menu_spec.rb

FIX: shows errors when converting to public is impossible (#27103)

2024-05-21 12:14:31 +02:00

topic_bulk_select_spec.rb

DEV: Fix flaky test with bulk select closing topics (#29871)

2024-11-20 16:34:44 -07:00

topic_list_focus_spec.rb

DEV: Remove flaky spec (#24795)

2023-12-08 11:43:17 -05:00

topic_map_spec.rb

UX: reduce bottom topic map threshold, with protections (#29665)

2024-11-13 07:58:44 -05:00

topic_page_spec.rb

FIX: Respect the End key when last post is already rendered (#28524)

2024-08-26 14:39:30 -04:00

topics_unread_when_closed_spec.rb

FEATURE: Silence Close Notifications User Setting (#26072)

2024-03-08 15:14:46 -07:00

user_activation_spec.rb

UX: Add progress bar to the registration flow (#27694)

2024-08-28 08:43:39 -03:00

user_activity_bookmarks_spec.rb

FIX: correctly filter user bookmarks (#28612)

2024-08-28 15:39:07 -04:00

user_invites_spec.rb

FIX: Don't show that an existing user is invited_by another user (#27665)

2024-07-04 10:27:37 +08:00

user_selector_spec.rb

DEV: Allow fab! without block (#24314)

2023-11-09 16:47:59 -06:00

user_tips_spec.rb

FIX: Show the last rendered user-tip (#29346)

2024-10-22 22:41:29 +02:00

viewing_category_spec.rb

DEV: Allow fab! without block (#24314)

2023-11-09 16:47:59 -06:00

viewing_group_members_spec.rb

DEV: Allow fab! without block (#24314)

2023-11-09 16:47:59 -06:00

viewing_navigation_menu_preferences_spec.rb

DEV: Allow fab! without block (#24314)

2023-11-09 16:47:59 -06:00

viewing_sidebar_as_anonymous_user_spec.rb

UX: support links in tag descriptions (#22994)

2023-08-16 11:43:54 -04:00

viewing_sidebar_mobile_spec.rb

DEV: Fix various rubocop lints (#24749)

2023-12-06 23:25:00 +01:00

viewing_sidebar_spec.rb

DEV: Untangle the admin sidebar from the sidebar code (#27640)

2024-07-05 13:11:15 -03:00

viewing_user_menu_spec.rb

DEV: Add setUserMenuNotificationsLimit plugin-api method (#25119)

2024-01-09 08:38:00 +08:00

viewing_user_private_messages_spec.rb

DEV: Fix ember/no-private-routing-service (#24009)

2023-11-29 12:26:52 +01:00

wizard_spec.rb

DEV: Update member access wizard step to use toggle group (#28013)

2024-07-29 14:07:06 +08:00