7408 Commits

Author SHA1 Message Date
Kurtis Rader
b023bddc88 Revert "Clarified job_continue logging"
This reverts commit 8f2ef082be3679a76156f4fdcff459aec45ee435.
It was meant for the major branch.
2017-08-13 15:28:05 -07:00
Kurtis Rader
a8a8d33fe0 Revert "Better set_child_group logic for multi-process jobs"
This reverts commit 99c6f65fee8be5476197cb11d9c8f8bec85266b5.
It was meant for the major branch.
2017-08-13 15:27:57 -07:00
Kurtis Rader
8a1af4a38d Revert "Be more judicious about when SIGSTOP is performed"
This reverts commit abf6874a2df910453948a91ac3dc767e64aff6d8.
It was meant for the major branch.
2017-08-13 15:27:48 -07:00
Kurtis Rader
607d9e6aef Revert "No need to unblock last process since it will no longer be SIGSTOP'd"
This reverts commit 30aa8b3663008afb1275ab7c90a30073b4235639.
It was meant for the major branch.
2017-08-13 15:27:40 -07:00
Kurtis Rader
b3f43723dc Revert "Improved comments"
This reverts commit 1ae0272c4edee47390f7bc59d7c02fbcf21f0c37.
It was meant for the major branch.
2017-08-13 15:27:17 -07:00
Kurtis Rader
92628a384b Revert "Retry setpgid in setup_child_process on EPERM"
This reverts commit d6c4e66484957355d4985938ca30bc5d31ddc156.
It was meant for the major branch.
2017-08-13 15:27:08 -07:00
Kurtis Rader
ac4eedb436 Revert "Fixed no-op loop hang"
This reverts commit 8537cc982e67d548b08dcc887ff32d338e7ba3e4.
It was meant for the major branch.
2017-08-13 15:27:00 -07:00
Kurtis Rader
4b1bc53f91 Revert "Split child_set_group from setup_child_process"
This reverts commit f7b051905e66abf3bbdd8c6f0f2ce75f2d0a73a2.
It was meant for the major branch.
2017-08-13 15:26:52 -07:00
Kurtis Rader
7b443ac1d3 Revert "terminal_give_to_job() was bypassing the cont branch"
This reverts commit b27217e106313fd492be093999bd8c3bd01b7221.
It was meant for the major branch.
2017-08-13 15:26:41 -07:00
Kurtis Rader
bd601019fe Revert "blocking only if pipes_to_next_command breaks things like read.expect test"
This reverts commit c3d756b5df0a2fdbe91cf892325249ee255b57ed.
It was meant for the major branch.
2017-08-13 15:26:30 -07:00
Kurtis Rader
8c86d258e8 Revert "unblock_previous on exec_job finish"
This reverts commit 5db8065f151d01e9003c24d5615a083acb6b33f0.
It was meant for the major branch.
2017-08-13 15:26:22 -07:00
Kurtis Rader
376cb99974 Revert "Logging updates"
This reverts commit a0efae5f08f6b157a397444a2c60a3088c6f7057.
It was meant for the major branch.
2017-08-13 15:26:13 -07:00
Kurtis Rader
d0ce2b4824 Revert "Minor refactoring"
This reverts commit 15da6f02032f8bfa6d2af333cf386250ca76d4f5.
It was meant for the major branch.
2017-08-13 15:26:03 -07:00
Kurtis Rader
a4593d011a Revert "Added important comment about blocked_pid"
This reverts commit 16d2f4faff4d06c26a162c50fb47fc2f1f0f73e0.
It was meant for the major branch.
2017-08-13 15:25:54 -07:00
Kurtis Rader
177256064c Revert "Removed old/unneeded variants of block_child"
This reverts commit 8e63386203dcf6377a9c5a49207249523d66ccd3.
It was meant for the major branch.
2017-08-13 15:25:45 -07:00
Kurtis Rader
a3863b22a7 Revert "OS X EINVAL compatibility for waitpid"
This reverts commit 628db65504a69cff1d04a0639ace4a9358504fff.
It was meant for the major branch.
2017-08-13 15:25:29 -07:00
Kurtis Rader
1bbd288f86 Revert "Removed unused job_t * parameter from setup_child_process"
This reverts commit dabe718c52f498f43e6dfc5c0e292cae2f7fd2b2.
It was meant for the major branch.
2017-08-13 15:25:19 -07:00
Kurtis Rader
260d5bb013 Revert "Cleaned up terminal_give_to_job() code flow and comments"
This reverts commit 7e23965250eef92452df1ddd89f316a411f92a28.
It was meant for the major branch.
2017-08-13 15:25:10 -07:00
Kurtis Rader
aab3dbd24c Revert "Removed unused <mutex> header include"
This reverts commit 87db424e45a7b04ca45d9dca735b2368a123977f.
It was meant for the major branch.
2017-08-13 15:25:02 -07:00
Kurtis Rader
5c0311653e Revert "Raised debug level for "Retrying setpgid" message"
This reverts commit 711c81b8c8bf5d2dcfffe5add8ca5ab39382bf8a.
It was meant for the major branch.
2017-08-13 15:24:44 -07:00
Kurtis Rader
6fe0cb1941 Revert "Split internal_exec to its own function"
This reverts commit 4a1de248bc5ea83c63904dc962467b1e220c1eb9.
It was meant for the major branch.
2017-08-13 15:24:36 -07:00
Kurtis Rader
03a66e31f4 Revert "Unified all child/parent forking code in exec_job"
This reverts commit 384879704ac5164ac6ab659bc668b8933e073b5b.
It was meant for the major branch.
2017-08-13 15:24:29 -07:00
Kurtis Rader
5aa281942f Revert "Corrected job_type for external command in debug log"
This reverts commit 4dfb334db813c35950b11a0201953d32b4b4a858.
It was meant for the major branch.
2017-08-13 15:24:18 -07:00
Kurtis Rader
82ee3d6a4e Revert "Deduplication between INTERNAL_FUNCTION and INTERNAL_BLOCK_NODE"
This reverts commit 0594735714faf03e92863ebda67945a45521493e.
It was meant for the major branch.
2017-08-13 15:24:08 -07:00
Kurtis Rader
fea22f2bec Revert "Revert "Revert "finish cleanup of signal blocking code"""
This reverts commit 52d739c746034e0dcd554001f5927ad2f32a20fc.
It was meant for the major branch.
2017-08-13 15:23:57 -07:00
Kurtis Rader
8aca33b21f Revert "fixes to job control changes"
This reverts commit 083224d1c0076b43e9dbb080bc501ee275a9619d.
It was meant for the major branch.
2017-08-13 15:23:44 -07:00
Kurtis Rader
dc5d0ff22f Revert "lint and style cleanups"
This reverts commit acdb81bbca0090fd5f13d72fa1c936c2b645fc42.
It was meant for the major branch.
2017-08-13 15:23:19 -07:00
Kurtis Rader
b0c47c814f Revert "make style-all time again"
This reverts commit 975a5bfbdeeee59b6c46febe9de4d00a51f68196.
It was meant for the major branch.
2017-08-13 15:22:50 -07:00
Kurtis Rader
5786f9e5c3 Revert "replace var_entry_t with env_var_t"
This reverts commit 1c9370dbd2a3a0135c9c5fdd6b2a690dcd0c8027.
2017-08-13 14:58:00 -07:00
Kurtis Rader
2b7a4143ec Revert "fix bug in env_get() involving empty vars"
This reverts commit 559b05d01df07f2d60caaa686d4dd1357ab231bb.
It was meant for the major branch.
2017-08-13 14:57:44 -07:00
Kurtis Rader
a2f507f1c8 Revert "remove more ENV_NULL references"
This reverts commit 591449aba72f5f6a8fa646f57704ece4428eccb4.
It was meant for the major branch.
2017-08-13 14:57:31 -07:00
Kurtis Rader
9f4f9545c1 Revert "change order of env_set() args"
This reverts commit 6e7956a41383b3273981916901c6db091ea0c6ed.
It was meant for the major branch.
2017-08-13 12:48:22 -07:00
Kurtis Rader
59dbf64603 Revert "make missing_var a singleton"
This reverts commit 3df8643c31a4053aa04410d967886a5888adb1e0.
It was meant for the major branch.
2017-08-13 12:48:22 -07:00
Fabian Homborg
e8b8be4237 Merge branch 'pr/4326' 2017-08-13 13:24:13 +02:00
Andrew Toskin
e80e9c6b06
getopt isn't used anymore, and getent itself is optional.
getopt doesn't work very well in the BSDs, and getent has plenty of
fallbacks to replace it when it's not available.

<https://github.com/terrycloth/fish-shell/commit/
47a768ceeaef1d702624802d83338edbcc0f377c#commitcomment-23613921>
2017-08-12 22:40:48 -07:00
Mahmoud Al-Qudsi
fefd1c7991 Silence unused result warnings on newer compilers
Newer versions of GCC and Clang are not satisfied by a cast to void,
this fix is adapted from glibc's solution.

New wrapper function ignore_result should be used when a function with
explicit _unused_attribute_ wrapper is called whose result will not be
handled.
2017-08-12 09:54:26 -05:00
Andrew Toskin
47a768ceea
Really spell out the last of the required UNIX utilities.
Finishing the job started in Pull Request #4301

<https://github.com/fish-shell/fish-shell/pull/4301>

Thanks to @faho for filtering and sorting my giant list of detected
possible commands.

<https://github.com/fish-shell/fish-shell/issues/2062#issuecomment-321788080>
2017-08-12 00:56:13 -07:00
David Adam
d40667bf26 Revert "configure: check that errno is threadsafe"
This reverts commit ee15f1b9877834f49342a7bd93457e423eeb2cb4.

The test relies on undefined behaviour (checking for errno in the
absence of an error condition) and was broken on OpenBSD.

Closes #4184.
2017-08-12 14:26:40 +08:00
David Adam
0a23d615f4 docs: update language in read documentation 2017-08-12 12:20:49 +08:00
sentriz
44ef6cc87f Check for affirmative answer 2017-08-11 19:16:47 -07:00
sentriz
4cf480a1a5 Accept return as a valid answer to 'Edit the file again?' 2017-08-11 19:09:03 -07:00
Kurtis Rader
3df8643c31 make missing_var a singleton
Make the `env_var_t::missing_var()` object a singleton rather than a
dynamically constructed object. This requires some discipline in its use
since C++ doesn't directly support immutable objects. But it is slightly
more efficient and helps identify code that incorrectly mutates `env_var_t`
objects that should not be modified.
2017-08-11 15:51:42 -07:00
Kurtis Rader
6e7956a413 change order of env_set() args
It's bugged me forever that the scope is the second arg to `env_get()`
but not `env_set()`. And since I'll be introducing some helper functions
that wrap `env_set()` now is a good time to change the order of its
arguments.
2017-08-11 15:51:42 -07:00
Kurtis Rader
751d5503a1 Merge branch 'master' into major 2017-08-11 15:51:27 -07:00
Mahmoud Al-Qudsi
67f7e53237 Ignore more invalid arguments from parsed man pages
Specifically closes #4313.
Not being as agressive in what we ignore/blacklist, but can be revisited
easily in the future to add more characters to the argument blacklist.
2017-08-11 13:54:41 -05:00
Mahmoud Al-Qudsi
d09d2ca9ca Ignore more invalid arguments from parsed man pages
Specifically closes #4313.
Not being as agressive in what we ignore/blacklist, but can be revisited
easily in the future to add more characters to the argument blacklist.
2017-08-11 13:51:28 -05:00
Fabian Homborg
219c7ec812 help: Fix error if no argument is given 2017-08-11 18:27:58 +02:00
Fabian Homborg
4dbb274d8a Clarify docs on $status with and/or/begin/end
See #4311.
2017-08-11 15:06:03 +02:00
Andrew Toskin
e27855b225 Clarify dependencies: required vs optional, and build vs runtime. (#4301)
* Clarify dependencies: required vs optional, and build vs runtime.

A first pass at updating the dependency documentation, based on the
discussion in this thread:
https://github.com/fish-shell/fish-shell/issues/2062

* Clarify notes on dependency errors, tests, and VCS integration.

An optional feature that suggests you install Python is okay;
core-dumping is not.

The note on tests was about fish development tests, not the `test`
builtin for conditional syntax.

Specifically mention git, hg, and svn in the VCS section.
2017-08-11 12:52:38 +02:00
Andrew Toskin
101926a8e8
Clarify notes on dependency errors, tests, and VCS integration.
An optional feature that suggests you install Python is okay;
core-dumping is not.

The note on tests was about fish development tests, not the `test`
builtin for conditional syntax.

Specifically mention git, hg, and svn in the VCS section.
2017-08-10 23:03:51 -07:00