mirror of
https://github.com/fish-shell/fish-shell.git
synced 2024-11-23 13:33:02 +08:00
5b706faa73
If it can't recognize the DE, xdg-open uses a "generic" way of opening things where it doesn't spawn off a DE-provided utility like kde-open. This sounds great, but it fails to fork and therefore blocks the terminal. So we start it in the background and disown it. Fixes #7215.
41 lines
1.3 KiB
Fish
41 lines
1.3 KiB
Fish
#
|
|
# This allows us to use 'open FILENAME' to open a given file in the default
|
|
# application for the file.
|
|
#
|
|
if not command -sq open
|
|
function open --description "Open file in default application"
|
|
set -l options h/help
|
|
argparse -n open $options -- $argv
|
|
or return
|
|
|
|
if set -q _flag_help
|
|
__fish_print_help open
|
|
return 0
|
|
end
|
|
|
|
if not set -q argv[1]
|
|
printf (_ "%ls: Expected at least %d args, got only %d\n") open 1 0
|
|
return 1
|
|
end
|
|
|
|
if type -q -f cygstart
|
|
for i in $argv
|
|
cygstart $i
|
|
end
|
|
else if type -q -f xdg-open
|
|
for i in $argv
|
|
# In the "generic" path where it doesn't use a helper utility,
|
|
# xdg-open fails to fork off, so it blocks the terminal.
|
|
xdg-open $i &
|
|
# Note: We *need* to pass $last_pid, or it will disown the last *existing* job.
|
|
# In case xdg-open forks, that would be whatever else the user has backgrounded.
|
|
#
|
|
# Yes, this has a (hopefully theoretical) race of the PID being recycled.
|
|
disown $last_pid 2>/dev/null
|
|
end
|
|
else
|
|
echo (_ 'No open utility found. Try installing "xdg-open" or "xdg-utils".')
|
|
end
|
|
end
|
|
end
|