github-mirror/framework
github-mirror/framework
2
0
Fork 0
mirror of https://github.com/flarum/framework.git synced 2025-04-02 23:19:04 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Installer: Get rid of an instance variable

Browse Source 
Leftover from PR #1405.
This commit is contained in:
Franz Liedke 2018-07-16 00:33:32 +02:00
parent 084b4a8cc3
commit 1c152a7265
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
framework/core/src/Install/Console/InstallCommand.php
View File

@ -138,7 +138,6 @@ class InstallCommand extends AbstractCommand
protected function install() protected function install()
{ {
try { try {
$this->debug = $this->dataSource->isDebugMode();
$this->dbConfig = $this->dataSource->getDatabaseConfiguration(); $this->dbConfig = $this->dataSource->getDatabaseConfiguration();
$validation = $this->getValidator()->make( $validation = $this->getValidator()->make(
@ -177,7 +176,7 @@ class InstallCommand extends AbstractCommand
throw new Exception('Username can only contain letters, numbers, underscores, and dashes.'); throw new Exception('Username can only contain letters, numbers, underscores, and dashes.');
} }
$this->storeConfiguration(); $this->storeConfiguration($this->dataSource->isDebugMode());
$resolver = $this->application->make(ConnectionResolverInterface::class); $resolver = $this->application->make(ConnectionResolverInterface::class);
AbstractModel::setConnectionResolver($resolver); AbstractModel::setConnectionResolver($resolver);
@ -210,12 +209,12 @@ class InstallCommand extends AbstractCommand
} }
} }
protected function storeConfiguration() protected function storeConfiguration(bool $debugMode)
{ {
$dbConfig = $this->dbConfig; $dbConfig = $this->dbConfig;
$config = [ $config = [
'debug' => $this->debug, 'debug' => $debugMode,
'database' => [ 'database' => [
'driver' => $dbConfig['driver'], 'driver' => $dbConfig['driver'],
'host' => $dbConfig['host'], 'host' => $dbConfig['host'],