Toby Zerner
309bb21ffe
Drastically improve search performance
...
The previous approach of joining the posts table into the main search
query was not scaling well. Searches on discuss.flarum.org were taking
~1.5 seconds which – a significant improvement over the pre-beta 8
search, but still not acceptable.
This new approach uses a much more efficient subquery join. Searches
on discuss.flarum.org now take mere milliseconds. The search result
ranking strategy has been further refined as well so that discussions
are ranked by the collective relevance of their posts.
2018-11-14 11:19:39 +10:30
Toby Zerner
c0286bb4a3
Allow users to hide their own posts just as they can edit them
...
This fixes a regression introduced by #1466 .
2018-11-14 09:33:28 +10:30
flarum-bot
83d7a73ccb
Bundled output for commit 90bb012ab8
[skip ci]
2018-11-13 21:41:20 +00:00
David Sevilla Martín
90bb012ab8
Move EditUserModal fields into an ItemList to make more extendable ( #1593 )
2018-11-14 08:00:43 +10:30
Toby Zerner
0f05ecbbc6
Fix incorrect regex modifier, causing JS to become malformed is some cases
2018-11-14 06:45:14 +10:30
Franz Liedke
2762da9384
Merge pull request #1633 from flarum/tz/improve-logging
...
Improve logging
2018-11-13 11:03:24 +01:00
Toby Zerner
2a5f524980
Remove fileinfo dependency
...
As per https://github.com/flarum/docs/issues/14#issuecomment-365972062
2018-11-13 17:16:47 +10:30
Toby Zerner
3ab7da66c8
Log errors when debug mode is on too
2018-11-13 07:47:01 +10:30
flarum-bot
e3d01c5e94
Bundled output for commit b1e2322581
[skip ci]
2018-11-12 10:35:23 +00:00
Toby Zerner
b1e2322581
Trigger input event when text is programmatically inserted
2018-11-12 17:21:37 +10:30
Toby Zerner
b49774d0e2
Add a toolbar area to the TextEditor component
...
This is to be used for formatting buttons and the like. Although it is
displayed in the controls area at the moment, it is conceptually
different and may be relocated to the top of the text editor in the
future.
2018-11-12 17:21:15 +10:30
Toby Zerner
a6a4cf3fbc
Improve appearance of text editor buttons
...
- Change preview icon to Font Awesome Regular instead of Solid
- Give the preview button a tooltip
- Change submit button icon to paper plane (shown on mobile)
- Tweak mobile header button touch target
- Scroll overflowing text editor controls horizontally
2018-11-12 17:19:37 +10:30
flarum-bot
4718bf4d81
Bundled output for commit b6f37526a3
[skip ci]
2018-11-12 01:14:08 +00:00
Toby Zerner
b6f37526a3
Merge pull request #1634 from clarkwinkelmann/fix-scrubber-index
...
Fix scrubber index exceeding post count
2018-11-12 11:40:29 +10:30
Clark Winkelmann
8250584ba7
Fix notification isRead value not being updated in API update response ( #1635 )
2018-11-12 00:14:13 +01:00
Toby Zerner
ac63665f8b
Boot new application instance before enabling extensions. fixes #1587 ( #1631 )
2018-11-12 00:01:17 +01:00
Franz Liedke
f346a51748
Remove unused default constructor
2018-11-11 23:52:47 +01:00
Clark Winkelmann
3d1578b89a
Clean PostStreamScrubber code
2018-11-11 19:03:22 +01:00
Clark Winkelmann
87f94e64e4
Fix scrubber index not limited to max items count when bypassing view()
2018-11-11 19:00:51 +01:00
Toby Zerner
95944e3630
Log errors that occur in the API stack
...
This takes place only in the FallbackExceptionHandler. Having a custom
exception handler implies that a friendly message is displayed in the
API response, in which case we can bet that the exception won't need to
be "debugged" per se.
2018-11-11 18:00:57 +10:30
Toby Zerner
4302687876
Stop logging errors that use a custom view
...
Having a custom view implies that a friendly message is displayed to
the user, in which case we can bet that the exception won't need to be
"debugged" per se.
2018-11-11 17:57:55 +10:30
Toby Zerner
2df5be7bcb
Catch Throwables so that we handle internal PHP errors too
2018-11-11 17:54:19 +10:30
flarum-bot
91e8d6820a
Bundled output for commit d9037fe472
[skip ci]
2018-11-11 06:35:34 +00:00
Toby Zerner
278bbd992b
Apply fixes from StyleCI ( #1632 )
...
[ci skip] [skip ci]
2018-11-11 17:01:34 +10:30
Toby Zerner
d9037fe472
Delete associated notifications when deleting discussions, posts, and users. fixes #1380
2018-11-11 16:59:24 +10:30
Toby Zerner
0e5c3aff1a
Perform visibility checks on notification subjects at the query level
...
This will prevent a notification from being seen by a user if its
subject is deleted or undergoes some kind of permission change (eg.
a discussion is moved into a private tag)
ref #1380
2018-11-11 16:58:08 +10:30
Toby Zerner
9b013a4136
Consolidate Post visibility logic into the PostPolicy
...
A post can only be seen if the discussion in which it resides can be
seen. The logic for this belongs in the policy, not the model.
2018-11-11 16:54:15 +10:30
Toby Zerner
e02b18d08e
Fix notification list not displaying "empty" message
2018-11-11 16:46:54 +10:30
Toby Zerner
b68f183e86
Always allow users to see their own account. fixes #1626
2018-11-11 14:25:21 +10:30
Franz Liedke
ebcc173496
Fix leak of private information when updating users
...
Fixes #1628 .
2018-11-09 12:02:26 +01:00
Franz Liedke
fad8ed335d
Add regression test for email crawling vulnerability
...
Refs #1628 .
2018-11-09 12:02:26 +01:00
Franz Liedke
99f9ec45f1
Move trait to base test class
...
This way, its properties can be overwritten in subclasses of
`ApiControllerTestCase`. This isn't allowed when those subclasses
use the trait directly.
2018-11-09 12:02:21 +01:00
Daniël Klabbers
f41ae92f1a
add security address in issue template as well ( #1630 )
...
as per suggestion by @CDK2020, let's also add an important statement in the issue template
2018-11-09 10:02:20 +01:00
Daniël Klabbers
ee386b8899
add security email address in flarum/core readme ( #1629 )
...
Let's make the security email address even more visible.
2018-11-08 23:41:51 +01:00
Daniël Klabbers
33b39137b9
[b8] master token fix ( #1622 )
...
* fixed not being able to use master token because id column no longer holds key
* added flexibility of user_id column
* added tests to confirm the api keys actually work as intended
2018-11-07 22:34:09 +01:00
flarum-bot
4eafba9189
Bundled output for commit 8e5099711f
[skip ci]
2018-11-07 21:20:16 +00:00
Franz Liedke
537e61ba00
Restore horizontal overflow for permission grid
...
Refs #1627 .
2018-11-07 22:17:16 +01:00
Clark Winkelmann
8e5099711f
Use ItemList for EditGroupModal fields ( #1625 )
2018-11-07 22:15:19 +01:00
David Sevilla Martín
e1dc724333
Remove overflow from .PermissionsPage-permissions ( #1627 )
2018-11-06 22:41:21 +01:00
Toby Zerner
1f2c24e404
Merge pull request #1623 from flarum/luceos-patch-1
...
Update AccessToken.php
2018-11-02 07:12:23 +10:30
Daniël Klabbers
dba160b9f1
Update AccessToken.php
...
Fixes phpdoc while working on #1622
2018-11-01 10:56:45 +01:00
flarum-bot
38259d2cd5
Bundled output for commit ddeb005a7a
[skip ci]
2018-10-31 13:35:47 +00:00
Daniël Klabbers
ddeb005a7a
Update EditGroupModal.js
...
fixed placeholder icon name fa 4 style to fa 5 style with `fas fa-bolt`
2018-10-31 14:28:50 +01:00
Daniël Klabbers
b64cdb1cfe
fixes author gambit when used with fulltext search, added test to cover ( #1620 )
...
* fixes author gambit when used with fulltext search, added test to cover
* Apply fixes from StyleCI
[ci skip] [skip ci]
2018-10-29 23:01:25 +01:00
flarum-bot
ac5a6349e4
Bundled output for commit 9b24edc391
[skip ci]
2018-10-28 21:00:22 +00:00
Toby Zerner
9b24edc391
Fix regression in admin routing in subdirectory. fixes #1606
...
Because admin routing uses the "hash" strategy, the base path does not
need to be taken into account.
2018-10-29 07:25:17 +10:30
Franz Liedke
5ad2a5a842
Fix installation in subdirectory
...
Fixes #1604 .
2018-10-26 00:27:35 +02:00
Franz Liedke
194808ec7c
Fix tests
2018-10-24 22:38:47 +02:00
Franz Liedke
196a4f6e65
Apply fixes from StyleCI ( #1616 )
...
[ci skip] [skip ci]
2018-10-24 22:20:15 +02:00
Franz Liedke
28eb5f27f2
Allow setting all paths when instantiating Site
...
Fixes #1592 .
2018-10-24 22:19:09 +02:00