Contributions of patches to Oh My Fish are very welcome, and should be made through the Pull Request mechanism via Github. Although this page explains the steps that a pull request goes through, note that this is primarily just an organisational structure and not a rigid set of rules.
Submission
When submitted, the pull request will automatically notify members of the organisation: a.k.a the core team. Members of the core team must also pull requests to submit patches.
Pulls must always follow code style, employ good english and be well separated in logical commits. If a pull don't pass this requirements, core team can impose a veto on the merge --- accompanied with specific feedback as to why the pull would be bad to accept.
Pull requests are public, where reviews and feedback can be provided by anyone! But prior to merging a pull requests, a certain number of 👍 from the core team may be required, depending whether the change impacts the framework. Generally, code that has general in scope require 2 👍 (2 should be treated as default) to be accepted.
Other changes that requires 👍 from core team:
| Change type |
At least 👍s |
| Design |
3 |
| Command line |
3 |
| Plugin inclusion |
2 |
| Naming |
2 |